| *** ashleighfarnham has joined #openstack-trove | 00:19 | |
| *** haomaiwa_ has quit IRC | 00:39 | |
| *** ashleighfarnham has quit IRC | 00:53 | |
| *** erkules_ has joined #openstack-trove | 01:42 | |
| *** erkules has quit IRC | 01:45 | |
| *** coolsvapl is now known as coolsvap | 03:22 | |
| *** haomaiwang has joined #openstack-trove | 03:38 | |
| *** eghobo has joined #openstack-trove | 04:10 | |
| *** masco has joined #openstack-trove | 04:14 | |
| *** sgotliv has joined #openstack-trove | 04:44 | |
| *** erkules_ is now known as erkules | 05:06 | |
| *** erkules has joined #openstack-trove | 05:06 | |
| *** ashleighfarnham has joined #openstack-trove | 05:34 | |
| *** ashleighfarnham has quit IRC | 05:39 | |
| *** sgotliv has quit IRC | 05:59 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/trove: Imported Translations from Transifex https://review.openstack.org/179633 | 06:04 |
|---|---|---|
| *** ashleighfarnham has joined #openstack-trove | 07:24 | |
| *** ashleighfarnham has quit IRC | 07:28 | |
| *** eghobo has quit IRC | 07:29 | |
| *** chlong has quit IRC | 07:37 | |
| openstackgerrit | Sushil Kumar proposed openstack/trove: Added more unit-tests to taskmanager https://review.openstack.org/179355 | 08:14 |
| *** tlashchova has joined #openstack-trove | 08:50 | |
| *** ashleighfarnham has joined #openstack-trove | 09:13 | |
| *** ashleighfarnham has quit IRC | 09:17 | |
| *** sgotliv has joined #openstack-trove | 09:19 | |
| *** jpena has joined #openstack-trove | 09:43 | |
| *** IanGovett has joined #openstack-trove | 10:21 | |
| *** exploreshaifali has joined #openstack-trove | 10:40 | |
| *** exploreshaifali has quit IRC | 10:59 | |
| *** ashleighfarnham has joined #openstack-trove | 11:01 | |
| *** ashleighfarnham has quit IRC | 11:06 | |
| *** Longgeek has joined #openstack-trove | 11:15 | |
| *** jpena is now known as jpena|lunch | 11:20 | |
| *** sgotliv has quit IRC | 11:25 | |
| *** sgotliv has joined #openstack-trove | 11:49 | |
| *** exploreshaifali has joined #openstack-trove | 11:56 | |
| *** sgotliv has quit IRC | 11:59 | |
| *** exploreshaifali has quit IRC | 12:00 | |
| *** exploreshaifali has joined #openstack-trove | 12:00 | |
| *** sgotliv has joined #openstack-trove | 12:01 | |
| *** exploreshaifali has quit IRC | 12:03 | |
| *** exploreshaifali has joined #openstack-trove | 12:03 | |
| *** exploreshaifali has quit IRC | 12:07 | |
| *** exploreshaifali has joined #openstack-trove | 12:08 | |
| *** exploreshaifali has quit IRC | 12:08 | |
| *** dencaval has joined #openstack-trove | 12:11 | |
| *** exploreshaifali has joined #openstack-trove | 12:15 | |
| *** exploreshaifali has quit IRC | 12:17 | |
| *** exploreshaifali has joined #openstack-trove | 12:18 | |
| *** shakamunyi has quit IRC | 12:18 | |
| *** exploreshaifali has quit IRC | 12:19 | |
| *** ashleighfarnham has joined #openstack-trove | 12:19 | |
| *** exploreshaifali has joined #openstack-trove | 12:20 | |
| *** exploreshaifali has quit IRC | 12:21 | |
| *** jpena|lunch is now known as jpena | 12:23 | |
| *** ashleighfarnham has quit IRC | 12:24 | |
| *** radez_g0n3 is now known as radez | 12:44 | |
| jpena | hi everyone, I think I'm hitting https://bugs.launchpad.net/trove/+bug/1402055 (RDO Kilo RC2 preview), can anyone give me any hints on how to troubleshoot it? | 12:48 |
| openstack | Launchpad bug 1402055 in Trove "Trove-taskmanager fails to start if urls obtained from Keystone" [Medium,New] - Assigned to Nikhil Manchanda (slicknik) | 12:48 |
| *** exploreshaifali has joined #openstack-trove | 12:48 | |
| *** exploreshaifali has quit IRC | 12:51 | |
| *** exploreshaifali has joined #openstack-trove | 12:52 | |
| *** links has joined #openstack-trove | 12:56 | |
| *** exploreshaifali has quit IRC | 12:57 | |
| *** exploreshaifali has joined #openstack-trove | 12:57 | |
| *** exploreshaifali has quit IRC | 12:59 | |
| *** exploreshaifali has joined #openstack-trove | 13:00 | |
| *** exploreshaifali has quit IRC | 13:00 | |
| *** coolsvap is now known as coolsvap|afk | 13:37 | |
| *** chlong has joined #openstack-trove | 13:57 | |
| *** mattgriffin has joined #openstack-trove | 14:01 | |
| *** ashleighfarnham has joined #openstack-trove | 14:08 | |
| *** chlong has quit IRC | 14:08 | |
| *** ashleighfarnham has quit IRC | 14:13 | |
| *** exploreshaifali has joined #openstack-trove | 14:19 | |
| *** georgelorch has joined #openstack-trove | 14:20 | |
| *** masco has quit IRC | 14:22 | |
| *** jpena has quit IRC | 14:22 | |
| *** chlong has joined #openstack-trove | 14:26 | |
| *** sriram_tesora has joined #openstack-trove | 14:44 | |
| *** shayneburgess has quit IRC | 14:49 | |
| *** jpena has joined #openstack-trove | 14:49 | |
| *** links has quit IRC | 14:56 | |
| *** ashleighfarnham has joined #openstack-trove | 15:29 | |
| sushilkm | hello pmali peterstac | 15:31 |
| openstackgerrit | Merged openstack/trove: Fixes the unsafe mocking in test_dbaas https://review.openstack.org/179372 | 15:33 |
| peterstac | hi sushilkm | 15:34 |
| pmalik | o/ | 15:35 |
| sushilkm | wanted to know about https://review.openstack.org/#/c/176989/ | 15:37 |
| sushilkm | how are we using this patchset to find dangling mocks | 15:37 |
| sushilkm | what is the role of trove/tests/unittests/trove_testtools.py | 15:37 |
| *** Longgeek_ has joined #openstack-trove | 15:40 | |
| *** shayneburgess has joined #openstack-trove | 15:41 | |
| *** Longgeek has quit IRC | 15:42 | |
| peterstac | sushilkm: right now we're not using it ;) | 15:43 |
| peterstac | sushilkm: it has to be merged first | 15:43 |
| sushilkm | hehehe | 15:44 |
| sushilkm | ok, but after merge do we run a separate job for the detection or how | 15:44 |
| pmalik | ok, so the trove_testtools module provides a base TestCase class. That class extends the testtools.TestCase. You just need to replace the test's base class with this one and run it. | 15:44 |
| *** cweid has quit IRC | 15:45 | |
| *** jpena has quit IRC | 15:45 | |
| peterstac | sushilkm: there are a couple of files fixed in the patchset - you can see how it works there | 15:46 |
| pmalik | No, that would not make sense - it would be failing all the time. You just pick a test suite (module) and replace its base class. Then run it locally using tox and fix the identified problems. Once everything is fixed you push it up for review. :-) | 15:46 |
| sushilkm | so, by just using trove_testtools.TestCase instead of testtools.TestCase it would find dangling mocks | 15:46 |
| pmalik | Yes. | 15:46 |
| peterstac | sushilkm: yes | 15:46 |
| sushilkm | so let us take an example, u remember the comment i posted https://review.openstack.org/#/c/164034/19/trove/tests/unittests/guestagent/test_volume.py | 15:49 |
| sushilkm | https://github.com/openstack/trove/blob/master/trove/tests/unittests/guestagent/test_volume.py#L196 is inherited from trove_testtools then it would show that problem | 15:50 |
| sushilkm | ok let me try this once :) | 15:51 |
| peterstac | sushilkm: before you start reinventing the wheel, make sure the work hasn't been done :) | 15:53 |
| sushilkm | yeah sure but first i wanted to understand how it works | 15:53 |
| pmalik | sushilkm: There has been an Etherpad page where you can sign up for modules. You can grab something from there. It is in the comments under the mocking patch set. :-) | 15:54 |
| sushilkm | cool | 15:54 |
| sushilkm | or rather i can experience that simply by modifying ur patch too on my local box | 15:55 |
| sushilkm | https://review.openstack.org/#/c/176989/7/trove/tests/unittests/guestagent/test_service.py | 15:55 |
| sushilkm | it just fixes one of those dangling mocks :) | 15:55 |
| sushilkm | okay thanks, let me try this first | 15:56 |
| *** cweid has joined #openstack-trove | 15:57 | |
| *** jpena has joined #openstack-trove | 15:58 | |
| sushilkm | in the etherpad all those which have names have been worked, or u both have just assigned them to start on them :) | 15:58 |
| *** ashleighfarnham has quit IRC | 15:59 | |
| *** eghobo has joined #openstack-trove | 16:00 | |
| *** eghobo has quit IRC | 16:00 | |
| *** sgotliv has quit IRC | 16:01 | |
| peterstac | sushilkm: most of the work is already done, just waiting for the base patchset to merge | 16:03 |
| sushilkm | okies, awesome | 16:03 |
| sushilkm | :) | 16:03 |
| sushilkm | yeah just tried an execution, it helps greatly | 16:04 |
| sushilkm | the patchset :) | 16:04 |
| *** eghobo has joined #openstack-trove | 16:08 | |
| sushilkm | what about those which dont have the name assigned to them, are they worked or they r free for others to be picked up ;) | 16:12 |
| *** eghobo has quit IRC | 16:14 | |
| *** ashleighfarnham has joined #openstack-trove | 16:14 | |
| *** eghobo has joined #openstack-trove | 16:17 | |
| peterstac | sushilkm: they're free to be worked on - just put your nick beside the one you're doing so we don't double up | 16:18 |
| sushilkm | ok thanks peterstac | 16:20 |
| peterstac | sushilkm: np | 16:21 |
| *** masco has joined #openstack-trove | 16:40 | |
| *** cweid has quit IRC | 16:45 | |
| *** cweid has joined #openstack-trove | 16:47 | |
| *** jpena has quit IRC | 16:51 | |
| *** mattgriffin has quit IRC | 16:53 | |
| *** mattgriffin has joined #openstack-trove | 17:07 | |
| *** Longgeek_ has quit IRC | 17:10 | |
| openstackgerrit | Merged openstack/trove: Imported Translations from Transifex https://review.openstack.org/179633 | 17:13 |
| *** masco has quit IRC | 17:13 | |
| *** IanGovett has quit IRC | 17:31 | |
| *** IanGovett has joined #openstack-trove | 17:31 | |
| *** sgotliv has joined #openstack-trove | 17:40 | |
| *** sgotliv has quit IRC | 17:55 | |
| *** mattgriffin has quit IRC | 17:56 | |
| *** chlong has quit IRC | 18:02 | |
| *** exploreshaifali has quit IRC | 18:03 | |
| *** exploreshaifali has joined #openstack-trove | 18:03 | |
| *** exploreshaifali_ has joined #openstack-trove | 18:03 | |
| *** exploreshaifali has quit IRC | 18:04 | |
| *** exploreshaifali_ has quit IRC | 18:04 | |
| *** exploreshaifali has joined #openstack-trove | 18:04 | |
| *** exploreshaifali has quit IRC | 18:13 | |
| *** chlong has joined #openstack-trove | 18:14 | |
| *** sgotliv has joined #openstack-trove | 18:36 | |
| *** sgotliv has quit IRC | 18:36 | |
| *** sgotliv has joined #openstack-trove | 18:36 | |
| *** mattf is now known as _mattf | 18:37 | |
| *** mattgriffin has joined #openstack-trove | 18:39 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-troveclient: Updated from global requirements https://review.openstack.org/179873 | 18:51 |
| *** IanGovett1 has joined #openstack-trove | 18:52 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/trove: Updated from global requirements https://review.openstack.org/179879 | 18:52 |
| *** IanGovett has quit IRC | 18:54 | |
| pmalik | Hello. Any of the cores wants to take a look at the mock leak detector patch set? It has been sitting there for a while, still needing one last +2. Thanks. https://review.openstack.org/#/c/176989/ | 18:58 |
| *** radez is now known as radez_g0n3 | 19:01 | |
| *** sgotliv_ has joined #openstack-trove | 19:04 | |
| pmalik | ^^^^^ amrith, vkmc, SlickNik, edmondk | 19:05 |
| *** sgotliv has quit IRC | 19:05 | |
| *** chlong has quit IRC | 19:07 | |
| *** eghobo has quit IRC | 19:15 | |
| *** mattgriffin has quit IRC | 19:38 | |
| *** mattgriffin has joined #openstack-trove | 19:42 | |
| *** dencaval has quit IRC | 19:45 | |
| *** mattgriffin has quit IRC | 19:51 | |
| *** eghobo has joined #openstack-trove | 20:03 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-troveclient: Updated from global requirements https://review.openstack.org/179873 | 20:09 |
| *** radez_g0n3 is now known as radez | 20:14 | |
| *** mattgriffin has joined #openstack-trove | 20:16 | |
| *** zacksh has quit IRC | 20:24 | |
| *** zacksh has joined #openstack-trove | 20:25 | |
| *** sriram_ has joined #openstack-trove | 20:29 | |
| *** exploreshaifali has joined #openstack-trove | 20:29 | |
| *** zacksh has quit IRC | 20:31 | |
| *** sriram_tesora has quit IRC | 20:32 | |
| *** PeterSchwaller has joined #openstack-trove | 20:33 | |
| *** zacksh has joined #openstack-trove | 20:33 | |
| *** bhunter has quit IRC | 20:34 | |
| *** PeterSchwaller_ has quit IRC | 20:36 | |
| *** bhunter has joined #openstack-trove | 20:36 | |
| *** mattgrif_ has joined #openstack-trove | 20:37 | |
| *** mattgriffin has quit IRC | 20:40 | |
| *** exploreshaifali has quit IRC | 20:51 | |
| *** radez is now known as radez_g0n3 | 21:25 | |
| vkmc | pmalik, if you are around, could you clarify the import ordering in the mock leak detector patch set? | 21:41 |
| pmalik | You mean 'test_service.py'? | 21:42 |
| pmalik | vkmc: It's a mistake, I will put them into alphabetical order, now. | 21:44 |
| vkmc | pmalik, sure, np | 21:45 |
| vkmc | I wonder why pep8 passed | 21:45 |
| vkmc | the gate should catch those, right? | 21:45 |
| peterstac | vkmc: I don't think we have that pep8 enabled - I've seen too many out-of-order imports | 21:45 |
| vkmc | hmm | 21:46 |
| vkmc | there is a pep8 gate though | 21:46 |
| peterstac | yes, but the hacking rule for ordering imports and multi-imports is ignored (H301 and H306) | 21:53 |
| openstackgerrit | Petr Malik proposed openstack/trove: Implement dangling mock detector for unittests https://review.openstack.org/176989 | 21:54 |
| vkmc | peterstac, it makes sense now | 21:57 |
| pmalik | vkmc: done :-) | 21:58 |
| vkmc | pmalik, thx :) | 21:58 |
| *** mattgrif_ has quit IRC | 21:59 | |
| *** flwang has joined #openstack-trove | 21:59 | |
| *** IanGovett1 has quit IRC | 22:47 | |
| *** eghobo_ has joined #openstack-trove | 23:02 | |
| *** eghobo has quit IRC | 23:06 | |
| *** eghobo_ has quit IRC | 23:12 | |
| *** eghobo has joined #openstack-trove | 23:22 | |
| *** chlong has joined #openstack-trove | 23:30 | |
| *** IanGovett has joined #openstack-trove | 23:35 | |
| *** ashleighfarnham has quit IRC | 23:51 | |
| *** IanGovett has quit IRC | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!