*** mattgriffin has joined #openstack-trove | 00:01 | |
*** IanGovett has quit IRC | 00:15 | |
*** sriram_tesora has quit IRC | 00:25 | |
*** mattgriffin has quit IRC | 00:31 | |
*** radez is now known as radez_g0n3 | 00:54 | |
*** Riddhi_ has quit IRC | 01:06 | |
*** Riddhi has joined #openstack-trove | 01:06 | |
*** Riddhi has quit IRC | 01:10 | |
*** danritchie has quit IRC | 01:11 | |
*** shayneburgess has quit IRC | 01:33 | |
*** X019 has quit IRC | 01:39 | |
*** danritchie has joined #openstack-trove | 01:51 | |
*** IanGovett has joined #openstack-trove | 01:58 | |
*** erkules_ has joined #openstack-trove | 02:03 | |
*** IanGovett has quit IRC | 02:04 | |
*** erkules has quit IRC | 02:05 | |
*** david-lyle is now known as david-lyle_afk | 02:10 | |
*** Longgeek has quit IRC | 02:11 | |
*** haomaiwang has joined #openstack-trove | 02:11 | |
*** pmackinn has quit IRC | 02:42 | |
*** danritchie has quit IRC | 02:51 | |
*** erkules has joined #openstack-trove | 03:00 | |
*** erkules_ has quit IRC | 03:03 | |
*** X019 has joined #openstack-trove | 03:18 | |
*** Riddhi has joined #openstack-trove | 03:34 | |
*** Riddhi has quit IRC | 03:49 | |
*** Riddhi has joined #openstack-trove | 03:51 | |
*** Riddhi has quit IRC | 03:55 | |
*** Riddhi has joined #openstack-trove | 03:56 | |
*** Riddhi has quit IRC | 04:08 | |
*** Riddhi has joined #openstack-trove | 04:08 | |
*** Riddhi has quit IRC | 04:19 | |
*** danritchie has joined #openstack-trove | 04:40 | |
*** danritchie has quit IRC | 04:44 | |
*** newb has quit IRC | 04:45 | |
*** esp has left #openstack-trove | 04:52 | |
*** nosnos has joined #openstack-trove | 05:10 | |
*** flwang has quit IRC | 05:11 | |
*** ajayaa has joined #openstack-trove | 05:32 | |
*** sgotliv has joined #openstack-trove | 05:54 | |
*** ajayaa has quit IRC | 06:05 | |
*** k4n0 has joined #openstack-trove | 06:10 | |
*** vigneshvar has joined #openstack-trove | 06:52 | |
*** ajayaa has joined #openstack-trove | 07:51 | |
*** pcaruana has joined #openstack-trove | 07:56 | |
*** romainh has joined #openstack-trove | 08:33 | |
*** ajayaa has quit IRC | 08:40 | |
*** exploreshaifali has joined #openstack-trove | 08:44 | |
*** boblebauce has joined #openstack-trove | 08:56 | |
*** romainh1 has joined #openstack-trove | 10:19 | |
*** romainh has quit IRC | 10:19 | |
openstackgerrit | ramesh-sahu proposed openstack/trove: Adds "devstack.rst" doc for Trove Installation with Devstack https://review.openstack.org/142717 | 10:24 |
---|---|---|
*** ajayaa has joined #openstack-trove | 10:36 | |
openstackgerrit | Sushil Kumar proposed openstack/trove: Corrects list_database query for MySQL https://review.openstack.org/142719 | 10:37 |
*** tlashchova has quit IRC | 10:57 | |
*** haomaiwang has quit IRC | 11:08 | |
*** boblebauce has quit IRC | 11:16 | |
*** nosnos has quit IRC | 11:26 | |
*** nosnos has joined #openstack-trove | 11:26 | |
*** nosnos has quit IRC | 11:30 | |
*** nosnos has joined #openstack-trove | 11:39 | |
*** exploreshaifali has quit IRC | 11:47 | |
*** danritchie has joined #openstack-trove | 11:55 | |
*** danritchie has quit IRC | 12:00 | |
*** Longgeek has joined #openstack-trove | 12:06 | |
*** vkmc has joined #openstack-trove | 12:22 | |
openstackgerrit | Sushil Kumar proposed openstack/trove: Strips '.' from re-raised exception message https://review.openstack.org/142759 | 12:32 |
*** Longgeek has quit IRC | 12:33 | |
*** Longgeek has joined #openstack-trove | 12:33 | |
*** IanGovett has joined #openstack-trove | 12:37 | |
*** pboros has joined #openstack-trove | 12:40 | |
openstackgerrit | Sushil Kumar proposed openstack/trove: Fixes package configuration method in pkg.py https://review.openstack.org/141767 | 13:02 |
*** nosnos has quit IRC | 13:05 | |
*** nosnos has joined #openstack-trove | 13:06 | |
*** pboros has quit IRC | 13:06 | |
*** pboros has joined #openstack-trove | 13:08 | |
*** nosnos has quit IRC | 13:10 | |
*** amrith is now known as _amrith_ | 13:21 | |
*** sgotliv has quit IRC | 13:34 | |
*** Longgeek has quit IRC | 13:44 | |
*** Longgeek has joined #openstack-trove | 13:45 | |
*** ajayaa has quit IRC | 13:53 | |
*** isviridov_away is now known as isviridov | 13:59 | |
*** pmackinn has joined #openstack-trove | 13:59 | |
vkmc | _amrith_, when you have a moment, I wanted to ask you about this change https://review.openstack.org/#/c/141090/6/openstack-common.conf | 14:04 |
*** jcru has joined #openstack-trove | 14:08 | |
*** jcru has quit IRC | 14:09 | |
*** jcru has joined #openstack-trove | 14:09 | |
*** jcru has quit IRC | 14:10 | |
*** pboros has quit IRC | 14:10 | |
*** pboros has joined #openstack-trove | 14:11 | |
*** _mattf is now known as mattf | 14:12 | |
*** boblebauce has joined #openstack-trove | 14:13 | |
openstackgerrit | Merged openstack/trove: Adds negative test to test_instance_controller.py https://review.openstack.org/140650 | 14:17 |
*** radez_g0n3 is now known as radez | 14:18 | |
*** sgotliv has joined #openstack-trove | 14:19 | |
*** grapex has joined #openstack-trove | 14:20 | |
*** grapex_ has joined #openstack-trove | 14:21 | |
*** grapex has quit IRC | 14:21 | |
*** mattf has quit IRC | 14:22 | |
*** mattf has joined #openstack-trove | 14:22 | |
*** k4n0 has quit IRC | 14:29 | |
*** mattgriffin has joined #openstack-trove | 14:43 | |
*** _amrith_ is now known as amrith | 14:44 | |
*** johnma has quit IRC | 14:59 | |
*** johnma has joined #openstack-trove | 15:01 | |
*** pmackinn1 has joined #openstack-trove | 15:03 | |
*** pmackinn has quit IRC | 15:03 | |
*** david-lyle_afk has quit IRC | 15:07 | |
*** esp has joined #openstack-trove | 15:09 | |
*** newb has joined #openstack-trove | 15:11 | |
*** thedodd has joined #openstack-trove | 15:18 | |
*** __TheDodd__ has joined #openstack-trove | 15:22 | |
*** thedodd has quit IRC | 15:23 | |
*** Barker has joined #openstack-trove | 15:29 | |
*** __TheDodd__ is now known as thedodd | 15:31 | |
*** johnma has quit IRC | 15:35 | |
*** Riddhi has joined #openstack-trove | 15:36 | |
*** Riddhi has quit IRC | 15:37 | |
*** Riddhi has joined #openstack-trove | 15:37 | |
*** isviridov has left #openstack-trove | 15:38 | |
*** grapex has joined #openstack-trove | 15:40 | |
*** grapex_ has quit IRC | 15:43 | |
*** jmontemayor has joined #openstack-trove | 15:50 | |
*** Riddhi has quit IRC | 15:53 | |
*** vigneshvar has quit IRC | 15:55 | |
*** david-lyle has joined #openstack-trove | 16:02 | |
*** danritchie has joined #openstack-trove | 16:05 | |
*** johnma has joined #openstack-trove | 16:10 | |
amrith | vkmc, hello | 16:13 |
*** johnma_ has joined #openstack-trove | 16:13 | |
vkmc | amrith, hi! | 16:13 |
vkmc | amrith, re https://review.openstack.org/#/c/141090/6/openstack-common.conf | 16:13 |
amrith | sorry, just saw your question | 16:13 |
amrith | yes | 16:14 |
vkmc | amrith, I was wondering where fileutils, middleware and policy modules were used | 16:14 |
*** johnma has quit IRC | 16:14 | |
*** johnma_ is now known as johnma | 16:14 | |
amrith | (long answer follows) | 16:15 |
vkmc | amrith, because I saw you only updated the uses for the utils module | 16:15 |
amrith | they were not, I don't believe. what appears to have happened is this ... When modules are added and referenced in project code (i.e. trove code) that's when they should be added to openstack-common.conf. They should not be added to openstack-common.conf if there are dependencies between oslo-incubator modules. Second, when references to oslo-incubator modules are eliminated, the assumption is that the last person removes | 16:16 |
amrith | the references to openstack-common.conf. | 16:16 |
amrith | what I found is that both of these were (in some cases) not done. | 16:16 |
amrith | I found a case (don't recall which) where a change was made in openstack-common.conf for a new module and also its dependencies. | 16:17 |
amrith | second, when people change code it isn't always as part of an o-i cleanup | 16:17 |
amrith | so there was a case where progressively fewer places used a module | 16:17 |
amrith | but the last reference didn't trigger the cleanup | 16:17 |
amrith | since I was doing an oslo-incubator resync, I went and did a sweep and did this cleanup. | 16:17 |
amrith | that's the full story! | 16:17 |
amrith | the removal of things other than utils are a cleanup | 16:18 |
vkmc | oh I see | 16:18 |
vkmc | makes sense | 16:18 |
vkmc | I was grepping the code searching for those hehe | 16:18 |
amrith | think about it for a second | 16:19 |
amrith | if you have an entry in openstack-common.conf but no file in trove/openstack/common | 16:19 |
amrith | you shouldn't (hopefully) find it by grepping ;) | 16:19 |
vkmc | yeah of course | 16:19 |
amrith | hence the cleanup ... | 16:19 |
amrith | conversely, if the file is in trove/openstack/common/* but the only 'grep' results are also in trove/openstack/common | 16:20 |
amrith | then the files need not be listed in openstack-common.conf | 16:20 |
amrith | update.sh handles dependencies by itself | 16:20 |
amrith | see update.py (in oslo-incubator) | 16:21 |
amrith | and the funciton _build_dependency_tree() | 16:21 |
* vkmc looks for it | 16:21 | |
amrith | which actually scans all modules (in o-i) and builds the list of required additional modules. | 16:21 |
vkmc | thanks | 16:21 |
*** Riddhi has joined #openstack-trove | 16:22 | |
vkmc | yeah, without that it would be so painful to maintain | 16:22 |
amrith | yes | 16:23 |
vkmc | thanks for the explanation amrith :) and for working on that, of course | 16:23 |
amrith | not a problem, thanks! | 16:23 |
*** Riddhi has quit IRC | 16:28 | |
*** Riddhi has joined #openstack-trove | 16:28 | |
*** romainh1 has left #openstack-trove | 16:32 | |
*** pcaruana has quit IRC | 16:33 | |
*** exploreshaifali has joined #openstack-trove | 16:45 | |
*** exploreshaifali has quit IRC | 16:45 | |
*** exploreshaifali has joined #openstack-trove | 16:46 | |
*** exploreshaifali has quit IRC | 16:46 | |
*** exploreshaifali has joined #openstack-trove | 16:46 | |
*** vigneshvar has joined #openstack-trove | 16:47 | |
*** thedodd has quit IRC | 17:09 | |
*** thedodd has joined #openstack-trove | 17:14 | |
*** PierreRambaud has quit IRC | 17:16 | |
*** thedodd has quit IRC | 17:19 | |
*** thedodd has joined #openstack-trove | 17:19 | |
*** f13o has quit IRC | 17:33 | |
*** f13o has joined #openstack-trove | 17:34 | |
*** newb has quit IRC | 17:41 | |
*** newb has joined #openstack-trove | 17:41 | |
*** boblebauce has quit IRC | 17:43 | |
*** thedodd has quit IRC | 18:03 | |
*** thedodd has joined #openstack-trove | 18:04 | |
*** thedodd has quit IRC | 18:04 | |
*** thedodd has joined #openstack-trove | 18:04 | |
*** thedodd has quit IRC | 18:09 | |
*** thedodd has joined #openstack-trove | 18:12 | |
*** mattf is now known as _mattf | 18:13 | |
openstackgerrit | Sergey Gotliv proposed openstack/trove: Integration with oslo.messaging library https://review.openstack.org/94484 | 18:17 |
*** X019 has quit IRC | 18:19 | |
*** danritchie has quit IRC | 18:46 | |
*** X019 has joined #openstack-trove | 19:24 | |
*** Barker has quit IRC | 19:28 | |
*** Barker has joined #openstack-trove | 19:49 | |
*** Barker has quit IRC | 19:52 | |
openstackgerrit | Merged openstack/trove: Enable volume resize tests https://review.openstack.org/138482 | 19:58 |
*** Longgeek has quit IRC | 20:10 | |
*** Barker has joined #openstack-trove | 20:27 | |
*** flwang has joined #openstack-trove | 20:43 | |
openstackgerrit | Shayne Burgess proposed openstack/trove: Enforce volume size on replica https://review.openstack.org/142900 | 20:47 |
*** sgotliv has quit IRC | 20:56 | |
*** romainh has joined #openstack-trove | 20:56 | |
*** jmontemayor has quit IRC | 20:59 | |
*** erkules_ has joined #openstack-trove | 21:01 | |
*** jmontemayor has joined #openstack-trove | 21:02 | |
*** erkules has quit IRC | 21:03 | |
*** sgotliv has joined #openstack-trove | 21:05 | |
*** sgotliv has quit IRC | 21:15 | |
*** exploreshaifali has quit IRC | 21:17 | |
*** romainh has left #openstack-trove | 21:29 | |
*** flwang has quit IRC | 21:41 | |
*** flwang has joined #openstack-trove | 21:41 | |
*** vigneshvar has quit IRC | 21:46 | |
*** mattgriffin has quit IRC | 21:51 | |
*** shayneburgess has joined #openstack-trove | 21:55 | |
*** boblebauce has joined #openstack-trove | 21:58 | |
*** mattgriffin has joined #openstack-trove | 22:01 | |
*** cweid has quit IRC | 22:03 | |
openstackgerrit | Shayne Burgess proposed openstack/trove: Enforce volume size on replica https://review.openstack.org/142900 | 22:04 |
*** thedodd has quit IRC | 22:12 | |
*** grapex has quit IRC | 22:12 | |
*** grapex has joined #openstack-trove | 22:13 | |
*** jmontemayor has quit IRC | 22:13 | |
*** boblebauce has left #openstack-trove | 22:17 | |
*** grapex has quit IRC | 22:17 | |
*** pboros has quit IRC | 22:23 | |
*** amrith is now known as _amrith_ | 22:25 | |
*** sgotliv has joined #openstack-trove | 22:31 | |
*** Barker has quit IRC | 22:44 | |
*** david-ly_ has joined #openstack-trove | 22:58 | |
*** david-lyle has quit IRC | 23:03 | |
*** flwang has quit IRC | 23:03 | |
*** flwang has joined #openstack-trove | 23:10 | |
*** jmontemayor has joined #openstack-trove | 23:14 | |
*** jmontemayor has quit IRC | 23:52 | |
openstackgerrit | Shayne Burgess proposed openstack/trove-integration: Keep localrc.rc in sync with devstack https://review.openstack.org/142937 | 23:53 |
*** mattgriffin has quit IRC | 23:54 | |
*** IanGovett has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!