*** peopleme1ge has joined #openstack-trove | 00:11 | |
*** peoplemerge has quit IRC | 00:12 | |
*** demorris has joined #openstack-trove | 00:40 | |
*** juantwo has quit IRC | 01:16 | |
*** demorris has quit IRC | 01:24 | |
*** robertmyers has joined #openstack-trove | 02:34 | |
*** demorris has joined #openstack-trove | 03:13 | |
*** eghobo has joined #openstack-trove | 03:17 | |
*** robertmyers has quit IRC | 03:47 | |
*** demorris has quit IRC | 03:52 | |
*** eghobo has quit IRC | 04:16 | |
*** ramishra has joined #openstack-trove | 04:16 | |
*** eghobo has joined #openstack-trove | 04:17 | |
*** achampion has quit IRC | 04:19 | |
*** ramishra has quit IRC | 04:34 | |
*** ramishra has joined #openstack-trove | 04:42 | |
*** eghobo has quit IRC | 05:13 | |
*** Longgeek has joined #openstack-trove | 05:15 | |
*** michael-yu has joined #openstack-trove | 05:32 | |
*** flaper87|afk is now known as flaper87 | 05:46 | |
*** michael-yu_ has joined #openstack-trove | 06:09 | |
*** michael-yu has quit IRC | 06:12 | |
*** michael-yu_ is now known as michael-yu | 06:12 | |
*** flaper87 is now known as flaper87|afk | 06:12 | |
*** k4n0 has joined #openstack-trove | 06:16 | |
*** michael-yu has quit IRC | 06:20 | |
*** dkehnx has quit IRC | 06:35 | |
*** dkehnx has joined #openstack-trove | 06:35 | |
*** eghobo has joined #openstack-trove | 06:41 | |
*** eghobo has quit IRC | 06:42 | |
*** Longgeek has quit IRC | 07:26 | |
*** Longgeek has joined #openstack-trove | 07:28 | |
*** ramishra has quit IRC | 07:59 | |
*** boblebauce has joined #openstack-trove | 08:12 | |
*** isviridov is now known as isviridov|vacati | 08:14 | |
*** boden has joined #openstack-trove | 08:23 | |
*** boden has quit IRC | 08:32 | |
*** ramishra has joined #openstack-trove | 08:53 | |
*** sgotliv has joined #openstack-trove | 09:33 | |
*** sgotliv has quit IRC | 10:00 | |
*** georgelorch2 has joined #openstack-trove | 10:07 | |
*** georgelorch3 has quit IRC | 10:08 | |
*** boden has joined #openstack-trove | 10:42 | |
*** ramishra has quit IRC | 11:07 | |
*** ramishra has joined #openstack-trove | 11:08 | |
*** demorris has joined #openstack-trove | 11:18 | |
*** denis_makogon has joined #openstack-trove | 11:32 | |
*** IanGovett has joined #openstack-trove | 11:36 | |
*** ramishra has quit IRC | 11:46 | |
amrith | denis_makogon, yt? | 12:08 |
---|---|---|
denis_makogon | amrith, yes | 12:09 |
amrith | denis_makogon, would you please review your comments to https://review.openstack.org/#/c/108215/ and https://review.openstack.org/#/c/108216/. It is hard to understand (to me) what you want changed. It would help considerably if you were more precise in the nature of the change you would like. | 12:10 |
amrith | for example, in https://review.openstack.org/#/c/108216/ you "are thinking" about changing the default for a parameter from logging=None to logging=logging.DEBUG. But, I'm trying to do the same kind of thing that is done all over openstack. | 12:11 |
amrith | so, are you recommending that I do something different from the rest of openstack (in many many places), and certainly different from what this function is doing? | 12:11 |
amrith | in https://review.openstack.org/#/c/108215/ you ask that I do proper multi-string formatting. What would you like? I'm emitting a bash script the exact same way in which it is done in two other places in that file. | 12:12 |
amrith | so, please help us understand what your thinking is by being a bit more specific so we can incorporate your feedback. otherwise it just sits there delaying the review process and we go back and forth with patch sets that may or many not reflect what you want/intend/thought of/hoped for/desired. etc., | 12:13 |
*** demorris has quit IRC | 12:13 | |
amrith | denis_makogon, ^^ | 12:13 |
*** juantwo has joined #openstack-trove | 12:13 | |
denis_makogon | amrith, "other OpenStack" sound more than weired for me | 12:14 |
amrith | I don't understand what you are saying. again, please speak more 'plainly'. what is weired (what is weired) about it? | 12:15 |
denis_makogon | denis_makogon, one module doesn't mean whole ecosystem, but i will leave it for oslo cores, they would made the last decision | 12:15 |
amrith | let me observe that in 579 places in trove, we have parameter=None as the default. | 12:16 |
*** juantwo has quit IRC | 12:17 | |
amrith | so, would you please send an email to, say openstack-dev with your proposal? it isn't for oslo-core, what you are proposing is for openstack at large. | 12:17 |
denis_makogon | amrith, different situation, different project, different behavior | 12:18 |
*** juantwo has joined #openstack-trove | 12:18 | |
amrith | I'd strongly urge you to send your proposal to the openstack dev community with your sugegstion. I agree, it could reduce lines of code. | 12:18 |
denis_makogon | amrith, i'm not interested in it | 12:18 |
denis_makogon | amrith, i don't like to follow strange patterns, just because someone did like that long time ago and he thought that it was ok | 12:19 |
amrith | interesting. you are ok -1'ing a change and proposing something that isn't done anywhere else in that source file, but not interested enough to actually follow through? | 12:19 |
amrith | denis_makogon, I'm not a python "guru", you clearly have an opinion about it. why not do something about it? if it is strange, why not make that something we can all benefit from? | 12:20 |
*** IanGovett has quit IRC | 12:20 | |
amrith | anyway, what about the multi-line formatting? is it something like this where you think it is a strange pattern? | 12:21 |
denis_makogon | amrith, because staying focused on 1-2 projects is more productive than spreading myself to tons of them | 12:21 |
*** pdmars has joined #openstack-trove | 12:21 | |
denis_makogon | amrith, yes | 12:21 |
amrith | denis_makogon, so why not make that clear in your comment? what's the pattern you would like? | 12:22 |
denis_makogon | amrith, triple quotes are used only for docstrings mostly, python has more appropriate ways to format lines | 12:22 |
amrith | how would you like these lines wrapped? | 12:22 |
amrith | so, please share, how does one do this? | 12:23 |
denis_makogon | amrith, i already left comment with an example of lines should be wrapped https://review.openstack.org/#/c/108215/2/tests/unit/test_processutils.py,cm | 12:23 |
*** ramishra has joined #openstack-trove | 12:23 | |
denis_makogon | amrith, also, testing thing, testtools has perfect method called `assertRaises`, it returns raised exception object, so, you don't have to write try:except blocks to catch the certain exception | 12:25 |
amrith | I'm trying your code out | 12:25 |
denis_makogon | amrith, could you please fix test assertions too ? | 12:25 |
*** georgelorch2 has quit IRC | 12:26 | |
amrith | one at a time | 12:26 |
amrith | your proposed code doesn't work | 12:26 |
amrith | so we'll leave that alone | 12:26 |
*** georgelorch2 has joined #openstack-trove | 12:26 | |
amrith | as for the assertion, if you observe, the intent of the test is not to see whether a particular assertion is raised or not (which is what assertRaises does) | 12:26 |
amrith | instead, it is to actually cause the assertion | 12:26 |
amrith | and interrogate the contents of the thrown exception | 12:27 |
amrith | sorry, cause the exception and interrogate the contents of the exception | 12:27 |
denis_makogon | amrith, actually it does | 12:27 |
amrith | but again, if you know how to make assertRaises() do that, I'm certainly interested in knowing. | 12:27 |
*** k4n0 has quit IRC | 12:28 | |
denis_makogon | amrith, i will leave comment, and while i'm doing it, you could find where i missed formatting symbol at previous comment | 12:28 |
amrith | Yes, please do. that would help. | 12:29 |
denis_makogon | amrith, https://gist.github.com/denismakogon/0ed14d89b752630c4273 | 12:30 |
amrith | the code you propose in this gist above does not do what the test is intending to test. | 12:31 |
amrith | I want to make sure that the assertion does NOT contain the string you have ... | 12:31 |
amrith | anywhere in it | 12:32 |
amrith | second, your assertRaises() does not account for other variables in the exception. | 12:32 |
amrith | so sorry, your code doesn't accomplish what I'm trying to test. | 12:33 |
amrith | got to run now, thanks for your help. | 12:33 |
denis_makogon | amrith, i does _actually_ what you've wrote at the patchset, but it avoids try:except block which should not be in tests, find appropriate way with use of assertRaises | 12:34 |
amrith | no it does not | 12:34 |
amrith | it tests that an exception is thrown and you provide some things in the exception | 12:34 |
amrith | but there are others | 12:34 |
amrith | please tell me how assertRaises tests for 'password="secret"' not in err.cmd | 12:35 |
amrith | are you proposing that I keep all the code 19-26 as well? or just 15-17? | 12:36 |
denis_makogon | amrith, see https://gist.github.com/denismakogon/0ed14d89b752630c4273 | 12:38 |
amrith | I'll fix the formatting on line 11, sounds good. | 12:39 |
amrith | if that's what you want | 12:39 |
amrith | so why does the rest of the source file not do this? and should I conform to the same thing that the rest of the file uses? | 12:39 |
amrith | anyway, please propose that in your comments. I'll take a look | 12:40 |
*** radez_g0n3 is now known as radez | 12:40 | |
denis_makogon | amrith, we should do our best on what we do and do not look at stinky(sometimes) code that was committed long time ago | 12:40 |
*** IanGovett has joined #openstack-trove | 13:22 | |
*** achampion has joined #openstack-trove | 13:31 | |
*** tvoran has joined #openstack-trove | 13:31 | |
*** demorris has joined #openstack-trove | 13:33 | |
*** georgelorch2 has quit IRC | 13:39 | |
*** georgelorch has joined #openstack-trove | 13:39 | |
*** IanGovett_ has joined #openstack-trove | 13:57 | |
*** IanGovett_ has left #openstack-trove | 13:57 | |
*** robertmyers has joined #openstack-trove | 14:08 | |
*** mattgriffin has joined #openstack-trove | 14:09 | |
*** boden has quit IRC | 14:10 | |
*** georgelorch has quit IRC | 14:11 | |
*** georgelorch has joined #openstack-trove | 14:11 | |
denis_makogon | amrith, could you please fix https://review.openstack.org/#/c/107726/5/trove/guestagent/api.py,cm | 14:24 |
amrith | I could | 14:27 |
amrith | what is it? | 14:28 |
amrith | hard to read it while driving ;) | 14:28 |
*** grapex has joined #openstack-trove | 14:30 | |
*** rwsu has joined #openstack-trove | 14:32 | |
*** Longgeek has quit IRC | 14:34 | |
denis_makogon | amrith, the message contains work "calling" even if it's in _cast(...) method | 14:36 |
denis_makogon | *word | 14:36 |
denis_makogon | cores, and other guys who's interested in, just letting you, i've added patch for devstack, see https://review.openstack.org/#/c/108371/, and for infra, see https://review.openstack.org/#/c/100601/ - all this patches are related to heat based testing | 14:41 |
*** Barker has joined #openstack-trove | 14:41 | |
*** yidclare has joined #openstack-trove | 14:45 | |
*** yidclare has quit IRC | 14:47 | |
*** openstackgerrit has joined #openstack-trove | 14:48 | |
*** openstackgerrit has quit IRC | 14:48 | |
*** thedodd has joined #openstack-trove | 14:49 | |
*** doddstack has joined #openstack-trove | 14:52 | |
*** thedodd has quit IRC | 14:54 | |
*** openstackgerrit has joined #openstack-trove | 15:02 | |
imsplitbit | hello everyone! | 15:02 |
juantwo | wow, hi imsplitbit | 15:02 |
imsplitbit | had a few minutes before I had to get started working, though I'd reach out and see how everyoen is | 15:03 |
*** IanGovett has left #openstack-trove | 15:04 | |
*** rueben has joined #openstack-trove | 15:06 | |
juantwo | imsplitbit: how are you liking the new digs? | 15:06 |
imsplitbit | lovin it | 15:07 |
rueben | imsplitbit: o/ | 15:07 |
imsplitbit | especially now that I don't have to work with rueben... | 15:07 |
imsplitbit | oh... | 15:07 |
imsplitbit | awkward | 15:07 |
rueben | ;( | 15:07 |
juantwo | lol | 15:07 |
rueben | haha | 15:07 |
imsplitbit | hi rueben | 15:07 |
imsplitbit | :D | 15:07 |
rueben | cweid: tells me the only reason I got rueben on freenode is because I spell my name wrong | 15:08 |
rueben | so lots of love... | 15:09 |
rueben | gonna have to grab lunch. You're still in town right? | 15:09 |
cp16net | imsplitbit: omg he speaks | 15:12 |
imsplitbit | you go work for a startup and see how often you can come up for air | 15:13 |
imsplitbit | :) | 15:13 |
cp16net | drowning huh? | 15:13 |
imsplitbit | doesn't feel like it | 15:13 |
imsplitbit | but I'm def more busy | 15:13 |
imsplitbit | which is crazy cause I always felt like I was busy before | 15:14 |
imsplitbit | :) | 15:14 |
cp16net | yeah i bet | 15:14 |
*** IanGovett has joined #openstack-trove | 15:18 | |
dougshelley66 | imsplitbit, hi there - good to hear from you! liking the startup life? | 15:21 |
boblebauce | Hi. I created a Wiki page for the rootwrap-for-guest blueprint : https://wiki.openstack.org/wiki/Trove/Blueprints/rootwrap-for-guest | 15:22 |
boblebauce | Is it possible to update the https://blueprints.launchpad.net/trove/+spec/rootwrap-for-guest page to link to the Wiki entry please ? | 15:23 |
boblebauce | And possibly update the assignee :) | 15:23 |
*** juantwo_ has joined #openstack-trove | 15:25 | |
boblebauce | Any chance to review this BP for the today's meeting ? | 15:25 |
*** grapex has quit IRC | 15:25 | |
*** grapex has joined #openstack-trove | 15:25 | |
*** ramishra has quit IRC | 15:26 | |
*** ramishra has joined #openstack-trove | 15:26 | |
*** juantwo has quit IRC | 15:28 | |
*** ramishra has quit IRC | 15:30 | |
*** grapex_ has joined #openstack-trove | 15:32 | |
*** grapex has quit IRC | 15:34 | |
dougshelley66 | boblebauce, just add your info to here https://wiki.openstack.org/wiki/Meetings/TroveBPMeeting | 15:34 |
boblebauce | dougshelley66: I'm adding it right now, thanks | 15:34 |
*** jmontemayor has joined #openstack-trove | 15:35 | |
*** grapex has joined #openstack-trove | 15:35 | |
*** grapex_ has quit IRC | 15:37 | |
*** grapex has quit IRC | 15:37 | |
*** edmund has joined #openstack-trove | 15:38 | |
*** grapex_ has joined #openstack-trove | 15:38 | |
*** redthrux has joined #openstack-trove | 15:38 | |
*** ramishra has joined #openstack-trove | 15:46 | |
*** eghobo has joined #openstack-trove | 15:47 | |
denis_makogon | boblebauce, are you there ? | 15:48 |
*** ramishra has quit IRC | 15:49 | |
denis_makogon | boblebauce, hope you are, please update blueprint by setting specification URL, https://wiki.openstack.org/wiki/Trove/Blueprints/rootwrap-for-guest | 15:49 |
boblebauce | denis_makogon: I'm there | 15:50 |
denis_makogon | boblebauce, nice =) | 15:50 |
boblebauce | denis_makogon: I can't modify it, I don't have the permissions to edit the launchpad bp | 15:50 |
denis_makogon | boblebauce, as i can see you also cannot modify blueprint =), i update whiteboard of it | 15:50 |
denis_makogon | boblebauce, i see, that's why i update BP whiteboard | 15:51 |
boblebauce | denis_makogon: thanks | 15:51 |
denis_makogon | boblebauce, np | 15:51 |
*** eghobo has quit IRC | 15:54 | |
*** shakamunyi has joined #openstack-trove | 15:54 | |
*** doddstack has quit IRC | 15:54 | |
*** eghobo has joined #openstack-trove | 15:55 | |
openstackgerrit | Christian Berendt proposed a change to openstack/trove: Enable hacking check H306 https://review.openstack.org/108417 | 15:57 |
*** ViswaV_ has joined #openstack-trove | 15:58 | |
*** ViswaV has quit IRC | 16:00 | |
*** thedodd has joined #openstack-trove | 16:09 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: parse the mysql cnf file for password https://review.openstack.org/104107 | 16:09 |
*** boblebauce has left #openstack-trove | 16:10 | |
*** Barker has quit IRC | 16:21 | |
*** Barker has joined #openstack-trove | 16:23 | |
*** rueben has quit IRC | 16:30 | |
openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for trove/guestagent module https://review.openstack.org/107726 | 16:33 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add instance ID validation stage while creating incremental backup https://review.openstack.org/108101 | 16:37 |
openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for guestagent/redis https://review.openstack.org/107805 | 16:38 |
openstackgerrit | Suthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available https://review.openstack.org/106843 | 16:42 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Update backup state when guest error occurs https://review.openstack.org/102262 | 16:44 |
denis_makogon | amrith, ping | 16:44 |
openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for guestagent/redis https://review.openstack.org/107805 | 16:56 |
*** IanGovett has left #openstack-trove | 16:57 | |
*** IanGovett has joined #openstack-trove | 16:57 | |
openstackgerrit | Anna Shen proposed a change to openstack/trove: Add neutron support https://review.openstack.org/88349 | 16:59 |
*** annashen_ has joined #openstack-trove | 17:01 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Fix incremental backups feature validation https://review.openstack.org/106065 | 17:03 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Fix parent backup state validation https://review.openstack.org/106050 | 17:03 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add instance ID validation stage while creating incremental backup https://review.openstack.org/108101 | 17:03 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Mark all running backups as FAILED when instance was deleted https://review.openstack.org/102838 | 17:03 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Update backup state when guest error occurs https://review.openstack.org/102262 | 17:03 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Fix backup state check while restoring an instance https://review.openstack.org/106042 | 17:03 |
*** ViswaV has joined #openstack-trove | 17:03 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: guestagent contract for packages should be a list https://review.openstack.org/104108 | 17:05 |
*** ViswaV_ has quit IRC | 17:06 | |
denis_makogon | SlickNik, are you there ? | 17:07 |
*** ViswaV_ has joined #openstack-trove | 17:09 | |
*** ViswaV has quit IRC | 17:12 | |
openstackgerrit | Suthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available https://review.openstack.org/106843 | 17:12 |
openstackgerrit | Denis M. proposed a change to openstack/trove-integration: Enabling Heat provisioning based on ENV for Trove https://review.openstack.org/108443 | 17:18 |
*** jcru has joined #openstack-trove | 17:20 | |
openstackgerrit | Ramashri Umale proposed a change to openstack/trove: Adds backup/restore support for mongodb https://review.openstack.org/78339 | 17:21 |
*** demorris has quit IRC | 17:22 | |
*** jcru has quit IRC | 17:23 | |
*** saurabhs has joined #openstack-trove | 17:27 | |
*** tvoran has quit IRC | 17:32 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Support full backup/restore for Cassandra https://review.openstack.org/77551 | 17:38 |
*** peopleme1ge is now known as peoplemerge | 17:40 | |
*** thedodd has quit IRC | 17:40 | |
SlickNik | denis_makogon: Yes, what's up? | 17:44 |
denis_makogon | SlickNik, just wanted to talk to you about heat gates | 17:44 |
denis_makogon | SlickNik, i've submitted 3 patches: devstack, integration, infra | 17:45 |
*** jcru has joined #openstack-trove | 17:45 | |
*** shakamunyi_ has joined #openstack-trove | 17:45 | |
denis_makogon | SlickNik, redstack https://review.openstack.org/#/c/108443/ | 17:45 |
denis_makogon | SlickNik, devstack https://review.openstack.org/#/c/108371/ | 17:45 |
denis_makogon | SlickNik, infra https://review.openstack.org/#/c/100601/ | 17:46 |
denis_makogon | need your thoughts and patient reviewing | 17:46 |
*** shakamunyi has quit IRC | 17:49 | |
SlickNik | denis_makogon: Okay, will probably get to them after the j2 cut. Right now, the j2 work items are keeping me pretty busy. | 17:49 |
denis_makogon | SlickNik, ok | 17:50 |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Make storage strategy available for trove API and TM https://review.openstack.org/86242 | 17:55 |
*** grapex_ has quit IRC | 17:57 | |
*** grapex has joined #openstack-trove | 17:57 | |
*** thedodd has joined #openstack-trove | 17:58 | |
SlickNik | #startmeeting trove-bp-review | 18:00 |
openstack | Meeting started Mon Jul 21 18:00:04 2014 UTC and is due to finish in 60 minutes. The chair is SlickNik. Information about MeetBot at http://wiki.debian.org/MeetBot. | 18:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 18:00 |
openstack | The meeting name has been set to 'trove_bp_review' | 18:00 |
denis_makogon | o/ | 18:00 |
SlickNik | giving folks a few minutes to trickle in | 18:00 |
SlickNik | Agenda at: | 18:01 |
SlickNik | #link https://wiki.openstack.org/wiki/Meetings/TroveBPMeeting | 18:01 |
dougshelley66 | o/ | 18:02 |
vgnbkr | o/ | 18:02 |
schang | o/ | 18:02 |
peterstac | o/ | 18:02 |
grapex | o/ | 18:02 |
SlickNik | denis_makogon: You have 3 BPs scheduled. In the interest of fairness - and time, we'll discuss the first one, move on to boblebauce's bp, and then come back to the other two. | 18:03 |
denis_makogon | SlickNik, of course | 18:03 |
*** Riddhi has joined #openstack-trove | 18:03 | |
iccha | o/ | 18:03 |
amrith | o/ | 18:04 |
SlickNik | #topic Datastore log files operations | 18:04 |
SlickNik | #link https://blueprints.launchpad.net/trove/+spec/dbinstance-log | 18:04 |
denis_makogon | so, it's mine | 18:04 |
denis_makogon | we've did reviewing of it, twice already | 18:04 |
denis_makogon | the last concerns were related to HTTP routes, payloads | 18:04 |
denis_makogon | i've did alot with vipul to flesh it out | 18:05 |
annashen_ | o/ | 18:05 |
vgnbkr | Yes. Can you point out where you have addressed SlickNik's concerns as listed on the whiteboard? I couldn't find where they were addressed. | 18:05 |
denis_makogon | so, and this review request was raised to kill this beast finally, since it should be in Juno release | 18:05 |
*** demorris has joined #openstack-trove | 18:06 | |
*** boblebauce has joined #openstack-trove | 18:06 | |
amrith | sorry, I don't get it. is the review to accept the proposal or kill the proposal? | 18:06 |
denis_makogon | amrith, review request =) | 18:06 |
grapex | I didn't know we needed formal meetings to stop the progress on features in Trove. | 18:07 |
amrith | vgnbkr +1 | 18:07 |
denis_makogon | vgnbkr, cases are described in Justification section | 18:07 |
grapex | j/k | 18:07 |
vgnbkr | So I wasn't clear how audit fit into all this. Are you planning to enable auditing somehow? | 18:08 |
SlickNik | This review is to get the proposal accepted. | 18:08 |
denis_makogon | vgnbkr, all concerns are not fitting into first proposal, but itss a good start to accomplish goals | 18:08 |
vipul | I thinkt he audit stuff just needs to be taken out.. to avoid confusion on what is being propsed | 18:09 |
denis_makogon | vgnbkr, audit will be accomplished by 3d party tools, our task to pull logs out of instance, since we cannot access instance through ssh or whatever | 18:09 |
sbadia | o/ | 18:09 |
SlickNik | denis_makogon: I don't think this is a very good proposal for Audit requirements — I can see this as a good convenience to developers (i.e. I want to find out the contents of my slow-query logs, for example). | 18:09 |
vipul | this proposal is pretty simple.. provide a mechanism to ship datastore logs out of Trove instances | 18:09 |
denis_makogon | vipul, yes, that's what i was trying to say | 18:10 |
vipul | i think the extra wording confuses that message denis_makogon | 18:10 |
denis_makogon | vipul, i see | 18:10 |
SlickNik | denis_makogon: Yes, in that case, please remove the requirements section about "audit", since it doesn't look like this is aiming to tackle that. | 18:11 |
denis_makogon | so, as vipul said, initial proposal is simple - provide a mechanism to ship logs from instance to storage | 18:11 |
denis_makogon | done | 18:12 |
amrith | one minor nit, my browser has a plugin that detects plagarism (vestiges of being a teacher) and it flagged this page. Turns out there's some chunks that have been copied without attribution. Justification: Database Audit was copied from an article http://www.comwise.com.my/learn-about-database-security-auditing-tools/. If that's the case, we should attribute the content. | 18:12 |
vipul | let's just delete that section too -- not necessary to talk about auditing why/how/at all | 18:13 |
denis_makogon | done and done | 18:13 |
vgnbkr | Does it include operations to enable logging? i.e., to create the log files that the user wants to see? | 18:13 |
*** amcrn has joined #openstack-trove | 18:13 | |
denis_makogon | vgnbkr, its up to configurations API | 18:14 |
denis_makogon | vgnbkr, by use of configurations API, user will be able to enable/disable logging configuration | 18:14 |
denis_makogon | vgnbkr, spec states about it | 18:15 |
denis_makogon | vgnbkr, API section | 18:15 |
denis_makogon | vgnbkr, https://wiki.openstack.org/wiki/Trove/DBInstanceLogOperationV1#How_does_it_works | 18:15 |
SlickNik | denis_makogon: So what's the behavior if the configuration group has logging disabled? | 18:16 |
vgnbkr | I did read that, but it really wasn't very clear what you were getting at there. | 18:16 |
denis_makogon | SlickNik, user would not be able to pull logs, because they are not enabled by the applied configuration | 18:16 |
SlickNik | denis_makogon: There likely needs to be a new error response to the client, I take it? That's something that's part of the API contract and should be called out. | 18:17 |
SlickNik | denis_makogon: Also the "Public API" section confuses me. It states: | 18:18 |
SlickNik | Three new resources, log-create, log-show will be exposed as part of the Trove API. | 18:18 |
SlickNik | The log-show is used to provide an ability to list all available(availability defined by Trove) database logging filenames per instance. | 18:18 |
SlickNik | The log-create is used to provide an ability to save database logging file into the Swift container, required attribute - instance. | 18:18 |
denis_makogon | SlickNik, user will see an empty log ist | 18:18 |
denis_makogon | *list | 18:18 |
SlickNik | denis_makogon: That is not good UX — for there is no indication that this feature is tied to config groups at all! They would never guess how to enable it. | 18:19 |
*** rueben has joined #openstack-trove | 18:19 | |
SlickNik | denis_makogon: That section says "three" but lists only "two". | 18:19 |
*** dkehn_ has joined #openstack-trove | 18:20 | |
denis_makogon | SlickNik, fixed, actually two | 18:20 |
SlickNik | denis_makogon: What's the API response on error — (eg. when swift is not accessible?) | 18:21 |
*** tvoran has joined #openstack-trove | 18:21 | |
openstackgerrit | Suthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available https://review.openstack.org/108459 | 18:21 |
denis_makogon | SlickNik, design was taken from backups API, user will receive 403 Forbidden | 18:21 |
*** kevinconway has joined #openstack-trove | 18:22 | |
SlickNik | denis_makogon: The spec does not call that out. | 18:22 |
vipul | denis_makogon, SlickNik -- we shouldn't be editing this spec on the fly as we find issues.. i think it's better for everyone if Denis goes back.. and addresses all these points | 18:22 |
denis_makogon | SlickNik, i see | 18:22 |
SlickNik | denis_makogon: In general, the spec needs to cover these issues. | 18:22 |
*** dkehnx has quit IRC | 18:23 | |
denis_makogon | skipping | 18:23 |
SlickNik | denis_makogon: I find it concerning that after going through multiple iterations for multiple specs, you still come back with specs that are missing key parts of the API information. | 18:23 |
denis_makogon | SlickNik, each time new concern are being raised, which weren't asked ever before | 18:24 |
denis_makogon | let's just skip it | 18:24 |
SlickNik | denis_makogon: not every concern should have to be called out. Let's talk offline about how we can achieve writing better specs from the get-go, so as to reduce churn at these meetings. | 18:26 |
SlickNik | #topic Use oslo-rootwrap | 18:26 |
SlickNik | #link https://blueprints.launchpad.net/trove/+spec/rootwrap-for-guest | 18:27 |
SlickNik | boblebauce: around? | 18:27 |
*** thedodd has quit IRC | 18:28 | |
robertmyers | hmm, the review linked to that BP has noting to do with root wrap | 18:28 |
sbadia | I'm here (I work with boblebauce) | 18:28 |
openstackgerrit | Ramashri Umale proposed a change to openstack/trove: Adds backup/restore support for mongodb https://review.openstack.org/78339 | 18:29 |
sbadia | robertmyers: yes, the review linked is more a code cleanup | 18:29 |
amrith | SlickNik, I'd agreed to work with boblebauce about this. I think I'll have to do some more. | 18:29 |
amrith | Didn't realize this was coming up today | 18:30 |
amrith | else I'd have chatted with him about it | 18:30 |
robertmyers | yeah, root wrap will be a major change | 18:30 |
openstackgerrit | Suthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available https://review.openstack.org/108459 | 18:30 |
amrith | yes | 18:31 |
amrith | I think what boblebauce is proposing is much smaller | 18:31 |
robertmyers | yes, that is just bug fix | 18:31 |
amrith | I'll work with him about this. that was supposed to be just a 'sample'. | 18:31 |
robertmyers | the BP is a major overhaul | 18:31 |
amrith | but I think there's more work to be done before this can be reviewed. | 18:31 |
SlickNik | amrith / sbadia: So I think we all agree that the BP is worth tackling. While coming up with the spec, we need to look at a couple of things: | 18:31 |
SlickNik | - What other OpenStack projects do? There is root-wrap code in oslo, how do we leverage this | 18:31 |
SlickNik | - What would the impact of these changes be? | 18:31 |
kevinconway | amrith: a sample? is the first one free? | 18:32 |
amrith | SlickNik, a couple of things | 18:32 |
amrith | (and I'll get to kevinconway's comment in a second) | 18:32 |
amrith | one thing I'd like is to hold the bp in vipul's name till we reach agreement on what is to be done | 18:32 |
amrith | and I'll get you the answers to the questions you pose above. | 18:32 |
amrith | kevinconway, the second is half-price. | 18:33 |
amrith | ; | 18:33 |
amrith | ;) | 18:33 |
amrith | I've been looking at other projects over the weekend | 18:33 |
cp16net | sounds like half a product tho :-P | 18:33 |
amrith | and not all have done this migration, I think. | 18:33 |
amrith | so, I'll follow-up on my action item from the meeting on 07-19 | 18:34 |
amrith | and get back to y'all | 18:34 |
amrith | unless sbadia has other thoughts, I'd call time on this one. | 18:34 |
iccha | yeah i think it was rejected in glance | 18:34 |
iccha | dont rem why | 18:34 |
sbadia | amrith: nop, it's ok | 18:35 |
amrith | iccha, some projects rejected it because of scope pre-icehouse | 18:35 |
sbadia | indeed | 18:35 |
SlickNik | amrith: I think nova is the one that has it done. Depending on the scope / impact, I'm okay with punting this based on other priorities. | 18:35 |
robertmyers | I'm not sure if root wrap will work nicely with our guest | 18:35 |
robertmyers | specifically backups and restores | 18:35 |
robertmyers | we call subprocess directly | 18:35 |
amrith | can we agree that this is not targeted for juno (grin) | 18:35 |
amrith | any +1's on that? | 18:35 |
SlickNik | amrith: It isn't targeted for juno, already | 18:36 |
boblebauce | Hello | 18:36 |
SlickNik | amrith: Milestone target: ongoing | 18:36 |
SlickNik | Series: Accepted for future | 18:36 |
amrith | ok. boblebauce sorry I dropped the ball on this one. we should chat; maybe after this meeting. I know we chatted a bit after the last meeting but, my apologies. | 18:37 |
boblebauce | amrith: no problem ! | 18:37 |
SlickNik | Okay, let's keep moving. | 18:38 |
SlickNik | #topic Disk space validation coefficient | 18:38 |
SlickNik | #link https://blueprints.launchpad.net/trove/+spec/restore-disk-space-coefficient | 18:38 |
kevinconway | this sounds like a fun math equation | 18:39 |
denis_makogon | So, there's a bug report related to validation of disk space | 18:39 |
denis_makogon | kevinconway, it is | 18:39 |
vgnbkr | So this is a feature to detect when an operation would fail, and fail more gracefully. Shouldn't we instead be looking to make the functionality work? | 18:39 |
denis_makogon | vgnbkr, there's a problem with backuping/restoring tools | 18:40 |
denis_makogon | vgnbkr, most of them can't do streaming | 18:40 |
denis_makogon | vgnbkr, but mysqldump, xtrabackup can | 18:40 |
robertmyers | denis_makogon: is that the problem? | 18:40 |
kevinconway | it's more than streaming isn't it? you can't stream 20 gigs into a 1 gig disk | 18:40 |
robertmyers | kevinconway: +1 | 18:40 |
vgnbkr | Right. So shouldn't we make a non-streaming backup/restore work in all cases? Can't we address the diskspace issue somehow? Perhaps mounting a temp volume? | 18:40 |
amrith | what do you mean by streaming? | 18:41 |
vgnbkr | Backup/restore by default streams the backup directly to swift, without storing it on the local drive. | 18:42 |
amrith | you get a file, you have to restore it. what does streaming mean? | 18:42 |
denis_makogon | amrith, writing data directly into stdout without any specific preparations | 18:42 |
robertmyers | so streaming only make backups take less memory | 18:42 |
SlickNik | robertmyers: +1 | 18:42 |
robertmyers | not sure how this applies to restore | 18:42 |
denis_makogon | amrith, robertmyers, the problem is in the size of provided disk, you can't restore 20G to 1G disk, but you can deployers can configure Trove to accept size of disk that can be calculated with specific coefficient | 18:43 |
kevinconway | yeah seems like the issue is with all backups that exceed the disk space of the instance | 18:43 |
SlickNik | amrith: streaming = writing the backup to swift directly so that the backup doesn't take up space on local disk. | 18:43 |
robertmyers | denis_makogon: so we should require at least a 20g in that case | 18:43 |
kevinconway | so denis_makogon is looking for a way to prevent failed builds due to a backup being too big. is that correct? | 18:43 |
SlickNik | amrith: at least that's the implication here. | 18:43 |
amrith | I hear two very different problems being described. | 18:44 |
amrith | one is a restore problem. | 18:44 |
robertmyers | I thought there was already a review for this | 18:44 |
amrith | one is a backup problem. | 18:44 |
amrith | so q to denis_makogon ... you appear to be solving the restore problem. yes? | 18:44 |
denis_makogon | kevinconway, not at all, its all about quota on size of disk | 18:44 |
denis_makogon | amrith, yes | 18:44 |
amrith | ok, so if this is a restore problem, then ... | 18:45 |
amrith | this is an extension of the bug you are fixing | 18:45 |
denis_makogon | so, if you want to restore X Gb, you would need to use X * per_datastore_coefficient disk size | 18:45 |
amrith | where we said a backup is ~ size of on disk storage | 18:45 |
robertmyers | amrith: +1 | 18:45 |
amrith | but you are looking to do some multiplication | 18:45 |
amrith | to deal with the fact that the backup may be compressed | 18:46 |
amrith | or some such | 18:46 |
denis_makogon | amrith, that's why it's configurable per datastore | 18:46 |
denis_makogon | amrith, deployer/dev knows how much additional space will be used by one or another strategy | 18:46 |
amrith | there's a backup on swift | 18:47 |
robertmyers | denis_makogon: so a person backing up a 10g volume would need a 20g volume if the coefficient is 2? | 18:47 |
amrith | it gets mounted and accessible | 18:47 |
robertmyers | seems a little hight | 18:47 |
denis_makogon | amrith, for mysql coefficient is 1 of course, because it can accept data as stream directly | 18:47 |
robertmyers | high | 18:47 |
amrith | so someone has to guess how much disk space is needed in total for this backup inclusive of any intermedite files that may be required | 18:47 |
denis_makogon | robertmyers, yes | 18:47 |
robertmyers | that doesn't seem like a solution | 18:48 |
amrith | I don't get it. | 18:48 |
amrith | how do I know that a compressed backup of 10GB can fit in a database of 10GB with indexes and stuff like that? | 18:48 |
amrith | as robertmyers says, this doesn't sound like a solution to me. | 18:48 |
denis_makogon | amrith, you can't know | 18:48 |
SlickNik | denis_makogon: This seems to me to be a bad idea. Seems to me like this propagates the idea of having "voodoo numbers" in our conf settings that doesn't really solve anything concrete. | 18:49 |
robertmyers | so, let it fail I say | 18:49 |
amrith | I'd rather we do something like tag the size of the instance volume that generated the abckup and let the user base the size of the new instance on that as a recommendation. | 18:49 |
denis_makogon | if it's bad - lets skip it and find more appropriate solution | 18:50 |
amrith | magic numbers: -1 | 18:50 |
kevinconway | amrith: it's like a box delivered to you in the desert. you don't know what's in it so you have to guess and ask "What's in the booox?" | 18:50 |
vgnbkr | amrith: so then the user would be stuck paying indefinitely for storage that was used only to do the restore, no? | 18:50 |
amrith | no, it's a hint | 18:50 |
amrith | a user can say restore this for me, pick a size you think is appropriate | 18:50 |
amrith | or a user can say restore on size X GB, and it may fail | 18:50 |
amrith | or we can do the obvious 'du' before we do the dump and record that size, rounded up etc., | 18:51 |
amrith | and use that as the starting point | 18:51 |
SlickNik | IIRC, we do store the size of the data on disk, as part of the backup. | 18:51 |
robertmyers | SlickNik: yes | 18:51 |
amrith | SlickNik, I think we store the size of the backup file | 18:51 |
robertmyers | amrith: no | 18:51 |
amrith | ok | 18:51 |
robertmyers | volume used | 18:52 |
SlickNik | amrith: No - we also store the size of the data on the volume. | 18:52 |
amrith | volume size (total) or space used? | 18:52 |
robertmyers | so we should just require at least that much | 18:52 |
denis_makogon | how user can know how much space he needs to restore a backup ? | 18:52 |
SlickNik | and that should be a good enough hint of what volume size should be used. | 18:52 |
robertmyers | amrith: space used | 18:52 |
robertmyers | SlickNik: +1 | 18:52 |
denis_makogon | user is not able to know that strategy X takes up to two times of backup size | 18:52 |
amrith | OK, then that's a start | 18:52 |
amrith | let's now get to the issue of streaming vs. non-streaming | 18:53 |
robertmyers | denis_makogon: add documentation | 18:53 |
robertmyers | for the users | 18:53 |
amrith | for mysql; the total space used is sufficient as a starting point | 18:53 |
amrith | for others you may have to stage an intermediate hunk of stuff in (say) /tmp | 18:53 |
amrith | is that what denis_makogon is referring to as 'streaming' and 'non-streaming'? | 18:53 |
robertmyers | I question whether this is an issue for other datastores | 18:54 |
robertmyers | I think this would apply to mysql too | 18:54 |
amrith | robertmyers, I'll defer to the author of the proposal on that. | 18:54 |
robertmyers | mysqldump does not stream | 18:54 |
denis_makogon | amrith, i was referring to the tools that cannot accept data as income stream | 18:54 |
amrith | I'm just trying to figure out what's being requested here | 18:54 |
robertmyers | denis_makogon: look at xtrabackup | 18:55 |
robertmyers | it doesn't stream it directly in | 18:55 |
amrith | so in effect, denis_makogon is making a proposal for the case of a solution that cannot do what mysql does | 18:55 |
robertmyers | it loads it on disk first | 18:55 |
denis_makogon | robertmyers, xtrabackup can do data streaming | 18:55 |
amrith | or that needs an intermediate space | 18:55 |
robertmyers | denis_makogon: look again | 18:55 |
robertmyers | stream out | 18:55 |
robertmyers | the stream in is just a temp space that is not the actual restore | 18:56 |
amrith | so robertmyers I think we agreed that we're talking about sreaming 'in' only | 18:56 |
amrith | i.e. restore | 18:56 |
robertmyers | yeah and I'm saying it doesn't even apply to mysql | 18:56 |
robertmyers | in our current form | 18:56 |
SlickNik | Okay, time check here. | 18:57 |
amrith | SlickNik +1 | 18:57 |
denis_makogon | i'll mark it as obsolete | 18:57 |
SlickNik | denis_makogon: Once again, I think the lack of clarity in the actual spec is causing a lot of confusion as to what's actually being proposed here. | 18:57 |
denis_makogon | ok | 18:58 |
openstackgerrit | Suthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available https://review.openstack.org/106843 | 18:58 |
SlickNik | denis_makogon: and what the problem that we are trying to address really _is_ | 18:58 |
SlickNik | Okay, thanks. | 18:58 |
SlickNik | #endmeeting | 18:59 |
openstack | Meeting ended Mon Jul 21 18:59:19 2014 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 18:59 |
*** denis_makogon has quit IRC | 18:59 | |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-07-21-18.00.html | 18:59 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-07-21-18.00.txt | 18:59 |
grapex | Thanks SlickNik! | 18:59 |
openstack | Log: http://eavesdrop.openstack.org/meetings/trove_bp_review/2014/trove_bp_review.2014-07-21-18.00.log.html | 18:59 |
SlickNik | That's all the time that we have for this week. | 18:59 |
SlickNik | Thanks folks. | 18:59 |
cp16net | cool thanks | 18:59 |
*** thedodd has joined #openstack-trove | 19:02 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add instance ID validation stage while creating incremental backup https://review.openstack.org/108101 | 19:02 |
openstackgerrit | Suthan Venkataramanaiah proposed a change to openstack/python-troveclient: Prevent extra API call when hostname not available https://review.openstack.org/106843 | 19:03 |
openstackgerrit | Joe Cruz proposed a change to openstack/trove: Make configuration tests configurable by datastore https://review.openstack.org/102972 | 19:04 |
*** redthrux has quit IRC | 19:05 | |
*** demorris_ has joined #openstack-trove | 19:17 | |
*** demorris has quit IRC | 19:17 | |
*** demorris_ is now known as demorris | 19:17 | |
*** ViswaV_ has quit IRC | 19:25 | |
openstackgerrit | Simon Chang proposed a change to openstack/trove: Adjusted audit logging for taskmanager module https://review.openstack.org/108020 | 19:27 |
*** grapex has quit IRC | 19:31 | |
*** demorris has quit IRC | 19:37 | |
*** grapex has joined #openstack-trove | 19:38 | |
*** ViswaV has joined #openstack-trove | 19:40 | |
*** redthrux has joined #openstack-trove | 19:47 | |
*** amrith has left #openstack-trove | 19:48 | |
*** amrith has joined #openstack-trove | 19:48 | |
*** jcru_ has joined #openstack-trove | 19:49 | |
*** jcru has quit IRC | 19:52 | |
*** jcru_ has quit IRC | 19:56 | |
*** jcru has joined #openstack-trove | 19:56 | |
*** jcru has quit IRC | 19:57 | |
*** mrsnivvel has quit IRC | 20:01 | |
*** ViswaV has quit IRC | 20:02 | |
*** jmontemayor has quit IRC | 20:06 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Implements guest agent upgrade pip strategy https://review.openstack.org/85225 | 20:12 |
*** jmontemayor has joined #openstack-trove | 20:30 | |
*** ViswaV has joined #openstack-trove | 20:30 | |
*** ViswaV_ has joined #openstack-trove | 20:31 | |
*** ViswaV has quit IRC | 20:35 | |
*** ViswaV_ has quit IRC | 20:44 | |
openstackgerrit | Greg Lucas proposed a change to openstack/trove: Inject guest conf files to configurable location https://review.openstack.org/100381 | 20:49 |
*** ViswaV has joined #openstack-trove | 20:55 | |
*** jmontemayor has quit IRC | 21:02 | |
*** ViswaV has quit IRC | 21:12 | |
*** jmontemayor has joined #openstack-trove | 21:16 | |
*** saurabhs has quit IRC | 21:16 | |
*** saurabhs has joined #openstack-trove | 21:19 | |
*** freyes_ has joined #openstack-trove | 21:23 | |
*** shakamunyi_ has quit IRC | 21:24 | |
*** IanGovett has quit IRC | 21:26 | |
*** freyes_ has quit IRC | 21:27 | |
*** saurabhs has quit IRC | 21:29 | |
*** rueben has quit IRC | 21:31 | |
*** juantwo_ has quit IRC | 21:32 | |
*** kevinconway has quit IRC | 21:36 | |
*** freyes_ has joined #openstack-trove | 21:40 | |
*** redthrux has quit IRC | 21:47 | |
*** demorris has joined #openstack-trove | 22:00 | |
*** rwsu has quit IRC | 22:02 | |
*** annashen_ has quit IRC | 22:10 | |
*** robertmyers has quit IRC | 22:14 | |
*** Barker has quit IRC | 22:16 | |
*** grapex has quit IRC | 22:30 | |
*** ViswaV has joined #openstack-trove | 22:33 | |
*** ViswaV_ has joined #openstack-trove | 22:34 | |
*** esp has left #openstack-trove | 22:36 | |
*** esp has joined #openstack-trove | 22:36 | |
openstackgerrit | Craig Vyvial proposed a change to openstack/trove: parse the mysql cnf file for password https://review.openstack.org/104107 | 22:37 |
*** ViswaV has quit IRC | 22:37 | |
*** thedodd has quit IRC | 22:41 | |
*** edmund has quit IRC | 22:42 | |
*** pdmars has quit IRC | 22:46 | |
*** pdmars has joined #openstack-trove | 22:47 | |
*** achampion has quit IRC | 22:48 | |
*** pdmars has quit IRC | 22:52 | |
*** shakamunyi_ has joined #openstack-trove | 22:53 | |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Make storage strategy available for trove API and TM https://review.openstack.org/86242 | 22:58 |
*** freyes_ has quit IRC | 23:06 | |
*** demorris has quit IRC | 23:09 | |
*** Riddhi has quit IRC | 23:12 | |
*** shakamunyi_ has quit IRC | 23:33 | |
*** achampion has joined #openstack-trove | 23:44 | |
*** ViswaV_ has quit IRC | 23:58 | |
*** eghobo has quit IRC | 23:58 | |
*** ViswaV has joined #openstack-trove | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!