| *** achampion has joined #openstack-trove | 00:01 | |
| *** Riddhi has joined #openstack-trove | 00:10 | |
| *** ranjitha has quit IRC | 00:14 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove: Restrict backup-list on instance to tenant https://review.openstack.org/107536 | 00:15 |
|---|---|---|
| *** Riddhi has quit IRC | 00:15 | |
| *** Riddhi has joined #openstack-trove | 00:16 | |
| *** Riddhi_ has joined #openstack-trove | 00:25 | |
| *** Riddhi has quit IRC | 00:28 | |
| *** annashen_ has joined #openstack-trove | 00:34 | |
| *** ViswaV has quit IRC | 00:36 | |
| *** Riddhi_ has quit IRC | 00:38 | |
| *** jgriffith has quit IRC | 00:42 | |
| *** jgriffith has joined #openstack-trove | 00:43 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove: Refactored datastores to use common chown function https://review.openstack.org/107542 | 00:43 |
| *** Riddhi has joined #openstack-trove | 00:48 | |
| *** michael-yu has joined #openstack-trove | 01:14 | |
| *** michael-yu has quit IRC | 01:25 | |
| *** robertmyers has joined #openstack-trove | 01:33 | |
| *** michael-yu has joined #openstack-trove | 01:43 | |
| *** nosnos has joined #openstack-trove | 01:49 | |
| *** saurabhs has quit IRC | 01:57 | |
| *** haomaiw__ has joined #openstack-trove | 02:04 | |
| *** haomaiwang has quit IRC | 02:07 | |
| *** michael-yu has quit IRC | 02:08 | |
| *** nehav has joined #openstack-trove | 02:22 | |
| *** demorris has joined #openstack-trove | 02:23 | |
| *** ramishra has joined #openstack-trove | 02:53 | |
| *** nosnos has quit IRC | 03:06 | |
| *** Longgeek has joined #openstack-trove | 03:10 | |
| *** kevinconway has joined #openstack-trove | 03:12 | |
| *** demorris has quit IRC | 03:12 | |
| *** kevinconway_ has joined #openstack-trove | 03:22 | |
| *** kevinconway has quit IRC | 03:24 | |
| *** kevinconway_ is now known as kevinconway | 03:24 | |
| *** nosnos has joined #openstack-trove | 03:33 | |
| *** nehav has quit IRC | 03:45 | |
| *** nehav has joined #openstack-trove | 03:45 | |
| *** mattgriffin has quit IRC | 03:55 | |
| *** kevinconway has quit IRC | 04:00 | |
| *** amcrn has quit IRC | 04:03 | |
| *** michael-yu has joined #openstack-trove | 04:09 | |
| *** ramishra has quit IRC | 04:26 | |
| *** ramishra has joined #openstack-trove | 04:26 | |
| *** michael-yu has quit IRC | 04:28 | |
| *** ramishra has quit IRC | 04:30 | |
| *** ramishra_ has joined #openstack-trove | 04:30 | |
| *** amcrn has joined #openstack-trove | 04:31 | |
| *** ViswaV has joined #openstack-trove | 04:45 | |
| *** michael-yu has joined #openstack-trove | 04:46 | |
| *** ramishra_ has quit IRC | 04:58 | |
| *** robertmyers has quit IRC | 04:58 | |
| *** Riddhi has quit IRC | 05:06 | |
| *** ramishra has joined #openstack-trove | 05:08 | |
| *** michael-yu has quit IRC | 05:21 | |
| *** nehav has quit IRC | 05:23 | |
| *** juantwo has quit IRC | 05:33 | |
| *** Riddhi has joined #openstack-trove | 05:36 | |
| *** Riddhi has quit IRC | 05:41 | |
| *** flaper87|afk is now known as flaper87 | 05:53 | |
| *** ViswaV has quit IRC | 05:59 | |
| *** ranjitha has joined #openstack-trove | 06:09 | |
| *** denis_makogon has joined #openstack-trove | 06:12 | |
| *** ramishra has quit IRC | 06:16 | |
| *** ramishra has joined #openstack-trove | 06:16 | |
| *** k4n0 has joined #openstack-trove | 06:22 | |
| *** michael-yu has joined #openstack-trove | 06:27 | |
| *** Longgeek has quit IRC | 06:28 | |
| *** michael-yu has quit IRC | 06:32 | |
| *** ramishra has quit IRC | 06:33 | |
| *** dougshelley66 has quit IRC | 06:33 | |
| *** SergeyLukjanov has quit IRC | 06:34 | |
| *** d0ugal has quit IRC | 06:34 | |
| *** esp has quit IRC | 06:34 | |
| *** k4n0 has quit IRC | 06:34 | |
| *** SergeyLukjanov has joined #openstack-trove | 06:34 | |
| *** dougshelley66 has joined #openstack-trove | 06:34 | |
| *** esp has joined #openstack-trove | 06:35 | |
| *** d0ugal has joined #openstack-trove | 06:36 | |
| *** k4n0 has joined #openstack-trove | 06:36 | |
| *** ramishra has joined #openstack-trove | 06:36 | |
| *** ramishra has quit IRC | 06:38 | |
| *** ranjitha has quit IRC | 06:40 | |
| *** ramishra has joined #openstack-trove | 06:45 | |
| *** Longgeek has joined #openstack-trove | 06:51 | |
| *** ramishra has quit IRC | 06:59 | |
| *** ramishra has joined #openstack-trove | 07:00 | |
| *** annashen_ has quit IRC | 07:01 | |
| *** annashen_ has joined #openstack-trove | 07:01 | |
| *** annashen_ has quit IRC | 07:06 | |
| *** ramishra has quit IRC | 07:26 | |
| *** freyes has joined #openstack-trove | 07:37 | |
| *** ramishra has joined #openstack-trove | 07:54 | |
| *** haomaiw__ has quit IRC | 08:05 | |
| *** haomaiwang has joined #openstack-trove | 08:06 | |
| *** rwsu has quit IRC | 08:13 | |
| *** boblebauce has joined #openstack-trove | 08:14 | |
| *** haomai___ has joined #openstack-trove | 08:19 | |
| *** Riddhi has joined #openstack-trove | 08:19 | |
| *** karimb has joined #openstack-trove | 08:20 | |
| *** haomaiwang has quit IRC | 08:22 | |
| *** ramishra has quit IRC | 08:22 | |
| *** Riddhi has quit IRC | 08:24 | |
| *** karimb has quit IRC | 08:31 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove: Restrict backup-list on instance to tenant https://review.openstack.org/107536 | 08:32 |
| *** johnma has joined #openstack-trove | 08:33 | |
| *** haomai___ has quit IRC | 08:45 | |
| *** haomaiwang has joined #openstack-trove | 08:45 | |
| *** ramishra has joined #openstack-trove | 08:47 | |
| *** karimb has joined #openstack-trove | 08:47 | |
| openstackgerrit | Ionut Artarisi proposed a change to openstack/trove: show stdout/err from failed command execution https://review.openstack.org/106008 | 08:47 |
| *** ramishra has quit IRC | 09:04 | |
| openstackgerrit | Deepika Goswami proposed a change to openstack/trove: Incorrect error message- user-access-revoke API https://review.openstack.org/86258 | 09:14 |
| *** ramishra has joined #openstack-trove | 09:29 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove: Restrict backup-list on instance to tenant https://review.openstack.org/107536 | 09:43 |
| *** nosnos has quit IRC | 09:54 | |
| amcrn | SlickNik: since you're already in the midst of fixing backup-list, i'm curious: is it purposeful that a backup-create initiated by admin tenant has the backup actually land in the admin tenant's swift container vs. the user's? | 09:57 |
| amcrn | i can cook up some reasons why that'd be helpful, but i could also come up with a few why it'd be a hindrance | 09:58 |
| SlickNik | amcrn: Yeah, the idea there was to allow for the admin to take auto-backups on behalf of the user as a managed feature. | 10:00 |
| SlickNik | amcrn: And in this case the user shouldn't get billed for the storage space in Swift. | 10:00 |
| amcrn | ah, i figured the first point; the billing aspect i hadn't thought of. | 10:01 |
| amcrn | thanks for the history lesson ;) | 10:01 |
| *** nosnos has joined #openstack-trove | 10:01 | |
| amcrn | heading off to bed, take it easy slick | 10:02 |
| SlickNik | See you in the morrow! | 10:02 |
| SlickNik | g'night. | 10:03 |
| *** freyes has quit IRC | 10:07 | |
| *** Riddhi has joined #openstack-trove | 10:08 | |
| *** haomaiwang has quit IRC | 10:08 | |
| *** haomaiwang has joined #openstack-trove | 10:09 | |
| *** nosnos has quit IRC | 10:10 | |
| *** haomaiw__ has joined #openstack-trove | 10:11 | |
| *** nosnos has joined #openstack-trove | 10:12 | |
| *** Riddhi has quit IRC | 10:12 | |
| *** haomaiwang has quit IRC | 10:14 | |
| *** demorris has joined #openstack-trove | 10:24 | |
| *** nosnos has quit IRC | 10:38 | |
| *** demorris has quit IRC | 10:49 | |
| *** freyes has joined #openstack-trove | 11:01 | |
| *** ramishra has quit IRC | 11:20 | |
| *** ramishra has joined #openstack-trove | 11:20 | |
| *** ramishra has quit IRC | 11:25 | |
| *** boden has joined #openstack-trove | 11:25 | |
| *** ramishra has joined #openstack-trove | 11:26 | |
| openstackgerrit | A change was merged to openstack/trove: Fix tracking of SG's provisioned by Heat https://review.openstack.org/96795 | 11:26 |
| *** Meirav has joined #openstack-trove | 11:47 | |
| *** Meirav has left #openstack-trove | 11:48 | |
| *** denis_makogon_ has joined #openstack-trove | 11:53 | |
| *** denis_makogon has quit IRC | 11:53 | |
| *** denis_makogon_ is now known as denis_makogon | 11:53 | |
| denis_makogon | SlickNik, ping | 11:53 |
| *** denis_makogon_ has joined #openstack-trove | 11:54 | |
| *** Riddhi has joined #openstack-trove | 11:56 | |
| *** demorris has joined #openstack-trove | 11:57 | |
| *** juantwo has joined #openstack-trove | 11:59 | |
| *** Riddhi has quit IRC | 12:01 | |
| *** Riddhi has joined #openstack-trove | 12:05 | |
| *** ramishra has quit IRC | 12:06 | |
| *** ramishra has joined #openstack-trove | 12:06 | |
| *** ramishra has quit IRC | 12:09 | |
| *** ramishra has joined #openstack-trove | 12:12 | |
| *** achampion has quit IRC | 12:15 | |
| *** ramishra has quit IRC | 12:19 | |
| *** ramishra has joined #openstack-trove | 12:20 | |
| *** ramishra has quit IRC | 12:30 | |
| *** pdmars has joined #openstack-trove | 12:38 | |
| *** miqui has joined #openstack-trove | 12:41 | |
| *** boblebauce has quit IRC | 12:58 | |
| *** k4n0 has quit IRC | 13:01 | |
| *** Riddhi has quit IRC | 13:04 | |
| dougshelley66 | denis_makogon, I believe SlickNik would be sleeping at this point given that he was working until about 3 hours ago | 13:10 |
| *** achampion has joined #openstack-trove | 13:17 | |
| *** tvoran has joined #openstack-trove | 13:24 | |
| *** jcru has joined #openstack-trove | 13:36 | |
| *** juantwo has quit IRC | 13:37 | |
| *** iartarisi has joined #openstack-trove | 13:37 | |
| *** juantwo has joined #openstack-trove | 13:37 | |
| *** robertmyers has joined #openstack-trove | 13:43 | |
| *** boblebauce has joined #openstack-trove | 13:56 | |
| *** Barker has joined #openstack-trove | 14:00 | |
| *** boblebauce has quit IRC | 14:01 | |
| *** Barker has quit IRC | 14:06 | |
| *** boblebauce has joined #openstack-trove | 14:10 | |
| *** Riddhi has joined #openstack-trove | 14:14 | |
| *** grapex has joined #openstack-trove | 14:31 | |
| *** amcrn has quit IRC | 14:31 | |
| openstackgerrit | Christian Berendt proposed a change to openstack/trove: Remove default=None for config options https://review.openstack.org/96081 | 14:37 |
| openstackgerrit | Christian Berendt proposed a change to openstack/trove: Remove default=None for config options https://review.openstack.org/96081 | 14:39 |
| *** johnma has quit IRC | 14:39 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for trove/guestagent module https://review.openstack.org/107726 | 14:47 |
| *** mattgriffin has joined #openstack-trove | 14:48 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for trove/guestagent module https://review.openstack.org/107726 | 14:52 |
| *** pdmars_ has joined #openstack-trove | 14:54 | |
| *** jcru_ has joined #openstack-trove | 14:54 | |
| *** Riddhi_ has joined #openstack-trove | 14:55 | |
| *** thedodd has joined #openstack-trove | 14:55 | |
| *** grapex_ has joined #openstack-trove | 14:55 | |
| *** haomaiwa_ has joined #openstack-trove | 14:55 | |
| *** johnma has joined #openstack-trove | 14:59 | |
| *** esp_ has joined #openstack-trove | 15:01 | |
| *** jcru__ has joined #openstack-trove | 15:02 | |
| *** grapex has quit IRC | 15:02 | |
| *** jcru has quit IRC | 15:02 | |
| *** pdmars has quit IRC | 15:02 | |
| *** haomaiw__ has quit IRC | 15:02 | |
| *** karimb has quit IRC | 15:02 | |
| *** esp has quit IRC | 15:02 | |
| *** Riddhi has quit IRC | 15:02 | |
| *** johnma has quit IRC | 15:02 | |
| *** johnma has joined #openstack-trove | 15:02 | |
| *** esp_ is now known as esp | 15:03 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for trove/guestagent/backup module https://review.openstack.org/107732 | 15:04 |
| *** jcru_ has quit IRC | 15:04 | |
| *** karimb has joined #openstack-trove | 15:07 | |
| *** Riddhi_ has quit IRC | 15:07 | |
| *** Riddhi has joined #openstack-trove | 15:08 | |
| *** Barker has joined #openstack-trove | 15:10 | |
| *** Riddhi has quit IRC | 15:10 | |
| *** Riddhi has joined #openstack-trove | 15:11 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for trove/guestagent/datastore module https://review.openstack.org/107739 | 15:11 |
| *** karimb has quit IRC | 15:13 | |
| openstackgerrit | iccha-sethi proposed a change to openstack/trove: Per datastore volume support https://review.openstack.org/107117 | 15:20 |
| openstackgerrit | Ionut Artarisi proposed a change to openstack/trove: Make default extension path relative to pybasedir https://review.openstack.org/107744 | 15:21 |
| *** ramishra has joined #openstack-trove | 15:25 | |
| *** annashen_ has joined #openstack-trove | 15:26 | |
| *** ramishra has quit IRC | 15:34 | |
| openstackgerrit | Ionut Artarisi proposed a change to openstack/trove: Make default extension path relative to pybasedir https://review.openstack.org/107744 | 15:41 |
| *** michael-yu has joined #openstack-trove | 15:49 | |
| *** Barker has quit IRC | 15:52 | |
| *** Barker has joined #openstack-trove | 15:55 | |
| iccha | jcru__: denis_makogon i updated my patch if you would like to take a look | 15:55 |
| denis_makogon | iccha, will do it asap | 15:56 |
| iccha | thank u denis_makogon :) | 15:56 |
| denis_makogon | iccha, everything looks good, but you've missed mongodb group | 15:58 |
| denis_makogon | iccha, i wouldn't -1 it, but please fix it, thanks | 15:58 |
| iccha | denis_makogon: in the conf files? | 15:58 |
| denis_makogon | iccha, yes | 15:58 |
| iccha | will add in it denis_makogon | 15:59 |
| denis_makogon | iccha, thanks =) | 15:59 |
| *** freyes has quit IRC | 15:59 | |
| openstackgerrit | iccha-sethi proposed a change to openstack/trove: Per datastore volume support https://review.openstack.org/107117 | 16:02 |
| iccha | added it in and pushed it up denis_makogon ^ | 16:02 |
| *** jcru__ has quit IRC | 16:04 | |
| *** Longgeek has quit IRC | 16:05 | |
| *** ViswaV has joined #openstack-trove | 16:06 | |
| *** ViswaV_ has joined #openstack-trove | 16:07 | |
| *** pdmars has joined #openstack-trove | 16:09 | |
| *** pdmars_ has quit IRC | 16:09 | |
| *** Riddhi has quit IRC | 16:09 | |
| *** robertmyers has quit IRC | 16:10 | |
| *** ViswaV has quit IRC | 16:10 | |
| *** grapex_ has quit IRC | 16:12 | |
| *** pdmars has quit IRC | 16:13 | |
| *** michael-yu has quit IRC | 16:14 | |
| *** robertmyers has joined #openstack-trove | 16:19 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for trove/guestagent module https://review.openstack.org/107726 | 16:41 |
| *** iartarisi has quit IRC | 16:42 | |
| *** mattgriffin has quit IRC | 16:44 | |
| openstackgerrit | Laurel Michaels proposed a change to openstack/trove: Manual install page needed swift info https://review.openstack.org/107155 | 16:45 |
| *** boblebauce has left #openstack-trove | 16:48 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for guestagent/strategies module https://review.openstack.org/107774 | 16:55 |
| *** rwsu has joined #openstack-trove | 16:55 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for guestagent/strategies module https://review.openstack.org/107774 | 16:57 |
| *** michael-yu has joined #openstack-trove | 16:58 | |
| denis_makogon | amrith, ping | 16:59 |
| *** ViswaV_ has quit IRC | 17:08 | |
| *** ViswaV has joined #openstack-trove | 17:10 | |
| peterstac | denis_makogon: When you get a chance, can you see if I've addressed your concerns on https://review.openstack.org/#/c/107186/ ? | 17:10 |
| denis_makogon | peterstac, sure | 17:12 |
| peterstac | denis_makogon: Thanks! | 17:12 |
| denis_makogon | peterstac, done, i do agree with your comments, thanks | 17:13 |
| peterstac | denis_makogon: Great, thx | 17:14 |
| denis_makogon | peterstac, np | 17:14 |
| denis_makogon | amrith, it will be great if you will join all patchest for guestagent package into a ordered sequence, it would be easier to review | 17:15 |
| *** michael-yu has quit IRC | 17:31 | |
| *** ramishra has joined #openstack-trove | 17:32 | |
| openstackgerrit | A change was merged to openstack/trove: Ensure routing key is specified in the address for a direct producer https://review.openstack.org/98900 | 17:32 |
| *** michael-yu has joined #openstack-trove | 17:32 | |
| *** thedodd has quit IRC | 17:33 | |
| *** robertmyers has quit IRC | 17:35 | |
| *** ramishra has quit IRC | 17:35 | |
| *** denis_makogon_ has quit IRC | 17:36 | |
| *** mayfield has quit IRC | 17:38 | |
| *** yidclare has joined #openstack-trove | 17:38 | |
| *** ramishra has joined #openstack-trove | 17:44 | |
| *** amcrn has joined #openstack-trove | 17:49 | |
| *** tvoran has quit IRC | 17:50 | |
| *** ramishra has quit IRC | 17:52 | |
| *** tvoran has joined #openstack-trove | 18:04 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for guestagent/cassandra https://review.openstack.org/107787 | 18:08 |
| *** mattgriffin has joined #openstack-trove | 18:10 | |
| openstackgerrit | Michael Yu proposed a change to openstack/trove: Add Backup/Restore support for Couchbase https://review.openstack.org/86731 | 18:17 |
| openstackgerrit | Michael Yu proposed a change to openstack/trove: Add Backup/Restore support for Couchbase https://review.openstack.org/86731 | 18:17 |
| *** Barker has quit IRC | 18:23 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for guestagent/couchbase https://review.openstack.org/107788 | 18:25 |
| *** juantwo has quit IRC | 18:25 | |
| *** yidclare has quit IRC | 18:33 | |
| *** Barker has joined #openstack-trove | 18:33 | |
| *** thedodd has joined #openstack-trove | 18:39 | |
| *** ViswaV has quit IRC | 18:41 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for guestagent/mongodb https://review.openstack.org/107795 | 18:41 |
| SlickNik | Hey guys. | 18:46 |
| SlickNik | Just had a couple of quick PSA's for those who are around. | 18:46 |
| SlickNik | I've cleaned up the work-items for the proposed juno-2 milestone at: https://launchpad.net/trove/+milestone/juno-2 | 18:47 |
| SlickNik | Please take a look and let me know if you think any of your work items need to be changed (add / removed from juno-2) | 18:47 |
| SlickNik | Also I've created a review page to review the juno-2 bps that are still in progress here: http://lihk.in/trove/03-juno2-bps.htm | 18:49 |
| *** ViswaV has joined #openstack-trove | 18:50 | |
| SlickNik | It would be awesome if we can prioritize these reviews to ensure that the BPs make the juno-2 cut. | 18:51 |
| SlickNik | Thanks! | 18:53 |
| SlickNik | Also, on a completely different note — I've updated the rdjenkins gerrit trigger plugin so that you can re-trigger your job by leaving a comment of "rdjenkins no bug", or "rdjenkins bug {bug#}" | 18:53 |
| SlickNik | So that should help with re-triggering rdjenkins jobs. | 18:53 |
| *** ViswaV has quit IRC | 18:57 | |
| *** ViswaV has joined #openstack-trove | 18:58 | |
| *** Barker has quit IRC | 19:08 | |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for guestagent/redis https://review.openstack.org/107805 | 19:19 |
| openstackgerrit | amrith proposed a change to openstack/trove: Logging audit for trove/mysql module https://review.openstack.org/107806 | 19:19 |
| *** Barker has joined #openstack-trove | 19:20 | |
| *** demorris has quit IRC | 19:25 | |
| iccha | SlickNik: i like the compilation. theron will be finishing up https://review.openstack.org/#/c/92701/ | 19:29 |
| SlickNik | iccha: Thanks for the update! | 19:32 |
| SlickNik | tvoran: Let me know if there're any updates on the BP. Thanks! | 19:32 |
| tvoran | SlickNik: will do | 19:33 |
| openstackgerrit | A change was merged to openstack/python-troveclient: Use JSON instead of json in the parameter descriptions https://review.openstack.org/103882 | 19:36 |
| denis_makogon | SlickNik, ping | 19:43 |
| denis_makogon | SlickNik, can we talk about https://review.openstack.org/#/c/106050/ ? | 19:43 |
| SlickNik | denis_makogon: sure | 19:44 |
| SlickNik | Let me read your comments, one sec. | 19:45 |
| denis_makogon | SlickNik, of course | 19:45 |
| amrith | SlickNik, ... do you think it is reasonable to put https://bugs.launchpad.net/trove/+bug/1324206 on the juno-2 milestone? | 19:49 |
| amrith | hi denis_makogon | 19:49 |
| amrith | just getting back on IRC | 19:49 |
| denis_makogon | amrith, hi | 19:49 |
| amrith | trying to undersatnd your comment from about 2 hours ago | 19:49 |
| SlickNik | So denis_makogon — I don't think I explained my suggestion clearly enough. | 19:49 |
| amrith | I've pushed up all the code I wanted to | 19:49 |
| denis_makogon | amrith, let me first finish with SlickNik and then we'll talk | 19:50 |
| amrith | sorry, didn't realize u were in middle of a conversation with SlickNik | 19:50 |
| amrith | I'll wait | 19:50 |
| SlickNik | So your test depends on needs a failed backup, and you're trying to create an incremental off a failed backup, right? | 19:50 |
| denis_makogon | SlickNik, you've suggested to re-use backup from previous test to create incremental, but the problem is that there's no instance at that stage, because it was deleted to verify that all running backup become FAILED | 19:51 |
| denis_makogon | SlickNik, yes | 19:51 |
| SlickNik | Why is the instance needed at that stage? | 19:52 |
| denis_makogon | SlickNik, because of this https://github.com/openstack/trove/blob/master/trove/backup/models.py#L78 | 19:53 |
| denis_makogon | SlickNik, when i'm trying to create incremental backup - instance should exits for sure | 19:53 |
| denis_makogon | SlickNik, if instance is missing, API will return HTTP 404 | 19:53 |
| SlickNik | In that case we're blocking on a FAILED backup too late. | 19:54 |
| denis_makogon | Why? | 19:55 |
| denis_makogon | instance can still remain in ACTIVE state and DB is reachable | 19:55 |
| SlickNik | Because if you're trying to create an incremental backup based on a FAILED backup, it shouldn't be allowed at all (checking for the instance shouldn't even come into the picture). | 19:55 |
| denis_makogon | SlickNik, in this case, we need to load parent backup object before we're loading an instance object | 19:56 |
| denis_makogon | SlickNik, and if we do that, i do agree that we don't need an instance at all | 19:57 |
| denis_makogon | SlickNik, i will move parent backup loading and validation before instance loading, ok? | 19:58 |
| *** ViswaV has quit IRC | 19:58 | |
| SlickNik | denis_makogon: Yes, it makes sense to move your changes L88-99 in trove backup models earlier to _before_ the instance gets loaded. | 19:59 |
| amrith | denis_makogon, I'm here | 19:59 |
| denis_makogon | SlickNik, i will update patchset as soon as possible. | 19:59 |
| amrith | private chat doesn't work well on my phone | 19:59 |
| SlickNik | denis_makogon: Okay, thanks! | 20:00 |
| denis_makogon | amrith, oh, ok, i'd like to suggest to make all patchsets (translation stuff) dependent in terms of one package | 20:00 |
| amrith | denis_makogon, what does that mean, what's the benefit, and how do I do it? | 20:01 |
| denis_makogon | amrith, it would be easier to review them one by one | 20:01 |
| amrith | i.e. I've never done that before | 20:01 |
| amrith | and I don't know how to | 20:01 |
| denis_makogon | amcrn, i can explain | 20:02 |
| amrith | and I don't know what it will give to anyone (benefit) | 20:02 |
| *** amrith is now known as notamcrn | 20:02 | |
| notamcrn | go ahead | 20:02 |
| denis_makogon | amrith, once you checkouted a new branch, you will need to do certain number of commits in this branch | 20:03 |
| denis_makogon | notamcrn, from git perspective - each HEAD commit depends on previous | 20:03 |
| denis_makogon | notamcrn, and that's what dependent patchsets are | 20:04 |
| *** Barker has quit IRC | 20:05 | |
| denis_makogon | notamcrn, you can find some info here https://wiki.openstack.org/wiki/Gerrit_Workflow | 20:05 |
| notamcrn | ok, I will read that | 20:05 |
| notamcrn | what do I do now or are you suggesting I do this in the future? | 20:05 |
| denis_makogon | notamcrn, actually i'd suggest to do it now | 20:07 |
| denis_makogon | notamcrn, since you've touched pretty big package, more than 15 files | 20:07 |
| notamcrn | it would be harder to do it now so I will do this differently next time | 20:09 |
| notamcrn | I've followed the same patern as was displayed in the etherpad for this project | 20:09 |
| notamcrn | one commit per line in that list | 20:09 |
| notamcrn | I'm unsure how it would be easier to review, so I must be missing something | 20:10 |
| notamcrn | there is no overlap between the chkins | 20:10 |
| notamcrn | each one is a different part of the code | 20:10 |
| notamcrn | so, if you don't mind, I'd rather not change it now. | 20:10 |
| denis_makogon | notamcrn, dependent commits are fitting into 'commit per file' strategy | 20:11 |
| notamcrn | ok, I've misread the web page in that case. let me read again and check back with you | 20:11 |
| denis_makogon | notamcrn, ok, i just suggested, it's up to you | 20:11 |
| notamcrn | if it is easy, I'll do it now | 20:11 |
| notamcrn | no, no. it seems to make sense. | 20:12 |
| notamcrn | I just don't (a) know how exactly to do it now without going and making a whole bunch of new commits and abandoning these. and (b) how to do it easily ;) | 20:12 |
| notamcrn | so let me go read and get back to you | 20:12 |
| notamcrn | if it is easier to review, it makes sense to do it | 20:12 |
| notamcrn | so I'll go read the web page you provided again and ping you tomorrow (it must be pretty late for you already) | 20:13 |
| denis_makogon | notamcrn, you don't have to abandon them, once you will do ordered commits, you will just need to copy Change-Id to commit message | 20:13 |
| denis_makogon | notamcrn, it's not to late, yet, but thanks for thinking about my timezone =) | 20:14 |
| notamcrn | If it is just changing the commit message, I'll do it. Not a problem at all. | 20:15 |
| denis_makogon | notamcrn, here's more meaningful doc, https://review.openstack.org/Documentation/user-upload.html | 20:15 |
| denis_makogon | notamcrn, it's not only changing a commit message, it's all about making each new commit on top of previous | 20:16 |
| denis_makogon | notamcrn, so, when you'll finish you would have a brach that ahead of master for N commits | 20:16 |
| denis_makogon | notamcrn, and when you'll hit `git review`, review plugin will ask you for permission to publish more than one commit | 20:17 |
| denis_makogon | notamcrn, each commit - separate review | 20:17 |
| denis_makogon | notamcrn, take a look at https://review.openstack.org/#/c/102262, at top right corner, you'll see section called `Related Changes` - it means that all listed commits were made on top of each other | 20:19 |
| denis_makogon | notamcrn, the last doc, https://wiki.openstack.org/wiki/GerritJenkinsGit | 20:20 |
| *** ViswaV has joined #openstack-trove | 20:21 | |
| *** RicoLin has quit IRC | 20:21 | |
| *** boden has quit IRC | 20:23 | |
| *** yidclare has joined #openstack-trove | 20:24 | |
| *** michael-yu has quit IRC | 20:29 | |
| notamcrn | ouch, this is going to be a pain. I'll do it next time. | 20:32 |
| notamcrn | I've done all of these changes on different directories into which I cloned a complete trove | 20:33 |
| notamcrn | so I could run each independent of the others | 20:33 |
| *** pdmars has joined #openstack-trove | 20:38 | |
| *** pdmars has quit IRC | 20:38 | |
| *** pdmars has joined #openstack-trove | 20:39 | |
| *** notamcrn is now known as amrith | 20:40 | |
| amrith | denis_makogon, you still around? | 20:40 |
| *** Riddhi has joined #openstack-trove | 20:41 | |
| *** kevinconway has joined #openstack-trove | 20:42 | |
| *** ViswaV_ has joined #openstack-trove | 20:43 | |
| *** ViswaV has quit IRC | 20:43 | |
| *** ViswaV_ is now known as ViswaV | 20:47 | |
| *** IanGovett has joined #openstack-trove | 20:47 | |
| denis_makogon | amrith, yes | 20:53 |
| amrith | I'll make this kind of dependent change for future chkins; this one will be a pain especially since the commits are already done and all are from different trove directories. therefore the only way to get to the point you are describing would involving manually copying files around my machine and I'd rather avoid that. | 20:54 |
| *** jcru has joined #openstack-trove | 20:55 | |
| denis_makogon | amcrn, not at all, you can use git things like `fetch' | 20:55 |
| *** Barker has joined #openstack-trove | 20:55 | |
| denis_makogon | my god, i hate my tab button ... | 20:55 |
| denis_makogon | amrith, not at all, you can use git things like `fetch' | 20:56 |
| *** Barker has quit IRC | 20:58 | |
| *** pdmars has quit IRC | 20:58 | |
| *** robertmyers has joined #openstack-trove | 20:59 | |
| openstackgerrit | Auston McReynolds proposed a change to openstack/trove: Sync oslo-incubator rpc module https://review.openstack.org/107829 | 21:01 |
| *** michael-yu has joined #openstack-trove | 21:02 | |
| *** Barker has joined #openstack-trove | 21:03 | |
| *** ViswaV_ has joined #openstack-trove | 21:04 | |
| *** ViswaV has quit IRC | 21:06 | |
| *** Barker has quit IRC | 21:08 | |
| *** Barker has joined #openstack-trove | 21:10 | |
| *** flaper87 is now known as flaper87|afk | 21:19 | |
| *** kevinconway has quit IRC | 21:22 | |
| *** jcru has quit IRC | 21:23 | |
| *** Riddhi has quit IRC | 21:23 | |
| *** tvoran has quit IRC | 21:24 | |
| *** IanGovett has quit IRC | 21:32 | |
| *** Barker has quit IRC | 21:40 | |
| *** robertmyers has quit IRC | 21:41 | |
| *** juantwo has joined #openstack-trove | 21:42 | |
| *** yidclare has quit IRC | 21:42 | |
| *** juantwo has quit IRC | 21:43 | |
| *** juantwo has joined #openstack-trove | 21:44 | |
| *** denis_makogon has quit IRC | 21:51 | |
| *** johnma has quit IRC | 22:08 | |
| *** kevinconway has joined #openstack-trove | 22:26 | |
| *** kevinconway has quit IRC | 22:36 | |
| *** mattgriffin has quit IRC | 22:41 | |
| *** georgelorch2 has joined #openstack-trove | 22:42 | |
| *** thedodd has quit IRC | 22:43 | |
| *** georgelorch has quit IRC | 22:43 | |
| openstackgerrit | Michael Yu proposed a change to openstack/trove: Add Backup/Restore support for Couchbase https://review.openstack.org/86731 | 22:51 |
| openstackgerrit | Michael Yu proposed a change to openstack/trove: Add Backup/Restore support for Couchbase https://review.openstack.org/86731 | 22:51 |
| *** ViswaV_ has quit IRC | 22:51 | |
| *** annashen_ has quit IRC | 22:51 | |
| *** ekarlso has quit IRC | 22:51 | |
| *** krugg has quit IRC | 22:51 | |
| *** michael-yu has quit IRC | 22:52 | |
| *** haomaiwa_ has quit IRC | 22:52 | |
| *** dougshelley66 has quit IRC | 22:52 | |
| *** bhunter71 has quit IRC | 22:52 | |
| *** coolsvap has quit IRC | 22:52 | |
| *** abramley has quit IRC | 22:52 | |
| *** haomaiwa_ has joined #openstack-trove | 22:53 | |
| *** dougshelley66 has joined #openstack-trove | 22:53 | |
| *** bhunter71 has joined #openstack-trove | 22:53 | |
| *** coolsvap has joined #openstack-trove | 22:53 | |
| *** abramley has joined #openstack-trove | 22:53 | |
| *** michael-yu has joined #openstack-trove | 22:53 | |
| *** ViswaV_ has joined #openstack-trove | 22:53 | |
| *** annashen_ has joined #openstack-trove | 22:53 | |
| *** ekarlso has joined #openstack-trove | 22:53 | |
| *** krugg has joined #openstack-trove | 22:53 | |
| *** amcrn has quit IRC | 22:54 | |
| *** SergeyLukjanov has quit IRC | 22:54 | |
| *** zacksh has quit IRC | 22:54 | |
| *** cp16net has quit IRC | 22:54 | |
| *** mat-lowery has quit IRC | 22:54 | |
| *** zigo has quit IRC | 22:54 | |
| *** Isotopp has quit IRC | 22:54 | |
| *** glucas has quit IRC | 22:54 | |
| *** radez_g0n3 has quit IRC | 22:54 | |
| *** amrith has quit IRC | 22:55 | |
| *** amcrn has joined #openstack-trove | 22:55 | |
| *** SergeyLukjanov has joined #openstack-trove | 22:55 | |
| *** zacksh has joined #openstack-trove | 22:55 | |
| *** cp16net has joined #openstack-trove | 22:55 | |
| *** mat-lowery has joined #openstack-trove | 22:55 | |
| *** zigo has joined #openstack-trove | 22:55 | |
| *** Isotopp has joined #openstack-trove | 22:55 | |
| *** glucas has joined #openstack-trove | 22:55 | |
| *** radez_g0n3 has joined #openstack-trove | 22:55 | |
| *** amrith has joined #openstack-trove | 22:56 | |
| *** flaper87|afk has quit IRC | 22:57 | |
| *** flaper87|afk has joined #openstack-trove | 22:57 | |
| *** mayfield has joined #openstack-trove | 22:59 | |
| *** mayfield has joined #openstack-trove | 22:59 | |
| *** ViswaV_ has quit IRC | 23:06 | |
| *** achampion has quit IRC | 23:29 | |
| *** demorris has joined #openstack-trove | 23:38 | |
| *** demorris has quit IRC | 23:41 | |
| *** michael-yu has quit IRC | 23:43 | |
| *** achampion has joined #openstack-trove | 23:44 | |
| openstackgerrit | Nikhil Manchanda proposed a change to openstack/trove: Moved core int-test groups from trove-int to trove https://review.openstack.org/107860 | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!