*** amcrn has quit IRC | 00:04 | |
*** harlowja is now known as harlowja_away | 00:04 | |
*** amcrn has joined #openstack-trove | 00:11 | |
openstackgerrit | SlickNik proposed a change to openstack/trove-integration: Clean up redstack to use SERVICE_HOST https://review.openstack.org/71128 | 00:14 |
---|---|---|
*** harlowja_away is now known as harlowja | 00:15 | |
*** freyes has joined #openstack-trove | 00:18 | |
*** michael-yu has quit IRC | 00:19 | |
*** matsuhashi has joined #openstack-trove | 00:19 | |
esmute | Hey grapex, when you have time, can you look at https://review.openstack.org/#/c/71120/? It is preventing int tests to run here in HP | 00:21 |
grapex | esmute: Ok, that strikes a chord with me so I will try. I have to admit it will take me awhile to review it as the changes seem large. | 00:23 |
grapex | esmute: why do " test_create_with_bad_availability_zone" and "test_create_with_bad_nics" not work in fake mode? | 00:24 |
esmute | grapex: It is deceiving. its not really that large.. I looks large because i moved the CreateInstance class down | 00:24 |
grapex | ok | 00:24 |
grapex | So quick note | 00:24 |
grapex | we used to always use the "enabled" argument of the test decorator and have it be driven by the test config | 00:25 |
grapex | I now recommend never doing that | 00:25 |
esmute | availability and bad nic errors are only found in the TM | 00:25 |
grapex | because if you accdidently disable a test, you don't even see it | 00:25 |
grapex | So put the skip in the function with an if statement if you must | 00:25 |
grapex | like "if not FAKE:\n\t raise SkipTest()" | 00:26 |
esmute | people were assuming that these tests were returning an error 400 from the api | 00:26 |
esmute | which was not. | 00:26 |
esmute | the error was due to not having the volume param in the request | 00:26 |
grapex | So- the test should work in fake mode | 00:27 |
*** flaper87 is now known as flaper87|afk | 00:27 | |
grapex | I guess these features aren't faked out is why it isn't | 00:27 |
grapex | ok | 00:27 |
esmute | ok | 00:27 |
grapex | So you mostly just added these two tests | 00:27 |
esmute | what is the best way to simulate an error in the TM? | 00:27 |
esmute | in fake mode | 00:27 |
grapex | Well basically fake mode really will run the task manager | 00:28 |
grapex | So if it fails in real life, it should fail in fake mode unless the code in the test double isn't the same | 00:28 |
grapex | And maybe its not always worth writing in fake mode support if this is something you won't run into except rarely | 00:28 |
esmute | ok.. what i think what is needed is to have the TM return an error when a bad availability is passed | 00:29 |
esmute | or a bad nic | 00:29 |
grapex | Ok- typically the nics are passed to Nova, right? | 00:30 |
esmute | yeah | 00:30 |
grapex | check it out | 00:30 |
grapex | go to trove/tests/fakes/nova.py | 00:30 |
esmute | as availability_zone | 00:30 |
grapex | Line 264 | 00:30 |
esmute | ok | 00:30 |
grapex | "nics" gets passed in | 00:30 |
grapex | In production, will the Nova API give you an error on create if the nic is bad? | 00:31 |
esmute | cool.. Let me do that quick | 00:31 |
grapex | Or does it return 200 on create, and then when you poll the Nova instance it later goes into ERROR state? | 00:31 |
esmute | the first.... it will error out in the api | 00:32 |
grapex | Ok | 00:32 |
esmute | it will complains about network not found or somethiing | 00:32 |
grapex | So, this may be a better case for unit tests, however I know how you can add this to fake mode very easily | 00:33 |
grapex | In that create method in the fake/nova.py file, on line 264 | 00:33 |
grapex | check the nics argument | 00:33 |
grapex | if it's bad, raise the same exception Nova does | 00:33 |
grapex | Ditto for availability zones | 00:33 |
esmute | cool.. sounds good | 00:34 |
grapex | esmute: one more thing | 00:34 |
grapex | "CreateInstanceFail", take it out of the normal groups | 00:34 |
grapex | Right now it says "groups=[GROUP, GROUP_START, GROUP_START_SIMPLE, tests.INSTANCES]," | 00:35 |
esmute | the reason why i separated them was because the two new tests takes a while to complete | 00:35 |
grapex | Change that to something else, like 'groups=["dbaas.api.failures"]' | 00:35 |
grapex | Yes, that's good | 00:35 |
esmute | ok | 00:35 |
grapex | if you add it to a different group, then everyone won't have to always run it. We're running blackbox at rackspace and I don't know if these tests will work for us. | 00:36 |
grapex | So, those are my two pull request comments I guess, put it in a different group and make it work in fake mode | 00:36 |
grapex | esmute: Let me know if you have questions | 00:36 |
esmute | awesome | 00:36 |
esmute | thanks grapex.. Let me get on it now | 00:36 |
grapex | cool | 00:37 |
grapex | brb | 00:37 |
grapex | esmute: back | 00:42 |
esmute | hello grapex | 00:42 |
grapex | hello | 00:43 |
grapex | just wanted to say back so it wouldn't seem like I'd left forever | 00:43 |
grapex | though dinner is nearly ready, so I will need to leave in a bit | 00:44 |
*** ViswaV has quit IRC | 00:50 | |
*** amrith has joined #openstack-trove | 00:51 | |
grapex | esmute: Ok, got to eat. I'll be checking the pull request later tonight though | 00:58 |
grapex | ttyl | 00:58 |
esmute | ok | 00:58 |
esmute | bon appetite grapex | 00:58 |
*** freyes has quit IRC | 01:00 | |
grapex | Ciao | 01:02 |
*** yidclare has quit IRC | 01:16 | |
*** nosnos has joined #openstack-trove | 01:28 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Removes is_root_enabled from guest agent https://review.openstack.org/71705 | 01:33 |
*** robertmyers has joined #openstack-trove | 01:33 | |
*** Ranjitha has quit IRC | 01:36 | |
*** igor__ has joined #openstack-trove | 01:42 | |
*** igor has quit IRC | 01:42 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/python-troveclient: Updates root-show help message https://review.openstack.org/71711 | 01:54 |
*** michael-yu has joined #openstack-trove | 01:57 | |
*** erkules_ has joined #openstack-trove | 02:31 | |
*** erkules has quit IRC | 02:33 | |
*** amrith has quit IRC | 02:33 | |
*** amcrn has quit IRC | 02:39 | |
openstackgerrit | SlickNik proposed a change to openstack/trove-integration: Clean up redstack to use SERVICE_HOST https://review.openstack.org/71128 | 02:55 |
*** SushilKM has quit IRC | 02:57 | |
*** doug_shelley66 has quit IRC | 03:38 | |
*** harlowja is now known as harlowja_away | 03:53 | |
*** edmund has quit IRC | 04:00 | |
*** grapex has quit IRC | 04:04 | |
*** grapex has joined #openstack-trove | 04:04 | |
*** grapex has quit IRC | 04:09 | |
*** jasonb365 has joined #openstack-trove | 04:17 | |
*** grapex has joined #openstack-trove | 04:35 | |
*** SushilKM has joined #openstack-trove | 04:38 | |
*** grapex has quit IRC | 04:44 | |
*** krow1 has quit IRC | 04:50 | |
openstackgerrit | Khyati Sheth proposed a change to openstack/trove: Initial support for single instance Couchbase https://review.openstack.org/71407 | 04:52 |
openstackgerrit | Khyati Sheth proposed a change to openstack/trove: Initial support for single instance Couchbase https://review.openstack.org/71407 | 04:58 |
openstackgerrit | Robert Myers proposed a change to openstack/trove: Adding Incremental Backups https://review.openstack.org/59568 | 05:00 |
*** amcrn has joined #openstack-trove | 05:04 | |
*** jasonb365 has quit IRC | 05:05 | |
*** saju_m has joined #openstack-trove | 05:08 | |
*** amcrn_ has joined #openstack-trove | 05:08 | |
*** amcrn has quit IRC | 05:11 | |
*** krow has joined #openstack-trove | 05:11 | |
*** jcooley_ has quit IRC | 05:14 | |
*** jcooley_ has joined #openstack-trove | 05:15 | |
*** robertmyers has quit IRC | 05:16 | |
*** grapex has joined #openstack-trove | 05:36 | |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Modifying tests to run with different configurations https://review.openstack.org/71120 | 05:36 |
*** SushilKM has quit IRC | 05:37 | |
*** grapex has quit IRC | 05:40 | |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Modifying tests to run with different configurations https://review.openstack.org/71120 | 05:59 |
*** krow has quit IRC | 05:59 | |
*** krow has joined #openstack-trove | 06:01 | |
*** doug_shelley66 has joined #openstack-trove | 06:02 | |
*** jaishanker has joined #openstack-trove | 06:15 | |
*** saju_m has quit IRC | 06:18 | |
*** denis_makogon has joined #openstack-trove | 06:25 | |
*** SnowDust has joined #openstack-trove | 06:25 | |
*** grapex has joined #openstack-trove | 06:36 | |
openstackgerrit | Shane Wang proposed a change to openstack/database-api: Fix misspellings in database-api https://review.openstack.org/71766 | 06:36 |
*** krow has quit IRC | 06:37 | |
*** grapex has quit IRC | 06:41 | |
*** krow has joined #openstack-trove | 06:48 | |
*** erkules_ is now known as erkules | 06:53 | |
*** SushilKM has joined #openstack-trove | 06:59 | |
*** jcooley_ has quit IRC | 07:05 | |
*** matsuhashi has quit IRC | 07:05 | |
*** jcooley_ has joined #openstack-trove | 07:06 | |
*** yogesh has joined #openstack-trove | 07:07 | |
*** jcooley_ has quit IRC | 07:08 | |
*** SushilKM has quit IRC | 07:16 | |
*** matsuhashi has joined #openstack-trove | 07:21 | |
*** yogesh has quit IRC | 07:21 | |
*** PradeepChandani has joined #openstack-trove | 07:21 | |
*** yogesh has joined #openstack-trove | 07:23 | |
*** amcrn_ is now known as amcrn | 07:30 | |
*** SushilKM has joined #openstack-trove | 07:32 | |
*** saju_m has joined #openstack-trove | 07:32 | |
*** jcooley_ has joined #openstack-trove | 07:34 | |
*** grapex has joined #openstack-trove | 07:37 | |
*** grapex has quit IRC | 07:41 | |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Adding override.config.template for percona https://review.openstack.org/71788 | 07:43 |
*** nosnos_ has joined #openstack-trove | 07:51 | |
*** nosnos has quit IRC | 07:54 | |
*** michael-yu has quit IRC | 07:55 | |
*** yogesh has quit IRC | 07:58 | |
openstackgerrit | Alex Holden proposed a change to openstack/trove: Fix Spelling Errors in Trove https://review.openstack.org/71798 | 08:00 |
openstackgerrit | Ailing Zhang proposed a change to openstack/database-api: Fixing misspellings in database-api https://review.openstack.org/71799 | 08:00 |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Modifying tests to run with different configurations https://review.openstack.org/71120 | 08:01 |
*** denis_makogon has quit IRC | 08:04 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Corrects spelling typos https://review.openstack.org/69383 | 08:08 |
*** matsuhashi has quit IRC | 08:10 | |
openstackgerrit | Shane Wang proposed a change to openstack/trove: Fix misspellings in trove https://review.openstack.org/71807 | 08:11 |
openstackgerrit | Alex Holden proposed a change to openstack/trove: Fix Spelling errors in Trove https://review.openstack.org/71808 | 08:12 |
openstackgerrit | Alex Holden proposed a change to openstack/trove: Fix spelling errors in Trove https://review.openstack.org/71809 | 08:12 |
openstackgerrit | Alex Holden proposed a change to openstack/trove: Fix Spelling errors and add .DSStore Mac Metadata files to gitignore file. https://review.openstack.org/71810 | 08:12 |
openstackgerrit | Alex Holden proposed a change to openstack/trove: Fixed Spelling errors and added Mac Metadata files (DSSTORE) to gitignore https://review.openstack.org/71812 | 08:15 |
openstackgerrit | Pengfei Zhang proposed a change to openstack/trove: Fixing misspelling in Trove https://review.openstack.org/71814 | 08:26 |
*** krow has quit IRC | 08:27 | |
openstackgerrit | Pengfei Zhang proposed a change to openstack/trove: Fixing misspelling in Trove https://review.openstack.org/71816 | 08:28 |
*** flaper87|afk is now known as flaper87 | 08:29 | |
*** krow has joined #openstack-trove | 08:30 | |
*** krow has quit IRC | 08:35 | |
*** grapex has joined #openstack-trove | 08:37 | |
*** SnowDust has quit IRC | 08:39 | |
openstackgerrit | Auston McReynolds proposed a change to openstack/trove: Fix Redis After Configuration Group Merge https://review.openstack.org/71822 | 08:40 |
openstackgerrit | Sushil Kumar proposed a change to openstack/python-troveclient: Enabled F821, H306, H402, and H404 flake8 rule https://review.openstack.org/66369 | 08:41 |
*** grapex has quit IRC | 08:42 | |
*** SushilKM has quit IRC | 08:47 | |
*** haomai___ has quit IRC | 08:49 | |
*** haomaiwang has joined #openstack-trove | 08:50 | |
openstackgerrit | Auston McReynolds proposed a change to openstack/trove: Changes Volume Prefix From mysql To datastore https://review.openstack.org/71829 | 09:02 |
*** michael-yu has joined #openstack-trove | 09:04 | |
*** SnowDust has joined #openstack-trove | 09:04 | |
*** yogesh has joined #openstack-trove | 09:08 | |
*** yogesh has quit IRC | 09:13 | |
*** grapex has joined #openstack-trove | 09:38 | |
*** michael-yu has quit IRC | 09:39 | |
*** grapex has quit IRC | 09:42 | |
*** nosnos_ has quit IRC | 09:43 | |
*** SnowDust has quit IRC | 09:56 | |
*** saju_m has quit IRC | 09:58 | |
openstackgerrit | Auston McReynolds proposed a change to openstack/trove: Changes Volume Prefix From mysql To datastore https://review.openstack.org/71829 | 10:14 |
*** jaishanker has quit IRC | 10:17 | |
*** amcrn has quit IRC | 10:29 | |
*** grapex has joined #openstack-trove | 10:38 | |
openstackgerrit | A change was merged to openstack/python-troveclient: Remove copyright from empty files https://review.openstack.org/67760 | 10:42 |
*** grapex has quit IRC | 10:43 | |
*** jcooley_ has quit IRC | 10:52 | |
*** jcooley_ has joined #openstack-trove | 10:52 | |
*** jcooley_ has quit IRC | 10:57 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Security groups workflow update https://review.openstack.org/50944 | 10:58 |
openstackgerrit | Sascha Peilicke proposed a change to openstack/trove: Support building wheels (PEP-427) https://review.openstack.org/57135 | 11:05 |
dmakogon_ | Gate is broken again | 11:13 |
*** dmakogon_ is now known as denis_makogon | 11:13 | |
openstackgerrit | Sascha Peilicke proposed a change to openstack/python-troveclient: Support building wheels (PEP-427) https://review.openstack.org/57133 | 11:19 |
*** grapex has joined #openstack-trove | 11:39 | |
*** grapex has quit IRC | 11:43 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Initial support for single instance Cassandra Database https://review.openstack.org/51884 | 11:44 |
*** PradeepChandani has quit IRC | 11:59 | |
openstackgerrit | Denis M. proposed a change to openstack/python-troveclient: Allow log files audit https://review.openstack.org/64303 | 12:04 |
*** jcooley_ has joined #openstack-trove | 12:24 | |
*** jcooley_ has quit IRC | 12:30 | |
*** grapex has joined #openstack-trove | 12:39 | |
*** grapex has quit IRC | 12:43 | |
*** pdmars has joined #openstack-trove | 13:11 | |
*** jcooley_ has joined #openstack-trove | 13:19 | |
*** jimbobhickville has joined #openstack-trove | 13:20 | |
openstackgerrit | Sascha Peilicke proposed a change to openstack/python-troveclient: Add py33 trove classifier https://review.openstack.org/71895 | 13:25 |
*** jcooley_ has quit IRC | 13:26 | |
*** russellb is now known as rustlebee | 13:30 | |
*** haomaiwang has quit IRC | 13:32 | |
*** haomaiwang has joined #openstack-trove | 13:33 | |
*** doug_shelley66 has quit IRC | 13:34 | |
*** grapex has joined #openstack-trove | 13:40 | |
*** grapex has quit IRC | 13:44 | |
*** amytron has joined #openstack-trove | 13:45 | |
*** vgnbkr_ has joined #openstack-trove | 13:49 | |
*** doug_shelley66 has joined #openstack-trove | 14:09 | |
openstackgerrit | Denis M. proposed a change to openstack/trove-integration: Initial support for single instance Cassandra Database https://review.openstack.org/52666 | 14:10 |
*** jcooley_ has joined #openstack-trove | 14:14 | |
*** igor_ has joined #openstack-trove | 14:15 | |
*** igor__ has quit IRC | 14:15 | |
*** jcooley_ has quit IRC | 14:19 | |
*** Barker has joined #openstack-trove | 14:30 | |
*** edmund has joined #openstack-trove | 14:36 | |
*** doug_shelley66 has quit IRC | 14:39 | |
*** grapex has joined #openstack-trove | 14:40 | |
*** grapex_ has joined #openstack-trove | 14:42 | |
*** grapex has quit IRC | 14:42 | |
*** michael-yu has joined #openstack-trove | 14:42 | |
*** haomaiwang has quit IRC | 14:43 | |
*** haomaiwang has joined #openstack-trove | 14:43 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Allow db instance conditional logging https://review.openstack.org/63789 | 14:58 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Allow log files audit https://review.openstack.org/64302 | 14:58 |
*** kevinconway has joined #openstack-trove | 15:00 | |
*** doug_shelley66 has joined #openstack-trove | 15:06 | |
openstackgerrit | Denis M. proposed a change to openstack/trove-integration: Addind dblog tests https://review.openstack.org/71920 | 15:08 |
*** jcooley_ has joined #openstack-trove | 15:08 | |
*** michael-yu has quit IRC | 15:11 | |
*** jcooley_ has quit IRC | 15:14 | |
*** robertmyers has joined #openstack-trove | 15:30 | |
*** timfreund has quit IRC | 15:40 | |
*** datsun180b has joined #openstack-trove | 15:43 | |
*** ViswaV has joined #openstack-trove | 15:47 | |
*** ViswaV_ has joined #openstack-trove | 15:49 | |
openstackgerrit | Ed Cranford proposed a change to openstack/trove: Ignore outdated messages sent to conductor https://review.openstack.org/67611 | 15:49 |
datsun180b | ^^ had to move my migrate to 021 | 15:50 |
datsun180b | nbd | 15:50 |
robertmyers | vipul: SlickNik: I have added integration tests to https://review.openstack.org/59568 please have another look | 15:53 |
*** ViswaV has quit IRC | 15:53 | |
datsun180b | oh good patch 11 already failed | 15:56 |
* datsun180b (╯°□°)╯︵ ┻━┻ | 15:56 | |
*** jmontemayor has joined #openstack-trove | 15:58 | |
imsplitbit | whoa | 15:59 |
imsplitbit | wha? | 15:59 |
denis_makogon | gate broken | 16:00 |
denis_makogon | almost all day | 16:00 |
*** jcooley_ has joined #openstack-trove | 16:01 | |
datsun180b | yeah that | 16:03 |
* datsun180b (ノಥ益ಥ)ノ ┻━┻ | 16:03 | |
datsun180b | oh that one's even better | 16:03 |
denis_makogon | datsun180b, lol, where do you search for those ? | 16:04 |
datsun180b | just searched for "table flip emoji" | 16:06 |
*** jcooley_ has quit IRC | 16:08 | |
denis_makogon | ʕノ•ᴥ•ʔノ ︵ ┻━┻ | 16:08 |
denis_makogon | lol | 16:08 |
*** timfreund has joined #openstack-trove | 16:10 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Allow log files audit https://review.openstack.org/64302 | 16:11 |
grapex_ | datsun180b: I wonder if that ever gets put in Japanese logging messages. | 16:13 |
*** amytron has quit IRC | 16:13 | |
denis_makogon | hey, guys, what do you think about adding to DatastoreVersion view attribute that defines if version is active or not | 16:14 |
grapex_ | denis_makogon: That would work well for a MGTM api | 16:15 |
denis_makogon | grapex_, i see the problem when user could list all datastore version but cannot know if it's active or not | 16:16 |
grapex_ | denis_makogon: Me too- if we're listing non active datastores we need to change that. | 16:17 |
denis_makogon | grapex_, so, i think this should be available for simple user | 16:17 |
grapex_ | denis_makogon: I don't know. Why would a user who can't change what datastores are available want to see ones they can't use? | 16:18 |
denis_makogon | exception will be raised on create call, this is correct but would be better to avoid "the game of russian roulette" | 16:19 |
jimbobhickville | I think grapex is saying that the datastore list methods should only return active ones to non-admin users | 16:20 |
grapex_ | denis_makogon: Wouldn't not showing unavailable datastores also fix this? | 16:20 |
denis_makogon | grapex_, lets think about capabilities, suppose this tenant could use only mysql, and no sql | 16:22 |
denis_makogon | some sort of | 16:22 |
jimbobhickville | I thought capabilities was for the datastore, not per-tenant permissions | 16:22 |
denis_makogon | jimbobhickville, only example | 16:23 |
denis_makogon | lets be focused on topic | 16:23 |
jimbobhickville | an example should be a real case or it's not useful as an example | 16:23 |
denis_makogon | so, would it be better to list only active or list all with filter active=True ? | 16:24 |
grapex_ | I think listing only active datastores make sense | 16:24 |
grapex_ | *makes sense | 16:24 |
denis_makogon | ok | 16:24 |
denis_makogon | about capabilities, first usecase - capabilities pinned to datastore, second usecase - capabilities based on tenant | 16:27 |
denis_makogon | it's like Amazon accounts | 16:27 |
denis_makogon | one is cheaper, other costs alot | 16:28 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 16:30 |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add stack_id for future usage https://review.openstack.org/67873 | 16:31 |
denis_makogon | vipul, SlickNik , grapex_, https://review.openstack.org/#/c/71870/ |||| https://review.openstack.org/#/c/71905/ - could you please review this patches | 16:32 |
datsun180b | "future usage"? IN THE YEAR TWO THOUUUUUUSAND! | 16:32 |
*** vgnbkr_ has left #openstack-trove | 16:33 | |
denis_makogon | datsun180b, yup =) | 16:33 |
*** vgnbkr_ has joined #openstack-trove | 16:34 | |
*** sballe has joined #openstack-trove | 16:41 | |
cp16net | hrm gate is not happy with trove.test.config | 16:45 |
datsun180b | or with ssh in general | 16:46 |
grapex_ | I've got to head out for a few hours, I'll be back soon | 16:52 |
*** grapex_ has quit IRC | 16:52 | |
hub_cap | so i agree. we should only show active instances | 16:56 |
hub_cap | err datastore versions | 16:56 |
hub_cap | and only way to see non active is w/ a admin acct | 16:57 |
hub_cap | anythign else is silly since the customer has no need for inactive datastores | 16:57 |
*** plodronio has joined #openstack-trove | 16:58 | |
*** jcooley_ has joined #openstack-trove | 16:59 | |
*** ViswaV_ has quit IRC | 17:01 | |
*** ViswaV has joined #openstack-trove | 17:01 | |
*** jcooley_ has quit IRC | 17:03 | |
*** michael-yu has joined #openstack-trove | 17:10 | |
denis_makogon | hub_cap, i rebased cassandra and mongo, | 17:11 |
denis_makogon | hub_cap, also, db_log is ready | 17:11 |
*** michael-yu has quit IRC | 17:11 | |
denis_makogon | about datastores/versions - https://github.com/openstack/trove/blob/master/trove/datastore/service.py | 17:11 |
cp16net | yeah hub_cap i agree wrt datastore versions | 17:11 |
denis_makogon | it seems that we already doing it | 17:12 |
cp16net | hub_cap: wrt https://blueprints.launchpad.net/trove/+spec/configuration-parameters-in-db | 17:13 |
*** tanisdl has joined #openstack-trove | 17:13 | |
cp16net | hub_cap: last night i was thinking this should really be a mgmt api CRUD for the parameters | 17:13 |
cp16net | and the user should just be able to Read them | 17:14 |
cp16net | if i added it to the trove-manage cmd it seems like it would be overkill to add CRUD of the parameters there | 17:14 |
cp16net | dontcha agree? | 17:15 |
hub_cap | cp16net: yes there should be mgmt api | 17:22 |
hub_cap | look @ what andrey did for datastores in the client/api | 17:22 |
hub_cap | he just made a few mgmt calls (and took them _out_ of trove-manage ;)) | 17:22 |
*** mattgriffin has quit IRC | 17:28 | |
*** mattgriffin has joined #openstack-trove | 17:28 | |
*** datsun180b has quit IRC | 17:31 | |
*** datsun180b_ has joined #openstack-trove | 17:32 | |
*** datsun180b_ is now known as datsun180b | 17:32 | |
cp16net | yeah i think that would be much betta | 17:36 |
*** michael-yu has joined #openstack-trove | 17:39 | |
*** tanisdl has quit IRC | 17:41 | |
esmute | Hi cp16net | 17:41 |
*** tanisdl has joined #openstack-trove | 17:42 | |
*** ashestakov has joined #openstack-trove | 17:44 | |
*** datsun180b has quit IRC | 17:44 | |
*** datsun180b has joined #openstack-trove | 17:44 | |
*** datsun180b has quit IRC | 17:48 | |
cp16net | esmute: whats up | 17:50 |
cp16net | how was the parade? | 17:50 |
esmute | Hi | 17:50 |
esmute | chaotic... madness | 17:50 |
cp16net | nice | 17:50 |
esmute | 800k people was crammbed along 4th ave | 17:50 |
*** jcooley_ has joined #openstack-trove | 17:50 | |
cp16net | is your office near there? | 17:51 |
esmute | yup... 3 blocks up | 17:51 |
cp16net | nice | 17:51 |
esmute | we couldnt even get to 4th.. | 17:51 |
esmute | i think we are repeating next year.. our team is young, talented and had great leadership :-) | 17:52 |
esmute | Anyawys cp16net, i want to ask you to review a quick fix (hopefully) | 17:52 |
esmute | the merge of patch 'adding configuration group support' may have broken percona.. | 17:52 |
esmute | this seemed to have fixed it https://review.openstack.org/#/c/71788/ | 17:52 |
esmute | can you verify? | 17:53 |
esmute | i just copied the mysql templace and place it in percona | 17:53 |
*** jcooley_ has quit IRC | 17:56 | |
denis_makogon | esmute, 'sup | 17:59 |
denis_makogon | cp16net, congrats., your code landed))) | 17:59 |
cp16net | w00t | 17:59 |
denis_makogon | big feature | 17:59 |
denis_makogon | nice | 17:59 |
cp16net | yeah it is | 18:00 |
*** michael-yu has quit IRC | 18:00 | |
denis_makogon | cp16net, you are, some times gate fixing master, take a look at it, if you have time | 18:00 |
cp16net | esmute: yeah that should be fine | 18:00 |
cp16net | denis_makogon: looks like its devstack | 18:01 |
cp16net | denis_makogon: pdmars saw that it has to do with the ipaddr install thats located on google drive and its been hit too much apparently | 18:01 |
hub_cap | heh | 18:02 |
*** krow has joined #openstack-trove | 18:04 | |
*** michael-yu has joined #openstack-trove | 18:08 | |
denis_makogon | hehe | 18:09 |
denis_makogon | hub_cap, saw you approved https://review.openstack.org/#/c/71788/ | 18:10 |
denis_makogon | hub_cap, what about heat.template ? | 18:10 |
*** yogesh has joined #openstack-trove | 18:10 | |
hub_cap | separate issue | 18:10 |
hub_cap | u cant expect them to start testing heat out of nowhere | 18:11 |
hub_cap | and provide a template | 18:11 |
hub_cap | if they dont use it | 18:11 |
hub_cap | if u want to use it, add it | 18:11 |
hub_cap | they will add it once they start using it | 18:11 |
hub_cap | feel free to watch the bug thats created for it | 18:12 |
*** Ranjitha has joined #openstack-trove | 18:13 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Allow log files audit https://review.openstack.org/64302 | 18:14 |
denis_makogon | @all, feel free to review | 18:16 |
denis_makogon | it hangs too long | 18:16 |
*** jcooley_ has joined #openstack-trove | 18:16 | |
*** igor_ has quit IRC | 18:17 | |
*** igor_ has joined #openstack-trove | 18:18 | |
*** harlowja_away is now known as harlowja | 18:18 | |
denis_makogon | guys, please take a look at https://review.openstack.org/#/c/71870/ | 18:20 |
*** jcooley_ has quit IRC | 18:20 | |
ashestakov | hub_cap: will ceilometer-integration in i3? | 18:21 |
*** krow has quit IRC | 18:23 | |
hub_cap | ashestakov: is the bp in i3? | 18:23 |
hub_cap | weve discussed this, i thought we put it in i3 | 18:24 |
*** igor_ has quit IRC | 18:24 | |
*** krow has joined #openstack-trove | 18:24 | |
ashestakov | bp in 'next' | 18:24 |
hub_cap | link plz | 18:24 |
ashestakov | https://blueprints.launchpad.net/trove/+spec/ceilometer-integration | 18:24 |
hub_cap | ashestakov: https://review.openstack.org/#/c/70369/ build is broken | 18:27 |
hub_cap | are u finished w/ it? | 18:27 |
hub_cap | is the client piece required to make the test work? | 18:27 |
ashestakov | hub_cap: it depends on troveclient changes | 18:28 |
ashestakov | https://review.openstack.org/#/c/70780/ | 18:28 |
hub_cap | and i assume u need it integrated before u can do the plugin work w/ cielo? | 18:28 |
hub_cap | s/integrated/merged | 18:29 |
ashestakov | yes, bu i started with ceilo plugin | 18:30 |
*** michael-yu has quit IRC | 18:30 | |
*** Ranjitha has quit IRC | 18:31 | |
hub_cap | ok cool | 18:34 |
hub_cap | ill make sure this gets in front of cores soon | 18:34 |
hub_cap | so u can get your ceilo stuff merged | 18:34 |
*** jcooley_ has joined #openstack-trove | 18:40 | |
*** plodronio has quit IRC | 18:46 | |
*** jcooley_ has quit IRC | 18:47 | |
*** jcooley_ has joined #openstack-trove | 18:48 | |
*** michael-yu has joined #openstack-trove | 18:48 | |
*** grapex has joined #openstack-trove | 18:48 | |
*** datsun180b has joined #openstack-trove | 18:49 | |
*** yidclare has joined #openstack-trove | 18:49 | |
*** igor_ has joined #openstack-trove | 18:50 | |
*** Ranjitha has joined #openstack-trove | 18:51 | |
*** grapex has quit IRC | 18:51 | |
*** grapex has joined #openstack-trove | 18:52 | |
*** jcooley_ has quit IRC | 18:52 | |
*** jcooley_ has joined #openstack-trove | 18:53 | |
*** plodronio has joined #openstack-trove | 18:53 | |
*** igor_ has quit IRC | 18:55 | |
openstackgerrit | A change was merged to openstack/trove: Adding override.config.template for percona https://review.openstack.org/71788 | 19:01 |
*** shakayumi has joined #openstack-trove | 19:02 | |
cp16net | esmute: its merged :) | 19:03 |
esmute | cp16net: woo! thansk | 19:04 |
esmute | :-) | 19:04 |
SlickNik | esmute: good work on that. | 19:04 |
*** datsun180b has quit IRC | 19:06 | |
esmute | SlickNik: Thanks | 19:06 |
*** jcooley_ has quit IRC | 19:06 | |
*** krow has quit IRC | 19:12 | |
*** jcooley_ has joined #openstack-trove | 19:13 | |
*** datsun180b has joined #openstack-trove | 19:16 | |
*** annashen has left #openstack-trove | 19:16 | |
*** krow has joined #openstack-trove | 19:18 | |
*** michael-yu has quit IRC | 19:18 | |
*** amcrn has joined #openstack-trove | 19:18 | |
*** michael-yu has joined #openstack-trove | 19:19 | |
openstackgerrit | Auston McReynolds proposed a change to openstack/trove: Fix Redis After Configuration Group Merge https://review.openstack.org/71822 | 19:20 |
*** datsun180b has quit IRC | 19:21 | |
*** datsun180b has joined #openstack-trove | 19:21 | |
*** michael-yu has quit IRC | 19:23 | |
*** michael-yu has joined #openstack-trove | 19:26 | |
*** datsun180b has quit IRC | 19:28 | |
denis_makogon | amcrn, ping | 19:30 |
denis_makogon | amcrn, about "sudo killall java 2> /dev/null", Prof: http://www.ex.ua/863016447007 (there are to screenshots which proves my words) | 19:32 |
*** datsun180b has joined #openstack-trove | 19:32 | |
denis_makogon | amcrn, check your env, i don't see any issues on any ubuntu-base env | 19:34 |
denis_makogon | amcrn, i cannot image when this command could fail (sudo killall java 2> /dev/null), it would not fail if there are no java processes | 19:34 |
*** datsun180b has quit IRC | 19:35 | |
*** datsun180b has joined #openstack-trove | 19:36 | |
denis_makogon | amcrn, i hope, those screenshots are fully proves my words | 19:36 |
*** demorris has joined #openstack-trove | 19:37 | |
*** datsun180b has quit IRC | 19:39 | |
*** datsun180b has joined #openstack-trove | 19:39 | |
denis_makogon | vipul, SlickNik grapex hub_cap: i need your thoughts about this situation | 19:40 |
datsun180b | only had to restart colloquy three times! | 19:40 |
hub_cap | denis_makogon: i dnot know the situation, because youve just responded to something amcrn said to u | 19:41 |
hub_cap | so i dont know anything before u said about "sudo killall..." | 19:41 |
kevinconway | denis_makogon: you can add "|| true" for force it to pass even if it fails | 19:42 |
amcrn | denis_makogon: see my latest reply, that command works in general, yes, but it is not working in the "trove restart" flow; the instance remains in REBOOT (or was it SHUTDOWN, don't remember) | 19:44 |
denis_makogon | amcrn, please share guest logs with all of us | 19:46 |
*** igor_ has joined #openstack-trove | 19:49 | |
*** datsun180b has quit IRC | 19:51 | |
kevinconway | grapex: https://github.rackspace.com/gist/kevi6450/5299427c7c6c2844d240 | 19:52 |
kevinconway | not sure what to make of it | 19:52 |
*** datsun180b has joined #openstack-trove | 19:52 | |
grapex | kevinconway: It's probably due to OS differences | 19:57 |
grapex | let's talk about it on the rax channel though :p | 19:58 |
hub_cap | lulz | 19:58 |
grapex | Sorry guys we're discussing our secret Windows port of Trove | 19:58 |
hub_cap | Glad u didnt expose TroveOS | 19:58 |
amcrn | lol | 19:58 |
grapex | TropinStack | 19:59 |
hub_cap | LOL | 19:59 |
*** amytron has joined #openstack-trove | 20:01 | |
cp16net | haha | 20:01 |
*** datsun180b has quit IRC | 20:01 | |
*** datsun180b has joined #openstack-trove | 20:02 | |
*** datsun180b has quit IRC | 20:05 | |
*** datsun180b has joined #openstack-trove | 20:05 | |
*** yogesh has quit IRC | 20:07 | |
*** yogesh has joined #openstack-trove | 20:10 | |
*** demorris has quit IRC | 20:13 | |
*** edmund has quit IRC | 20:17 | |
*** demorris has joined #openstack-trove | 20:17 | |
*** demorris has quit IRC | 20:26 | |
*** edmund has joined #openstack-trove | 20:27 | |
*** SushilKM has joined #openstack-trove | 20:33 | |
openstackgerrit | Robert Myers proposed a change to openstack/trove: Adding Incremental Backups https://review.openstack.org/59568 | 20:33 |
*** openstackgerrit has quit IRC | 20:34 | |
*** openstackgerrit has joined #openstack-trove | 20:34 | |
*** igor___ has joined #openstack-trove | 20:34 | |
*** igor_ has quit IRC | 20:36 | |
*** ashestakov has quit IRC | 20:39 | |
SushilKM | Hello @amcrn | 20:39 |
*** Barker has quit IRC | 20:39 | |
*** Barker has joined #openstack-trove | 20:40 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Removes is_root_enabled from guest agent https://review.openstack.org/71705 | 20:42 |
*** datsun180b has quit IRC | 20:49 | |
*** denis_makogon_ has joined #openstack-trove | 20:51 | |
esmute | Hey grapex, when you have time, can you review https://review.openstack.org/#/c/71120/? We just want to get our tests working for the weekend :-) | 20:54 |
*** amytron has quit IRC | 20:58 | |
grapex | esmute: Done! +2'd | 20:58 |
grapex | thanks | 20:58 |
openstackgerrit | A change was merged to openstack/database-api: Fix misspellings in database-api https://review.openstack.org/71766 | 21:00 |
*** jimbobhickville has quit IRC | 21:00 | |
*** datsun180b has joined #openstack-trove | 21:01 | |
denis_makogon_ | http://russellbryant.net/openstack-stats/trove-openreviews.txt | 21:01 |
esmute | grapex: Thank you ! | 21:01 |
denis_makogon_ | maybe its time to review | 21:01 |
*** Ranjitha has quit IRC | 21:02 | |
cp16net | configs is finally off that list of the longest review ever | 21:05 |
*** amytron has joined #openstack-trove | 21:05 | |
denis_makogon_ | cp16net, yeah, but there tons of patchsets that "stucked" without being reviewed for cores and cotributors | 21:07 |
denis_makogon_ | http://stackalytics.com/report/reviews/trove/open | 21:08 |
hub_cap | denis_makogon: we are aware | 21:09 |
hub_cap | we discuss it daily | 21:09 |
hub_cap | ive said it once | 21:09 |
hub_cap | ill say it again | 21:09 |
hub_cap | if your code is in i3, it will be merged | 21:09 |
*** michael-yu has quit IRC | 21:09 | |
hub_cap | ok /me goes to sf | 21:10 |
hub_cap | see yall this evening | 21:10 |
juice | i'm going to sf too? | 21:10 |
juice | this is great! | 21:10 |
*** krow has quit IRC | 21:12 | |
denis_makogon_ | the problem is not in merging, its it reviewing in general =( | 21:13 |
*** doug_shelley66 has quit IRC | 21:13 | |
cp16net | hub_cap: say what again? | 21:14 |
cp16net | :-P | 21:14 |
*** doug_shelley66 has joined #openstack-trove | 21:14 | |
hub_cap | hahah | 21:14 |
hub_cap | virtually | 21:14 |
hub_cap | aka ill be online in a few hrs | 21:14 |
hub_cap | DORKS | 21:14 |
hub_cap | now go to your freezing homes :) | 21:14 |
hub_cap | and ill go to my rainy one | 21:14 |
hub_cap | peace out | 21:14 |
SlickNik | later dude | 21:15 |
cp16net | peace | 21:17 |
esp | I wish I was going to sf | 21:22 |
datsun180b | i don't | 21:23 |
datsun180b | i might run into hub_cap | 21:23 |
datsun180b | >:3 | 21:23 |
esp | lol | 21:27 |
esp | datsun180b: it's a big city | 21:27 |
*** ViswaV has quit IRC | 21:36 | |
*** krow has joined #openstack-trove | 21:38 | |
*** ViswaV has joined #openstack-trove | 21:38 | |
*** ramashri has joined #openstack-trove | 21:45 | |
openstackgerrit | A change was merged to openstack/trove: Make test mysql connection code less confusing https://review.openstack.org/71088 | 21:47 |
*** jcooley_ has quit IRC | 21:48 | |
*** jcooley_ has joined #openstack-trove | 21:49 | |
openstackgerrit | Paul Lodronio proposed a change to openstack/trove: Adding additional datastore tests https://review.openstack.org/70296 | 21:52 |
*** datsun180b has quit IRC | 21:54 | |
*** datsun180b has joined #openstack-trove | 21:55 | |
datsun180b | did i read that right, something was merged to trove? | 21:56 |
datsun180b | so what tree do i shake to get my conductor changes in? | 21:57 |
esp | hmm | 21:57 |
vipul | datsun180b: I think you're patch is a victim of unfortunate gate slowness | 21:58 |
vipul | https://review.openstack.org/#/c/67611/ | 21:58 |
datsun180b | only so much we can do, but i thought i'd check | 21:58 |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Modifying tests to run with different configurations https://review.openstack.org/71120 | 21:59 |
datsun180b | yeah looked like you guys gave it enough +2s and approves, thanks for that by the way | 21:59 |
cp16net | yeah that sucks | 22:01 |
cp16net | but if you turn in 5 circles and tap your heals maybe it will be done. | 22:02 |
SlickNik | Something is rotten in the state of zuul. | 22:02 |
SlickNik | I don't see datsun180b's change in the gate. | 22:02 |
cp16net | maybe it hasnt picked it up yet | 22:02 |
datsun180b | it'll get there, i'm not worried | 22:02 |
* amcrn lights some candles and speaks in tongues to woo the gate | 22:03 | |
SlickNik | Okay that's better. | 22:03 |
amcrn | ah, there it goes | 22:04 |
cp16net | amcrn: did it! :-P | 22:04 |
amcrn | +1 Slytherins | 22:04 |
SlickNik | lol | 22:04 |
datsun180b | nice, thanks | 22:04 |
datsun180b | now let's see if it can get through the gate without the sphinxes on either side lasering it to death | 22:05 |
SlickNik | datsun180b: Hope you answered their riddles correctly... | 22:05 |
*** vgnbkr_ has quit IRC | 22:09 | |
*** pdmars has quit IRC | 22:10 | |
kevinconway | nah, he just needs to be true of heart | 22:14 |
kevinconway | and have no fear | 22:14 |
kevinconway | datsun180b: doesn't he get shot at, but just dodges the lazers? | 22:15 |
datsun180b | kevinconway: that will suffice | 22:16 |
*** yidclare has quit IRC | 22:16 | |
*** sballe has quit IRC | 22:18 | |
*** Ranjitha has joined #openstack-trove | 22:18 | |
*** michael-yu has joined #openstack-trove | 22:18 | |
*** ashestakov has joined #openstack-trove | 22:21 | |
*** ashestakov has quit IRC | 22:23 | |
*** datsun180b has quit IRC | 22:24 | |
*** ashestakov has joined #openstack-trove | 22:28 | |
denis_makogon_ | ViswaV, ping | 22:30 |
*** jcooley_ has quit IRC | 22:31 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/python-troveclient: Enabled F821, H306, H402, and H404 flake8 rule https://review.openstack.org/66369 | 22:33 |
denis_makogon_ | https://rdjenkins.dyndns.org/job/Trove-Gate/2449/consoleFull - well, someone sees such problem ? | 22:33 |
*** amytron has quit IRC | 22:37 | |
*** datsun180b has joined #openstack-trove | 22:38 | |
*** ashestakov has quit IRC | 22:38 | |
*** Barker has quit IRC | 22:40 | |
*** michael-yu has quit IRC | 22:41 | |
*** yidclare has joined #openstack-trove | 22:43 | |
*** michael-yu has joined #openstack-trove | 22:45 | |
*** annashen_ has joined #openstack-trove | 22:48 | |
openstackgerrit | A change was merged to openstack/trove: Ignore outdated messages sent to conductor https://review.openstack.org/67611 | 22:53 |
*** kevinconway has quit IRC | 22:55 | |
SlickNik | ^^ datsun180b :) | 22:55 |
*** michael-yu has quit IRC | 22:56 | |
amcrn | woo hoo | 22:57 |
*** edmund has quit IRC | 22:59 | |
datsun180b | oh yes | 22:59 |
datsun180b | thank you very much! | 22:59 |
*** rwsu has quit IRC | 23:01 | |
*** jcooley_ has joined #openstack-trove | 23:01 | |
*** rwsu has joined #openstack-trove | 23:02 | |
*** rwsu has quit IRC | 23:06 | |
*** jcooley_ has quit IRC | 23:06 | |
*** robertmyers has quit IRC | 23:09 | |
*** michael-yu has joined #openstack-trove | 23:09 | |
*** datsun180b has quit IRC | 23:09 | |
*** jmontemayor has quit IRC | 23:10 | |
*** rwsu has joined #openstack-trove | 23:19 | |
*** doug_shelley66 has quit IRC | 23:24 | |
*** doug_shelley66 has joined #openstack-trove | 23:25 | |
openstackgerrit | Jenkins proposed a change to openstack/database-api: Updated from global requirements https://review.openstack.org/72022 | 23:25 |
*** datsun180b has joined #openstack-trove | 23:29 | |
*** datsun180b has quit IRC | 23:32 | |
*** ViswaV has quit IRC | 23:33 | |
*** yogesh has quit IRC | 23:42 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Reports enabled-root for restored instance https://review.openstack.org/72025 | 23:42 |
*** yogesh has joined #openstack-trove | 23:43 | |
*** denis_makogon_ has quit IRC | 23:45 | |
plodronio | amcrn , SlickNik , vipul : would appreciate a code-review for https://review.openstack.org/#/c/70296/ - thanks in advance | 23:46 |
*** yogesh has quit IRC | 23:47 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!