*** mat-lowery has quit IRC | 00:08 | |
*** rongze has joined #openstack-trove | 00:14 | |
*** rongze has quit IRC | 00:18 | |
*** mrsnivvel has quit IRC | 00:19 | |
*** mrsnivvel has joined #openstack-trove | 00:19 | |
*** vvutharkar has quit IRC | 00:30 | |
*** amcrn has joined #openstack-trove | 01:09 | |
*** rongze has joined #openstack-trove | 01:15 | |
*** rongze has quit IRC | 01:20 | |
*** demorris has quit IRC | 01:29 | |
*** rongze has joined #openstack-trove | 01:38 | |
*** yogesh has quit IRC | 01:50 | |
*** thedodd has joined #openstack-trove | 01:55 | |
*** thedodd has quit IRC | 01:58 | |
*** plodronio has quit IRC | 02:00 | |
*** plodronio has joined #openstack-trove | 02:16 | |
*** dguitarbite has joined #openstack-trove | 02:17 | |
*** dguitarbite__ has joined #openstack-trove | 02:17 | |
*** rongze has quit IRC | 02:18 | |
*** rongze has joined #openstack-trove | 02:19 | |
*** rongze has quit IRC | 02:19 | |
*** rongze has joined #openstack-trove | 02:20 | |
*** erkules has quit IRC | 02:23 | |
*** rongze has quit IRC | 02:32 | |
*** rongze has joined #openstack-trove | 02:33 | |
*** erkules has joined #openstack-trove | 02:39 | |
*** dguitarbite__ has quit IRC | 02:45 | |
*** dguitarbite has quit IRC | 02:45 | |
*** plodronio has quit IRC | 02:52 | |
*** plodronio has joined #openstack-trove | 03:08 | |
*** plodronio has quit IRC | 03:12 | |
*** plodronio_ has joined #openstack-trove | 03:13 | |
*** laurelm has quit IRC | 03:13 | |
*** harlowja is now known as harlowja_away | 03:51 | |
*** SushilKM__ has joined #openstack-trove | 03:51 | |
openstackgerrit | A change was merged to openstack/trove: Removes privilege modification for MYSQL_BASE_DIR https://review.openstack.org/62724 | 03:58 |
---|---|---|
*** rongze has quit IRC | 04:04 | |
SushilKM__ | needed help to re-run the reddwarf tests for https://review.openstack.org/#/c/64539/ | 04:09 |
*** SushilKM__ has quit IRC | 04:15 | |
openstackgerrit | Mat Lowery proposed a change to openstack/trove-integration: Fix incorrect redirection when staging SSH files. https://review.openstack.org/64778 | 04:50 |
*** plodronio_ has left #openstack-trove | 05:18 | |
*** yogesh has joined #openstack-trove | 05:41 | |
*** krow has joined #openstack-trove | 06:12 | |
*** krow has quit IRC | 06:26 | |
*** dguitarbite has joined #openstack-trove | 06:27 | |
*** amcrn has quit IRC | 06:51 | |
*** amrith has quit IRC | 07:02 | |
*** dguitarbite has quit IRC | 07:06 | |
*** dguitarbite has joined #openstack-trove | 07:09 | |
*** rongze has joined #openstack-trove | 07:12 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Test Checkin, DO NOT REVIEW https://review.openstack.org/64790 | 07:22 |
*** SushilKM has joined #openstack-trove | 07:23 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Relocates guest_config and its implementation https://review.openstack.org/64539 | 07:50 |
*** flaper87|afk is now known as flaper87 | 08:00 | |
*** vipul is now known as vipul-away | 08:27 | |
*** vipul-away is now known as vipul | 08:29 | |
*** vipul is now known as vipul-away | 08:44 | |
openstackgerrit | A change was merged to openstack/trove: Removes directory creation prior to _tmp_mount https://review.openstack.org/62754 | 08:49 |
*** yogesh has quit IRC | 08:51 | |
*** yogesh has joined #openstack-trove | 08:52 | |
*** yogesh has quit IRC | 08:56 | |
*** vipul-away is now known as vipul | 09:00 | |
*** yogeshmehra has joined #openstack-trove | 09:00 | |
*** rongze has quit IRC | 09:10 | |
*** dguitarbite has quit IRC | 09:12 | |
openstackgerrit | A change was merged to openstack/trove: make the bin scripts called with main() https://review.openstack.org/54225 | 09:15 |
*** yogeshmehra has quit IRC | 09:51 | |
*** rongze has joined #openstack-trove | 10:04 | |
*** dguitarbite has joined #openstack-trove | 10:14 | |
*** dguitarbite has quit IRC | 10:26 | |
*** SnowDust has joined #openstack-trove | 10:29 | |
*** dguitarbite has joined #openstack-trove | 10:35 | |
*** dguitarbite has quit IRC | 10:42 | |
*** yogeshmehra has joined #openstack-trove | 11:02 | |
*** yogeshmehra has quit IRC | 11:07 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove-integration: Updates project-list https://review.openstack.org/64517 | 11:20 |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove-integration: Removes devstack duplicated code https://review.openstack.org/64517 | 11:21 |
*** dguitarbite_ has joined #openstack-trove | 11:30 | |
*** dguitarbite_ has quit IRC | 11:36 | |
*** dguitarbite has joined #openstack-trove | 11:50 | |
*** dguitarbite has quit IRC | 12:12 | |
*** dguitarbite_ has joined #openstack-trove | 12:23 | |
*** dguitarbite_ has quit IRC | 12:37 | |
*** dguitarbite has joined #openstack-trove | 12:54 | |
*** dguitarbite has quit IRC | 13:00 | |
*** pdmars has joined #openstack-trove | 13:04 | |
*** rongze has quit IRC | 13:10 | |
*** dguitarbite_ has joined #openstack-trove | 13:23 | |
SushilKM | help needed, plz re-run the tests for https://review.openstack.org/#/c/64517/ | 13:24 |
SushilKM | reddwarf | 13:24 |
*** dguitarbite_ has quit IRC | 13:27 | |
*** SnowDust has quit IRC | 13:30 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Relocates guest_config and its implementation https://review.openstack.org/64539 | 13:33 |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove-integration: Removes devstack duplicated code https://review.openstack.org/64517 | 13:37 |
*** konetzed has quit IRC | 13:39 | |
*** konetzed has joined #openstack-trove | 13:39 | |
*** rongze has joined #openstack-trove | 13:41 | |
*** radez_g0n3 is now known as radez | 13:44 | |
*** dguitarbite has joined #openstack-trove | 13:49 | |
*** rongze has quit IRC | 13:52 | |
*** dguitarbite has quit IRC | 14:01 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Relocates guest_config and its implementation https://review.openstack.org/64539 | 14:14 |
*** jcru has joined #openstack-trove | 14:18 | |
*** SushilKM has quit IRC | 14:18 | |
*** robertmyers has joined #openstack-trove | 14:30 | |
*** robertmyers has quit IRC | 14:32 | |
*** robertmyers has joined #openstack-trove | 14:32 | |
*** robertmyers has quit IRC | 14:38 | |
*** robertmyers has joined #openstack-trove | 14:39 | |
*** rongze has joined #openstack-trove | 14:45 | |
*** rongze has quit IRC | 14:50 | |
*** rongze has joined #openstack-trove | 14:56 | |
*** mrsnivvel has quit IRC | 15:04 | |
*** radez is now known as radez_g0n3 | 15:09 | |
*** kevinconway has joined #openstack-trove | 15:13 | |
*** jmontemayor has joined #openstack-trove | 15:18 | |
*** jimbobhickville has joined #openstack-trove | 15:20 | |
openstackgerrit | Robert Myers proposed a change to openstack/trove-integration: Removing keystone account creation https://review.openstack.org/64842 | 15:20 |
*** thedodd has joined #openstack-trove | 15:22 | |
*** russellb is now known as rustlebee | 15:23 | |
*** datsun180b has joined #openstack-trove | 15:24 | |
*** laurelm has joined #openstack-trove | 15:32 | |
*** radez_g0n3 is now known as radez | 15:33 | |
*** rnirmal has joined #openstack-trove | 15:47 | |
*** demorris has joined #openstack-trove | 15:53 | |
*** SushilKM has joined #openstack-trove | 16:28 | |
SushilKM | Hi Robert | 16:31 |
SushilKM | @robertmyers | 16:31 |
*** SushilKM has quit IRC | 16:31 | |
robertmyers | and he's gone | 16:40 |
*** SushilKM has joined #openstack-trove | 16:50 | |
*** SushilKM has quit IRC | 16:51 | |
*** SushilKM has joined #openstack-trove | 16:54 | |
*** SushilKM has joined #openstack-trove | 17:00 | |
*** radez is now known as radez_g0n3 | 17:04 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Relocates guest_config and its implementation https://review.openstack.org/64539 | 17:04 |
*** demorris has quit IRC | 17:17 | |
*** flaper87 is now known as flaper87|afk | 17:24 | |
*** harlowja_away is now known as harlowja | 17:38 | |
*** demorris has joined #openstack-trove | 17:44 | |
*** datsun180b has quit IRC | 17:49 | |
*** amcrn has joined #openstack-trove | 17:58 | |
*** ViswaVutharkar has joined #openstack-trove | 18:12 | |
*** ViswaVutharkar is now known as ViswaV | 18:13 | |
*** ViswaV has left #openstack-trove | 18:14 | |
*** ViswaV has joined #openstack-trove | 18:14 | |
*** SushilKM has quit IRC | 18:20 | |
*** thedodd has quit IRC | 18:20 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Relocates guest_config and its implementation https://review.openstack.org/64539 | 18:22 |
*** SushilKM has joined #openstack-trove | 18:23 | |
*** rwsu has quit IRC | 18:28 | |
jimbobhickville | can someone explain the logic behind having the model classes not inherit from the DatabaseModelBase and instead having a separate DB class that does that and then passing that in to the model class? | 18:29 |
jimbobhickville | for example, DBDatastore vs Datastore | 18:30 |
hub_cap | jimbobhickville: some of that is cuz the "data" is not in our db | 18:31 |
hub_cap | for instance, info about flavors | 18:31 |
hub_cap | or the ips for a instance | 18:31 |
hub_cap | so the _transformation_ is some stuff in our db + some stuff from nova | 18:31 |
hub_cap | but for that, i cant relaly speak to it other than | 18:31 |
hub_cap | maybe to detach a session from a "DO" in java speak? | 18:31 |
jimbobhickville | I don't speak Java :D | 18:32 |
hub_cap | HAH | 18:32 |
hub_cap | data object | 18:32 |
hub_cap | aka, remove teh abiltiy fo ryour blah.foo = "X" to actually update the db | 18:32 |
hub_cap | god i cant type | 18:32 |
jimbobhickville | ah, so that gives you more control over readonly fields and whatnot? | 18:32 |
hub_cap | again this is a guess, but yes? im not sure why its like that though honestly | 18:33 |
hub_cap | just a stab | 18:33 |
jimbobhickville | just seems needlessly complex at first glance, so I thought I'd see if I could understand the rationale | 18:33 |
hub_cap | its entirely possible u cant modify a sqlalchemy object loaded w/o calling save explicitly (/me is still a python n00b compared to java heh) | 18:33 |
jimbobhickville | I can't speak for SQLAlchemy, but I know that some other ORMs won't call the update until you explicitly save or call update with a list of key/value pairs to update directly | 18:34 |
jimbobhickville | it just tracks the changes internally until that point | 18:34 |
jimbobhickville | is this just a case of someone did it this way at one point and everyone else based their code off that? | 18:36 |
jimbobhickville | I hope I'm not coming off as critical, just trying to understand | 18:37 |
*** kevinconway has quit IRC | 18:38 | |
hub_cap | jimbobhickville: if u come across as wanting to make the code better, its good by me, no matter how u ask it ;) | 18:44 |
*** datsun180b has joined #openstack-trove | 18:44 | |
hub_cap | well almost _no matter how_ heh | 18:44 |
jimbobhickville | heh. this code is dirty as hell and I'm not gonna take it any more!!! | 18:44 |
hub_cap | jimbobhickville: horray | 18:45 |
hub_cap | that wont hurt me either ;) | 18:45 |
hub_cap | just so u know, this is what im talking about in the hibernate java orm world https://docs.jboss.org/hibernate/core/3.3/reference/en-US/html/objectstate.html#objectstate-modifying | 18:45 |
*** kevinconway has joined #openstack-trove | 18:45 | |
*** yogesh has joined #openstack-trove | 18:45 | |
hub_cap | for better or worse jimbobhickville stay far away from that link | 18:48 |
jimbobhickville | heh, why is that? | 18:48 |
jimbobhickville | also I've noticed that the db classes don't specify what table they belong to… is there some magic that derives that somewhere? | 18:50 |
kevinconway | it's been a while since i looked, but i think it's based off the model name | 18:52 |
kevinconway | of if you search for __table__ or __tablename__ attributes somewhere | 18:52 |
jimbobhickville | __table wasn't found at all in the trove codebase | 18:53 |
kevinconway | trove/db/sqlalchemy/mappers | 18:54 |
kevinconway | also, most of the time you are not directly using sqlalchemy models | 18:55 |
kevinconway | we have our own wrappers around them | 18:55 |
jimbobhickville | so we have to define the mapping in a separate file rather than specifying the table name within the model definition? | 18:55 |
*** thedodd has joined #openstack-trove | 18:55 | |
hub_cap | robertmyers: question sir | 18:56 |
hub_cap | jimbobhickville: using our awesome tooling at present yes | 18:56 |
hub_cap | robertmyers: did u write the _addition_ of colorized logs in the guest output? | 18:56 |
hub_cap | it seems that redstack is editing stuff in our git tree, which is not cool | 18:57 |
robertmyers | hub_cap: no, I just consolidated the two versions of it | 18:57 |
kevinconway | jimbobhickville: sqlalchemy ORM models have you define the table name when you create the class | 18:57 |
robertmyers | hub_cap: oh that | 18:58 |
kevinconway | i'm guessing the mapper is part of our abstraction | 18:58 |
hub_cap | robertmyers: kk. is there a reason its just not natureally enabled in teh guest config file? | 18:58 |
hub_cap | kevinconway: jimbobhickville i would love to see the entire db layer written in a less sucky way | 18:58 |
robertmyers | hub_cap: yeah, maybe we should just put that in there | 18:58 |
hub_cap | but maybe next cycle since we are in the 2nd milestone already ;) | 18:58 |
hub_cap | robertmyers: ya its hella annoying lol | 18:59 |
jimbobhickville | fair enough, that'll give me time to learn SQLAlchemy better | 18:59 |
robertmyers | hub_cap: we could just commit the changes :) | 18:59 |
kevinconway | hub_cap: is there a requirement that we need an abstraction of sqla? | 18:59 |
kevinconway | or i guess the question would be does trove need to run on nosql databases? | 18:59 |
hub_cap | https://github.com/openstack-dev/devstack/commit/0f9a1b058423b293935b414b2035713d8ead3e71 <-- sweet | 19:00 |
hub_cap | kevinconway: its not the sweet spot reallly, right grapex? | 19:00 |
hub_cap | HAH | 19:00 |
hub_cap | im sure thats recorded somewhere | 19:00 |
jimbobhickville | wouldn't it just be better to add nosql support to sqlalchemy's ORM instead of having our own secondary ORM in that case? | 19:01 |
jimbobhickville | a lot of nosql implementations actually support a SQL-ish query language these days, like CQL for Cassandra and was it Pig or Hive for Hadoop (I can't recall) | 19:01 |
kevinconway | i'm pretty sure sqlalchemy is specific to relational databases | 19:02 |
kevinconway | as a project i mean. | 19:02 |
jimbobhickville | we could implement NoSQLAlchemy which just mimics the SQLAlchemy ORM objects but with a backend for nosql systems :D | 19:03 |
jimbobhickville | it's kind of a pointless exercise anyway since it seems unlikely that trove will be moving in that direction any time soon | 19:04 |
hub_cap | correct | 19:04 |
hub_cap | lets worry about impl'ing a nosql datastore before we make our infrastructure run on nosql ;) | 19:04 |
hub_cap | a bit of history | 19:04 |
jimbobhickville | heh, indeed | 19:04 |
hub_cap | openstack had a redis impl for a while (Backend) | 19:05 |
hub_cap | its gotta be in the git tree somewhere | 19:05 |
jimbobhickville | we used cassandra for really heavy write stuff at my last job, but it was just for places where the load was killing us using postgres | 19:05 |
jimbobhickville | wouldn't make sense to put the whole thing in there | 19:05 |
hub_cap | u gotta go far back though (https://github.com/openstack/nova/tree/3dcc46bc5cea6011e578bf67391daef2789a8505) | 19:06 |
hub_cap | heh | 19:06 |
hub_cap | jimbobhickville: ya, they have their places | 19:07 |
*** rongze has quit IRC | 19:15 | |
*** rongze has joined #openstack-trove | 19:16 | |
*** rongze has quit IRC | 19:20 | |
*** SushilKM has quit IRC | 19:22 | |
*** SushilKM has joined #openstack-trove | 19:23 | |
*** SushilKM__ has joined #openstack-trove | 19:23 | |
jimbobhickville | is there a trove roadmap somewhere by chance? the openstack wiki doesn't make reference to one | 19:41 |
*** rwsu has joined #openstack-trove | 19:41 | |
*** ViswaV has quit IRC | 19:46 | |
jimbobhickville | is it a safe assumption that new code should have both unit tests and API tests? | 19:51 |
*** SushilKM has quit IRC | 19:51 | |
*** SushilKM__ has quit IRC | 19:51 | |
datsun180b | jimbobhickville: i'd say so | 19:57 |
datsun180b | what can we do, politely suggest you remove perfectly good tests after the fact? | 19:57 |
*** vipul is now known as vipul-away | 20:00 | |
jimbobhickville | lol, just wondered if it was an explicit goal for test coverage or if it was more lax than that | 20:03 |
jimbobhickville | some things seem to be absent unit tests like datastores, so I wasn't sure | 20:03 |
jimbobhickville | thought maybe there was a non-obvious rule of thumb or something | 20:06 |
*** vipul-away is now known as vipul | 20:07 | |
datsun180b | ¯\_(ツ)_/¯ | 20:07 |
*** flaper87|afk is now known as flaper87 | 20:08 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Removes server from FreshInstanceTasks.create_instance https://review.openstack.org/64896 | 20:10 |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Removes unused "server" from taskmanager https://review.openstack.org/64896 | 20:15 |
*** rongze has joined #openstack-trove | 20:16 | |
openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Removes unused "server" from taskmanager https://review.openstack.org/64896 | 20:17 |
*** radez_g0n3 is now known as radez | 20:20 | |
openstackgerrit | Robert Myers proposed a change to openstack/trove-integration: Removing keystone account creation https://review.openstack.org/64842 | 20:21 |
cp16net | what does this line do? assert True, create_connection | 20:21 |
*** viswav has joined #openstack-trove | 20:21 | |
robertmyers | should be assert create_connection | 20:22 |
*** vipul is now known as vipul-away | 20:23 | |
*** rongze has quit IRC | 20:23 | |
*** vipul-away is now known as vipul | 20:42 | |
*** jimbobhickville1 has joined #openstack-trove | 20:48 | |
*** jimbobhickville has quit IRC | 20:48 | |
*** jimbobhickville has joined #openstack-trove | 20:51 | |
*** jimbobhickville1 has quit IRC | 20:51 | |
*** vipul is now known as vipul-away | 20:59 | |
*** krow has joined #openstack-trove | 21:01 | |
*** vipul-away is now known as vipul | 21:02 | |
*** krow has quit IRC | 21:06 | |
*** krow has joined #openstack-trove | 21:07 | |
*** vipul is now known as vipul-away | 21:08 | |
*** vipul-away is now known as vipul | 21:08 | |
*** rongze has joined #openstack-trove | 21:19 | |
*** rongze has quit IRC | 21:23 | |
*** viswav has quit IRC | 21:30 | |
*** jimbobhickville has quit IRC | 21:37 | |
*** jimbobhickville has joined #openstack-trove | 21:38 | |
*** vipul is now known as vipul-away | 21:56 | |
*** vipul-away is now known as vipul | 21:56 | |
*** pdmars has quit IRC | 22:07 | |
*** SergeyLukjanov has joined #openstack-trove | 22:10 | |
*** ViswaV has joined #openstack-trove | 22:19 | |
*** rongze has joined #openstack-trove | 22:20 | |
openstackgerrit | Robert Myers proposed a change to openstack/trove-integration: Removing keystone account creation https://review.openstack.org/64842 | 22:22 |
*** rongze has quit IRC | 22:25 | |
*** vipul is now known as vipul-away | 22:35 | |
*** vipul-away is now known as vipul | 22:36 | |
*** kevinconway has quit IRC | 22:59 | |
*** robertmyers has quit IRC | 22:59 | |
*** jcru has quit IRC | 22:59 | |
*** datsun180b has quit IRC | 23:02 | |
*** jimbobhickville has quit IRC | 23:05 | |
*** flaper87 is now known as flaper87|afk | 23:15 | |
*** thedodd has quit IRC | 23:16 | |
*** rongze has joined #openstack-trove | 23:20 | |
*** thedodd has joined #openstack-trove | 23:21 | |
*** rongze has quit IRC | 23:25 | |
*** SergeyLukjanov has quit IRC | 23:26 | |
*** vipul is now known as vipul-away | 23:30 | |
*** vipul-away is now known as vipul | 23:30 | |
*** thedodd has quit IRC | 23:35 | |
*** jmontemayor has quit IRC | 23:36 | |
*** vipul is now known as vipul-away | 23:46 | |
*** yogesh has quit IRC | 23:46 | |
*** rnirmal has quit IRC | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!