| *** amytron has quit IRC | 00:00 | |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Validate databases for user grants https://review.openstack.org/59529 | 00:00 |
|---|---|---|
| *** flaper87 is now known as flaper87|afk | 00:12 | |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Validate databases for user grants https://review.openstack.org/59529 | 00:21 |
| *** harlowja has quit IRC | 00:40 | |
| *** harlowja has joined #openstack-trove | 00:42 | |
| openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Validate databases for user grants https://review.openstack.org/59529 | 00:46 |
| *** esp has left #openstack-trove | 00:49 | |
| *** vipul has quit IRC | 00:51 | |
| *** vipul has joined #openstack-trove | 00:52 | |
| *** jcooley_ has joined #openstack-trove | 00:56 | |
| *** yogeshmehra has joined #openstack-trove | 01:03 | |
| *** yidclare has quit IRC | 01:08 | |
| openstackgerrit | SlickNik proposed a change to openstack/trove: Remove comments from empty __init__.py files https://review.openstack.org/60393 | 01:11 |
| openstackgerrit | SlickNik proposed a change to openstack/trove: Remove comments from empty __init__.py files https://review.openstack.org/60393 | 01:13 |
| *** yogeshmehra has quit IRC | 01:22 | |
| *** mmcdaris has joined #openstack-trove | 01:37 | |
| *** nosnos has joined #openstack-trove | 01:42 | |
| *** tanisdl has quit IRC | 02:01 | |
| *** jcooley_ has quit IRC | 02:03 | |
| *** jcooley_ has joined #openstack-trove | 02:04 | |
| *** mmcdaris has quit IRC | 02:07 | |
| *** jcooley_ has quit IRC | 02:08 | |
| *** rongze has joined #openstack-trove | 02:12 | |
| *** robertmyers has joined #openstack-trove | 02:16 | |
| *** jcooley_ has joined #openstack-trove | 02:19 | |
| *** mmcdaris has joined #openstack-trove | 02:26 | |
| *** mmcdaris has quit IRC | 02:40 | |
| *** erkules_ has joined #openstack-trove | 02:44 | |
| *** erkules has quit IRC | 02:47 | |
| *** erkules_ has quit IRC | 02:48 | |
| *** erkules_ has joined #openstack-trove | 02:50 | |
| *** vipul is now known as vipul-away | 03:05 | |
| *** mmcdaris has joined #openstack-trove | 03:07 | |
| *** amcrn has quit IRC | 03:08 | |
| *** vipul-away is now known as vipul | 03:11 | |
| *** robertmyers has quit IRC | 03:24 | |
| *** jcooley_ has quit IRC | 03:29 | |
| *** jcooley_ has joined #openstack-trove | 03:30 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: .gitignore some extra generated files and test user creds for cli https://review.openstack.org/59527 | 03:31 |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: fake mode script needs to be updated after changed were merged in trove https://review.openstack.org/58441 | 03:31 |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: changes to support configuration groups https://review.openstack.org/58445 | 03:31 |
| *** jcooley_ has quit IRC | 03:34 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: fake mode script needs to be updated after changed were merged in trove https://review.openstack.org/58441 | 03:39 |
| *** krast has joined #openstack-trove | 03:43 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: .gitignore some extra generated files and test user creds for cli https://review.openstack.org/59527 | 03:43 |
| *** shalini has quit IRC | 03:47 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove: adding configuration group support https://review.openstack.org/53168 | 03:53 |
| *** shalini has joined #openstack-trove | 04:02 | |
| *** erkules_ is now known as erkules | 04:23 | |
| *** mmcdaris has quit IRC | 04:25 | |
| *** mmcdaris has joined #openstack-trove | 04:28 | |
| *** rongze has quit IRC | 04:50 | |
| *** rongze has joined #openstack-trove | 04:54 | |
| *** jcooley_ has joined #openstack-trove | 04:55 | |
| *** esp has joined #openstack-trove | 04:56 | |
| *** esp has left #openstack-trove | 04:59 | |
| *** shalini has quit IRC | 05:06 | |
| *** jcooley_ has quit IRC | 05:22 | |
| *** jcooley_ has joined #openstack-trove | 05:22 | |
| *** jcooley_ has quit IRC | 05:27 | |
| *** vipul has quit IRC | 05:52 | |
| *** vipul has joined #openstack-trove | 05:53 | |
| *** yogeshmehra has joined #openstack-trove | 05:59 | |
| *** yogeshmehra has quit IRC | 06:00 | |
| *** yogeshmehra has joined #openstack-trove | 06:06 | |
| *** denis_makogon has joined #openstack-trove | 06:27 | |
| *** yogeshmehra has joined #openstack-trove | 06:30 | |
| *** nosnos_ has joined #openstack-trove | 06:30 | |
| *** mmcdaris has quit IRC | 06:31 | |
| *** nosnos has quit IRC | 06:33 | |
| *** yogeshmehra has quit IRC | 06:40 | |
| *** jumping_Bond has joined #openstack-trove | 06:41 | |
| *** jumping_Bond has quit IRC | 06:41 | |
| *** Flying_Bond has joined #openstack-trove | 06:42 | |
| *** Flying_Bond has quit IRC | 06:43 | |
| *** Flying_Bond has joined #openstack-trove | 06:43 | |
| *** mmcdaris has joined #openstack-trove | 06:44 | |
| *** yogesh has joined #openstack-trove | 06:44 | |
| *** mmcdaris has quit IRC | 06:55 | |
| *** denis_makogon has quit IRC | 07:14 | |
| *** yogesh has quit IRC | 07:22 | |
| *** yogesh has joined #openstack-trove | 07:40 | |
| *** yogesh_ has joined #openstack-trove | 07:43 | |
| *** yogesh has quit IRC | 07:45 | |
| *** yogesh has joined #openstack-trove | 07:46 | |
| *** yogesh_ has quit IRC | 07:46 | |
| *** mmcdaris has joined #openstack-trove | 07:51 | |
| *** yogeshmehra has joined #openstack-trove | 07:51 | |
| *** yogeshmehra has quit IRC | 07:56 | |
| *** flaper87|afk is now known as flaper87 | 07:56 | |
| *** Flying_Bond has quit IRC | 08:20 | |
| *** mmcdaris_ has joined #openstack-trove | 08:27 | |
| *** krast_ has joined #openstack-trove | 08:30 | |
| *** hub_cap_ has joined #openstack-trove | 08:31 | |
| *** esmute_ has joined #openstack-trove | 08:33 | |
| *** esmute has quit IRC | 08:34 | |
| *** lifeless has quit IRC | 08:34 | |
| *** isviridov has quit IRC | 08:34 | |
| *** mmcdaris has quit IRC | 08:34 | |
| *** krast has quit IRC | 08:34 | |
| *** hub_cap has quit IRC | 08:34 | |
| *** isviridov has joined #openstack-trove | 08:34 | |
| *** mmcdaris_ is now known as mmcdaris | 08:35 | |
| *** rongze_ has joined #openstack-trove | 08:35 | |
| *** esmute_ is now known as esmute | 08:35 | |
| *** lifeless has joined #openstack-trove | 08:36 | |
| *** rongze has quit IRC | 08:37 | |
| *** haomaiwang has joined #openstack-trove | 08:44 | |
| *** nosnos_ has quit IRC | 09:29 | |
| *** nosnos has joined #openstack-trove | 09:29 | |
| *** yogesh has quit IRC | 09:30 | |
| *** Flying_Bond has joined #openstack-trove | 09:32 | |
| *** yogeshmehra has joined #openstack-trove | 09:32 | |
| *** yogeshmehra has quit IRC | 09:59 | |
| *** bot_bot is now known as denis_makogon | 10:09 | |
| *** krast_ has quit IRC | 10:34 | |
| *** nosnos_ has joined #openstack-trove | 10:44 | |
| *** nosnos has quit IRC | 10:48 | |
| *** Flying_Bond has quit IRC | 10:49 | |
| *** rongze_ has quit IRC | 11:17 | |
| *** rongze has joined #openstack-trove | 11:28 | |
| *** pdmars has joined #openstack-trove | 12:48 | |
| *** pdmars has quit IRC | 12:49 | |
| *** pdmars has joined #openstack-trove | 12:50 | |
| *** abramley has joined #openstack-trove | 13:02 | |
| *** nosnos_ has quit IRC | 13:11 | |
| *** demorris has joined #openstack-trove | 13:29 | |
| *** mmcdaris has quit IRC | 13:36 | |
| *** mmcdaris has joined #openstack-trove | 13:59 | |
| *** radez_g0n3 is now known as radez | 14:14 | |
| *** rnirmal has joined #openstack-trove | 14:32 | |
| *** russellb is now known as rustlebee | 14:38 | |
| *** cweid has joined #openstack-trove | 14:53 | |
| *** robertmyers has joined #openstack-trove | 14:53 | |
| *** ashestakov has joined #openstack-trove | 14:53 | |
| *** rongze has quit IRC | 15:00 | |
| *** robertmyers has quit IRC | 15:04 | |
| *** rongze has joined #openstack-trove | 15:16 | |
| *** mmcdaris has quit IRC | 15:17 | |
| *** jcru has joined #openstack-trove | 15:28 | |
| *** amytron has joined #openstack-trove | 15:33 | |
| *** tanisdl has joined #openstack-trove | 15:36 | |
| *** datsun180b has joined #openstack-trove | 15:36 | |
| *** SushilKM has joined #openstack-trove | 15:38 | |
| *** plodronio has joined #openstack-trove | 15:48 | |
| *** jmontemayor has joined #openstack-trove | 15:49 | |
| *** SushilKM has quit IRC | 15:50 | |
| *** demorris_ has joined #openstack-trove | 16:01 | |
| *** demorris has quit IRC | 16:01 | |
| *** demorris_ is now known as demorris | 16:01 | |
| *** jcooley_ has joined #openstack-trove | 16:10 | |
| *** jasonb365 has joined #openstack-trove | 16:10 | |
| *** robertmy_ has joined #openstack-trove | 16:11 | |
| *** robertmy_ has quit IRC | 16:13 | |
| *** robertmy_ has joined #openstack-trove | 16:13 | |
| *** robertm__ has joined #openstack-trove | 16:17 | |
| *** robertmy_ has quit IRC | 16:18 | |
| *** robertm__ has quit IRC | 16:18 | |
| *** robertmy_ has joined #openstack-trove | 16:20 | |
| *** robertmy_ has quit IRC | 16:22 | |
| *** robertmyers has joined #openstack-trove | 16:22 | |
| *** robertmyers has quit IRC | 16:23 | |
| hub_cap_ | hey, austin is frozen, so it might be a while before the cro-magnon start stirring... its gotta thaw there first | 16:25 |
| *** hub_cap_ is now known as hub_cap | 16:25 | |
| *** robertmyers has joined #openstack-trove | 16:25 | |
| denis_makogon | hub_cap, hi =) | 16:26 |
| hub_cap | howdy | 16:26 |
| hub_cap | also, im not here to work yet, i still have to make coffee/breakfast but ill be back in ~30 minutes | 16:28 |
| denis_makogon | https://review.openstack.org/#/c/60553/ https://review.openstack.org/#/c/60532/ | 16:30 |
| denis_makogon | it might be interesting | 16:30 |
| ikhudoshyn | hub_cap, hey, ive got +1s from robots at last, could u pls check https://review.openstack.org/#/c/57189/ | 16:35 |
| hub_cap | commented on the first one denis_makogon .. u might want to update the commit msg | 16:36 |
| denis_makogon | hub_cap, already | 16:36 |
| hub_cap | ikhudoshyn: im not really around for like ~20 more min... remind me | 16:36 |
| ikhudoshyn | hub_cap, sure | 16:36 |
| *** ashestakov has quit IRC | 16:39 | |
| hub_cap | ikhudoshyn: i lied, i did it | 16:39 |
| hub_cap | and my wife poured me coffee cuz i havent left my desk now hehe | 16:41 |
| *** jcooley_ has quit IRC | 17:10 | |
| demorris | curious, how do y'all program? http://www.reddit.com/r/ProgrammerHumor/comments/1rx2p0/programming_in_movies_vs_programming_in_real_life/ | 17:18 |
| hub_cap | demorris: OMG LOL | 17:23 |
| hub_cap | im def the green screen one | 17:23 |
| demorris | :) | 17:23 |
| *** Flying_Bond has joined #openstack-trove | 17:24 | |
| *** ashestakov has joined #openstack-trove | 17:24 | |
| *** mmcdaris has joined #openstack-trove | 17:25 | |
| demorris | I am more this style - http://www.youtube.com/watch?v=dxIPcbmo1_U | 17:28 |
| *** SushilKM has joined #openstack-trove | 17:30 | |
| *** grapex has joined #openstack-trove | 17:31 | |
| hub_cap | omg | 17:32 |
| hub_cap | if it wasnt for that stupid slow UI, she wouldve hacked that so miuch faster | 17:32 |
| demorris | It's a Unix system! | 17:32 |
| hub_cap | i know this! | 17:33 |
| hub_cap | lol @ that line | 17:33 |
| hub_cap | hmmmmm i dont know if i should map shift+bkspace or super+bkspace ot delete | 17:34 |
| hub_cap | what do yall recommend? | 17:34 |
| hub_cap | im thinking shift | 17:34 |
| pdmars | demorris: "Denis, our lives are in your hands and you have butterfingers?" | 17:34 |
| hub_cap | pdmars: its actually buttafingahs | 17:35 |
| pdmars | hub_cap: true | 17:35 |
| hub_cap | http://www.hark.com/clips/wsmqpbjnpb-lives-are-in-your-hands-and-you-have-butter-fingers | 17:35 |
| hub_cap | i couldnt do an inflection in the text tho | 17:36 |
| pdmars | that was pretty close | 17:36 |
| hub_cap | ya i think the a needed a umlaut or something | 17:36 |
| hub_cap | maybe a accent mark | 17:36 |
| hub_cap | :P | 17:36 |
| demorris | pdmars: :) | 17:37 |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Updates tox.ini to remove suppressed https://review.openstack.org/60564 | 17:38 |
| *** esp has joined #openstack-trove | 17:48 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Updates tox.ini to remove suppressed H403, H702. https://review.openstack.org/60564 | 17:52 |
| *** flaper87 is now known as flaper87|afk | 17:54 | |
| *** mmcdaris has quit IRC | 17:54 | |
| hub_cap | brb in a bit | 17:55 |
| *** grapex has quit IRC | 17:56 | |
| *** rnirmal has quit IRC | 18:05 | |
| *** SushilKM has quit IRC | 18:05 | |
| *** grapex has joined #openstack-trove | 18:07 | |
| *** SnowDust has joined #openstack-trove | 18:11 | |
| datsun180b | so what's it take to ask for some eyeballs on an itty bitty tiny baby fix that's been sort of sitting around for a while like https://review.openstack.org/#/c/56966/ and would just love to get merged | 18:14 |
| *** yogesh has joined #openstack-trove | 18:18 | |
| *** demorris has quit IRC | 18:21 | |
| *** yogesh has quit IRC | 18:23 | |
| *** yogesh has joined #openstack-trove | 18:23 | |
| *** yogesh has quit IRC | 18:23 | |
| *** yogesh has joined #openstack-trove | 18:24 | |
| *** yidclare has joined #openstack-trove | 18:26 | |
| *** rnirmal has joined #openstack-trove | 18:31 | |
| *** amcrn has joined #openstack-trove | 18:32 | |
| *** Flying_Bond has quit IRC | 18:33 | |
| *** mmcdaris has joined #openstack-trove | 18:36 | |
| *** Flying_Bond has joined #openstack-trove | 18:38 | |
| *** yogeshmehra has joined #openstack-trove | 18:40 | |
| SlickNik | hub_cap / grapex: Can you guys take a look at https://review.openstack.org/#/c/58062/ and https://review.openstack.org/#/c/58066/ when you get a chance? Thanks! | 18:42 |
| *** imsplitbit has quit IRC | 18:49 | |
| *** Ikhudoshyn__ has joined #openstack-trove | 18:49 | |
| openstackgerrit | A change was merged to openstack/trove: Added ability to pass custom command-line options to backup runner https://review.openstack.org/58062 | 18:49 |
| openstackgerrit | A change was merged to openstack/trove: Clean up zombie processes on backup failure https://review.openstack.org/58066 | 18:51 |
| *** Ikhudoshyn__ has quit IRC | 18:58 | |
| *** yogeshmehra has quit IRC | 18:58 | |
| *** tanisdl has quit IRC | 18:59 | |
| *** westmaas is now known as westmau5 | 19:07 | |
| SlickNik | Thanks grapex! | 19:07 |
| datsun180b | cool, thanks for looking at that, i'll rebase it | 19:11 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: RootReport through Conductor https://review.openstack.org/59410 | 19:12 |
| openstackgerrit | A change was merged to openstack/trove: setting fake mode to print startup errors https://review.openstack.org/58440 | 19:13 |
| openstackgerrit | Ed Cranford proposed a change to openstack/trove: Extract suffix from req URL to avoid escaping dots https://review.openstack.org/56966 | 19:14 |
| *** tanisdl has joined #openstack-trove | 19:16 | |
| openstackgerrit | Andrey Shestakov proposed a change to openstack/python-troveclient: Datastore support improvements https://review.openstack.org/60588 | 19:16 |
| *** mmcdaris has quit IRC | 19:17 | |
| *** plodronio has left #openstack-trove | 19:22 | |
| openstackgerrit | A change was merged to openstack/trove: Unittest Case for get_user https://review.openstack.org/48201 | 19:47 |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: changes to support configuration groups https://review.openstack.org/58445 | 19:48 |
| *** radez is now known as radez_g0n3 | 19:49 | |
| *** freyes has quit IRC | 19:49 | |
| *** yogeshmehra has joined #openstack-trove | 19:49 | |
| *** yogeshmehra has quit IRC | 19:50 | |
| grapex | I've got a question for the room: Why are all of these pull requests for the guests have the agent raise NotImplementedError? Seems like Trove should be able to figure out if an agent won't be able to do some action based on the datastore type. | 19:50 |
| grapex | Also, there's really no difference between raising NotImplementedError and simply not adding the method- both suggest the agent can't support the RPC call. | 19:50 |
| *** amytron has quit IRC | 19:51 | |
| kevinconway | grapex: what response gets sent back if the method it's looking for isn't there? | 19:52 |
| grapex | The guest manager should raise an exception saying there is no such method. | 19:52 |
| grapex | So to me it's the same- raising NotImplementedErrors everywhere seems unnecessary | 19:53 |
| kevinconway | i guess raising NotImplemented would only be required if the guest used an ABCMeta | 19:53 |
| grapex | Yeah- it already uses that Manager class which should inform the caller the method it wanted is missing | 19:54 |
| *** mmcdaris has joined #openstack-trove | 19:56 | |
| *** yidclare has quit IRC | 19:57 | |
| ikhudoshyn | grapex, SlickNik hi, guys, could u pls take a look https://review.openstack.org/#/c/57189/ | 19:57 |
| *** mmcdaris has quit IRC | 19:57 | |
| *** mmcdaris has joined #openstack-trove | 19:58 | |
| *** vipul is now known as vipul-away | 19:59 | |
| *** vipul-away is now known as vipul | 19:59 | |
| cp16net | grapex: yeah i think that makes sense but will that raise a different exception if the call went to the wrong manager? | 19:59 |
| grapex | cp16net: Wrong manager? | 20:01 |
| *** datsun_F40PH has joined #openstack-trove | 20:06 | |
| datsun_F40PH | oh neat, my vpn decided to take a nap | 20:06 |
| datsun_F40PH | well at least i'm on public | 20:06 |
| cp16net | grapex: well if the manger didnt have the method | 20:07 |
| cp16net | thats what i was thinking | 20:07 |
| grapex | cp16net: Then the RPC call simply fails with some exception saying the method wasn't there. | 20:08 |
| *** datsun180b has quit IRC | 20:08 | |
| *** datsun_F40PH is now known as datsun180b | 20:08 | |
| kevinconway | grapex: does it return a 501 NotImplemented as the final status when the RPC fails to find the method? | 20:10 |
| *** mmcdaris has left #openstack-trove | 20:10 | |
| kevinconway | I haven't looked into the mechanism that does it, but there are 400 BadRequest exceptions thrown in the mysql guest that bubble up to the client that called the API | 20:10 |
| kevinconway | so should they maybe raise HTTPNotImplmented of some kind? like a trove exception? | 20:11 |
| *** mwagner_lap has joined #openstack-trove | 20:11 | |
| *** yogesh has quit IRC | 20:12 | |
| *** yogesh has joined #openstack-trove | 20:12 | |
| *** Flying_Bond has quit IRC | 20:14 | |
| grapex | ikhudoshyn: https://review.openstack.org/#/c/57189/ I responded | 20:14 |
| grapex | One qualm: please rename "mount_point" to "data_dir" where it appears in the backup code | 20:15 |
| grapex | Someone reading the code might infer that we're doing backups of the entire volume which may or may not be true for all datastores. | 20:15 |
| *** rongze has quit IRC | 20:15 | |
| *** yogesh has quit IRC | 20:17 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: fake mode update after changes to trove https://review.openstack.org/58441 | 20:21 |
| *** harlowja has quit IRC | 20:23 | |
| *** imsplitbit has joined #openstack-trove | 20:23 | |
| *** harlowja has joined #openstack-trove | 20:23 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove-integration: fake mode update after changes to trove https://review.openstack.org/58441 | 20:30 |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove: revert change to the trove.test.conf https://review.openstack.org/60612 | 20:33 |
| *** tanisdl has quit IRC | 20:52 | |
| *** denis_makogon_ has joined #openstack-trove | 20:52 | |
| *** denis_makogon has quit IRC | 20:58 | |
| *** denis_makogon_ is now known as denis_makogon | 20:58 | |
| *** tanisdl has joined #openstack-trove | 20:58 | |
| *** dmakogon_ has joined #openstack-trove | 20:58 | |
| denis_makogon | guys, could you please review https://review.openstack.org/#/c/59410/ | 20:59 |
| *** SnowDust has quit IRC | 21:00 | |
| *** yogesh has joined #openstack-trove | 21:06 | |
| *** demorris has joined #openstack-trove | 21:11 | |
| *** SnowDust has joined #openstack-trove | 21:12 | |
| *** yidclare has joined #openstack-trove | 21:13 | |
| *** radez_g0n3 is now known as radez | 21:13 | |
| hub_cap | ugh... stdby keeps making my laptop go crazy | 21:14 |
| *** yogesh has quit IRC | 21:34 | |
| denis_makogon | hub_cap, could you please re-review https://review.openstack.org/#/c/59410/ ? we already have two ready reviews, ikhudoshyn 's review(already approved) depends on mine, | 21:38 |
| hub_cap | can u link ikhudoshyn's review? | 21:40 |
| denis_makogon | hub_cap, https://review.openstack.org/#/c/59078/ | 21:42 |
| hub_cap | ikhudoshyn: your dependent review is outdated... im not sure if itll auto merge (But its a good way to test it out!) | 21:43 |
| hub_cap | denis_makogon: he may have to rebase after yours gets in :P | 21:44 |
| hub_cap | im not sure how gerrit works in this case | 21:44 |
| denis_makogon | mine already rebased | 21:44 |
| denis_makogon | could mine land first ? | 21:44 |
| denis_makogon | hub_cap, he might rebase anyway | 21:47 |
| denis_makogon | lol, B. Singer anounced X-Men: Apocalypse movie =)) | 21:48 |
| cweid | totally trying this when I get home... http://i.imgur.com/eo999FM.gif | 21:51 |
| hub_cap | wowowwowowo cweid | 21:52 |
| openstackgerrit | Robert Myers proposed a change to openstack/python-troveclient: Adding pagination support for backups https://review.openstack.org/60626 | 21:53 |
| hub_cap | thats crazy | 21:53 |
| cweid | Yeah wish you would have saved all them AOL cds huh? | 21:54 |
| grapex | denis_makogon hub_cap: Sorry, I just -2'd this: https://review.openstack.org/#/c/59410/ | 21:54 |
| denis_makogon | grapex, for what reason ? | 21:55 |
| grapex | I think the correct fix is to change the root history from the Trove side- the guest shouldn't have to tell Trove root was enabled when Trove asked it to in the prepare call | 21:55 |
| hub_cap | i think SlickNik asked this before grapex | 21:56 |
| grapex | hub_cap: I don't see his comment in gerrit | 21:57 |
| denis_makogon | grapex, i see what you mean, but there's no wat to know if guest successfully finished this task | 21:57 |
| grapex | denis_makogon: If the prepare call fails, it never enters ACTIVE state. | 21:57 |
| denis_makogon | grapex, robertmyers asked : Looks good, however it seems like this doesn't need to be done on the guest side. Can't the taskmanager api update the root record when we make the call? Either way I'm fine with this. | 21:57 |
| grapex | I am curious | 21:58 |
| grapex | if a user asks for a new instance, and wants a root user, and then gets a new instance without, how will they know that it failed? | 21:59 |
| datsun180b | the thinking was the user create calls are async just in case it takes nonzero time to execute the command in mysql | 21:59 |
| datsun180b | so then if it's async then only the guest would know if/when it completed successfully without the taskman polling for it or something | 21:59 |
| denis_makogon | grapex, problem, that guest cannot report, all cals are async | 22:00 |
| datsun180b | at least i think that was the rationale | 22:00 |
| grapex | It's like the instance is in a semi-initialized state. Also, if it doesn't already, shouldn't enable_root raise an exception (and thus end the prepare call and cause a failure) if it fails anyway? | 22:00 |
| grapex | deni_makogon: No, it can. | 22:00 |
| denis_makogon | if you want to know if root unabled, prepare call should be "call istead of cast" | 22:00 |
| grapex | It does so by updating the service_status, the way it always does | 22:00 |
| SlickNik | denis_makogon: why can't we do it in the taskmanager after the call to the guestagent. It's a _call_ and not a _cast_ so we can do it only if the guest agent has succeeded. | 22:00 |
| grapex | So if I want a new instance which is restored from some backup, if the restore process fails we don't just say the instance is ACTIVE and leave it at that. | 22:01 |
| grapex | The prepare call should always do what it was told or leave the guest in a failed state. | 22:01 |
| denis_makogon | grapex, so you suggesting to move report call from guest | 22:02 |
| grapex | denis_makogon: yes. It could live along side the prepare call in the taskmanager code. | 22:02 |
| *** yogesh has joined #openstack-trove | 22:02 | |
| *** jcooley_ has joined #openstack-trove | 22:03 | |
| denis_makogon | grapex, https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L231 after last call, before return | 22:03 |
| denis_makogon | grapex, ok, i'm fine with that | 22:03 |
| grapex | denis_makogon: Why not put it even closer to prepare though | 22:03 |
| grapex | like right before or after the call | 22:04 |
| grapex | So the instance is basically "born" with root history | 22:04 |
| denis_makogon | grapex, becasuse if prepare would fail we would have another message in MQ | 22:04 |
| denis_makogon | without consumer | 22:04 |
| denis_makogon | grapex, not so good case | 22:05 |
| grapex | denis_makogon: I mean, don't even call conductor- set the root history in the database without talking to conductor. | 22:05 |
| denis_makogon | what if instance failed, but root enabled because it was written to db | 22:05 |
| denis_makogon | grapex, i understood it | 22:05 |
| *** ashestakov has quit IRC | 22:06 | |
| denis_makogon | grapex, and i will be silly if taskmanager would call conductor while it has direct access to db | 22:06 |
| grapex | denis_makogon: If the instance fails, most likely ops or someone will have to fix it, or the user will just delete it. Either way at that point the experience is already subpar, no one would care that the root history was enabled | 22:06 |
| *** radez is now known as radez_g0n3 | 22:06 | |
| *** mmcdaris has joined #openstack-trove | 22:06 | |
| grapex | denis_makogon: Sorry, I guess I misunderstood what you meant about having another message in MQ. | 22:06 |
| *** mmcdaris has quit IRC | 22:07 | |
| grapex | I thought you understood it, but I just wanted to restate just in case. | 22:07 |
| *** yogeshmehra has joined #openstack-trove | 22:07 | |
| *** mmcdaris has joined #openstack-trove | 22:07 | |
| denis_makogon | grapex, no proble, | 22:07 |
| *** mmcdaris has left #openstack-trove | 22:07 | |
| denis_makogon | grapex, i mean that i would like to avoid such things | 22:07 |
| denis_makogon | if instance fail - we should not get any other reports, except status | 22:08 |
| denis_makogon | if instance failed, root report should not even being reported | 22:08 |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Paginate backup list api https://review.openstack.org/60358 | 22:09 |
| denis_makogon | grapex, i'm definitely ok with simplifying prepare call | 22:09 |
| grapex | denis_makogon: If the instance fails and you have an entry in root history enabled, I don't see what the problem is with that. | 22:10 |
| denis_makogon | grapex, incorrect reporting to end-user | 22:10 |
| denis_makogon | grapex, it would looks like incosistent state | 22:11 |
| grapex | The end user's instance already says FAILED. I don't think they'd care about it | 22:11 |
| grapex | like if I'm waiting for food at a restaurant for hours, and then I find someone else took my order when they called my name, I don't care if they did or didn't include pickles and onions. | 22:11 |
| denis_makogon | grapex, anyway, let's avoid such cases, we can do that | 22:12 |
| grapex | denis_makogon: Is your suggestion to put it around where the usage event is sent? | 22:12 |
| denis_makogon | yes | 22:12 |
| grapex | denis_makogon: So, let's say an operator shuts off the task manager daemon | 22:13 |
| denis_makogon | i think it's perfect place | 22:13 |
| grapex | a usage event not being sent means the operator probably loses a bit of money or something | 22:13 |
| *** robertmy_ has joined #openstack-trove | 22:13 | |
| grapex | But if we send the event earlier, its possible the customer is overbilled | 22:13 |
| grapex | So, if we set root history earlier, what is the danger to the user? | 22:14 |
| grapex | The only way in which it becomes misleading is if there is an error provisioning their instance | 22:14 |
| grapex | so the instance goes to FAILED status | 22:14 |
| grapex | and then an operator steps in and manually fixes it somehow | 22:14 |
| grapex | and then the operator doesn't enable root during the manual process, plus the user decides to change their mind and not enable root either | 22:15 |
| grapex | and then later the user gets upset when they see root is enabled- to me that's a hypothetical | 22:15 |
| grapex | the risk on the other hand is that there is a time out in the taskmanager, so the root history is *never* set | 22:15 |
| grapex | but then the instance ends up eventually provisioning - maybe it just took a long time- and now on top of the usage event issue, the root history is not set. | 22:16 |
| denis_makogon | yes, and _never_set_ is ok | 22:16 |
| grapex | I disagree. | 22:16 |
| *** robertmyers has quit IRC | 22:16 | |
| grapex | If never set is ok for users who have root, why even have a root history? | 22:16 |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove: making the bin scripts called with main() https://review.openstack.org/54225 | 22:16 |
| denis_makogon | grapex, you suggesting to put it after prepare call & | 22:17 |
| denis_makogon | ? | 22:17 |
| *** robertmy_ has quit IRC | 22:17 | |
| grapex | Or right before- just don't put it after waiting to see the status changed. | 22:17 |
| denis_makogon | https://github.com/openstack/trove/blob/master/trove/taskmanager/models.py#L205 | 22:18 |
| *** yogeshmehra has quit IRC | 22:18 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove: changing the routes for the api to be clear https://review.openstack.org/54224 | 22:18 |
| grapex | denis_makogon: inserting it on line 203, or right after 205 would make sense to me. | 22:18 |
| denis_makogon | grapex, ok, i'll do that | 22:19 |
| denis_makogon | grapex, thanks for brainstorm =) | 22:19 |
| denis_makogon | grapex, anyway, we need to break connection between guest and back-end | 22:20 |
| grapex | denis_makogon: Thanks for the pull request- sorry there's this issue holding it up due to pre-existing code. | 22:20 |
| denis_makogon | grapex, asap | 22:20 |
| denis_makogon | grapex, no problem, i | 22:21 |
| denis_makogon | grapex, as i said, i'm totally ok with making guest prepare faster | 22:21 |
| *** harlowja has quit IRC | 22:21 | |
| denis_makogon | grapex, hub_cap, btw, have you seen ML thread about unified VM agents ? | 22:21 |
| *** SnowDust has quit IRC | 22:22 | |
| grapex | denis_makogon: yes | 22:22 |
| grapex | I've been wondering when / if to respond. | 22:22 |
| denis_makogon | grapex, very interesting | 22:22 |
| grapex | I don't believe a unified agent across OpenStack projects makes any sense. | 22:22 |
| denis_makogon | grapex, it has a lot responses | 22:22 |
| denis_makogon | grapex, i think it would be nice to have framework for agents, with pluggable transport impl | 22:23 |
| grapex | I'm worried the end result could only be either a very bloated agent that has to do a bit of everything, or enforcing that an agent can only do several things which will require changing Trove | 22:23 |
| denis_makogon | grapex, and API | 22:23 |
| grapex | I think Trove should support an interface for agents. If some new framework is created and works well, I'd always be for using that. | 22:23 |
| kevinconway | i should respond to the ML with my bash agent | 22:24 |
| denis_makogon | grapex, when i was playing with extracting guest code, i was common skeleton | 22:24 |
| kevinconway | it listens to rabbit. that means it s cales | 22:24 |
| denis_makogon | *i saw | 22:24 |
| *** jcooley_ has quit IRC | 22:24 | |
| grapex | I just don't want at the next OS summit prominent people in OS who don't work on Trove to start asking why we aren't using some new framework that doesn't do things we may need. | 22:24 |
| denis_makogon | grapex, true | 22:25 |
| grapex | So at Rackspace we use Sneaky Pete which is in C++. We also contribute to the reference agent. So I'm predisposed against the idea of creating a third agent since I've already written several trove features into two agents already. | 22:26 |
| denis_makogon | grapex, for now it will be nice to send into ML Trove requirements for such agent | 22:26 |
| denis_makogon | i think solum soon would need that | 22:26 |
| *** yogeshmehra has joined #openstack-trove | 22:28 | |
| kevinconway | i'm still not sure what a common guest agent could even be except a framework on which to build agents. | 22:28 |
| kevinconway | even then what would the framework be? a base class on which to build your system daemon that listens to rabbit for messages? | 22:29 |
| kevinconway | that's what managers already do | 22:29 |
| denis_makogon | kevinconway, different transport | 22:29 |
| denis_makogon | kevinconway, different ways of executing tasks | 22:29 |
| denis_makogon | kevinconway, for now i know 2 ways | 22:30 |
| denis_makogon | kevinconway, API and scenarious | 22:30 |
| kevinconway | but how is that different from what a manager already does? | 22:30 |
| denis_makogon | kevinconway, no difference, that is why it would be easy to collect common needs and requirements | 22:31 |
| kevinconway | if it is not different then what does it add? | 22:31 |
| denis_makogon | kevinconway, unified agents concept is only under design | 22:31 |
| denis_makogon | kevinconway, almost all code will be in oslo | 22:31 |
| denis_makogon | kevinconway, so other projects will just sync wth oslo and will develop their own agent on top of oslo lib | 22:33 |
| kevinconway | denis_makogon: manager and transport code is already in oslo | 22:33 |
| denis_makogon | kevinconway, yes | 22:33 |
| denis_makogon | kevinconway, you are right | 22:33 |
| *** yogeshmehra has quit IRC | 22:33 | |
| denis_makogon | kevinconway, but there's no was to combine them into one entity | 22:33 |
| kevinconway | you combine them as needed for your agent though | 22:34 |
| denis_makogon | kevinconway, use, but oslo will dictate you rules how to build it | 22:34 |
| denis_makogon | kevinconway, as i said - framework | 22:34 |
| kevinconway | denis_makogon: https://github.com/kevinconway/scriptpool | 22:36 |
| kevinconway | it's apache licensed | 22:36 |
| kevinconway | great agent framework | 22:36 |
| denis_makogon | lol | 22:36 |
| kevinconway | you can impl new transports easy | 22:36 |
| kevinconway | it listens to rabbit already | 22:36 |
| kevinconway | i' m working on a socket/network transport too so you can cURL to it | 22:37 |
| denis_makogon | we need REST | 22:37 |
| denis_makogon | instead of rpc/rebbit | 22:37 |
| denis_makogon | it's very hard to proxy rpc calls | 22:38 |
| kevinconway | denis_makogon: i plan to integrate my bash http server into it once complete. it will allow REST service development in bash that can drive the agent. | 22:38 |
| denis_makogon | so, ok, thanks to all for chat | 22:38 |
| denis_makogon | kevinconway, <---- maniac | 22:39 |
| * denis_makogon gone until Mon | 22:39 | |
| *** denis_makogon is now known as bot_bot | 22:40 | |
| datsun180b | does that mean that denis is really a robot? | 22:41 |
| *** bot_bot has quit IRC | 22:45 | |
| *** datsun180b has quit IRC | 22:48 | |
| grapex | Ok, I've got to go. Talk to you all on Monday! | 22:48 |
| hub_cap | cu guys | 22:51 |
| hub_cap | cu bot_bot | 22:52 |
| cp16net | peace out grapex | 22:58 |
| cp16net | hub_cap: did we decide to hold off on adding new datastores for a while? | 22:59 |
| cp16net | i think i recall this being said but wasnt sure | 22:59 |
| cp16net | hub_cap: at least until tempest ? | 22:59 |
| hub_cap | cp16net: i had said it for ones that hadnt already been in review status | 23:00 |
| hub_cap | but i think at this point we should allow them | 23:00 |
| *** yidclare has quit IRC | 23:00 | |
| hub_cap | but we should discuss | 23:00 |
| cp16net | ok | 23:00 |
| hub_cap | what do u think cp16net ? | 23:00 |
| cp16net | because i've skipped looking at those | 23:00 |
| hub_cap | heh | 23:00 |
| hub_cap | id say give em a look-see | 23:00 |
| hub_cap | im running redis right now | 23:00 |
| cp16net | cool | 23:00 |
| jmontemayor | +1 | 23:01 |
| cp16net | i've been working on getting a public image working for me | 23:01 |
| hub_cap | hah of course youd say that jmontemayor ;) | 23:02 |
| hub_cap | ya i think bot_bot would like to know that too | 23:03 |
| hub_cap | ill talk to them on monday | 23:03 |
| cp16net | yeah i'm thinking is going to be difficult to test all the datastores | 23:03 |
| cp16net | in the public jenkins job | 23:03 |
| hub_cap | well.. with enough cloud vms u can test em ;) | 23:03 |
| hub_cap | its just creating them is via a tempest fixture | 23:04 |
| cp16net | true... | 23:04 |
| cp16net | it would require basically a job for each datastore | 23:04 |
| hub_cap | and we can reuse that to prov diff datastores and even clusters eventually | 23:04 |
| *** jcru has quit IRC | 23:04 | |
| cp16net | which would make it pretty easy i think | 23:04 |
| *** yogesh has quit IRC | 23:05 | |
| cp16net | this might even be able to be helped out with using the fake daemon mode to run through the tests | 23:05 |
| *** kevinconway has quit IRC | 23:05 | |
| *** yogesh has joined #openstack-trove | 23:05 | |
| cp16net | it allowed me to test the api for configs | 23:05 |
| cp16net | without waiting 2 min for a vm to spin up | 23:06 |
| cp16net | hub_cap: another point is that i am sure the public wants something more than mysql by now as well | 23:06 |
| cp16net | i think if we merged them in we are early enough in the Icehouse cycle to be able to fix issues that come up | 23:07 |
| cp16net | it would not make sense to merge a new datastore in I4 time frame | 23:08 |
| cp16net | I3 at the latest i think | 23:08 |
| cp16net | what do you think hub_cap | 23:08 |
| hub_cap | yes, there is no I4 :( | 23:09 |
| hub_cap | but we should merge them sooner rathe than later hehe | 23:09 |
| *** yogesh has quit IRC | 23:09 | |
| *** jasonb365 has quit IRC | 23:10 | |
| *** pdmars has quit IRC | 23:12 | |
| *** pdmars has joined #openstack-trove | 23:13 | |
| *** pdmars has quit IRC | 23:14 | |
| *** yidclare has joined #openstack-trove | 23:15 | |
| *** rnirmal has quit IRC | 23:18 | |
| demorris | +1 for merging them :) | 23:20 |
| *** mmcdaris has joined #openstack-trove | 23:22 | |
| *** tanisdl has quit IRC | 23:22 | |
| cp16net | i'll go through them some time soon | 23:26 |
| cp16net | i really want to get my image setup to fire up a review and test it | 23:26 |
| cp16net | so i can verify much mo betta | 23:27 |
| *** mmcdaris has quit IRC | 23:33 | |
| *** tanisdl has joined #openstack-trove | 23:33 | |
| *** rnirmal has joined #openstack-trove | 23:33 | |
| hub_cap | ++ | 23:36 |
| hub_cap | im doin that w/ the redis review now | 23:36 |
| hub_cap | but for some reason rabbit wouldnt start | 23:36 |
| hub_cap | so i killed the vm and brought up a new one heh | 23:36 |
| hub_cap | now its fine | 23:36 |
| cp16net | ncie | 23:39 |
| cp16net | what all did you bake into the image? | 23:40 |
| *** jmontemayor has quit IRC | 23:42 | |
| amcrn | +1 for merging them :) | 23:48 |
| hub_cap | umm it was kinda iterative... i can give u my root history after i sanitize it | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
