| SlickNik | Strange, he seemed to think he was still connected. | 00:00 |
|---|---|---|
| SlickNik | I restarted him, and he re-joined... | 00:00 |
| amcrn | konetzed kevinconway demorris have all parted, but if anyone else was following the type/version upgrade conversation earlier, i have a mailing-list draft at https://gist.github.com/amcrn/dfd493200fcdfdb61a23 | 00:01 |
| amcrn | oh, konetzed is still here :X | 00:01 |
| amcrn | anyway, i'm going to toss that on the mailing list in about 30 minutes unless someone has some objections or amendments they'd like to add | 00:02 |
| amcrn | (sorry for the topic change, carry on) | 00:02 |
| SlickNik | amcrn: no worries; thanks for putting that together. | 00:03 |
| hub_cap | ok i lied. its not review time its grocery shopping time :o | 00:03 |
| hub_cap | see yall later | 00:03 |
| amcrn | np | 00:04 |
| SlickNik | heh, remember the milk. | 00:04 |
| amcrn | he lives near sf, it can't just be milk, it's gotta be almond or soy milk :P | 00:06 |
| amcrn | (note: i'm not a hater, i love me some soy milk, just joshin' around) | 00:07 |
| *** grapex has quit IRC | 00:08 | |
| *** grapex has joined #openstack-trove | 00:08 | |
| *** grapex has quit IRC | 00:13 | |
| *** matsuhashi has joined #openstack-trove | 00:32 | |
| *** kevinconway has joined #openstack-trove | 00:36 | |
| *** plodronio has quit IRC | 00:42 | |
| *** esp has left #openstack-trove | 00:44 | |
| amcrn | fyi, it's hit the mailing list under "[openstack-dev] [trove] Datastore Type/Version Migration" | 00:55 |
| *** esp has joined #openstack-trove | 01:00 | |
| *** matsuhashi has quit IRC | 01:02 | |
| *** matsuhashi has joined #openstack-trove | 01:02 | |
| *** matsuhashi has quit IRC | 01:07 | |
| *** yidclare has quit IRC | 01:10 | |
| *** NehaV has joined #openstack-trove | 01:11 | |
| *** amytron has quit IRC | 01:11 | |
| *** jcru has quit IRC | 01:11 | |
| *** yogesh has joined #openstack-trove | 01:12 | |
| *** matsuhashi has joined #openstack-trove | 01:15 | |
| *** NehaV has quit IRC | 01:27 | |
| *** NehaV has joined #openstack-trove | 01:28 | |
| *** nosnos has joined #openstack-trove | 01:30 | |
| *** amcrn has quit IRC | 01:31 | |
| *** esp has left #openstack-trove | 01:31 | |
| *** haomaiwang has quit IRC | 01:33 | |
| *** yogesh has quit IRC | 01:36 | |
| *** yogesh has joined #openstack-trove | 01:37 | |
| *** yogesh has quit IRC | 01:41 | |
| *** matsuhashi has quit IRC | 01:45 | |
| *** matsuhashi has joined #openstack-trove | 01:46 | |
| *** haomaiwang has joined #openstack-trove | 01:53 | |
| *** tanisdl has quit IRC | 02:06 | |
| *** erkules_ has joined #openstack-trove | 02:16 | |
| *** erkules has quit IRC | 02:19 | |
| *** demorris has joined #openstack-trove | 02:20 | |
| *** NehaV has quit IRC | 02:23 | |
| *** Barker has joined #openstack-trove | 02:32 | |
| *** esp has joined #openstack-trove | 02:57 | |
| *** esp has left #openstack-trove | 02:57 | |
| *** demorris has quit IRC | 02:59 | |
| *** matsuhas_ has joined #openstack-trove | 03:05 | |
| *** matsuhashi has quit IRC | 03:08 | |
| *** NehaV has joined #openstack-trove | 03:15 | |
| *** NehaV has quit IRC | 03:23 | |
| *** Barker has quit IRC | 03:38 | |
| *** Barker has joined #openstack-trove | 03:38 | |
| *** coolsvap has joined #openstack-trove | 03:40 | |
| *** NehaV has joined #openstack-trove | 03:48 | |
| *** esp has joined #openstack-trove | 03:49 | |
| *** adrian_otto has joined #openstack-trove | 03:52 | |
| *** Barker has quit IRC | 03:54 | |
| *** esp has left #openstack-trove | 03:54 | |
| *** matsuhas_ has quit IRC | 04:00 | |
| *** matsuhashi has joined #openstack-trove | 04:02 | |
| *** matsuhashi has quit IRC | 04:14 | |
| *** coolsvap has quit IRC | 04:19 | |
| *** matsuhashi has joined #openstack-trove | 04:19 | |
| *** coolsvap has joined #openstack-trove | 04:21 | |
| *** coolsvap has quit IRC | 04:27 | |
| *** coolsvap_ has joined #openstack-trove | 04:27 | |
| *** coolsvap_ has quit IRC | 04:28 | |
| *** adrian_otto has quit IRC | 04:36 | |
| *** coolsvap has joined #openstack-trove | 04:45 | |
| *** coolsvap has quit IRC | 04:50 | |
| *** coolsvap has joined #openstack-trove | 04:50 | |
| *** matsuhashi has quit IRC | 05:02 | |
| *** yogesh has joined #openstack-trove | 05:23 | |
| *** yogesh has quit IRC | 05:28 | |
| *** yogesh has joined #openstack-trove | 05:42 | |
| *** yogesh has quit IRC | 05:49 | |
| *** yogesh has joined #openstack-trove | 05:50 | |
| *** yogesh has quit IRC | 05:51 | |
| *** yogesh has joined #openstack-trove | 06:04 | |
| *** NehaV has quit IRC | 06:05 | |
| *** SushilKM__ has joined #openstack-trove | 06:06 | |
| *** yogesh has quit IRC | 06:31 | |
| *** yogesh has joined #openstack-trove | 06:31 | |
| *** yogesh has quit IRC | 06:32 | |
| *** yogesh has joined #openstack-trove | 06:32 | |
| *** SushilKM__ has quit IRC | 06:34 | |
| *** SushilKM__ has joined #openstack-trove | 06:45 | |
| *** nosnos has quit IRC | 06:48 | |
| *** nosnos has joined #openstack-trove | 06:48 | |
| *** yogesh has quit IRC | 07:06 | |
| *** yogesh has joined #openstack-trove | 07:07 | |
| *** yogesh has quit IRC | 07:07 | |
| *** yogesh has joined #openstack-trove | 07:08 | |
| openstackgerrit | Kevin Conway proposed a change to openstack/trove-integration: Add support for kick-starting postgresql https://review.openstack.org/57608 | 07:08 |
| openstackgerrit | Kevin Conway proposed a change to openstack/trove: WIP: Add PostgreSQL support https://review.openstack.org/57609 | 07:13 |
| openstackgerrit | Kevin Conway proposed a change to openstack/trove: WIP: Add PostgreSQL support https://review.openstack.org/57609 | 07:15 |
| *** kevinconway has quit IRC | 07:22 | |
| *** denis_makogon_ has joined #openstack-trove | 07:28 | |
| openstackgerrit | Nicholas Shobe proposed a change to openstack/python-troveclient: Allow --json output override printing dict/list https://review.openstack.org/57619 | 08:25 |
| *** nosnos_ has joined #openstack-trove | 08:30 | |
| *** nosnos has quit IRC | 08:33 | |
| *** coolsvap is now known as coolsvap[A] | 09:36 | |
| * coolsvap[A] is now away - Reason : away | 09:36 | |
| *** coolsvap[A] is now known as coolsvap | 09:39 | |
| * coolsvap is no longer away : Gone for 3 minutes 23 seconds | 09:39 | |
| *** ashestakov has joined #openstack-trove | 09:50 | |
| *** yogesh has quit IRC | 09:53 | |
| *** yogesh has joined #openstack-trove | 09:53 | |
| *** yogesh has quit IRC | 09:58 | |
| *** coolsvap is now known as coolsvap[A] | 10:09 | |
| * coolsvap[A] is now away - Reason : Auto-Away after 30 minutes | 10:09 | |
| *** SnowDust has joined #openstack-trove | 10:31 | |
| *** coolsvap[A] is now known as coolsvap | 10:38 | |
| * coolsvap is no longer away : Gone for 59 minutes 40 seconds | 10:38 | |
| *** coolsvap has quit IRC | 11:08 | |
| *** coolsvap has joined #openstack-trove | 11:12 | |
| *** nosnos_ has quit IRC | 11:20 | |
| *** nosnos has joined #openstack-trove | 11:21 | |
| *** nosnos has quit IRC | 11:25 | |
| *** flaper87 has joined #openstack-trove | 11:30 | |
| *** SnowDust has quit IRC | 11:33 | |
| *** coolsvap has quit IRC | 11:37 | |
| *** ashestakov has quit IRC | 11:38 | |
| *** erkules_ is now known as erkules | 12:21 | |
| *** kevinconway has joined #openstack-trove | 12:23 | |
| *** kevinconway has quit IRC | 12:25 | |
| *** coolsvap has joined #openstack-trove | 12:29 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 12:42 |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove-integration: Add support for minimal MongoDB testing https://review.openstack.org/53378 | 12:48 |
| *** pdmars has joined #openstack-trove | 12:55 | |
| *** pdmars has quit IRC | 12:59 | |
| *** coolsvap is now known as coolsvap_away | 12:59 | |
| * coolsvap_away is now away - Reason : Auto-Away after 30 minutes | 12:59 | |
| *** pdmars has joined #openstack-trove | 13:02 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove-integration: Add support for minimal MongoDB testing https://review.openstack.org/53378 | 13:06 |
| *** demorris has joined #openstack-trove | 13:07 | |
| *** kevinconway has joined #openstack-trove | 13:08 | |
| *** demorris has quit IRC | 13:25 | |
| openstackgerrit | Denis M. proposed a change to openstack/python-troveclient: Adding ConnectionError class https://review.openstack.org/56930 | 13:46 |
| *** demorris has joined #openstack-trove | 13:46 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 13:53 |
| openstackgerrit | Denis M. proposed a change to openstack/trove: Allow query logging https://review.openstack.org/57408 | 13:53 |
| *** SushilKM__ has quit IRC | 13:54 | |
| kevinconway | denis_makogon: thanks for the fast review | 13:58 |
| kevinconway | i agree with most of your code comments. will be working on some of them later. | 13:59 |
| denis_makogon | kevinconway, no problem, my friend | 13:59 |
| kevinconway | denis_makogon: are you working on cassandra? | 14:00 |
| denis_makogon | kevinconway, yes | 14:00 |
| kevinconway | what are you doing for backups? | 14:00 |
| kevinconway | what is there seemed pretty mysql specific | 14:01 |
| denis_makogon | snapshot on file system then collect dirs into tar, then tar into stream | 14:01 |
| *** demorris has quit IRC | 14:01 | |
| denis_makogon | kevinconway, robert myers working on backups and restore code | 14:01 |
| denis_makogon | now code look cleaner | 14:02 |
| *** jcru has joined #openstack-trove | 14:04 | |
| kevinconway | oh nice, looks like backups might not be too bad to implement | 14:05 |
| *** coolsvap_away is now known as coolsvap | 14:10 | |
| * coolsvap is no longer away : Gone for 1 hour 40 minutes 45 seconds | 14:10 | |
| *** rongze has joined #openstack-trove | 14:12 | |
| denis_makogon | kevinconway, yes, it might | 14:19 |
| denis_makogon | kevinconway, if you would need any kind of help - always welcome | 14:20 |
| *** coolsvap has left #openstack-trove | 14:22 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove-integration: Add support for minimal MongoDB testing https://review.openstack.org/53378 | 14:23 |
| *** coolsvap has joined #openstack-trove | 14:23 | |
| *** rongze_ has joined #openstack-trove | 14:24 | |
| *** rongze has quit IRC | 14:27 | |
| *** demorris has joined #openstack-trove | 14:28 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 14:30 |
| *** rongze has joined #openstack-trove | 14:30 | |
| *** rongze_ has quit IRC | 14:33 | |
| *** NehaV1 has joined #openstack-trove | 14:40 | |
| *** adrian_otto has joined #openstack-trove | 14:43 | |
| *** robertmy_ has joined #openstack-trove | 14:57 | |
| *** Barker has joined #openstack-trove | 14:57 | |
| *** robertmy_ has quit IRC | 15:04 | |
| *** robertmyers has joined #openstack-trove | 15:04 | |
| *** amytron has joined #openstack-trove | 15:05 | |
| *** jasonb365 has joined #openstack-trove | 15:24 | |
| *** grapex has joined #openstack-trove | 15:34 | |
| *** grapex has quit IRC | 15:35 | |
| *** grapex has joined #openstack-trove | 15:35 | |
| *** datsun180b has joined #openstack-trove | 15:36 | |
| *** rongze_ has joined #openstack-trove | 15:37 | |
| *** rongze has quit IRC | 15:37 | |
| *** radez_g0n3 is now known as radez | 15:42 | |
| datsun180b | hub_cap: lmk when you're in, i want your help with my conductor tests | 15:43 |
| *** coolsvap is now known as coolsvap_away | 15:46 | |
| *** coolsvap_away is now known as coolsvap | 15:51 | |
| *** tanisdl has joined #openstack-trove | 15:58 | |
| *** jasonb365 has quit IRC | 15:59 | |
| cp16net | datsun180b: you still having issues with tox | 16:00 |
| datsun180b | i am, i think i figured out who's asking for my password during the testr tests | 16:00 |
| datsun180b | adding a little debugging to be certain | 16:00 |
| *** yidclare has joined #openstack-trove | 16:02 | |
| *** jasonb365 has joined #openstack-trove | 16:02 | |
| *** datsun180b_ has joined #openstack-trove | 16:04 | |
| *** datsun180b_ has quit IRC | 16:04 | |
| *** datsun180b has quit IRC | 16:04 | |
| *** datsun180b has joined #openstack-trove | 16:04 | |
| *** NehaV has joined #openstack-trove | 16:06 | |
| *** NehaV1 has quit IRC | 16:07 | |
| *** jmontemayor has joined #openstack-trove | 16:14 | |
| *** jmontemayor has quit IRC | 16:14 | |
| *** rongze_ has quit IRC | 16:17 | |
| *** haomaiwang has quit IRC | 16:17 | |
| *** jmontemayor has joined #openstack-trove | 16:19 | |
| *** jmontemayor has quit IRC | 16:19 | |
| *** rongze has joined #openstack-trove | 16:23 | |
| *** radez is now known as radez_g0n3 | 16:25 | |
| *** haomaiwang has joined #openstack-trove | 16:27 | |
| *** NehaV has quit IRC | 16:28 | |
| *** SushilKM__ has joined #openstack-trove | 16:32 | |
| *** jasonb365 has quit IRC | 16:32 | |
| *** NehaV has joined #openstack-trove | 16:32 | |
| *** jasonb365 has joined #openstack-trove | 16:33 | |
| *** NehaV has quit IRC | 16:36 | |
| *** Barker has quit IRC | 16:36 | |
| openstackgerrit | Sushil Kumar proposed a change to openstack/trove: Remove radmin credentials from create_heat_client https://review.openstack.org/56373 | 16:39 |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Remove 'mount_point' from guestagent RPC API https://review.openstack.org/57189 | 16:43 |
| *** jmontemayor has joined #openstack-trove | 16:47 | |
| *** jmontemayor has quit IRC | 16:47 | |
| *** jmontemayor has joined #openstack-trove | 16:53 | |
| *** jmontemayor has quit IRC | 16:55 | |
| *** jmontemayor has joined #openstack-trove | 16:59 | |
| *** pdmars has quit IRC | 17:00 | |
| *** jasonb365 has quit IRC | 17:03 | |
| *** jmontemayor has quit IRC | 17:03 | |
| *** jmontemayor has joined #openstack-trove | 17:06 | |
| datsun180b | ProcessExecutionError: Unexpected error while running command. | 17:06 |
| datsun180b | Command: sudo chmod -R 0777 /var/lib/mysql | 17:06 |
| datsun180b | Nope, not allowed to do that to my host machine, tests. | 17:06 |
| datsun180b | The unit tests are trying to do things to the host system when the unit tests run, and that is super bad | 17:07 |
| *** Barker has joined #openstack-trove | 17:08 | |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 17:10 |
| datsun180b | robertmyers: 1cceaa11 | 17:11 |
| *** jasonb365 has joined #openstack-trove | 17:12 | |
| *** jasonb365 has quit IRC | 17:13 | |
| *** yogesh has joined #openstack-trove | 17:14 | |
| *** NehaV has joined #openstack-trove | 17:19 | |
| *** jasonb365 has joined #openstack-trove | 17:19 | |
| cp16net | very bad | 17:23 |
| *** tanisdl has quit IRC | 17:26 | |
| robertmyers | datsun180b: cp16net: very bad indeed, it sucks that we didn't catch this in the review of datastore types | 17:30 |
| robertmyers | tox tests should not be running any commands on the test machine, this needs to be mocked | 17:30 |
| denis_makogon | sup guys | 17:31 |
| openstackgerrit | Illia Khudoshyn proposed a change to openstack/trove: Initial support for single instance MongoDB support https://review.openstack.org/50597 | 17:38 |
| *** SnowDust has joined #openstack-trove | 17:43 | |
| *** coolsvap is now known as coolsvap_away | 17:50 | |
| *** yogesh has quit IRC | 17:54 | |
| *** jasonb365 has quit IRC | 17:57 | |
| *** yogesh has joined #openstack-trove | 18:00 | |
| *** jasonb365 has joined #openstack-trove | 18:01 | |
| *** pdmars has joined #openstack-trove | 18:02 | |
| *** jasonb365 has quit IRC | 18:02 | |
| *** jasonb365 has joined #openstack-trove | 18:04 | |
| *** jasonb365 has quit IRC | 18:05 | |
| *** NehaV has quit IRC | 18:08 | |
| *** jasonb365 has joined #openstack-trove | 18:10 | |
| *** jasonb365 has quit IRC | 18:11 | |
| *** yogesh has quit IRC | 18:19 | |
| *** jasonb365 has joined #openstack-trove | 18:23 | |
| *** rnirmal has joined #openstack-trove | 18:27 | |
| SnowDust | https://review.openstack.org/#/c/56373/ anyone there ? | 18:30 |
| *** SushilKM__ has quit IRC | 18:33 | |
| *** adrian_otto has quit IRC | 18:36 | |
| *** Barker has quit IRC | 18:36 | |
| *** rongze has quit IRC | 18:40 | |
| *** NehaV has joined #openstack-trove | 18:41 | |
| *** yogesh has joined #openstack-trove | 18:41 | |
| openstackgerrit | Tim Simpson proposed a change to openstack/python-troveclient: Allow for compatable auths between new and old CLI https://review.openstack.org/57736 | 18:44 |
| cp16net | datsun180b: https://gist.github.com/cp16net/7587296 | 18:47 |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Moving storage logic out of backup runner class https://review.openstack.org/56702 | 18:48 |
| datsun180b | cp16net: gerrit it, put your name on it | 18:49 |
| cp16net | yeah i'm on it | 18:49 |
| *** adrian_otto has joined #openstack-trove | 18:52 | |
| *** amcrn has joined #openstack-trove | 18:59 | |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove: need to mock out of the clear_expired_passwords for tox https://review.openstack.org/57739 | 19:03 |
| datsun180b | cp16net: use " dbaas.clear_expired_password = Mock()" instead in test_dbaas | 19:05 |
| cp16net | ummm | 19:06 |
| cp16net | sorta but no... | 19:06 |
| cp16net | when(dbaas).clear_expired_password().thenReturn(None) | 19:06 |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove: need to mock out of the clear_expired_passwords for tox https://review.openstack.org/57739 | 19:07 |
| cp16net | alright hopefully that fixes the issue we have been seeing | 19:08 |
| *** rongze has joined #openstack-trove | 19:11 | |
| datsun180b | fair enough, i see both uses in test_dbaas but looks like you're right | 19:14 |
| hub_cap | cp16net: the issue, is that the one datsun180b saw on his review too? | 19:17 |
| hub_cap | the one i commented on? | 19:17 |
| cp16net | its both | 19:18 |
| cp16net | i didnt make mine depend on his | 19:18 |
| hub_cap | sure i just wondered about the issue / fix | 19:18 |
| *** rongze has quit IRC | 19:18 | |
| cp16net | it seems to be a big issue when running tox on a mac | 19:19 |
| cp16net | it was trying to sudo chmod /var/lib/mysql | 19:19 |
| hub_cap | HAH | 19:19 |
| robertmyers | correction tox on any platform should not run any sudo command | 19:19 |
| hub_cap | now thats perty funny | 19:19 |
| cp16net | and cat /root/.mysql_secret | 19:19 |
| robertmyers | bad bad bad | 19:19 |
| cp16net | yeah bad | 19:20 |
| cp16net | my mac had issues with it | 19:20 |
| cp16net | and my linux box just cranked through | 19:20 |
| datsun180b | after these fixes my tests are consistently green | 19:20 |
| cp16net | kinda scares me | 19:20 |
| datsun180b | KNEW it was the db | 19:20 |
| robertmyers | basically tox should *only* effect the .tox virtualenv | 19:21 |
| robertmyers | not your dev box | 19:21 |
| datsun180b | that mysqld_bin fix wouldn't show up in jenkins if those ubuntu machines happen to have mysql installed, but it screams at us in os x because ours is kept in /opt/something/macs/are/goofy | 19:21 |
| cp16net | heh | 19:21 |
| cp16net | yeah | 19:21 |
| cp16net | fail | 19:21 |
| cp16net | plz merge this asap | 19:22 |
| datsun180b | and mine too | 19:22 |
| robertmyers | we should make sure no other commands are being run in the unittests | 19:22 |
| datsun180b | but if you merge his first then mine will be zero | 19:22 |
| cp16net | perferably yeah datsun180b's first | 19:23 |
| cp16net | :) | 19:23 |
| hub_cap | cp16net: link to datsun180bs | 19:23 |
| datsun180b | https://review.openstack.org/#/c/57555/ | 19:23 |
| datsun180b | we're just trying to get this thing fixed | 19:23 |
| cp16net | #link | 19:23 |
| datsun180b | #link https://review.openstack.org/#/c/57555/ ?? | 19:24 |
| cp16net | lol | 19:24 |
| cp16net | yes | 19:24 |
| hub_cap | cp16net: if u mark datsun180b's as a dependent commit, then we can +2/approve yours as well, and it wont merge until datsun180b's gets merged | 19:24 |
| cp16net | hub_cap: how wold i do that? | 19:25 |
| datsun180b | isn't doing that more work than just rebasing | 19:25 |
| hub_cap | not really | 19:25 |
| datsun180b | you'd have to checkout my code, add your commit, and resubmit the review anyway | 19:25 |
| hub_cap | ya effectively that | 19:25 |
| hub_cap | but its the same review | 19:25 |
| datsun180b | alternately pull, rebase, review | 19:25 |
| hub_cap | it just gets a dependency | 19:25 |
| datsun180b | six one way half a dozen the other | 19:26 |
| hub_cap | not really | 19:26 |
| cp16net | hmmm | 19:26 |
| cp16net | i'll try | 19:26 |
| hub_cap | cuz then we can approve his stuff and move on | 19:26 |
| datsun180b | i guess the difference is gerrit will know | 19:26 |
| cp16net | last time i did something like that i changed tim's review to mine | 19:26 |
| hub_cap | and magically itll get merged in 2+ hrs cuz gates are slow | 19:26 |
| cp16net | lol | 19:26 |
| hub_cap | cp16net: HAH, just dont change the commit id's | 19:26 |
| hub_cap | itll be HEAD->57555->your_review | 19:27 |
| cp16net | hub_cap: ok cangit-review do this? | 19:27 |
| cp16net | add a dependent review? | 19:27 |
| hub_cap | so when u do a git review | 19:28 |
| hub_cap | itll say "woah woah, you are submitting 2 patchsets, are u sure u want to do this" | 19:28 |
| datsun180b | if you review more than one commit it'll update the relevant reviews | 19:28 |
| hub_cap | and iirc, it should be yours on top, datsuns on the 2nd line | 19:28 |
| datsun180b | if you have four different commits and four different commit ids but you do git review once you get four reviews out of the deal with the dependencies in place | 19:29 |
| datsun180b | change-ids, not commit ids. that about right, hub_cap ? | 19:29 |
| hub_cap | yup | 19:29 |
| cp16net | ummmm | 19:30 |
| cp16net | datsun180b | 19:30 |
| cp16net | looks like your review is not the same level else: than the if: | 19:30 |
| datsun180b | huh | 19:30 |
| datsun180b | yeah that else i added belongs to the for | 19:30 |
| cp16net | oh yeah? | 19:31 |
| datsun180b | the else clause of a for loop executes if the loop wasn't broken | 19:31 |
| cp16net | oh interesting | 19:31 |
| hub_cap | yea gosh | 19:32 |
| datsun180b | better than "sentinel = None; for i in things; if condition(i): sentinel = i" | 19:32 |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove: need to mock out of the clear_expired_passwords for tox https://review.openstack.org/57739 | 19:32 |
| cp16net | ok i think it did it | 19:32 |
| hub_cap | so i dropped my car off and got a nice little loaner | 19:32 |
| cp16net | got a lotus? | 19:32 |
| cp16net | :-P | 19:32 |
| hub_cap | lol i wish | 19:33 |
| hub_cap | http://en.wikipedia.org/wiki/Range_Rover_Evoque | 19:33 |
| hub_cap | its got 300 miles on it | 19:33 |
| cp16net | ok i got the dep workin | 19:33 |
| hub_cap | me and the wife are gonna road trip it all weekend | 19:33 |
| datsun180b | cool | 19:33 |
| hub_cap | well we are gonna take our son w/ us too i guess | 19:33 |
| cp16net | how are your dogs? | 19:34 |
| cp16net | err dog... | 19:34 |
| hub_cap | shes layin right next to me | 19:34 |
| hub_cap | shes pretty chill | 19:34 |
| cp16net | pretty chill | 19:34 |
| cp16net | nice | 19:34 |
| hub_cap | heh | 19:34 |
| cp16net | my pup calms down after hes gone for a walk or run | 19:34 |
| hub_cap | for sure :) how old is he now? | 19:35 |
| cp16net | 7 months | 19:35 |
| hub_cap | oh fun :) | 19:35 |
| cp16net | yeah hes doing good | 19:35 |
| hub_cap | ours was a terror at 7mo lol | 19:35 |
| grapex | hub_cap SlickNik vipul: Please look at this- it's a fix for the CLI to relieve some pain at using the new CLI at Rax: https://review.openstack.org/#/c/57736/ | 19:36 |
| amcrn | i desperately want a rat terrier pup :/ | 19:37 |
| amcrn | what breed is yours cp16net | 19:38 |
| cp16net | amcrn: mines a lab mix | 19:39 |
| amcrn | nice, labs are awesome | 19:39 |
| hub_cap | amcrn: http://www.ratterrierresq.com/wp-content/uploads/2009/04/IMG_1096m.jpg | 19:39 |
| amcrn | awwwww | 19:39 |
| hub_cap | cp16net: good job on the dependency stuff. easy right? | 19:40 |
| cp16net | http://vyvial.smugmug.com/2013/Pup-Photo-Shoot/i-SJbKLjm/0/X2/IMG_5119-X2.jpg | 19:40 |
| cp16net | yeah | 19:40 |
| cp16net | hub_cap: so i used git-revi | 19:41 |
| cp16net | i checked out master and pull latest | 19:41 |
| cp16net | git-review -d 57555 | 19:41 |
| hub_cap | cp16net: that ole boy has some growin to do still :) | 19:41 |
| cp16net | git-review -x 57739 | 19:42 |
| cp16net | fix the conflicts and commit them | 19:42 |
| cp16net | then git-review | 19:42 |
| cp16net | that made it work | 19:42 |
| cp16net | hub_cap: he's slown' down | 19:42 |
| cp16net | hes about 65 it hink | 19:42 |
| cp16net | about 2 weeks ago he was 60 | 19:43 |
| *** yidclare has quit IRC | 19:43 | |
| hub_cap | hmm didnt know about -x | 19:44 |
| *** amcrn is now known as [a]mcrn | 19:44 | |
| cp16net | git-review --help | 19:45 |
| *** rongze has joined #openstack-trove | 19:45 | |
| cp16net | how about --help ? lolz | 19:45 |
| grapex | hub_cap: Respond: "rax_legacy" wouldn't make sense because its a new auth type for the old CLI. | 19:47 |
| *** jasonb365 has quit IRC | 19:47 | |
| datsun180b | what are you saying? the documentation helped you use the tools it accompanied? | 19:47 |
| datsun180b | that's unheard of | 19:47 |
| grapex | The new auth type works the same way as the new CLI, whose arguments are incompatible with the old CLI. | 19:47 |
| *** NehaV has quit IRC | 19:48 | |
| hub_cap | would anything make more sense than rax2 ? maybe rax_compat? | 19:49 |
| datsun180b | no rax2 is fine | 19:49 |
| hub_cap | rax2 it is! | 19:49 |
| *** rongze has quit IRC | 19:50 | |
| hub_cap | my laptop will be delivered by nov 25 sayeth amazon | 19:50 |
| hub_cap | or chromebook, netbook, whatever u call it | 19:51 |
| grapex | hub_cap: So is it still forbidden that we both +2 bits of code? | 19:51 |
| datsun180b | just in time for the snow | 19:51 |
| grapex | SlickNik vipul: If one of you could approve this, its just a backwards compatability thing that helps migrate scripts using the old CLI | 19:51 |
| hub_cap | grapex: /me shrugs, but lets have vipul or someone else non rax comment on it at least | 19:51 |
| datsun180b | why would they care? they won't use it | 19:51 |
| datsun180b | seeing how it's a rax auth method | 19:52 |
| grapex | datsun180b: Maybe they set up Rax auth and occasionally write code to integrate with it for fun? | 19:52 |
| datsun180b | "rax auth" and "fun" | 19:52 |
| datsun180b | what | 19:52 |
| vipul | i'll look at it just for sanity check | 19:52 |
| grapex | datsun180b: Let alone "cli" and "fun" | 19:52 |
| grapex | I was talking to redthrux earlier about how making any iteration of the CLI work has always been like solving a Resident Evil style puzzle. | 19:53 |
| datsun180b | You are standing in a dark cave. Exits are south, up, and Gary. _ | 19:53 |
| hub_cap | well since its in compat i dont think they would use it, but i wouldnt want to introduce company specific stuff into the openstack product.. this does not apply here tho :) | 19:53 |
| vipul | when are you guys just using a keystone API | 19:53 |
| vipul | you're already on rax2 :p | 19:53 |
| redthrux | ZOMG hub_cap LET ME TELL YOU THE WOES | 19:53 |
| hub_cap | redthrux: hahaha | 19:53 |
| grapex | vipul: Well then we'd miss out on hours of fun. :) | 19:54 |
| datsun180b | Yeah I think you threw that baby out with the bath water about the time "compat" was introduced | 19:54 |
| grapex | vipul: Seriously though, I'm not sure. You are preaching to the choir on that one. | 19:54 |
| datsun180b | if i misused that idiom i do not apologize | 19:54 |
| *** jdbarry has quit IRC | 19:56 | |
| datsun180b | think i got it anyway. sounds right | 19:57 |
| SlickNik | yeah, looks good to me (like datsun180b says, we're not gonna need to use it). | 19:57 |
| *** jasonb365 has joined #openstack-trove | 19:57 | |
| *** jdbarry has joined #openstack-trove | 19:58 | |
| *** yogesh has quit IRC | 20:01 | |
| datsun180b | as soon as those bugfixes are merged I'll rebase conductor and bother you all about it | 20:01 |
| *** NehaV has joined #openstack-trove | 20:05 | |
| openstackgerrit | A change was merged to openstack/python-troveclient: Allow for compatable auths between new and old CLI https://review.openstack.org/57736 | 20:05 |
| openstackgerrit | A change was merged to openstack/trove: Add default case for mysqld_bin https://review.openstack.org/57555 | 20:05 |
| *** yogesh_ has joined #openstack-trove | 20:05 | |
| cp16net | thanks vipul | 20:06 |
| cp16net | vipul: SlickNik: https://review.openstack.org/#/c/57739/ | 20:06 |
| cp16net | this is a dependent review for tox tests | 20:07 |
| openstackgerrit | A change was merged to openstack/trove: Remove radmin credentials from create_heat_client https://review.openstack.org/56373 | 20:08 |
| *** rwsu has joined #openstack-trove | 20:08 | |
| *** vipul is now known as vipul-away | 20:15 | |
| *** vipul-away is now known as vipul | 20:15 | |
| SnowDust | A change was merged to openstack/trove: Remove radmin credentials from create_heat_client https://review.openstack.org/56373 | 20:17 |
| SnowDust | thanks all !!! | 20:17 |
| datsun180b | was wondering why i didn't see the emails for that one | 20:18 |
| datsun180b | make sense now | 20:18 |
| datsun180b | oh vipul / SlickNik can either of you give https://review.openstack.org/#/c/57739/ a little push please? without it tox tries to manipulate mysql on the host running tox, not an entity in the tox env | 20:19 |
| vipul | datsun180b: sure seems like an easy review | 20:19 |
| datsun180b | thank you, it's killing unit tests otherwise | 20:20 |
| vipul | thanks for fixing it | 20:20 |
| hub_cap | cp16net: now check out https://review.openstack.org/#/c/57739/ , no more dependencies | 20:22 |
| datsun180b | yeah it's resolved | 20:23 |
| cp16net | thats tite | 20:23 |
| cp16net | thank vipul | 20:23 |
| datsun180b | now for the robots to take care of the rest | 20:24 |
| openstackgerrit | Craig Vyvial proposed a change to openstack/trove: adding configuration group support https://review.openstack.org/53168 | 20:24 |
| cp16net | ummm | 20:24 |
| datsun180b | huh | 20:24 |
| cp16net | ok so git-review -u almatically does that | 20:24 |
| *** SnowDust has quit IRC | 20:25 | |
| cp16net | how about automatically* | 20:25 |
| datsun180b | oh neat | 20:25 |
| cp16net | no it just forces up a review | 20:26 |
| cp16net | even if nothing has changed | 20:26 |
| cp16net | i guess if you want a bad version pushed ... you can do it.. :-P | 20:27 |
| datsun180b | yeah i keep away from commit -a usually | 20:27 |
| *** yogesh has joined #openstack-trove | 20:35 | |
| *** yogesh_ has quit IRC | 20:37 | |
| *** vipul is now known as vipul-away | 20:38 | |
| *** vipul-away is now known as vipul | 20:38 | |
| *** grapex has quit IRC | 20:39 | |
| *** yidclare has joined #openstack-trove | 20:39 | |
| *** rongze has joined #openstack-trove | 20:47 | |
| openstackgerrit | Kevin Conway proposed a change to openstack/trove-integration: Add support for kick-starting postgresql https://review.openstack.org/57608 | 20:48 |
| *** grapex has joined #openstack-trove | 20:48 | |
| *** ashestakov has joined #openstack-trove | 20:49 | |
| *** rongze has quit IRC | 20:51 | |
| *** vipul is now known as vipul-away | 20:53 | |
| *** vipul-away is now known as vipul | 20:54 | |
| datsun180b | craig's other fix is still queued for Zuul py26 but everything else is green. i've got to run but i'll try to wake conductor up tonight after that fix is merged | 20:57 |
| cp16net | haha yeah | 20:57 |
| cp16net | i've been waiting for that too | 20:57 |
| datsun180b | have fun! | 20:57 |
| *** datsun180b has quit IRC | 20:58 | |
| cp16net | its going.... | 20:58 |
| ashestakov | review pls https://review.openstack.org/#/c/54921/ | 21:00 |
| openstackgerrit | A change was merged to openstack/trove: need to mock out of the clear_expired_passwords for tox https://review.openstack.org/57739 | 21:01 |
| *** jasonb365 has quit IRC | 21:02 | |
| *** denis_makogon has quit IRC | 21:04 | |
| *** denis_makogon_ is now known as denis_makogon | 21:04 | |
| denis_makogon | hi guys__ | 21:04 |
| *** dmakogon_ has joined #openstack-trove | 21:04 | |
| denis_makogon | glad 2 see you all | 21:04 |
| kevinconway | there are too many of you in this room denis_makogon ))) | 21:07 |
| denis_makogon | nope)) | 21:07 |
| denis_makogon | kevinconway, only me and myself | 21:08 |
| denis_makogon | kevinconway, i've got question 2 you | 21:08 |
| kevinconway | uh oh... | 21:08 |
| denis_makogon | kevinconway, any reason to change flow of https://review.openstack.org/#/c/57608/2/scripts/redstack | 21:08 |
| kevinconway | denis_makogon: it was hard coded for mysql only | 21:09 |
| denis_makogon | kevinconway, from tech side, i agree with your changes | 21:09 |
| kevinconway | … BUT? | 21:10 |
| denis_makogon | kevinconway, there is always but))) | 21:10 |
| denis_makogon | kevinconway, could you make it as separate review, please ? | 21:10 |
| denis_makogon | kevinconway, it's a bit our of scope of postgres review | 21:11 |
| kevinconway | denis_makogon: ? | 21:11 |
| kevinconway | denis_makogon: i disagree. without that change you can't actually kick-start postgresql | 21:11 |
| kevinconway | you instances would not go active because it would install mysql | 21:12 |
| kevinconway | because mysql is hard coded | 21:12 |
| robertmyers | denis_makogon: it looks like it makes it possible to create a different datastore type | 21:12 |
| denis_makogon | kevinconway, is i agree, but it would be better to make 2 commits, not the single one | 21:12 |
| robertmyers | why? | 21:12 |
| kevinconway | separate it from what? | 21:12 |
| robertmyers | this should be changed to allow more types | 21:12 |
| denis_makogon | my point is that cassandra, mongo, redis, postgres need this changes, that is why i wondring to move it in its own review | 21:13 |
| denis_makogon | robertmyers, i agree | 21:13 |
| denis_makogon | current review could be separated into two dependent commits, and as result, two dependent reviews | 21:14 |
| robertmyers | denis_makogon: I see | 21:16 |
| kevinconway | denis_makogon: yeah, i get what you're saying | 21:16 |
| denis_makogon | kevinconway, thanks, a lot, it's good to have same thought and be "on the same wave" | 21:17 |
| denis_makogon | robertmyers, kevinconway thanks, guys | 21:17 |
| *** flaper87 is now known as flaper87|afk | 21:18 | |
| ashestakov | kevinconway: do tests works with your review? | 21:19 |
| kevinconway | ashestakov: the integration review? | 21:19 |
| ashestakov | kevinconway: yes | 21:20 |
| ashestakov | i think names of datastores are hardcoded in tests for mysql | 21:20 |
| kevinconway | ashestakov: i believe they do. they passed earlier. | 21:20 |
| denis_makogon | robertmyers, could you update your status with this review https://review.openstack.org/#/c/56702/ | 21:21 |
| robertmyers | denis_makogon: ? | 21:22 |
| denis_makogon | robertmyers, personaly i thinks we need this patch | 21:22 |
| ashestakov | kevinconway: how about this https://github.com/openstack/trove/blob/master/trove/tests/config.py#L74 ? | 21:22 |
| robertmyers | denis_makogon: you agreed with me tho? what do you want me to update? | 21:22 |
| denis_makogon | robertmyers, update means - Any estimates for approvent of this | 21:23 |
| robertmyers | denis_makogon: well, its my patch soo, I *could* +1 it but others need to | 21:24 |
| robertmyers | I want it in :) | 21:24 |
| kevinconway | ashestakov: i think i see what you mean. i haven't gotten to making the tests pass with a real instance yet. | 21:24 |
| denis_makogon | robertmyers, i mean approvement from -cores | 21:24 |
| kevinconway | ashestakov: the integration review is just to add the ability to build instances for testing/dev | 21:25 |
| ashestakov | kevinconway: i think fake tests should be failed | 21:25 |
| robertmyers | denis_makogon: I can't read minds ;) | 21:25 |
| kevinconway | ashestakov: only if you actually kick-start postgresql | 21:25 |
| denis_makogon | robertmyers, ok, i got you | 21:25 |
| kevinconway | ashestakov: i will fix this as i work on the trove review | 21:25 |
| ashestakov | kevinconway: actually there tests for datastores | 21:25 |
| denis_makogon | ashestakov, could you co-work with kevinconway on making tests passable ? | 21:26 |
| denis_makogon | guys, it would be nice to review this one https://review.openstack.org/#/c/57408/ | 21:28 |
| robertmyers | denis_makogon: I'm also working on another swift related bug, then fixing the restore logic to be less mysql specific | 21:29 |
| robertmyers | https://bugs.launchpad.net/trove/+bug/1253752 | 21:29 |
| denis_makogon | robertmyers, have you read about swift-server-side encryption | 21:29 |
| robertmyers | no, what is that? | 21:30 |
| denis_makogon | it means that swift allow to perform enc. on swift side, not even before sending artifact to it | 21:31 |
| robertmyers | denis_makogon: sounds good to me, we don't use that feature in trove | 21:32 |
| robertmyers | denis_makogon: we == rax | 21:32 |
| denis_makogon | robertmyers, i know, that's why i'm telling you) | 21:32 |
| robertmyers | that would be alot nicer tho | 21:33 |
| denis_makogon | robertmyers, [openstack-dev] [Swift] Server Side Encryption | 21:33 |
| denis_makogon | robertmyers, you could search in ML | 21:33 |
| robertmyers | denis_makogon: found it thanks | 21:34 |
| denis_makogon | robertmyers, np ;) | 21:34 |
| openstackgerrit | Kevin Conway proposed a change to openstack/trove-integration: Add support for kick-starting new datastores https://review.openstack.org/57780 | 21:35 |
| denis_makogon | kevinconway, <3 | 21:36 |
| denis_makogon | hub_cap, vipul, SlickNik: could you please take a look at https://review.openstack.org/#/c/56930/ | 21:36 |
| kevinconway | so how do dependent commits work? | 21:37 |
| kevinconway | i did a review -d <number> but it just checked out the branch | 21:37 |
| kevinconway | do i just apply the change and review? | 21:37 |
| denis_makogon | it work in next way | 21:38 |
| denis_makogon | localy you make 2 commit on single branch, then hit "git review" and follow questions being asked | 21:38 |
| ashestakov | kevinconway: should works | 21:39 |
| denis_makogon | wow, all tests on first kevinconway review passed ))) | 21:40 |
| *** yogesh has quit IRC | 21:44 | |
| ashestakov | kevinconway: ah, names not hardcoded now, nvm | 21:45 |
| *** yogesh has joined #openstack-trove | 21:45 | |
| *** rongze has joined #openstack-trove | 21:47 | |
| *** yogesh has quit IRC | 21:49 | |
| *** rongze has quit IRC | 21:52 | |
| hub_cap | ive been enlisted in the making of bacon pancakes | 22:01 |
| hub_cap | http://www.youtube.com/watch?v=TrcT7sseLZI | 22:01 |
| hub_cap | im following those directions | 22:01 |
| *** yogesh has joined #openstack-trove | 22:02 | |
| hub_cap | ill be back in ~20 | 22:03 |
| imsplitbit | mmmm bacon | 22:04 |
| denis_makogon | imsplitbit, like Homer, mmmm bacoooooon | 22:11 |
| imsplitbit | lol | 22:11 |
| imsplitbit | I don't watch the simpsons | 22:11 |
| imsplitbit | but I am definitely in favor of bacon | 22:11 |
| imsplitbit | on everything | 22:11 |
| imsplitbit | it's how you make something tastier | 22:12 |
| denis_makogon | everything with bacon tasts better, even bacon | 22:14 |
| *** pdmars has quit IRC | 22:17 | |
| cp16net | Homer: Lurlee your song touched me in so many ways ... and which way to the can? | 22:34 |
| cp16net | Bender: Bite my splintery, wooden ass! | 22:34 |
| * hub_cap boxes cp16net with an amazing sheet of paper | 22:37 | |
| * hub_cap enters Khaled Mardam-Bey in cp16net's Spotlight. Weeee 1224 Hits! | 22:37 | |
| * cp16net boxes hub_cap with Cthulhu's tentacles | 22:38 | |
| * cp16net leads hub_cap into a dark alley - Hey, test my crowbar! | 22:38 | |
| hub_cap | dirty | 22:38 |
| cp16net | lol | 22:38 |
| openstackgerrit | Kevin Conway proposed a change to openstack/trove: WIP: Add PostgreSQL support https://review.openstack.org/57609 | 22:42 |
| *** ashestakov has quit IRC | 22:44 | |
| *** rongze has joined #openstack-trove | 22:48 | |
| hub_cap | wife approves of bacon pancakes | 22:50 |
| hub_cap | mine are almost done | 22:50 |
| * hub_cap is excited | 22:50 | |
| kevinconway | hub_cap: i need some gerrit help | 22:51 |
| kevinconway | i've updated my review at https://review.openstack.org/#/c/57608/2 | 22:52 |
| kevinconway | is there a way to have it depend on https://review.openstack.org/#/c/57780/? | 22:52 |
| *** rongze has quit IRC | 22:54 | |
| hub_cap | kevinconway: heck yes | 22:56 |
| kevinconway | even if they are on separate topic branches? | 22:57 |
| hub_cap | ya i dont think thats a problem | 22:57 |
| hub_cap | lets use git review -x since cp16net found it today | 22:58 |
| hub_cap | so just do a | 22:58 |
| hub_cap | git review -d parent_commit | 22:58 |
| kevinconway | yeah, i did that. it just checks out the other branch | 22:58 |
| hub_cap | git review -x child_commit | 22:58 |
| kevinconway | ah | 22:58 |
| kevinconway | missing steps | 22:59 |
| hub_cap | fix any of the conflicts | 22:59 |
| hub_cap | and then just do a | 22:59 |
| cp16net | yes thats the easiest way to do it | 22:59 |
| hub_cap | git review | 22:59 |
| cp16net | :) | 22:59 |
| cp16net | alright i think its time to head home | 22:59 |
| *** jasonb365 has joined #openstack-trove | 22:59 | |
| kevinconway | thanks, i'll give it a shot. probably not right now though. home time. | 22:59 |
| hub_cap | bacon pancake time is more like it | 23:00 |
| *** amytron has quit IRC | 23:02 | |
| *** kevinconway has quit IRC | 23:02 | |
| hub_cap | im pretty sure bacon pancakes are not brain food | 23:04 |
| cp16net | hub_cap: they could be | 23:06 |
| cp16net | talk you l8r | 23:06 |
| hub_cap | cp16net: peace | 23:07 |
| denis_makogon | hub_cap, glad to see you)) | 23:15 |
| denis_makogon | hub_cap, could you please review some code ? | 23:16 |
| denis_makogon | hub_cap, less then 20 lines)) | 23:16 |
| openstackgerrit | Robert Myers proposed a change to openstack/trove: Simply swift storage load logic https://review.openstack.org/57796 | 23:16 |
| *** yogesh has quit IRC | 23:17 | |
| *** yogesh has joined #openstack-trove | 23:18 | |
| hub_cap | denis_makogon: send me the link | 23:20 |
| denis_makogon | hub_cap, https://review.openstack.org/#/c/56930/ | 23:20 |
| denis_makogon | hub_cap, https://review.openstack.org/#/c/57408/ | 23:20 |
| *** robertmyers has quit IRC | 23:21 | |
| *** yogesh has quit IRC | 23:22 | |
| denis_makogon | hub_cap, i saw you approved ikhudoshyn patch, what if there would be misconfiguration with mount points ? | 23:25 |
| *** demorris has quit IRC | 23:25 | |
| hub_cap | misconfiguration by a operator? | 23:26 |
| denis_makogon | hub_cap, one in db config, and another in trove conf | 23:26 |
| denis_makogon | hub_cap, i thought about getting mount point for volue from db config | 23:26 |
| hub_cap | we cannot (and should not) try to fix operator error. we can document it. and why do we have mount point in the db? | 23:26 |
| hub_cap | the better idea might be to put those things into metadata server | 23:27 |
| denis_makogon | mount_point=/var/lib/mysql | 23:27 |
| denis_makogon | mysql data_dir = /var/lib/mysql | 23:27 |
| hub_cap | i dont like the idea of having that stuff in our db when they can go into a metadata store (like nova) | 23:27 |
| hub_cap | *like nova has* | 23:27 |
| denis_makogon | i'm missing something, could you correct me | 23:28 |
| denis_makogon | i wondering why not read storage location for mysql config and pass it like mount_point ? | 23:29 |
| *** jmontemayor has quit IRC | 23:30 | |
| hub_cap | how is that better than it being in a config value? | 23:30 |
| hub_cap | grapex: cp16net do yall remember why mount_point wasnt put as a conf variable in the guest conf? i think cp16net worked on that MANY moons ago | 23:31 |
| hub_cap | oh and grapex, u know the best thing about the holidays? eggnog+coffee | 23:31 |
| denis_makogon | https://github.com/openstack/trove/blob/master/trove/templates/mysql/config.template#L11 | 23:31 |
| grapex | hub_cap: That work happened in concert with a dozen other things, so my guess is we screwed up. :| | 23:31 |
| hub_cap | denis_makogon: maybe it makes more sense to generate it there, and let the guest read it from the config file | 23:32 |
| hub_cap | if it needs it for mounting etc.. | 23:32 |
| hub_cap | rather than putting it in the guest config file | 23:33 |
| denis_makogon | hub_cap, yes, that's what i mean | 23:33 |
| denis_makogon | now if i want change mount point(datadir) i need to to that twice | 23:34 |
| hub_cap | so, read in from the taskmgr config file (like it is today). put in to the template file as datadir = {{ mountpoint }} | 23:34 |
| hub_cap | when the guest needs it, it reads the my.cnf to find its DATADIR | 23:34 |
| hub_cap | for things like doing mv's and mounts and such | 23:34 |
| denis_makogon | agreed with last step, but why do we need to render new parameter | 23:35 |
| *** NehaV has quit IRC | 23:35 | |
| denis_makogon | my major point is to avoid using mount_point in any of trove confs | 23:36 |
| hub_cap | well u cant say that | 23:36 |
| hub_cap | cuz then u wouldnt define datadir | 23:36 |
| hub_cap | its _somewhere_ | 23:36 |
| hub_cap | and its configurable | 23:36 |
| hub_cap | if, for some reason, the user decides to leave that value out of their custom config | 23:36 |
| hub_cap | our guest will start barfing | 23:36 |
| openstackgerrit | A change was merged to openstack/trove: User-Create Host Does Not Allow Wildcarded Octet https://review.openstack.org/54216 | 23:37 |
| hub_cap | but if we make sure, by the fact that its in our config file for taskmgr, that itll get set properly. | 23:37 |
| hub_cap | so when the guest needs it, it knows itll be there | 23:37 |
| denis_makogon | hub_cap, could i make patch from my thoughts and let all interested take a look on it ? | 23:38 |
| hub_cap | sure. but do u see my point? cuz i will make sure to reiterate it if you leave it out of the taskmgr conf :) | 23:38 |
| denis_makogon | i'm seing problem when something like cassandra and mongo would come | 23:40 |
| denis_makogon | volume mount into the database datadir | 23:41 |
| denis_makogon | *mounts | 23:41 |
| denis_makogon | i don't realy like to change mount_point in gues conf when i need something different from mysql | 23:42 |
| denis_makogon | i think the best way is to use datadir for my.cnf - it would lead us to easier configuration | 23:44 |
| *** [a]mcrn is now known as amcrn | 23:44 | |
| denis_makogon | to be precise, only one place to change mount_point in templates/{datastore}/config.template | 23:44 |
| *** jasonb365 has quit IRC | 23:45 | |
| denis_makogon | in this way it would be harder to misconfigure volume mounting | 23:45 |
| hub_cap | my way is the same | 23:47 |
| hub_cap | u only configure on taskmgr config file | 23:47 |
| hub_cap | but im ok either way | 23:47 |
| *** esp has joined #openstack-trove | 23:48 | |
| denis_makogon | hub_cap, thanks for help, as always <3 | 23:48 |
| *** rongze has joined #openstack-trove | 23:50 | |
| denis_makogon | also, i would like you all take a look at Trove resource in Heat | 23:52 |
| denis_makogon | not so long ago i reviewed those one, but since trove got ashestakov huge feature, we need to re-review it, so anyone, please welcome | 23:53 |
| *** rnirmal has quit IRC | 23:54 | |
| denis_makogon | hub_cap, goodnight ) | 23:55 |
| *** rongze has quit IRC | 23:56 | |
| *** amytron has joined #openstack-trove | 23:57 | |
| *** yogesh has joined #openstack-trove | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
