| *** e0ne has joined #openstack-telemetry | 02:57 | |
| *** e0ne has quit IRC | 02:57 | |
| *** witek_ has joined #openstack-telemetry | 06:16 | |
| openstackgerrit | Xuan Yandong proposed openstack/ceilometer master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/ceilometer/+/787919 | 06:45 |
|---|---|---|
| openstackgerrit | Xuan Yandong proposed openstack/ceilometermiddleware master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/ceilometermiddleware/+/787920 | 06:52 |
| openstackgerrit | Matthias Runge proposed openstack/ceilometer master: Use tox constraints instead of upper constraints https://review.opendev.org/c/openstack/ceilometer/+/785861 | 06:56 |
| *** bengates has joined #openstack-telemetry | 07:26 | |
| *** openstack has joined #openstack-telemetry | 07:54 | |
| *** ChanServ sets mode: +o openstack | 07:54 | |
| *** e0ne has joined #openstack-telemetry | 08:10 | |
| *** openstackgerrit has quit IRC | 08:11 | |
| *** lxkong has quit IRC | 08:24 | |
| *** lxkong has joined #openstack-telemetry | 08:30 | |
| *** openstackgerrit has joined #openstack-telemetry | 10:43 | |
| openstackgerrit | Merged openstack/telemetry-tempest-plugin master: Switch telemetry-tempest-dsvm to non-voting for now https://review.opendev.org/c/openstack/telemetry-tempest-plugin/+/787739 | 10:43 |
| *** witek_ has quit IRC | 12:10 | |
| *** witek_ has joined #openstack-telemetry | 12:42 | |
| zigo | mrunge: Hey man, how are you? | 13:13 |
| zigo | What's the status of your patch here? https://review.opendev.org/c/openstack/aodh/+/786880 | 13:13 |
| zigo | Is it only the unit tests that are broken, or what? | 13:13 |
| zigo | Can I confidently add it to Debian packages? | 13:13 |
| zigo | (removing the tests...) | 13:13 |
| mrunge | zigo, hey. | 13:44 |
| mrunge | with this patch, unit tests are missing | 13:45 |
| zigo | My package fails unit tests when I add your patch. | 13:45 |
| mrunge | and integration tests are failing. But they are failing anyways (neutron port still in use after shutting down a vm) | 13:45 |
| mrunge | what fails exactly? | 13:46 |
| zigo | Give me 15 minutes to build it again. | 13:46 |
| zigo | And I'll tell you. | 13:46 |
| zigo | (I want to check without the patch first...) | 13:46 |
| mrunge | okay, thank you | 13:47 |
| zigo | Confirmed. | 13:49 |
| zigo | mrunge: http://paste.openstack.org/show/804780/ | 13:49 |
| zigo | That's building Victoria. | 13:49 |
| * mrunge clicks | 13:49 | |
| mrunge | did you check the latest version of that patch? | 13:50 |
| zigo | I can try to update it, but I believe I have the latest version. | 13:50 |
| zigo | Trying to update, just to confirm. | 13:50 |
| mrunge | I have seen that as failure in an iteration | 13:50 |
| mrunge | and they added a catch for that? | 13:50 |
| mrunge | yes, see https://review.opendev.org/c/openstack/aodh/+/786880/5/aodh/evaluator/threshold.py#41 | 13:51 |
| zigo | Not the same patch, indeed: | 13:52 |
| zigo | - if rule['metric'] == 'cpu': | 13:52 |
| zigo | + if 'metric' in rule and rule['metric'] == 'cpu': | 13:52 |
| mrunge | https://review.opendev.org/c/openstack/aodh/+/786880/4..5/aodh/evaluator/threshold.py | 13:52 |
| mrunge | that's the diff | 13:52 |
| mrunge | yes | 13:52 |
| mrunge | personally, I don't like this hard coding of metric rules in this patch | 13:52 |
| mrunge | that has to be better in ceilometer | 13:53 |
| zigo | It's passing ! :) | 13:53 |
| zigo | Thanks. | 13:53 |
| mrunge | you're welcome | 13:53 |
| zigo | Will try it right away in our pre-prod cluster. | 13:54 |
| zigo | IMO, it's missing docs on how to use it. | 13:54 |
| mrunge | yes | 13:54 |
| zigo | We may contribute that part of the doc for autoscalling. | 13:54 |
| zigo | As we're documenting it for ourselves ... | 13:54 |
| mrunge | oh, nice! | 13:54 |
| mrunge | I'm happy to pick that up upstream | 13:54 |
| zigo | :) | 13:56 |
| zigo | Got to wait until my colleague writes a full doc for our customers, then I can pick-it-up and rewrite it in Sphinx format. | 13:57 |
| zigo | Any idea where I should write it? | 13:57 |
| zigo | In Aodh maybe? | 13:57 |
| zigo | What chapter, etc. ? | 13:57 |
| mrunge | The template for autoscaling is in HEAT | 13:57 |
| mrunge | but maybe really adding a new chapter in aodh would be the better option | 13:58 |
| *** openstackgerrit has quit IRC | 14:23 | |
| *** bengates has quit IRC | 16:29 | |
| *** bengates has joined #openstack-telemetry | 16:30 | |
| *** bengates has quit IRC | 16:35 | |
| *** witek_ has quit IRC | 17:55 | |
| *** witek_ has joined #openstack-telemetry | 18:33 | |
| *** witek_ has quit IRC | 19:23 | |
| *** e0ne has quit IRC | 20:55 | |
| *** jobewan has joined #openstack-telemetry | 23:39 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!