| *** pojadhav|afk is now known as pojadhav | 04:45 | |
| *** pojadhav- is now known as pojadhav | 11:05 | |
| *** pojadhav is now known as pojadhav|break | 11:35 | |
| *** pojadhav|break is now known as pojadhav | 12:08 | |
| opendevreview | Dan Smith proposed openstack/project-team-guide master: Add unified-limits technical guide https://review.opendev.org/c/openstack/project-team-guide/+/833672 | 16:03 |
|---|---|---|
| *** diablo_rojo is now known as Guest2228 | 16:11 | |
| *** Guest2228 is now known as diablo_rojo | 16:17 | |
| spotz_ | dansmith: Do you want comments for grammar or edits? | 20:17 |
| dansmith | spotz_: my grammar is perfect, obviously! (of course edits!) | 20:20 |
| spotz_ | dansmith: You seem very comma happy:) | 20:20 |
| dansmith | I am a serial comma over-offender for sure | 20:21 |
| spotz_ | even there!:) | 20:21 |
| spotz_ | Most of it read nicely though except for the commas and a missing the | 20:21 |
| dansmith | spotz_: also you don't (nor does anyone) need to ask permission to review my stuff | 20:23 |
| * dansmith removed like seven commas from that last message before sending | 20:23 | |
| spotz_ | dansmith: I always ask the first time before editing someone's writing | 20:24 |
| spotz_ | Some people do prefer the comments to improve | 20:24 |
| dansmith | spotz_: well, do it for you, not for me.. this is open source, yo | 20:24 |
| dansmith | damn, too many commas! | 20:25 |
| spotz_ | Not improve persay but when English isn't a first language it actually helps them | 20:25 |
| spotz_ | I think Oslo is capitalized, someone will correct if wrong:) | 20:28 |
| dansmith | yeah, you're right. I struggle to capitalize all of the projects because I use them so often in lowercase, and oslo especially | 20:35 |
| opendevreview | Amy Marrich proposed openstack/project-team-guide master: Add unified-limits technical guide https://review.opendev.org/c/openstack/project-team-guide/+/833672 | 20:35 |
| dansmith | oh, I thought you were going to give me _comments_ | 20:36 |
| spotz_ | hehe I though you said edit! | 20:36 |
| dansmith | I thought you meant edits like red pen :) | 20:36 |
| spotz_ | ugh! | 20:37 |
| spotz_ | There were a LOT of commas.... | 20:37 |
| opendevreview | Merged openstack/governance master: Remove the vulnerability:managed tag https://review.opendev.org/c/openstack/governance/+/830478 | 20:39 |
| dansmith | I think you changed the meaning of one of my sentences. I'll _comment_ and have you look | 20:40 |
| dansmith | several of the comma-ectomies make it harder to read now for me, which is why it'd be nice to discuss or justify them in comments | 20:43 |
| dansmith | specifically: | 20:43 |
| dansmith | "It is recommended that if any unified limits are to be applied, all of them should be applied" | 20:43 |
| dansmith | to me, that comment is shorthand for "then", but without it in your edit it seems to all run together too much.. is that just me being crazy? | 20:44 |
| dansmith | spotz_: left that comment in the change of meaning there on L76 | 20:46 |
| spotz_ | dansmith: I can see 76 changing it | 20:49 |
| dansmith | ack, will fix without adding any commas :) | 20:50 |
| spotz_ | hehe | 20:50 |
| spotz_ | And I'm not offended if you want to revert | 20:53 |
| dansmith | https://linguaholic.com/linguablog/comma-before-then/ | 20:54 |
| dansmith | this is what I'm thinking of in the quoted line above, although my "then" is implied, which it doesn't cover | 20:54 |
| dansmith | oh SNAP | 20:54 |
| dansmith | https://english.stackexchange.com/questions/4693/if-with-implicit-then-question-should-a-comma-be-used | 20:54 |
| dansmith | OPTIONAL comma | 20:55 |
| dansmith | that means I get to add some back (two I think) | 20:55 |
| dansmith | sweet sweet comma revenge! | 20:55 |
| dansmith | and also, "Martha" from 2010 agrees that when in doubt, add the comma | 20:56 |
| dansmith | that's like 51% pro-comma majority | 20:56 |
| spotz_ | hehe | 20:57 |
| spotz_ | comma wars! | 20:57 |
| dansmith | I will never let you forget that you were ambiguously not correct about 7% of my comma usage | 20:57 |
| opendevreview | Dan Smith proposed openstack/project-team-guide master: Add unified-limits technical guide https://review.opendev.org/c/openstack/project-team-guide/+/833672 | 21:14 |
| spotz_ | hehe, I'll buy you strudel in Berlin to make up for it | 21:24 |
| dansmith | I won't be in berlin, but you buy me a strudel, and then eat it for me and we'll call it even :) | 21:25 |
| spotz_ | hehe | 21:47 |
| fungi | i'll eat your share of kartoffelsalat | 21:48 |
| spotz_ | Potato salad! | 21:49 |
| fungi | it's a biergarten mainstay | 21:49 |
| spotz_ | oh fungi do you know what's up with stackalytics? I know you don't maintain it but it's said updating for a week | 21:50 |
| fungi | absolutely no clue | 21:50 |
| fungi | i think the current maintainers may be in the ukraine though? so... maybe just wait a little longer | 21:50 |
| spotz_ | ahh, hope they're ok:( | 21:50 |
| fungi | me too! | 21:51 |
| clarkb | one thing worth noting is there are two servers and you wnat ot make sure you aren't looking at the wrong one | 22:09 |
| opendevreview | Merged openstack/project-team-guide master: Add unified-limits technical guide https://review.opendev.org/c/openstack/project-team-guide/+/833672 | 22:56 |
| *** timburke_ is now known as timburke | 23:42 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!