opendevreview | Clay Gerrard proposed openstack/swift master: WIP: Refactor SLO size/etag sysmeta tests https://review.opendev.org/c/openstack/swift/+/896466 | 00:10 |
---|---|---|
opendevreview | ASHWIN A NAIR proposed openstack/swift master: slo: part-number=N query paramater support https://review.opendev.org/c/openstack/swift/+/894570 | 00:16 |
opendevreview | Jianjian Huo proposed openstack/swift master: Object-server: add periodic greenthread yielding during file read. https://review.opendev.org/c/openstack/swift/+/896872 | 05:17 |
opendevreview | Pete Zaitcev proposed openstack/swift master: tests: drop pkg_resources from test_auditor.py https://review.opendev.org/c/openstack/swift/+/897991 | 17:07 |
opendevreview | Jianjian Huo proposed openstack/swift master: Object-server: add periodic greenthread yielding during file read. https://review.opendev.org/c/openstack/swift/+/896872 | 17:15 |
opendevreview | Jianjian Huo proposed openstack/swift master: Object-server: add periodic greenthread yielding during file read. https://review.opendev.org/c/openstack/swift/+/896872 | 18:05 |
opendevreview | Alistair Coles proposed openstack/swift master: WIP s3api: Stop propagating storage policy to sub-requests https://review.opendev.org/c/openstack/swift/+/897864 | 18:37 |
timburke | #startmeeting swift | 21:00 |
opendevmeet | Meeting started Wed Oct 11 21:00:10 2023 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:00 |
opendevmeet | The meeting name has been set to 'swift' | 21:00 |
mattoliver | o/ | 21:00 |
timburke | who's here for the swift meeting? | 21:01 |
timburke | (sorry, i'm a little distracted trying to concurrently help my daughter with some homework) | 21:01 |
mattoliver | lol, np | 21:02 |
timburke | which also means i haven't updated the agenda | 21:02 |
timburke | i think the only big thing i wanted to bring up was the PTG | 21:03 |
timburke | i'll i still need to add my own availability, and i should probably nudge clayg, indianwhocodes, and a few others to add theirs | 21:04 |
timburke | but i'll book meeting slots soon | 21:05 |
mattoliver | yeah, I did mine | 21:05 |
timburke | and we'll continue to add topics to the etherpad | 21:06 |
timburke | #link https://etherpad.opendev.org/p/swift-ptg-caracal | 21:06 |
mattoliver | +1 | 21:06 |
timburke | i started adding some today, and i see mattoliver's adding, too :-) | 21:07 |
mattoliver | yup, adding a few discussion topics. But will pad out with some more as I think of them. | 21:07 |
timburke | only a week and a half away now! | 21:08 |
timburke | that's the only major thing i wanted to bring up this week | 21:09 |
timburke | #open discussion | 21:09 |
timburke | mattoliver, since it's just you and me -- anything you'd like to bring up? or i can fill you in on some of what i've been doing with labeled metrics | 21:09 |
mattoliver | ahh, I don't have too much, I know I keep saying that, but other work keeps getting in my way. But I'd love to hear about labeled metrics! | 21:10 |
timburke | so at one point i was working toward a big-bang transition -- one patch that would touch absolutely *everywhere* that we emit metrics | 21:11 |
mattoliver | like tracing | 21:12 |
timburke | #link https://review.opendev.org/c/openstack/swift/+/885321 | 21:12 |
timburke | this was rather horrible -- more than 1k line diff, and that's before even starting to look at fixing up tests | 21:13 |
timburke | on investigating, it seems like a more gradual transition shouldn't be too bad, operationally -- the statsd_exporter that i'm targeting is happy to eat a mix of labeled and legacy metrics | 21:14 |
mattoliver | kk | 21:15 |
mattoliver | I thought one benefit of the whole hog approach, was we could maybe decouple the logger from metrics. Is that something we can still do easily in a gradual approach? is that still the plan? | 21:16 |
timburke | so i did a spike to break it up as a chain: first, make some assertions about the actual bytes-on-the-wire that we're sending, then add the new can-emit-as-labeled-metrics api to StatsdClient (making sure that those on-the-wire tests still pass), then change the calls to use labels | 21:16 |
timburke | yeah, we probably could still do that... haven't looked hard at it yet, as it doesn't seem to be on the critical path | 21:17 |
mattoliver | kk | 21:17 |
timburke | that chain ends at | 21:17 |
timburke | #link https://review.opendev.org/c/openstack/swift/+/896969 | 21:17 |
timburke | though it clearly needs a little more work | 21:18 |
timburke | but once we have the new api from https://review.opendev.org/c/openstack/swift/+/896968 i think we can spin out a bunch of separate patches for all the other places we want to start having labeled metrics | 21:19 |
mattoliver | oh I like the build up. More tests first to get a better picture and then moving up to labeled metrics. | 21:20 |
timburke | it seemed like a good way to de-risk us breaking legacy metrics -- in no small part because i realized that our biggest cluster will probably have to live with them for a while, as graphs get rebuilt to use the new stuff | 21:22 |
mattoliver | Nice, might need to do some research into some of these mode types, some I've heard others not so much | 21:22 |
mattoliver | oh yeah, now that's a great point. There is alot of infrastructure that revolves around metrics.. so there will be alot of work to use the new hotness. | 21:23 |
mattoliver | This is looking pretty great tim | 21:24 |
mattoliver | also thanks for comment links for each build_line func | 21:25 |
timburke | one idea that's come up is providing an option to have us emit *both* labeled and legacy metrics -- i'm torn about it, though -- if an operator wanted to put in the work to ensure metrics continuity, it seems likely to lead to double-counting... | 21:26 |
mattoliver | yeah. But I guess if you can point them to different end points, there could be a clear separation. | 21:27 |
mattoliver | this is a great start. I'll keep this tab open and work my way though it more indepth. | 21:27 |
timburke | thanks, mattoliver | 21:28 |
timburke | all right, that's all i've got | 21:28 |
timburke | i think i'll call it early and let you enjoy your morning :-) | 21:28 |
timburke | thanks for coming, and thanks for working on swift! | 21:29 |
timburke | #endmeeting | 21:29 |
opendevmeet | Meeting ended Wed Oct 11 21:29:15 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:29 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2023/swift.2023-10-11-21.00.html | 21:29 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2023/swift.2023-10-11-21.00.txt | 21:29 |
opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2023/swift.2023-10-11-21.00.log.html | 21:29 |
mattoliver | cool, I think I might need to go take the kid to school anyways :) | 21:29 |
mattoliver | thanks timburke for all you do! | 21:29 |
opendevreview | ASHWIN A NAIR proposed openstack/swift master: s3api: Support GET/HEAD request with PartNumber https://review.opendev.org/c/openstack/swift/+/894580 | 21:37 |
opendevreview | ASHWIN A NAIR proposed openstack/swift master: s3api: Support GET/HEAD request with PartNumber https://review.opendev.org/c/openstack/swift/+/894580 | 21:37 |
indianwhocodes | catching up, sorry was a bit late. | 21:39 |
opendevreview | Tim Burke proposed openstack/swift master: stats: Allow emission of labeled metrics https://review.opendev.org/c/openstack/swift/+/896968 | 22:01 |
opendevreview | Tim Burke proposed openstack/swift master: Move proxy-logging to labeled metrics https://review.opendev.org/c/openstack/swift/+/896969 | 22:01 |
opendevreview | Clay Gerrard proposed openstack/swift master: WIP: Refactor SLO size/etag sysmeta tests https://review.opendev.org/c/openstack/swift/+/896466 | 22:37 |
opendevreview | Clay Gerrard proposed openstack/swift master: WIP: slo: refactor GET/HEAD response handling https://review.opendev.org/c/openstack/swift/+/893578 | 22:37 |
-opendevstatus- NOTICE: Another short Gerrit outage for updates on review.opendev.org. This update ensures we are using the current versions of all Gerrit plugins. | 23:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!