*** timburke__ is now known as timburke | 20:59 | |
timburke | #startmeeting swift | 21:00 |
---|---|---|
opendevmeet | Meeting started Wed May 25 21:00:56 2022 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. | 21:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 21:00 |
opendevmeet | The meeting name has been set to 'swift' | 21:00 |
timburke | who's here for the swift meeting? | 21:01 |
ade_lee | o/ | 21:01 |
mattoliver | o/ | 21:01 |
timburke | as usual, the agenda's at https://wiki.openstack.org/wiki/Meetings/Swift | 21:02 |
timburke | and as usual, i haven't updated it like i should have ;-) | 21:03 |
timburke | first up | 21:03 |
timburke | #topic gate failures | 21:03 |
timburke | our gate's busted! | 21:03 |
timburke | but https://review.opendev.org/c/openstack/swift/+/842817 should fix it | 21:03 |
timburke | tl;dr is that with openstack dropping py36 and py37 support for zed, we've got to maintain our own constraints file for the old versions again | 21:04 |
mattoliver | oh thanks for dinning into hat | 21:04 |
mattoliver | *that | 21:04 |
timburke | see also https://governance.openstack.org/tc/reference/runtimes/zed.html | 21:05 |
mattoliver | *digging | 21:05 |
mattoliver | wow, you can tell it's early here, I can't even type :P | 21:05 |
timburke | and http://lists.openstack.org/pipermail/openstack-discuss/2022-May/028611.html | 21:06 |
mattoliver | ok and centos stream 9 for zed, interesting | 21:06 |
timburke | now i just need to get the fix merged ;-) | 21:07 |
timburke | yeah, i started looking at getting a centos stream 9 job running somewhere... pyeclib or liberasurecode, maybe? but i don't think i actually got it passing | 21:08 |
timburke | ah! sure enough, libec: https://review.opendev.org/c/openstack/liberasurecode/+/820969 | 21:08 |
timburke | last run was a few months ago, though, and i don't remember what the failure mode was | 21:09 |
ade_lee | timburke, its definitely worth re-running | 21:09 |
mattoliver | yeah, just attempted to click on the output. | 21:09 |
timburke | anyway, that's all i had about the gate: if your patches keep failing, don't freak out just yet ;-) | 21:10 |
timburke | next up | 21:10 |
timburke | #topic sha1 deprecation | 21:10 |
mattoliver | cschwede-: has +2'ed the first in the chain | 21:11 |
timburke | we've got a bunch of patches we ought to land! ade_lee even managed to get cschwede to do some reviews, so it *must* be important ;-) | 21:11 |
mattoliver | lol | 21:11 |
ade_lee | and you got me to join this meeting too :) | 21:12 |
timburke | it's like whoa | 21:12 |
ade_lee | so yeah - pretty please, this is the patch thats holding up a bunch of fips jobs across projects | 21:12 |
ade_lee | (patches) | 21:12 |
timburke | do we know what the status is on the tempest dependency? https://review.opendev.org/c/openstack/tempest/+/832771 | 21:13 |
mattoliver | 525771 also has a +2 in the second last patchset from pete.. so maybe we just land | 21:13 |
ade_lee | huh - I actually didn't realize we had a tempest dependency .. | 21:14 |
timburke | the tempurl remove-sha1-from-defaults can't pass with tempest master | 21:15 |
ade_lee | so -- we need to fix a few tests .. | 21:15 |
ade_lee | or a few more tests .. | 21:15 |
ade_lee | although I guess that things pass right now with the tests that were fixed? | 21:16 |
ade_lee | timburke, I haven't been following closely - but is there an issue in fixing the formpost tests? | 21:17 |
timburke | in tempest? yeah, we've got a bit of a chicken-and-egg problem since swift currently *only* supports sha1 for formpost. can't move tempest to using sha256 for those until swift actually supports it | 21:19 |
ade_lee | but mattoliver subsequent patch adds support for sha256 , right? | 21:19 |
ade_lee | https://review.opendev.org/c/openstack/swift/+/838434 | 21:20 |
timburke | yup. and sha1 is still an allowed-by-default digest, which is as it should be | 21:20 |
timburke | there could absolutely be another patch written against tempest to switch the formpost tests to sha256. can't be part of https://review.opendev.org/c/openstack/tempest/+/832771, though, since it'll depend on mattoliver's patch, which eventually depends on 832771 | 21:22 |
ade_lee | timburke, ok -- so if I understand this -- to get the tempest patch in -- all we need to do is fix test_object_temp_url_negative.py as well. | 21:22 |
ade_lee | and yeah we defer the formpost stuff | 21:22 |
ade_lee | to a different patch | 21:23 |
timburke | i think so? seems right to me. unfortunately, i don't think i have much leverage on getting tempest code merged, though | 21:23 |
ade_lee | then we need a second patch which fixes the tempest tests for formpost , which depends on mattoliver formpost patch? | 21:23 |
ade_lee | ack - I can talk to martin | 21:24 |
ade_lee | I just didn't realize there was still a tempest issue | 21:24 |
timburke | cool, thanks! and i'll work on getting my gate fixed and patches +A'ed | 21:24 |
timburke | #topic ring v2 | 21:25 |
ade_lee | timburke, for the formpost patches, presumably those can be merged without changes to tempest | 21:25 |
timburke | #undo | 21:25 |
opendevmeet | Removing item from minutes: #topic ring v2 | 21:25 |
ade_lee | and then we can do the tempest change to actually make sure its tested .. | 21:26 |
timburke | ade_lee, well, except they depend on the tempurl patch (at least, as things currently stand) | 21:26 |
ade_lee | well yeah - we're asuming that goes in | 21:26 |
ade_lee | assuming | 21:26 |
ade_lee | for the formtest changes -- I see there is something about optionally specifying the digest | 21:27 |
timburke | and that going in is dependent upon the tempest change to tempurl tests going in | 21:27 |
ade_lee | does that mean that when we set up the tempest tests for formpost + sha256, we'll have to add some config? | 21:28 |
timburke | don't think so, but i haven't looked closely at mattoliver's patch since it got broken up. it's on my list for this week | 21:28 |
timburke | should be able to just swap sha1 to sha256, similar to the tempurl tempest patch | 21:29 |
mattoliver | if you use sha256 it'll detect that | 21:29 |
mattoliver | no extra config | 21:29 |
ade_lee | cool - so plan is -- I'll fix up that addtional test, and talk to martin about merging tempest patch without formpost changes | 21:30 |
timburke | the follow-up should just give clients an option for another way to spell it | 21:30 |
ade_lee | then we can merge all the swift patches | 21:30 |
ade_lee | and then we can add extra patch to tempest to switch formpost tests | 21:30 |
timburke | yup! sounds right to me | 21:30 |
mattoliver | +1 | 21:30 |
ade_lee | cool thanks! | 21:30 |
timburke | #topic ring v2 | 21:31 |
timburke | sorry, mattoliver, i still haven't gotten to following up on your review :-( | 21:32 |
mattoliver | nps, i mean it'll be good to get too, but you are saving our gate bacon :P | 21:32 |
mattoliver | I tried to address most the todos in the follow up. | 21:33 |
timburke | thanks for that -- though i think there's one part i won't be taking as-is | 21:33 |
timburke | (around unrecognized digest algos) | 21:33 |
timburke | let's see... the memcache patches are mostly resolved now... | 21:34 |
timburke | #topic eventlet, logging, and locking | 21:35 |
timburke | mattoliver, am i remembering right that you were going to try this out in our staging environment? | 21:35 |
timburke | i *know* we still haven't tried it out in prod yet | 21:35 |
mattoliver | I was suppose to. But onboarding new devs got in the way. I know I said it last week, but I'll try generating a load and giving it whirl this week. | 21:36 |
mattoliver | Seems we have Als backend ratelimint in there 2. | 21:37 |
timburke | sounds good -- just wanted to make sure i wasn't the one who'd committed to it ;-) | 21:37 |
mattoliver | so load generation we might be able to do 2 birds one stone | 21:37 |
timburke | yup! | 21:37 |
mattoliver | lol | 21:37 |
timburke | #topic backend ratelimiting | 21:38 |
timburke | we're up to 2 +2s on https://review.opendev.org/c/openstack/swift/+/836046/ ! should we wait on the results of your testing before merging? | 21:38 |
timburke | or should i just blindly +A once we've got the gate passing again? ;-) | 21:39 |
mattoliver | good question, in theory it can be turned off. But maybe work on the gate and hopefully by then we'll have some staging results | 21:40 |
timburke | sounds good | 21:40 |
timburke | #topic ptg | 21:41 |
timburke | i almost forgot! they've set the dates for the next (in person!) PTG | 21:41 |
timburke | #link http://lists.openstack.org/pipermail/openstack-discuss/2022-May/028601.html | 21:41 |
mattoliver | \o/ | 21:42 |
timburke | October 17-20th, in Columbus, Ohio | 21:42 |
mattoliver | It'll be so awesome to meet up face to face with everyone again! | 21:43 |
timburke | for sure | 21:43 |
timburke | i can hardly wait | 21:43 |
mattoliver | I should confirm work will send me, then get my esta organised so I can enter the US :P | 21:43 |
timburke | that's all i've got | 21:43 |
mattoliver | got a few months :P | 21:43 |
timburke | #topic open discussion | 21:43 |
timburke | anything else we should bring up this week? | 21:43 |
mattoliver | Been playing with the next steps for not moving to Cleaved until we're ready. Hopefully have something up to review today or tomorrow | 21:45 |
timburke | nice! | 21:45 |
mattoliver | code just doesn't look right yet. OCD :P | 21:45 |
timburke | oh yeah, and i should go re-review https://review.opendev.org/c/openstack/swift/+/841143 | 21:46 |
mattoliver | yeah, then we can land it | 21:46 |
mattoliver | it's better then what we have now. And saved our bacon in prod. | 21:46 |
mattoliver | so think it's a win | 21:46 |
timburke | 👍 | 21:47 |
timburke | all right, i'll let you get on with your morning, then | 21:47 |
timburke | thanks for coming, and thanks for working on swift! | 21:47 |
timburke | #endmeeting | 21:47 |
opendevmeet | Meeting ended Wed May 25 21:47:35 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:47 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/swift/2022/swift.2022-05-25-21.00.html | 21:47 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/swift/2022/swift.2022-05-25-21.00.txt | 21:47 |
opendevmeet | Log: https://meetings.opendev.org/meetings/swift/2022/swift.2022-05-25-21.00.log.html | 21:47 |
opendevreview | Merged openstack/swift master: CI: constrain py36 deps https://review.opendev.org/c/openstack/swift/+/842817 | 23:29 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!