*** gyee has quit IRC | 00:46 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Give ECAppIter greenthreads a chance to wrap up https://review.opendev.org/665773 | 00:58 |
---|---|---|
*** baojg has joined #openstack-swift | 01:13 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Give ECAppIter greenthreads a chance to wrap up https://review.opendev.org/665773 | 01:48 |
*** threestrands has joined #openstack-swift | 02:43 | |
*** redrobot has quit IRC | 03:32 | |
*** psachin has joined #openstack-swift | 03:36 | |
*** Guest99405 has joined #openstack-swift | 03:39 | |
*** ccamacho has quit IRC | 05:33 | |
*** pcaruana has joined #openstack-swift | 05:44 | |
*** rcernin has quit IRC | 06:44 | |
*** threestrands has quit IRC | 07:24 | |
*** ccamacho has joined #openstack-swift | 07:36 | |
*** early has quit IRC | 08:26 | |
*** early has joined #openstack-swift | 08:29 | |
*** new_student1411 has joined #openstack-swift | 08:37 | |
*** tkajinam has quit IRC | 08:40 | |
*** zaitcev__ has joined #openstack-swift | 09:25 | |
*** ChanServ sets mode: +v zaitcev__ | 09:25 | |
*** tdasilva_ has quit IRC | 09:25 | |
*** tdasilva_ has joined #openstack-swift | 09:26 | |
*** ChanServ sets mode: +v tdasilva_ | 09:26 | |
*** zaitcev_ has quit IRC | 09:28 | |
*** tdasilva_ has quit IRC | 09:47 | |
*** tdasilva_ has joined #openstack-swift | 09:47 | |
*** ChanServ sets mode: +v tdasilva_ | 09:47 | |
*** thiago__ has joined #openstack-swift | 10:15 | |
*** ChanServ sets mode: +v thiago__ | 10:15 | |
*** tdasilva_ has quit IRC | 10:17 | |
*** new_student1411 has quit IRC | 10:23 | |
*** new_student1411 has joined #openstack-swift | 10:23 | |
*** takamatsu has joined #openstack-swift | 10:37 | |
*** tesseract has joined #openstack-swift | 11:38 | |
*** new_student1411 has quit IRC | 11:49 | |
*** thiago__ has quit IRC | 12:26 | |
*** thiago__ has joined #openstack-swift | 12:27 | |
*** ChanServ sets mode: +v thiago__ | 12:27 | |
*** zaitcev__ has quit IRC | 12:27 | |
*** thiago__ has quit IRC | 12:33 | |
*** thiago__ has joined #openstack-swift | 12:33 | |
*** ChanServ sets mode: +v thiago__ | 12:33 | |
*** tdasilva_ has joined #openstack-swift | 12:35 | |
*** ChanServ sets mode: +v tdasilva_ | 12:35 | |
*** thiago__ has quit IRC | 12:38 | |
*** zaitcev__ has joined #openstack-swift | 12:39 | |
*** ChanServ sets mode: +v zaitcev__ | 12:39 | |
*** new_student1411 has joined #openstack-swift | 12:47 | |
*** mvkr_ has quit IRC | 12:56 | |
*** Guest99405 is now known as redrobot | 13:13 | |
*** hoonetorg has quit IRC | 13:28 | |
*** tdasilva_ has quit IRC | 13:41 | |
*** tdasilva_ has joined #openstack-swift | 13:42 | |
*** ChanServ sets mode: +v tdasilva_ | 13:42 | |
*** tomha has joined #openstack-swift | 14:00 | |
*** tomha has quit IRC | 14:01 | |
*** tdasilva_ has quit IRC | 14:09 | |
*** tdasilva_ has joined #openstack-swift | 14:09 | |
*** ChanServ sets mode: +v tdasilva_ | 14:09 | |
*** tdasilva_ is now known as tdasilva | 14:15 | |
*** ccamacho has quit IRC | 14:15 | |
*** ccamacho has joined #openstack-swift | 14:20 | |
*** tdasilva has quit IRC | 15:05 | |
*** tdasilva has joined #openstack-swift | 15:05 | |
*** ChanServ sets mode: +v tdasilva | 15:05 | |
*** hoonetorg has joined #openstack-swift | 15:26 | |
*** tdasilva_ has joined #openstack-swift | 15:26 | |
*** ChanServ sets mode: +v tdasilva_ | 15:26 | |
*** tdasilva has quit IRC | 15:28 | |
*** zaitcev__ is now known as zaitcev | 15:41 | |
*** gyee has joined #openstack-swift | 16:27 | |
*** zaitcev has quit IRC | 16:36 | |
*** ccamacho has quit IRC | 16:37 | |
*** zaitcev has joined #openstack-swift | 16:53 | |
*** ChanServ sets mode: +v zaitcev | 16:53 | |
clayg | tdasilva_: yeah I think the fact that you can update the content-type of a hardlink-target but the hardlink (and container listing) don't get updated isn't great | 17:29 |
tdasilva_ | clayg: yeah, but if we want to provide the functionality, i'm not sure how to get around it...fwiw, it's only the container listing that doesn't get updated | 17:30 |
clayg | tdasilva_: give that the client probably just wants to change the content-type it might be useful to know that you can post to a symlink/hardlink to change it's content-type and update the container listing (even thought we return 307) | 17:30 |
clayg | tdasilva_: well symlink=get will still show the old content-type too | 17:30 |
clayg | given that the lifecycle of the link's content-type is compleatly decoupled from the target maybe there's a better affordance in the API - it's difficult to make it transparent because the lifecycle of the targets ctype is decouopled from the etag | 17:32 |
tdasilva_ | right! | 17:35 |
clayg | I think the truth is just that hardlinks are tied to the .data (etag & size) and the content-type stuff is just convience | 17:37 |
tdasilva_ | yeah, so might be worth getting rid of content-type?? | 17:39 |
clayg | a few ideas might make that more clear 1) only set content-type on the hardlink if the client doesn't explicitly set it 2) simiarlly set application/symlink on soft links if the client doesn't set it 3) try to document that you can update content-type of symlinks in the container listing using a POST despite the 307 response (!?) | 17:39 |
clayg | i'm not really sure any of those are good ideas mind you 😁 | 17:40 |
tdasilva_ | i'm not sure they help solve the issue...for the content-type of the symlink itself, why not enforce that it must always be application/symlink | 17:45 |
tdasilva_ | ? | 17:45 |
*** tdasilva_ is now known as tdasilva | 17:45 | |
*** hogepodge has quit IRC | 17:45 | |
*** clayg has quit IRC | 17:45 | |
*** hogepodge has joined #openstack-swift | 17:47 | |
*** clayg has joined #openstack-swift | 17:48 | |
*** ChanServ sets mode: +v clayg | 17:48 | |
timburke | clayg, i think i like all of those ideas -- seems to put more power in the client's hands, which is generally a good thing | 17:53 |
timburke | tdasilva, we *could* enforce a content-type for symlinks at PUT time... but we we'd have to write down whatever the client sent us at POST. in light of that, idk that there's good reason to impose requirements at PUT time | 17:55 |
clayg | how on earth does the object server understand how to 412 an if-match correctly on SLOs and respect multipart-manifest=get | 17:55 |
timburke | slo ignores the 412 ;-) https://github.com/openstack/swift/blob/2.21.0/swift/common/middleware/slo.py#L704-L711 | 17:56 |
timburke | of, but there's more to it than that! i'd kinda forgotten about https://github.com/openstack/swift/commit/2d25fe6 ... | 17:59 |
tdasilva | timburke: good poing on not being able to enforce on POST :/ | 18:01 |
clayg | timburke: yeah so but that change didn't add any new code to the object-server - the existing `resolve_etag_is_at_header` machineary must have somehow been sufficient | 18:03 |
timburke | yup; that all came in with encryption | 18:03 |
clayg | does SLO somehow add some x-backend header to ... every GET/HEAD like "just in case" | 18:03 |
timburke | yup | 18:03 |
*** psachin has quit IRC | 18:04 | |
timburke | it's the call to update_etag_is_at_header | 18:04 |
timburke | ...which we skip on ?multipart-manifest=get | 18:04 |
clayg | right, right, ok... ok... so 🤔 | 18:05 |
timburke | actually... i wonder if that machinery first came in with EC... | 18:05 |
*** irclogbot_3 has quit IRC | 18:07 | |
*** altlogbot_1 has quit IRC | 18:07 | |
timburke | looks like x-backend-etag-is-at came in with https://github.com/openstack/swift/commit/b1eda4a | 18:08 |
timburke | and it was refactored to take a list of headers in https://github.com/openstack/swift/commit/03b762e | 18:08 |
*** irclogbot_0 has joined #openstack-swift | 18:09 | |
*** altlogbot_1 has joined #openstack-swift | 18:09 | |
* clayg timburke: so, this works: | 18:25 | |
clayg | final_etag = resolve_etag_is_at_header( | 18:25 |
clayg | req, HeaderKeyDict(self._response_headers)) | 18:25 |
clayg | but i still to have to figureout how to normalize the quoting :\ | 18:26 |
clayg | also, i guess SLO doesn't set the x-backend header on PUT | 18:30 |
timburke | no -- since the only if-match-y semantic PUT supports is `If-None-Match: *` | 18:33 |
openstackgerrit | Thiago da Silva proposed openstack/swift master: Add rolling upgrade tests https://review.opendev.org/626663 | 18:35 |
*** dsariel has joined #openstack-swift | 18:41 | |
*** dsariel has quit IRC | 18:43 | |
clayg | timburke: so is the coupling less bad if slo sets it on PUT so that symlinks can validate the client provided etag? | 18:43 |
clayg | there's a similar problem in versoined writes where it has to notice the object in the listing it's creating a hardlink too (like on a stack DELETE) has a slo_etag and it uses that instead | 18:44 |
clayg | we could side step most of this by requiring hardlink clients to use the etag of the manifest 🤷♂️ | 18:44 |
timburke | clayg, yeah, i'm kinda coming around to that... largely because we want symlink so far to the right in the pipeline | 18:46 |
timburke | it's kinda annoying from a client perspective... but at the same time, it's not like it's *that* hard to get the value you need | 18:47 |
clayg | a hardlink *is* pretty low-level - i just hate that SLO's manifest etag is really hard to predict - you kinda just have to look it up! | 18:47 |
timburke | yup :-( | 18:48 |
*** dsariel__ has joined #openstack-swift | 18:48 | |
timburke | two proxy servers may well write down different bytes-on-disk for the same SLO | 18:48 |
timburke | it's not like we include sort_keys or anything in slo... | 18:49 |
*** new_student1411 has quit IRC | 19:05 | |
openstackgerrit | Ghanshyam Mann proposed openstack/swift master: Add integrated gate tempest and grenade job https://review.opendev.org/671554 | 19:16 |
openstackgerrit | Ghanshyam Mann proposed openstack/swift master: Add integrated gate tempest and grenade job https://review.opendev.org/671554 | 19:17 |
timburke | oh, cool: swiftclient isn't *completely* useless in trying to make symlinks: swift upload c - < /dev/null --object-name link -H 'x-symlink-target: c/o' | 19:23 |
timburke | not exactly pretty, but it seems to work | 19:24 |
*** e0ne has joined #openstack-swift | 19:38 | |
*** pcaruana has quit IRC | 20:01 | |
*** tesseract has quit IRC | 20:05 | |
*** mvkr_ has joined #openstack-swift | 20:05 | |
*** tomha has joined #openstack-swift | 20:08 | |
*** tomha has quit IRC | 20:09 | |
*** dsariel__ has quit IRC | 20:10 | |
clayg | that's awesome that you can stuff the `- < /dev/null` in the middle of the command option slike that 🤯 | 20:11 |
openstackgerrit | Tim Burke proposed openstack/swift master: py3: Bring functional/test_object.py under test; add func-ec-py37 job https://review.opendev.org/645895 | 21:05 |
clayg | anyone know anything about dsvm-functional and account.name vs AUTH_swiftprojecttest1? | 21:05 |
timburke | clayg, i know a bit about that sort of thing... | 21:05 |
timburke | what are you seeing? | 21:05 |
clayg | AUTH_59b53071a4fd469cb3e4586bb1303a2c != AUTH_swiftprojecttest1 in places where the func tests are building the path from self.account.name | 21:06 |
clayg | http://logs.openstack.org/57/633857/4/check/swift-dsvm-functional/50c6b7e/job-output.txt.gz | 21:06 |
clayg | all three dsvm func jobs on the change failed | 21:06 |
clayg | iniset /etc/swift/test.conf func_test account swiftprojecttest1 | 21:10 |
clayg | seems legit | 21:10 |
timburke | those new tests seem to be the only ones that ever look at self.account.name... i think it's going to be the project name rather than the project id, which is what keystone's going to be shoving into the storage url | 21:12 |
clayg | oh bummer | 21:12 |
clayg | symlink tests doing tf.parsed[0].path.split('/', 2)[2] | 21:14 |
timburke | https://github.com/openstack/swift/blob/master/test/functional/test_container.py#L1633-L1638 might be useful? | 21:15 |
timburke | oh, yeah -- you already found parsed.path | 21:15 |
*** e0ne has quit IRC | 21:17 | |
openstackgerrit | Clay Gerrard proposed openstack/swift master: symlink-backed versioned_writes https://review.opendev.org/633857 | 21:37 |
*** tkajinam has joined #openstack-swift | 22:58 | |
*** rcernin has joined #openstack-swift | 23:15 | |
*** tdasilva has quit IRC | 23:19 | |
zigo | timburke: Did you try with a very recent kernel, maybe? | 23:30 |
zigo | (re: the ERANGE thing...) | 23:31 |
openstackgerrit | Thomas Goirand proposed openstack/swift master: Fix test_parse_get_node_args https://review.opendev.org/670894 | 23:33 |
zigo | This one should pass the pep8 tests. | 23:33 |
* zigo waves from Debconf in Curitiba, Brazil. :) | 23:33 | |
mattoliverau | morning | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!