*** chsc has quit IRC | 00:00 | |
notmyname | at a high level, it sounds reasonable | 00:00 |
---|---|---|
notmyname | I'd definitely leave it to you to submit whichever way is easier to digest | 00:01 |
openstackgerrit | Samuel Merritt proposed openstack/swift master: Add checksum to object extended attributes https://review.openstack.org/336323 | 00:15 |
openstackgerrit | Samuel Merritt proposed openstack/swift master: Add metadata checksums to old objects in auditor. https://review.openstack.org/513569 | 00:15 |
torgomatic | notmyname: well, there you go | 00:15 |
*** ukaynar has quit IRC | 01:03 | |
*** ukaynar has joined #openstack-swift | 01:08 | |
*** gyee has quit IRC | 01:09 | |
*** tovin07_ has joined #openstack-swift | 01:28 | |
kota_ | good morning | 01:29 |
*** vint_bra has joined #openstack-swift | 01:39 | |
mattoliverau | kota_: morning | 01:40 |
kota_ | mattoliverau: hi | 01:40 |
kota_ | notmyname: thx for notification for the typhoon. Unfortunately, that day is the voting day for Japanese government so probably i should go out... | 01:42 |
*** SkyRocknRoll has joined #openstack-swift | 01:45 | |
openstackgerrit | Merged openstack/swift master: Stop logging tracebacks on bad xLOs https://review.openstack.org/496493 | 01:46 |
openstackgerrit | Merged openstack/swift-bench master: Remove discover from test-requirements https://review.openstack.org/345252 | 01:54 |
kota_ | oh nice, swift priority reviews wiki has been better format. nice work notmyname. | 01:55 |
*** SkyRocknRoll has quit IRC | 01:56 | |
notmyname | kota_: thanks | 01:56 |
*** SkyRocknRoll has joined #openstack-swift | 02:08 | |
*** ukaynar has quit IRC | 02:25 | |
*** klrmn has quit IRC | 02:29 | |
*** psachin has joined #openstack-swift | 02:31 | |
*** chsc has joined #openstack-swift | 02:51 | |
*** chsc has joined #openstack-swift | 02:51 | |
*** two_tired has joined #openstack-swift | 03:03 | |
*** chsc has quit IRC | 03:13 | |
*** gkadam-away has joined #openstack-swift | 03:15 | |
*** gkadam-away is now known as gkadam | 03:19 | |
*** wes_dillingham has quit IRC | 03:23 | |
*** SkyRocknRoll_ has joined #openstack-swift | 03:27 | |
*** vint_bra has quit IRC | 03:27 | |
*** SkyRocknRoll has quit IRC | 03:29 | |
*** two_tired has quit IRC | 03:33 | |
*** chsc has joined #openstack-swift | 04:18 | |
*** chsc has joined #openstack-swift | 04:18 | |
*** chsc has quit IRC | 04:36 | |
*** SkyRocknRoll_ has quit IRC | 04:38 | |
*** ianychoi_ has joined #openstack-swift | 04:48 | |
*** ianychoi has quit IRC | 04:50 | |
openstackgerrit | Kota Tsuyuzaki proposed openstack/swift feature/s3api: Continue merge swift3 middleware https://review.openstack.org/513170 | 04:52 |
kota_ | tdasilva: that is the solution to resolve dsvm gate problem i suppose | 04:53 |
*** ianychoi__ has joined #openstack-swift | 04:54 | |
*** ianychoi_ has quit IRC | 04:56 | |
*** ianychoi has joined #openstack-swift | 05:07 | |
*** ianychoi__ has quit IRC | 05:10 | |
*** newmember has joined #openstack-swift | 05:16 | |
*** spectr has joined #openstack-swift | 05:54 | |
*** vinsh has quit IRC | 06:13 | |
*** dja_ has joined #openstack-swift | 06:16 | |
*** dja_ has quit IRC | 06:20 | |
*** dja has quit IRC | 06:21 | |
*** dja has joined #openstack-swift | 06:21 | |
*** psachin has quit IRC | 06:33 | |
*** hseipp has joined #openstack-swift | 06:39 | |
*** tesseract has joined #openstack-swift | 07:03 | |
*** geaaru has joined #openstack-swift | 07:06 | |
kota_ | yey, that change resolved gate issue! | 07:07 |
*** SkyRocknRoll has joined #openstack-swift | 07:07 | |
*** silor has joined #openstack-swift | 07:22 | |
*** kallenp has joined #openstack-swift | 07:23 | |
*** cbartz has joined #openstack-swift | 07:32 | |
*** kallenp has quit IRC | 07:35 | |
*** mabrams has joined #openstack-swift | 07:35 | |
*** SkyRocknRoll has quit IRC | 07:44 | |
*** silor1 has joined #openstack-swift | 07:46 | |
*** silor has quit IRC | 07:49 | |
*** silor1 is now known as silor | 07:49 | |
*** SkyRocknRoll has joined #openstack-swift | 07:57 | |
openstackgerrit | Merged openstack/swift feature/s3api: Continue merge swift3 middleware https://review.openstack.org/513170 | 08:09 |
acoles | good morning | 08:16 |
*** silor has quit IRC | 08:22 | |
*** newmember has quit IRC | 08:23 | |
*** newmember has joined #openstack-swift | 08:23 | |
*** SkyRocknRoll has quit IRC | 08:32 | |
*** newmember has quit IRC | 08:45 | |
*** newmember has joined #openstack-swift | 08:45 | |
openstackgerrit | Alistair Coles proposed openstack/swift feature/deep: Delete orphaned shard containers https://review.openstack.org/513468 | 08:54 |
*** jamielennox has quit IRC | 08:57 | |
*** jamielennox has joined #openstack-swift | 09:02 | |
*** Tengu has joined #openstack-swift | 09:07 | |
Tengu | hello there! | 09:07 |
*** rcernin has joined #openstack-swift | 09:12 | |
*** newmember has quit IRC | 09:40 | |
*** newmember has joined #openstack-swift | 09:41 | |
*** pcaruana has joined #openstack-swift | 09:46 | |
*** Tengu has left #openstack-swift | 09:57 | |
*** itlinux has joined #openstack-swift | 09:58 | |
*** kallenp has joined #openstack-swift | 09:58 | |
*** kallenp has quit IRC | 10:03 | |
*** tovin07_ has quit IRC | 10:06 | |
*** tovin07 has quit IRC | 10:07 | |
*** kallenp has joined #openstack-swift | 10:14 | |
*** kallenp has quit IRC | 10:19 | |
*** itlinux has quit IRC | 10:47 | |
*** newmember has quit IRC | 10:50 | |
*** newmember has joined #openstack-swift | 10:51 | |
*** tone_zrt has quit IRC | 11:07 | |
*** mabrams has quit IRC | 11:49 | |
*** kallenp has joined #openstack-swift | 11:57 | |
*** gkadam has quit IRC | 12:00 | |
*** kallenp has quit IRC | 12:03 | |
*** kallenp has joined #openstack-swift | 12:08 | |
*** kallenp has quit IRC | 12:09 | |
tdasilva | kota_: nice! I couldn't figure out the issue from the logs | 12:18 |
*** rcernin has quit IRC | 12:20 | |
*** NM has joined #openstack-swift | 12:27 | |
*** pcaruana has quit IRC | 12:31 | |
*** mat128 has joined #openstack-swift | 12:39 | |
*** mwheckmann has joined #openstack-swift | 12:44 | |
*** kallenp has joined #openstack-swift | 12:50 | |
openstackgerrit | Thiago da Silva proposed openstack/swift feature/s3api: Sync s3api feature branch with master https://review.openstack.org/513730 | 12:54 |
tdasilva | lol | 12:54 |
tdasilva | acoles, kota_: ^^^ that was my first attempt at merging master into feature branch and I completely failed... | 12:55 |
tdasilva | looking | 12:55 |
acoles | tdasilva: how did it fail? | 12:56 |
*** kallenp has quit IRC | 12:56 | |
tdasilva | acoles: i see no changes in gerrit | 12:56 |
tdasilva | acoles: am i mistaken? | 12:56 |
acoles | tdasilva: hmmm, did you need to fix any merge conflicts? if not I'm not sure you see any changes | 12:57 |
tdasilva | acoles: no, there were no merge conflicts | 12:58 |
acoles | tdasilva: cf. https://review.openstack.org/#/c/511941/ | 12:58 |
patchbot | patch 511941 - swift (feature/deep) - Merge branch 'master' into feature/deep (MERGED) | 12:58 |
tdasilva | i guess i was expecting to see whatever changes went into master that were not in feature branch | 12:58 |
tdasilva | ah interesting | 12:58 |
acoles | tdasilva: the two parents look like HEAD of master and presumably HEAD of the feature branch | 12:59 |
* tdasilva nods | 13:00 | |
tdasilva | acoles: approved | 13:01 |
acoles | tdasilva: one of the easier reviews you get to do :) | 13:02 |
tdasilva | lol, yep | 13:02 |
tdasilva | hopefully won't require 1k 'rechecks' | 13:02 |
*** spectr has quit IRC | 13:03 | |
*** wes_dillingham has joined #openstack-swift | 13:04 | |
*** spectr has joined #openstack-swift | 13:19 | |
*** lifeless has quit IRC | 13:28 | |
*** lifeless has joined #openstack-swift | 13:29 | |
*** vint_bra has joined #openstack-swift | 13:39 | |
*** d0ugal_ has joined #openstack-swift | 13:59 | |
*** d0ugal has quit IRC | 13:59 | |
*** thurloat has quit IRC | 13:59 | |
*** thurloat has joined #openstack-swift | 14:00 | |
*** d0ugal_ has quit IRC | 14:01 | |
*** d0ugal has joined #openstack-swift | 14:01 | |
*** d0ugal has joined #openstack-swift | 14:01 | |
*** spectr has quit IRC | 14:06 | |
*** spectr has joined #openstack-swift | 14:18 | |
*** spectr has quit IRC | 14:42 | |
*** chsc has joined #openstack-swift | 15:01 | |
*** chsc has joined #openstack-swift | 15:01 | |
notmyname | good morning | 15:06 |
*** klrmn has joined #openstack-swift | 15:11 | |
*** kallenp has joined #openstack-swift | 15:12 | |
notmyname | tdasilva: you need any help with merging master into a feature branch? | 15:13 |
*** kallenp has quit IRC | 15:13 | |
tdasilva | notmyname: good morning | 15:16 |
notmyname | FYI big changes coming in pip. I wouldn't be surprised if somewhere somehow we're impacted in the gate. probably good to check your internal build pipelines too http://lists.openstack.org/pipermail/openstack-dev/2017-October/123817.html | 15:16 |
tdasilva | notmyname: i think i got it...should be merging soon, we'll see. p 513730 | 15:16 |
patchbot | https://review.openstack.org/#/c/513730/ - swift (feature/s3api) - Sync s3api feature branch with master | 15:16 |
notmyname | tdasilva: yeah, from gerrit that seems right. | 15:21 |
tdasilva | notmyname: cool, last sync was from a week ago, so I thought it would be a good exercise to do one today, plus pick up whatever changes went in this week | 15:22 |
notmyname | sounds good | 15:22 |
notmyname | locally checkout a branch off of master, switch to the feature branch, `git merge master`, `git amend` to fix the commit message and get a change-id, `git review -R` | 15:23 |
notmyname | (off the top of my head) | 15:23 |
*** ukaynar has joined #openstack-swift | 15:23 | |
notmyname | `git config --global --list` --> 'alias.amend=commit --amend' # best alias I've ever made | 15:24 |
acoles | notmyname: I have a bash alias 'amend' | 15:25 |
notmyname | that one time I did `git commit -amend` and end up with adding everything to a new commit with the commit message "end" was really annoying. that's when I created the alias :-) | 15:27 |
acoles | ouch | 15:27 |
timburke | that's why i just get as far as `git --am<tab>` | 15:28 |
timburke | only drawback is i don't know how to spell ammend ;-) | 15:28 |
tdasilva | lol | 15:28 |
* notmyname laughs familiarly | 15:28 | |
notmyname | familliarilly | 15:28 |
timburke | familially? :P | 15:29 |
acoles | now you all got me chanting amo, amas, amat... | 15:32 |
*** NM has quit IRC | 15:45 | |
*** cbartz has quit IRC | 15:47 | |
*** NM has joined #openstack-swift | 15:48 | |
*** newmember has quit IRC | 15:55 | |
*** gyee has joined #openstack-swift | 15:56 | |
openstackgerrit | Merged openstack/swift feature/s3api: Sync s3api feature branch with master https://review.openstack.org/513730 | 16:01 |
openstackgerrit | Alistair Coles proposed openstack/swift feature/deep: sharder needs rsync module conf option https://review.openstack.org/513788 | 16:08 |
openstackgerrit | Alistair Coles proposed openstack/swift feature/deep: sharder needs rsync module conf option https://review.openstack.org/513788 | 16:09 |
*** chsc has quit IRC | 16:17 | |
*** tesseract has quit IRC | 16:17 | |
*** gkadam has joined #openstack-swift | 16:17 | |
*** klrmn has quit IRC | 16:18 | |
*** silor has joined #openstack-swift | 16:18 | |
*** hseipp has quit IRC | 16:26 | |
*** gkadam has quit IRC | 17:05 | |
*** klrmn has joined #openstack-swift | 17:10 | |
*** ukaynar has quit IRC | 17:12 | |
*** NM has quit IRC | 17:24 | |
*** NM has joined #openstack-swift | 17:27 | |
*** klrmn has quit IRC | 17:39 | |
*** klrmn has joined #openstack-swift | 17:41 | |
*** ukaynar has joined #openstack-swift | 17:48 | |
openstackgerrit | Alistair Coles proposed openstack/swift feature/deep: Root driven shrinking https://review.openstack.org/510978 | 17:56 |
*** ukaynar has quit IRC | 18:18 | |
*** ukaynar has joined #openstack-swift | 18:31 | |
*** ukaynar has quit IRC | 18:33 | |
*** ukaynar has joined #openstack-swift | 18:33 | |
*** ukaynar_ has joined #openstack-swift | 18:35 | |
*** ukaynar has quit IRC | 18:35 | |
openstackgerrit | Samuel Merritt proposed openstack/swift master: Add checksum to object extended attributes https://review.openstack.org/336323 | 18:36 |
openstackgerrit | Samuel Merritt proposed openstack/swift master: Add metadata checksums to old objects in auditor. https://review.openstack.org/513569 | 18:36 |
*** chinkara has joined #openstack-swift | 18:36 | |
*** chinkara has quit IRC | 18:37 | |
*** chinkara has joined #openstack-swift | 18:53 | |
*** chinkara has quit IRC | 18:53 | |
*** ChubYann has quit IRC | 18:57 | |
*** ChubYann has joined #openstack-swift | 19:00 | |
*** chsc has joined #openstack-swift | 19:01 | |
*** chsc has joined #openstack-swift | 19:01 | |
*** silor has quit IRC | 19:14 | |
*** ukaynar_ has quit IRC | 19:57 | |
*** DuncanT has quit IRC | 20:07 | |
*** DuncanT has joined #openstack-swift | 20:07 | |
*** itlinux has joined #openstack-swift | 20:19 | |
*** wes_dillingham has quit IRC | 20:29 | |
*** NM has quit IRC | 20:35 | |
*** itlinux has quit IRC | 20:47 | |
*** ukaynar has joined #openstack-swift | 21:06 | |
*** mat128 has quit IRC | 21:27 | |
openstackgerrit | Samuel Merritt proposed openstack/swift master: Clean up memcache tests https://review.openstack.org/513858 | 21:49 |
*** geaaru has quit IRC | 21:57 | |
*** vint_bra has quit IRC | 22:12 | |
*** geaaru has joined #openstack-swift | 22:15 | |
timburke | torgomatic: i was thinking about just logging a warning (error?) down in read_metadata but otherwise continuing with everything as before | 22:17 |
torgomatic | timburke: one would probably have to plumb the exception up to someone with a logger | 22:17 |
torgomatic | but I guess that seems reasonable | 22:17 |
timburke | idk. i could go either way. i guess (attempting to) quarantine's fine | 22:18 |
torgomatic | no, you're right that it's not a great answer. | 22:20 |
torgomatic | let me try the exception plumbing and see how bad it is | 22:20 |
*** mwheckmann has quit IRC | 22:22 | |
timburke | i *does* make me wonder if we should try to get the replicator involved instead though... if we *did* somehow have an auditor that (1) could quarantine yet (2) couldn't write xattrs, we'd quarantine... then replication would push a new copy in... but if the other end hasn't put the checksum on, we'll probably just quarantine again... | 22:24 |
openstackgerrit | Samuel Merritt proposed openstack/swift master: Clean up a couple hand-rolled mocks. https://review.openstack.org/513870 | 22:31 |
timburke | another? i like it, but torgomatic, what are you doing that you're kicking over these rocks? | 22:34 |
timburke | usually that's *my* job ;-) | 22:35 |
torgomatic | timburke: I tried raising an exception from down in diskfile.read_metadata and that's not too bad, but the problem is that we want to log an error but still return the metadata | 23:28 |
torgomatic | I suppose I could pass a logger to read_metadata that it can use in case of error, but that feels gross | 23:29 |
torgomatic | and using "logging.error" will send the logs to some default place, not whatever's configured in your object server conf | 23:29 |
*** chsc has quit IRC | 23:51 | |
*** vint_bra has joined #openstack-swift | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!