| *** itlinux has quit IRC | 00:02 | |
| openstackgerrit | Timur Alperovich proposed openstack/python-swiftclient master: Turn stdin uploads into SLO above 10MB. https://review.openstack.org/478611 | 00:05 |
|---|---|---|
| openstackgerrit | Timur Alperovich proposed openstack/python-swiftclient master: Allow for uploads from standard input. https://review.openstack.org/475038 | 00:05 |
| openstackgerrit | Pete Zaitcev proposed openstack/swift master: PUT+POST and its development test https://review.openstack.org/427911 | 00:16 |
| *** vint_bra has joined #openstack-swift | 00:21 | |
| *** psachin has joined #openstack-swift | 00:36 | |
| *** kiennt has joined #openstack-swift | 00:42 | |
| *** kiennt has left #openstack-swift | 00:43 | |
| *** vint_bra has quit IRC | 00:51 | |
| *** itlinux has joined #openstack-swift | 00:53 | |
| *** itlinux has quit IRC | 00:58 | |
| *** klrmn has quit IRC | 01:05 | |
| *** tovin07_ has joined #openstack-swift | 01:05 | |
| *** Sukhdev has quit IRC | 01:06 | |
| *** jamielennox has quit IRC | 01:08 | |
| *** jamielennox has joined #openstack-swift | 01:15 | |
| *** two_tired has joined #openstack-swift | 01:24 | |
| *** cdelatte has quit IRC | 01:27 | |
| *** noxdafox has quit IRC | 01:28 | |
| *** JimCheung has quit IRC | 01:32 | |
| *** JimCheung has joined #openstack-swift | 01:33 | |
| *** noxdafox has joined #openstack-swift | 01:34 | |
| *** vint_bra has joined #openstack-swift | 01:34 | |
| *** JimCheung has quit IRC | 01:37 | |
| *** tonanhngo has joined #openstack-swift | 01:48 | |
| *** JimCheung has joined #openstack-swift | 02:02 | |
| *** JimCheung has quit IRC | 02:07 | |
| *** klrmn has joined #openstack-swift | 02:13 | |
| *** jamielennox has quit IRC | 02:17 | |
| *** jamielennox has joined #openstack-swift | 02:24 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-swiftclient master: Updated from global requirements https://review.openstack.org/89250 | 02:28 |
| *** vint_bra has quit IRC | 02:45 | |
| *** ukaynar has quit IRC | 02:52 | |
| *** ukaynar has joined #openstack-swift | 02:53 | |
| openstackgerrit | Merged openstack/python-swiftclient master: Allow for uploads from standard input. https://review.openstack.org/475038 | 03:16 |
| openstackgerrit | John Dickinson proposed openstack/python-swiftclient master: 3.4.0 authors/changelog update https://review.openstack.org/485859 | 03:21 |
| openstackgerrit | John Dickinson proposed openstack/python-swiftclient master: 3.4.0 authors/changelog update https://review.openstack.org/485859 | 03:23 |
| notmyname | I'm landing patch 485859 and will tag the release as soon as it makes its way through the gate | 03:23 |
| patchbot | https://review.openstack.org/#/c/485859/ - python-swiftclient - 3.4.0 authors/changelog update | 03:23 |
| *** gkadam has joined #openstack-swift | 03:30 | |
| *** psachin has quit IRC | 03:41 | |
| *** psachin has joined #openstack-swift | 03:58 | |
| *** klrmn has quit IRC | 04:01 | |
| *** hoonetorg has joined #openstack-swift | 04:26 | |
| *** itlinux has joined #openstack-swift | 04:29 | |
| *** gkadam is now known as gkadam-afk | 04:31 | |
| *** links has joined #openstack-swift | 04:33 | |
| *** tonanhngo has quit IRC | 04:44 | |
| *** gkadam-afk is now known as gkadm | 05:15 | |
| *** gkadm is now known as gkadam | 05:15 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-swiftclient master: Updated from global requirements https://review.openstack.org/89250 | 05:32 |
| *** two_tired has quit IRC | 05:47 | |
| *** ukaynar has quit IRC | 05:49 | |
| *** ukaynar has joined #openstack-swift | 05:50 | |
| *** skudlik has joined #openstack-swift | 05:54 | |
| *** ukaynar has quit IRC | 05:54 | |
| openstackgerrit | Merged openstack/python-swiftclient master: 3.4.0 authors/changelog update https://review.openstack.org/485859 | 06:09 |
| *** kiennt_ has joined #openstack-swift | 06:17 | |
| *** kiennt has joined #openstack-swift | 06:17 | |
| *** kiennt has quit IRC | 06:17 | |
| *** tonanhngo has joined #openstack-swift | 06:34 | |
| *** cschwede_ has joined #openstack-swift | 06:38 | |
| *** tonanhngo has quit IRC | 06:39 | |
| *** cshastri has joined #openstack-swift | 06:40 | |
| *** hseipp has joined #openstack-swift | 06:41 | |
| *** ChubYann has quit IRC | 06:41 | |
| *** xrb has joined #openstack-swift | 06:51 | |
| *** xrb has quit IRC | 07:00 | |
| *** rcernin has joined #openstack-swift | 07:13 | |
| rledisez | clayg: yeah, sorry, i was so tired I went sleeping (and no, even if i'm french, i'm not taking vacations this summer :p) | 07:25 |
| *** JimCheung has joined #openstack-swift | 07:31 | |
| *** JimCheung has quit IRC | 07:35 | |
| *** jaosorior has joined #openstack-swift | 07:52 | |
| *** oshritf has joined #openstack-swift | 07:54 | |
| *** tonanhngo has joined #openstack-swift | 08:15 | |
| *** tonanhngo has quit IRC | 08:19 | |
| acoles | clayg: my stats_interval was 20, interval was 10 | 08:20 |
| kota_ | oops, sorry i could not find time to review for priorities today. it was a busy day for some inflight meetings :( | 08:20 |
| acoles | kota_: o/ | 08:20 |
| kota_ | acoles: o/ | 08:20 |
| *** geaaru has joined #openstack-swift | 08:22 | |
| *** oshritf has quit IRC | 08:24 | |
| acoles | timburke: clayg nice work on is_healthy! | 08:28 |
| *** oshritf has joined #openstack-swift | 08:36 | |
| *** oshritf has quit IRC | 08:51 | |
| *** oshritf has joined #openstack-swift | 08:54 | |
| *** mvk has quit IRC | 09:04 | |
| *** oshritf has quit IRC | 09:07 | |
| acoles | clayg: so my stats_interval was 20 and reconstructor.ring_check_interval is 15 - I figure that sometimes an aggregate_recon_update happened before ring_check_interval expired which caused the ring to be reloaded and so no change was detected when ring_check_interval eventually expired. Other times ring_check got to the ring first so detected the change, but then the ring itself did not reload because it had not reached | 09:11 |
| acoles | its _rtime (reload time), so then I saw workers restart but using stale devs. | 09:11 |
| acoles | clayg: but that is all history now :) | 09:11 |
| *** kiennt_ is now known as kiennt | 09:15 | |
| *** oshritf has joined #openstack-swift | 09:15 | |
| *** mvk has joined #openstack-swift | 09:44 | |
| *** tovin07_ has quit IRC | 10:08 | |
| *** tonanhngo has joined #openstack-swift | 10:21 | |
| *** tonanhngo has quit IRC | 10:26 | |
| *** JimCheung has joined #openstack-swift | 11:07 | |
| *** JimCheung has quit IRC | 11:11 | |
| *** ukaynar has joined #openstack-swift | 11:17 | |
| *** ukaynar has quit IRC | 11:28 | |
| *** kei_yama has quit IRC | 11:35 | |
| *** catintheroof has joined #openstack-swift | 12:11 | |
| *** kiennt has quit IRC | 12:11 | |
| *** psachin has quit IRC | 12:26 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-swiftclient master: Updated from global requirements https://review.openstack.org/89250 | 12:40 |
| *** gkadam has quit IRC | 12:49 | |
| *** links has quit IRC | 12:52 | |
| *** lucasxu has joined #openstack-swift | 13:03 | |
| *** caiobrentano has joined #openstack-swift | 13:06 | |
| *** JimCheung has joined #openstack-swift | 13:33 | |
| *** JimCheung has quit IRC | 13:38 | |
| *** mathiasb has quit IRC | 13:52 | |
| *** mvk has quit IRC | 14:06 | |
| *** lucasxu has quit IRC | 14:30 | |
| *** lucasxu has joined #openstack-swift | 14:32 | |
| *** iprokg has joined #openstack-swift | 14:33 | |
| openstackgerrit | Alistair Coles proposed openstack/swift master: Add unit test for ObjectReconstructor.is_healthy https://review.openstack.org/487873 | 14:35 |
| *** iprokg has quit IRC | 14:38 | |
| *** cshastri has quit IRC | 14:48 | |
| *** lucasxu has quit IRC | 14:59 | |
| *** lucasxu has joined #openstack-swift | 15:02 | |
| *** rcernin has quit IRC | 15:03 | |
| *** links has joined #openstack-swift | 15:04 | |
| *** links has quit IRC | 15:07 | |
| *** skudlik has quit IRC | 15:12 | |
| acoles | clayg: do you want to take a final look at patch 478416 w.r.t. timburke's fixes? | 15:24 |
| patchbot | https://review.openstack.org/#/c/478416/ - swift - Add multiple worker processes strategy to reconstr... | 15:24 |
| *** caiobrentano_ has joined #openstack-swift | 15:25 | |
| *** caiobrentano has quit IRC | 15:25 | |
| *** mat128 has joined #openstack-swift | 15:29 | |
| clayg | Yes please! | 15:29 |
| *** psachin has joined #openstack-swift | 15:32 | |
| *** caiobrentano_ has quit IRC | 15:33 | |
| acoles | clayg: ok, it's teetering on the edge... | 15:35 |
| *** gyee has joined #openstack-swift | 15:35 | |
| acoles | I'm looking at patch 448480 | 15:36 |
| *** caiobrentano has joined #openstack-swift | 15:36 | |
| patchbot | https://review.openstack.org/#/c/448480/ - swift - DB replicator cleanup | 15:36 |
| notmyname | good morning | 15:46 |
| notmyname | swiftclient was tagged. thanks timur timburke and acoles for that final patch push | 15:47 |
| acoles | :) | 15:48 |
| *** caiobrentano has quit IRC | 16:06 | |
| *** lucasxu has quit IRC | 16:06 | |
| *** caiobrentano has joined #openstack-swift | 16:22 | |
| *** mat128 has quit IRC | 16:24 | |
| *** hseipp has quit IRC | 16:25 | |
| *** psachin has quit IRC | 16:32 | |
| *** JimCheung has joined #openstack-swift | 16:34 | |
| *** JimCheung has quit IRC | 16:37 | |
| *** JimCheung has joined #openstack-swift | 16:37 | |
| *** JimCheung has quit IRC | 16:38 | |
| *** JimCheung has joined #openstack-swift | 16:38 | |
| *** JimCheung has quit IRC | 16:39 | |
| *** JimCheung has joined #openstack-swift | 16:39 | |
| timburke | good morning | 16:42 |
| *** mvk has joined #openstack-swift | 17:13 | |
| *** klrmn has joined #openstack-swift | 17:13 | |
| *** rcernin has joined #openstack-swift | 17:16 | |
| *** mat128 has joined #openstack-swift | 17:20 | |
| *** mat128 has quit IRC | 17:29 | |
| *** ChubYann has joined #openstack-swift | 17:30 | |
| *** mat128 has joined #openstack-swift | 17:34 | |
| notmyname | acoles: timburke: on https://review.openstack.org/#/c/478416/ you both have +2s. what are we looking for next on that one? more eyes? squash follow-ups? something else? | 17:38 |
| patchbot | patch 478416 - swift - Add multiple worker processes strategy to reconstr... | 17:38 |
| acoles | notmyname: clayg said he'd like one last look | 17:38 |
| notmyname | kk | 17:38 |
| clayg | Am I holding things up? | 17:39 |
| clayg | I looked. It looks fine. I'm sure we can live with whatever. There's going to be follow up regardless. | 17:39 |
| acoles | no need to squash follow up IMHO | 17:39 |
| acoles | clayg: notmyname ok I'll +A | 17:40 |
| notmyname | ok,thanks | 17:40 |
| clayg | Whoa! Cool! Wtg guys! | 17:40 |
| acoles | clayg: this is the only follow up https://review.openstack.org/#/c/487873 so far | 17:41 |
| patchbot | patch 487873 - swift - Add unit test for ObjectReconstructor.is_healthy | 17:41 |
| notmyname | brb. restarting bouncer | 17:42 |
| *** patchbot has quit IRC | 17:42 | |
| *** notmyname has quit IRC | 17:43 | |
| clayg | assertNotEqual isn't terribly strong but it gets the idea across. Why not merge it? | 17:44 |
| *** patchbot has joined #openstack-swift | 17:44 | |
| *** notmyname has joined #openstack-swift | 17:44 | |
| *** ChanServ sets mode: +v notmyname | 17:44 | |
| *** cschwede_ has quit IRC | 17:45 | |
| *** patchbot has quit IRC | 17:45 | |
| *** patchbot has joined #openstack-swift | 17:45 | |
| notmyname | test patch 1234 | 17:45 |
| patchbot | https://review.openstack.org/#/c/1234/ - tempest - Removing link doctoring in test_images (MERGED) | 17:45 |
| notmyname | test patch 12345 | 17:45 |
| patchbot | https://review.openstack.org/#/c/12345/ - neutron - Update with latest code from openstack-common (sta... (MERGED) | 17:45 |
| notmyname | ok, all good | 17:45 |
| timburke | clayg: hey, you didn't +A either :P | 17:48 |
| clayg | Not logged into gerrit ATM | 17:48 |
| *** mat128 has quit IRC | 17:53 | |
| openstackgerrit | Alistair Coles proposed openstack/swift master: DB replicator cleanup https://review.openstack.org/448480 | 17:56 |
| *** geaaru has quit IRC | 18:13 | |
| *** mat128 has joined #openstack-swift | 18:16 | |
| *** skudlik has joined #openstack-swift | 18:20 | |
| clayg | acoles: i missed patch 487168 when it came up - it doesn't seem obviously simpler to me | 18:43 |
| patchbot | https://review.openstack.org/#/c/487168/ - swift - WIP try synchronous recon aggregation | 18:43 |
| clayg | what's the benefit you were going for exactly? I just want to evaluate it in the correct light; other wise IIABDFI | 18:45 |
| notmyname | http://www.urbandictionary.com/define.php?term=iiabdfi <-- no definitions found | 18:48 |
| timburke | notmyname: if it ain't broke... | 18:49 |
| timburke | i had to look it up, too | 18:49 |
| notmyname | ah, ok :-) | 18:49 |
| *** oshritf has quit IRC | 18:57 | |
| clayg | hrmm... Pavel found another gem and I missed it - lp bug #1690791 | 19:10 |
| openstack | Launchpad bug 1690791 in OpenStack Object Storage (swift) "Objects are not deleted from additional handoff when primary disk fails" [Undecided,New] https://launchpad.net/bugs/1690791 | 19:10 |
| clayg | tdasilva: I think we should have a tag for "has-patch" or something no? | 19:10 |
| clayg | at somepoint that could be useful cleanup? | 19:10 |
| clayg | Like once we have all the bugs "confirmed" I assume next step will probably be to try and maybe close one here or there? based on priority or something? If something is "confirmed" and "medium" and "has-patch" maybe that'd be a good place to start after we finish triage? or something? Maybe? | 19:11 |
| timburke | clayg: doesn't launchpad have a search option like "Show only bugs with patches available"? | 19:12 |
| clayg | probably - but that's like "diff attached to bug" not "review available in gerrit" | 19:12 |
| clayg | but maybe "has-patch" isn't the right name for the tag - good point | 19:12 |
| timburke | i thought that's what the in-progress status was for | 19:13 |
| clayg | "gerrit-review-available" | 19:13 |
| clayg | timburke: i'm not sure how we use in-progress | 19:13 |
| clayg | ... but I'm pretty sure you can set that if it's assigned to you even before you put a change up | 19:13 |
| clayg | in fact that's probably a state with a timeout we could bot-away | 19:13 |
| *** chsc has joined #openstack-swift | 19:14 | |
| *** chsc has joined #openstack-swift | 19:14 | |
| timburke | hmm... https://review.openstack.org/#/c/219963/ has a really old bug attached... | 19:17 |
| patchbot | patch 219963 - swift - Fix memcached exception out of range stacktrace | 19:17 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/swift master: Updated from global requirements https://review.openstack.org/88736 | 19:23 |
| clayg | torgomatic: zaitcev: timburke: I missed patch 486264 - good fix! (cc rledisez) | 19:39 |
| patchbot | https://review.openstack.org/#/c/486264/ - swift - Close stdout *after* binding ports (MERGED) | 19:39 |
| timburke | clayg: yeah, much better to have reliable probe tests again :-) | 19:39 |
| *** skudlik has quit IRC | 20:22 | |
| *** mat128 has quit IRC | 20:27 | |
| *** mat128 has joined #openstack-swift | 20:27 | |
| *** mat128 has quit IRC | 20:29 | |
| timburke | clayg: on https://bugs.launchpad.net/swift/+bug/1525245 -- are we arguing for deprecating/dropping support for conditional puts entirely? 'cause that sure sounds like an argument for doing so | 20:31 |
| openstack | Launchpad bug 1525245 in OpenStack Object Storage (swift) "If None Match on upload" [Wishlist,Incomplete] | 20:31 |
| clayg | no | 20:32 |
| clayg | if-none-match: * has an interesting affordance that hints at the only acceptable use-case (IMHO) | 20:32 |
| timburke | how is it different? two clients attempt to PUT to the same name at approximately the same time... one actually gets to have its data durably stored, the other doesn't | 20:33 |
| clayg | which is basically - I have generated THE data that belongs at this name, and unless someone has already beaten me to it - I'd like you to save it permanently at this name - if you have any record of an object - then you definitely have the correct data - because I have coded my application to work this way | 20:33 |
| clayg | if you do not see a record of this object I will transfer it to you - and if you're wrong - worst case is I didn't get my little efficiency bump of getting to skip the network ingress | 20:34 |
| clayg | yes, I mean... if you have to clients racing to upload different data - i mean what else would you expect if-none-match: * to do? | 20:35 |
| clayg | unless the upload is somehow instantaneous? I think the affordance somewhat hints at the guarantee - I was pretty skeptical to it when it was added - but the alternative was HEAD then PUT - and request_node_count 404's were an annoying price to pay when the application had the semantic I described (which JungleDisk did - and they were a huge consumer on CloudFiles at the time) | 20:37 |
| clayg | if you try to abuse it to do like an atomic "baton" where whoever gets the PUT off holds a "lock" until they DELETE - but it fails horribly because of the upload/tombstone/[upload&upload] case | 20:39 |
| clayg | i hope no one tries to use it like that - because it definitely doesn't work in any reasonable sense - so it's unfortunate that it does give off that affordance a little bit - but i'm not advocating it should be ripped out, no | 20:41 |
| clayg | maybe that's not a consistent posistion for me to take! but it's honest if still hypocritical. | 20:41 |
| clayg | notmyname: oh hey! you were asking me about this very thing on the doc reorg -> http://lists.openstack.org/pipermail/openstack-dev/2017-July/120255.html | 20:46 |
| clayg | I told you "meh, bite the bullet" - but I am an asshole that hates users! We should *totally* provide these magic redirects with crazy regex's | 20:47 |
| clayg | notmyname: do you have enough sense of how the top-level trees have moved that you could purpose a patch that makes it "just work" - or even just validate the "process" works and then we can muddle around ad-hoc as we find broken links (how would we even find them? Can we review the access logs to swift.openstack.org!?) | 20:48 |
| notmyname | so far, the top level stuff we used to have hasn't moved much | 20:49 |
| notmyname | however, the "plan" is that a lot of it will move. however, that's got to be part of a larger reorg of the docs content | 20:50 |
| notmyname | I love the idea of being able to maintain our own file that does redirects | 20:50 |
| clayg | IKR!? | 20:50 |
| timburke | but the redirects we have are crap. http://docs.openstack.org/developer/swift/development_saio.html -> https://docs.openstack.org/swift/latest/ ? that's not https://docs.openstack.org/swift/latest/development_saio.html ! | 20:50 |
| clayg | we *have* redirects!? | 20:51 |
| notmyname | yes, but no | 20:51 |
| timburke | (maybe not "crap", but they could be improved) | 20:51 |
| notmyname | the only redirects that have been set up are those external to our repo to point into our docs tree according to the new docs structure | 20:51 |
| timburke | and they only go to the root | 20:51 |
| clayg | oh... that sounds lame... I want to the hawtness with the we can fix it! | 20:52 |
| notmyname | the previous /developer/ content (ie everything we used to have) is supposed to be under a /contributor/ directory and external redirects would link to that | 20:52 |
| notmyname | similarly to how external redirects for the API are now linking into our docs tree | 20:53 |
| notmyname | or the install guide | 20:53 |
| notmyname | ie the stuff that we moved into our repo from the -manuals project | 20:53 |
| notmyname | today, we're at the point where further reorg work can be done entirely in our repo | 20:54 |
| notmyname | and maybe we can use the .htaccess to provide better redirects? I don't know. I only saw the ML message the same time clayg did | 20:54 |
| openstackgerrit | John Dickinson proposed openstack/swift master: added .htaccess redirect file for docs https://review.openstack.org/488202 | 20:58 |
| notmyname | I guess that's the basic structure? | 20:58 |
| clayg | we should put one in tho - anyone have a guess at what one might look like - to test? | 20:59 |
| notmyname | heh, yeah. IDK :-) | 20:59 |
| clayg | I think this is one of those just do it and see what happens kind of things - I don't really mind a few shas in the commit history to figure out what works | 21:00 |
| notmyname | sure. even a /test-change-please-ignore -> / | 21:00 |
| clayg | yes yes yes! | 21:00 |
| clayg | i was thinking /notmyname -> /ptl-for-life but w/e | 21:00 |
| notmyname | lol | 21:00 |
| notmyname | a 402 on /write-this-special-feature might be a little too snarky ;-) | 21:02 |
| clayg | noice | 21:05 |
| openstackgerrit | Merged openstack/swift master: Add multiple worker processes strategy to reconstructor https://review.openstack.org/478416 | 21:06 |
| notmyname | woohoo | 21:06 |
| openstackgerrit | John Dickinson proposed openstack/swift master: added .htaccess redirect file for docs https://review.openstack.org/488202 | 21:07 |
| clayg | did everyone do the think at https://www.openstack.org/profile/ where you click the "make me foundation member" button? | 21:07 |
| clayg | http://lists.openstack.org/pipermail/openstack-dev/2017-July/119786.html | 21:08 |
| openstackgerrit | Merged openstack/swift master: Add unit test for ObjectReconstructor.is_healthy https://review.openstack.org/487873 | 21:09 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/swift master: Updated from global requirements https://review.openstack.org/88736 | 21:10 |
| timburke | clayg: i thought you *had* to sign up for gerrit? hence http://lists.openstack.org/pipermail/openstack-dev/2017-July/120180.html recently... | 21:10 |
| timburke | er, "had to *to* sign up..." | 21:12 |
| notmyname | I need to add a changelog entry for the multi-process reconstructor (/cc clayg) and then I'll push up another patchset for it | 21:15 |
| notmyname | I'm tempted to go ahead and land it and tag a swift release tonight | 21:15 |
| clayg | whoa | 21:20 |
| clayg | umm... notmyname were you asking me to write the change log entry? | 21:20 |
| notmyname | nope. just letting you know that *I'm* writing it, and I'm about to ask you if you think what I just wrote is ok | 21:21 |
| clayg | i bet it's *amazing* | 21:21 |
| openstackgerrit | John Dickinson proposed openstack/swift master: 2.15.0 authors and changelog update https://review.openstack.org/485839 | 21:22 |
| notmyname | ta da | 21:22 |
| notmyname | starting at line 28 on https://review.openstack.org/#/c/485839/6/CHANGELOG | 21:23 |
| patchbot | patch 485839 - swift - 2.15.0 authors and changelog update | 21:23 |
| notmyname | oh, weird. https://review.openstack.org/#/c/476955/ never actually landed | 21:26 |
| patchbot | patch 476955 - swift - Add bin/swift-dispersion-report | 21:26 |
| timburke | parent change: https://review.openstack.org/#/c/476953/ | 21:27 |
| patchbot | patch 476953 - swift - Make swift-dispersion-report importable | 21:27 |
| openstackgerrit | John Dickinson proposed openstack/swift master: 2.15.0 authors and changelog update https://review.openstack.org/485839 | 21:44 |
| notmyname | I found 2 uncredited authors | 21:44 |
| notmyname | clayg: if you're ok with the changelog note for the reconstructor, I'll land it | 21:45 |
| clayg | *totally* | 21:46 |
| notmyname | ok, thanks | 21:46 |
| clayg | notmyname: yeah I think that patch 488202 looks like a grand idea | 22:00 |
| patchbot | https://review.openstack.org/#/c/488202/ - swift - added .htaccess redirect file for docs | 22:00 |
| clarkb | clayg: I've just approved the change to make it work on the web server side so you should be able to test it with the docs-draft site shortly | 22:02 |
| clayg | whhhaaa??? nowhey!! thanks clarkb!! | 22:02 |
| notmyname | clarkb: thanks! | 22:19 |
| notmyname | clarkb: do we need to wait on a different patch before landing https://review.openstack.org/#/c/488202/? or should we go ahead and land ours and it will start working when another patch lands? | 22:23 |
| patchbot | patch 488202 - swift - added .htaccess redirect file for docs | 22:23 |
| clarkb | notmyname: you shouldn't need to wait it should start working once the server update happens. but you may want to wait if you want to test using docs-draft first, eg http://docs-draft.openstack.org/02/488202/2/check/gate-swift-docs-ubuntu-xenial/623ed92//doc/build/html/ | 22:24 |
| notmyname | clarkb: ok. what's the other patch? | 22:25 |
| clarkb | notmyname: https://review.openstack.org/488172 which has merged, we just need puppet to apply it to the servers which should happen real soon now if not already done | 22:25 |
| patchbot | patch 488172 - openstack-infra/system-config - allow redirects in .htaccess files on the static w... (MERGED) | 22:25 |
| notmyname | ok | 22:25 |
| notmyname | so we recheck our patch and it will be in the docs-draft? | 22:25 |
| *** rcernin has quit IRC | 22:26 | |
| clarkb | notmyname: its already in docs-draft, the url I pasted is the draft build for it | 22:26 |
| notmyname | oh :-) | 22:27 |
| clarkb | notmyname: no recheck necesasry as this is purely a webserver update to allow htaccess to affect things | 22:27 |
| *** catintheroof has quit IRC | 22:27 | |
| openstackgerrit | Timur Alperovich proposed openstack/python-swiftclient master: Turn stdin uploads into SLO above 10MB. https://review.openstack.org/478611 | 22:29 |
| notmyname | clarkb: tbh, I'm not sure how to check the regex on the docs-draft site. what's the root (ie that matches ^) | 22:30 |
| clarkb | notmyname: /02/488202/2/check/gate-swift-docs-ubuntu-xenial/623ed92//doc/build/html/ is the url I expect /02/488202/ to be the root which is your change id mangled. So it may be a pita to test that way | 22:31 |
| notmyname | hmm.. yeah. the beginning of line match is likely messing it up | 22:32 |
| notmyname | clarkb: ok, so how is this implemented? all projects are hosted at the same domain, so we just have good-faith that my regexes start with /swift/ and nova's start with /nova/ and we trust people not to stomp on each other? | 22:32 |
| notmyname | is the server side just a concat of all the available .htaccess files? | 22:33 |
| notmyname | or is each project only given .htaccess inside of their path segment? | 22:33 |
| notmyname | (which mean that /swift/ is the only thing that would work but /nova/ in our .htaccess wouldn't break nova) | 22:33 |
| clarkb | notmyname: aiui an htaccess file only applies to the directory it is in and any subdirectories | 22:35 |
| notmyname | ok | 22:35 |
| clarkb | notmyname: that means you'd have to be in eg /swift/foo/bar/ to hit your htaccess file in which case a redirect from /nova/ to /notnova/ wouldn't match | 22:35 |
| clarkb | you could still have that rule but I don't think it would have any effect | 22:35 |
| notmyname | right. ok. makes sense | 22:35 |
| *** openstack has joined #openstack-swift | 22:44 | |
| *** jidar has quit IRC | 22:45 | |
| notmyname | yeah, ok. some more generic regex might be more testable | 22:46 |
| *** jidar has joined #openstack-swift | 22:47 | |
| *** redbo has joined #openstack-swift | 22:47 | |
| *** ChanServ sets mode: +v redbo | 22:47 | |
| *** mmmucky has joined #openstack-swift | 22:48 | |
| *** ukaynar has joined #openstack-swift | 22:50 | |
| *** itlinux has joined #openstack-swift | 23:03 | |
| *** chsc_ has quit IRC | 23:27 | |
| *** kei_yama has joined #openstack-swift | 23:31 | |
| notmyname | I approved the changelog patch before the .htaccess patch. but because of the change to the check queue, the .htaccess patch got to the gate queue a lot faster. meaning that it will be in this release instead of the next one | 23:42 |
| notmyname | it doesn't really matter in this case, but it's interesting to note that the gate can and will reorder the patches to merge them, regardless of when the +A was given | 23:43 |
| clarkb | notmyname: which two changes? | 23:43 |
| clarkb | https://review.openstack.org/#/c/488202/ and ? | 23:43 |
| patchbot | patch 488202 - swift - added .htaccess redirect file for docs | 23:43 |
| notmyname | https://review.openstack.org/#/c/485839/ | 23:44 |
| patchbot | patch 485839 - swift - 2.15.0 authors and changelog update | 23:44 |
| notmyname | the changelog patch was +A'd nearly an hour before the .htaccess patch, but the .htaccess one is in front of the changelog one in the gate queue | 23:44 |
| clarkb | yes the reason for that is the changelog patch had not passed check to get a +1 yet. And you can't enter the gate until you have that +1 | 23:45 |
| clarkb | the htaccess change had already received the check +1 when approved so went straight into the gate | 23:45 |
| notmyname | this is because the check queue for the .htaccess patch only ran the short tests (it matched the docs-only change pattern) | 23:45 |
| notmyname | note that the .htaccess patch spent around 5 minutes in the check queue. the full check queue is an hour | 23:46 |
| notmyname | like I said, it doesn't matter in this case. the non-determinism is something to be cautious of, though | 23:47 |
| clarkb | well it is deterministic | 23:47 |
| notmyname | it's based on how long the check queue takes | 23:47 |
| notmyname | which can vary on workers | 23:47 |
| clarkb | its based on change state more specifically | 23:47 |
| notmyname | which isn't always deterministic | 23:47 |
| clarkb | if you wait for cehck +1 before approval the order will always be preserved | 23:48 |
| notmyname | sure. and it will always be preserved if every patch has a depends-on tag. definitely something lost in both cases, though | 23:48 |
| clarkb | ya or just a git parent child relationship since they are in the same repo | 23:48 |
| *** catintheroof has joined #openstack-swift | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!