*** baffle has quit IRC | 00:25 | |
*** baffle has joined #openstack-swift | 00:25 | |
*** AndyWojo has quit IRC | 00:53 | |
mattoliverau | Morning | 01:33 |
---|---|---|
*** mingyu has joined #openstack-swift | 02:11 | |
kota_ | good morning | 02:36 |
*** psachin has joined #openstack-swift | 03:09 | |
*** psachin has quit IRC | 03:13 | |
*** klrmn has quit IRC | 03:34 | |
*** psachin has joined #openstack-swift | 03:39 | |
mattoliverau | kota_: morning | 03:44 |
kota_ | mattoliverau: o/ | 03:45 |
*** links has joined #openstack-swift | 04:12 | |
*** vinsh has joined #openstack-swift | 04:14 | |
*** vinsh has quit IRC | 04:14 | |
*** flwang1 has quit IRC | 05:07 | |
*** mingyu has quit IRC | 05:26 | |
*** arunman has joined #openstack-swift | 05:53 | |
*** adriant has quit IRC | 06:08 | |
*** arunman has quit IRC | 06:22 | |
*** arunman has joined #openstack-swift | 06:52 | |
*** tesseract has joined #openstack-swift | 07:06 | |
*** mingyu has joined #openstack-swift | 07:07 | |
*** arunman has quit IRC | 07:10 | |
*** rcernin has joined #openstack-swift | 07:12 | |
kota_ | hmmm.... why https://review.openstack.org/#/c/453827 failed, idk | 07:13 |
patchbot | patch 453827 - swift - Add CompositeRingBuilder class | 07:13 |
kota_ | that has no message, just said "invocation error" so no hint to me... | 07:13 |
kota_ | let's check also the master | 07:14 |
*** rcernin has quit IRC | 07:32 | |
kota_ | hmm... the master works | 07:54 |
kota_ | and my rebasing doesn't, so something happens during the changes. | 07:55 |
*** mingyu has quit IRC | 07:55 | |
mattoliverau | Maybe just do a recheck and see if it happens again | 07:56 |
*** mingyu has joined #openstack-swift | 07:57 | |
*** SkyRocknRoll has joined #openstack-swift | 07:57 | |
*** SkyRocknRoll has quit IRC | 08:00 | |
*** SkyRocknRoll has joined #openstack-swift | 08:01 | |
*** d0ugal has quit IRC | 08:07 | |
*** d0ugal has joined #openstack-swift | 08:08 | |
*** geaaru_ has quit IRC | 08:09 | |
*** geaaru has joined #openstack-swift | 08:19 | |
kota_ | mattoliverau: thx for the suggestion but it happens in my local so that something wrong i think | 08:22 |
* kota_ is now doubting `from mock import mock` line in the unit test that looks odd | 08:23 | |
openstackgerrit | Alistair Coles proposed openstack/swift master: Fix unit test failing when swift.conf has default policy index >10 https://review.openstack.org/461062 | 08:24 |
acoles | good morning | 08:24 |
kota_ | acoles: good morning | 08:25 |
kota_ | acoles: thx for fixing a lot for my WIP patch :-D | 08:26 |
kota_ | that is already squashed to the parent | 08:26 |
mattoliverau | acoles: o/ | 08:26 |
acoles | kota_: your patch was really good, hope it was ok for me to squash it | 08:27 |
acoles | mattoliverau: o/ | 08:27 |
kota_ | acoles: that's cool except it hits an invocation error on unit test. I'm now digging why it happesn | 08:27 |
kota_ | happens | 08:27 |
*** arunman has joined #openstack-swift | 08:28 | |
kota_ | i think, it's not gate problem because i also have been able to hit it. | 08:28 |
acoles | kota_: I'm just running locally (although I am sure I would have done that before pushing to gerrit) | 08:30 |
kota_ | acoles: hmm... weird. the invocation error looked to occur the end of unit tests | 08:32 |
kota_ | the log says test.unit.test_locale -> ok so all unit tests inside test/unit runs successfully | 08:32 |
acoles | kota_: I see it too but I ignored because I had 3 tests fail due to https://review.openstack.org/461062 | 08:34 |
patchbot | patch 461062 - swift - Fix unit test failing when swift.conf has default ... | 08:34 |
* acoles slap self | 08:34 | |
*** arunman has quit IRC | 08:39 | |
acoles | mattoliverau: if you have chance to revisit it, i now have +2 on https://review.openstack.org/454386 | 08:43 |
patchbot | patch 454386 - swift - Fix install guide filter:authtoken config example | 08:43 |
*** hseipp has joined #openstack-swift | 08:43 | |
* kota_ has no idea for now how to debug the invocation error because it has no message :/ | 08:48 | |
* kota_ is running the parent patch independently to clarify when it was injected. | 08:48 | |
kota_ | it looks like patch set4 ran successfully at the gate but the diff since that not so strange except `from mock import mock`. However, when I fixed that, it still happesn | 08:50 |
kota_ | happens | 08:50 |
acoles | mattoliverau: thank you! | 08:52 |
acoles | kota_: more output from 'tox -e py27 -- test.unit.common.ring.test_composite_builder.py' | 08:53 |
acoles | kota_: I have an idea what the cause is | 08:53 |
acoles | just trying a fix | 08:54 |
kota_ | acoles: oh, that enables us to reproduce? I was waiting whole test run with `tox -e py27` | 08:54 |
kota_ | acoles: (because, just `nosetests test/unit/common/ring/test_composite_builder.py` didn't fail) | 08:55 |
* kota_ tries | 08:55 | |
acoles | kota_: yep. but the traceback is in coverage | 08:55 |
acoles | 'nosetests ./test/unit/common/ring/test_composite_builder.py --with-coverage' fails | 08:56 |
kota_ | oic | 08:56 |
kota_ | make sense | 08:57 |
acoles | kota_: I am betting a beer that it is because I chdir to the tempdir here https://github.com/openstack/swift/blob/d079c3d5b3ff3b097fcb1e12cd5e0defa7d69305/test/unit/common/ring/test_composite_builder.py#L490-L490 | 08:57 |
acoles | kota_: yes! it is the chdir | 08:58 |
kota_ | wow, it sounds dengerous :/ | 08:58 |
*** mingyu has quit IRC | 08:58 | |
acoles | yeah :/ | 08:59 |
kota_ | ah, and the coverage cannot report the output on 'current dir' because the tempdir already removed | 08:59 |
kota_ | got it! | 08:59 |
acoles | crazy | 09:00 |
* kota_ is waiting acoles pushed the new version :) | 09:00 | |
acoles | I will | 09:00 |
kota_ | kk, let's leave my comments to the current version now | 09:00 |
kota_ | acoles: the left comments on the patch from my side is for the compose method | 09:04 |
kota_ | acoles: that looks designed for overriding current components in the CompositeRingBuilder. And I'm wondering how it works with the check_against_existing. | 09:05 |
kota_ | i didn't try to check the test and to write some assertions by my self but from my quick view, if overriding with other path, the compose can fail with different components? | 09:06 |
kota_ | so I'm not sure it's for just path change operation or, completly overwriting of components for now. | 09:07 |
*** arunman has joined #openstack-swift | 09:09 | |
kota_ | let me continue tomorrow | 09:09 |
acoles | kota_: My intent was to allow builder file paths to be passed in case the paths had changed | 09:10 |
acoles | or, if with force=True s ome or all of the builders was changing | 09:10 |
kota_ | acoles: so the component contents should not be changed? | 09:10 |
acoles | some* | 09:10 |
acoles | kota_: correct, normally | 09:11 |
kota_ | acoles: ok, force=True is same with my thought. | 09:11 |
kota_ | acoles: ok, that's same with my reading for the code. | 09:11 |
kota_ | so it looks correct coding. | 09:11 |
kota_ | acoles: nice :D | 09:11 |
acoles | kota_: hmmm, but now I can see that the same could be achieved using the set_builders method, so no need for builders arg on compose | 09:12 |
acoles | set_builder_files* | 09:12 |
kota_ | acoles: maybe | 09:12 |
kota_ | yeah | 09:12 |
acoles | that would perhaps make the compose() signature less confusing? | 09:14 |
kota_ | acoles: maybe. and i'd like to add some docs, the components will be still checked even if the builder files changed | 09:16 |
*** arunman has quit IRC | 09:16 | |
acoles | kota_: I'll think about it some more and maybe make that change | 09:16 |
kota_ | any of 'override the builder files' sounds to replace every component | 09:16 |
acoles | kota_: ack re doc | 09:17 |
kota_ | it may be only me though. | 09:17 |
kota_ | acoles: thx! | 09:17 |
*** mingyu has joined #openstack-swift | 09:17 | |
acoles | sorry for the weird test failures :/ | 09:17 |
kota_ | acoles: np | 09:18 |
kota_ | acoles: and fyi, tomorrow is the last *office* day to me before OpenStack Summit because this is a long national holiday week in Japan. | 09:19 |
acoles | kota_: ok. thanks | 09:19 |
kota_ | acoles: I'm willing to attend the irc meeting Thu in JST morning but my activity will be slow down until the summit. | 09:19 |
acoles | kota_: sure, enjoy the holiday | 09:20 |
kota_ | thx | 09:20 |
acoles | kota_: so *if* we have enough agreement then maybe we could merge the CompositeRingBuilder patch into patch 441921, tomorrow? But I don't want to force it if there are still issues | 09:22 |
patchbot | https://review.openstack.org/#/c/441921/ - swift - Add Composite Ring Functionality | 09:22 |
*** mingyu has quit IRC | 09:25 | |
*** SkyRocknRoll has quit IRC | 09:29 | |
openstackgerrit | junboli proposed openstack/swift master: Tests: Use the recommended assertions https://review.openstack.org/449077 | 09:59 |
kota_ | acoles: maybe we can, maybe can't. I'll try to make me to do that. | 10:08 |
openstackgerrit | Merged openstack/swift master: Fix install guide filter:authtoken config example https://review.openstack.org/454386 | 10:17 |
*** hseipp has quit IRC | 10:18 | |
*** mingyu has joined #openstack-swift | 10:19 | |
*** flwang1 has joined #openstack-swift | 10:25 | |
*** mingyu has quit IRC | 10:40 | |
openstackgerrit | junboli proposed openstack/swift master: Remove the unused import code https://review.openstack.org/461360 | 10:47 |
*** chlong has joined #openstack-swift | 11:07 | |
*** silor has joined #openstack-swift | 11:22 | |
*** mingyu has joined #openstack-swift | 11:34 | |
*** mingyu has quit IRC | 11:45 | |
*** mvk has quit IRC | 11:46 | |
openstackgerrit | junboli proposed openstack/swift master: Tests: Use the recommended assertions https://review.openstack.org/449077 | 11:47 |
*** mingyu has joined #openstack-swift | 11:54 | |
*** mvk has joined #openstack-swift | 12:04 | |
*** mingyu has quit IRC | 12:11 | |
*** gkadam has joined #openstack-swift | 12:13 | |
*** klamath has joined #openstack-swift | 12:14 | |
*** klamath has joined #openstack-swift | 12:14 | |
*** gkadam has quit IRC | 12:39 | |
*** mingyu has joined #openstack-swift | 12:45 | |
*** mingyu has quit IRC | 12:46 | |
*** mingyu has joined #openstack-swift | 12:46 | |
*** arunman has joined #openstack-swift | 12:59 | |
*** arunman has quit IRC | 13:11 | |
*** gkadam has joined #openstack-swift | 13:11 | |
*** arunman has joined #openstack-swift | 13:16 | |
*** arunman has quit IRC | 13:17 | |
*** hoonetorg has quit IRC | 13:19 | |
*** hoonetorg has joined #openstack-swift | 13:20 | |
openstackgerrit | Alistair Coles proposed openstack/swift master: Experimental swift-ring-composer CLI to build composite rings https://review.openstack.org/451507 | 13:24 |
openstackgerrit | Alistair Coles proposed openstack/swift master: Add composite ring doc https://review.openstack.org/451500 | 13:24 |
openstackgerrit | Alistair Coles proposed openstack/swift master: Add CompositeRingBuilder class https://review.openstack.org/453827 | 13:24 |
*** mingyu has quit IRC | 13:26 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/swift master: Updated from global requirements https://review.openstack.org/88736 | 13:28 |
*** links has quit IRC | 13:29 | |
*** mingyu has joined #openstack-swift | 13:32 | |
*** mingyu has quit IRC | 13:36 | |
*** arunman has joined #openstack-swift | 13:41 | |
*** mingyu has joined #openstack-swift | 14:10 | |
*** SkyRocknRoll has joined #openstack-swift | 14:11 | |
*** gkadam has quit IRC | 14:12 | |
*** mingyu has quit IRC | 14:15 | |
*** mingyu has joined #openstack-swift | 14:15 | |
*** SkyRocknRoll has quit IRC | 14:22 | |
*** SkyRocknRoll has joined #openstack-swift | 14:24 | |
*** oshritf has joined #openstack-swift | 14:25 | |
*** catintheroof has joined #openstack-swift | 14:30 | |
*** catintheroof has quit IRC | 14:36 | |
*** catintheroof has joined #openstack-swift | 14:40 | |
*** oshritf has quit IRC | 14:40 | |
*** catintheroof has quit IRC | 14:42 | |
*** arunman has quit IRC | 14:44 | |
*** SkyRocknRoll has quit IRC | 14:44 | |
*** peterlisak has quit IRC | 14:45 | |
*** peterlisak has joined #openstack-swift | 14:46 | |
*** vinsh has joined #openstack-swift | 14:57 | |
*** vinsh_ has joined #openstack-swift | 14:59 | |
*** vinsh has quit IRC | 15:00 | |
*** links has joined #openstack-swift | 15:13 | |
*** links has quit IRC | 15:17 | |
*** arunman has joined #openstack-swift | 15:22 | |
*** arunman has quit IRC | 15:25 | |
*** arunman has joined #openstack-swift | 15:28 | |
*** arunman has quit IRC | 15:31 | |
*** arunman has joined #openstack-swift | 15:48 | |
*** gyee has joined #openstack-swift | 16:00 | |
*** Sukhdev has joined #openstack-swift | 16:00 | |
*** arunman has quit IRC | 16:09 | |
*** Sukhdev has quit IRC | 16:14 | |
notmyname | good morning | 16:16 |
*** tesseract has quit IRC | 16:29 | |
*** hseipp has joined #openstack-swift | 16:29 | |
*** openstack has joined #openstack-swift | 17:00 | |
*** openstack has joined #openstack-swift | 17:23 | |
*** tonanhngo has joined #openstack-swift | 17:24 | |
*** psachin has quit IRC | 17:25 | |
*** tonanhngo_ has joined #openstack-swift | 17:27 | |
*** tonanhngo has quit IRC | 17:29 | |
*** tonanhngo_ has quit IRC | 17:29 | |
notmyname | FYI there are three interesting governance patches that will be discussed in tomorrow's tc meeting. here's a summary of each... | 17:30 |
notmyname | patch 459848 proposes dropping the TC meetings entirely and moving to ad-hoc discussions in #openstack-dev | 17:30 |
notmyname | patch 460946 proposes a new principle that no decisions should be made in a synchronous way (eg in a meeting). instead, decisions should be made in an async way, and the patch suggests using gerrit and the ML for that | 17:30 |
notmyname | patch 460951 proposes redefining the current pike goal of using mod_wsgi. The proposal is to change to using uWSGI instead. The patch claims this will be much easier on projects | 17:30 |
patchbot | https://review.openstack.org/#/c/459848/ - governance - Drop Technical Committee meetings | 17:30 |
patchbot | https://review.openstack.org/#/c/460946/ - governance - Do not make decisions using synchronous communication | 17:30 |
patchbot | https://review.openstack.org/#/c/460951/ - governance - Change the target for this goal to uWSGI not Apach... | 17:30 |
*** tonanhngo has joined #openstack-swift | 17:32 | |
*** tongli has quit IRC | 17:41 | |
timburke | acoles: ok, one more idea on that patch: rather than having expected_headers and unexpected_headers, what about *just* having expected_headers, and anything *not* there is automatically unexpected? http://paste.openstack.org/show/608537/ | 17:43 |
acoles | timburke: that might be too brittle - someone might run func tests against a cluster with custom middleware that adds a header we don't know about? | 17:47 |
timburke | hmmm... i've just got a feeling like there are probably *other* headers we want to be sure to not find, only we haven't even realized it yet... | 17:49 |
*** silor has joined #openstack-swift | 17:52 | |
timburke | Pragma, say, or Upgrade | 17:55 |
*** chsc has joined #openstack-swift | 18:05 | |
*** chsc has joined #openstack-swift | 18:05 | |
*** tdasilva has joined #openstack-swift | 18:07 | |
*** openstackstatus has joined #openstack-swift | 18:15 | |
*** ChanServ sets mode: +v openstackstatus | 18:15 | |
notmyname | rledisez: here? | 18:15 |
*** mingyu has quit IRC | 18:15 | |
notmyname | I have (tentatively?) scheduled an additional 2 hours for the swift team in room 109 next wednesday from 10:30 to 12:30. This is in addition to our existing 2:20 time block on tuesday. | 18:19 |
tdasilva | notmyname: do you have a link to the final forum schedule handy? | 18:21 |
notmyname | unfortunately, this conflicts with the OVH conference talk on small file optimization (rledisez), but it's the largest block of time that's non-conflicting as possible i could find | 18:21 |
notmyname | yes. | 18:21 |
notmyname | https://ethercalc.openstack.org/Boston_Forum_Hacking_Rooms | 18:21 |
notmyname | that link is for the reservable rooms | 18:21 |
notmyname | the final schedule for the forum is what's on https://www.openstack.org/summit/boston-2017/summit-schedule/ | 18:22 |
*** xinli has joined #openstack-swift | 18:42 | |
rledisez | hi notmyname, the losf talk is not an OVH talk. it's a guy from iqiyi that does the same kind of work, but on hummingbird. i exchanged mail with him and i'm hoping to meet him in boston | 18:54 |
notmyname | oh right! | 18:55 |
rledisez | well, i'll try to arrange between that time slot you got and his talk | 18:56 |
notmyname | I just saw LOSF and put it in the " rledisez will save us" bucket :-) | 18:56 |
rledisez | will save us *one day* :) | 18:56 |
notmyname | rledisez: yeah, I think there will be some conflict for most days of the week where some poeple willneed to step out for some amount of time | 18:56 |
openstackgerrit | Tim Burke proposed openstack/swift master: Always check for unexected requests in mocked_http_conn https://review.openstack.org/461483 | 19:07 |
*** silor has quit IRC | 19:40 | |
*** mingyu has joined #openstack-swift | 20:04 | |
*** mingyu has quit IRC | 20:08 | |
*** klamath has quit IRC | 20:08 | |
*** xinli has quit IRC | 20:29 | |
*** flwang1 has quit IRC | 20:32 | |
openstackgerrit | Merged openstack/swift master: Do not sync suffixes when remote rejects reconstructor revert https://review.openstack.org/435152 | 20:38 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/swift master: Updated from global requirements https://review.openstack.org/88736 | 20:41 |
*** klamath has joined #openstack-swift | 21:02 | |
*** Sukhdev_ has joined #openstack-swift | 21:08 | |
*** flwang1 has joined #openstack-swift | 21:30 | |
*** adriant has joined #openstack-swift | 21:37 | |
*** geaaru has quit IRC | 21:45 | |
*** catintheroof has joined #openstack-swift | 21:50 | |
openstackgerrit | Tim Burke proposed openstack/swift master: Always check for unexected requests in mocked_http_conn https://review.openstack.org/461483 | 22:12 |
*** klamath has quit IRC | 22:34 | |
*** catintheroof has quit IRC | 22:39 | |
*** tonanhngo has quit IRC | 22:41 | |
*** tonanhngo has joined #openstack-swift | 22:42 | |
*** tonanhngo_ has joined #openstack-swift | 22:45 | |
*** tonanhngo has quit IRC | 22:46 | |
*** tonanhngo_ has quit IRC | 22:50 | |
*** chsc has quit IRC | 23:37 | |
*** jamielennox is now known as jamielennox|away | 23:56 | |
*** jamielennox|away is now known as jamielennox | 23:58 | |
mattoliverau | Morning | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!