*** dmorita has quit IRC | 00:14 | |
*** diogogmt has quit IRC | 00:18 | |
*** tqtran has quit IRC | 00:21 | |
*** gyee has quit IRC | 00:21 | |
*** garthb has quit IRC | 00:22 | |
*** Jeffrey4l has joined #openstack-swift | 00:23 | |
*** lyrrad has quit IRC | 00:25 | |
*** suyash has quit IRC | 00:27 | |
openstackgerrit | Pete Zaitcev proposed openstack/swift: Use pre-defined inputs in TestGetHashPrefixAndSuffix https://review.openstack.org/327466 | 00:29 |
---|---|---|
*** ouchkernel has quit IRC | 00:29 | |
*** ouchkernel has joined #openstack-swift | 00:30 | |
*** klamath has quit IRC | 00:34 | |
*** klamath has joined #openstack-swift | 00:35 | |
*** urth has quit IRC | 00:52 | |
*** urth has joined #openstack-swift | 00:54 | |
kota_ | good morning | 01:02 |
*** zul has joined #openstack-swift | 01:04 | |
*** dmorita has joined #openstack-swift | 01:05 | |
*** dmorita has quit IRC | 01:10 | |
kota_ | tdasilva: nice work on the liberasurecode gate job, thanks! | 01:38 |
tdasilva | kota_: thx :) | 01:38 |
*** zul has quit IRC | 01:41 | |
*** zul has joined #openstack-swift | 01:54 | |
*** klamath has quit IRC | 01:59 | |
*** suyash has joined #openstack-swift | 02:19 | |
*** ouchkernel has quit IRC | 02:53 | |
*** ouchkernel has joined #openstack-swift | 03:00 | |
*** links has joined #openstack-swift | 03:08 | |
*** openstackgerrit has quit IRC | 03:11 | |
*** openstackgerrit has joined #openstack-swift | 03:11 | |
*** ouchkernel has quit IRC | 03:12 | |
*** ouchkernel has joined #openstack-swift | 03:15 | |
*** dmorita has joined #openstack-swift | 04:11 | |
*** garthb has joined #openstack-swift | 04:27 | |
*** dmorita has quit IRC | 04:27 | |
*** psachin has joined #openstack-swift | 04:32 | |
*** ppai has joined #openstack-swift | 04:33 | |
*** pcaruana has quit IRC | 04:39 | |
*** sheel has joined #openstack-swift | 05:04 | |
*** dmorita has joined #openstack-swift | 05:27 | |
*** ChubYann has quit IRC | 05:29 | |
*** dmorita has quit IRC | 05:31 | |
*** garthb has quit IRC | 05:47 | |
*** klrmn has quit IRC | 05:56 | |
*** rcernin has joined #openstack-swift | 06:11 | |
*** pcaruana has joined #openstack-swift | 06:16 | |
*** suyash has quit IRC | 06:17 | |
*** openstackgerrit has quit IRC | 06:48 | |
*** openstackgerrit has joined #openstack-swift | 06:48 | |
*** ppai has quit IRC | 06:54 | |
*** ppai has joined #openstack-swift | 06:54 | |
*** tesseract has joined #openstack-swift | 06:56 | |
*** McMurlock has joined #openstack-swift | 06:59 | |
*** hseipp has joined #openstack-swift | 07:19 | |
*** rledisez has joined #openstack-swift | 07:22 | |
*** hseipp has quit IRC | 07:23 | |
*** dmk0202 has joined #openstack-swift | 07:32 | |
*** hseipp has joined #openstack-swift | 07:33 | |
openstackgerrit | Kota Tsuyuzaki proposed openstack/swift: Avoid docs warning: Duplicate explicit target name https://review.openstack.org/329307 | 07:58 |
kota_ | acoles: the code at patch 328203 looks good to me. | 08:03 |
patchbot | kota_: https://review.openstack.org/#/c/328203/ - swift (feature/crypto-review) - Refactor tests and add tests | 08:03 |
kota_ | acoles: and not sure yet but the patch seems to hit a docs warning comes from same target name (but different hyperlink) | 08:04 |
kota_ | acoles: I pushed my solution here, https://review.openstack.org/329307 it explicitly avoids the warnings in my local but I'm not sure that is ok becuase I don't know yet why 1st patch set didn't hit the warnings. | 08:05 |
kota_ | i hope it could be helpful to maintain the review chain. | 08:05 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/swift: [WIP] Testing latest u-c https://review.openstack.org/318441 | 08:10 |
*** mvk has quit IRC | 08:24 | |
*** admin6 has joined #openstack-swift | 08:33 | |
*** mvk has joined #openstack-swift | 08:51 | |
*** acoles_ is now known as acoles | 08:58 | |
*** Shashikant86 has joined #openstack-swift | 08:59 | |
*** ouchkernel has quit IRC | 09:04 | |
*** ouchkernel has joined #openstack-swift | 09:06 | |
acoles | kota_: I cannot see why the docs gate job failed on patch 328203, the in process func tests also job failed but no tests show failed in the log ?!? I have seen the duplicate target name warning on master, but it's just a warning. | 09:14 |
patchbot | acoles: https://review.openstack.org/#/c/328203/ - swift (feature/crypto-review) - Refactor tests and add tests | 09:14 |
*** jordanP has joined #openstack-swift | 09:14 | |
acoles | kota_: good that you have found a fix for those warning though! | 09:14 |
kota_ | acoles: it looks like the func test also failed at the doc build. | 09:15 |
kota_ | i'm not sure if that triggers the get failed or not though.... | 09:17 |
kota_ | ah, no. I could be dreaming. | 09:19 |
kota_ | that is not reason why the func test failed. | 09:20 |
kota_ | sorry | 09:20 |
acoles | kota_: heh. I don't think the func tests try to build the docs. I see success reported here, but the gate reports failure, http://logs.openstack.org/03/328203/2/check/gate-swift-tox-func-in-process-fast-post/b37a6b5/console.html#_2016-06-13_17_49_31_331713 | 09:20 |
acoles | kota_: just issued a re-check on that review | 09:20 |
kota_ | yup, let's do this. | 09:21 |
*** Shashikant86 has quit IRC | 09:24 | |
*** manous has joined #openstack-swift | 09:28 | |
*** Shashikant86 has joined #openstack-swift | 09:32 | |
*** manous has quit IRC | 09:33 | |
openstackgerrit | Reedip proposed openstack/swift-bench: Remove support for py33/py26 https://review.openstack.org/264486 | 09:36 |
*** admin6_ has joined #openstack-swift | 09:38 | |
*** admin6 has quit IRC | 09:41 | |
*** admin6_ is now known as admin6 | 09:41 | |
*** mvk has quit IRC | 09:50 | |
*** mvk has joined #openstack-swift | 09:51 | |
*** McMurlock has quit IRC | 09:53 | |
*** McMurlock has joined #openstack-swift | 10:06 | |
*** links has quit IRC | 10:07 | |
*** dmk0202 has quit IRC | 10:08 | |
*** ozeri has joined #openstack-swift | 10:15 | |
*** jmccarthy has quit IRC | 10:18 | |
*** jmccarthy has joined #openstack-swift | 10:19 | |
*** links has joined #openstack-swift | 10:20 | |
*** McMurlock has quit IRC | 10:22 | |
*** dmorita has joined #openstack-swift | 10:28 | |
*** dmorita has quit IRC | 10:32 | |
*** Shashikant86 has quit IRC | 10:42 | |
*** Shashikant86 has joined #openstack-swift | 11:05 | |
*** permalac has quit IRC | 11:09 | |
*** ntt has quit IRC | 11:12 | |
*** sheel has quit IRC | 11:15 | |
*** manous has joined #openstack-swift | 11:16 | |
*** hosanai has quit IRC | 11:20 | |
*** ppai has quit IRC | 11:22 | |
acoles | kota_: all the tests passed on that recheck :) | 11:22 |
kota_ | acoles: nice :) | 11:23 |
*** Shashikant86 has quit IRC | 11:35 | |
*** raildo-afk is now known as raildo | 11:54 | |
*** Shashikant86 has joined #openstack-swift | 11:55 | |
*** kei_yama has quit IRC | 12:10 | |
*** daemontool has joined #openstack-swift | 12:11 | |
*** pauloewerton has joined #openstack-swift | 12:16 | |
*** klamath has joined #openstack-swift | 12:27 | |
*** klamath has quit IRC | 12:28 | |
*** klamath has joined #openstack-swift | 12:29 | |
*** silor has joined #openstack-swift | 12:55 | |
*** ozeri has quit IRC | 13:09 | |
*** diogogmt has joined #openstack-swift | 13:13 | |
*** diogogmt has quit IRC | 13:28 | |
*** Shashikant86 has quit IRC | 13:32 | |
*** Shashikant86 has joined #openstack-swift | 13:34 | |
ahale | i've been playing with some other openstack projects recently - i never really realised how amazing the swift docs are until now | 13:34 |
tdasilva | heh | 13:34 |
tdasilva | i guess it's all a matter of perspective, huh? | 13:34 |
ahale | :) | 13:35 |
*** fifieldt has joined #openstack-swift | 13:47 | |
*** jmccarthy has quit IRC | 13:52 | |
*** jmccarthy has joined #openstack-swift | 13:52 | |
*** Shashikant86 has quit IRC | 13:54 | |
*** cdelatte has joined #openstack-swift | 13:56 | |
acoles | notmyname: thanks for pointing out the public access issue | 14:04 |
acoles | notmyname: we could just uppercase req.method and we'd be safe :P (jk, really) | 14:04 |
acoles | notmyname: jrichli: I am thinking that in several cases the req methods map to the same handler, so we could just hardcode, avoid the decorator, and probably save some lines of code | 14:06 |
acoles | particulalrly in the keymaster | 14:06 |
acoles | I'll link a diff to the gerrit review | 14:07 |
*** links has quit IRC | 14:14 | |
*** bill_az has joined #openstack-swift | 14:22 | |
*** Shashikant86 has joined #openstack-swift | 14:25 | |
*** admin6_ has joined #openstack-swift | 14:27 | |
*** dmorita has joined #openstack-swift | 14:29 | |
*** admin6 has quit IRC | 14:29 | |
*** admin6_ is now known as admin6 | 14:29 | |
*** dmorita has quit IRC | 14:33 | |
*** tanee is now known as tanee_away | 14:37 | |
*** tanee_away is now known as tanee | 14:43 | |
*** bill_az has quit IRC | 14:54 | |
openstackgerrit | David Goetz proposed openstack/swift: Use pre-defined inputs in TestGetHashPrefixAndSuffix https://review.openstack.org/327466 | 14:59 |
*** ukaynar has joined #openstack-swift | 15:04 | |
*** garthb has joined #openstack-swift | 15:05 | |
*** Jeffrey4l has quit IRC | 15:07 | |
*** fifieldt has quit IRC | 15:08 | |
*** ukaynar has quit IRC | 15:08 | |
*** _JZ_ has quit IRC | 15:08 | |
*** rcernin has quit IRC | 15:11 | |
*** ukaynar has joined #openstack-swift | 15:11 | |
*** klrmn has joined #openstack-swift | 15:13 | |
*** psachin has quit IRC | 15:18 | |
*** dmorita has joined #openstack-swift | 15:22 | |
*** tongli has joined #openstack-swift | 15:31 | |
*** permalac has joined #openstack-swift | 15:38 | |
*** _JZ_ has joined #openstack-swift | 15:39 | |
*** delattec has joined #openstack-swift | 15:44 | |
*** manous has quit IRC | 15:45 | |
timburke | good morning | 15:46 |
*** cdelatte has quit IRC | 15:47 | |
*** delattec has quit IRC | 15:51 | |
*** delattec has joined #openstack-swift | 15:53 | |
*** Shashikant86 has quit IRC | 15:58 | |
*** manous has joined #openstack-swift | 15:58 | |
*** hseipp has quit IRC | 16:02 | |
*** permalac has quit IRC | 16:16 | |
*** lyrrad has joined #openstack-swift | 16:22 | |
*** daemontool has quit IRC | 16:28 | |
*** daemontool has joined #openstack-swift | 16:29 | |
*** nadeem has joined #openstack-swift | 16:29 | |
*** ChubYann has joined #openstack-swift | 16:29 | |
*** gyee has joined #openstack-swift | 16:35 | |
*** siva_krish has joined #openstack-swift | 16:38 | |
*** tongli has quit IRC | 16:39 | |
*** daemontool has quit IRC | 16:43 | |
*** tesseract has quit IRC | 16:43 | |
acoles | timburke: good morning. been working through review comments (thanks!). this one: https://review.openstack.org/#/c/328204/2/swift/proxy/controllers/obj.py@350 | 16:43 |
patchbot | acoles: patch 328204 - swift (feature/crypto-review) - Support for http footers - Replication and EC | 16:43 |
acoles | do you mena we could remove the filtering at lines 872 and 2299? | 16:45 |
*** awelleck has joined #openstack-swift | 16:47 | |
*** mvk has quit IRC | 16:47 | |
timburke | acoles: that was my thinking. i must admit, i didn't actually try it to see if anything failed | 16:48 |
timburke | i just don't like how we keep doing the same filtering over and over | 16:48 |
acoles | timburke: I didn't try it yet either, but I think we could, only side effect is the size of the GreenAsyncPile may be larger than necessary if there are failed putters | 16:48 |
*** suyash has joined #openstack-swift | 16:50 | |
timburke | we could still do it as a list comprehension, ahead of instantiating the pile, yeah? | 16:50 |
acoles | timburke: that one definitely seems redundant, which maybe why the 'sanity check' comment crept in | 16:50 |
acoles | timburke: yeah | 16:50 |
acoles | timburke: k, I'll try that | 16:51 |
timburke | yep. i was thinking about asking to have it removed, but then i realized that keeping it there would mean we could drop it from the two callers. if i only have to think about it once, so much the better | 16:52 |
*** jordanP has quit IRC | 16:53 | |
timburke | on the *LO question at https://review.openstack.org/#/c/328203/2/test/functional/tests.py@757, i'll admit it was somewhat rhetorical. i knew the tests wouldn't pass if there were large objects. maybe worth adding a comment stating as much? | 16:54 |
patchbot | timburke: patch 328203 - swift (feature/crypto-review) - Refactor tests and add tests | 16:54 |
timburke | and on the contextmanager idea for test/unit/helpers.py, yeah, it seems like more work than we really want for that patch. i'll add it to my list of things to (maybe) follow up on after the merge | 16:57 |
*** garthb_ has joined #openstack-swift | 16:59 | |
acoles | timburke: hmmm, if I filter the putters list in _get_put_repsonses then it changes the logic here, where AFAICT failed putters are not removed before calling send_commit_confirmation https://github.com/openstack/swift/blob/master/swift/proxy/controllers/obj.py#L2069-L2102 | 17:00 |
*** garthb has quit IRC | 17:00 | |
acoles | timburke: I'm not sure that (on master) makes sense, just making me nervous | 17:00 |
*** siva_krish has left #openstack-swift | 17:01 | |
acoles | i could generate a modified putter list locally to _get_put_responses | 17:01 |
timburke | hmm. maybe better to leave it as is, then. it certainly doesn't seem risky as written (in patchset 2) | 17:02 |
timburke | it just feels vaguely unnecessary (but apparently isn't quite) | 17:03 |
acoles | heh, well I'm not sure what the consequences are of calling send_commit_confirmation on a failed putter :/ | 17:03 |
acoles | and like I said, I think the douplicate filtering must have confused someone (me?) before because of the "sanity check" comment | 17:05 |
torgomatic | if it's failed, then throw it out | 17:08 |
torgomatic | if the object server couldn't persist the object you were sending it, then there's no reason to suspect it can persist a .durable file, nor should it have a bare .durable file | 17:09 |
torgomatic | ...at least, I think so | 17:09 |
*** garthb_ has quit IRC | 17:10 | |
*** garthb_ has joined #openstack-swift | 17:10 | |
*** mvk has joined #openstack-swift | 17:18 | |
*** klrmn has quit IRC | 17:25 | |
*** klrmn has joined #openstack-swift | 17:25 | |
*** rledisez has quit IRC | 17:29 | |
*** tqtran has joined #openstack-swift | 17:32 | |
timburke | oh, acoles, fyi: looks like the topics got a little messed up; *-0 became *-1 and *-1 became *-2, so there are two *-2s | 17:53 |
acoles | torgomatic: makes sense | 17:54 |
acoles | timburke: ack, i screwed up pushing the chain yesterday so I guess my script got the topic numbering wrong, and then when fixed some of the patches would not have changed therefore gerrit would have rejected another push :( | 17:56 |
timburke | i kinda figured. it doesn't matter too much; i'm starting to get used to the gerrit UI (backwards though it seems). like i said, more of an fyi | 17:58 |
*** dmorita has quit IRC | 18:01 | |
acoles | timburke: at least the review numbers are sequential. I did consider deliberately changing something in every patches commit message every time I push the chain so that they'd all get a fresh version in lock-step, but felt that could cause reviewers to shout at me 'wait, what changed...nothing?' :) | 18:01 |
acoles | s/patches/patch's/ argh, I'm getting really bad with grammar mistakes | 18:01 |
*** dmorita has joined #openstack-swift | 18:02 | |
*** manous has quit IRC | 18:04 | |
acoles | ok, slow progress today so I won't be pushing any changes to crypto-review until tomorrow, but keep those reviews coming! | 18:06 |
acoles | timburke: cschwede: kota_ jrichli notmyname ^^ | 18:07 |
acoles | jrichli: notmyname: let me know which way your prefer to go on patch 328208 | 18:08 |
patchbot | acoles: https://review.openstack.org/#/c/328208/ - swift (feature/crypto-review) - Enable object body and metadata encryption | 18:08 |
jrichli | acoles: ok, will take a look. have a good night! | 18:08 |
*** dmk0202 has joined #openstack-swift | 18:09 | |
*** acoles is now known as acoles_ | 18:10 | |
*** dmorita has quit IRC | 18:12 | |
*** mvk_ has joined #openstack-swift | 18:14 | |
*** mvk has quit IRC | 18:17 | |
*** manous has joined #openstack-swift | 18:17 | |
*** dmorita has joined #openstack-swift | 18:21 | |
*** dmk0202 has quit IRC | 18:30 | |
*** siva_krish has joined #openstack-swift | 18:43 | |
*** lifeless has quit IRC | 18:46 | |
*** lifeless has joined #openstack-swift | 18:47 | |
*** manous has quit IRC | 19:03 | |
*** dmorita has quit IRC | 19:04 | |
*** dmorita has joined #openstack-swift | 19:04 | |
*** dmorita has quit IRC | 19:04 | |
*** dmorita has joined #openstack-swift | 19:05 | |
*** dmk0202 has joined #openstack-swift | 19:05 | |
*** dmorita has quit IRC | 19:16 | |
*** manous has joined #openstack-swift | 19:16 | |
*** dmorita has joined #openstack-swift | 19:24 | |
*** ukaynar has quit IRC | 19:27 | |
*** dmorita has quit IRC | 19:30 | |
*** dmorita has joined #openstack-swift | 19:31 | |
*** dmorita has quit IRC | 19:36 | |
openstackgerrit | Merged openstack/python-swiftclient: Query string functionality for containers https://review.openstack.org/283815 | 19:36 |
*** gyee has quit IRC | 19:36 | |
openstackgerrit | Merged openstack/swift: Use pre-defined inputs in TestGetHashPrefixAndSuffix https://review.openstack.org/327466 | 19:41 |
*** ukaynar has joined #openstack-swift | 19:44 | |
*** delattec has quit IRC | 19:45 | |
*** ouchkernel has quit IRC | 19:53 | |
*** ouchkernel has joined #openstack-swift | 19:59 | |
*** dmorita has joined #openstack-swift | 20:09 | |
*** cdelatte has joined #openstack-swift | 20:12 | |
*** silor has quit IRC | 20:18 | |
*** dmk0202 has quit IRC | 20:26 | |
*** dmk0202 has joined #openstack-swift | 20:26 | |
*** diogogmt has joined #openstack-swift | 20:27 | |
*** dmk0202 has quit IRC | 20:33 | |
*** awelleck has left #openstack-swift | 20:37 | |
*** mkrcmari__ has joined #openstack-swift | 20:39 | |
*** mvk_ has quit IRC | 20:43 | |
*** diogogmt has quit IRC | 20:43 | |
*** mvk_ has joined #openstack-swift | 20:45 | |
*** raildo is now known as raildo-afk | 20:47 | |
*** diogogmt has joined #openstack-swift | 20:48 | |
*** manous has quit IRC | 20:48 | |
*** mkrcmari__ has quit IRC | 20:48 | |
*** ukaynar has quit IRC | 20:54 | |
*** ukaynar has joined #openstack-swift | 20:58 | |
*** mvk has joined #openstack-swift | 20:58 | |
*** mvk_ has quit IRC | 20:59 | |
*** darrenc is now known as darrenc_afk | 21:03 | |
*** gyee has joined #openstack-swift | 21:06 | |
*** Raymii has quit IRC | 21:08 | |
*** ukaynar has quit IRC | 21:10 | |
*** ukaynar_ has joined #openstack-swift | 21:10 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-swiftclient: Updated from global requirements https://review.openstack.org/89250 | 21:10 |
*** pauloewerton has quit IRC | 21:11 | |
*** Raymii has joined #openstack-swift | 21:13 | |
notmyname | hello world. finally online today | 21:31 |
notmyname | acoles_: I didn't see a linked diff as an alternative (but it's entirely likely gerrit was helpful and made it hard to find?) | 21:32 |
*** siva_krish has quit IRC | 21:35 | |
*** siva_krish has joined #openstack-swift | 21:36 | |
*** cdelatte has quit IRC | 21:39 | |
*** sileht has quit IRC | 21:51 | |
*** sileht has joined #openstack-swift | 21:52 | |
*** darrenc_afk is now known as darrenc | 21:54 | |
*** siva_krish has quit IRC | 22:02 | |
*** nadeem has quit IRC | 22:03 | |
*** mmcardle1 has quit IRC | 22:11 | |
*** openstackstatus has quit IRC | 22:25 | |
*** openstack has joined #openstack-swift | 22:27 | |
*** openstackstatus has joined #openstack-swift | 22:27 | |
*** ChanServ sets mode: +v openstackstatus | 22:27 | |
*** rcernin has joined #openstack-swift | 22:28 | |
*** catintheroof has quit IRC | 22:30 | |
*** ukaynar_ has quit IRC | 22:35 | |
*** furlongm_ has joined #openstack-swift | 22:37 | |
*** furlongm has quit IRC | 22:37 | |
*** mvk_ has joined #openstack-swift | 22:58 | |
*** mvk has quit IRC | 23:01 | |
*** mathiasb has quit IRC | 23:06 | |
openstackgerrit | Samuel Merritt proposed openstack/swift: Catch AttributeError less often https://review.openstack.org/329713 | 23:12 |
*** mathiasb has joined #openstack-swift | 23:14 | |
*** kei_yama has joined #openstack-swift | 23:26 | |
*** Jeffrey4l has joined #openstack-swift | 23:29 | |
*** rcernin has quit IRC | 23:40 | |
*** hosanai has joined #openstack-swift | 23:46 | |
*** ChanServ sets mode: +v hosanai | 23:46 | |
*** ukaynar has joined #openstack-swift | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!