Monday, 2015-03-23

*** echevemaster has joined #openstack-swift00:02
*** ho has joined #openstack-swift00:13
*** bkopilov has quit IRC00:24
hogood morining!00:24
mattoliverauho morning00:28
*** bkopilov has joined #openstack-swift00:29
homattoliverau: morning00:29
*** bkopilov has quit IRC00:48
*** bkopilov has joined #openstack-swift00:54
*** fbo has quit IRC01:16
*** fbo has joined #openstack-swift01:17
*** panbalag has joined #openstack-swift01:27
*** bkopilov has quit IRC01:40
*** Guest____ has joined #openstack-swift02:02
*** kota_ has joined #openstack-swift02:05
*** Guest____ has quit IRC02:06
*** Guest____ has joined #openstack-swift02:08
*** Guest____ has quit IRC02:13
*** panbalag has quit IRC02:14
*** jrichli has quit IRC02:16
*** Gu_______ has joined #openstack-swift02:19
pelusemattoliverau, awesome thanks.  Just made the suggested change, yeah very cool.  Plus I found another typo in a comment, good lord I'm falling apart02:25
mattoliveraulol02:25
openstackgerritpaul luse proposed openstack/swift: Make get_dev_path() treat mount_check literally...  https://review.openstack.org/16630702:26
mattoliveraupeluse: cool, once you've uploaded the new patchset I'll go check it out and +2 it (hopefully) :)02:26
mattoliverauand there it is, lol02:26
pelusegood timing :)02:26
*** haomaiwang has joined #openstack-swift02:46
openstackgerritHisashi Osanai proposed openstack/swift: Clarify the description of backward compatibility in Keystoneauth's docstring  https://review.openstack.org/16668103:15
*** bkopilov has joined #openstack-swift03:46
*** kbee has joined #openstack-swift03:56
openstackgerritJohn Dickinson proposed openstack/swift: EC: support single ranges for GET requests  https://review.openstack.org/16362004:20
notmynametorgomatic: my change is to update the functional tests to include the values I was seeing on Friday that initially revealed the issue. https://review.openstack.org/#/c/163620/5/test/functional/tests.py04:21
notmynamealso, I can't see anything that's not awesome about a one-liner that's written as a 25-line-nested-tertiary-statements-with-comments-too statement ;-)04:24
*** bkopilov has quit IRC04:25
*** bkopilov has joined #openstack-swift04:28
*** echevemaster has quit IRC04:47
notmynametorgomatic: I'm still seeing a functional test fail in test_slo_ranged_submanifest() with a 416. but that's the only range functional test that fails04:48
openstackgerritHisashi Osanai proposed openstack/swift: Refactor the getting roles logic in _keystone_identity  https://review.openstack.org/16669605:01
notmynameah, there's another one. test_object.py:test_manifest05:04
*** pcaruana has quit IRC05:07
*** ppai has joined #openstack-swift05:30
*** bkopilov has quit IRC05:33
*** bkopilov has joined #openstack-swift05:34
*** Sandeep has joined #openstack-swift05:36
Sandeephi05:36
*** Sandeep is now known as Guest2100505:36
Guest21005hi05:37
*** Guest21005 has left #openstack-swift05:37
notmynamehi. and bye05:37
*** bishtsanddev has joined #openstack-swift05:38
bishtsanddevhi05:39
notmynamehi again05:39
bishtsanddevhi notmyname05:41
bishtsanddevis this possible in to migrate objects from one devstack to another05:42
bishtsanddev?05:42
notmynameisn't devstack for a dev environment? ie why do you need to keep the data?05:43
notmynamebut to answer the question...yes, probably, with a read from one and a write to another05:43
* notmyname doesn't use devstack05:43
bishtsanddevi am thinking of geo redundancy modal Object migration from one cloud to another (what you prefer for Openstack development)05:44
bishtsanddev?05:44
notmynameSwift supports geographically disperse clusters. see https://swiftstack.com/blog/2013/07/02/swift-1-9-0-release/ from201305:46
bishtsanddevi am interested in contributing to openstack-Could you please guide me on this05:47
notmynamebishtsanddev: openstack is a huge and diverse collection of different source code repos and teams of people. do you have a particular area of interest?05:48
bishtsanddevneutron / Swift05:49
bishtsanddevSDN-NFV05:49
*** bkopilov has quit IRC05:50
notmynamesdn/nfv, of course, would be in the realm of neutron (instead of swift). for that, you should check out #openstack-neutron (I think)05:51
notmynamebut if you're interested in object storage, swift is great, and this is the right place :-)05:51
bishtsanddevYes i am interested in it05:52
bishtsanddevI am focusing in these two area05:53
bishtsanddevPlease guide me for swift development05:54
notmynamebishtsanddev: right now in swift we're busy with a final push to a major feature. we're working on getting erasure codes supported (in addition to replicated storage). this week is a big push to get the last stuff done (then we've got some integration work). you can see the channel topic message for some info05:54
notmynamebishtsanddev: but, for general stuff, definitely check out https://swiftstack.com/blog/2013/02/12/swift-for-new-contributors/ and https://wiki.openstack.org/wiki/Swift/ideas and https://bugs.launchpad.net/swift/+bugs05:55
notmynamebishtsanddev: and we have weekly meeings in #openstack-meeting on wednesdays at 1900UTC05:56
notmynamemeetings agendas are tracked at https://wiki.openstack.org/wiki/Meetings/Swift05:58
bishtsanddevGreat i will join that, first few week i need to learn Openstack-swift05:58
notmynamebishtsanddev: http://swift.openstack.org and https://swiftstack.com/openstack-swift/ are two places for high-level understanding of how swift works and what it does05:59
bishtsanddevcurrently in home i have MAC with 4gb ram, its enough for development purpose06:00
bishtsanddev?06:00
bishtsanddevor i have to purchase some high configuration PC (BOTH Development of Swift and Testing)06:01
notmynamehttp://docs.openstack.org/developer/swift/development_saio.html06:02
*** bkopilov has joined #openstack-swift06:03
*** ktsuyuzaki has joined #openstack-swift06:04
*** Gu_______ has quit IRC06:04
bishtsanddevIs there any way to contact you offline (mean) mail?06:05
*** kota_ has quit IRC06:05
*** kota_ has joined #openstack-swift06:08
notmynamebishtsanddev: the best way, if you're not on IRC, is to use the openstack-dev mailing list06:09
notmynamelists.openstack.org06:10
*** ktsuyuzaki has quit IRC06:10
bishtsanddevi am in maling list...Thanks06:12
bishtsanddevone more question- Requirement to join meeting06:13
bishtsanddev?06:13
bishtsanddevits Chat based meeting or Confrence ?06:13
notmynameit's in irc06:13
bishtsanddevTHanks06:13
bishtsanddevThanks what is your exactly name.....My Mom said ....say thanks with name :)06:14
notmynameheh. in here I'm notmyname. otherwise, http://not.mn06:15
bishtsanddevThanks John Dickinson. Nice Talking too you...06:16
*** ktsuyuzaki has joined #openstack-swift06:19
*** bishtsanddev has quit IRC06:20
*** kota_ has quit IRC06:21
*** kota_ has joined #openstack-swift06:24
*** ktsuyuzaki has quit IRC06:25
*** ktsuyuzaki has joined #openstack-swift06:26
*** jamielennox is now known as jamielennox|away06:28
*** kota_ has quit IRC06:28
*** kota_ has joined #openstack-swift06:29
*** ktsuyuzaki has quit IRC06:31
notmynametorgomatic: I found an issue with DLOs and suffix ranges with the current version of the patch. leaving a comment now06:31
notmyname(and then to bed)06:31
*** bkopilov is now known as bkopilov_wfh06:37
notmynametorgomatic: ok, comment left.06:38
notmynamefor any wanting to take a look at something, EC + zero-byte with a suffix range causes problems (traceback in the logs). https://review.openstack.org/#/c/163620/06:39
notmynameand now it's midnight, so I'll see you tomorrow06:39
hoI'm looking for doc to build a saio with ec. Is there any doc?06:42
*** ppai has quit IRC06:51
openstackgerritMerged openstack/swift: Fix typo in swift/test/unit/account/test_backend.py  https://review.openstack.org/16642106:53
*** ppai has joined #openstack-swift06:57
*** pcaruana has joined #openstack-swift06:58
*** nshaikh has joined #openstack-swift06:59
*** Bsony has joined #openstack-swift06:59
*** silor has joined #openstack-swift07:00
*** wer has quit IRC07:01
*** wer has joined #openstack-swift07:03
*** ttrumm has joined #openstack-swift07:34
*** ppai has quit IRC07:35
*** bkopilov_wfh has quit IRC07:37
*** bkopilov_wfh has joined #openstack-swift07:44
*** ppai has joined #openstack-swift07:47
*** bkopilov has joined #openstack-swift07:51
*** bkopilov_wfh has quit IRC07:52
*** chlong has quit IRC07:58
*** bkopilov has quit IRC08:19
*** jordanP has joined #openstack-swift08:21
*** mmcardle has quit IRC08:28
*** geaaru has joined #openstack-swift08:32
*** mmcardle has joined #openstack-swift08:34
*** SkyRocknRoll has joined #openstack-swift08:40
*** SkyRocknRoll has joined #openstack-swift08:40
*** ppai has quit IRC08:53
*** joeljwright has joined #openstack-swift08:57
*** jistr has joined #openstack-swift09:02
*** ondergetekende_ has quit IRC09:03
*** ppai has joined #openstack-swift09:07
*** jordanP has quit IRC09:27
*** kota_ has quit IRC09:27
*** tab___ has joined #openstack-swift09:28
*** jordanP has joined #openstack-swift09:28
*** ho has quit IRC09:44
openstackgerritKota Tsuyuzaki proposed openstack/swift: Small ec diskfile refactor  https://review.openstack.org/16675409:46
*** kota_ has joined #openstack-swift09:47
*** ktsuyuzaki has joined #openstack-swift09:52
*** kota_ has quit IRC09:54
*** kota_ has joined #openstack-swift09:54
*** ktsuyuzaki has quit IRC09:57
*** ktsuyuzaki has joined #openstack-swift09:57
*** kota_ has quit IRC09:59
*** kota_ has joined #openstack-swift09:59
*** ktsuyuzaki has quit IRC10:01
*** ktsuyuzaki has joined #openstack-swift10:02
*** kota_ has quit IRC10:04
*** kota_ has joined #openstack-swift10:05
*** ktsuyuzaki has quit IRC10:06
*** ktsuyuzaki has joined #openstack-swift10:07
*** kota_ has quit IRC10:09
*** kota_ has joined #openstack-swift10:10
*** ktsuyuzaki has quit IRC10:12
*** ktsuyuza_ has joined #openstack-swift10:12
*** ppai has quit IRC10:13
*** ondergetekende has joined #openstack-swift10:13
*** kota_ has quit IRC10:14
*** kota_ has joined #openstack-swift10:17
*** ktsuyuza_ has quit IRC10:18
*** ktsuyuzaki has joined #openstack-swift10:21
*** kota_ has quit IRC10:23
*** ktsuyuzaki has quit IRC10:26
*** ppai has joined #openstack-swift10:27
*** nottrobin is now known as nottrobi10:29
*** nottrobi is now known as nottrobin10:29
*** haomaiwang has quit IRC10:38
*** SkyRocknRoll has quit IRC10:41
*** bkopilov has joined #openstack-swift10:44
*** panbalag has joined #openstack-swift10:45
*** panbalag has quit IRC10:45
*** panbalag has joined #openstack-swift10:46
*** ttrumm has quit IRC10:53
*** kbee has quit IRC10:55
*** Bsony_ has joined #openstack-swift11:00
*** kota_ has joined #openstack-swift11:02
*** ppai has quit IRC11:02
*** Bsony has quit IRC11:04
*** silor has quit IRC11:13
*** ppai has joined #openstack-swift11:16
*** zul has joined #openstack-swift11:32
*** bkopilov has quit IRC11:34
*** bkopilov has joined #openstack-swift11:34
*** nshaikh has quit IRC11:39
openstackgerritLorcan Browne proposed openstack/swift: Add swift-recon feature to track swift-drive-audit error count  https://review.openstack.org/16388911:46
*** ppai has quit IRC11:49
*** ppai has joined #openstack-swift12:03
chmouelclayg: yeah it's the thing i wrote some time ago (cloudfs) and guys from memset took over and made it basically working12:18
*** bkopilov has quit IRC12:19
*** kota_ has quit IRC12:21
*** jrichli has joined #openstack-swift12:41
*** bkopilov has joined #openstack-swift12:45
openstackgerritMerged openstack/swift: Test swift-object-info opens meta and ts files  https://review.openstack.org/16539512:50
*** silor has joined #openstack-swift12:51
openstackgerritMerged openstack/swift: Per-policy DiskFile classes  https://review.openstack.org/16512512:51
*** Bsony has joined #openstack-swift13:01
*** ppai has quit IRC13:03
*** Bsony_ has quit IRC13:04
tab___one quick question. Having 12 disk node. how much CPU cores would you recommend within swift set-up to have on such system for expecting for example write throughput of just about 3-4 MB/s, i gess no big demands. Typical HP DL380 has for example 2xCPU, each for example with 6 cores. Since there will also be some other high demand appliaction on this system, would 2 cores be enough for Swift to process such a demand?,13:04
*** annegentle has joined #openstack-swift13:16
*** bkopilov has quit IRC13:32
*** cdelatte has quit IRC13:32
*** delattec has quit IRC13:32
*** bkopilov has joined #openstack-swift13:33
*** bkopilov has quit IRC13:39
*** bkopilov has joined #openstack-swift13:42
*** acoles_away is now known as acoles13:52
tdasilvadencaval: hi!, I was just reading your comment on patch 156825, but i'm not sure I understand what you mean13:58
patchbottdasilva: https://review.openstack.org/#/c/156825/13:58
openstackgerritMartin Kletzander proposed openstack/swift: Fix common misspellings  https://review.openstack.org/16684314:00
dencavaltdasilva hm, It's just an idea to have the policy object created early instead at _store_object14:01
tdasilvadencaval: oh I see...I think the idea is that everything in the PUT method itself is more like req validation and some API handling, and in _store_object is where data gets transferred to the backend storage nodes, so I think that's where policy would come into play, what do you think?14:04
*** bkopilov has quit IRC14:04
*** mragupat has joined #openstack-swift14:08
dencavaldasilva hm, I do not know yet if some req validation could take some different decision according to the policy, but It could be easy to do if policy is available14:09
*** Gue______ has joined #openstack-swift14:11
*** acoles is now known as acoles_away14:17
*** PeterTr7 has joined #openstack-swift14:17
PeterTr7Hi, is anyone familiar with Python-swiftclient? I have a feature I was wondering if I should build out myself or potentially contribute14:20
*** kallebe has joined #openstack-swift14:20
tdasilvadencaval: yeah, at least in the ec code so far, it was not needed, but if that comes up, we could change it later...my 2 cents :-)14:22
*** bkopilov has joined #openstack-swift14:22
*** lpabon has joined #openstack-swift14:26
*** petertr7_ has joined #openstack-swift14:27
*** annegentle has quit IRC14:29
*** annegentle has joined #openstack-swift14:34
*** annegentle has quit IRC14:34
joeljwrightPeterTr7: If you give more details it might start a discussion14:34
PeterTr7Thank you joeljwright!14:35
*** Fin1te has joined #openstack-swift14:35
joeljwrightPeterTr7: If you're interested in contributing you should take a look here too http://docs.openstack.org/infra/manual/developers.html14:38
PeterTr7Thank you! I'm reading through this and some more getting started documentation14:39
*** mahatic has joined #openstack-swift14:47
PeterTr7I'm interested in creating an "upload continuation" feature for users who upload several TB of data to a Swift cluster via python-swiftclient. In particular, uploading files exceeding the 5gb limit and need to be segmented. The primary use case for this is when a user is tasked with uploading a lot of data and maybe interrupted (disconnected, lunch break, etc). I would like the user to be able to continue the upload of some larg14:48
*** annegentle has joined #openstack-swift14:51
notmynamehttps://metacpan.org/release/MASAKYST/Net-OpenStack-Swift-0.02  <-- anyone know this person?14:51
*** acoles_away is now known as acoles14:56
*** mragupat has quit IRC15:03
*** Fin1te has quit IRC15:06
openstackgerritThiago da Silva proposed openstack/swift: refactor PUT method  https://review.openstack.org/16456115:07
openstackgerritThiago da Silva proposed openstack/swift: Validate the PUT method extraction for EC  https://review.openstack.org/16495015:07
*** kallebe has quit IRC15:29
*** Fin1te has joined #openstack-swift15:31
openstackgerritThiago da Silva proposed openstack/swift: Validate the PUT method extraction for EC  https://review.openstack.org/16495015:36
tdasilvaclayg: ^^^ squashed the two patches to make it easier to review15:38
*** bkopilov has quit IRC15:51
*** Gue______ has quit IRC15:51
*** kallebe has joined #openstack-swift15:53
*** Gue______ has joined #openstack-swift15:54
*** kallebe has left #openstack-swift15:54
*** reed has joined #openstack-swift15:55
*** PeterTr7 has quit IRC15:58
*** petertr7_ is now known as petertr715:58
notmynamegood morning16:04
acolesnotmyname: good morning16:05
notmynamebig week this week16:07
pelusemornin'16:07
*** Bsony has quit IRC16:08
peluseI went though acoles patch chain and +2'd each one.  They all look and work cominbed with the recon which was just tons of fun to switch over :)16:08
acolespeluse: cool, i bet it wasn't 'fun'16:08
acolespeluse: fyi i am mid-review of clayg's patch 15963716:09
patchbotacoles: https://review.openstack.org/#/c/159637/16:09
*** gyee has joined #openstack-swift16:09
peluseIf we can land those today and I can make some progress on ecrecon we should be able to get the PUT refactor in next, any of torgomatics GET range stuff, more ssync tests and then the recon possibly most of those this week16:09
peluseacoles, cool - that one surprised me.  I figured "no way will this work" :)16:10
notmynameand by "this week" you mean by wednesday, right? ;-)16:10
peluseyes, wed16:10
acolespeluse: oh, and re ssync tests, i spent some time over weekend reworking those end-to-end tests i had (to make them way more compact/re-usable i hope) - not quite there yet though16:10
peluseI have spotted time today but almost all day Tue/Wed both16:11
acolesnotmyname: weds? aren't we targetting 27th?16:11
notmynameacoles: ya :-)16:11
acolesnotmyname: you just piling on the pressure there> :)16:11
notmynamepeluse is out for something like "I've been married multiple decades and am going somewhere with my wife" on thursday and friday16:11
notmynameacoles: heh16:12
notmynameacoles: you've got until friday. peluse has to be done by wednesday :-)16:12
peluseyeah, San Fran and Napa!16:12
pelusewill text you Thu eve to see if you want to pop down to thr RickHouse fo a drink with us...16:12
acolespeluse: right! 'hey darling, all the guys from work are coming along to our anniversary dinner...'16:13
notmynamelol16:13
acolespeluse: congrats by the way.16:14
peluseheh - the celebration starts in Napa on Fri.  Thu my sister and her husband are also in town so its more about just having fun and less about the anniverary then.16:14
peluseacoles, thanks :)16:14
acolesnotmyname: peluse : i am in Galway this week, where the team have just moved into a brand new building. I am not sure yet whether my pass will allow me to leave overnight ;)16:16
* notmyname goes to figure out gerrit patch chains16:17
notmynamelooks like just one more +2 needed for https://review.openstack.org/#/c/156825/16:19
pelusenotmyname, yeah I was thinking we should land scoles and claygs MFI patches first since they're a bit more complex then if there are conflicts it'd be easier to deal with them on the PUT refator landing16:20
notmynameok. on master or feature/ec16:21
notmynametdasilva: after that one lands ^ what's the state of the version for feature/ec? pick it up from master? or still work on https://review.openstack.org/#/c/164561/16:21
*** gyee has quit IRC16:21
peluseI'm only talking feature/ec.  shit I was reading the wrong patch16:22
notmynamepeluse: acoles: looks like https://review.openstack.org/#/c/165188/3 is the current start of the reconstructor chain16:22
notmynameis that correct?16:22
peluseI have to take my daughter to a Dr appt but when I get back, if it hasn't already landed, I'll review the master version16:22
notmynamethanks16:22
pelusenotmyname, that one is still outside of the reconstructor16:23
notmynamepeluse: looks like there's a dependency chain there16:23
peluseyeah, I neeed it for sure16:23
pelusebut it can land first w/o screwing anything else up16:23
*** gyee has joined #openstack-swift16:23
notmynameok. that's all I'm looking at. the root of the various patch chains16:24
acolesnotmyname: yes looks like thats now the start of the chain16:24
pelusethe chain all the way up to https://review.openstack.org/#/c/159637/ can land as "pre reconstructor" work16:24
acoleswhy does git review -d for *any* reviewon a chain create the *same* local branch name? :( its so confusing16:24
peluseBTW, acoles my hat is off to you for your work there.  Really, really nice work!16:25
peluseand clayg of course as well16:25
acolesits all clayg16:26
peluseOK, I'm outta here for a few hrs.... back later16:26
notmynameacoles: what's the status of https://review.openstack.org/#/c/162249/16:26
notmynamemarked WIP with a merge conflict and a referenced patch that has landed16:26
acolesnotmyname: abandoned as of 10 seconds ago16:27
notmynamethanks16:27
*** Fin1te has quit IRC16:29
*** tsg_ has joined #openstack-swift16:35
*** zaitcev has joined #openstack-swift16:44
*** ChanServ sets mode: +v zaitcev16:44
*** reed has quit IRC16:45
*** AbyssOne is now known as a1|away16:46
*** reed has joined #openstack-swift16:46
*** Gue______ has quit IRC16:49
*** Gue______ has joined #openstack-swift16:49
*** jordanP has quit IRC16:56
*** annegentle has quit IRC16:59
*** annegentle has joined #openstack-swift17:10
openstackgerritOpenStack Proposal Bot proposed openstack/swift: Updated from global requirements  https://review.openstack.org/8873617:14
*** zhill has joined #openstack-swift17:21
tdasilvanotmyname: I tried to squash 164561 and 164950 and  I think I  got it right (checking now), so I should be able to abandon 164561, so that there's only one refactoring to review in feature/ec.17:22
notmynamethanks17:22
tdasilvanotmyname: I think if patch 156825 lands on master and we merge master to feature/ec, then it will be even easier to review the EC refactor17:24
patchbottdasilva: https://review.openstack.org/#/c/156825/17:24
notmynameright. that's the plan, as I understand it17:24
tdasilvaok, thanks17:24
*** kallebe has joined #openstack-swift17:27
*** annegentle has quit IRC17:37
*** cdelatte has joined #openstack-swift17:39
*** delattec has joined #openstack-swift17:39
*** khivin has quit IRC17:40
*** jest__ has joined #openstack-swift17:44
*** zhill_ has joined #openstack-swift17:51
*** jistr has quit IRC17:54
*** bkopilov has joined #openstack-swift17:55
kallebeHello. Since assertEquals is deprecated for quite some time ( http://bugs.python.org/issue9424 and https://docs.python.org/2/library/unittest.html#deprecated-aliases ), I think it would be good if the tests were refactored to use assertEqual instead of assertEquals. I grep'ed the code and there were 4635 occurences of assertEquals. I am thinking ab17:58
kallebeout doing the replace (simple sed and check the indentation for some cases). However, all this change, if merged, would cause much merge conflict in current change requests. What do you think?17:58
*** bkopilov has quit IRC17:59
*** bkopilov has joined #openstack-swift17:59
*** Fin1te has joined #openstack-swift18:00
kallebeForgot to add that there is already a hacking check about this, but apparently it it nos enabled for swift: https://github.com/openstack-dev/hacking/blob/master/hacking/checks/python23.py#L10618:01
*** sandywalsh_ has joined #openstack-swift18:03
*** sandywalsh has quit IRC18:06
zaitcevI think "Who in the world cares"18:07
kallebeYes, it is not really important, but one day this will have to be done. We don't know how long assertEquals will be compatible18:08
*** bkopilov has quit IRC18:12
zaitcevWe're all hands on deck for EC in Kilo right now. Once that ships in April, then file away, someone will hopefuly waddle through and verify, +2.18:18
tdasilvakallebe: I think there should also be a discussion about enabling the hacking check after you change, otherwise there would be no point in having you make all those changes, just to allow people to go and add assertEquals in new tets...18:27
*** silor has quit IRC18:27
kallebetdasilva yes, I was thinking about this too. I think it will not be worth to do this huge change for now because it will only delay all current patch sets because almost all test files have assertEquals18:29
zaitcevEnabling that goes without saying18:29
tdasilvakallebe: but like zaitcev said, everyone is very focused on the EC work right now, so if you submit a patch it probably won't be looked at for a while. My other suggestion would be that if it makes sense, try to break up into smaller patches (e.,g maybe one for functional tests and another for unit)...just an idea...18:31
zaitcevno, don't mix it18:31
zaitcevalthough a good idea by itself18:32
*** mmcardle has quit IRC18:32
tdasilvadon't mix? or don't break up?18:32
zaitcevdon't do breakup and assertEqual(s) in one patch18:32
zaitcevI'd hate to review that hairball.18:32
lpabonkallebe: i think that is a great idea, i look forward to your patch or patches18:41
claygohai18:46
claygi have a bunch of outstanding code that I don't know how to move forward with - i think i'm spending too much time thinking about the right way to order the diffs for the next week that I'm not focusing on fixing the things that are broken quickly enough18:47
clayge.g. the handoff get node index thing18:48
*** jest__ has quit IRC18:56
peluseclayg, I had some ideas there - what did you have in mind?18:58
peluseclayg, oh, just saw email18:59
*** raginbajin has quit IRC19:04
*** swat30 has quit IRC19:04
*** raginbajin has joined #openstack-swift19:04
*** Dieterbe has quit IRC19:04
*** omame has quit IRC19:04
*** bus-104 has quit IRC19:04
*** Dieterbe has joined #openstack-swift19:04
*** swat30 has joined #openstack-swift19:04
*** bus-104 has joined #openstack-swift19:05
*** geaaru has quit IRC19:05
pelusetsg_, any chance you were able to look into the requiements.txt issue on feature/ec?19:07
*** Gue______ has quit IRC19:08
notmynamepeluse: I can follow up with that one (perhaps after lunch)19:10
notmynamepeluse: for the time being, can you repropose that merge from master without the requirements change? that way we won't be blocked by it19:10
*** Gues_____ has joined #openstack-swift19:10
*** erlon_away has joined #openstack-swift19:10
pelusenotmyname, I can't figure out how to get it removed from the patch19:14
openstackgerritTim Burke proposed openstack/python-swiftclient: Remove all DLO segments on upload of replacement  https://review.openstack.org/16197219:15
openstackgerritJohn Dickinson proposed openstack/swift: Merge master to feature/ec  https://review.openstack.org/16655819:16
notmynamepeluse: there19:16
pelusewell well19:17
notmynamepeluse: well, all I did was use the requeirements.txt from master19:17
notmyname`git checkout master -- requirements.txt`19:17
notmynamepeluse: please validate it. if it works, land it. I'm going to grab some lunch19:18
pelusenotmyname, so yeah I tried that and Jenkins still puked.  I was trying to totally remove it from the patch - that's what I couldn't figure out how to do.19:18
notmynameoh. hmm19:18
pelusehell, maybe I did it wrong :)  we19:18
notmynameya, I'm not sure why it's still showing up19:18
pelusewill see19:18
acolesclayg: i'm reviewing patch 159637, got a question for you19:19
patchbotacoles: https://review.openstack.org/#/c/159637/19:19
claygacoles: sup!19:20
claygthanks for fixing that test bug thing last week or whatever19:20
acolesclayg: i'm trying to convince myself that all the test coverage has been retained :) so here https://review.openstack.org/#/c/159637/20/test/unit/obj/test_diskfile.py line 901-916 in the *base* version19:21
acolesi don't see those two tests translated down to the new test class, but i think the scenarios are covered, correct?19:21
acolesclayg: like, i broke the code and *some* tests still failed19:21
*** dencaval has quit IRC19:21
acolesclayg: so just checking thats part of your plan :)19:22
claygi would have swore the raise unavailable test was in there19:22
claygtest_get_hashes_bad_dev19:22
acolesclayg: oh crap, sorry, wrong lines!!19:22
acoleshang on19:22
*** erlon_away is now known as erlon19:23
claygthen test_get_hashes_create... fine19:23
acolesclayg: line 187 - 19619:23
claygyeah those are probably there too - let's find them19:23
acolesclayg: i think you have just covered in tests on get_hashes?19:23
claygyeah I never tested hash_suffix directly because it's not part of the public interface in any fashion - it should just be an implemenation detail19:24
claygthe interface of when it raises and whatever is a total coupling fuck19:25
acolesclayg: thats what i figured19:25
claygso the assertraises pathnotdir - turned into test_get_hashes_hash_suffix_enotdir probably19:25
claygyeah, then test_get_hashes_hash_suffix_other_oserror19:26
claygi think you're cover19:26
claygd19:26
claygthanks for checking!19:26
acolesclayg: yup makes sense those are tests that failed when i broke the code.19:27
clayglol ;)19:27
claygi guess they were there for that!19:27
acolesclayg: ok i just wanted to be sure it wasn't a cut'n'paste blooper19:27
claygacoles: totally could have happened - i really appreciate you double checking me19:27
acolesclayg: well, my eyes are dropping on those tests, i've been up since 5am (flew over to ireland today), so i'm not sure i'm doing a great job19:30
claygi'll take a sleepy acoles over almost any other review any time!19:30
acolesclayg: lol. so....ECDiskFileManager.invalidate_hash - we don't need it do we?19:31
acolesclayg: like i just deleted it and tests passed ;D19:31
clayghrmmm.....19:32
* acoles feels invalidate_hash is his nemesis19:32
claygit's an exact dupe of the module function right?19:32
acolesyup19:32
claygok sweet - don't need it!19:32
peluseclayg, try deleting some more code and see what happens - you could be on a roll19:32
tdasilvalol, are we also replicating code now?19:33
pelusedata *and* code :)19:33
tdasilva:-)19:33
acolespeluse: clayg: so this is *erasure* coded code yeah, like we can delete pieces and it keeps working?19:33
peluseoh man, don't go there!19:34
tsg_peluse: on the requirements issue on feature/ec, looks like Jenkins still is complaining .. I am looking19:34
acolesclayg: i'm pretty sure i diff'd the two functions and they were the same , i'll double check myself19:34
peluseclayg, if you're going to work on the GET FI thing I'll keep on the ECrecon however if not I'll see if I can nail it here pretty quick - your call chief19:35
pelusepretty sure? heh19:36
*** jest_____ has joined #openstack-swift19:36
claygacoles: I think there were needlessly different - i vaugly remember seeing something in a self review that reminded me I'm stupid19:36
acolesclayg: ah, there is a diff -you took out the os.path.exists(hashes_file) check before lock_partition19:37
claygyeah i don't recall at all why that was a good idea19:37
peluseor why it would be different EC vs repl19:38
claygI think it was a hold over of refctoring out the class things - the whole thing can be dropped most likely19:38
claygacoles: ding me on the review and I'll get it cleaned up19:38
acolesclayg: my guess is that the check is done for early exit before taking the lock, so imho probably best left there19:38
claygI think i'm going to rebase the world by EOB19:38
claygacoles: should probably have a behavior test - like I said, I think i was just copying pauls code into the per policy diskfiles - and the lock was probably ahppening inside of a class call that I replaced19:39
acolesclayg: there were a few totally nit typos i found and fixed locally, you want me to just push over with invalidate_hash gone too? or you prefer i leave it to you?19:40
acolesyeah a test would be good19:40
claygoh, yeah if you've already got a diff going just push - you can make me write the test19:40
acolesk will do19:40
claygwell otoh - just push the typos - the broken code may be useful for the test19:40
claygit's either way19:40
acolesi'll write a test it np19:41
claygoh ptptphthtfhfhhfh - even better :P19:41
acolesbut if it proves tricky i'll give up and go get a beer ;D19:41
openstackgerritpaul luse proposed openstack/swift: Make get_dev_path() treat mount_check literally...  https://review.openstack.org/16630719:43
*** omame has joined #openstack-swift19:46
*** kallebe has left #openstack-swift19:55
*** os1 has joined #openstack-swift19:58
os1Hi19:58
os1Is there any way I could see an updates/specs page in regards to EC?19:58
os1Just out of curiosity.19:59
peluseusre, one sec19:59
*** Gues_____ has quit IRC20:00
pelusewell, maybe like 5 min on the spec page but wrt current WIP see https://trello.com/b/LlvIFIQs/swift-erasure-codes20:00
os1peluse: Thanks.20:03
os1Just out of curiosity, once EC is done, what are the "next big features" that the community plans to work on?20:03
os1It seems like EC was big, in terms of effort and resources involved.20:04
peluseall sorts of good stuff :)  notmyname may chime in, I'm trying to get a few changes to the spec done here before I have to run off to a meeting (yes EC=big)20:04
os1wondering it that's normally the case, or if there is something particular to EC that made it a big accomplishment.20:05
acolesclayg: i can fix that stupid invalidate_hash forwarding method that i put into DiskFileWriter as well20:06
*** tsg_ has quit IRC20:07
*** tsg has joined #openstack-swift20:08
claygacoles: waht do you mean now?20:11
*** annegentle has joined #openstack-swift20:11
claygacoles: I think it's probably worth it in the long run to forward the majority of module methods to the manager - i stopped just sort of read/write_metadata20:11
claygi even forwarded quarantine renamer in one of my dependent patches - but I didn't acctually implement anything better for the ECDiskFileManager20:12
*** Fin1te has quit IRC20:12
claygoh god - i didn't realize we merged the per policy diskfile change already - i need to rebase badly :\20:13
peluseos1, patch coming here in just another minute or two....20:14
acolesclayg: i only mean this http://paste.openstack.org/show/195551/ , still routing to manager, just without the hop through the writer method20:15
claygacoles: yeah that was a good change - i have that in my chain somewhere too - i bit up too much rebasing in this cleanup - cost me too much time and folks (rightfully) moved on without me.20:17
openstackgerritAlistair Coles proposed openstack/swift: Multiple Fragment Archive support for suffix hashes  https://review.openstack.org/15963720:22
acolesclayg: peluse: ^^hope i didn't break it! gotta go find my hotel and food now20:23
openstackgerritpaul luse proposed openstack/swift-specs: Updates to the reconstructor section, quick scrub of everything  https://review.openstack.org/14214620:23
peluseacoles, that sounds enoucraging :)20:24
peluseacoles, off to a meeting.  Will check it out later20:24
peluseos1, once that builds ^^ click on the docs link in there and you'll see the latest20:25
peluseos1, here's the direct link http://docs-draft.openstack.org/46/142146/4/check/gate-swift-specs-docs/6910dcb//doc/build/html/specs/in_progress/erasure_coding.html20:30
*** bkopilov has joined #openstack-swift20:31
*** zhill_ has quit IRC20:32
*** acoles is now known as acoles_away20:35
tdasilvatsg: hi, when was ECPyECLibException removed?20:37
*** tsg has quit IRC20:38
*** Fin1te has joined #openstack-swift20:42
*** lpabon has quit IRC20:49
openstackgerritJohn Dickinson proposed openstack/swift: Merge master to feature/ec  https://review.openstack.org/16700420:50
openstackgerritJanie Richling proposed openstack/swift: Enable middleware to set metadata on object POST  https://review.openstack.org/15840120:53
pelusetdasilva, yeah I think that changed with a recent version of pyeclib20:55
*** mahatic has quit IRC20:56
*** annegentle has quit IRC20:59
*** jamielennox|away is now known as jamielennox21:02
openstackgerritJohn Dickinson proposed openstack/swift: Merge master to feature/ec  https://review.openstack.org/16655821:03
notmynamebah!!21:03
pelusecrazy huh?21:04
notmynamewell, this one might wrok21:04
notmynamemaybe21:04
notmynameso my goal is not to get the proper requirements. just to mark it so that requirements.txt isnt' changed so it doesn't trigger21:05
notmynamethat maybe it's just a diff against the previous commit that matters (ie not against master)21:06
peluseyeah, that's what I gave up on a while ago :)21:06
pelusemight be easier to get the requiements at the right version and have the jenkins issues addressed21:07
torgomaticmutable state is basically the root of all evil21:08
notmynamepeluse: also, I have no idea why pep8 is failing.21:08
mattoliverauMorning21:11
notmynamehi mattoliverau21:11
notmynamehmm... `$ tox -epep8` works on saio, so I'm guessing it might be a side-effect of the requirements shenanigans21:12
torgomaticif I have to fix one more stupid bug caused by this big steaming pile of mutable WSGI environment getting passed back and forth and back and forth all over the place, I'm rewriting the whole thing in Clojure.21:12
mattoliverauBusy week! Let's go!21:12
pelusenotmyname, yeah WFM too21:12
notmynamemattoliverau: typey typey!21:13
mattoliverauLol, perfect use21:13
*** annegentle has joined #openstack-swift21:14
notmynamepeluse: ya, I was hoping to sidestep requirements so it's not a blocker for the merge from master. I don't think it's hard to find the right values for requirements.txt, it's just that the job fails because it doesn't work on the feature branch21:14
pelusenotmyname, we could just do a new patch to manually update feature/ec (w/o using merge)21:17
notmynamepeluse: that sounds terrible ;-)21:17
peluseyeah, I typed before I thought :)21:17
*** Fin1te has quit IRC21:17
os1peluse: Thank you! :)21:18
peluseno problem!21:20
notmynamepeluse: nope. hasn't finished all the checks yet, but the requirements one is still busted21:23
* notmyname takes a journey up the mountain to -infra to see if it can be fixed21:23
*** jrichli has quit IRC21:25
*** joeljwright has quit IRC21:29
notmynamepeluse: clarkb is helping out in -infra21:31
peluseahh cool21:31
notmynamesaying "feature/* should be treated like master" and looking in to what needs to change21:31
*** tsg has joined #openstack-swift21:40
os1What are some "big item" work items, once EC work has been released?21:43
os1coming up21:44
os1Just out of curiosity :)21:45
os1I'm wondering what other items could hold such a high importance as to have almost everybody focus on it, like the case of erasure codes.21:46
os1In the near/far future.21:47
zaitcevI'm going to circle around with PBEs and Thiago is coming with the single-process mode.21:47
zaitcevBut you may be sure that EC will take a year to settled down with its reconstructors, trailers, fragment argives and all other machinery.21:48
zaitcevKilo is merely a beta.21:48
*** joeljwright has joined #openstack-swift21:49
peluse"merely a beta"  ouch!21:49
zaitcevYou know best of all how big a change it is.21:50
pelusebut for sure we all agree its needs exposure/feedback/testing before we can stand behind it as production :)21:50
mattoliverauos1: you can take a look at the swift-specs repo to see some proposed/potential larger changes/additions to swift.21:53
peluseos1, just keep in mind that those are not all approved (so not to be confused with a roadmap or anything)21:54
notmynameos1: that's the fun problem of project management in an open source project. next priority is whatever people in the community work on :-)21:56
pelusethat's the best part!!21:57
notmynameos1: of course, that' a little naive too. in reality, look at the specs repo. look at the ideas wiki page. those are some of the things that have been talked about that people are working on or have talked about21:57
*** Nadeem has joined #openstack-swift21:58
* peluse wonders if notmyname just called him naive...21:58
notmynamenah, it was a response to myself. you just type faster :-)21:58
pelusehey but if the shoe fits....21:59
notmynameIMO it's naive to think there is zero prioritization in the community and it's all "whatever you want to do"21:59
notmynamepeluse: is there anything on the master2ec merge that can't wait until tomorrow? -infra can hack it today if needed, or tomorrow it can be done right22:01
notmynamelooks like tdasilva's patch hasn't landed yet, and that's all I think is on master that's required for ec22:01
pelusenotmyname, yeah it can wait22:02
notmynameok, thanks for confirming22:02
peluseyup, I like the sound of "done right" :)22:02
peluseFYI I'll be looking at the PUT refactor here shorlty as well....22:02
zaitcevI'd like believe that we have certain accountability and/or responsibility to operators. In particular it makes sense for Box to desire for EC, so they help with manpower, and then this makes progress.22:04
jest_____Quick question: let's say that i would want to choose saving data with EC, insted of  3-way replica for saving data with certain amount of robustness. How much more CPU usage I could expect on the system when reading/writing such data in comparison with current Swift mode using replicas?22:19
torgomaticthose two statements are incompatible22:19
torgomatic"quick question" and the rest22:19
notmynamequick answer: "more"22:20
claygsurely you jest22:20
torgomaticno, I'm serious, and don't call me Shirley22:20
torgomaticthat joke doesn't work nearly so well in text, sadly22:20
notmyname"surely you jest_____" FTFY22:21
notmynamejest_____: there isn't an answer to that question. it depends on what EC scheme, what EC library, what workload, what size of data, what hardware, etc22:22
notmynamejest_____: but at this point, all we really know is "EC takes more CPU than replicas". you definitely need to benchmark it (and otherwise test) before using it22:22
notmynamealso, it's not even finished yet, so there's that :-)22:23
jest_____torgomaic, notmyname: ok yes too general question. thank your comments. Maybe than this question, would you rather use EC just for strictly archival solution, Where also read are rare or at least not web-scaled like?22:26
pelusejest_____, so some of that answer will depend on where we wind up w/performance.  EC is pretty popular for archival but it doesn't have to be that way if perf is good enough (or other cahing solutions are added for example to make up for latency)22:27
pelusegood enough for the usage model in question that is....22:28
zaitcevConsider that Microsoft Azure is purely EC based and never had a replication implementation to begin with. If Microsoft's claims are to be trusted, it has more objects than Amazon S3. What's not web-scale about it?22:31
zaitcevIt's manifastly obvious that you can build a RAX-sized cluster with EC, the only small problem is to implement it right.22:31
notmynamezaitcev: any idea if they do a haystack-style scheme with large data slabs?22:31
notmyname"small problem" lol22:32
zaitcevhehe22:32
notmynameit's trivially easy to build AI. the only small problem is typing in the right things22:32
pelusewell, the Azure implementation is a bit more complex than ours...22:33
pelusewe're starting with basic RS, they do all sorts of cool stuff for optimizing perf, minimziing network overhead22:33
openstackgerritSamuel Merritt proposed openstack/swift: EC: support single ranges for GET requests  https://review.openstack.org/16362022:47
*** erlon has quit IRC22:51
*** annegentle has quit IRC22:53
openstackgerritSamuel Merritt proposed openstack/swift: EC: Support If-Match and If-None-Match on GET+HEAD  https://review.openstack.org/16657922:55
*** joeljwright has quit IRC23:13
*** os1 has left #openstack-swift23:17
*** Nadeem has quit IRC23:22
openstackgerritSamuel Merritt proposed openstack/swift: EC: multi-range GET support  https://review.openstack.org/16657623:23
*** jest_____ has quit IRC23:25
*** chlong has joined #openstack-swift23:30
*** dmorita has joined #openstack-swift23:38
*** annegentle has joined #openstack-swift23:41
*** km has joined #openstack-swift23:46
openstackgerritSamuel Merritt proposed openstack/swift: EC: multi-range GET support  https://review.openstack.org/16657623:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!