| openstackgerrit | Merged openstack/storlets: Add some comments about input parameters https://review.openstack.org/275089 | 07:54 |
|---|---|---|
| *** eranrom has joined #openstack-storlets | 08:08 | |
| openstackgerrit | Kota Tsuyuzaki proposed openstack/storlets: Refactor Storlet Handler middleware https://review.openstack.org/275619 | 10:54 |
| kota_ | takashi:^^ | 10:56 |
| *** eranrom has quit IRC | 11:20 | |
| *** takashi has joined #openstack-storlets | 12:45 | |
| *** eranrom has joined #openstack-storlets | 12:50 | |
| eranrom | Hi. Anybody here? | 13:00 |
| takashi | Hi | 13:00 |
| eranrom | Hi Takashi. | 13:01 |
| kota_ | hello | 13:01 |
| eranrom | Hi Kota | 13:01 |
| takashi | eranrom, kota_: Hello | 13:01 |
| eranrom | Thanks very much for all the patches. I still need to have a deeper look at the refactor one. From a first look I really like it. | 13:02 |
| kota_ | eranrom: :-) | 13:02 |
| *** openstackgerrit has quit IRC | 13:02 | |
| eranrom | I am currently working on a copy patch. Need to add unit tests and probably rebase accoring to https://review.openstack.org/275619 | 13:03 |
| *** openstackgerrit has joined #openstack-storlets | 13:03 | |
| eranrom | Not much else from my side. | 13:04 |
| kota_ | looks like patch 275619 faile in functional | 13:04 |
| patchbot | kota_: https://review.openstack.org/#/c/275619/ - storlets - Refactor Storlet Handler middleware | 13:04 |
| kota_ | but build failed??? | 13:05 |
| takashi | I have not so big topics today. | 13:05 |
| takashi | s/have not/don't have/ | 13:05 |
| takashi | fd leak is now fixed, and I'm working about range stuff | 13:05 |
| takashi | but I noticed that I should do that after kota_'s refactoring patch has finished | 13:06 |
| kota_ | thanks guys | 13:06 |
| eranrom | takashi,: alright, so I will try and review asap. | 13:07 |
| kota_ | basically my refactoring depends on trust for takashi's unit tests (takashi, thanks for working that) so i didn't test any functionality on real storlet containers | 13:08 |
| kota_ | so it's helpful if you find any issues in the functional tests | 13:08 |
| kota_ | i hope current failure at the gerrit gate is not related to my change... | 13:09 |
| kota_ | that's note for you all. | 13:09 |
| kota_ | and then | 13:09 |
| takashi | no other topics from me today | 13:11 |
| kota_ | right now, I just did some code cleanup to be readable. However, I found some duplication or doughtful code there. | 13:11 |
| kota_ | I didn't dig them yet and if it's ok I will put them into future work if current code keeps backward compatibility with existing behavior. | 13:12 |
| kota_ | s/i will/i would like to/ | 13:12 |
| takashi | kota_: +1 | 13:12 |
| kota_ | doughtful code is noted by likely "TODO(kota_)" in the code. | 13:13 |
| kota_ | I hope anyone steal the task from me :/ | 13:14 |
| eranrom | sorry got interruption | 13:14 |
| kota_ | eranrom: no worries | 13:15 |
| kota_ | eranrom: oh yeah, I have to say "thanks for working a lot to submit the CFP for austin summit" | 13:15 |
| takashi | kota_: I'm now looking that patch, and I can note some comments about that. | 13:16 |
| eranrom | kota_,: sure | 13:16 |
| kota_ | takashi: cool, feel free to add remaining tasks :) | 13:16 |
| takashi | kota_: Yes :-) | 13:17 |
| kota_ | that's all from me o/ | 13:18 |
| takashi | I'm looking foward to see the result of Austin session selection. Thanks eranrom from me, too. you made a very cool proposal. | 13:20 |
| eranrom | thanks! | 13:20 |
| eranrom | Alright. So let me see if I get it right. | 13:21 |
| eranrom | The plan is to land Kota's refactoring patch | 13:21 |
| eranrom | after which we will land copy / ranges | 13:21 |
| eranrom | right? | 13:21 |
| kota_ | eranrom: that's what I thought :) | 13:22 |
| takashi | eranrom: yes | 13:22 |
| eranrom | alright. | 13:22 |
| eranrom | anything else for today? | 13:22 |
| takashi | nothing from me | 13:23 |
| kota_ | enough \o/ | 13:24 |
| eranrom | good night then | 13:24 |
| eranrom | and thanks for joining | 13:24 |
| takashi | eranrom: thanks | 13:25 |
| *** takashi has quit IRC | 13:36 | |
| *** takashi has joined #openstack-storlets | 20:51 | |
| *** takashi has quit IRC | 21:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!