| *** tristanC has quit IRC | 01:01 | |
| *** tristanC has joined #openstack-stable | 01:01 | |
| *** udesale has joined #openstack-stable | 04:07 | |
| *** e0ne has joined #openstack-stable | 04:27 | |
| *** e0ne has quit IRC | 04:27 | |
| *** pcaruana has joined #openstack-stable | 04:38 | |
| *** e0ne has joined #openstack-stable | 05:04 | |
| *** e0ne has quit IRC | 05:04 | |
| *** skazi has quit IRC | 05:05 | |
| *** e0ne has joined #openstack-stable | 05:08 | |
| *** e0ne has quit IRC | 05:09 | |
| *** skazi has joined #openstack-stable | 05:51 | |
| *** ltomasbo is now known as ltomasbo_meeting | 06:49 | |
| *** ltomasbo_meeting is now known as ltomasbo | 06:49 | |
| *** lajoskatona has joined #openstack-stable | 07:03 | |
| *** rcernin has quit IRC | 07:08 | |
| *** jpich has joined #openstack-stable | 07:57 | |
| *** dtantsur|afk is now known as dtantsur | 08:08 | |
| *** e0ne has joined #openstack-stable | 08:11 | |
| *** e0ne has quit IRC | 08:17 | |
| *** e0ne has joined #openstack-stable | 08:18 | |
| *** e0ne has quit IRC | 08:26 | |
| *** dave-mccowan has joined #openstack-stable | 09:49 | |
| *** udesale has quit IRC | 10:52 | |
| mpeterson | stable team, could you please review the n-odl patches in this dashboard? https://review.openstack.org/#/dashboard/?title=networking-odl+(stable-maintainers)&Pending+(stable/rocky)=project:openstack/networking-odl+branch:stable/rocky+is:open&Pending+(stable/queens)=project:openstack/networking-odl+branch:stable/queens+is:open | 11:07 |
|---|---|---|
| mpeterson | for easier access: https://tiny.cc/n-odl-stable | 11:08 |
| *** zul has joined #openstack-stable | 12:04 | |
| smcginnis | mpeterson: I will try to get to those later today. | 12:57 |
| mpeterson | smcginnis: thanks! I see that yesterday you checked some and you said that they weren't cherry picked properly, do you want us to clarify that so we don't hit any bumps during the reviews? example https://review.openstack.org/#/c/607592/ | 13:02 |
| *** zul has quit IRC | 13:09 | |
| *** udesale has joined #openstack-stable | 13:13 | |
| *** mriedem has joined #openstack-stable | 13:19 | |
| *** udesale has quit IRC | 13:21 | |
| smcginnis | mpeterson: Oh, right. Yes, if these are being backported then they should have the cherry pick information in the commit message (by either doing Cherry Pick through the gerrit UI or git cherry-pick -x on the command line) so that they are tracked appropriately. | 13:28 |
| smcginnis | And if they are not cherry picked, then a message explaining why that could not be done. | 13:29 |
| mpeterson | smcginnis: gotcha. All, except one, were all cherry-picked but since they were done in bulk through rebase -i and then pick the message was not added. Do you want me to go and add it for those missing? I can do it but it will trigger a CI recheck on all patches (and possible false -1 because of timeouts that have been happening lately on the CI) | 13:31 |
| mpeterson | smcginnis: I don't mind to do it, just getting your advise on it | 13:32 |
| smcginnis | mpeterson: Yeah, I hate the gate overhead it will cause, but I think we really should have that in there for later tracking. | 13:33 |
| smcginnis | mriedem: What's your "former stable PTL" opinion on that? ^ | 13:34 |
| mpeterson | smcginnis: something to notice is that Change-Id is still the same though, and they are linked by that too | 13:40 |
| *** mlavalle has joined #openstack-stable | 13:51 | |
| mriedem | smcginnis: link to the series? | 13:53 |
| mpeterson | smcginnis: done, made sure all references are now kept | 13:53 |
| smcginnis | mriedem: It was up at 6:07, but looks like mpeterson got it all. | 13:54 |
| mriedem | ok | 13:54 |
| mpeterson | mriedem: https://review.openstack.org/#/c/604755/7 | 13:54 |
| mriedem | i was up at 3am but went back to bed like a sane person | 13:54 |
| smcginnis | mriedem: Still curious though on your opinion of whether it is worth it to require the cherry-pick in the commit. | 13:54 |
| smcginnis | Been there, done that too many times. | 13:54 |
| mriedem | i think so yes | 13:54 |
| mpeterson | mriedem: I'm giving you the specific revision because all newer revisions have been updated already | 13:54 |
| mriedem | mpeterson: is this stack just making these jobs zuulv3-ified on stable? | 13:56 |
| *** zul has joined #openstack-stable | 13:58 | |
| mpeterson | mriedem: kinda, it's a mix and there are three topics involved. Topic "functional-zullv3" and "remove-fullstack" yes. Topic "bug/1791348" is a backport bugfix | 13:58 |
| *** eharney has joined #openstack-stable | 14:00 | |
| *** mugsie has joined #openstack-stable | 14:14 | |
| mriedem | mpeterson: did you see this https://review.openstack.org/#/c/607535/4//COMMIT_MSG@12 ? | 14:18 |
| *** eharney has quit IRC | 14:18 | |
| mpeterson | mriedem: I did not. Let me take care of that. | 14:21 |
| mpeterson | mriedem: just curious how did you detect there was a merge conflict? | 14:24 |
| mriedem | comparing the cherry pick against the origin i could see the line number difference on that one file | 14:26 |
| mpeterson | mriedem: ah gotcha | 14:26 |
| *** eharney has joined #openstack-stable | 14:33 | |
| mpeterson | mriedem: I added an explanation. | 14:36 |
| mriedem | ack | 14:36 |
| mriedem | mpeterson: ok i've gone through that queens stack; -1 on the final change in the series | 15:00 |
| mpeterson | mriedem: awesome, thanks. I'll take a look at that tomorrow first thing as I have to leave the office now | 15:02 |
| mpeterson | mriedem: thanks a lot for looking at the patches | 15:02 |
| mriedem | yw | 15:02 |
| *** eharney_ has joined #openstack-stable | 15:31 | |
| *** eharney has quit IRC | 15:34 | |
| *** zul has quit IRC | 16:23 | |
| *** jpich has quit IRC | 16:23 | |
| *** mriedem is now known as mriedem_stew | 16:43 | |
| *** eharney_ is now known as eharney | 16:52 | |
| *** dtantsur is now known as dtantsur|afk | 17:08 | |
| *** zul has joined #openstack-stable | 17:20 | |
| *** mriedem_stew is now known as mriedem | 18:31 | |
| *** eharney has quit IRC | 18:53 | |
| *** eharney has joined #openstack-stable | 19:08 | |
| *** pcaruana has quit IRC | 20:37 | |
| *** eharney has quit IRC | 21:05 | |
| *** rcernin has joined #openstack-stable | 22:42 | |
| *** mriedem has quit IRC | 22:57 | |
| *** mlavalle has quit IRC | 23:35 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!