| *** pixelbeat_ has quit IRC | 00:13 | |
| *** dims has joined #openstack-stable | 00:33 | |
| *** dims_ has quit IRC | 00:34 | |
| *** dims has quit IRC | 02:25 | |
| *** dims has joined #openstack-stable | 02:46 | |
| *** dims has quit IRC | 03:14 | |
| *** bswartz has quit IRC | 04:07 | |
| *** armax has joined #openstack-stable | 04:22 | |
| *** bswartz has joined #openstack-stable | 04:23 | |
| *** e0ne has joined #openstack-stable | 07:43 | |
| *** armax has quit IRC | 08:28 | |
| *** dtantsur|afk is now known as dtantsur | 10:28 | |
| *** dims has joined #openstack-stable | 10:47 | |
| *** pixelbeat_ has joined #openstack-stable | 11:49 | |
| *** ihrachys has joined #openstack-stable | 11:55 | |
| *** dtantsur is now known as dtantsur|brb | 13:54 | |
| *** pixelbeat_ has quit IRC | 13:58 | |
| *** dtantsur|brb is now known as dtantsur | 14:44 | |
| *** mriedem_away is now known as mriedem | 14:48 | |
| *** sbadia has left #openstack-stable | 14:56 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:02 | |
| *** eharney has joined #openstack-stable | 15:15 | |
| dtantsur | jroll, I'm not 100% convinced https://review.openstack.org/#/c/249094/ qualifies for a stable backport.. | 16:13 |
|---|---|---|
| dtantsur | any more opinions ^^? | 16:13 |
| mriedem | dtantsur: it's pretty borderline, | 16:17 |
| mriedem | from reading the commit message and bug, it's enabling a callback for someone's out of tree network provider, is that right? | 16:17 |
| mriedem | and by default it does nothing | 16:18 |
| dtantsur | I'd not object if it didn't extend the plugin interface.. | 16:18 |
| dtantsur | mriedem, well, yeah, adds a no-op by default method to the network provider interface | 16:18 |
| mriedem | as ruby points out http://docs.openstack.org/project-team-guide/stable-branches.html#appropriate-fixes | 16:18 |
| mriedem | "The user visible benefit: are we fixing something that users might actually notice and, if so, how important is it?" | 16:19 |
| mriedem | so the only users that are going to get benefit from this are the ones with the out of tree network provider | 16:19 |
| mriedem | that are hooking into it | 16:19 |
| mriedem | idk, i guess i'll defer to jroll who i see already +2'ed, but might want to expand on why | 16:20 |
| dtantsur | my usual concern with extending any plugin interface is that if some another implementation by chance has a method with this name, things are going to get wild :) very unlikely, but not impossible | 16:21 |
| *** armax has joined #openstack-stable | 16:53 | |
| jroll | mriedem: dtantsur: honestly, I didn't think about it extending the plugin interface, you may be right | 16:54 |
| *** ttx has quit IRC | 17:00 | |
| *** ttx has joined #openstack-stable | 17:01 | |
| *** e0ne has quit IRC | 17:11 | |
| *** dims has quit IRC | 17:29 | |
| *** dims has joined #openstack-stable | 17:36 | |
| *** dtantsur is now known as dtantsur|afk | 17:42 | |
| *** e0ne has joined #openstack-stable | 18:05 | |
| *** armax has quit IRC | 18:12 | |
| *** Adri2000 has quit IRC | 18:12 | |
| *** Adri2000 has joined #openstack-stable | 18:13 | |
| *** ihrachys has quit IRC | 18:47 | |
| *** eharney_ has joined #openstack-stable | 19:43 | |
| *** eharney has quit IRC | 19:45 | |
| mriedem | prometheanfire: #openstack-meeting is happening to talk about https://review.openstack.org/#/c/226157/ if you're interetsed | 20:00 |
| mriedem | has to do with upper-constraints and not capping things on stable | 20:00 |
| mriedem | TC meeting i should say | 20:00 |
| *** eharney_ is now known as eharney | 20:01 | |
| prometheanfire | oh | 20:01 |
| *** e0ne has quit IRC | 20:28 | |
| *** eharney has quit IRC | 20:53 | |
| sigmavirus24 | Any thoughts on https://review.openstack.org/#/c/248852/5 ? | 21:41 |
| *** eharney has joined #openstack-stable | 21:56 | |
| prometheanfire | sigmavirus24: hi | 22:02 |
| prometheanfire | looks fine to me, but I don't have much pull here :P | 22:03 |
| *** dims has quit IRC | 22:20 | |
| *** dims has joined #openstack-stable | 22:25 | |
| *** doug-fis_ has joined #openstack-stable | 23:15 | |
| *** doug-fish has quit IRC | 23:17 | |
| *** dims has quit IRC | 23:20 | |
| *** dims has joined #openstack-stable | 23:25 | |
| *** doug-fis_ has quit IRC | 23:25 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:35 | |
| *** mriedem has quit IRC | 23:37 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!