| *** dims has joined #openstack-stable | 00:24 | |
| *** pixelbeat has quit IRC | 01:53 | |
| *** dims has quit IRC | 02:09 | |
| *** dims has joined #openstack-stable | 03:09 | |
| *** dims has quit IRC | 03:16 | |
| *** dims has joined #openstack-stable | 05:13 | |
| *** dims has quit IRC | 05:18 | |
| *** sileht has quit IRC | 05:33 | |
| *** jamielennox is now known as jamielennox|away | 06:12 | |
| *** e0ne has joined #openstack-stable | 06:27 | |
| *** e0ne has quit IRC | 06:34 | |
| *** rajesht has joined #openstack-stable | 06:52 | |
| *** e0ne has joined #openstack-stable | 07:07 | |
| *** e0ne has quit IRC | 07:09 | |
| *** e0ne has joined #openstack-stable | 07:21 | |
| *** ihrachys has joined #openstack-stable | 07:53 | |
| *** ihrachys has quit IRC | 07:56 | |
| *** derekh has joined #openstack-stable | 08:07 | |
| *** pixelbeat has joined #openstack-stable | 08:34 | |
| *** dims has joined #openstack-stable | 09:16 | |
| *** dims has quit IRC | 09:22 | |
| *** dims has joined #openstack-stable | 09:47 | |
| *** apevec has joined #openstack-stable | 10:00 | |
| *** apevec has joined #openstack-stable | 10:00 | |
| jokke_ | Hi guys! | 10:12 |
|---|---|---|
| jokke_ | Anyone willing to have a look on Glance backport for me and give ones opinion. https://review.openstack.org/#/c/226220/ I'm bit puzzled about the potential impact that change has | 10:13 |
| *** ihrachys has joined #openstack-stable | 10:46 | |
| *** jamielennox|away is now known as jamielennox | 10:49 | |
| *** dims_ has joined #openstack-stable | 12:36 | |
| *** dims has quit IRC | 12:40 | |
| *** dims_ has quit IRC | 12:53 | |
| *** dims has joined #openstack-stable | 13:01 | |
| *** mriedem_away is now known as mriedem | 13:07 | |
| *** eharney has quit IRC | 14:06 | |
| mriedem | jokke_: probably b/c it's related to a blueprint and has an APIImpact tag in the commit message | 14:31 |
| mriedem | generally those are big no-no's in stable | 14:31 |
| jokke_ | mriedem: indeed | 14:33 |
| mriedem | as flaper87 pointed out in there though, i don't know why there was a blueprint | 14:33 |
| jokke_ | me neither and I'm not that sure about the api impact either | 14:33 |
| jokke_ | like I mentioned in my comment | 14:33 |
| mriedem | the author was probably confused about rest API vs db API | 14:34 |
| flaper87 | could it be that the master patch was just misled into a spec and the APIImpact not thoroughly considered ? | 14:34 |
| mriedem | which should have all been caught on master | 14:34 |
| mriedem | flaper87: probably | 14:34 |
| mriedem | looks like just a bug fix to me | 14:34 |
| mriedem | the blueprint whiteboard talked about a db migration but apparently that never happened | 14:35 |
| flaper87 | I'm happy to backport this if we clarify my comments and state that clearly in the ocmmit message | 14:35 |
| flaper87 | mriedem: right | 14:35 |
| jokke_ | the db impact is my biggest concern ... would that have been affecting only the broken db engines I would have been perfectly fine to just fix the misleading stuff from the commit message and treat this as bug fix | 14:36 |
| jokke_ | also this is not a new thing and it's surfacing now, so the customer base impacted ain't big | 14:37 |
| mriedem | no it's not, b/c it's a db2 problem | 14:38 |
| mriedem | from the bug report | 14:38 |
| mriedem | DBDuplicateEntry: (IntegrityError) ibm_db_dbi::IntegrityError: Statement Execute Failed: [IBM][CLI Driver][DB2/LINUXX8664] SQL0803N | 14:38 |
| mriedem | that's db2 | 14:38 |
| mriedem | db2 is stricter than mysql/postgres | 14:38 |
| jokke_ | so if that extra query causes potential issues to anyone else, I'm really tempted to not accept that backport and advice them to move to stable/liberty in few weeks time | 14:39 |
| mriedem | so usually there is actually a problem in the schema, but mysql papers over it | 14:39 |
| mriedem | jokke_: well, if you're worried about that you'll just have those same issues in liberty :) | 14:39 |
| jokke_ | and see if there is something in that behavior we need to fix for liberty and avoid needing those changes going to kilo as well | 14:40 |
| mriedem | heh, i see the change just recently merged in liberty | 14:40 |
| mriedem | i figured there was more burn in time for that one | 14:40 |
| mriedem | maybe glance shouldn't be approving blueprints up to the week before rc1 :) | 14:41 |
| jokke_ | mriedem: ^^ is my concern | 14:41 |
| jokke_ | mriedem: I think flaper87 has other plans for next cycle :P | 14:41 |
| mriedem | good | 14:43 |
| *** dims has quit IRC | 15:04 | |
| *** dims__ has joined #openstack-stable | 15:16 | |
| *** apevec has quit IRC | 15:20 | |
| *** eharney has joined #openstack-stable | 15:48 | |
| *** pixelbeat has quit IRC | 16:06 | |
| *** pixelbeat has joined #openstack-stable | 16:10 | |
| *** dims__ has quit IRC | 16:38 | |
| *** dims__ has joined #openstack-stable | 16:39 | |
| *** ihrachys has quit IRC | 16:43 | |
| *** derekh has quit IRC | 16:56 | |
| *** ihrachys has joined #openstack-stable | 17:34 | |
| *** pixelbeat has quit IRC | 17:37 | |
| *** mriedem has quit IRC | 17:38 | |
| *** mriedem has joined #openstack-stable | 17:43 | |
| *** sileht_ has joined #openstack-stable | 17:44 | |
| *** sileht_ is now known as sileht | 17:45 | |
| *** sileht has quit IRC | 17:45 | |
| *** sileht has joined #openstack-stable | 17:46 | |
| *** dims has joined #openstack-stable | 18:00 | |
| *** ihrachys has quit IRC | 18:00 | |
| *** dims__ has quit IRC | 18:02 | |
| *** pixelbeat has joined #openstack-stable | 18:48 | |
| *** e0ne has quit IRC | 18:54 | |
| *** eharney has quit IRC | 18:55 | |
| *** eharney has joined #openstack-stable | 19:01 | |
| *** pixelbeat has quit IRC | 19:16 | |
| *** eharney has quit IRC | 19:32 | |
| *** sileht has quit IRC | 19:39 | |
| *** eharney has joined #openstack-stable | 19:45 | |
| *** sileht has joined #openstack-stable | 19:45 | |
| *** sileht has quit IRC | 19:47 | |
| *** sileht has joined #openstack-stable | 19:48 | |
| *** e0ne has joined #openstack-stable | 20:14 | |
| *** Kiall has quit IRC | 20:27 | |
| *** dims has quit IRC | 20:28 | |
| *** dims has joined #openstack-stable | 20:29 | |
| *** Kiall has joined #openstack-stable | 20:29 | |
| *** pixelbeat has joined #openstack-stable | 20:53 | |
| *** e0ne has quit IRC | 21:38 | |
| *** devlaps has joined #openstack-stable | 21:52 | |
| *** mriedem is now known as mriedem_away | 22:09 | |
| *** mriedem_away has quit IRC | 22:09 | |
| *** dims_ has joined #openstack-stable | 23:19 | |
| *** dims has quit IRC | 23:22 | |
| *** eharney has quit IRC | 23:23 | |
| *** dims_ has quit IRC | 23:31 | |
| *** dims_ has joined #openstack-stable | 23:32 | |
| *** flaper87 has quit IRC | 23:32 | |
| *** flaper87 has joined #openstack-stable | 23:32 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!