| *** chandanc has joined #openstack-sprint | 02:47 | |
| *** chandanc has quit IRC | 05:23 | |
| *** yuikotakadamori has quit IRC | 08:18 | |
| *** hieulq has quit IRC | 09:32 | |
| Zara | storyboard bugsquash time! | 11:00 |
|---|---|---|
| Zara | I know there's little in life more exciting than fixing storyboard bugs | 11:01 |
| Zara | but please, form an orderly queue | 11:01 |
| Zara | for the next 24 hours, I'll be checking on this channel more than I normally do, to answer questions, etc | 11:01 |
| *** pedroalvarez has joined #openstack-sprint | 11:02 | |
| Zara | stories which include tasks that are relatively easy to get started with are listed in this worklist: https://storyboard.openstack.org/#!/worklist/76 | 11:03 |
| Zara | hey pedro | 11:03 |
| pedroalvarez | hi! :) | 11:03 |
| Zara | so for newcomers, some of those stories have a mix of harder and easier tasks, so it's worth asking questions here or in #storyboard if something catches your eye! | 11:03 |
| Zara | I've probably missed a bunch of stuff, so everyone ask as many questions as it takes to get me to make sense. :) | 11:04 |
| Zara | we should be both fixing bugs and marking old bug reports 'invalid', so I may ping around about things | 11:05 |
| Zara | also idk if I'm meant to change this channel topic or something | 11:06 |
| SotK | hi | 11:07 |
| Zara | hi there | 11:14 |
| Zara | READY TO SPRINT | 11:14 |
| Zara | ??? | 11:14 |
| SotK | YEAH | 11:14 |
| Zara | OKAY | 11:14 |
| SotK | well, I'm writing a patch to be able to edit comments | 11:14 |
| SotK | but then I might sprint a bit | 11:15 |
| Zara | :) | 11:15 |
| Zara | I think my sprinting will involve me updating all those old patches I started on ages ago | 11:15 |
| Zara | in general they are bugsquashy patches | 11:16 |
| *** persia has joined #openstack-sprint | 12:02 | |
| Zara | hi persia! | 12:13 |
| Zara | it's quiet in here at the moment; imagine most folks will wake up in a few | 12:14 |
| Zara | for newcomers, things in review live: https://review.openstack.org/#/q/status:open+project:openstack-infra/storyboard , https://review.openstack.org/#/q/status:open+project:openstack-infra/storyboard-webclient and https://review.openstack.org/#/q/status:open+project:openstack-infra/python-storyboardclient,n,z | 12:24 |
| *** rfolco has joined #openstack-sprint | 12:26 | |
| *** ttx has joined #openstack-sprint | 12:39 | |
| ttx | yay storyboard | 12:39 |
| Zara | \o/ | 12:39 |
| Zara | it's a slow sprint at the moment; literally everyone else in the room I'm sitting in has gone to lunch. | 12:40 |
| Zara | at some point I want to go through old stories and ask people how valid they still are, but I think I should wait for more people to wake up for that | 12:41 |
| Zara | in the meantime, https://storyboard.openstack.org/#!/worklist/76 collects some of the stories with smallish tasks | 12:41 |
| ttx | Yeah, I'm pretty busy today, I hope to carve up time to look into some bugs tomorrow morning | 12:41 |
| Zara | :) thank you | 12:42 |
| Zara | the sprint ostensibly continues until 11:00 UTC tomorrow, but we'll be around in #storyboard as usual after that... so it's the same as always for us. | 12:42 |
| ttx | the new timeline looks really good fwiw :) | 12:42 |
| Zara | yes! SotK is the best! :D | 12:43 |
| Zara | SotK ^ | 12:43 |
| Zara | well he's at lunch but he'll see that eventually | 12:44 |
| jroll | \o/ for sprints! | 12:59 |
| SotK | :) | 13:04 |
| Zara | I'm less sprinting and more wandering along, but we'll get there. | 13:07 |
| *** cdelatte has joined #openstack-sprint | 13:57 | |
| *** baoli has joined #openstack-sprint | 13:59 | |
| *** baoli_ has joined #openstack-sprint | 14:00 | |
| *** baoli__ has joined #openstack-sprint | 14:01 | |
| *** baoli has quit IRC | 14:04 | |
| *** baoli_ has quit IRC | 14:05 | |
| Zara | just a note that we're still sprinting away, though all conversation is ongoing in #storyboard because we never got the hang of this here sprint channel thingamibob | 14:28 |
| Zara | I'll post to that effect in here every so often | 14:28 |
| *** anteaya has joined #openstack-sprint | 15:01 | |
| *** yarkot1 has quit IRC | 15:10 | |
| *** yarkot1 has joined #openstack-sprint | 15:11 | |
| fungi | heh, thanks for the heads up | 15:43 |
| fungi | and yeah, i'll echo ttx's sentiments. busy but want to free myself up to do some sb-related stuff later today and tomorrow | 15:44 |
| anteaya | fungi: can you change the channel topic? | 15:52 |
| anteaya | https://wiki.openstack.org/wiki/VirtualSprints#StoryBoard_Bug_Sprint | 15:52 |
| anteaya | https://etherpad.openstack.org/p/June-22-and-23-storyboard-bug-sprint | 15:52 |
| anteaya | so we don't have much in the etherpad yet | 15:53 |
| anteaya | are we just linking to worklists in storyboard? | 15:53 |
| fungi | the wiki section should link to the etherpad or wherever else you're working, so we can have just one url in the topic | 15:53 |
| *** ChanServ changes topic to "StoryBoard Bug Squash! || https://wiki.openstack.org/wiki/VirtualSprints#StoryBoard_Bug_Sprint" | 15:54 | |
| anteaya | fungi: thank you | 15:56 |
| fungi | you're welcome | 15:57 |
| anteaya | okay so regarding the nova bug needs | 16:03 |
| anteaya | thanks for looking at the nova bug etherpad Zara, I had wondered if there was something out there and you already found it | 16:04 |
| anteaya | my plan for approaching marcus from nova was to have the gerrit storyboard integration in place first | 16:04 |
| anteaya | then ask him to try it out and ask if there was any blocking thing preventing nova team from using storyboard | 16:05 |
| anteaya | which is why I hadn't gone digging myself yet | 16:05 |
| anteaya | are there other things on the nova etherpad list that you have started implimenting? | 16:05 |
| anteaya | I ask because I have not looked at the nova bug list | 16:05 |
| anteaya | and part of how I see my role as facilitator is to move things which are not things that are blocking migration and which potentially might cause conflict which we don't need from the lists | 16:06 |
| anteaya | and I don't see this as a migration blocking feature | 16:07 |
| anteaya | but i do foresee a boatload of bikeshedding on it which could bog us down for some time, to no good effect for an adoption decision | 16:07 |
| anteaya | so now with gerrit storyboard integration in place my one and only quesiton is there any functionality missing preventing you from working should we migrate to storyboard right now | 16:09 |
| anteaya | to that end I do see api docs being very important | 16:09 |
| persia | And probably overview docs to set the basic semantics. | 16:11 |
| anteaya | persia: I've started something here if you would care to review: https://review.openstack.org/#/c/325474/ | 16:12 |
| persia | Yep. I should have less travel soon, so I can add to that. | 16:13 |
| anteaya | persia: add to that meaning review it or add to that meaning add a child patch? | 16:13 |
| anteaya | I do want to expand it but haven't gotten any feedback on basic choices like capitlization and use of the :guilabel: syntax | 16:14 |
| persia | I don't know yet :). If it merges before I review, obviously the latter. | 16:14 |
| anteaya | which is why it is as short as it is | 16:14 |
| anteaya | oh well I am looking for reviews at the moment so we can get some agreement on the choices I made for the patch | 16:14 |
| Zara | wow, backscroll! (was afk) | 16:15 |
| Zara | I think that's the first time I've seen the sprint etherpad, I'm fine with people using it or not as they see fit. I've just been linking things in the channel but I can put them there | 16:16 |
| Zara | that's probably better for posterity anyway | 16:16 |
| Zara | oh, nvm, been done | 16:16 |
| Zara | thanks anteaya | 16:16 |
| anteaya | Zara: yes and helps if we get any newcomers as using an etherpad for a sprint is what many other projects do | 16:16 |
| *** baoli__ has quit IRC | 16:16 | |
| anteaya | welcome :) | 16:16 |
| anteaya | I just read the backscroll and copy pasted your links | 16:17 |
| anteaya | back in a minute | 16:17 |
| *** baoli has joined #openstack-sprint | 16:17 | |
| Zara | np, thanks :) | 16:17 |
| Zara | I've already said where i stand on the guide so I don't have much to add yet; still in 'see if it helps people in this bugsquash' mode | 16:18 |
| Zara | I'm also trying to make an effort to actually make stories for annoying things, and tomorrow will see about cleaning outthe old ones | 16:21 |
| Zara | so that worklist should get bigger | 16:21 |
| Zara | in the meantime, if people want details on tasks in stories int eh worklist, etherpad is probably the best place for me to note which are low-hanging-fruit | 16:22 |
| Zara | but it's quite a lot of effort to go through it all | 16:22 |
| Zara | so I'd rather if someone says 'hey, this story looks interesting; which tasks are the small ones?', then I can note them | 16:23 |
| Zara | on a per-story basis | 16:23 |
| anteaya | fair enough | 16:23 |
| anteaya | SotK: what headway if any have you been able to make on expanding teh api documentation | 16:24 |
| Zara | otherwise, it might cut into time that'd be better-spent reviewing or patching or filing stories, and I'm not sure how many people to expect | 16:24 |
| Zara | yaeh | 16:24 |
| Zara | *yeah | 16:24 |
| anteaya | SotK: I would like to help with that | 16:24 |
| Zara | I can't spell, today :) | 16:24 |
| anteaya | Zara: I can't spell any day | 16:24 |
| Zara | well tbf I end up saying that every day | 16:24 |
| SotK | anteaya: none yet :) | 16:24 |
| anteaya | SotK: okey dokey | 16:25 |
| anteaya | SotK: any thoughts on what I can do to be most helpful? | 16:25 |
| anteaya | pleia2: did identify the section on tokens needs to be expanded | 16:25 |
| anteaya | and I do think the api docs need examples | 16:25 |
| anteaya | I don't know how we fit examples in with the way it is generated | 16:25 |
| anteaya | but I do feel we need examples | 16:25 |
| SotK | examples for the endpoints documentation? | 16:26 |
| anteaya | well that would be a start | 16:26 |
| anteaya | examples of any api command our users expect to run | 16:26 |
| anteaya | so far I don't see any examples in the api docs, or are they there and I can't see them | 16:27 |
| SotK | that means the same thing to me | 16:27 |
| * SotK goes to look at wsme's autodoc stuff | 16:27 | |
| Zara | btw, all, SotK is politely helping out, but he is ill, and should really go home and rest at the first opportunity! | 16:28 |
| anteaya | SotK: oh my | 16:29 |
| anteaya | SotK: if you are sick, go home | 16:29 |
| anteaya | SotK: be well | 16:29 |
| anteaya | SotK: there is always tomorrow | 16:29 |
| Zara | it's already half 5 for us, so please encourage him to go to bed already. | 16:29 |
| Zara | yessss | 16:29 |
| anteaya | thanks for your help but go take care of yourself | 16:29 |
| SotK | :) | 16:29 |
| anteaya | SotK: see you tomorrow | 16:29 |
| SotK | I will soon | 16:29 |
| Zara | NIGHT NIGHT SOTK | 16:29 |
| anteaya | drink lots of water and get lots of sleep | 16:29 |
| Zara | he's stubbornly sitting there. I give up. | 16:31 |
| SotK | I suspect the easiest way to provide examples will be to include them in the docstrings of the various methods | 16:32 |
| *** baoli has quit IRC | 16:33 | |
| *** baoli has joined #openstack-sprint | 16:33 | |
| anteaya | SotK: yes, seems that we should just opt to abuse the autodoc feature rather than trying to fight it | 16:33 |
| anteaya | I'm reading http://www.sphinx-doc.org/en/stable/ext/autodoc.html | 16:35 |
| *** baoli has quit IRC | 16:43 | |
| *** baoli has joined #openstack-sprint | 16:44 | |
| anteaya | SotK: I was going to take a try at tokens to start | 16:44 |
| anteaya | SotK: what do you want to start with? | 16:44 |
| Zara | ah, he's gone to catch a tram | 16:51 |
| Zara | he might look back in a bit, but I hope he doesn't. | 16:52 |
| Zara | problem is if I go 'GO HOME YOU ARE ILL' he takes it as a challenge. ¬_¬ | 16:52 |
| anteaya | yeah I know that behaviour | 16:52 |
| anteaya | glad he has gone to find a tram | 16:53 |
| Zara | I mean he will mutter something about free will and how he was going to sit there *anyway* because he had things to do but that's my version and I'm sticking to it. :P | 16:54 |
| anteaya | Zara: :) | 17:02 |
| Zara | I'm leaving for the evening but I'll check back periodically, and maybe even update some stories! | 17:10 |
| anteaya | Zara: thank you | 17:11 |
| anteaya | have a good evening | 17:11 |
| *** zaro has joined #openstack-sprint | 17:26 | |
| pleia2 | o/ zaro | 17:37 |
| *** zara_the_lemur__ has joined #openstack-sprint | 17:51 | |
| pleia2 | zaro: I'm around all day, so just lmk if you need other changes made to get this plugin going | 17:56 |
| anteaya | a patch to expand the api documentation with some examples | 17:58 |
| anteaya | now with link: https://review.openstack.org/#/c/332946/2 | 18:03 |
| pedroalvarez | anteaya: +1 to that idea | 18:14 |
| pleia2 | anteaya: were does this documentation end up? on the api docs? | 18:15 |
| anteaya | pedroalvarez: thank you | 18:15 |
| anteaya | yes | 18:15 |
| pedroalvarez | pleia2: here, I believe: http://docs.openstack.org/infra/storyboard/webapi/v1.html | 18:15 |
| anteaya | if you pull it down in your storyboard clone and run tox -edocs it will appear in file:///home/anita/work/storyboard/doc/build/html/webapi/v1.html | 18:15 |
| anteaya | or your path to file | 18:16 |
| pleia2 | I'll just wait for the docs job to run :) | 18:16 |
| anteaya | pedroalvarez: yeah that's it | 18:16 |
| anteaya | cool | 18:16 |
| pleia2 | tested all the commands and they work, once I see them inline I'll chime in on the review | 18:16 |
| pleia2 | er, rendered | 18:16 |
| anteaya | I'm going to submit a new patch since I need some suggestions on how to address the line wrapping | 18:16 |
| anteaya | for the POST comand | 18:17 |
| anteaya | and yay working commands! | 18:17 |
| anteaya | \o/ | 18:17 |
| pleia2 | pedroalvarez: how to verify the've been generated is to either follow anteaya's instructions above, or to wait for the gate-storyboard-docs job to run and then click on the results of that job to see the rendered documentation | 18:18 |
| pedroalvarez | trying the former currently | 18:19 |
| pleia2 | great | 18:19 |
| *** david-lyle has joined #openstack-sprint | 18:20 | |
| anteaya | phone person at my house, going to have to pay attention to it now | 18:26 |
| anteaya | back in a bit | 18:26 |
| pleia2 | anteaya: gave a wrapping suggestion in the review | 18:28 |
| anteaya | pleia2: awesome thanks | 18:28 |
| anteaya | good news is that my modem can get internet in the house | 18:29 |
| anteaya | now we just have to figure out how to get wires without shorts in them into the office | 18:29 |
| pleia2 | good luck :) | 18:29 |
| anteaya | thanks | 18:30 |
| anteaya | :) | 18:30 |
| zara_the_lemur__ | thanks for working on these. :) I'll look at them first thing tomorrow | 18:35 |
| anteaya | zara_the_lemur__: thank you | 18:48 |
| anteaya | pleia2: the bashisms don't fix the line wrapping in my local build | 18:49 |
| anteaya | I don't understand why some of my additons are not rendered | 18:50 |
| pleia2 | anteaya: can you take a screenshot? | 18:50 |
| anteaya | they are in the docs draft | 18:51 |
| anteaya | under Create a new task, Modify this task and Delete this task I have Example: TODO in the source yet that isn't rendered in the docs-draft | 18:52 |
| pleia2 | ah, that was quick | 18:52 |
| pleia2 | I see, I guess it's trying to be clever | 18:53 |
| anteaya | yeah | 18:53 |
| anteaya | clever doc generation makes me tired | 18:54 |
| pleia2 | and I guess Example: is not a known thing in this doc rendering (like | 18:54 |
| anteaya | any idea how we uncleaver it? | 18:54 |
| pleia2 | Parameters: and Return type:) | 18:54 |
| anteaya | well it does render the example here: http://docs-draft.openstack.org/46/332946/4/check/gate-storyboard-docs/ac73a29//doc/build/html/webapi/v1.html#get--v1-stories--story_id--tasks-(story_id) | 18:54 |
| anteaya | so I would accept your argument if it failed to render all my additions in tasks.py | 18:55 |
| pleia2 | yeah, but no special formatting | 18:55 |
| anteaya | I don't understand what you mean | 18:55 |
| pleia2 | I meant that Parameters: and Return Type: have nice formatting | 18:56 |
| anteaya | oh I don't care about formatting yet | 18:56 |
| anteaya | I just want my additions to be rendered for starters | 18:56 |
| pleia2 | they are related | 18:56 |
| anteaya | they don't appear at all, even with unly formating | 18:56 |
| anteaya | I'm not understanding yet, I'll listen for a bit | 18:56 |
| pleia2 | heh, maybe I'm confused | 18:57 |
| anteaya | why does it render Example: curl https://storyboard.openstack.org/api/v1/stories/11/tasks/2691 | 18:57 |
| anteaya | but not Example: curl https://storyboard.openstack.org/api/v1/stories/11/tasks | 18:57 |
| pleia2 | oh, I was looking at http://docs-draft.openstack.org/46/332946/4/check/gate-storyboard-docs/ac73a29//doc/build/html/webapi/v1.html#post--v1-stories | 18:58 |
| pleia2 | I thought we were still talking about the line wrapping, sorry | 18:58 |
| anteaya | oh sorry | 18:58 |
| pleia2 | is tasks.py included at all when the api docs are rendered? | 18:59 |
| pleia2 | I guess it is | 19:00 |
| anteaya | yeah because it renders that one line out of 5 | 19:02 |
| pleia2 | the console output complains near that line in the file, but it renders the other ones it complains about | 19:04 |
| anteaya | hmmmm | 19:04 |
| anteaya | okay so an issue we need more input on | 19:04 |
| anteaya | let's go back to your point about line wrapping | 19:05 |
| anteaya | and the bashism not showing up | 19:05 |
| pleia2 | finding someone who knows more about how this rendering works would be good | 19:06 |
| anteaya | agreed | 19:11 |
| anteaya | I just submitted another patchset to make pep8 happy | 19:11 |
| anteaya | then once docs render I'll see if Doug Hellman has a moment to take a peek and offer some direction | 19:12 |
| anteaya | and I have internet again! | 19:13 |
| anteaya | woooo | 19:13 |
| anteaya | \o/ | 19:13 |
| pleia2 | yay :) | 19:14 |
| anteaya | :) | 19:15 |
| anteaya | using my phone as a hot spot for multiple hours gives me such a head ache | 19:16 |
| anteaya | I think I'm going to get some food | 19:17 |
| *** baoli has quit IRC | 19:17 | |
| *** baoli has joined #openstack-sprint | 19:18 | |
| anteaya | dhellmann: hello would you have time to look at this docs-draft: http://docs-draft.openstack.org/46/332946/5/check/gate-storyboard-docs/e88d4b6//doc/build/html/webapi/v1.html#stories which is a patch to put some examples in the storyboard api docs: https://review.openstack.org/#/c/332946/5 | 19:33 |
| anteaya | dhellmann: two questions, why are some of my edits not being rendered, for instance this command: curl https://storyboard.openstack.org/api/v1/stories/11/tasks from line 284 of https://review.openstack.org/#/c/332946/5/storyboard/api/v1/tasks.py | 19:34 |
| anteaya | dhellmann: and second question, how should I line wrap the example that starts at line 174 in this file: https://review.openstack.org/#/c/332946/5/storyboard/api/v1/stories.py | 19:35 |
| *** baoli has quit IRC | 19:35 | |
| anteaya | storyboard is using sphinx autodoc: http://www.sphinx-doc.org/en/stable/ext/autodoc.html | 19:35 |
| *** baoli has joined #openstack-sprint | 19:35 | |
| anteaya | http://git.openstack.org/cgit/openstack-infra/storyboard/tree/doc/source/conf.py | 19:36 |
| anteaya | dhellmann: and I don't understand autodoc | 19:36 |
| anteaya | personally I wish it was a lot less clever then I could just edit the docs and get what I wanted, I hope | 19:36 |
| dhellmann | anteaya : looking | 19:38 |
| anteaya | thank you | 19:38 |
| dhellmann | anteaya : literal blocks need to start with a double colon and the literal text needs to be indented. | 19:39 |
| dhellmann | anteaya : I commented on the patch where it's possible to do mult-line | 19:39 |
| anteaya | thank you | 19:39 |
| dhellmann | anteaya : for the multi-line example if you get the literal formatting right you can insert those backslashes and they will show up in the output | 19:40 |
| anteaya | cool, thanks I'll add colons and see what happens | 19:41 |
| anteaya | my gratitude | 19:41 |
| dhellmann | np | 19:41 |
| anteaya | also does the query example help you at all? | 19:41 |
| anteaya | dhellmann: http://docs-draft.openstack.org/46/332946/5/check/gate-storyboard-docs/e88d4b6//doc/build/html/webapi/v1.html#get--v1-stories-search | 19:41 |
| anteaya | is that useful or not useful to you? | 19:41 |
| dhellmann | anteaya : I'm really more interested in being able to do that sort of thing in the UI and bookmark the results than using the API, but if documenting it in the API makes more sense that's a good way to start | 19:42 |
| anteaya | dhellmann: okay good to know, so is that command itself of use or do you need more? | 19:42 |
| dhellmann | anteaya : based on the response on the storyboard story where we were discussing this, I'm not sure storyboard actually does what I want with saved queries specifying the individual fields | 19:42 |
| anteaya | yeah I haven't come across the concept of saved queries myself in my conversations | 19:43 |
| anteaya | so it is possible that currently storyboard doesn't understand that | 19:43 |
| dhellmann | there was something like that that you showed me but it has a different name and it didn't seem to let me query in the ways I expect I'll need to | 19:43 |
| dhellmann | yeah, this may not be a thing they expected anyone to want to do, yet | 19:44 |
| anteaya | that is possible | 19:45 |
| dhellmann | anteaya : I want to replace this spreadsheet using something in storyboard so I can assign the individual tasks we were tracking to the project teams: https://docs.google.com/spreadsheets/d/1BLUDgediqgOzLZMMe8a3EAPOtyINAg2rpMtSyWjhC4o/edit#gid=0 | 19:45 |
| anteaya | you saying you want this is the first I'm hearing of this feature | 19:45 |
| anteaya | right, hmmmm | 19:45 |
| dhellmann | we wouldn't need the contact detail columns in storyboard, necessarily, since we could use the tool itself to contact the owners | 19:45 |
| anteaya | dhellmann: have you time to make a story saying that, then perhaps we can break it down into individual tasks? | 19:45 |
| anteaya | right | 19:46 |
| dhellmann | I think before I can express what I want clearly I need to understand the model storyboard has for tracking stuff a bit better, and that's going to mean me spending time reading documentation and experimenting | 19:46 |
| dhellmann | and I'm not going to have time for that this week, unfortunately | 19:47 |
| dhellmann | the one thing I'll note is that so far it seems like the UI either assumes stories/tasks are associated with an owner or a project, and the views reflect that assumption | 19:47 |
| anteaya | I understand | 19:47 |
| dhellmann | in my case, I want a more global view | 19:47 |
| anteaya | yes, I get that | 19:47 |
| anteaya | the view of all the things | 19:47 |
| anteaya | by the way, gerrit and storyboard can talk to each other now | 19:48 |
| anteaya | that is new | 19:48 |
| dhellmann | ok, just trying to boil down what I think is essentially different about what I'm looking for | 19:48 |
| dhellmann | ok, nice | 19:48 |
| *** cdelatte has quit IRC | 19:48 | |
| dhellmann | so when a patch merges a story status is updated? | 19:48 |
| anteaya | https://storyboard-dev.openstack.org/#!/story/18 | 19:48 |
| anteaya | yeah | 19:48 |
| anteaya | right now we have storyboard-dev and review-dev able to talk to each other | 19:48 |
| anteaya | dhellmann: oh yeah, I'm grateful to hear your thoughts | 19:49 |
| anteaya | and think talking about it a few times will distill it | 19:49 |
| * dhellmann is trying to be helpful and not flail about with vague feature requests | 19:49 | |
| anteaya | happy to keep chatting about this until we find something actionable | 19:49 |
| anteaya | aren't we all | 19:49 |
| anteaya | :) | 19:49 |
| anteaya | and thank you yes | 19:49 |
| anteaya | we are fine with the failing but are grateful at attempts to keep it to a minimum | 19:50 |
| anteaya | or flailing labelled clearly as such | 19:50 |
| anteaya | that's fine too | 19:50 |
| anteaya | flailing and failing | 19:50 |
| anteaya | only one l difference | 19:50 |
| dhellmann | how do I move things between lanes in a board? https://storyboard-dev.openstack.org/?#!/board/1 | 19:51 |
| dhellmann | oh, or maybe one doesn't do that by hand? | 19:52 |
| *** baoli has quit IRC | 19:53 | |
| anteaya | click and drag | 19:53 |
| anteaya | yes you do it by hand | 19:53 |
| SotK | that board's lanes are automatic, which don't yet have any way to be modified by hand | 19:53 |
| *** baoli has joined #openstack-sprint | 19:54 | |
| anteaya | SotK: ah thank you | 19:54 |
| dhellmann | SotK : k, thanks, that's what I thought | 19:54 |
| anteaya | SotK: I wonder if we should have some what of seeing if a board has automatic lanes? | 19:54 |
| anteaya | to prevent user frustration when failing to succeed at click and drag | 19:54 |
| SotK | probably | 19:56 |
| SotK | automatic lanes are darker than manual ones currently, but that isn't hugely helpful in a board which only has one type | 19:56 |
| anteaya | dhellmann: https://storyboard-dev.openstack.org/#!/board/3 | 19:57 |
| SotK | dhellmann: what do you mean by a "more global view" ooi? | 19:57 |
| anteaya | dhellmann: no automatic worklists on that board | 19:57 |
| * SotK goes to look at patches | 19:57 | |
| dhellmann | SotK : my impression is, and this could be wrong, that the storyboard UI assumes I'm either interested in looking at tasks associated with 1 project or assigned to me. To track the end of release work, I need to see specific tasks associated with any project and assigned to people I won't know in advance | 19:58 |
| dhellmann | SotK : I could probably do that with a board with manually managed lanes, but then I (or someone) have to update their state properly as tasks are completed | 19:59 |
| dhellmann | SotK : I'm looking for a way to query for the tasks, maybe via a tag or other characteristic, and then organize them based on whether they are complete or not | 20:00 |
| SotK | dhellmann: Have you had a chance to play with the search page (https://storyboard.openstack.org/#!/search) yet by any chance? | 20:03 |
| SotK | the UI could use some love there, but it allows you to filter tasks and stories | 20:03 |
| anteaya | dhellmann: could you give an example of what you would want to query for? | 20:04 |
| SotK | (typing in the search box on that view will offer suggested filters) | 20:05 |
| SotK | on storyboard stories are tagged (rather than tasks), and currently there is no way to filter tasks by "tags on the story this task is for" | 20:06 |
| SotK | the most annoying part of the search page is that there is no way to bookmark a set of filters | 20:07 |
| SotK | maybe that is the feature most needed here | 20:07 |
| anteaya | possibly? | 20:07 |
| dhellmann | SotK : ok, doing it by story would be fine | 20:11 |
| dhellmann | and yes, being able to bookmark a search would be useful for a lot of cases | 20:11 |
| dhellmann | is there a list of possible filters somewhere? because I haven't had a lot of luck getting it to suggest them for me | 20:11 |
| SotK | aside from finding it in the code, I don't think there is | 20:13 |
| SotK | what happens when you start typing in the box ooi? | 20:14 |
| *** baoli has quit IRC | 20:14 | |
| *** baoli_ has joined #openstack-sprint | 20:14 | |
| anteaya | SotK: what is ooi? | 20:15 |
| pedroalvarez | "out of interest" | 20:16 |
| anteaya | ah thanks | 20:16 |
| pleia2 | anteaya: did you figure out why those lines aren't showing up? | 20:16 |
| anteaya | pleia2: no | 20:16 |
| anteaya | dhellmann: gave me a suggestion which I implemented and pushed but my local build doesn't render the missing bits yet | 20:17 |
| pleia2 | well, hopefully this ps at least can get the multi-line thing sorted | 20:17 |
| dhellmann | SotK : if I happen to type a word that matches something, it offers some suggestions. I think it showed me the option of searching based on a tag even when there were no items with that tag (I typed "any") | 20:17 |
| anteaya | pleia2: since dhellmann and SotK are talking about an issue important to doug I was just waiting until they finished | 20:17 |
| dhellmann | anteaya : what's your patchset again? | 20:17 |
| anteaya | pleia2: it didn't for me locally :( | 20:17 |
| pleia2 | anteaya: yep, that's fine | 20:18 |
| pleia2 | dhellmann: https://review.openstack.org/#/c/332946/ | 20:18 |
| anteaya | https://review.openstack.org/#/c/332946/6 | 20:18 |
| pleia2 | I'm going to see about lunch | 20:18 |
| dhellmann | ok, let me take a look | 20:18 |
| anteaya | dhellmann: thanks | 20:18 |
| anteaya | pleia2: good idea, enjoy lunch | 20:18 |
| anteaya | dhellmann: SotK I confirm https://storyboard-dev.openstack.org/#!/search?q=any | 20:20 |
| anteaya | being able to have a list of tags already in use I think would be really valuable | 20:21 |
| anteaya | SotK: you already have something up about that don't you? | 20:21 |
| SotK | yeah, https://review.openstack.org/#/c/331030/ causes it to only offer tags that exist as suggestions | 20:22 |
| dhellmann | anteaya : try that latest version | 20:23 |
| anteaya | the newline | 20:24 |
| anteaya | it always evades me | 20:24 |
| dhellmann | SotK : if I know the thing I want to search for is a tag, is there a syntax to do that or do I need to type the name and select it from the list? | 20:24 |
| dhellmann | anteaya : also the double backslash, which I should have realized you'd need | 20:24 |
| dhellmann | SotK : a lot of this is really just me figuring out how to use the tool, so I apologize for asking such basic questions | 20:24 |
| SotK | you need to type the name and select it | 20:25 |
| SotK | no problem :) | 20:25 |
| dhellmann | ok, so that'd be another nice thing, if I could say something like tag:"the thing I know is a tag" | 20:25 |
| anteaya | dhellmann: thank you | 20:25 |
| dhellmann | between that and having bookmarkable searches, it would be easier to share views with other people | 20:25 |
| dhellmann | anteaya : np | 20:26 |
| anteaya | dhellmann: you can try the patch for having it only offer tags that exist here: http://docs-draft.openstack.org/30/331030/2/check/gate-storyboard-webclient-js-draft/00c8e70//dist/#!/page/about | 20:26 |
| dhellmann | anteaya : I can't always remember what rst stuff is "rules" and what is adopted style any more. The extra blank line after :: is a case of that | 20:26 |
| anteaya | dhellmann: yep | 20:27 |
| anteaya | dhellmann: if I go to that link and type t in the Jump to... search box | 20:27 |
| dhellmann | I get all sorts of things, nice | 20:28 |
| anteaya | I get four project groups, 5 repos and 5 stories that come up | 20:28 |
| anteaya | dhellmann: are they useful things? | 20:28 |
| dhellmann | this may also be a case of "the UI is smarter than you're used to" | 20:28 |
| anteaya | the icons match the icons on the left | 20:28 |
| dhellmann | it says "what would you like to search by?" and my first thought was "what are my options?" | 20:28 |
| anteaya | yeah, same with the docs generation too | 20:28 |
| anteaya | ha ha ha | 20:28 |
| anteaya | me too | 20:28 |
| dhellmann | magic? telepathy? :-) | 20:28 |
| anteaya | chocolate, vanilla, strawberry | 20:29 |
| anteaya | ha ha ha | 20:29 |
| anteaya | SotK: I do notice your patch suggests groups, repos and stories, but I don't see any tag suggestions | 20:29 |
| anteaya | perhaps storyboard-dev has no tags | 20:30 |
| anteaya | making tags in -dev I get some great errors: 400: GET https://storyboard-dev.openstack.org/api/v1/stories/18/events: Invalid input for field/attribute offset. Value: 'NaN'. unable to convert to int | 20:31 |
| anteaya | but even after making three tags 'aaa' 'bbb' 'ccc' I can't see them in the suggestions using the js-draft interface | 20:32 |
| anteaya | dhellmann: now locally the things that were not showing up are still not showing up for me: https://review.openstack.org/#/c/332946/ | 20:32 |
| anteaya | but lets wait until the docs job finishes | 20:33 |
| dhellmann | anteaya : what line of what file is something that doesn't show up? | 20:33 |
| anteaya | they are all in the tasks.file | 20:35 |
| anteaya | line 283 does not render | 20:35 |
| anteaya | all the edits in the stories file render | 20:36 |
| anteaya | 4 of 5 edits in the tasks file do not | 20:36 |
| dhellmann | hmm, I see the example under "GET /v1/tasks" in my local build | 20:37 |
| anteaya | really | 20:38 |
| anteaya | maybe it will show up in the docs draft | 20:39 |
| *** baoli_ has quit IRC | 20:39 | |
| anteaya | dhellmann: here is the build from patch 7: http://docs-draft.openstack.org/46/332946/7/check/gate-storyboard-docs/3d8639a//doc/build/html/webapi/v1.html#stories | 20:42 |
| anteaya | curl https://storyboard.openstack.org/api/v1/stories/11/tasks isn't rendered | 20:43 |
| dhellmann | hmm | 20:43 |
| anteaya | if it is rendering for you locally, do you have any idea what might be different for your local env and the docs jobs? | 20:43 |
| anteaya | (and my local env?) | 20:43 |
| dhellmann | http://docs-draft.openstack.org/46/332946/7/check/gate-storyboard-docs/3d8639a//doc/build/html/webapi/v1.html#tasks | 20:44 |
| anteaya | and pretty boxes around the example commands, thank you! | 20:44 |
| dhellmann | the link you sent was to the wrong API endpoint | 20:44 |
| anteaya | ah okay thank you | 20:45 |
| anteaya | I am trying to first of all create examples for the stories section of the docs | 20:45 |
| anteaya | I think we again have come up against the generator being too clever | 20:45 |
| anteaya | how do I get the stories section to have examples for every command? http://docs-draft.openstack.org/46/332946/7/check/gate-storyboard-docs/3d8639a//doc/build/html/webapi/v1.html#stories | 20:46 |
| anteaya | and in the tasks section the GET /v1/tasks/(task_id) doesn't have an example because it is showing up in the stories section | 20:47 |
| dhellmann | I'm pretty sure http://docs-draft.openstack.org/46/332946/7/check/gate-storyboard-docs/3d8639a//doc/build/html/webapi/v1.html#get--v1-stories--story_id--tasks is being pulled from TasksNestedController.get_all | 20:47 |
| dhellmann | if you look at line 310 of stories.py you'll see where it creates the sub-controllers | 20:49 |
| * anteaya looks | 20:49 | |
| SotK | anteaya: it suggests tags for me, where are you expecting the suggestion to be? | 20:51 |
| SotK | (it is in the large search boxes on either http://docs-draft.openstack.org/30/331030/2/check/gate-storyboard-webclient-js-draft/00c8e70//dist/#!/story/list or http://docs-draft.openstack.org/30/331030/2/check/gate-storyboard-webclient-js-draft/00c8e70//dist/#!/search) | 20:51 |
| anteaya | dhellmann: I see it now, thank you | 20:52 |
| dhellmann | anteaya : while you're in there, that docstring could use some clarification. Like "all of the tasks associated with the story" | 20:53 |
| anteaya | dhellmann: I'll take a look | 20:56 |
| anteaya | SotK: let me submit this patch then will respond, thank you | 20:57 |
| anteaya | dhellmann: thank you I was able to add examples for just stories for now | 20:58 |
| dhellmann | anteaya : \o/ | 20:59 |
| anteaya | yay | 21:00 |
| anteaya | thank you dhellmann | 21:01 |
| anteaya | if I can get one section working I'm hoping I can just do the same with the rest of the sections | 21:01 |
| anteaya | I haven't beeen able to figure out how to edit these docs prior to now | 21:01 |
| anteaya | SotK: ah I was in the Jump to... box | 21:02 |
| anteaya | SotK: which I call search but perhaps I shouldn't call the Jump to... box a search box | 21:02 |
| anteaya | and I find it odd that the Jump to... box would have different functionality than the large search box | 21:03 |
| anteaya | and yes, the tags I made show up when I type 'a' or 'b' in the large search box | 21:03 |
| anteaya | does Jump to... just offer a truncated version of search? | 21:07 |
| SotK | Jump to... offers a selection of things which match what you type | 21:08 |
| anteaya | in which case I would be in favour of ditching Jump to... and just going with Search | 21:08 |
| anteaya | but not tags apparently | 21:08 |
| SotK | no, because there is no "tag view" | 21:08 |
| anteaya | okay, I find that confusing | 21:08 |
| SotK | so, when you click on a project that appears, it takes you to the project view | 21:09 |
| anteaya | if search offers me everything I would be in favour of just using search | 21:09 |
| anteaya | does search do the same thing? | 21:09 |
| SotK | search offers a selection of things to filter the results by | 21:10 |
| SotK | if you pick a project there, it shows you all the things related to that project | 21:10 |
| SotK | the "Jump to..." box is meant as quick navigation, not search | 21:11 |
| anteaya | okay so right now I have no way of suggesting what someone should use for what case | 21:11 |
| anteaya | and if tags are offered in one view and not another I see that as a potential point of confusion | 21:11 |
| pleia2 | it is confusing | 21:12 |
| anteaya | if search shows all the things I'm in favour of search | 21:12 |
| anteaya | and remove Jump to... | 21:12 |
| anteaya | I can get to projects via search | 21:13 |
| anteaya | if I am working with someone and I say use search and they use jump to... we waste a lot of time | 21:13 |
| anteaya | since the results are potentially different | 21:13 |
| anteaya | speed is less important to me than consistentcy | 21:14 |
| anteaya | I need to know that they are clicking the thing I tell them to click otherwise I can't support them | 21:14 |
| anteaya | via irc | 21:14 |
| anteaya | yay all the stories api commands have example boxes: http://docs-draft.openstack.org/46/332946/8/check/gate-storyboard-docs/f0166cd//doc/build/html/webapi/v1.html#stories | 21:17 |
| anteaya | and none of the other sections do | 21:17 |
| anteaya | now to populate the TODOs with real commands | 21:17 |
| anteaya | thank you dhellmann | 21:17 |
| anteaya | and I do think having the patch offering known tags in response to searching is very valuable | 21:19 |
| anteaya | thanks for writing that SotK | 21:19 |
| anteaya | has anyone successfully modified a story via the api? | 21:32 |
| anteaya | I'm working on figuring out a command for that now | 21:32 |
| anteaya | this was supposed to modify story 19 and instead it created story 20: http://paste.openstack.org/show/521293/ | 21:34 |
| anteaya | that token I forgot to redact and will delete when I am finished | 21:35 |
| anteaya | I don't think anyone spamming the storyboard dev server is a big risk here | 21:35 |
| SotK | anteaya: you'll want to make the request to https://storyboard-dev.openstack.org/api/v1/stories/19, and include `-X PUT` in that command somewhere I think | 21:53 |
| SotK | anteaya: my opinions on search are documented here: https://storyboard.openstack.org/#!/story/2000402#comment-7042 | 21:54 |
| * SotK would like to discuss ways to solve all the search confusion at some point, but not when I'm about to go to sleep :) | 21:55 | |
| SotK | thanks for this examples work btw! | 21:57 |
| anteaya | ah I was missing -X PUT | 21:58 |
| anteaya | understood thank you | 21:58 |
| anteaya | sleep well and I hope you feel better tomorrow | 21:58 |
| anteaya | thanks so much for your excellent timing and getting a chat with Doug in, I really appreciate it | 21:58 |
| anteaya | thanks SotK that worked | 22:00 |
| anteaya | pleia2: can you create a story in storyboard-dev? I want to see if I can modify a story I don't own via the api | 22:13 |
| anteaya | I should be able to | 22:13 |
| anteaya | shouldn't | 22:16 |
| *** zara_the_lemur__ has quit IRC | 22:25 | |
| anteaya | so I have a 405 Method not allowed when trying to DELETE a story I created: http://paste.openstack.org/show/521300/ | 22:28 |
| anteaya | I think the database expects me to archive the story not DELETE it | 22:28 |
| anteaya | in which case we shouldn't have DELETE in the api docs | 22:28 |
| anteaya | and can we archive using the api? | 22:29 |
| anteaya | I think I have got commands for all the things I can get commands for in the stories section | 23:06 |
| anteaya | I question whether deleting is allowed | 23:07 |
| anteaya | I think I'm going to go for a walk | 23:07 |
| pleia2 | anteaya: sorry, had to step away for a few, still need? | 23:09 |
| anteaya | well yeah if you can create a story in -dev that I can try to modify | 23:10 |
| anteaya | I'd be grateful, thanks | 23:10 |
| pleia2 | anteaya: I have an existing one from when I created from the api the other day | 23:10 |
| pleia2 | at least, I thought I had one | 23:11 |
| *** zhenguo_ has quit IRC | 23:11 | |
| pleia2 | anyway, I'll make one happen either way | 23:12 |
| anteaya | thanks I appreciate it | 23:12 |
| pleia2 | ah yes https://storyboard-dev.openstack.org/#!/story/17 | 23:12 |
| anteaya | or you can try to modify one of mine | 23:12 |
| anteaya | oh awesome, thanks | 23:12 |
| anteaya | https://storyboard-dev.openstack.org/#!/story/17 | 23:16 |
| anteaya | yeah, so it appears that anyone can chance any other owner's story via the api | 23:16 |
| anteaya | appart from purpose vandalism, anyone can make a typo in the curl command and wipe out another user's story | 23:16 |
| anteaya | fungi: any suggestions? | 23:17 |
| anteaya | fungi: right now any user with a valid token can modify any other user's story via the api | 23:17 |
| anteaya | fungi: one person could either intentionally or by mistake take out our entire instance with one keystroke | 23:18 |
| fungi | hrm, seeing how far back i need to read to have context on what you're asking | 23:18 |
| anteaya | 23:09:13 | 23:19 |
| anteaya | pleia2 created story 17 and I just changed it via the api: https://storyboard-dev.openstack.org/#!/story/17 | 23:19 |
| fungi | yet you're unable to change it via the webui? | 23:20 |
| fungi | just making sure i understand teh risk being described | 23:20 |
| anteaya | oh no I can change it via teh web ui | 23:20 |
| pleia2 | I have admin access so I can change the text of any story, so I'm not a good one to test this | 23:20 |
| anteaya | yeah I just edited it again via the web ui | 23:20 |
| fungi | can you elaborate on the perceived risk then? you can do something via the api that you can also do via the webui... | 23:21 |
| fungi | is the api your primary concern there? | 23:21 |
| fungi | should you not be able to modify "other people's" stories? | 23:21 |
| anteaya | if I want to change story 18 and mistype and change 17 | 23:21 |
| anteaya | that is a mistake and removes liz's story | 23:21 |
| anteaya | if that was done in a loop | 23:21 |
| fungi | removes or changes? | 23:21 |
| anteaya | overwrites | 23:22 |
| fungi | i mean, you can also do that in loop with a command-line web client | 23:22 |
| anteaya | her prior title and description are no longer present in the ui | 23:22 |
| anteaya | sure | 23:22 |
| fungi | you could do that via lp as well | 23:22 |
| anteaya | if you percive no risk I'm fine with that | 23:22 |
| anteaya | okay | 23:22 |
| fungi | we backup the database | 23:22 |
| anteaya | I'm wrong | 23:22 |
| anteaya | okay thanks, happy to be wrong | 23:22 |
| anteaya | sorry for the noise | 23:22 |
| pleia2 | I appreciate that you're being diligent :) | 23:23 |
| fungi | not necessarily wrong, worth thinking about from a vandalism perspective. having a database transaction log also means we can _probably_ roll back those modifications discretely. i'd defer to someone with more dba background on that though | 23:23 |
| pleia2 | ++ | 23:24 |
| fungi | mediawiki addresses this by keeping a complete edit history (independent of any the database might have kept) but that could be overkill for this | 23:24 |
| fungi | sb has some audit logging for this at least, i gather, so we could also identify someone doing it maliciously and block their account | 23:25 |
| anteaya | sure if we have a discussion about it and are happy with current status I'm fine | 23:25 |
| anteaya | the idea just loped through my head so thought I'd share | 23:25 |
| fungi | pleia2: on the topic of sb, you didn't commit your sb-dev cert add in private hiera (also my original suggestion was to put it in public hiera but that can always come later) | 23:25 |
| fungi | anteaya: thanks! | 23:26 |
| pleia2 | fungi: whoops, thank you | 23:26 |
| anteaya | thank you | 23:26 |
| fungi | only noticed because adding pgp keyfiles for the signing node | 23:26 |
| pleia2 | fungi: shall I do the commit now? | 23:26 |
| fungi | i committed the file i edited and left your edits staged in case you were still doing something there | 23:27 |
| pleia2 | ok thanks | 23:27 |
| fungi | so yeah, commit at will | 23:27 |
| anteaya | my lastest api doc examples passed tests so I'm going to go for a walk now and will check back later | 23:27 |
| pleia2 | I just got distracted after adding it :\ | 23:27 |
| fungi | it happens! | 23:27 |
| anteaya | pleia2: ha ha ha | 23:27 |
| anteaya | latest | 23:27 |
| *** cdelatte has joined #openstack-sprint | 23:32 | |
| *** baoli has joined #openstack-sprint | 23:47 | |
| *** baoli has quit IRC | 23:54 | |
| *** baoli has joined #openstack-sprint | 23:57 | |
| *** baoli has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!