| *** chenhuayi has joined #openstack-smaug | 01:24 | |
| *** pzchen has joined #openstack-smaug | 01:44 | |
| *** zhangshuai_ has joined #openstack-smaug | 01:49 | |
| *** pzchen has quit IRC | 01:50 | |
| *** pzchen has joined #openstack-smaug | 01:56 | |
| openstackgerrit | smile-luobin proposed openstack/smaug: Store ResourceGraph and Plan in checkpoint https://review.openstack.org/307737 | 02:00 |
|---|---|---|
| *** yinwei_computer has joined #openstack-smaug | 02:32 | |
| *** pzchen has quit IRC | 03:56 | |
| *** zhangshuai_ has quit IRC | 04:01 | |
| *** zhangshuai_ has joined #openstack-smaug | 04:02 | |
| *** zhangshuai_ has quit IRC | 04:07 | |
| *** zhangshuai_ has joined #openstack-smaug | 04:07 | |
| *** zhangshuai_ has quit IRC | 04:33 | |
| *** zhangshuai_ has joined #openstack-smaug | 04:38 | |
| *** pzchen has joined #openstack-smaug | 06:08 | |
| openstackgerrit | Merged openstack/smaug: Store ResourceGraph and Plan in checkpoint https://review.openstack.org/307737 | 06:11 |
| *** zhangshuai_ has quit IRC | 06:13 | |
| *** zhangshuai_ has joined #openstack-smaug | 06:14 | |
| *** pzchen has quit IRC | 06:15 | |
| *** yuval has joined #openstack-smaug | 06:29 | |
| yuval | ping chenying | 06:30 |
| chenying | Hi | 06:31 |
| *** pzchen has joined #openstack-smaug | 06:34 | |
| yuval | chenying: regarding https://review.openstack.org/#/c/307737 | 06:44 |
| yuval | chenying: we should reach consensus regarding patches. This specific patch has issues, and you just merged it in | 06:45 |
| chenying | Do you have any comments about it? I need this patch to test restore. If this patch has issues, you can contact luobin, and ask him submit another patch to fix it. | 06:48 |
| chenying | I will ask luobin to join this channel. | 06:48 |
| yuval | chenying: there are 2 issues here. First, there is the issue in the patch, that we can discuss. Second, the fact that you merge the patch when there is no consensus, and the patch has issues | 06:50 |
| chenying | yuval: I will not merge patch when these is no consensus. But this patch have blocked serval guys's work. restore flow test and other guys's fullstack test. | 06:55 |
| yuval | chenying: well, if there are comments that require a fix - we need to discuss and fix them. if you need it urgently - tell us | 06:56 |
| chenying | yuval: OK I will. | 06:57 |
| *** gampel has joined #openstack-smaug | 06:58 | |
| chenying | When I do the test, I have found another several bug about the protect service. luobin or I will submit it as soon as possible. | 06:59 |
| yuval | chenying: if you need these patches for tests, you can download them and test them locally | 07:02 |
| yuval | chenying: if there are problems with the patch and you need it urgently, it doesn't justify merging the code | 07:03 |
| chenying | yuval: Yes I know. I don't know the problems with the patch, luobin and you did not reach an agreement. If I know it, I will not merge it with problems. | 07:12 |
| yuval | chenying: ok, I'll spea with luobin about it | 07:13 |
| yuval | *speak | 07:13 |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Protection Provider use Bank to wrap BankPlugin https://review.openstack.org/317436 | 07:34 |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Checkpoints to use a unique sub-section https://review.openstack.org/317437 | 07:35 |
| *** smile-luobin has joined #openstack-smaug | 07:53 | |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Checkpoints to use a unique sub-section https://review.openstack.org/317437 | 07:53 |
| *** smile-luobin has left #openstack-smaug | 07:55 | |
| openstackgerrit | zengchen proposed openstack/smaug: Encapsulate smaug client in Operation Engine https://review.openstack.org/310394 | 07:57 |
| *** smile-luobin2 has joined #openstack-smaug | 07:59 | |
| chenying | yuval: smile-luobin2 has joined. | 08:02 |
| yuval | hey smile-luobin2 | 08:02 |
| *** smile-luobin2 has quit IRC | 08:17 | |
| *** smile-luobin has joined #openstack-smaug | 08:18 | |
| *** smile-luobin_ has joined #openstack-smaug | 08:18 | |
| *** smile-luobin has left #openstack-smaug | 08:18 | |
| *** smile-luobin_ has quit IRC | 08:20 | |
| *** smile-luobin_ has joined #openstack-smaug | 08:24 | |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Fix stevedore of Protectable Registry https://review.openstack.org/312951 | 08:30 |
| yuval | ping chenzeng | 08:40 |
| chenzeng | yuval:hey, how are you | 08:40 |
| yuval | chenzeng: well, you? | 08:41 |
| *** zhangshuai_ has quit IRC | 08:42 | |
| chenzeng | yuval: good. | 08:42 |
| chenzeng | yuval: you want to talk about the smaug client ? | 08:42 |
| *** smile-luobin_ has quit IRC | 08:42 | |
| yuval | chenzeng: yes :) | 08:42 |
| yuval | chenzeng: didn't really understand | 08:42 |
| chenzeng | yuval:ok. | 08:42 |
| chenzeng | yuval:what don't you understand? | 08:45 |
| yuval | chenzeng: from what I've seen, the AuthManager class is similar to parts of the RequestContext class from Heat | 08:47 |
| chenzeng | yuval:actually, i have read the code of heat. | 08:48 |
| chenzeng | yuval:we use the 'trust' to create correct the token. Heat use the 'trust'. | 08:49 |
| *** smile-luobin has joined #openstack-smaug | 08:50 | |
| *** smile-luobin has quit IRC | 08:51 | |
| yuval | chenzeng: let me see if I understand. | 08:54 |
| chenzeng | yuval:ok, thank you! | 08:55 |
| yuval | chenzeng: someone calls `create_scheduled_operation()` in OperationEngineManager | 08:56 |
| yuval | chenzeng: then, it calls the smaug_client `add_operation()` | 08:56 |
| chenzeng | yeu | 08:56 |
| chenzeng | yuval:yes | 08:56 |
| yuval | chenzeng: (which adds the credentials to the AuthManager) | 08:56 |
| yuval | chenzeng: then, when the time for execute comes, ProtectOperation looks for the `smaug_client.client()` in order to get the client with credentials | 08:57 |
| chenzeng | yuval:i just want to create 'trust' by the toke of that user. | 08:57 |
| chenzeng | yuval:yes, you are right. | 08:58 |
| yuval | chenzeng: what id some calls `add_operation` with the same user_id and project_id multiple times? | 08:59 |
| chenzeng | yuval:I have store the credential when add_operation is called first with that user_id and project_id, If add_operation is called again with same user_id and project_id, it just return the trust id. | 09:02 |
| yuval | chenzeng: by the way, isn't python-smaugclient missing from requirements.txt? | 09:06 |
| chenzeng | yuval:yes, i forgot. i will update. thank you. | 09:07 |
| chenzeng | yuval:you understand my patch? | 09:08 |
| yuval | chenzeng: yes, I'll continue reviewing it | 09:08 |
| chenzeng | yuval:ok. thanks for your time. | 09:08 |
| yuval | chenzeng: I have a feeling that we might want to separate AuthManager from the add/delete/resume/_operation | 09:09 |
| chenzeng | yuval:can you give me more details? The input of AuthManager is the original credential of user. | 09:11 |
| yuval | chenzeng: I'll think about it first, it is just an initial feeling | 09:11 |
| chenzeng | yuval:ok , i believe your feeling. :) | 09:11 |
| *** pzchen has quit IRC | 10:09 | |
| *** pzchen has joined #openstack-smaug | 10:57 | |
| *** pzchen has quit IRC | 10:59 | |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Fix stevedore of Protectable Registry https://review.openstack.org/312951 | 11:06 |
| openstackgerrit | Merged openstack/smaug: Protection Provider use Bank to wrap BankPlugin https://review.openstack.org/317436 | 13:03 |
| openstackgerrit | Saggi Mizrahi proposed openstack/smaug: Fix minor issues with code formatting https://review.openstack.org/319673 | 13:55 |
| *** wangfeng has joined #openstack-smaug | 13:56 | |
| *** saggi has joined #openstack-smaug | 13:57 | |
| openstackgerrit | Merged openstack/smaug: Remote Restore states from possible checkpoint states https://review.openstack.org/319672 | 13:59 |
| openstackgerrit | Saggi Mizrahi proposed openstack/smaug: Fix minor issues with code formatting https://review.openstack.org/319673 | 14:23 |
| *** yuval has quit IRC | 15:06 | |
| openstackgerrit | Merged openstack/smaug: Move swift client to be created by ClientFactory https://review.openstack.org/300854 | 15:55 |
| *** jhamhader has joined #openstack-smaug | 16:41 | |
| *** chenhuayi has quit IRC | 16:42 | |
| *** jhamhader has quit IRC | 16:43 | |
| *** jhamhader has joined #openstack-smaug | 16:44 | |
| *** jhamhader has quit IRC | 16:47 | |
| *** jhamhader has joined #openstack-smaug | 16:48 | |
| *** jhamhader has quit IRC | 16:48 | |
| *** jhamhader has joined #openstack-smaug | 16:48 | |
| *** jhamhader has quit IRC | 16:48 | |
| *** jhamhader has joined #openstack-smaug | 16:49 | |
| *** jhamhader has joined #openstack-smaug | 16:52 | |
| *** jhamhader has quit IRC | 21:41 | |
| *** zengyingzhe__ has quit IRC | 22:53 | |
| *** saggi has quit IRC | 23:28 | |
| *** gampel has quit IRC | 23:28 | |
| *** zengyingzhe__ has joined #openstack-smaug | 23:38 | |
| *** saggi has joined #openstack-smaug | 23:40 | |
| *** gampel has joined #openstack-smaug | 23:43 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!