| *** mingyu has joined #openstack-smaug | 01:04 | |
| *** mingyu has quit IRC | 01:08 | |
| *** mingyu has joined #openstack-smaug | 02:39 | |
| *** mingyu has quit IRC | 02:43 | |
| *** mingyu has joined #openstack-smaug | 03:14 | |
| *** mingyu has quit IRC | 03:15 | |
| *** mingyu has joined #openstack-smaug | 05:05 | |
| *** mingyu has quit IRC | 05:11 | |
| *** mingyu has joined #openstack-smaug | 05:48 | |
| *** WANGFeng has joined #openstack-smaug | 05:55 | |
| *** mingyu has quit IRC | 06:03 | |
| *** mingyu has joined #openstack-smaug | 06:07 | |
| *** mingyu has quit IRC | 06:16 | |
| *** mingyu has joined #openstack-smaug | 06:22 | |
| *** mingyu_ has joined #openstack-smaug | 06:24 | |
| *** mingyu has quit IRC | 06:24 | |
| *** yuval has joined #openstack-smaug | 06:43 | |
| *** yuval is now known as Guest81049 | 06:44 | |
| *** Guest81049 has quit IRC | 06:51 | |
| *** yuval_ has joined #openstack-smaug | 06:51 | |
| *** yuval_ is now known as yuval | 06:51 | |
| openstackgerrit | zengchen proposed openstack/smaug: Implement restart of Operation Engine service https://review.openstack.org/304048 | 06:52 |
|---|---|---|
| chenzeng | yuval:good morning! can you see the updates in https://review.openstack.org/304048. i have one question to confirm with you. thanks. | 06:53 |
| *** mingyu_ has quit IRC | 06:59 | |
| *** mingyu has joined #openstack-smaug | 07:01 | |
| chenzeng | yuval:ping | 07:06 |
| *** mingyu has quit IRC | 07:14 | |
| yuval | chenzeng: hey | 07:33 |
| chenzeng | yuval:hi | 07:33 |
| chenzeng | yuval:do you see the updates? | 07:33 |
| yuval | chenzeng: yes, +1 it now | 07:33 |
| chenzeng | for state in states: | 07:34 |
| chenzeng | resume = (state.state in resume_states) | 07:34 |
| chenzeng | self._trigger_manager.register_operation( | 07:34 |
| chenzeng | state.operation.trigger_id, state.operation.id, | 07:34 |
| chenzeng | resume=resume, end_time_for_run=state.end_time_for_run) | 07:34 |
| chenzeng | do you see the last line? | 07:34 |
| chenzeng | i prepare to add one more attribute 'end_time_for_run' to ScheduledOpertionState. | 07:35 |
| chenzeng | end_time_for_run = expected_time + window. | 07:36 |
| yuval | wait, what? | 07:36 |
| yuval | oh | 07:36 |
| yuval | and who is reponsible for updating this field? | 07:37 |
| chenzeng | i want to use it to check whether can resume the operation. if time.nowutc() > end_time_for_run. i will not resume it. | 07:38 |
| yuval | yes, I understand. Who sets the time into ScheduledOperationState? | 07:38 |
| chenzeng | when invoke execute_operation of Executor, i will update the ScheduledOpertionState and set state to 'triggered' and end_time_for_run = expected_time + window. | 07:39 |
| chenzeng | i mean i will not write/read ScheduledOperationLog in executor class, but i have to update ScheduledOpertionState. | 07:40 |
| yuval | and we will use this parameter only if resume=True ? | 07:41 |
| chenzeng | yes. | 07:41 |
| yuval | ok :) | 07:41 |
| chenzeng | ok, thank you. | 07:42 |
| chenzeng | one more question. | 07:42 |
| yuval | sure | 07:42 |
| chenzeng | i prepare to fix the bug that we have discussed maney days ago. https://bugs.launchpad.net/smaug/+bug/1572865 | 07:43 |
| openstack | Launchpad bug 1572865 in Smaug "Fix the way of send the rpc requests to OperationEngine service" [Undecided,New] | 07:43 |
| yuval | sounds good | 07:43 |
| chenzeng | i remember you said you will check the cast interface of rpc. | 07:44 |
| chenzeng | have you finished? | 07:44 |
| yuval | I thoght we spoke about it, my bad. By default, cast() doesn't broadcast. In order for it to send a broadcast, you need to use a target with the 'fanout' parameter turned to True | 07:46 |
| yuval | You can add a fanout parameter to an existing target | 07:46 |
| chenzeng | ok, thank you. | 07:48 |
| yuval | fanout_target = target(fanout=True) | 07:48 |
| yuval | see: | 07:49 |
| yuval | http://docs.openstack.org/developer/oslo.messaging/target.html | 07:49 |
| yuval | (btw, you can't use a Target with 'fanout' for call(), only cast() ) | 07:49 |
| chenzeng | you mean i have to create two instance of Target. one with 'fanout=None' for call(), other with 'fanout=True' for call() | 07:51 |
| yuval | That is one option. Another one is to take an existing target, and add the fanout parameter: | 07:52 |
| yuval | fanout_target = target(fanout=True) | 07:52 |
| chenzeng | def __call__(self, **kwargs): | 07:53 |
| chenzeng | for a in ('exchange', 'topic', 'namespace', | 07:53 |
| chenzeng | 'version', 'server', 'fanout'): | 07:53 |
| chenzeng | kwargs.setdefault(a, getattr(self, a)) | 07:53 |
| chenzeng | return Target(**kwargs) | 07:53 |
| chenzeng | yes, i understand. | 07:53 |
| chenzeng | thanks. | 07:53 |
| openstackgerrit | Merged openstack/smaug: Implement the workflow https://review.openstack.org/285149 | 07:55 |
| yuval | chenzeng: :) | 07:56 |
| xiangxinyong | http://www.cnblogs.com/edisonxiang/p/5051666.html | 08:01 |
| *** WANGFeng has quit IRC | 08:02 | |
| yuval | If anybody wants, we have a vagrant script which sets up a libvirt vm and install devstack. It includes a smaug local.conf | 08:03 |
| yuval | https://github.com/omeranson/openstack-vagrant | 08:03 |
| *** yinweimac has joined #openstack-smaug | 08:12 | |
| *** yinweimac has quit IRC | 08:17 | |
| openstackgerrit | Merged openstack/smaug: Implement restart of Operation Engine service https://review.openstack.org/304048 | 09:11 |
| openstackgerrit | Merged openstack/python-smaugclient: Add show protectables instance endpoint https://review.openstack.org/302597 | 09:26 |
| chenzeng | yuval:good job. it is great! | 09:27 |
| yuval | it is oanson job :) | 10:14 |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Move swift client to be created by ClientFactory https://review.openstack.org/300854 | 10:49 |
| yuval | ping yinwei_computer | 11:22 |
| yuval | ping yinweiishere | 11:22 |
| openstackgerrit | zengchen proposed openstack/smaug: Fix the way of sending the rpc requests to OperationEngine service https://review.openstack.org/308929 | 11:26 |
| openstackgerrit | zengchen proposed openstack/smaug: Fix the way of sending the rpc requests to OperationEngine service https://review.openstack.org/308929 | 11:36 |
| chenzeng | yuval:if you have time, please review this patch. thanks. https://review.openstack.org/308929 | 11:37 |
| yuval | chenzeng: sure. did you see it failed CI? | 11:45 |
| chenzeng | yuval:i will update. thaks for you remiding. | 11:49 |
| chenzeng | yuval:i have to add one more patch to encapsulate the operation. i heard you will have a holiday next week, do you? | 11:52 |
| yuval | chenzeng: the holiday is in weekend, we work during the work week | 11:53 |
| chenzeng | yuval:great. i hope you can review my patches to make the work perfect. | 11:55 |
| chenzeng | yuval::) | 11:55 |
| openstackgerrit | chenying proposed openstack/smaug: Fix the wrong calling list_protectable_dependents https://review.openstack.org/308958 | 12:44 |
| openstackgerrit | xiangxinyong proposed openstack/smaug-dashboard: Add the project id and version for smaugclient https://review.openstack.org/308960 | 12:46 |
| openstackgerrit | Merged openstack/smaug: Fix serialized_meta in SwiftBankPlugin https://review.openstack.org/301427 | 13:52 |
| *** saggi has quit IRC | 15:11 | |
| openstackgerrit | Merged openstack/smaug: Fix the wrong calling list_protectable_dependents https://review.openstack.org/308958 | 15:13 |
| *** openstackgerrit has quit IRC | 15:48 | |
| *** openstackgerrit has joined #openstack-smaug | 15:48 | |
| *** yuval has quit IRC | 16:29 | |
| *** zhonghua has joined #openstack-smaug | 17:01 | |
| *** zhonghua-lee has quit IRC | 17:02 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!