| *** yuval has joined #openstack-smaug | 06:42 | |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Implement the common logic for service client https://review.openstack.org/291528 | 10:47 |
|---|---|---|
| openstackgerrit | Yuval Brik proposed openstack/smaug: Implement Nova service client https://review.openstack.org/291532 | 11:07 |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Implement Cinder service client https://review.openstack.org/291535 | 11:10 |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Implement Glance service client https://review.openstack.org/292119 | 11:12 |
| *** gampel1 has joined #openstack-smaug | 11:26 | |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Implement Cinder service client https://review.openstack.org/291535 | 11:27 |
| gampel1 | saggi: look at https://review.openstack.org/#/c/281618/9 | 11:30 |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Implement Glance service client https://review.openstack.org/292119 | 11:31 |
| openstackgerrit | Yuval Brik proposed openstack/smaug: Implement Glance service client https://review.openstack.org/292119 | 11:48 |
| *** chenying has quit IRC | 12:24 | |
| *** chenying has joined #openstack-smaug | 12:24 | |
| *** gampel1 has quit IRC | 14:19 | |
| chenzeng | ping yuval | 14:26 |
| chenzeng | yuval:are you there? | 14:26 |
| yuval | Yes | 14:41 |
| yuval | ping chenzeng | 14:41 |
| chenzeng | yuval, are you still there? | 14:50 |
| yuval | yes | 14:50 |
| chenzeng | would you please see the comments i replied to you on "time trigger design' | 14:52 |
| chenzeng | https://review.openstack.org/#/c/271210/ | 14:52 |
| chenzeng | maybe you have not understood my design. | 14:52 |
| yuval | I think we have a misunderstanding :) | 14:53 |
| chenzeng | i think so | 14:53 |
| yuval | As far as I understand, TimeTrigger decides the "when", and operation decides the "what". Therefor, for each time trigger (i.e "daily at 12:00"), we can bind 10 operations. Once that trigger "pops", we can execute all operations | 14:54 |
| chenzeng | in my design TimeTrigger is not a single trigger, it holds a lot of operations. it doesn't define when. it is a scheduler actually. | 14:56 |
| chenzeng | i think you should understand my design from the codes. | 14:57 |
| yuval | Say I have two triggers: daily at 12pm and weekly every sunday. Do I have two instances of TimeTrigger? | 14:58 |
| chenzeng | no | 14:59 |
| chenzeng | maybe the name of TimeTrigger misleads you. | 15:00 |
| chenzeng | i describe my designs to you. | 15:00 |
| yuval | Sure | 15:00 |
| chenzeng | there is only one instance of TimeTrigger in system. | 15:01 |
| chenzeng | it has an instance of JobStore which hold all operations registerd to TimeTrigger. | 15:02 |
| chenzeng | TimeTrigger query from the JobStore which operation should to be run, and submit it the Executor. | 15:03 |
| yuval | Do you know which patch contains the TriggerManager class? I can't find it | 15:03 |
| chenzeng | https://review.openstack.org/#/c/276081 | 15:05 |
| chenzeng | the class Job hold the operation id and its trigger info from which the 'next run time' can be canculated. | 15:08 |
| chenzeng | maybe i should update the class diagram in order to make the design clearer. | 15:16 |
| chenzeng | yuval: are you there? if you get any questions, please give me comments. tommorrow, i will reply you. thank you very much. | 15:22 |
| yuval | chenzeng: I'm here | 15:22 |
| chenzeng | yuval:ok | 15:23 |
| chenzeng | yuval:i think there is a little hard to understand my design only by reading the codes. | 15:24 |
| chenzeng | yuval:i have to go to bed. thanks for you to read my codes. i hope to discuss with you. | 15:34 |
| yuval | chenzeng: sure thing, good night | 15:34 |
| *** yuval has quit IRC | 15:34 | |
| openstackgerrit | Saggi Mizrahi proposed openstack/smaug: Create BankCheckpointCollection implementation https://review.openstack.org/280325 | 22:15 |
| openstackgerrit | Saggi Mizrahi proposed openstack/smaug: Proposed Smaug API v1.0 https://review.openstack.org/244756 | 22:25 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!