*** luobin has quit IRC | 00:07 | |
*** luobin has joined #openstack-smaug | 00:07 | |
openstackgerrit | zengchen proposed openstack/smaug: implement time trigger https://review.openstack.org/271196 | 01:30 |
---|---|---|
openstackgerrit | zengchen proposed openstack/smaug: Implement operation manager https://review.openstack.org/274339 | 01:35 |
openstackgerrit | zengchen proposed openstack/smaug: Implement executor of OperationEngine https://review.openstack.org/282263 | 02:14 |
openstackgerrit | zengchen proposed openstack/smaug: Implement rpc interfaces of OperationEngine https://review.openstack.org/276081 | 02:14 |
openstackgerrit | zengchen proposed openstack/smaug: Implement RestAPIs of trigger. https://review.openstack.org/286406 | 03:05 |
openstackgerrit | zengchen proposed openstack/smaug: RPC client recreates exception object failed https://review.openstack.org/289685 | 03:12 |
openstackgerrit | zengchen proposed openstack/smaug: Implement RestAPIs of Scheduled Operation. https://review.openstack.org/287036 | 03:25 |
openstackgerrit | zengchen proposed openstack/smaug: Implement RestAPIs of trigger. https://review.openstack.org/286406 | 03:34 |
*** CrayZee has quit IRC | 06:54 | |
*** CrayZee has joined #openstack-smaug | 06:55 | |
*** gampel has joined #openstack-smaug | 07:05 | |
*** yuval has joined #openstack-smaug | 07:11 | |
yuval | ping zengyingzhe | 07:11 |
yinwei_computer | ping saggi | 07:26 |
yuval | ping chenzeng | 07:54 |
chenzeng | yuval:hello | 07:54 |
yuval | How are you? | 07:54 |
chenzeng | yuval:fine, and you? | 07:54 |
yuval | I'm well | 07:54 |
yuval | Regarding 282263 ( | 07:55 |
yuval | Implement executor of OperationEngine | 07:55 |
yuval | I was thinking, because RecordOperationLogExecutor depends on the 'real_operation_executor' having register_event_function_when_execute_operation | 07:56 |
chenzeng | yuval:yes | 07:56 |
yuval | maybe we can instead of using the register event function, supply an optional callback argument to Executor's execute_operation() | 07:57 |
yuval | therefor RecordOperationLogExecute can set the start time before calling the real_operation_executor's execute_operation(), and pass the _after_execute_operation as a callback | 07:59 |
yuval | What do you think? | 07:59 |
chenzeng | yuval:1. the fuction 'before_execute_operation' will be invoked at the real execution time not at invoking the 'execute_operation'. 2. can you describe the advantages of your design? | 08:04 |
yuval | I would like to avoid coupling the LogExecutor to the ThreadPoolExecutor. If, for example, tomorrow we would like to add a new executor, it will must have the register_event_function_when_execute_operation() function in order to be compatible with the LogExecutor, which is not required by the BaseExecutor abstract base class | 08:08 |
*** luobin has quit IRC | 08:11 | |
*** luobin has joined #openstack-smaug | 08:11 | |
*** yuval has quit IRC | 08:22 | |
*** yuval has joined #openstack-smaug | 08:22 | |
*** yinweiphone has joined #openstack-smaug | 08:32 | |
yinweiphone | hi saggie | 08:33 |
yinweiphone | Ping saggi | 08:34 |
yuval | chenzeng: what do you think? | 08:37 |
gampel | hi yinwei | 08:38 |
*** saggi1 has joined #openstack-smaug | 08:39 | |
*** yinweiphone has quit IRC | 08:39 | |
gampel | hi saggi | 08:40 |
*** gampel has quit IRC | 08:40 | |
*** gampel has joined #openstack-smaug | 08:41 | |
gampel | hi yinwei did you ping me or saggi we are here now | 08:41 |
saggi1 | hi | 08:42 |
gampel | smile-luobin: are you here | 08:42 |
gampel | hi @luobin | 08:43 |
gampel | chenzeng: are you here | 08:44 |
gampel | ping zengyingzhe | 08:44 |
gampel | Is there anybody out there? | 08:46 |
gampel | am I swimming through this empty sea alone? | 08:47 |
luobin | yes | 08:48 |
saggi1 | gampel: I'm with you | 08:48 |
saggi1 | !! | 08:48 |
openstack | saggi1: Error: "!" is not a valid command. | 08:48 |
gampel | cool | 08:48 |
luobin | hi | 08:48 |
gampel | hi luobin | 08:48 |
gampel | did you see my comment on the swift bank patch | 08:48 |
luobin | yes | 08:49 |
gampel | what do you think ? | 08:49 |
gampel | each provider should have different bank account configuration | 08:51 |
luobin | OK, I agree | 08:52 |
gampel | very good job by the way, we can merge it this way but we must agree that this setting should be per provider | 08:52 |
gampel | we need to register a bug to create provider configuration file that will be passed to the bank and all the protection plugin | 08:53 |
luobin | OK, jusk do it | 08:53 |
gampel | will you be able to register this BUG ? | 08:53 |
luobin | just | 08:53 |
saggi1 | luobin: The configuration for the provider must be in a seperate file so that we can synchronize it between sites. So any solution must involve a configuration per provider. | 08:53 |
gampel | luobin: ? | 08:56 |
gampel | saggi1: who do you think can work on the provider configuration ? | 08:56 |
saggi1 | luobin: What do you have planned after the swift patch? | 08:56 |
luobin | I have something to do right now, please wait | 08:58 |
luobin | OK, i will. | 09:01 |
luobin | I will implement the nova protection plugin | 09:02 |
gampel | luobin: will you be able to register this bug | 09:03 |
luobin | gampel: OK, i will register this bug. | 09:03 |
gampel | luobin: if you are busy i will ask yuval or someone else to work on the provider configuration | 09:04 |
zhonghua-lee | hi, gampel | 09:23 |
zhonghua-lee | how are you | 09:23 |
chenzeng | yuval:sorry, are you there. | 09:26 |
yuval | yes | 09:26 |
chenzeng | yuval:i aggree you with the callback desgin. | 09:27 |
chenzeng | yuval:but how about the 'before_execute_operation' | 09:27 |
chenzeng | yuval:maybe i should think more about this design. it is not very good. | 09:29 |
yuval | chenzeng: maybe, instead of LogExecutor can wrap the original operation with a new log operation | 09:31 |
chenzeng | yuval:ok, i will update my realization. if you have good ideas, please tell me. thanks. | 09:37 |
*** luobin has quit IRC | 09:37 | |
gampel | zengchen: | 09:38 |
gampel | hi | 09:38 |
gampel | did you talk with saggi about https://review.openstack.org/#/c/271210/ | 09:38 |
chenzeng | gampel:no. it is too long to update it. | 09:40 |
chenzeng | gampel:last time, i talked with saggi about my design of time trigger, and he agreed with me. I think he forgot to update the comments. | 10:04 |
gampel | please ask him to fix that | 10:04 |
gampel | chenzeng: hi | 10:05 |
chenzeng | saggi:if you have time , can you review again about the " https://review.openstack.org/#/c/271210/" | 10:05 |
chenzeng | gampel:ok | 10:05 |
gampel | please look at https://review.openstack.org/#/c/286437/1 | 10:05 |
gampel | we need to make sure we do not merge with windows line ending | 10:05 |
gampel | will you be able to check why it failed locally when running tox and pass the CI gate | 10:06 |
chenzeng | this path is own by chenying. he go to holiday. | 10:09 |
gampel | Ok | 10:09 |
gampel | when will he be back ? | 10:09 |
chenzeng | tommorrow, i will update it. | 10:10 |
gampel | thx | 10:10 |
chenzeng | about 15 days. | 10:10 |
*** x00350071 has quit IRC | 10:42 | |
*** x00350071 has joined #openstack-smaug | 10:43 | |
*** x00350071 has quit IRC | 11:08 | |
openstackgerrit | Merged openstack/smaug-dashboard: Initial Cookiecutter for smaug-dashboard https://review.openstack.org/286456 | 11:24 |
*** luobin has joined #openstack-smaug | 11:38 | |
*** xiangxinyong456 has joined #openstack-smaug | 12:54 | |
xiangxinyong456 | eran and saggi: ping | 12:54 |
yuval | xiangxinyong456: Eran is in a meeting, can I help? | 12:57 |
xiangxinyong456 | yuval: thanks. | 12:57 |
xiangxinyong456 | yuval: we are devepping smaug dashboard | 12:58 |
saggi1 | xiangxinyong456: pong | 12:59 |
xiangxinyong456 | saggi and yuval: which kind of plugin do you prefer? | 12:59 |
saggi1 | xiangxinyong456: Could you give us a bit more context | 13:00 |
xiangxinyong456 | django plugin or angularjs plugin? | 13:00 |
saggi1 | xiangxinyong456: oh, do they both work with horizon? What is the preferred methods? | 13:00 |
xiangxinyong456 | yeah, they both work | 13:01 |
xiangxinyong456 | horizon guys use angluarjs in the lastest version | 13:02 |
saggi1 | xiangxinyong456: So django is deprecated? | 13:02 |
xiangxinyong456 | not yet. | 13:02 |
xiangxinyong456 | both work. | 13:02 |
saggi1 | xiangxinyong456: Are there any plans to deprecate it is angular considered the future? | 13:03 |
xiangxinyong456 | yeah, horizon guys consider to use angular in the future | 13:04 |
xiangxinyong456 | in the mitaka, there are lots of bp about angular in horizon. | 13:05 |
xiangxinyong456 | i am a little worried about the present angular in horizon is not mature | 13:07 |
xiangxinyong456 | because there are lots of django plugin in present horizon | 13:08 |
saggi1 | xiangxinyong456: I see. Looking at the docs they are both viable. | 13:10 |
xiangxinyong456 | yes | 13:10 |
xiangxinyong456 | so i want to receive our team`s ideas. | 13:12 |
saggi1 | xiangxinyong456: It seems like both requires some django in horizon at least for the REST. | 13:12 |
xiangxinyong456 | saggi: yes. | 13:13 |
saggi1 | xiangxinyong456: From what I understand there is a clear migration path from django to angular if we want in the future. An I right? | 13:13 |
xiangxinyong456 | i think so. but we need to do much more change. | 13:14 |
xiangxinyong456 | if we use django plugin, we use more python codes, | 13:15 |
xiangxinyong456 | if we use angular plugin,we use more js codes | 13:16 |
saggi1 | I've used angular in the past. It's a good framework. But the real question is what would be easier and faster for you to develop. | 13:16 |
*** luobin has quit IRC | 13:16 | |
saggi1 | Since I don't care much about the featureset ATM | 13:16 |
*** luobin has joined #openstack-smaug | 13:17 | |
xiangxinyong456 | saggi: sorry, ATM means what? | 13:19 |
saggi1 | At the moment | 13:20 |
xiangxinyong456 | saggi: :) | 13:21 |
saggi1 | xiangxinyong456: Have you worked with any of those before? | 13:21 |
xiangxinyong456 | saggi: i used jquery before | 13:22 |
xiangxinyong456 | saggi: django looks simple in some pages | 13:23 |
saggi1 | xiangxinyong456: django is classic MVC. angular is a bit less conventional. | 13:24 |
xiangxinyong456 | yeah, you are so professional in both django and angular. | 13:26 |
xiangxinyong456 | saggi: i feel it is harder to finish a table tree by using django | 13:28 |
xiangxinyong456 | e.g. the resource table tree. | 13:28 |
xiangxinyong456 | we could call it tree table | 13:29 |
xiangxinyong456 | i think we could only finish tree table widget by using js. | 13:31 |
xiangxinyong456 | saggi: do you have some suggetions? | 13:32 |
saggi1 | xiangxinyong456: We will have to use some JS in the table. | 13:32 |
saggi1 | xiangxinyong456: But I think ajax support is pretty good with django isn't it? | 13:33 |
xiangxinyong456 | yeah, i agree with you. i like ajax. | 13:34 |
xiangxinyong456 | it seems that we can mix to use.django plugin and angular plugin. | 13:36 |
xiangxinyong456 | like the present horizon | 13:36 |
saggi1 | xiangxinyong456: I think we should start using django and if we see there are things we need angular for we will use angular. | 13:37 |
saggi1 | Do you agree? | 13:37 |
xiangxinyong456 | yeah. +2 | 13:38 |
saggi1 | xiangxinyong456: Great | 13:39 |
xiangxinyong456 | we could start like that. | 13:39 |
xiangxinyong456 | saggi: thanks your suggestion. | 13:40 |
xiangxinyong456 | i really appreciate it. | 13:42 |
*** xiangxi12 has joined #openstack-smaug | 13:46 | |
*** xiangxinyong456 has quit IRC | 13:50 | |
*** xiangxi12 has quit IRC | 13:55 | |
*** xiangxinyong456 has joined #openstack-smaug | 14:02 | |
*** Guest41345 has quit IRC | 14:03 | |
openstackgerrit | Yuval Brik proposed openstack/smaug: docs: fix operation_engine_design rst syntax https://review.openstack.org/292898 | 14:12 |
openstackgerrit | Eran Gampel proposed openstack/smaug: Implement swift bank plugin https://review.openstack.org/279929 | 14:21 |
*** xiangxinyong456 has quit IRC | 14:48 | |
*** smile-luobin has joined #openstack-smaug | 15:00 | |
*** luobin has quit IRC | 15:04 | |
openstackgerrit | Yuval Brik proposed openstack/smaug: docs: fix operation_engine_design rst syntax https://review.openstack.org/292898 | 15:06 |
*** smile-luobin has quit IRC | 15:17 | |
*** yuval has quit IRC | 16:00 | |
*** openstackgerrit has quit IRC | 17:14 | |
*** openstackgerrit_ is now known as openstackgerrit | 17:14 | |
*** openstackgerrit has quit IRC | 17:15 | |
*** openstackgerrit_ has joined #openstack-smaug | 17:15 | |
*** openstackgerrit_ is now known as openstackgerrit | 17:16 | |
*** openstackgerrit_ has joined #openstack-smaug | 17:16 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!