openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Role Grant and Revoke https://review.openstack.org/501039 | 00:00 |
---|---|---|
*** gouthamr has quit IRC | 00:45 | |
*** gouthamr has joined #openstack-shade | 00:49 | |
*** thrash is now known as thrash|g0ne | 02:43 | |
mordred | SamYaple: I have submitted remote: https://review.openstack.org/501082 Release shade 1.23.0 | 02:57 |
*** gkadam has joined #openstack-shade | 03:16 | |
*** gouthamr has quit IRC | 03:46 | |
openstackgerrit | Merged openstack-infra/shade master: Remove improper exc handling in is_user_in_group https://review.openstack.org/500560 | 04:09 |
openstackgerrit | Merged openstack-infra/shade master: Begin converting baremetal node tests https://review.openstack.org/500847 | 05:50 |
*** ioggstream is now known as ioggstrea | 09:14 | |
*** openstackgerrit has quit IRC | 09:18 | |
*** ioggstrea is now known as _iogg | 09:19 | |
*** _iogg is now known as ioggstream | 09:19 | |
*** openstackgerrit has joined #openstack-shade | 09:46 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Roles for User in v2.0 https://review.openstack.org/501186 | 09:46 |
*** openstackgerrit has quit IRC | 10:03 | |
*** openstackgerrit has joined #openstack-shade | 10:13 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint List https://review.openstack.org/501200 | 10:13 |
samueldmq | morning shade | 10:13 |
samueldmq | 3 more patches to go with keystone calls restification yayy | 10:14 |
*** thrash|g0ne is now known as thrash | 10:29 | |
*** ioggstream has quit IRC | 10:34 | |
*** ioggstream has joined #openstack-shade | 10:46 | |
mordred | samueldmq: zomg. thta's so amazing | 11:33 |
samueldmq | :D | 11:56 |
samueldmq | mordred: isn't isinstance(thing, str) enough to test if thing is a string in python3 ? | 11:56 |
samueldmq | http://logs.openstack.org/86/501186/1/check/gate-shade-functional-legacy/6896762/console.html#_2017-09-06_10_32_14_746425 | 11:57 |
mordred | samueldmq: you want isinstance(thing, six.string_types) | 11:58 |
samueldmq | mordred: true, thanks | 12:07 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Roles for User in v2.0 https://review.openstack.org/501186 | 12:13 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Roles for User in v2.0 https://review.openstack.org/501186 | 12:17 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint List https://review.openstack.org/501200 | 12:20 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Roles for User in v2.0 https://review.openstack.org/501186 | 12:25 |
openstackgerrit | Merged openstack-infra/shade master: Use direct calls to get_<resource>_by_id https://review.openstack.org/494535 | 12:27 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint List https://review.openstack.org/501200 | 12:35 |
*** gkadam has quit IRC | 12:59 | |
samueldmq | I love consistency | 13:03 |
samueldmq | and the query params for listing role assignments aren;t consistent at all | 13:03 |
samueldmq | group_id, role_id, scope.domain.id, scope.OS-INHERIT:inherited_to, scope.project.id, user_id | 13:03 |
samueldmq | almost a different pattern for each of the allowed query params | 13:03 |
*** slaweq has quit IRC | 13:05 | |
*** gouthamr has joined #openstack-shade | 13:14 | |
mordred | samueldmq: wow - that's really nice | 13:16 |
samueldmq | mordred: even "nicier" is the code I wrote to translate those | 13:17 |
samueldmq | nicer* ? nvm even my translator can't find the right word :-) | 13:18 |
mordred | samueldmq: there is nothing uglier than code written to make ugly things better | 13:18 |
samueldmq | hehehe | 13:19 |
samueldmq | mordred: "scope.OS-INHERIT:inherited_to" only accepts "projects" as its value | 13:25 |
samueldmq | shade docs are not correct, I will get a patch for that too | 13:25 |
samueldmq | mordred: the filters actually are 'group.id', 'role.id', 'scope.domain.id', 'scope.project.id', 'scope.OS-INHERIT:inherited_to', 'user.id' | 13:43 |
samueldmq | it's the keysotne api-ref docs that are wrong | 13:44 |
samueldmq | and luckily shade implements things according to what's defined in code (and works) | 13:44 |
samueldmq | I mean, 1 pattern less. role_id becomes role.id | 13:45 |
mordred | samueldmq: yah - we code to what works, not to docs ;) | 13:50 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Role Assignments https://review.openstack.org/501268 | 13:52 |
samueldmq | mordred: ^ enjoy it! I tried to make it as simple as possible | 13:53 |
samueldmq | (also a question inline with the code) | 13:54 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Role Assignments https://review.openstack.org/501268 | 13:56 |
mordred | samueldmq: looks great - responded to question | 13:56 |
samueldmq | mordred: nice, just submitted anotehr version with removing the thing from _tasks | 13:56 |
samueldmq | mordred: thanks for the review | 13:57 |
samueldmq | and yay, 2 patches to go!!! | 13:57 |
mordred | samueldmq: SO CLOSE | 13:58 |
openstackgerrit | Merged openstack/os-client-config master: DataCentred supports Keystone V3 and Glance V2. https://review.openstack.org/493002 | 14:21 |
openstackgerrit | Merged openstack/os-client-config master: Updated from global requirements https://review.openstack.org/500013 | 14:21 |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add openstack-doc-build to shade https://review.openstack.org/500201 | 14:45 |
openstackgerrit | Merged openstack-infra/shade master: De-client-ify User Password Update https://review.openstack.org/500930 | 14:45 |
*** slaweq has joined #openstack-shade | 14:53 | |
*** rods has joined #openstack-shade | 15:24 | |
*** thrash is now known as thrash|biab | 15:49 | |
SamYaple | mordred: w00t | 15:59 |
SamYaple | thanks man | 16:00 |
*** slaweq has quit IRC | 16:39 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint Update https://review.openstack.org/501352 | 16:54 |
*** thrash|biab is now known as thrash | 17:33 | |
*** slaweq has joined #openstack-shade | 17:39 | |
*** slaweq has quit IRC | 17:42 | |
*** slaweq has joined #openstack-shade | 17:43 | |
*** ioggstream has quit IRC | 17:55 | |
openstackgerrit | Matthew Treinish proposed openstack-infra/shade master: Switch to using stestr https://review.openstack.org/491035 | 19:23 |
*** olaph has quit IRC | 19:50 | |
*** olaph has joined #openstack-shade | 19:51 | |
*** olaph1 has joined #openstack-shade | 19:55 | |
*** olaph has quit IRC | 19:56 | |
*** olaph1 is now known as olaph | 20:00 | |
*** slaweq has quit IRC | 20:47 | |
*** slaweq has joined #openstack-shade | 21:12 | |
*** gouthamr has quit IRC | 21:15 | |
*** yolanda has quit IRC | 21:26 | |
*** yolanda has joined #openstack-shade | 21:26 | |
*** olaph1 has joined #openstack-shade | 21:36 | |
*** olaph has quit IRC | 21:37 | |
*** umbSublime has quit IRC | 21:46 | |
*** olaph1 is now known as olaph | 21:51 | |
*** umbSublime has joined #openstack-shade | 22:06 | |
*** umbSublime has joined #openstack-shade | 22:06 | |
*** slaweq has quit IRC | 22:37 | |
openstackgerrit | Monty Taylor proposed openstack-infra/shade master: DNM testing https://review.openstack.org/501485 | 22:50 |
*** gouthamr has joined #openstack-shade | 22:52 | |
*** rods has quit IRC | 23:20 | |
*** rods has joined #openstack-shade | 23:21 | |
*** slaweq has joined #openstack-shade | 23:38 | |
*** slaweq has quit IRC | 23:43 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!