Wednesday, 2017-09-06

openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Role Grant and Revoke  https://review.openstack.org/50103900:00
*** gouthamr has quit IRC00:45
*** gouthamr has joined #openstack-shade00:49
*** thrash is now known as thrash|g0ne02:43
mordredSamYaple: I have submitted remote:   https://review.openstack.org/501082 Release shade 1.23.002:57
*** gkadam has joined #openstack-shade03:16
*** gouthamr has quit IRC03:46
openstackgerritMerged openstack-infra/shade master: Remove improper exc handling in is_user_in_group  https://review.openstack.org/50056004:09
openstackgerritMerged openstack-infra/shade master: Begin converting baremetal node tests  https://review.openstack.org/50084705:50
*** ioggstream is now known as ioggstrea09:14
*** openstackgerrit has quit IRC09:18
*** ioggstrea is now known as _iogg09:19
*** _iogg is now known as ioggstream09:19
*** openstackgerrit has joined #openstack-shade09:46
openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Roles for User in v2.0  https://review.openstack.org/50118609:46
*** openstackgerrit has quit IRC10:03
*** openstackgerrit has joined #openstack-shade10:13
openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint List  https://review.openstack.org/50120010:13
samueldmqmorning shade10:13
samueldmq3 more patches to go with keystone calls restification yayy10:14
*** thrash|g0ne is now known as thrash10:29
*** ioggstream has quit IRC10:34
*** ioggstream has joined #openstack-shade10:46
mordredsamueldmq: zomg. thta's so amazing11:33
samueldmq:D11:56
samueldmqmordred: isn't isinstance(thing, str) enough to test if thing is a string in python3 ?11:56
samueldmqhttp://logs.openstack.org/86/501186/1/check/gate-shade-functional-legacy/6896762/console.html#_2017-09-06_10_32_14_74642511:57
mordredsamueldmq: you want isinstance(thing, six.string_types)11:58
samueldmqmordred: true, thanks12:07
openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Roles for User in v2.0  https://review.openstack.org/50118612:13
openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Roles for User in v2.0  https://review.openstack.org/50118612:17
openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint List  https://review.openstack.org/50120012:20
openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Roles for User in v2.0  https://review.openstack.org/50118612:25
openstackgerritMerged openstack-infra/shade master: Use direct calls to get_<resource>_by_id  https://review.openstack.org/49453512:27
openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint List  https://review.openstack.org/50120012:35
*** gkadam has quit IRC12:59
samueldmqI love consistency13:03
samueldmqand the query params for listing role assignments aren;t consistent at all13:03
samueldmqgroup_id, role_id, scope.domain.id, scope.OS-INHERIT:inherited_to, scope.project.id, user_id13:03
samueldmqalmost a different pattern for each of the allowed query params13:03
*** slaweq has quit IRC13:05
*** gouthamr has joined #openstack-shade13:14
mordredsamueldmq: wow - that's really nice13:16
samueldmqmordred: even "nicier" is the code I wrote to translate those13:17
samueldmqnicer* ? nvm even my translator can't find the right word :-)13:18
mordredsamueldmq: there is nothing uglier than code written to make ugly things better13:18
samueldmqhehehe13:19
samueldmqmordred: "scope.OS-INHERIT:inherited_to" only accepts "projects" as its value13:25
samueldmqshade docs are not correct, I will get a patch for that too13:25
samueldmqmordred: the filters actually are 'group.id', 'role.id', 'scope.domain.id', 'scope.project.id', 'scope.OS-INHERIT:inherited_to', 'user.id'13:43
samueldmqit's the keysotne api-ref docs that are wrong13:44
samueldmqand luckily shade implements things according to what's defined in code (and works)13:44
samueldmqI mean, 1 pattern less. role_id becomes role.id13:45
mordredsamueldmq: yah - we code to what works, not to docs ;)13:50
openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Role Assignments  https://review.openstack.org/50126813:52
samueldmqmordred: ^ enjoy it! I tried to make it as simple as possible13:53
samueldmq(also a question inline with the code)13:54
openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify List Role Assignments  https://review.openstack.org/50126813:56
mordredsamueldmq: looks great - responded to question13:56
samueldmqmordred: nice, just submitted anotehr version with removing the thing from _tasks13:56
samueldmqmordred: thanks for the review13:57
samueldmqand yay, 2 patches to go!!!13:57
mordredsamueldmq: SO CLOSE13:58
openstackgerritMerged openstack/os-client-config master: DataCentred supports Keystone V3 and Glance V2.  https://review.openstack.org/49300214:21
openstackgerritMerged openstack/os-client-config master: Updated from global requirements  https://review.openstack.org/50001314:21
openstackgerritMonty Taylor proposed openstack-infra/shade master: Add openstack-doc-build to shade  https://review.openstack.org/50020114:45
openstackgerritMerged openstack-infra/shade master: De-client-ify User Password Update  https://review.openstack.org/50093014:45
*** slaweq has joined #openstack-shade14:53
*** rods has joined #openstack-shade15:24
*** thrash is now known as thrash|biab15:49
SamYaplemordred: w00t15:59
SamYaplethanks man16:00
*** slaweq has quit IRC16:39
openstackgerritSamuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Endpoint Update  https://review.openstack.org/50135216:54
*** thrash|biab is now known as thrash17:33
*** slaweq has joined #openstack-shade17:39
*** slaweq has quit IRC17:42
*** slaweq has joined #openstack-shade17:43
*** ioggstream has quit IRC17:55
openstackgerritMatthew Treinish proposed openstack-infra/shade master: Switch to using stestr  https://review.openstack.org/49103519:23
*** olaph has quit IRC19:50
*** olaph has joined #openstack-shade19:51
*** olaph1 has joined #openstack-shade19:55
*** olaph has quit IRC19:56
*** olaph1 is now known as olaph20:00
*** slaweq has quit IRC20:47
*** slaweq has joined #openstack-shade21:12
*** gouthamr has quit IRC21:15
*** yolanda has quit IRC21:26
*** yolanda has joined #openstack-shade21:26
*** olaph1 has joined #openstack-shade21:36
*** olaph has quit IRC21:37
*** umbSublime has quit IRC21:46
*** olaph1 is now known as olaph21:51
*** umbSublime has joined #openstack-shade22:06
*** umbSublime has joined #openstack-shade22:06
*** slaweq has quit IRC22:37
openstackgerritMonty Taylor proposed openstack-infra/shade master: DNM testing  https://review.openstack.org/50148522:50
*** gouthamr has joined #openstack-shade22:52
*** rods has quit IRC23:20
*** rods has joined #openstack-shade23:21
*** slaweq has joined #openstack-shade23:38
*** slaweq has quit IRC23:43

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!