| *** gouthamr has joined #openstack-shade | 00:12 | |
| *** gouthamr has quit IRC | 01:13 | |
| *** gkadam has quit IRC | 01:28 | |
| *** gouthamr has joined #openstack-shade | 01:30 | |
| *** slaweq has joined #openstack-shade | 01:42 | |
| *** slaweq has quit IRC | 01:47 | |
| *** gouthamr has quit IRC | 02:34 | |
| *** slaweq has joined #openstack-shade | 02:43 | |
| *** slaweq has quit IRC | 02:48 | |
| *** slaweq has joined #openstack-shade | 03:44 | |
| *** slaweq has quit IRC | 03:49 | |
| *** slaweq has joined #openstack-shade | 04:45 | |
| *** slaweq_ has joined #openstack-shade | 04:50 | |
| *** slaweq has quit IRC | 04:50 | |
| *** slaweq_ has quit IRC | 04:55 | |
| *** slaweq has joined #openstack-shade | 05:51 | |
| *** slaweq has quit IRC | 05:56 | |
| *** slaweq has joined #openstack-shade | 06:40 | |
| *** slaweq_ has joined #openstack-shade | 07:53 | |
| *** slaweq_ has quit IRC | 07:58 | |
| *** iogg has joined #openstack-shade | 07:59 | |
| *** slaweq has quit IRC | 08:33 | |
| *** slaweq has joined #openstack-shade | 08:54 | |
| *** slaweq has quit IRC | 08:59 | |
| *** rods has joined #openstack-shade | 09:37 | |
| *** slaweq has joined #openstack-shade | 09:55 | |
| *** slaweq has quit IRC | 10:00 | |
| *** slaweq has joined #openstack-shade | 10:19 | |
| *** slaweq has quit IRC | 10:34 | |
| *** slaweq has joined #openstack-shade | 10:36 | |
| rods | mordred what's up with https://review.openstack.org/#/c/492080/6? definitely needed for the work on _get_entity we talked about :) | 10:52 |
|---|---|---|
| rods | mordred looking at the _get_entity method https://github.com/openstack-infra/shade/blob/master/shade/_utils.py#L218 | 11:39 |
| rods | looks like if an object is passed, we are already short-circuit it and returning back the object | 11:40 |
| rods | so my understanding is that the use case we need to cover is when a UUID is passed. In that case we want to short-circuit the thing calling the get_<resource>_by_id method | 11:42 |
| *** slaweq has quit IRC | 11:43 | |
| rods | is that correct? | 11:43 |
| *** slaweq has joined #openstack-shade | 11:43 | |
| *** slaweq has quit IRC | 11:44 | |
| *** slaweq has joined #openstack-shade | 11:45 | |
| *** slaweq_ has joined #openstack-shade | 11:57 | |
| *** slaweq_ has quit IRC | 12:02 | |
| *** slaweq has quit IRC | 12:05 | |
| *** slaweq has joined #openstack-shade | 12:05 | |
| *** slaweq has quit IRC | 12:10 | |
| rods | mordred what about something like http://paste.openstack.org/show/618518/? | 12:11 |
| rods | 'is_uuid' needs to be defined, but you get the idea | 12:12 |
| rods | do we need the `use_direct_get` flag? | 12:17 |
| *** slaweq has joined #openstack-shade | 12:18 | |
| rods | if so, we just need to small change `if is_uuid(name_or_id) and cloud.use_direct_get:` | 12:18 |
| rods | *to make a small change | 12:19 |
| mordred | rods: we still need the flag because there are things (like nodepool) that never want to use direct get and instead always want to do the list/filter approach for concurrency reasons | 12:21 |
| mordred | rods: but - I think the is_uuid approach is a good one | 12:21 |
| mordred | rods: there are one or two places where id's are not uuids, but they'll just fallback to the list/filter approach we use today, so I think that's fine | 12:24 |
| mordred | rods: so if is_uuid(name_or_id): becomes if use_direct_get and is_uuid(name_or_id): and I think that's a _great_ approach | 12:24 |
| rods | cool, I'll keep going that direction | 12:25 |
| *** rods has quit IRC | 12:36 | |
| *** slaweq_ has joined #openstack-shade | 12:58 | |
| *** rods has joined #openstack-shade | 12:58 | |
| *** rods has joined #openstack-shade | 12:59 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use new keystoneauth version discovery https://review.openstack.org/493582 | 13:01 |
| *** slaweq_ has quit IRC | 13:03 | |
| *** rods has quit IRC | 13:09 | |
| *** rods has joined #openstack-shade | 13:10 | |
| *** rods has quit IRC | 13:14 | |
| *** gouthamr has joined #openstack-shade | 13:15 | |
| *** rods has joined #openstack-shade | 13:33 | |
| rods | looks like a bunch of projects are defining their own version of the `is_uuid_like` function(http://codesearch.openstack.org/?q=def%20is_uuid_like&i=nope&files=&repos=), even though is already defined in oslo.utils http://git.openstack.org/cgit/openstack/oslo.utils/tree/oslo_utils/uuidutils.py | 13:50 |
| rods | mordred ^^ how do we feel about adding a dependency? should we just copy/paste the code | 13:51 |
| mordred | rods: let's just copy the code - I'd rather avoid the oslo stack if we can - it's better suited for server-side stuff | 13:57 |
| rods | ya | 13:58 |
| *** slaweq_ has joined #openstack-shade | 13:59 | |
| *** slaweq_ has quit IRC | 14:04 | |
| *** slaweq has quit IRC | 14:30 | |
| *** gkadam has joined #openstack-shade | 14:45 | |
| *** slaweq has joined #openstack-shade | 15:00 | |
| *** slaweq has quit IRC | 15:05 | |
| *** gkadam is now known as gkadam-afk | 15:24 | |
| *** gkadam-afk has quit IRC | 15:31 | |
| *** gkadam has joined #openstack-shade | 15:32 | |
| *** yolanda has quit IRC | 15:44 | |
| *** yolanda has joined #openstack-shade | 15:44 | |
| kmalloc | mordred: ++ please no oslo | 15:55 |
| kmalloc | (or more oslo as the case may be) | 15:55 |
| *** slaweq has joined #openstack-shade | 16:01 | |
| mordred | there is no oslo in shade currently - other than pbr - but that's different | 16:02 |
| *** slaweq has quit IRC | 16:06 | |
| *** iogg has quit IRC | 16:09 | |
| *** iogg has joined #openstack-shade | 16:21 | |
| *** iogg has quit IRC | 16:26 | |
| *** slaweq has joined #openstack-shade | 17:03 | |
| *** slaweq has quit IRC | 17:07 | |
| * kmalloc still wants to ditch runtime requirement for PBR in ksa | 17:10 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use new keystoneauth version discovery https://review.openstack.org/493582 | 17:16 |
| *** gkadam has quit IRC | 17:25 | |
| *** slaweq has joined #openstack-shade | 18:03 | |
| *** slaweq has quit IRC | 18:09 | |
| *** slaweq has joined #openstack-shade | 18:15 | |
| *** iogg has joined #openstack-shade | 19:49 | |
| openstackgerrit | Slawek Kaplonski proposed openstack-infra/shade master: Don't determine local IPv6 support if force_ip4=True https://review.openstack.org/494319 | 20:35 |
| openstackgerrit | Slawek Kaplonski proposed openstack-infra/shade master: Fix determining if IPv6 is supported when it's disabled https://review.openstack.org/494321 | 20:38 |
| mordred | slaweq: wow. that's fun with that AttributeError | 20:39 |
| slaweq | mordred: why? :) | 20:40 |
| slaweq | in fact I cannot reproduce it on my Ubuntu 16.04 but I based on bug report https://storyboard.openstack.org/?#!/story/2001001 | 20:40 |
| slaweq | mordred: and BTW. You are really fast with reviewing patches ;) | 20:41 |
| mordred | slaweq: :) | 20:42 |
| *** gouthamr has quit IRC | 20:46 | |
| *** slaweq has quit IRC | 21:06 | |
| *** slaweq has joined #openstack-shade | 21:06 | |
| *** slaweq has quit IRC | 21:11 | |
| *** slaweq has joined #openstack-shade | 21:36 | |
| *** slaweq has quit IRC | 21:42 | |
| *** slaweq has joined #openstack-shade | 21:43 | |
| *** slaweq has quit IRC | 21:47 | |
| *** iogg has quit IRC | 21:55 | |
| *** rods has quit IRC | 22:08 | |
| *** rods has joined #openstack-shade | 22:11 | |
| *** gouthamr has joined #openstack-shade | 23:27 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!