*** chyka_ has quit IRC | 00:07 | |
*** markvoelker_ has quit IRC | 00:07 | |
*** markvoelker has joined #openstack-security | 00:08 | |
*** markvoelker has quit IRC | 00:12 | |
*** markvoelker has joined #openstack-security | 00:18 | |
*** dave-mccowan has joined #openstack-security | 00:47 | |
*** liverpooler has joined #openstack-security | 00:58 | |
*** markvoelker has quit IRC | 01:03 | |
*** markvoelker has joined #openstack-security | 01:03 | |
*** markvoelker has quit IRC | 01:08 | |
*** edmondsw has joined #openstack-security | 01:08 | |
*** edmondsw has quit IRC | 01:13 | |
*** liujiong_lj has joined #openstack-security | 01:32 | |
*** liujiong_lj is now known as liujiong | 01:43 | |
*** nikhil has quit IRC | 01:59 | |
*** sxc731 has joined #openstack-security | 01:59 | |
*** mihdih has quit IRC | 02:17 | |
*** salv-orlando has joined #openstack-security | 02:26 | |
*** salv-orl_ has quit IRC | 02:29 | |
*** sxc731 has quit IRC | 02:37 | |
*** dave-mccowan has quit IRC | 03:05 | |
*** liverpooler has quit IRC | 03:11 | |
*** AlexeyAbashkin has joined #openstack-security | 04:18 | |
*** AlexeyAbashkin has quit IRC | 04:22 | |
*** sxc731 has joined #openstack-security | 04:22 | |
*** mihdih has joined #openstack-security | 04:25 | |
*** mihdih has quit IRC | 04:26 | |
*** mihdih has joined #openstack-security | 04:28 | |
*** mihdih has quit IRC | 04:29 | |
*** mihdih has joined #openstack-security | 04:58 | |
*** pcaruana has joined #openstack-security | 05:58 | |
*** edmondsw has joined #openstack-security | 06:32 | |
*** edmondsw has quit IRC | 06:36 | |
*** sxc731 has quit IRC | 06:56 | |
*** liujiong has quit IRC | 07:15 | |
*** liujiong has joined #openstack-security | 07:16 | |
*** rcernin has quit IRC | 07:27 | |
*** openstackgerrit has joined #openstack-security | 07:28 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/anchor master: Updated from global requirements https://review.openstack.org/438424 | 07:28 |
---|---|---|
openstackgerrit | OpenStack Proposal Bot proposed openstack/anchor master: Updated from global requirements https://review.openstack.org/438424 | 07:31 |
*** sxc731 has joined #openstack-security | 07:48 | |
*** sxc731 has quit IRC | 07:53 | |
*** sxc731 has joined #openstack-security | 07:54 | |
*** AlexeyAbashkin has joined #openstack-security | 07:58 | |
openstackgerrit | Summer Long proposed openstack/security-doc master: General security-guide edits https://review.openstack.org/517200 | 08:04 |
*** salv-orlando has quit IRC | 08:08 | |
*** tesseract has joined #openstack-security | 08:10 | |
openstackgerrit | Merged openstack/security-doc master: Correct pipeline name for configuring keystone authentication https://review.openstack.org/516565 | 08:16 |
*** edmondsw has joined #openstack-security | 08:20 | |
*** edmondsw has quit IRC | 08:25 | |
*** rcernin has joined #openstack-security | 08:26 | |
*** spectr has joined #openstack-security | 08:36 | |
*** nkinder has quit IRC | 08:47 | |
*** salv-orlando has joined #openstack-security | 09:06 | |
*** sxc731 has quit IRC | 09:15 | |
*** sxc731 has joined #openstack-security | 09:15 | |
*** liujiong has quit IRC | 09:19 | |
*** liujiong has joined #openstack-security | 09:19 | |
*** gouthamr has quit IRC | 09:26 | |
*** sxc731 has quit IRC | 09:42 | |
*** sxc731 has joined #openstack-security | 09:45 | |
*** chas has joined #openstack-security | 09:49 | |
openstackgerrit | Jeremy Liu proposed openstack/syntribos master: Remove explicit version info from setup.cfg https://review.openstack.org/517232 | 09:52 |
*** edmondsw has joined #openstack-security | 10:08 | |
*** nkinder has joined #openstack-security | 10:10 | |
*** edmondsw has quit IRC | 10:13 | |
*** nkinder has quit IRC | 10:16 | |
*** liujiong has quit IRC | 10:19 | |
*** nkinder has joined #openstack-security | 10:20 | |
*** aselius has quit IRC | 10:21 | |
*** austin987 has quit IRC | 10:52 | |
*** edmondsw has joined #openstack-security | 11:54 | |
*** rcernin has quit IRC | 11:56 | |
*** edmondsw has quit IRC | 11:58 | |
*** mihdih has quit IRC | 12:14 | |
*** macermak has joined #openstack-security | 12:16 | |
macermak | Hey guys, I'd need a hand with https://review.openstack.org/#/c/510602/ ... I'd like to finish it up, so that it could be merged, but I find it pretty hard to pass the 2 readme tests.. I made a diff and I see no errors.. I lack some reviews to this. Could anyone help me with this, please? | 12:25 |
*** catintheroof has joined #openstack-security | 12:34 | |
*** dave-mccowan has joined #openstack-security | 12:36 | |
*** markvoelker has joined #openstack-security | 12:49 | |
*** markvoelker_ has joined #openstack-security | 12:50 | |
*** mihdih has joined #openstack-security | 12:52 | |
*** markvoelker has quit IRC | 12:53 | |
*** edmondsw has joined #openstack-security | 13:10 | |
*** liverpooler has joined #openstack-security | 13:12 | |
*** salv-orlando has quit IRC | 13:16 | |
*** AlexeyAbashkin has quit IRC | 13:23 | |
*** sxc731 has quit IRC | 13:28 | |
*** lbragstad has joined #openstack-security | 13:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/anchor master: Updated from global requirements https://review.openstack.org/438424 | 13:40 |
*** sxc731 has joined #openstack-security | 13:40 | |
*** markvoel_ has joined #openstack-security | 13:41 | |
*** markvoelker_ has quit IRC | 13:42 | |
*** AlexeyAbashkin has joined #openstack-security | 13:45 | |
*** B_Smith_ has joined #openstack-security | 13:47 | |
*** markvoel_ has quit IRC | 13:47 | |
*** B_Smith has quit IRC | 13:47 | |
*** salv-orlando has joined #openstack-security | 14:12 | |
*** liverpooler has quit IRC | 14:19 | |
*** liverpooler has joined #openstack-security | 14:25 | |
*** nikhil has joined #openstack-security | 14:29 | |
*** spectr-RH has joined #openstack-security | 14:30 | |
*** sxc731 has quit IRC | 14:31 | |
*** spectr has quit IRC | 14:33 | |
gagehugo | macermak sorry I've on vacation lately, I have that on my list of things to review | 14:41 |
macermak | Hi gagehugo. Sure, no prob, thank you. Hope you enjoyed it :) (envy) | 14:43 |
*** vds has quit IRC | 14:55 | |
*** austin987 has joined #openstack-security | 14:56 | |
*** chyka has joined #openstack-security | 15:17 | |
*** salv-orlando has quit IRC | 15:25 | |
*** salv-orlando has joined #openstack-security | 15:40 | |
*** spectr has joined #openstack-security | 15:41 | |
*** spectr-RH has quit IRC | 15:44 | |
*** chyka_ has joined #openstack-security | 15:51 | |
*** AlexeyAbashkin has quit IRC | 15:53 | |
*** chyka has quit IRC | 15:54 | |
*** spectr has quit IRC | 15:55 | |
*** vds has joined #openstack-security | 16:15 | |
*** dave-mccowan has quit IRC | 16:22 | |
*** catintheroof has quit IRC | 16:26 | |
*** catintheroof has joined #openstack-security | 16:30 | |
*** vds has quit IRC | 16:39 | |
*** lbragstad has quit IRC | 16:46 | |
*** markvoelker_ has joined #openstack-security | 17:07 | |
*** nikhil has quit IRC | 17:09 | |
*** markvoelker_ has quit IRC | 17:11 | |
*** markvoelker has joined #openstack-security | 17:12 | |
*** markvoelker has quit IRC | 17:13 | |
*** markvoelker has joined #openstack-security | 17:18 | |
openstackgerrit | Gage Hugo proposed openstack/bandit master: Custom formatter https://review.openstack.org/510602 | 17:18 |
gagehugo | macermak ^ should fix that help test issue | 17:19 |
gagehugo | feel free to change as you please | 17:19 |
*** markvoelker_ has joined #openstack-security | 17:21 | |
*** markvoelker has quit IRC | 17:23 | |
*** markvoelker has joined #openstack-security | 17:24 | |
*** markvoelker_ has quit IRC | 17:26 | |
*** markvoelker_ has joined #openstack-security | 17:28 | |
*** markvoelker has quit IRC | 17:29 | |
*** lbragstad has joined #openstack-security | 17:29 | |
*** vds has joined #openstack-security | 17:30 | |
*** AlexeyAbashkin has joined #openstack-security | 17:31 | |
*** markvoelker_ has quit IRC | 17:34 | |
*** AlexeyAbashkin has quit IRC | 17:35 | |
*** gyee has joined #openstack-security | 17:37 | |
*** aselius has joined #openstack-security | 17:44 | |
macermak | gagehugo, thanks, will look into it asap | 17:53 |
*** gouthamr has joined #openstack-security | 18:00 | |
*** AlexeyAbashkin has joined #openstack-security | 18:09 | |
*** pcaruana has quit IRC | 18:10 | |
*** AlexeyAbashkin has quit IRC | 18:14 | |
*** vds has quit IRC | 18:18 | |
*** tesseract has quit IRC | 18:25 | |
*** chyka has joined #openstack-security | 18:26 | |
*** chyka_ has quit IRC | 18:29 | |
macermak | gagehugo, I did a review, I don't think thats a good way to go... to remove the section from --help completely | 18:38 |
gagehugo | macermak I'm fine with adding it back | 18:40 |
macermak | also, lhinds, I wanted to attend the meating but I realized we had a time change last week and I am not gonna be able to manage the meetings for the next few weeks, did you have any updates to the custom formatter? | 18:40 |
gagehugo | I threw it at the bottom to simplify debugging why the help_text was failing | 18:40 |
macermak | gagehugo, I see .. what about the change with `custom` being at the end of formatters? It was pointed in patchset 3 by Tovin Seven that I should put it at the end | 18:41 |
gagehugo | macermak that seemed hacky imo but you can put it back if you want, I don't care either way | 18:42 |
macermak | tbh, I like it better this way, I just wanted to make him happy, now we are 2 against 1, thats cool | 18:42 |
gagehugo | and yeah I forgot to add the custom formatter section to the man pages too | 18:42 |
gagehugo | doh | 18:42 |
macermak | aight, I'll do it.. so the issue in tests was solved by the change in test_runtime..? | 18:43 |
*** vds has joined #openstack-security | 18:43 | |
gagehugo | yeah, after eliminating that custom section from --help, it ended up being a single newline causing the failure | 18:44 |
gagehugo | the test is very hacky as well imo | 18:45 |
gagehugo | I see its purpose, but I wonder if it could be changed to be better | 18:45 |
macermak | Ah, great, so lets hope I don't mess up anything so that we could finish it finally | 18:50 |
macermak | Ye, I agree, these two tests aren't very friendly. | 18:50 |
openstackgerrit | Gage Hugo proposed openstack/bandit master: Migrate to stestr https://review.openstack.org/517408 | 18:52 |
gagehugo | lhinds ^ stestr does not have the db type not found error | 18:53 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/anchor master: Updated from global requirements https://review.openstack.org/438424 | 19:12 |
*** liverpooler has quit IRC | 19:14 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/anchor master: Updated from global requirements https://review.openstack.org/438424 | 19:20 |
openstackgerrit | Marek Cermak proposed openstack/bandit master: Custom formatter https://review.openstack.org/510602 | 19:29 |
*** liverpooler has joined #openstack-security | 19:30 | |
*** dave-mccowan has joined #openstack-security | 19:33 | |
*** liverpooler has quit IRC | 19:35 | |
*** macermak has quit IRC | 19:35 | |
*** edmondsw has quit IRC | 19:51 | |
*** dave-mccowan has quit IRC | 19:56 | |
*** dave-mccowan has joined #openstack-security | 20:15 | |
*** liverpooler has joined #openstack-security | 20:16 | |
*** gyee has quit IRC | 20:18 | |
*** dave-mccowan has quit IRC | 20:35 | |
*** gyee has joined #openstack-security | 20:36 | |
*** gyee has quit IRC | 20:54 | |
*** liverpooler has quit IRC | 21:03 | |
*** AlexeyAbashkin has joined #openstack-security | 21:08 | |
*** AlexeyAbashkin has quit IRC | 21:13 | |
*** d0ugal has quit IRC | 21:40 | |
*** d0ugal has joined #openstack-security | 21:46 | |
*** catintheroof has quit IRC | 21:53 | |
*** rcernin has joined #openstack-security | 22:01 | |
*** AlexeyAbashkin has joined #openstack-security | 22:08 | |
*** mihdih has quit IRC | 22:08 | |
*** AlexeyAbashkin has quit IRC | 22:13 | |
*** lbragstad has quit IRC | 22:24 | |
*** sxc731 has joined #openstack-security | 22:53 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/anchor master: Updated from global requirements https://review.openstack.org/438424 | 23:04 |
*** chyka_ has joined #openstack-security | 23:09 | |
*** chyka has quit IRC | 23:12 | |
*** chyka_ has quit IRC | 23:13 | |
*** rcernin has quit IRC | 23:17 | |
*** ssathaye has quit IRC | 23:17 | |
*** ssathaye has joined #openstack-security | 23:18 | |
*** sxc731 has quit IRC | 23:32 | |
*** nikhil has joined #openstack-security | 23:41 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!