| *** mdong has joined #openstack-security | 00:52 | |
| *** serverascode has quit IRC | 01:10 | |
| *** aimeeu has quit IRC | 01:10 | |
| *** jraim has quit IRC | 01:10 | |
| *** vinaypotluri has joined #openstack-security | 01:13 | |
| *** salv-orlando has joined #openstack-security | 01:17 | |
| *** salv-orlando has quit IRC | 01:22 | |
| *** aimeeu has joined #openstack-security | 01:25 | |
| *** sdake_ has quit IRC | 01:25 | |
| *** serverascode has joined #openstack-security | 01:26 | |
| *** austin987 has joined #openstack-security | 01:27 | |
| *** jraim has joined #openstack-security | 01:28 | |
| *** jamielennox is now known as jamielennox|away | 01:30 | |
| *** sdake has joined #openstack-security | 01:30 | |
| *** jamielennox|away is now known as jamielennox | 01:43 | |
| *** mdong has quit IRC | 02:03 | |
| *** salv-orlando has joined #openstack-security | 02:24 | |
| *** salv-orlando has quit IRC | 02:27 | |
| *** yuanying has quit IRC | 02:51 | |
| *** yuanying has joined #openstack-security | 02:52 | |
| *** dave-mccowan has quit IRC | 03:17 | |
| *** jamielennox is now known as jamielennox|away | 03:21 | |
| *** mvaldes has joined #openstack-security | 03:24 | |
| *** markvoelker has joined #openstack-security | 03:27 | |
| *** mvaldes1 has joined #openstack-security | 03:29 | |
| *** markvoelker_ has joined #openstack-security | 03:29 | |
| *** mvaldes has quit IRC | 03:31 | |
| *** markvoelker has quit IRC | 03:33 | |
| *** yuanying has quit IRC | 03:44 | |
| *** markvoelker_ has quit IRC | 03:53 | |
| *** markvoelker has joined #openstack-security | 03:54 | |
| *** jamielennox|away is now known as jamielennox | 03:56 | |
| *** jass93 has quit IRC | 04:03 | |
| *** jass93 has joined #openstack-security | 04:03 | |
| *** mvaldes1 has quit IRC | 04:12 | |
| *** mvaldes has joined #openstack-security | 04:15 | |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: patch to sanitize debug log https://review.openstack.org/360127 | 04:15 |
|---|---|---|
| *** salv-orlando has joined #openstack-security | 04:18 | |
| *** salv-orlando has quit IRC | 04:23 | |
| openstackgerrit | Merged openstack/security-analysis: Cleanup tox.ini https://review.openstack.org/360991 | 04:40 |
| openstackgerrit | Merged openstack/security-analysis: Update requirements https://review.openstack.org/361167 | 04:40 |
| *** mvaldes has quit IRC | 04:54 | |
| *** yuanying has joined #openstack-security | 05:03 | |
| *** sdake_ has joined #openstack-security | 05:10 | |
| *** sdake_ is now known as dake | 05:13 | |
| *** sdake has quit IRC | 05:13 | |
| *** dake is now known as sdake | 05:13 | |
| *** sdake has quit IRC | 05:26 | |
| *** markvoelker has quit IRC | 05:36 | |
| *** salv-orlando has joined #openstack-security | 05:36 | |
| *** liverpooler has joined #openstack-security | 05:50 | |
| *** salv-orlando has quit IRC | 06:05 | |
| *** markvoelker has joined #openstack-security | 06:07 | |
| *** salv-orlando has joined #openstack-security | 06:07 | |
| *** markvoelker has quit IRC | 06:11 | |
| *** yuanying has quit IRC | 06:29 | |
| *** markvoelker has joined #openstack-security | 06:36 | |
| *** markvoelker has quit IRC | 06:41 | |
| *** rcernin has joined #openstack-security | 06:47 | |
| *** pcaruana has joined #openstack-security | 07:00 | |
| *** tesseract- has joined #openstack-security | 07:01 | |
| *** markvoelker has joined #openstack-security | 07:06 | |
| *** markvoelker has quit IRC | 07:12 | |
| *** markvoelker has joined #openstack-security | 07:36 | |
| *** markvoelker has quit IRC | 07:41 | |
| *** yuanying has joined #openstack-security | 07:51 | |
| openstackgerrit | gecong proposed openstack/anchor: Add Python 3.5 classifier and venv https://review.openstack.org/361921 | 07:57 |
| *** markvoelker has joined #openstack-security | 08:05 | |
| *** markvoelker has quit IRC | 08:10 | |
| *** vinaypotluri has quit IRC | 08:21 | |
| *** markvoelker has joined #openstack-security | 08:33 | |
| *** trisq has joined #openstack-security | 08:38 | |
| *** markvoelker has quit IRC | 08:38 | |
| *** salv-orlando has quit IRC | 08:49 | |
| *** markvoelker has joined #openstack-security | 09:03 | |
| *** shohel has joined #openstack-security | 09:07 | |
| *** markvoelker has quit IRC | 09:07 | |
| *** shohel has quit IRC | 09:11 | |
| *** salv-orlando has joined #openstack-security | 09:20 | |
| *** shohel has joined #openstack-security | 09:26 | |
| *** markvoelker has joined #openstack-security | 09:31 | |
| *** markvoelker has quit IRC | 09:35 | |
| *** dave-mccowan has joined #openstack-security | 09:50 | |
| *** zigo_ is now known as zigo | 09:56 | |
| *** markvoelker has joined #openstack-security | 10:00 | |
| *** markvoelker has quit IRC | 10:05 | |
| *** edaught has quit IRC | 10:18 | |
| *** markvoelker has joined #openstack-security | 10:28 | |
| *** markvoelker has quit IRC | 10:32 | |
| *** austin987 has quit IRC | 10:32 | |
| *** _sigmavirus24 is now known as sigmavirus | 10:47 | |
| *** sigmavirus has joined #openstack-security | 10:47 | |
| *** markvoelker has joined #openstack-security | 10:59 | |
| *** markvoelker has quit IRC | 11:03 | |
| *** trisq has quit IRC | 11:09 | |
| *** markvoelker has joined #openstack-security | 11:28 | |
| *** markvoelker has quit IRC | 11:32 | |
| *** markvoelker has joined #openstack-security | 11:57 | |
| *** markvoelker has quit IRC | 12:01 | |
| *** dave-mcc_ has joined #openstack-security | 12:07 | |
| *** salv-orl_ has joined #openstack-security | 12:08 | |
| *** dave-mccowan has quit IRC | 12:09 | |
| *** salv-orlando has quit IRC | 12:10 | |
| *** salv-orl_ has quit IRC | 12:16 | |
| *** markvoelker has joined #openstack-security | 12:26 | |
| *** salv-orlando has joined #openstack-security | 12:29 | |
| *** markvoelker has quit IRC | 12:30 | |
| *** trisq has joined #openstack-security | 12:53 | |
| *** markvoelker has joined #openstack-security | 12:56 | |
| *** markvoelker has quit IRC | 13:00 | |
| *** pcaruana has quit IRC | 13:02 | |
| *** sdake has joined #openstack-security | 13:03 | |
| *** _elmiko is now known as elmiko | 13:05 | |
| *** markvoelker has joined #openstack-security | 13:06 | |
| *** markvoelker_ has joined #openstack-security | 13:07 | |
| *** markvoelker_ has quit IRC | 13:10 | |
| *** markvoelker has quit IRC | 13:10 | |
| *** markvoelker_ has joined #openstack-security | 13:10 | |
| *** markvoelker has joined #openstack-security | 13:11 | |
| *** markvoelker_ has quit IRC | 13:13 | |
| *** cleong has joined #openstack-security | 13:14 | |
| *** pcaruana has joined #openstack-security | 13:17 | |
| *** sdake_ has joined #openstack-security | 13:23 | |
| *** sdake has quit IRC | 13:25 | |
| *** markvoelker has quit IRC | 13:30 | |
| *** jass93 has quit IRC | 13:42 | |
| *** woodburn has joined #openstack-security | 13:50 | |
| *** sdake_ has quit IRC | 13:50 | |
| *** sdake has joined #openstack-security | 13:51 | |
| *** woodster_ has joined #openstack-security | 13:54 | |
| *** pcaruana has quit IRC | 13:55 | |
| *** markvoelker has joined #openstack-security | 13:57 | |
| *** markvoelker has quit IRC | 14:01 | |
| *** lmiccini has quit IRC | 14:07 | |
| *** cgross has quit IRC | 14:08 | |
| *** pcaruana has joined #openstack-security | 14:09 | |
| *** cgross has joined #openstack-security | 14:09 | |
| *** lmiccini has joined #openstack-security | 14:14 | |
| *** mvaldes has joined #openstack-security | 14:22 | |
| *** ravelar has joined #openstack-security | 14:34 | |
| *** ravelar has left #openstack-security | 14:34 | |
| *** browne has joined #openstack-security | 14:36 | |
| *** knangia has joined #openstack-security | 14:38 | |
| *** dave-mcc_ has quit IRC | 14:49 | |
| *** shohel has quit IRC | 14:51 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/362173 | 15:01 |
| *** hockeynut has joined #openstack-security | 15:03 | |
| *** dave-mccowan has joined #openstack-security | 15:14 | |
| *** markvoelker has joined #openstack-security | 15:17 | |
| *** sdake_ has joined #openstack-security | 15:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/362173 | 15:18 |
| *** sdake has quit IRC | 15:20 | |
| *** vinaypotluri has joined #openstack-security | 15:20 | |
| *** sdake has joined #openstack-security | 15:24 | |
| *** sdake_ has quit IRC | 15:26 | |
| *** browne has quit IRC | 15:29 | |
| *** markvoelker has quit IRC | 15:32 | |
| *** hockeynut has quit IRC | 15:33 | |
| *** browne has joined #openstack-security | 15:40 | |
| *** tesseract- has quit IRC | 15:42 | |
| *** pcaruana has quit IRC | 15:43 | |
| *** rcernin has quit IRC | 15:44 | |
| *** ccneill has joined #openstack-security | 15:57 | |
| *** edtubill has joined #openstack-security | 15:57 | |
| *** mvaldes has quit IRC | 15:57 | |
| *** browne has quit IRC | 16:04 | |
| *** aastha has joined #openstack-security | 16:06 | |
| *** mdong has joined #openstack-security | 16:07 | |
| *** browne has joined #openstack-security | 16:09 | |
| *** sdake has quit IRC | 16:19 | |
| *** browne has quit IRC | 16:21 | |
| *** salv-orlando has quit IRC | 16:27 | |
| *** salv-orlando has joined #openstack-security | 16:27 | |
| *** sdake has joined #openstack-security | 16:30 | |
| *** salv-orlando has quit IRC | 16:30 | |
| *** mvaldes has joined #openstack-security | 16:32 | |
| openstackgerrit | Merged openstack/syntribos: changes to runner and result https://review.openstack.org/359463 | 16:43 |
| *** trisq has quit IRC | 16:49 | |
| *** gfhellma has joined #openstack-security | 16:54 | |
| openstackgerrit | Merged openstack/syntribos: Deleting unused data files https://review.openstack.org/361646 | 16:58 |
| ccneill | unrahul, vinaypotluri, aastha, mdong, knangia : you should all have access to the google doc now. take a look real quick to see if the headings I created make sense, and if there are any others you think we should add | 16:59 |
| ccneill | I added the Keystone bug that we found last time as an example | 17:00 |
| *** browne has joined #openstack-security | 17:05 | |
| unrahul | can access it , thanks ccneill | 17:06 |
| ccneill | cool cool | 17:06 |
| *** mvaldes has quit IRC | 17:10 | |
| openstackgerrit | Merged openstack/syntribos: Added config file improvements https://review.openstack.org/358856 | 17:11 |
| openstackgerrit | Merged openstack/syntribos: Buffer Overflow data file dependency is removed https://review.openstack.org/360558 | 17:13 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: patch to sanitize debug log https://review.openstack.org/360127 | 17:27 |
| *** singlethink has joined #openstack-security | 17:32 | |
| ccneill | ruh roh | 17:32 |
| ccneill | unrahul: looks like Keystone is throwing a 500 error on token requests | 17:32 |
| ccneill | "The server encountered an internal error or | 17:32 |
| ccneill | misconfiguration and was unable to complete | 17:32 |
| ccneill | your request." | 17:32 |
| unrahul | eeh.. i ddnt change anything in keystone.. :o | 17:33 |
| unrahul | let me check the server | 17:33 |
| ccneill | looks like it might be on the apache side - I got an HTML error | 17:37 |
| *** zul has quit IRC | 17:39 | |
| *** zul has joined #openstack-security | 17:42 | |
| *** markvoelker has joined #openstack-security | 17:53 | |
| unrahul | hey ccneill can u check it now.. it should be working.. | 18:02 |
| unrahul | there was another process running and trying to bind to the same port | 18:03 |
| ccneill | o_O | 18:03 |
| ccneill | ruh roh.. | 18:03 |
| ccneill | that doesn't sound good.. | 18:03 |
| ccneill | any idea what the process was? | 18:04 |
| ccneill | brb | 18:04 |
| openstackgerrit | Emma Foley proposed openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/362173 | 18:06 |
| *** markvoelker has quit IRC | 18:09 | |
| *** mvaldes has joined #openstack-security | 18:13 | |
| unrahul | well yeah.. when I setup the two last services.. I guess keystone eventlet init script also got installed and it was conflicting with the apache2 keystone , Matt, (mdorn) helped me figure it out | 18:14 |
| ccneill | ahhhh | 18:14 |
| ccneill | so it was 2 competing keystone instances | 18:14 |
| ccneill | wasn't sure if it was just some random process that showed up lol :X | 18:15 |
| unrahul | yeah.. and there is this weird thing.. that keystone uses openstack-keystoneclient for some of its interal services and it needs a specific version.. so if I do a pip --upgrade openstack-keystoneclient ( i guess i did) it just stops working | 18:15 |
| unrahul | :o | 18:15 |
| unrahul | so we had to remove the client and instal the version 1.7 | 18:16 |
| openstackgerrit | Merged openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/362173 | 18:27 |
| *** salv-orlando has joined #openstack-security | 18:34 | |
| ccneill | interesting.. sounds nice and intuitive lol :P | 18:36 |
| ccneill | unrahul: made a comment on your masking patch... looks like oslo | 18:36 |
| ccneill | oslo_util does some funky stuff to handle different "SANITIZE" strings | 18:36 |
| ccneill | so the tl;dr is: let's just remove the option to append new strings for the time being and revisit if we feel like we need to in the future | 18:37 |
| ccneill | I think sanitizing the passwords is the main thing we wanted, and the other stuff is less important | 18:37 |
| unrahul | +1 ccneill I will change the patch and limit it to sanitizing passwords for now and will work on the configurable part to be merged later. | 18:38 |
| *** gfhellma has quit IRC | 18:39 | |
| ccneill | cool cool | 18:39 |
| ccneill | thanks unrahul | 18:39 |
| *** hockeynut has joined #openstack-security | 18:40 | |
| *** salv-orlando has quit IRC | 18:42 | |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: patch to sanitize debug log https://review.openstack.org/360127 | 18:47 |
| *** liverpooler has quit IRC | 18:47 | |
| unrahul | np ccneill , kindly check the patch when u get time. | 18:47 |
| *** edtubill has quit IRC | 19:01 | |
| *** mvaldes has quit IRC | 19:04 | |
| ccneill | unrahul: noticed one tiny thing - the RequestObject.sanitize property isn't currently passed to request(0 | 19:06 |
| ccneill | request() * | 19:06 |
| ccneill | but after that it should be ready to go | 19:06 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: patch to sanitize debug log https://review.openstack.org/360127 | 19:13 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: patch to sanitize debug log https://review.openstack.org/360127 | 19:16 |
| *** gfhellma has joined #openstack-security | 19:20 | |
| ccneill | unrahul: +1'd :) | 19:20 |
| *** diazjf has joined #openstack-security | 19:20 | |
| unrahul | :) thanks ccneill . | 19:20 |
| mdong | I’ll start reviewing it to get it to +2 | 19:21 |
| unrahul | :) .. +1 mdong | 19:22 |
| ccneill | mdong: looking over your patch now | 19:22 |
| ccneill | testing it out with jq, seems like it'll be a very handy change for us | 19:22 |
| *** dave-mccowan has quit IRC | 19:25 | |
| *** tkelsey has joined #openstack-security | 19:28 | |
| *** tkelsey has quit IRC | 19:33 | |
| *** salv-orlando has joined #openstack-security | 19:42 | |
| *** salv-orlando has quit IRC | 19:44 | |
| *** edtubill has joined #openstack-security | 19:45 | |
| *** dave-mccowan has joined #openstack-security | 19:47 | |
| *** sdake has quit IRC | 19:48 | |
| *** zul has quit IRC | 19:51 | |
| *** markvoelker has joined #openstack-security | 19:52 | |
| *** markvoelker has quit IRC | 20:08 | |
| mdong | unrahul: +2’d your change | 20:09 |
| openstackgerrit | Merged openstack/syntribos: patch to sanitize debug log https://review.openstack.org/360127 | 20:10 |
| *** mvaldes has joined #openstack-security | 20:14 | |
| unrahul | phew, thanks mdong .. jenkins is pretty fast today.. | 20:16 |
| *** markvoelker has joined #openstack-security | 20:17 | |
| *** diazjf has quit IRC | 20:30 | |
| ccneill | mdong: one comment on your CR, then I think it's ready to go | 20:33 |
| mdong | thanks, fixing it now | 20:34 |
| openstackgerrit | Michael Dong proposed openstack/syntribos: Revamped results schema https://review.openstack.org/361507 | 20:35 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Modifying log file path https://review.openstack.org/362427 | 20:39 |
| ccneill | +1'd | 20:39 |
| openstackgerrit | Michael Dong proposed openstack/syntribos: Revamped results schema https://review.openstack.org/361507 | 20:40 |
| mdong | actually, while I’m at it | 20:40 |
| mdong | also addressed string truncating in the results output, it’s now 128 characters down from 512 | 20:40 |
| unrahul | mdong: ccneill guys, I have changed the file path, but logs are not written to the path.. I am not sure whats going on.. the way I understand it . it should.. can u guys take a look and comment.. I | 20:40 |
| unrahul | +1 mdong ..nice | 20:40 |
| ccneill | mdong: 128 sounds good | 20:41 |
| mdong | yeah, noticed that just now while testing. needs a +2 and workflow | 20:42 |
| ccneill | +2'd | 20:44 |
| *** markvoelker has quit IRC | 20:48 | |
| ccneill | unrahul: I'm seeing the same thing.. no log files created :( | 20:48 |
| unrahul | yeah.. and I just dont get it | 20:49 |
| unrahul | I have created a new path, gave that path to the log.basicConfig | 20:49 |
| unrahul | didnt do anything special | 20:49 |
| unrahul | :/ | 20:49 |
| ccneill | right, I see the path, but no files.. :( | 20:49 |
| *** diazjf has joined #openstack-security | 20:50 | |
| ccneill | when I print log_file, it looks good.. | 20:50 |
| ccneill | unrahul: ah, looks like this is the issue: https://stackoverflow.com/questions/13839554/how-to-change-filehandle-with-python-logging-on-the-fly-with-different-classes-a | 20:51 |
| openstackgerrit | Merged openstack/syntribos: Revamped results schema https://review.openstack.org/361507 | 20:51 |
| *** salv-orlando has joined #openstack-security | 20:51 | |
| ccneill | basicConfig only works if you don't already have a config established | 20:51 |
| unrahul | :/ .. pushing another patch asap.. | 20:52 |
| unrahul | thanks ccneill ! | 20:52 |
| *** sdake has joined #openstack-security | 20:52 | |
| ccneill | unrahul / vinaypotluri / mdong / knangia / aastha have y'all started testing? still want to meet at 4? I haven't started testing yet, but am happy to get together if it's helpful | 20:53 |
| unrahul | I havent. | 20:53 |
| unrahul | :( | 20:53 |
| unrahul | if we have to discuss on it. may be after 5 ? | 20:53 |
| ccneill | no worries, we've gotten lots of things merged today without breaking master, so I'd consider that an unambiguous win ;) | 20:53 |
| unrahul | would u guys have time then? | 20:53 |
| unrahul | hehe | 20:53 |
| unrahul | :D | 20:54 |
| ccneill | I'm cool with 5:00-5:30 if people will be around | 20:54 |
| mdong | I’ve been running it a bit, but I don’t have anything really to report, 5 works for me | 20:54 |
| ccneill | mdong: any thoughts on this CR? https://review.openstack.org/#/c/314700/ | 20:54 |
| ccneill | are we ready to abandon it? | 20:54 |
| ccneill | I haven't seen any unicode errors with our current payloads | 20:55 |
| ccneill | just figured we should clean out our list of open CRs since we're already down to 4 :D | 20:55 |
| mdong | ah, yeah, I’ll abandon it now | 20:56 |
| mdong | though…I don’t remember what we did to fix it... | 20:57 |
| ccneill | deleted some payloads maybe? | 20:57 |
| ccneill | been so long since that patch that I have no idea lol | 20:57 |
| *** dstufft has quit IRC | 20:58 | |
| ccneill | https://bugs.launchpad.net/syntribos/+bug/1580250 | 20:58 |
| openstack | Launchpad bug 1580250 in syntribos "unicode payload crashes for xml request template" [Undecided,New] | 20:58 |
| mdong | well, the exact payload that caused the bug is still in | 20:58 |
| ccneill | looks like it's XML-specific? | 20:58 |
| mdong | ah, right | 20:58 |
| ccneill | in which case | 20:58 |
| ccneill | ¯\_(ツ)_/¯ | 20:58 |
| *** dstufft has joined #openstack-security | 20:58 | |
| ccneill | I don't think we have any XML testing to do in the coming days, and I don't think we really mention it anywhere in documentation.. so I think we can live without it for the time being | 20:59 |
| *** salv-orlando has quit IRC | 20:59 | |
| *** mwturvey has joined #openstack-security | 20:59 | |
| mdong | yeah, I’ll still abandon it, I wasn’t sure that this was the right way to go about fixing the bug anyway | 21:00 |
| *** mwturvey has quit IRC | 21:00 | |
| mdong | we can always revisit this in the future | 21:00 |
| ccneill | yep | 21:00 |
| ccneill | it'll just be nice to have a clean slate while we're doing this testing | 21:00 |
| ccneill | speaking of, gonna check to see if we can close out any trello cards | 21:01 |
| ccneill | closed out the checks/signals one today :) | 21:01 |
| mdong | awesome | 21:01 |
| ccneill | woot, and then there were 3.. | 21:02 |
| *** cleong has quit IRC | 21:03 | |
| unrahul | :) .. | 21:03 |
| *** hockeynut has quit IRC | 21:04 | |
| *** salv-orlando has joined #openstack-security | 21:16 | |
| *** sdake has quit IRC | 21:33 | |
| *** ginko has joined #openstack-security | 21:34 | |
| *** mvaldes has quit IRC | 21:37 | |
| *** edtubill has quit IRC | 21:40 | |
| openstackgerrit | Charles Neill proposed openstack/syntribos: Adds relative paths for templates https://review.openstack.org/362460 | 21:41 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Modifying log file path https://review.openstack.org/362427 | 21:43 |
| ccneill | just threw up a quick patch to finish out the items on this card: https://trello.com/c/A4nu1Bsd/122-sectest-syn-fix-issues-identified-during-keystone-testing | 21:43 |
| ccneill | (relative path for filenames) | 21:43 |
| unrahul | ccneill: have updated the CR, kindly check it, when u get time. | 21:43 |
| ccneill | if anyone has a second to review | 21:43 |
| ccneill | yep yep | 21:43 |
| ccneill | once these 2 merge, we're done with that card :) | 21:44 |
| unrahul | :D checking ur cr now | 21:46 |
| ccneill | hmm.. seems we lost run time.. | 21:47 |
| *** diazjf has quit IRC | 21:47 | |
| ccneill | I get Run time: None sec. | 21:47 |
| ccneill | since run_test no longer returns run time | 21:47 |
| ccneill | the files are working though O:-) | 21:47 |
| ccneill | I can live without it for now | 21:49 |
| unrahul | are we logging the run time..? | 21:49 |
| unrahul | we are only printing it ryt.? | 21:49 |
| unrahul | to cli | 21:49 |
| ccneill | line 244-247 in runner | 21:50 |
| ccneill | I'm okay with us ditching it entirely | 21:50 |
| ccneill | since we already have the response time | 21:50 |
| ccneill | and the time per template, I believe | 21:50 |
| unrahul | oh.. should i submit another patch.. by caller the get_logger() there.. I think that should work. :o | 21:51 |
| mdong | wait, where were we using test_end_time? I removed it cause I did a grep for it and couldn’t find it being used anywhere... | 21:51 |
| ccneill | https://github.com/openstack/syntribos/blob/master/syntribos/runner.py#L183-L187 | 21:52 |
| *** diazjf has joined #openstack-security | 21:53 | |
| ccneill | https://github.com/openstack/syntribos/blob/master/syntribos/runner.py#L230-L233 | 21:53 |
| ccneill | but run_test doesn't return a time anymore | 21:53 |
| ccneill | https://github.com/openstack/syntribos/blob/master/syntribos/runner.py#L270 | 21:53 |
| ccneill | maybe it got lost in a rebase? /shrug | 21:53 |
| ccneill | not a big deal, I think we can probably live without it | 21:54 |
| mdong | I removed it here https://review.openstack.org/#/c/359463/7/syntribos/runner.py@278 but it wasn’t returning anything there | 21:55 |
| *** ginko has left #openstack-security | 21:55 | |
| *** hockeynut has joined #openstack-security | 21:59 | |
| ccneill | I think we can just modify the lines I posted to not include the "test_time =" bit and the LOG part | 22:00 |
| *** gfhellma1 has joined #openstack-security | 22:03 | |
| *** gfhellma has quit IRC | 22:03 | |
| ccneill | unrahul / knangia / vinaypotluri : https://gist.github.com/cneill/fea5039163a15db663c31a92db656110 | 22:12 |
| *** gfhellma has joined #openstack-security | 22:19 | |
| *** gfhellma1 has quit IRC | 22:20 | |
| *** diazjf has quit IRC | 22:31 | |
| openstackgerrit | Michael Dong proposed openstack/syntribos: Fixed runner time log https://review.openstack.org/362480 | 22:39 |
| *** diazjf has joined #openstack-security | 22:43 | |
| *** browne has quit IRC | 22:43 | |
| *** singlethink has quit IRC | 22:50 | |
| ccneill | mdong: minor comment on your CR, but otherwise looks good | 22:51 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Minor nit in progress display https://review.openstack.org/362484 | 22:51 |
| *** elmiko is now known as _elmiko | 22:52 | |
| unrahul | ccneill: mdong is there anything needed in the logger patch..? or is it good to go | 22:53 |
| *** jass93 has joined #openstack-security | 22:53 | |
| ccneill | I +1'd | 22:54 |
| ccneill | looks good to me | 22:54 |
| unrahul | just saw, thanks ccneill | 22:54 |
| ccneill | unrahul: minor nits on this one, but looks mostly ready to go: https://review.openstack.org/#/c/362484/ | 22:59 |
| *** trisq has joined #openstack-security | 23:00 | |
| *** markvoelker has joined #openstack-security | 23:02 | |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Minor nit in progress display https://review.openstack.org/362484 | 23:06 |
| unrahul | hey ccneill it was under indenting for me.. I have changed the \t and put few spaces in between.. now it should not over indent.. i guess... still may be later need to refactor that and format the string to avoid the \t s | 23:07 |
| ccneill | ¯\_(ツ)_/¯ it may differ by font sizes, terminal sizes, etc. | 23:08 |
| ccneill | so I | 23:08 |
| ccneill | I'm not too worried about it | 23:08 |
| ccneill | it looks okay on my end, just not "perfectly" centered lol. not worth the effort | 23:08 |
| ccneill | your latest patch looks good | 23:09 |
| ccneill | +1'd | 23:09 |
| ccneill | ugh.. looks like rainpocalypse continues.. | 23:09 |
| ccneill | looks like these CRs are about ready to go if we can get a +2 on them | 23:12 |
| unrahul | yup.. I have +1d the relative path CR | 23:14 |
| ccneill | looks like we've merged 6 CRs so far today :D | 23:15 |
| unrahul | thats a lot of changes.. and we didnt break master | 23:16 |
| unrahul | :D | 23:17 |
| ccneill | we can finish up with the rest tomorrow if y'all are ready to head out so you don't get caught in the rain | 23:17 |
| ccneill | yep! no new stacktraces :D | 23:17 |
| openstackgerrit | Merged openstack/syntribos: Minor nit in progress display https://review.openstack.org/362484 | 23:17 |
| ccneill | boom | 23:17 |
| *** lhinds has quit IRC | 23:18 | |
| ccneill | vinaypotluri / mdong : if y'all have a sec to look over this one it should be ready to go: https://review.openstack.org/#/c/362460/ | 23:19 |
| vinaypotluri | yes ccneill | 23:20 |
| *** jass93 has quit IRC | 23:20 | |
| *** lhinds has joined #openstack-security | 23:21 | |
| openstackgerrit | Merged openstack/syntribos: Modifying log file path https://review.openstack.org/362427 | 23:22 |
| ccneill | boom | 23:22 |
| *** salv-orlando has quit IRC | 23:25 | |
| *** trisq has quit IRC | 23:26 | |
| ccneill | c'mon, Jenkins... one more.. | 23:26 |
| openstackgerrit | Merged openstack/syntribos: Adds relative paths for templates https://review.openstack.org/362460 | 23:27 |
| ccneill | yeee | 23:27 |
| vinaypotluri | boom again | 23:27 |
| *** zul has joined #openstack-security | 23:29 | |
| ccneill | trello card slain! https://trello.com/c/A4nu1Bsd/122-sectest-syn-fix-issues-identified-during-keystone-testing | 23:29 |
| *** browne has joined #openstack-security | 23:31 | |
| *** diazjf has quit IRC | 23:34 | |
| *** hockeynut has quit IRC | 23:39 | |
| unrahul | phew.. now can start testing.. without thinking about these... | 23:53 |
| unrahul | it would be cool to add the signal diffing part to some tests.. on the way. | 23:54 |
| *** markvoelker has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!