*** bknudson has joined #openstack-security | 00:13 | |
*** bknudson has left #openstack-security | 00:13 | |
*** mvaldes has quit IRC | 00:18 | |
*** elo has quit IRC | 00:21 | |
*** elo has joined #openstack-security | 00:24 | |
*** eric_lopez has joined #openstack-security | 00:32 | |
*** elo has quit IRC | 00:33 | |
*** elo has joined #openstack-security | 00:33 | |
*** eric_lopez has quit IRC | 00:34 | |
*** mvaldes has joined #openstack-security | 00:49 | |
*** elo has quit IRC | 01:27 | |
*** elo has joined #openstack-security | 01:28 | |
*** mvaldes has quit IRC | 01:32 | |
*** mvaldes has joined #openstack-security | 01:48 | |
*** mvaldes1 has joined #openstack-security | 02:00 | |
*** mvaldes has quit IRC | 02:03 | |
*** zul_ has joined #openstack-security | 02:11 | |
*** mvaldes1 has quit IRC | 02:24 | |
*** davidjd-gh has joined #openstack-security | 02:26 | |
*** davidjd-gh has left #openstack-security | 02:26 | |
*** elo has quit IRC | 02:43 | |
*** elo has joined #openstack-security | 02:43 | |
*** yuanying has quit IRC | 02:52 | |
*** davidjd-gh has joined #openstack-security | 03:07 | |
*** davidjd-gh has left #openstack-security | 03:07 | |
*** zul_ has quit IRC | 03:07 | |
*** askingalexandria has joined #openstack-security | 03:09 | |
*** askingalexandria has left #openstack-security | 03:09 | |
*** nkinder has quit IRC | 03:15 | |
*** askingalexandria has joined #openstack-security | 03:19 | |
*** askingalexandria has left #openstack-security | 03:20 | |
*** davidjd-gh has joined #openstack-security | 03:29 | |
*** davidjd-gh has left #openstack-security | 03:30 | |
*** elo has quit IRC | 03:33 | |
*** elo has joined #openstack-security | 03:34 | |
*** nkinder has joined #openstack-security | 03:35 | |
*** davidjd-gh has joined #openstack-security | 03:37 | |
*** davidjd-gh has left #openstack-security | 03:37 | |
*** yuanying has joined #openstack-security | 03:47 | |
*** nkinder has quit IRC | 03:47 | |
*** davidjd-gh has joined #openstack-security | 03:50 | |
*** davidjd-gh has left #openstack-security | 03:50 | |
*** davidjd-gh has joined #openstack-security | 04:00 | |
*** davidjd-gh has left #openstack-security | 04:00 | |
*** tsufiev has quit IRC | 04:15 | |
*** tsufiev has joined #openstack-security | 04:17 | |
*** elo has quit IRC | 04:21 | |
*** elo has joined #openstack-security | 04:23 | |
*** elo has quit IRC | 04:43 | |
*** elo has joined #openstack-security | 04:43 | |
*** elo has quit IRC | 04:55 | |
*** elo has joined #openstack-security | 04:56 | |
*** dikonoor has joined #openstack-security | 05:05 | |
*** eric_lopez has joined #openstack-security | 05:24 | |
*** elo has quit IRC | 05:25 | |
*** salv-orlando has joined #openstack-security | 05:32 | |
*** salv-orlando has quit IRC | 05:47 | |
*** salv-orlando has joined #openstack-security | 05:47 | |
*** eric_lopez has quit IRC | 05:50 | |
*** eric_lopez has joined #openstack-security | 05:50 | |
*** rcernin has joined #openstack-security | 06:05 | |
*** eric_lopez has quit IRC | 06:08 | |
*** elo has joined #openstack-security | 06:08 | |
*** elo has quit IRC | 06:19 | |
*** elo has joined #openstack-security | 06:19 | |
*** pcaruana has joined #openstack-security | 06:37 | |
*** liverpooler has joined #openstack-security | 06:37 | |
*** tesseract- has joined #openstack-security | 06:41 | |
*** eric_lopez has joined #openstack-security | 07:03 | |
*** elo has quit IRC | 07:03 | |
*** salv-orlando has quit IRC | 07:10 | |
*** elo has joined #openstack-security | 07:15 | |
*** eric_lopez has quit IRC | 07:16 | |
*** salv-orlando has joined #openstack-security | 07:18 | |
*** elo has quit IRC | 07:19 | |
*** elo has joined #openstack-security | 07:19 | |
*** salv-orl_ has joined #openstack-security | 07:23 | |
*** salv-orlando has quit IRC | 07:25 | |
*** eric_lopez has joined #openstack-security | 07:26 | |
*** elo has quit IRC | 07:26 | |
*** eric_lopez has quit IRC | 07:37 | |
*** elo has joined #openstack-security | 07:37 | |
*** eric_lopez has joined #openstack-security | 08:15 | |
*** elo has quit IRC | 08:16 | |
*** unrahul has quit IRC | 08:32 | |
*** davidjd-gh has joined #openstack-security | 08:41 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/346649 | 08:43 |
---|---|---|
*** salv-orl_ has quit IRC | 08:58 | |
*** elo has joined #openstack-security | 09:13 | |
*** eric_lopez has quit IRC | 09:13 | |
openstackgerrit | maoshuai proposed openstack/security-doc: [sec-guide]A redundant word in Security Guide https://review.openstack.org/346671 | 09:33 |
*** salv-orlando has joined #openstack-security | 09:36 | |
*** salv-orlando has quit IRC | 09:40 | |
*** davidjd-gh has quit IRC | 09:47 | |
*** davidjd-gh has joined #openstack-security | 09:49 | |
*** salv-orlando has joined #openstack-security | 10:09 | |
*** salv-orlando has quit IRC | 10:13 | |
*** salv-orlando has joined #openstack-security | 10:14 | |
*** salv-orlando has quit IRC | 10:18 | |
*** davidjd-gh has left #openstack-security | 10:24 | |
*** elo has quit IRC | 11:12 | |
*** elo has joined #openstack-security | 11:12 | |
*** sdake has joined #openstack-security | 11:54 | |
*** edmondsw has joined #openstack-security | 11:59 | |
*** elo has quit IRC | 12:10 | |
*** elo has joined #openstack-security | 12:10 | |
*** d0ugal_ is now known as d0ugal | 12:17 | |
*** d0ugal has quit IRC | 12:17 | |
*** d0ugal has joined #openstack-security | 12:17 | |
*** salv-orlando has joined #openstack-security | 12:35 | |
*** elo has quit IRC | 12:41 | |
*** elo has joined #openstack-security | 12:47 | |
*** aurelien__ has joined #openstack-security | 12:54 | |
*** _elmiko is now known as elmiko | 12:59 | |
*** elo has quit IRC | 13:05 | |
*** elo has joined #openstack-security | 13:06 | |
*** elo has quit IRC | 13:07 | |
*** elo has joined #openstack-security | 13:07 | |
*** davidjd-gh has joined #openstack-security | 13:07 | |
*** davidjd-gh has left #openstack-security | 13:07 | |
*** Trident has quit IRC | 13:08 | |
*** bknudson has joined #openstack-security | 13:18 | |
*** elo has quit IRC | 13:22 | |
*** elo has joined #openstack-security | 13:24 | |
*** elo has quit IRC | 13:26 | |
*** elo has joined #openstack-security | 13:26 | |
*** salv-orlando has quit IRC | 13:28 | |
*** eric_lopez has joined #openstack-security | 13:28 | |
*** elo has quit IRC | 13:31 | |
*** elo has joined #openstack-security | 13:31 | |
*** eric_lopez has quit IRC | 13:33 | |
*** salv-orlando has joined #openstack-security | 13:34 | |
*** salv-orlando has quit IRC | 13:34 | |
*** salv-orlando has joined #openstack-security | 13:34 | |
openstackgerrit | maoshuai proposed openstack/security-doc: [sec-guide]A spelling mistake in Security Guide https://review.openstack.org/346813 | 13:36 |
*** elo has quit IRC | 13:36 | |
*** elo has joined #openstack-security | 13:37 | |
*** eric_lopez has joined #openstack-security | 13:39 | |
*** elo has quit IRC | 13:39 | |
*** salv-orlando has quit IRC | 13:43 | |
*** sdake_ has joined #openstack-security | 13:45 | |
*** sdake has quit IRC | 13:45 | |
*** zul has quit IRC | 14:02 | |
*** zul has joined #openstack-security | 14:02 | |
*** mvaldes has joined #openstack-security | 14:10 | |
*** eric_lopez has quit IRC | 14:12 | |
*** elo has joined #openstack-security | 14:16 | |
*** user154752_ has joined #openstack-security | 14:19 | |
*** eric_lopez has joined #openstack-security | 14:21 | |
*** elo has quit IRC | 14:21 | |
*** catintheroof has joined #openstack-security | 14:24 | |
*** jmckind has joined #openstack-security | 14:32 | |
*** eric_lopez has quit IRC | 14:34 | |
*** eric_lopez has joined #openstack-security | 14:35 | |
*** jmckind_ has joined #openstack-security | 14:36 | |
*** jmckind has quit IRC | 14:39 | |
*** jmckind_ has quit IRC | 14:55 | |
*** davidjd-gh has joined #openstack-security | 14:56 | |
*** davidjd-gh has left #openstack-security | 14:57 | |
*** jmckind has joined #openstack-security | 14:57 | |
*** rcernin has quit IRC | 15:00 | |
*** vinaypotluri has joined #openstack-security | 15:03 | |
*** unrahul has joined #openstack-security | 15:06 | |
*** eric_lopez has quit IRC | 15:20 | |
*** deblike has joined #openstack-security | 15:21 | |
*** elo has joined #openstack-security | 15:25 | |
*** pcaruana has quit IRC | 15:26 | |
*** cleong has joined #openstack-security | 15:27 | |
*** davidjd-gh has joined #openstack-security | 15:28 | |
*** davidjd-gh has left #openstack-security | 15:29 | |
openstackgerrit | maoshuai proposed openstack/security-doc: [sec-guide]fix a spelling mistake in Security Guide https://review.openstack.org/346892 | 15:31 |
*** dave-mccowan has joined #openstack-security | 15:33 | |
*** aurelien__ has quit IRC | 15:40 | |
*** sdake has joined #openstack-security | 15:46 | |
*** browne has joined #openstack-security | 15:47 | |
*** davidjd-gh has joined #openstack-security | 15:49 | |
*** sdake_ has quit IRC | 15:49 | |
*** davidjd-gh has left #openstack-security | 15:50 | |
*** aastha has joined #openstack-security | 15:55 | |
*** ccneill has joined #openstack-security | 16:08 | |
*** dave-mccowan has quit IRC | 16:14 | |
*** tesseract- has quit IRC | 16:21 | |
*** elo has quit IRC | 16:31 | |
*** mvaldes has quit IRC | 16:50 | |
*** elo has joined #openstack-security | 16:53 | |
*** cleong has quit IRC | 16:55 | |
*** corey_ has joined #openstack-security | 16:55 | |
*** eric_lopez has joined #openstack-security | 16:56 | |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding request/response content compression https://review.openstack.org/344999 | 16:56 |
*** liverpooler has quit IRC | 16:57 | |
*** elo has quit IRC | 17:00 | |
vinaypotluri | ccneill: your comment on my CR https://review.openstack.org/#/c/344489/4/syntribos/checks/string.py >>> "If the length of data["failure_strings"] is >0, you should include the strings that were found with .format() and .join()" | 17:01 |
*** nkinder has joined #openstack-security | 17:01 | |
vinaypotluri | correct me if i am wrong. I should append the failure keys to the text variable | 17:02 |
ccneill | yep | 17:11 |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding request/response content compression https://review.openstack.org/344999 | 17:20 |
*** pcaruana has joined #openstack-security | 17:23 | |
*** dikonoor has quit IRC | 17:31 | |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding request/response content compression https://review.openstack.org/344999 | 17:40 |
*** sdake has quit IRC | 17:41 | |
*** mvaldes has joined #openstack-security | 17:56 | |
*** mvaldes1 has joined #openstack-security | 18:06 | |
*** mvaldes1 has joined #openstack-security | 18:07 | |
*** mvaldes has quit IRC | 18:10 | |
*** mvaldes1 has quit IRC | 18:20 | |
*** mvaldes has joined #openstack-security | 18:20 | |
*** ccneill has quit IRC | 18:34 | |
*** ccneill has joined #openstack-security | 18:39 | |
*** sdake has joined #openstack-security | 18:44 | |
unrahul | is there something wrong with zuul/jenkins today, take a lot of time to pass jenkins.. | 18:48 |
unrahul | :/ | 18:48 |
openstackgerrit | Vinay Potluri proposed openstack/syntribos: Added string presence check https://review.openstack.org/344489 | 18:51 |
*** mdong has joined #openstack-security | 18:54 | |
openstackgerrit | Merged openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/346649 | 19:10 |
*** ccneill has quit IRC | 19:11 | |
*** ccneill has joined #openstack-security | 19:20 | |
vinaypotluri | mdong: wanted to confirm if we should just remove the failure cases method and just have a check for the string presence ? | 19:39 |
*** davidjd-gh has joined #openstack-security | 20:09 | |
*** davidjd-gh has left #openstack-security | 20:09 | |
*** sdake has quit IRC | 20:16 | |
*** davidjd-gh has joined #openstack-security | 20:39 | |
*** davidjd-gh has left #openstack-security | 20:39 | |
*** zul_ has joined #openstack-security | 21:01 | |
*** davidjd-gh has joined #openstack-security | 21:21 | |
*** davidjd-gh has left #openstack-security | 21:21 | |
*** corey_ has quit IRC | 21:28 | |
*** deblike has quit IRC | 21:34 | |
*** mvaldes has quit IRC | 21:44 | |
*** davidjd-gh has joined #openstack-security | 21:53 | |
*** davidjd-gh has left #openstack-security | 21:54 | |
*** elmiko is now known as _elmiko | 22:50 | |
*** jmckind has quit IRC | 22:54 | |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding request/response content compression https://review.openstack.org/344999 | 23:06 |
unrahul | hey ccneill you there? | 23:07 |
ccneill | yup | 23:08 |
ccneill | unrahul: ready for a review on that CR? | 23:08 |
unrahul | is there a way to undo the latest commit to gerrit.? | 23:08 |
ccneill | hmmm.. | 23:08 |
ccneill | you mean you want to roll back your local branch to the state from the last patch? | 23:08 |
unrahul | well the thing is the patch https://review.openstack.org/#/c/344999/ now contains changes for both debug_log compression and results_log modification.. | 23:09 |
mdong | git reset <SHA of commit you want to revert to>; git commit -a —amend? | 23:09 |
unrahul | I was trying to upload changes for the second CR and somehow it ended up in the first.. | 23:09 |
unrahul | well..not quite.. i want to undo.. the latest patch i have submitted.. i guess.. the only way to upload another patch..? | 23:10 |
ccneill | is it all 1 commit? or are the 2 pieces separated? | 23:10 |
mdong | I think once a patch is submitted, you can’t “un-submit” it | 23:11 |
unrahul | two separate commits | 23:11 |
mdong | you’d have to create a “new” patch that undoes it | 23:11 |
unrahul | yeah.. :/ | 23:11 |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding request/response content compression https://review.openstack.org/344999 | 23:11 |
unrahul | ccneill: mdong so.. yeah.. i uploaded another patch for the request/resp as shown above ^, this is up for review.. when you guys get time, kindly review.. | 23:12 |
ccneill | sure | 23:13 |
unrahul | thanks.. | 23:13 |
ccneill | unrahul: a few tiny changes, but then I think this is ready to go :) | 23:20 |
*** zul_ has quit IRC | 23:20 | |
unrahul | thanks ccneill , \t doesn't convert to tab when printing dict values.. of request attributes.. thats why i kept the space... | 23:27 |
unrahul | it would be a \t itself.. and clutters.. the output.. | 23:28 |
unrahul | should i change the space to \t.. ? what do u think.? | 23:28 |
ccneill | hmm.. didn't think about that | 23:31 |
ccneill | I guess it's okay in that context so that it's easier to see the compressed string | 23:31 |
ccneill | (the spaces instead of \t) | 23:32 |
*** mdong has quit IRC | 23:33 | |
unrahul | yeah.. i tried.. both and with the space looks bit better.. | 23:33 |
openstackgerrit | Rahul U Nair proposed openstack/syntribos: Adding request/response content compression https://review.openstack.org/344999 | 23:36 |
unrahul | uploaded a patch with the changes.. | 23:36 |
ccneill | +1'd | 23:39 |
unrahul | thanks ccneill ! | 23:48 |
ccneill | np! | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!