| *** browne has quit IRC | 01:39 | |
| *** sdake has joined #openstack-security | 01:54 | |
| *** vinaypotluri has quit IRC | 02:01 | |
| *** sdake has quit IRC | 02:04 | |
| *** markvoelker has quit IRC | 02:06 | |
| *** diazjf has joined #openstack-security | 02:18 | |
| *** vinaypotluri has joined #openstack-security | 02:19 | |
| *** browne has joined #openstack-security | 02:48 | |
| *** yuanying has quit IRC | 02:50 | |
| *** diazjf has quit IRC | 03:01 | |
| *** markvoelker has joined #openstack-security | 03:06 | |
| *** markvoelker has quit IRC | 03:11 | |
| *** liujiong has joined #openstack-security | 03:31 | |
| *** unrahul has quit IRC | 03:32 | |
| *** liujiong has quit IRC | 03:33 | |
| *** yuanying has joined #openstack-security | 03:53 | |
| *** markvoelker has joined #openstack-security | 04:07 | |
| *** markvoelker has quit IRC | 04:12 | |
| *** sdake has joined #openstack-security | 04:49 | |
| *** sdake_ has joined #openstack-security | 04:51 | |
| *** sdake_ has quit IRC | 04:53 | |
| *** sdake has quit IRC | 04:54 | |
| *** salv-orlando has joined #openstack-security | 05:00 | |
| *** salv-orl_ has quit IRC | 05:03 | |
| *** sdake has joined #openstack-security | 05:24 | |
| *** rcernin has joined #openstack-security | 05:26 | |
| *** liverpooler has joined #openstack-security | 05:33 | |
| *** rcernin has quit IRC | 05:34 | |
| *** sdake_ has joined #openstack-security | 05:36 | |
| *** sdake has quit IRC | 05:37 | |
| *** nkinder has joined #openstack-security | 05:39 | |
| *** markvoelker has joined #openstack-security | 06:09 | |
| *** rcernin has joined #openstack-security | 06:09 | |
| *** markvoelker has quit IRC | 06:13 | |
| *** liverpooler has quit IRC | 06:24 | |
| *** liverpooler has joined #openstack-security | 06:24 | |
| *** nkinder has quit IRC | 06:26 | |
| *** sdake_ has quit IRC | 06:30 | |
| *** pcaruana has joined #openstack-security | 06:37 | |
| *** vinaypotluri has quit IRC | 06:41 | |
| *** markvoelker has joined #openstack-security | 07:10 | |
| *** markvoelker has quit IRC | 07:14 | |
| *** tesseract- has joined #openstack-security | 07:15 | |
| *** liverpooler has quit IRC | 07:43 | |
| *** liverpooler has joined #openstack-security | 07:43 | |
| *** browne has quit IRC | 07:58 | |
| *** markvoelker has joined #openstack-security | 08:11 | |
| *** markvoelker has quit IRC | 08:15 | |
| *** jamielennox is now known as jamielennox|away | 08:16 | |
| *** yuanying_ has joined #openstack-security | 08:58 | |
| *** julian1 has joined #openstack-security | 09:02 | |
| *** purp_too has joined #openstack-security | 09:04 | |
| *** _elmiko_ has joined #openstack-security | 09:06 | |
| *** yuanying has quit IRC | 09:08 | |
| *** lhinds has quit IRC | 09:08 | |
| *** julian1_ has quit IRC | 09:08 | |
| *** lmiccini has quit IRC | 09:08 | |
| *** _elmiko has quit IRC | 09:08 | |
| *** purp has quit IRC | 09:08 | |
| *** lhinds has joined #openstack-security | 09:10 | |
| *** lmiccini has joined #openstack-security | 09:13 | |
| *** mdavidson has quit IRC | 10:33 | |
| *** salv-orl_ has joined #openstack-security | 11:00 | |
| *** salv-orlando has quit IRC | 11:03 | |
| *** salv-orl_ has quit IRC | 11:05 | |
| *** sdake has joined #openstack-security | 11:55 | |
| *** sdake_ has joined #openstack-security | 11:57 | |
| *** sdake has quit IRC | 12:01 | |
| *** salv-orlando has joined #openstack-security | 12:06 | |
| *** markvoelker has joined #openstack-security | 12:13 | |
| *** salv-orlando has quit IRC | 12:14 | |
| *** markvoelker has quit IRC | 12:14 | |
| *** markvoelker has joined #openstack-security | 12:15 | |
| *** edmondsw has joined #openstack-security | 12:25 | |
| *** salv-orlando has joined #openstack-security | 12:43 | |
| *** mdavidson has joined #openstack-security | 12:49 | |
| *** sdake has joined #openstack-security | 13:10 | |
| *** sdake_ has quit IRC | 13:13 | |
| *** cleong has joined #openstack-security | 13:14 | |
| *** ametts has joined #openstack-security | 13:21 | |
| *** jmckind has joined #openstack-security | 13:43 | |
| *** edmondsw has quit IRC | 13:44 | |
| *** jmckind_ has joined #openstack-security | 13:46 | |
| *** jmckind has quit IRC | 13:50 | |
| *** unrahul has joined #openstack-security | 14:00 | |
| *** sdake_ has joined #openstack-security | 14:07 | |
| *** sdake has quit IRC | 14:11 | |
| *** nkinder has joined #openstack-security | 14:13 | |
| *** rcernin has quit IRC | 14:14 | |
| *** sdake_ is now known as sdake | 14:20 | |
| *** edmondsw has joined #openstack-security | 14:26 | |
| *** mvaldes has joined #openstack-security | 14:29 | |
| *** rcernin has joined #openstack-security | 14:29 | |
| *** rcernin has quit IRC | 14:46 | |
| *** pcaruana has quit IRC | 14:46 | |
| *** nkinder has quit IRC | 14:48 | |
| *** sdake_ has joined #openstack-security | 14:56 | |
| *** rcernin has joined #openstack-security | 14:59 | |
| *** sdake has quit IRC | 14:59 | |
| *** sdake has joined #openstack-security | 15:10 | |
| *** sdake_ has quit IRC | 15:13 | |
| *** rcernin has quit IRC | 15:19 | |
| *** browne has joined #openstack-security | 15:25 | |
| *** tesseract- has quit IRC | 15:27 | |
| *** vinaypotluri has joined #openstack-security | 15:47 | |
| *** salv-orlando has quit IRC | 15:50 | |
| *** nkinder has joined #openstack-security | 16:07 | |
| *** sdake_ has joined #openstack-security | 16:15 | |
| *** mdong has joined #openstack-security | 16:16 | |
| *** browne has quit IRC | 16:17 | |
| *** sdake has quit IRC | 16:18 | |
| *** mdong has quit IRC | 16:21 | |
| *** mdong has joined #openstack-security | 16:21 | |
| *** sdake_ is now known as sdake | 16:23 | |
| *** nkinder has quit IRC | 16:24 | |
| *** ccneill has joined #openstack-security | 16:40 | |
| *** nkinder has joined #openstack-security | 16:43 | |
| *** yaya has joined #openstack-security | 16:47 | |
| ccneill | hey aastha: here's the "dry run" bug I was talking about in our standup - https://bugs.launchpad.net/syntribos/+bug/1597486 | 16:47 |
|---|---|---|
| openstack | Launchpad bug 1597486 in syntribos "Dry run does not work" [High,New] - Assigned to Charles Neill (charles-neill) | 16:47 |
| ccneill | see if you're able to reproduce it. mdong said it worked fine for him, so maybe it's entirely on my end | 16:48 |
| aastha | ok ccneill . i will check that out. thanks. | 16:49 |
| *** salv-orlando has joined #openstack-security | 16:51 | |
| *** salv-orl_ has joined #openstack-security | 16:57 | |
| *** salv-orlando has quit IRC | 16:58 | |
| *** nkinder has quit IRC | 16:59 | |
| *** tmcpeak has joined #openstack-security | 16:59 | |
| openstackgerrit | Vinay Potluri proposed openstack/syntribos: Adding SSL checks and testcase https://review.openstack.org/334565 | 17:00 |
| *** salv-orl_ has quit IRC | 17:02 | |
| *** tkelsey has joined #openstack-security | 17:02 | |
| *** browne has joined #openstack-security | 17:03 | |
| *** yaya_ has joined #openstack-security | 17:10 | |
| *** yaya_ has quit IRC | 17:10 | |
| *** JAHoagie has joined #openstack-security | 17:10 | |
| *** yaya has quit IRC | 17:13 | |
| *** JAHoagie has quit IRC | 17:20 | |
| openstackgerrit | Eric Brown proposed openstack/bandit: Add reno for release notes management https://review.openstack.org/335679 | 17:21 |
| *** salv-orlando has joined #openstack-security | 17:29 | |
| openstackgerrit | Luke Hinds proposed openstack/security-doc: Adding OSSN-0068 https://review.openstack.org/313896 | 17:31 |
| *** salv-orlando has quit IRC | 17:34 | |
| openstackgerrit | Charles Neill proposed openstack/syntribos: Refactoring BaseTestCase/BaseFuzzTestCase https://review.openstack.org/333627 | 17:38 |
| *** tkelsey has quit IRC | 17:41 | |
| *** lhinds is now known as lhinds|afk | 17:41 | |
| *** sdake has quit IRC | 17:45 | |
| *** mvaldes has quit IRC | 17:53 | |
| *** salv-orlando has joined #openstack-security | 17:57 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/336145 | 18:03 |
| *** salv-orlando has quit IRC | 18:05 | |
| *** salv-orlando has joined #openstack-security | 18:05 | |
| *** mvaldes has joined #openstack-security | 18:08 | |
| *** tmcpeak has quit IRC | 18:09 | |
| openstackgerrit | Charles Neill proposed openstack/syntribos: Refactoring BaseTestCase/BaseFuzzTestCase https://review.openstack.org/333627 | 18:11 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/anchor: Updated from global requirements https://review.openstack.org/314347 | 18:40 |
| openstackgerrit | Merged openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/336145 | 19:43 |
| *** mvaldes has quit IRC | 19:50 | |
| openstackgerrit | Vinay Potluri proposed openstack/syntribos: Adding SSL checks and testcase https://review.openstack.org/334565 | 20:00 |
| ccneill | vinaypotluri: can you update your CR with what's already in that __init__.py file? | 20:29 |
| ccneill | https://review.openstack.org/#/c/333627/7/syntribos/checks/__init__.py | 20:29 |
| vinaypotluri | ccneil yes | 20:31 |
| ccneill | cool, thanks! | 20:36 |
| *** mvaldes has joined #openstack-security | 20:39 | |
| openstackgerrit | Vinay Potluri proposed openstack/syntribos: Adding SSL checks and testcase https://review.openstack.org/334565 | 20:40 |
| vinaypotluri | ccneil i've updated and posted my patch | 20:40 |
| *** rcernin has joined #openstack-security | 20:41 | |
| ccneill | cool I'll take a look | 20:44 |
| ccneill | unrahul, mdong, browne: anyone got a sec to review this CR? https://review.openstack.org/#/c/333627/7 | 20:50 |
| ccneill | vinaypotluri: your patch is gonna conflict with the CR above | 20:50 |
| ccneill | :\ | 20:50 |
| ccneill | I thought it was based off of that CR, but it looks like it actually just conflicts with it | 20:50 |
| ccneill | which means that all the import statements I was asking you to make actually don't work because the CR with those changes in it isn't marked as a dependency | 20:51 |
| vinaypotluri | oh | 20:52 |
| ccneill | easy fix is just remove the import statements I just asked you to add from the BTC/BFTC refactor CR | 20:52 |
| vinaypotluri | should i just rollback | 20:52 |
| ccneill | :\ | 20:52 |
| vinaypotluri | ok | 20:52 |
| ccneill | sorry, I didn't realize it wasn't marked as a dependency | 20:52 |
| vinaypotluri | no problem. I will remove those import statements and post the patch again | 20:52 |
| ccneill | cool | 20:53 |
| ccneill | let me know when it's up | 20:53 |
| openstackgerrit | Vinay Potluri proposed openstack/syntribos: Adding SSL checks and testcase https://review.openstack.org/334565 | 20:56 |
| mdong | hey ccneill, looking at the CR now: what’s the “exception” issue in test_default_issues about? | 20:57 |
| ccneill | hmm | 20:59 |
| ccneill | I don't know that we actually need that | 20:59 |
| vinaypotluri | ccneil i've updated the patch | 20:59 |
| ccneill | I was just trying to capture that information somewhere.. | 20:59 |
| mdong | so if you have that as an issue, an exception will be marked as a test failure, rather than a test error | 21:00 |
| ccneill | good point | 21:00 |
| ccneill | let's not do that lol | 21:00 |
| ccneill | I'll pull it | 21:00 |
| ccneill | s/pull/kill/ | 21:00 |
| ccneill | well | 21:01 |
| ccneill | hmm | 21:01 |
| ccneill | so for the moment, we capture the requestslib exception but don't raise it.. | 21:01 |
| mdong | hmm, it won’t get marked as an error unless an exception is actually raised | 21:02 |
| ccneill | https://github.com/openstack/syntribos/blob/master/syntribos/clients/http/base_http_client.py#L83-L89 | 21:03 |
| ccneill | right | 21:03 |
| ccneill | so I believe my thought was that we might not want to raise an error, but actually a failure | 21:03 |
| ccneill | I don't think we want to do that *by default* though | 21:03 |
| ccneill | but if we throw the exception right away, we don't get to add context around it from the Test | 21:03 |
| ccneill | e.g. I send a giant payload and the server has a connection error. I'd count that as a failure, no? | 21:04 |
| ccneill | maybe not.. | 21:04 |
| mdong | there’s no way to know at that point | 21:04 |
| ccneill | but then you don't get all the info around it of "this is the test I was trying to run" | 21:04 |
| mdong | well, you get the (test, exception) tuple | 21:04 |
| mdong | in the result | 21:04 |
| ccneill | hmm, where's that? | 21:05 |
| mdong | https://github.com/openstack/syntribos/blob/master/syntribos/result.py#L47 | 21:05 |
| ccneill | thaaaat's right | 21:06 |
| ccneill | forgot about that | 21:06 |
| mdong | when the runner sees an exception from the test (that’s not an AssertionError), it calls result.addError | 21:06 |
| ccneill | hmmm, let me smoke a cigarette real quick and think about it lol | 21:07 |
| mdong | haha sure thing | 21:07 |
| ccneill | maybe we have something where you can either handle the exception manually, or if it falls through, it adds it as an error? | 21:07 |
| ccneill | not sure exactly what that would look like | 21:07 |
| ccneill | brb | 21:07 |
| openstackgerrit | Rahul U Nair proposed openstack/syntribos: Checks for Syntribos signals https://review.openstack.org/332519 | 21:10 |
| *** ametts has quit IRC | 21:13 | |
| ccneill | mdong: we could have tearDownClass check if self.failures is empty, and if so, check for "EXCEPTION_RAISED", and raise the exception there if it is unhandled? | 21:15 |
| ccneill | causing it to log as an error | 21:15 |
| mdong | do we get rid of the exception check in test_default_issues in this case? | 21:16 |
| ccneill | yep | 21:17 |
| ccneill | we can leave it to individual tests to handle | 21:17 |
| ccneill | if they're EXPECTING to cause an exception, they can handle it, otherwise it gets counted as an error | 21:17 |
| ccneill | sound good? | 21:18 |
| mdong | sounds good to me | 21:18 |
| ccneill | ok, I'll take a crack at it after I take a look at vinaypotluri's CR | 21:18 |
| mdong | 👌 | 21:18 |
| *** edmondsw has quit IRC | 21:24 | |
| *** cleong has quit IRC | 21:45 | |
| *** mihero has quit IRC | 21:45 | |
| *** webhat has quit IRC | 21:45 | |
| *** sdake_ has joined #openstack-security | 21:53 | |
| *** sdake_ has quit IRC | 21:53 | |
| *** sdake_ has joined #openstack-security | 21:53 | |
| *** catintheroof has joined #openstack-security | 22:03 | |
| *** mvaldes has quit IRC | 22:07 | |
| *** sdake_ has quit IRC | 22:33 | |
| *** salv-orl_ has joined #openstack-security | 22:34 | |
| *** salv-orlando has quit IRC | 22:35 | |
| *** jamielennox|away is now known as jamielennox | 22:37 | |
| *** mdong has quit IRC | 22:43 | |
| *** austin987 has quit IRC | 22:48 | |
| *** austin987 has joined #openstack-security | 23:01 | |
| *** jmckind_ has quit IRC | 23:06 | |
| openstackgerrit | Vinay Potluri proposed openstack/syntribos: Adding SSL checks and testcase https://review.openstack.org/334565 | 23:08 |
| *** sdake has joined #openstack-security | 23:11 | |
| *** sdake has quit IRC | 23:11 | |
| *** catintheroof has quit IRC | 23:18 | |
| *** lhinds|afk has quit IRC | 23:20 | |
| *** markvoelker has quit IRC | 23:21 | |
| *** lhinds has joined #openstack-security | 23:24 | |
| openstackgerrit | Merged openstack/syntribos: Checks for Syntribos signals https://review.openstack.org/332519 | 23:47 |
| openstackgerrit | Charles Neill proposed openstack/syntribos: Refactoring BaseTestCase/BaseFuzzTestCase https://review.openstack.org/333627 | 23:50 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!