*** tmcpeak has joined #openstack-security | 00:01 | |
*** browne has joined #openstack-security | 00:03 | |
*** shakamunyi has joined #openstack-security | 00:12 | |
*** barra204 has joined #openstack-security | 00:12 | |
*** salv-orlando has joined #openstack-security | 00:48 | |
*** salv-orlando has quit IRC | 00:55 | |
*** superfly_ has joined #openstack-security | 01:12 | |
*** bpokorny has quit IRC | 01:12 | |
*** superfly_ is now known as superflyy | 01:14 | |
*** barra204 has quit IRC | 01:24 | |
*** shakamunyi has quit IRC | 01:24 | |
*** superflyy has quit IRC | 01:24 | |
*** browne has quit IRC | 01:31 | |
openstackgerrit | Emett Speer proposed openstack/security-doc: Conslidated many of the small sections. https://review.openstack.org/187092 | 01:56 |
---|---|---|
*** salv-orlando has joined #openstack-security | 02:08 | |
*** sdake has quit IRC | 02:11 | |
*** salv-orlando has quit IRC | 02:14 | |
*** mohitsharma has joined #openstack-security | 02:20 | |
*** tmcpeak has quit IRC | 02:59 | |
*** tkelsey has joined #openstack-security | 03:06 | |
*** nkinder_ has joined #openstack-security | 03:09 | |
*** tkelsey has quit IRC | 03:10 | |
*** mohitsharma has quit IRC | 03:13 | |
*** mohitsharma has joined #openstack-security | 03:17 | |
*** markvoelker has quit IRC | 03:44 | |
*** browne has joined #openstack-security | 03:55 | |
*** salv-orlando has joined #openstack-security | 04:10 | |
*** markvoelker has joined #openstack-security | 04:45 | |
*** markvoelker has quit IRC | 04:50 | |
*** mohitsharma has quit IRC | 05:05 | |
*** mohitsharma has joined #openstack-security | 05:56 | |
*** shakamunyi has joined #openstack-security | 06:16 | |
*** barra204 has joined #openstack-security | 06:17 | |
openstackgerrit | Stanislaw Pitucha proposed stackforge/anchor: Fix notBefore/notAfter handling in non-UTC time https://review.openstack.org/186660 | 06:23 |
openstackgerrit | Stanislaw Pitucha proposed stackforge/anchor: Force pep8 to run using python2 https://review.openstack.org/187877 | 06:29 |
*** mohitsharma has quit IRC | 06:29 | |
*** mohitsharma has joined #openstack-security | 06:29 | |
*** markvoelker has joined #openstack-security | 06:34 | |
*** markvoelker has quit IRC | 06:38 | |
openstackgerrit | Stanislaw Pitucha proposed stackforge/anchor: Fix notBefore/notAfter handling in non-UTC time https://review.openstack.org/186660 | 06:55 |
*** browne has quit IRC | 07:02 | |
*** alex_klimov has joined #openstack-security | 07:19 | |
*** mohitsharma has quit IRC | 07:27 | |
*** mohitsharma has joined #openstack-security | 07:27 | |
*** markvoelker has joined #openstack-security | 08:22 | |
*** markvoelker has quit IRC | 08:27 | |
*** tkelsey has joined #openstack-security | 08:34 | |
*** mohitsharma has quit IRC | 10:08 | |
*** markvoelker has joined #openstack-security | 10:11 | |
*** markvoelker has quit IRC | 10:15 | |
*** sdake has joined #openstack-security | 11:02 | |
*** tkelsey has quit IRC | 11:05 | |
*** tkelsey has joined #openstack-security | 11:09 | |
*** zul has quit IRC | 11:22 | |
*** tkelsey has quit IRC | 11:23 | |
*** zul has joined #openstack-security | 11:28 | |
*** markvoelker has joined #openstack-security | 11:42 | |
*** markvoelker has quit IRC | 11:46 | |
*** tkelsey has joined #openstack-security | 11:50 | |
*** tkelsey has quit IRC | 11:54 | |
*** mohitsharma has joined #openstack-security | 11:57 | |
*** markvoelker has joined #openstack-security | 12:01 | |
*** tkelsey has joined #openstack-security | 12:38 | |
openstackgerrit | Stanislaw Pitucha proposed stackforge/anchor: Fix notBefore/notAfter handling in non-UTC time https://review.openstack.org/186660 | 12:48 |
*** bknudson has joined #openstack-security | 12:56 | |
*** dave-mcc_ has joined #openstack-security | 13:19 | |
*** dave-mccowan has quit IRC | 13:23 | |
*** singlethink has joined #openstack-security | 13:31 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:54 | |
*** singleth_ has joined #openstack-security | 13:58 | |
*** singlethink has quit IRC | 14:01 | |
*** barra204 has quit IRC | 14:36 | |
*** shakamunyi has quit IRC | 14:36 | |
*** voodookid has joined #openstack-security | 14:45 | |
chair6 | hey sigmavirus24 .. penny for your thoughts on https://review.openstack.org/#/c/186212/? | 14:47 |
sigmavirus24 | If that's the Py34 patch, I'm replying to everyone at once | 14:47 |
sigmavirus24 | :D | 14:47 |
chair6 | hah, cool :) | 14:47 |
sigmavirus24 | Just distracted by team chat asking me questions about stuff =P | 14:47 |
chair6 | i know that feeling.. | 14:47 |
*** dwyde has joined #openstack-security | 14:57 | |
sigmavirus24 | chair6: are you Jamie? | 15:11 |
chair6 | yep.. | 15:15 |
*** alex_klimov has quit IRC | 15:23 | |
*** tmcpeak has joined #openstack-security | 15:24 | |
*** RawInfoSec has joined #openstack-security | 15:27 | |
*** singlethink has joined #openstack-security | 15:28 | |
sigmavirus24 | chair6: that's very confusing =P | 15:30 |
*** singleth_ has quit IRC | 15:31 | |
*** RawInfoSec has left #openstack-security | 15:33 | |
chair6 | haha, howso? | 15:34 |
*** mohitsharma has quit IRC | 15:35 | |
sigmavirus24 | /whois chair6 just says you're too lazy to read the docs for BitchX | 15:36 |
sigmavirus24 | and I'm newish here so =P | 15:37 |
chair6 | oh right, i come from the bad ol' days when the name field was for anything but a real name.. :) | 15:41 |
*** bpokorny has joined #openstack-security | 15:42 | |
elmiko | lol | 15:42 |
sigmavirus24 | chair6: I do too | 15:44 |
sigmavirus24 | But when I started working on OpenStack I decided to be nicer | 15:44 |
sigmavirus24 | chair6: just to be clear, the minor tweaks you were imagining were... | 15:45 |
chair6 | oh.. there was erics suggestion to add 3.4 to setup.cfg, and the constants.* references in jinja2_templates.py that your comment said you didn't mean to commit | 15:48 |
sigmavirus24 | right that's what I was thinking too | 15:50 |
sigmavirus24 | okay :D | 15:50 |
openstackgerrit | Ian Cordasco proposed stackforge/bandit: Add Python 3.4 compatibility to bandit https://review.openstack.org/186212 | 15:50 |
openstackgerrit | Ian Cordasco proposed stackforge/bandit: Update example files to work on Python 2 & 3 https://review.openstack.org/187685 | 15:50 |
sigmavirus24 | So trivial rebases (the example files update) doesn't lose +2s but does lose +Ws. Good to know | 15:51 |
*** mohitsharma has joined #openstack-security | 15:52 | |
*** singlethink has quit IRC | 15:58 | |
*** tkelsey has quit IRC | 16:01 | |
sigmavirus24 | chair6: am I missing something? Does @checks also define the name of the plugin for use in bandit.yml? | 16:12 |
sigmavirus24 | tmcpeak: same question ^ | 16:14 |
openstackgerrit | Merged stackforge/anchor: Adding more docs strings https://review.openstack.org/187181 | 16:15 |
chair6 | @checks decorator is used to show what AST nodes a check should be executed against | 16:16 |
sigmavirus24 | Right, so did the exec.py check name change because the file name changed between the last release and when I started doing the compatibility work? | 16:16 |
sigmavirus24 | If so, Eric's comment seems tangential to the change, unless I'm missing something else | 16:17 |
sigmavirus24 | oh | 16:17 |
tmcpeak | sigmavirus24: no, it doesn't matter about the file name change | 16:17 |
tmcpeak | the function name matters | 16:17 |
sigmavirus24 | I named the py3 function differently | 16:17 |
tmcpeak | sigh, numbrs spamming anybody else? | 16:17 |
sigmavirus24 | Should I change that now, or later. I would think it should be the same but I missed that | 16:18 |
sigmavirus24 | tmcpeak: no but there has been a preponderence of bots sending spam links in DMs | 16:18 |
sigmavirus24 | tmcpeak: #freenode has IRCops that will kline them | 16:18 |
tmcpeak | sigmavirus24: change now please, then we don't have to update bandit.yaml anywhere | 16:18 |
tmcpeak | cool, I'll pop in there | 16:18 |
openstackgerrit | Ian Cordasco proposed stackforge/bandit: Add Python 3.4 compatibility to bandit https://review.openstack.org/186212 | 16:19 |
sigmavirus24 | Fixed | 16:19 |
tmcpeak | cool | 16:19 |
*** ChanServ sets mode: +o tmcpeak | 16:20 | |
*** jamielennox is now known as jamielennox|away | 16:21 | |
sigmavirus24 | oh tmcpeak they were spamming me the other day with that nick and a different one | 16:21 |
sigmavirus24 | I complained and the other one got klined but not nunbr\ s though | 16:21 |
*** barra204 has joined #openstack-security | 16:21 | |
*** tmcpeak sets mode: +b *!nunbrs@84.78.24.237 | 16:22 | |
*** nunbrs was kicked by tmcpeak (NO SPAM!) | 16:22 | |
*** nunbrs has joined #openstack-security | 16:22 | |
tmcpeak | well that failed | 16:22 |
*** tmcpeak sets mode: +b *!~nunbrs@84.78.24.237 | 16:24 | |
*** nunbrs was kicked by tmcpeak (NO SPAM!) | 16:24 | |
*** sriatom has joined #openstack-security | 16:24 | |
tmcpeak | sweet | 16:24 |
*** ChanServ sets mode: -o tmcpeak | 16:24 | |
tmcpeak | sigmavirus24: I think the new patch will still have the problem | 16:26 |
tmcpeak | because exec_used changed to exec_issue | 16:26 |
tmcpeak | oh I see | 16:26 |
tmcpeak | nevermind | 16:26 |
tmcpeak | cool | 16:26 |
tmcpeak | this looks good | 16:26 |
*** singlethink has joined #openstack-security | 16:27 | |
*** barra204 has quit IRC | 16:28 | |
openstackgerrit | Ian Cordasco proposed stackforge/bandit: Update example files to work on Python 2 & 3 https://review.openstack.org/187685 | 16:28 |
sigmavirus24 | tmcpeak: we could uncomment those Python 3 sections if we precede the statements with hasattr(_ast, 'Python3OnlyType') and isinstance(node, _ast.Python3OnlyType) | 16:36 |
tmcpeak | sigmavirus24: ahh ok cool, that sounds reasonable | 16:37 |
sigmavirus24 | tmcpeak: alright, I'll do that in a follow-up patch | 16:37 |
sigmavirus24 | that also eliminates that attr check as a fallback for NamedConstant | 16:38 |
sigmavirus24 | Actually, I guess we could say "if six.PY3 and isinstance(..)" | 16:38 |
sigmavirus24 | that's probably a bit more obvious to any future readers of the code why it works that way | 16:38 |
tmcpeak | yeah, that reads more clearly | 16:43 |
tmcpeak | cool, sounds good | 16:43 |
tmcpeak | yeah, we can get this one out for now | 16:44 |
*** dwyde has quit IRC | 16:48 | |
* sigmavirus24 probably could have ordered the examples/py34 work differently but it didn't occur to me at the time | 16:51 | |
openstackgerrit | Merged stackforge/bandit: Add Python 3.4 compatibility to bandit https://review.openstack.org/186212 | 16:51 |
openstackgerrit | Merged stackforge/bandit: Update example files to work on Python 2 & 3 https://review.openstack.org/187685 | 16:51 |
sigmavirus24 | Woah | 16:51 |
sigmavirus24 | That was timely | 16:52 |
*** mohitsharma has quit IRC | 16:52 | |
*** sriatom is now known as _sri | 16:53 | |
*** kutija has joined #openstack-security | 16:57 | |
chair6 | looks good ian, thanks for all the work on this! | 16:58 |
sigmavirus24 | chair6: happy to help | 17:00 |
sigmavirus24 | I have too much experience adding Py3 compat to things | 17:00 |
sigmavirus24 | Bandit was rather easy | 17:00 |
sigmavirus24 | Because it wasn't originally written for Py25 | 17:00 |
sigmavirus24 | *and* we're not doing any junk with bytes that require the same str-like API from Python 2 ;) | 17:01 |
* sigmavirus24 has gripes | 17:01 | |
sigmavirus24 | I'll address everything else after I get back from lunch | 17:03 |
*** Codeman655 has joined #openstack-security | 17:30 | |
*** dwyde has joined #openstack-security | 17:43 | |
*** barra204 has joined #openstack-security | 18:57 | |
*** barra204 has quit IRC | 19:02 | |
*** dwyde has quit IRC | 19:35 | |
*** Codeman655 has quit IRC | 19:41 | |
*** dwyde has joined #openstack-security | 19:43 | |
*** _sri has quit IRC | 19:53 | |
*** barra204 has joined #openstack-security | 19:58 | |
*** dave-mcc_ has quit IRC | 20:02 | |
*** barra204 has quit IRC | 20:03 | |
*** dave-mccowan has joined #openstack-security | 20:05 | |
*** salv-orlando has quit IRC | 20:09 | |
*** salv-orlando has joined #openstack-security | 20:09 | |
chair6 | jelle wrote a little article showing bandit/jenkins integration .. http://vdwaa.nl/bandit/python/security/jenkins/openstack-bandit-jenkins-integration/ | 20:23 |
chair6 | another way of doing things outside of gerrit land.. | 20:23 |
elmiko | neat | 20:25 |
*** singleth_ has joined #openstack-security | 20:32 | |
*** singlethink has quit IRC | 20:35 | |
*** yusgot has joined #openstack-security | 20:43 | |
*** sicarie has quit IRC | 21:16 | |
*** alex_klimov has joined #openstack-security | 21:21 | |
bknudson | "found some issues in our code" -- that is neat | 21:40 |
*** bpokorny has quit IRC | 21:45 | |
openstackgerrit | Ian Cordasco proposed stackforge/bandit: Clean up tests and examples for Python 3.4 https://review.openstack.org/188186 | 21:46 |
openstackgerrit | Ian Cordasco proposed stackforge/bandit: Clean up tests and examples for Python 3.4 https://review.openstack.org/188186 | 21:47 |
openstackgerrit | Ian Cordasco proposed stackforge/bandit: Add notes to the README about Bandit on Python 3.4 https://review.openstack.org/188187 | 21:54 |
*** bpokorny has joined #openstack-security | 21:55 | |
*** erretres has joined #openstack-security | 22:09 | |
*** erretres has left #openstack-security | 22:11 | |
*** dwyde_ has joined #openstack-security | 22:15 | |
*** dwyde has quit IRC | 22:17 | |
*** dwyde_ is now known as dwyde | 22:17 | |
*** singlethink has joined #openstack-security | 22:17 | |
*** dave-mccowan has quit IRC | 22:18 | |
*** dwyde has quit IRC | 22:18 | |
*** singleth_ has quit IRC | 22:18 | |
*** dave-mccowan has joined #openstack-security | 22:20 | |
*** jamielennox|away is now known as jamielennox | 22:20 | |
openstackgerrit | Merged stackforge/bandit: Clean up tests and examples for Python 3.4 https://review.openstack.org/188186 | 22:23 |
*** dave-mccowan has quit IRC | 22:24 | |
*** bpokorny has quit IRC | 22:27 | |
*** bpokorny has joined #openstack-security | 22:27 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:30 | |
*** bknudson has quit IRC | 22:31 | |
*** singlethink has quit IRC | 22:36 | |
*** singlethink has joined #openstack-security | 22:36 | |
*** singlethink has quit IRC | 22:44 | |
*** barra204 has joined #openstack-security | 22:48 | |
*** barra204 has quit IRC | 22:53 | |
*** bpokorny has quit IRC | 22:57 | |
*** voodookid has quit IRC | 23:06 | |
*** sdake has quit IRC | 23:35 | |
*** bpokorny has joined #openstack-security | 23:40 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!