*** voodookid has quit IRC | 00:07 | |
*** markvoelker has quit IRC | 00:17 | |
*** bdpayne_ has joined #openstack-security | 00:33 | |
*** bdpayne_ has quit IRC | 00:33 | |
*** bdpayne has quit IRC | 00:36 | |
*** markvoelker has joined #openstack-security | 00:52 | |
*** markvoelker has quit IRC | 00:56 | |
*** markvoelker_ has joined #openstack-security | 00:56 | |
*** singlethink has quit IRC | 01:04 | |
*** tmcpeak has quit IRC | 01:13 | |
*** tmcpeak has joined #openstack-security | 01:41 | |
*** bpokorny_ has quit IRC | 01:53 | |
*** tmcpeak has quit IRC | 02:12 | |
openstackgerrit | Brian Moss proposed openstack/security-doc: Updated SSL to TLS https://review.openstack.org/154315 | 02:44 |
---|---|---|
*** tmcpeak has joined #openstack-security | 02:53 | |
*** tmcpeak has quit IRC | 02:57 | |
*** ljfisher has quit IRC | 03:12 | |
*** ljfisher has joined #openstack-security | 03:12 | |
*** ljfisher has quit IRC | 03:13 | |
*** _amrith_ is now known as amrith | 03:47 | |
*** JAHoagie has joined #openstack-security | 04:34 | |
*** vozcelik has joined #openstack-security | 04:35 | |
*** vozcelik has quit IRC | 04:37 | |
*** vozcelik has joined #openstack-security | 04:38 | |
*** amrith is now known as _amrith_ | 04:56 | |
*** JAHoagie has quit IRC | 05:17 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/security-doc: Imported Translations from Transifex https://review.openstack.org/154760 | 06:01 |
openstackgerrit | Merged openstack/security-doc: Imported Translations from Transifex https://review.openstack.org/154760 | 06:25 |
*** markvoelker_ has quit IRC | 07:28 | |
*** fev3r101 has joined #openstack-security | 07:57 | |
*** fev3r101 has quit IRC | 07:58 | |
*** vozcelik has quit IRC | 09:10 | |
*** _amrith_ is now known as amrith | 12:04 | |
*** tmcpeak has joined #openstack-security | 12:32 | |
*** markvoelker has joined #openstack-security | 12:51 | |
*** amrith is now known as _amrith_ | 13:41 | |
*** bknudson has joined #openstack-security | 13:49 | |
*** ljfisher has joined #openstack-security | 14:06 | |
*** dave-mccowan has joined #openstack-security | 14:13 | |
*** dave-mccowan has quit IRC | 14:18 | |
*** jursey has quit IRC | 15:10 | |
*** voodookid has joined #openstack-security | 15:14 | |
*** singlethink has joined #openstack-security | 15:15 | |
*** voodookid has quit IRC | 15:19 | |
*** voodookid has joined #openstack-security | 15:32 | |
ljfisher | tmcpeak I think you suggested a tox test env to run for bandit, but alas, I’ve forgotten. :) I’ve got py27 and pep8. What were you running as a matter of practice? | 15:47 |
tmcpeak | ljfisher: let me check | 15:48 |
tmcpeak | "cover" | 15:50 |
tmcpeak | tox -e pep8,py27,cover should do it | 15:50 |
ljfisher | kk. did that too | 15:50 |
tmcpeak | should be good then | 15:50 |
ljfisher | more bandit review coming | 15:51 |
tmcpeak | woot! | 15:51 |
*** _amrith_ is now known as amrith | 15:52 | |
openstackgerrit | Lucas Fisher proposed stackforge/bandit: Make func, class name definitions fully qualified https://review.openstack.org/154922 | 15:52 |
*** bpokorny has joined #openstack-security | 16:11 | |
tmcpeak | ljfisher: I'm reviewing too, hold off on making Tim's changes for a few mins, ok? | 16:21 |
ljfisher | ok | 16:21 |
*** singlethink has quit IRC | 16:21 | |
tmcpeak | ljfisher: I've never seen this '{}' thing you're doing in the logs | 16:25 |
ljfisher | could you give me a line number | 16:26 |
ljfisher | hmm, so tox doesn’t run pep8 on tests I see | 16:27 |
tmcpeak | bandit/core/utils.py 143 | 16:27 |
ljfisher | https://docs.python.org/2/library/stdtypes.html#str.format | 16:28 |
ljfisher | Like ‘%’ but different. | 16:28 |
tmcpeak | ljfisher: ahh ok | 16:28 |
ljfisher | I belive ‘%’ might go away in py3?? | 16:28 |
tmcpeak | you learn something new 'ery day :) | 16:29 |
ljfisher | both of us! | 16:29 |
tmcpeak | ljfisher: did you rename the test_util file or something? | 16:38 |
ljfisher | perils of copy and paste | 16:38 |
tmcpeak | ljfisher: I think it's in the wrong place | 16:39 |
ljfisher | how so? | 16:39 |
tmcpeak | oh nevermind | 16:40 |
tmcpeak | it's unit tests for the utilities | 16:40 |
ljfisher | as tim pointed out there is some cruft I left in there since I thought it would be useful at some point… | 16:40 |
chair6 | sadly when i started writing bandit i was still in-between py2/py3 headspace, so used %s everywhere .. i'm all about the {}s now but bandit hasn't caught up :) | 16:45 |
tmcpeak | py2 for lyf | 16:46 |
*** singlethink has joined #openstack-security | 16:47 | |
ljfisher | tmcpeak what do you think about replaceing the lines changing the namespace with small until functiosn like extend_namespace() and narrow_namespace() | 16:50 |
tmcpeak | ljfisher: I like it | 16:50 |
ljfisher | I think that will convey the point without too many repeated comments | 16:50 |
tmcpeak | yeah, that's a nice approach | 16:51 |
tmcpeak | hey ljfisher: isn't the missing end test also missing a's __init__.py? | 16:54 |
tmcpeak | I guess it doesn't matter | 16:56 |
ljfisher | yeah, but the code should never get there | 16:58 |
tmcpeak | yeah, true | 16:58 |
tmcpeak | this looks like a cool change | 16:58 |
tmcpeak | good stuff | 16:58 |
ljfisher | thanks | 17:01 |
bknudson | str.format has been around forever. | 17:23 |
tmcpeak | new to me :) — personally I think % is more readable but I acknowledge this is oldschool | 17:24 |
bknudson | if someone used str.format over % I'd complain in most cases. | 17:25 |
tmcpeak | well as chair6 and ljfisher mentioned, I guess it's the future | 17:25 |
bknudson | where is it the future? | 17:26 |
bknudson | logging uses %-style formatting: https://docs.python.org/2/library/logging.html#logging.Logger.debug | 17:28 |
tmcpeak | apparently it can use the curly braces too? | 17:29 |
bknudson | you can pass any string you want to it, but it's more efficient to pass replacements as separate arguments, then you have to use % | 17:29 |
bknudson | for example, from the docs: logger.warning('Protocol problem: %s', 'connection reset') | 17:30 |
bknudson | is more efficient than logger.warning('Protocol problem: %s' % 'connection reset') | 17:30 |
bknudson | since the latter builds the string even if logging is disabled. | 17:31 |
tmcpeak | ooh, interesting | 17:31 |
tmcpeak | efficient from a performance standpoint | 17:31 |
bknudson | if it's a large string it can make a difference. | 17:31 |
bknudson | or in a loop. | 17:32 |
tmcpeak | I'm just catching up to the '90s apparently. I didn't even know {} was a thing | 17:32 |
tmcpeak | http://stackoverflow.com/questions/5082452/python-string-formatting-vs-format | 17:32 |
openstackgerrit | Lucas Fisher proposed stackforge/bandit: Make func, class name definitions fully qualified https://review.openstack.org/154922 | 17:32 |
tmcpeak | well the mid 2000's | 17:32 |
ljfisher | tmcpeak I went with more mimicing os.path.{join,split} for namespaces. See if you think it is any clearer. | 17:33 |
tmcpeak | ljfisher: cool, I'll check it out | 17:33 |
bknudson | we went with the .format() type of strings in keystone for the mapping rules... otherwise for logging, etc., it's %. | 17:34 |
tmcpeak | bknudson: how come on the logging? reason I'm asking is because we're in the process of reviewing a change for Bandit | 17:35 |
tmcpeak | is it just a style thing? | 17:35 |
bknudson | tmcpeak: for logging we use %-style so that the parameters because it's more efficient. | 17:35 |
bknudson | I don't think anyone would even consider using .format for logs, and if they did it would be inconsistent with the rest of the code. | 17:36 |
tmcpeak | bknudson: ok cool | 17:36 |
tmcpeak | ljfisher: ^ | 17:36 |
tmcpeak | want to convert the logs back to % ? :) | 17:36 |
bknudson | for logging we use %-style because it's more efficient ... the parameters are separate so that the string isn't formatted if logging is disabled. | 17:37 |
tmcpeak | yeah, that makes sense | 17:37 |
tmcpeak | I can see how it would add up | 17:37 |
tmcpeak | and might as well get into a good habit | 17:37 |
bknudson | we actually had a lot of places in keystone that used '%s' % 'whatever' in logs and someone went through and fixed them to '%s', 'whatever'. | 17:38 |
bknudson | might even have a hacking check for it now? | 17:39 |
tmcpeak | yeah, I'm pretty sure we're using "%s", %val | 17:39 |
ljfisher | aren’t the log functions more efficient because you pass the fmt str and args separately to the log function? The log function could use % or .format() and be just as efficient. It is just the log function chose the % formatting. | 17:45 |
tmcpeak | bknudson: ^ ? | 18:03 |
*** sicarie has joined #openstack-security | 18:15 | |
*** singlethink has quit IRC | 18:18 | |
bknudson | the python logging functions use % formatting. | 18:32 |
*** bdpayne has joined #openstack-security | 18:33 | |
*** sicarie has quit IRC | 18:35 | |
*** singlethink has joined #openstack-security | 18:47 | |
openstackgerrit | Lucas Fisher proposed stackforge/bandit: Make func, class name definitions fully qualified https://review.openstack.org/154922 | 18:53 |
*** sicarie has joined #openstack-security | 19:15 | |
elmiko | bdpayne: you around? | 19:57 |
ljfisher | elmiko I have a meeting with him in a few minutes | 19:59 |
bdpayne | heh, hey! | 20:00 |
elmiko | ljfisher: no rush, we'll be having a meeting in about an hour in here. | 20:00 |
elmiko | hey | 20:00 |
bdpayne | ljfisher is correct, but I can chat later :-) | 20:00 |
elmiko | k, we'll catch up during the sec-doc meeting | 20:00 |
bdpayne | ok | 20:00 |
openstackgerrit | Tyler Britten proposed openstack/security-doc: Reworded the sentence to make it clearer and less choppy https://review.openstack.org/155036 | 20:01 |
*** singlethink has quit IRC | 20:07 | |
*** amrith is now known as _amrith_ | 20:07 | |
openstackgerrit | Tyler Britten proposed openstack/security-doc: Reworded the sentence to make it clearer and less choppy https://review.openstack.org/155036 | 20:29 |
openstackgerrit | Lucas Fisher proposed stackforge/bandit: Make func, class name definitions fully qualified https://review.openstack.org/154922 | 20:36 |
openstackgerrit | Merged stackforge/bandit: Make func, class name definitions fully qualified https://review.openstack.org/154922 | 20:45 |
openstackgerrit | Michael McCune proposed openstack/security-doc: Adding data processing chapter https://review.openstack.org/155052 | 20:55 |
sicarie | +1 elmiko | 20:57 |
elmiko | =) | 20:57 |
bdpayne | sicarie elmiko hey there | 21:00 |
elmiko | hey | 21:01 |
bdpayne | so looks like elmiko has been busy | 21:01 |
elmiko | yup, finally all came together | 21:01 |
bdpayne | cool | 21:01 |
bdpayne | so I'll review that in the next day or so | 21:02 |
elmiko | thanks | 21:02 |
bdpayne | I try to review new changes daily | 21:02 |
bdpayne | ok, so we can get rolling here | 21:02 |
bdpayne | https://bugs.launchpad.net/openstack-manuals/+bugs?field.tag=sec-guide | 21:02 |
bdpayne | today we start with https://bugs.launchpad.net/openstack-manuals/+bug/1261735 | 21:02 |
openstack | Launchpad bug 1261735 in openstack-manuals "Chapter 40. Hypervisor Selection in OpenStack Security Guide - havana" [Wishlist,Confirmed] | 21:02 |
bdpayne | hey, thanks ircbot | 21:02 |
sicarie | That's a nice feature | 21:03 |
elmiko | sgordon's comments seem spot on | 21:03 |
sicarie | I'd almost say incomplete, but wishlist is a good category, IMO | 21:03 |
elmiko | yea, wishlist maybe makes more sense. unless the bug author truly has more info about hyper-v | 21:04 |
*** bpokorny has quit IRC | 21:04 | |
bdpayne | yeah, these feels reasonable to me for a wishlist | 21:04 |
bdpayne | https://bugs.launchpad.net/openstack-manuals/+bug/1342368 | 21:05 |
openstack | Launchpad bug 1342368 in openstack-manuals "Security Guide - Conventions for referring to people involved in cloud" [Wishlist,Triaged] | 21:05 |
elmiko | does the openstack glossary provide any guidance on what to use? | 21:05 |
bdpayne | I agree this would be nice, and I agree that it is a wishlist item | 21:05 |
sicarie | Yep, or do the other manuals have something established? | 21:05 |
elmiko | if we know what term to use i would place this at a medium | 21:06 |
elmiko | i think it's a nice effort though | 21:06 |
bdpayne | I'm not sure what the other guides use | 21:06 |
bdpayne | perhaps I can take that as an action item to find out | 21:06 |
elmiko | http://docs.openstack.org/glossary/content/glossary.html | 21:06 |
elmiko | uses the term operator | 21:06 |
elmiko | "The person responsible for planning and maintaining an OpenStack installation." | 21:07 |
sicarie | maintaining would include ops/admin so if operator is the standard, let's go for it | 21:07 |
*** bpokorny has joined #openstack-security | 21:08 | |
bdpayne | I think that operator and admin have different meanings, personally | 21:08 |
bdpayne | but, I can explore this with the doc team a bit | 21:08 |
elmiko | i guess the question is, are there multiple roles we need to address | 21:08 |
elmiko | yea | 21:08 |
bdpayne | right | 21:08 |
bdpayne | I think that there are | 21:08 |
bdpayne | so it would be nice to flush this out | 21:08 |
bdpayne | but I don't think that it is making the guide harder to understand | 21:08 |
elmiko | agreed | 21:08 |
bdpayne | which is why I think wishlist makes sense | 21:09 |
elmiko | also, we should make sure to update the glossary once we reach consensus | 21:09 |
bdpayne | yeah | 21:09 |
sicarie | +1 | 21:09 |
bdpayne | ok | 21:09 |
bdpayne | https://bugs.launchpad.net/openstack-manuals/+bug/1342406 | 21:09 |
openstack | Launchpad bug 1342406 in openstack-manuals "Chapter 13. Database access control in OpenStack Security Guide -> Nova Conductor - current - summary of risks/benefits" [Wishlist,Confirmed] - Assigned to Malini Bhandaru (malini-k-bhandaru) | 21:09 |
bdpayne | I think this is a good suggestion | 21:09 |
bdpayne | I think wishlist makes sense as well | 21:10 |
elmiko | definitely sounds like an improvement, but not urgetn | 21:10 |
elmiko | *urgent | 21:10 |
sicarie | Yep | 21:10 |
bdpayne | https://bugs.launchpad.net/openstack-manuals/+bug/1342421 | 21:10 |
openstack | Launchpad bug 1342421 in openstack-manuals "Chapter 30. Messaging security in OpenStack Security Guide -> Message queue process isolation and policy - current - more details need for namespaces and zeromq" [Wishlist,Confirmed] | 21:10 |
openstackgerrit | Tyler Britten proposed openstack/security-doc: Reworded the sentence to make it clearer and less choppy https://review.openstack.org/155036 | 21:11 |
elmiko | hmm | 21:11 |
elmiko | that seems like it could be a deep issue | 21:12 |
bdpayne | yeah, network namespaces are all kinds of annoying | 21:12 |
bdpayne | I wonder if that's even the right suggestion here | 21:12 |
bdpayne | as in, should we be recommending it | 21:13 |
bdpayne | it does have some nice properties | 21:13 |
bdpayne | but... yeah | 21:13 |
elmiko | it seems very specific to an installation though, like if you need it you will know | 21:13 |
bdpayne | alas... on this ticket... assuming we keep network namespaces, I agree that a diagram woudl be useful | 21:13 |
elmiko | i think something high level, like the diagram, would definitely help | 21:13 |
bdpayne | yeah, so let's keep this ticket | 21:14 |
elmiko | not sure how deep we should get into the discussion from there though | 21:14 |
bdpayne | ok, so I put "Idea here should be to provide a high level diagram, but not get too deep into the discussion of network namespaces, which is probably best left to other guides. We do think that a diagram would be useful here." | 21:15 |
elmiko | +1 | 21:15 |
bdpayne | https://bugs.launchpad.net/openstack-manuals/+bug/1342430 | 21:15 |
openstack | Launchpad bug 1342430 in openstack-manuals "Chapter 40. Hypervisor selection in OpenStack Security Guide -> Selection Criteria - current - generalize selection criteria" [Wishlist,Confirmed] | 21:15 |
*** singlethink has joined #openstack-security | 21:16 | |
elmiko | +1 to the idea, i think it would really help | 21:16 |
bdpayne | yeah, seems reasonable | 21:16 |
bdpayne | I'm ok with wishlist here | 21:16 |
elmiko | i have a question, how will we move from wishlist to an action item? | 21:17 |
bdpayne | ? | 21:17 |
sicarie | I'd say wishlist, but mostly because I think the decision on hypervisor is mostly up to ops - security is usually "this is what we're going with, harden it" | 21:17 |
bdpayne | sicare that can really depend | 21:18 |
openstackgerrit | Tyler Britten proposed openstack/security-doc: Reworded the sentence to make it clearer and less choppy https://review.openstack.org/155036 | 21:18 |
elmiko | well, this one seems to me like it would be really useful. i could see elevating the priority, but i'm curious how do we decide to take something from a wishlist item to a blueprint/review? | 21:18 |
bdpayne | elmiko I think that the items on wishlist are actionable | 21:18 |
elmiko | ok, thanks. my misunderstanding | 21:18 |
bdpayne | we could certainly bump it up | 21:18 |
bdpayne | I think the idea is just to sort the urgency of everything | 21:19 |
elmiko | got it | 21:19 |
bdpayne | where, to me, wishlist is more of an enhacement to what is already there | 21:19 |
elmiko | makes sense | 21:19 |
bdpayne | kk | 21:19 |
elmiko | we don't really have a spec process for sec-doc either, so maybe wishlist makes sense for things we'd like to see | 21:19 |
bdpayne | https://bugs.launchpad.net/openstack-manuals/+bug/1343480 | 21:19 |
openstack | Launchpad bug 1343480 in openstack-manuals "Fix references provided as lists of URLs" [Wishlist,Triaged] | 21:19 |
bdpayne | yeah | 21:20 |
bdpayne | I think it is generally up to the person doing the work to spec it out | 21:20 |
bdpayne | but we can certainly add more definition in the bugs | 21:20 |
sicarie | Oh +1 on this one | 21:20 |
bdpayne | which, this one that I just linked could probably benefit from | 21:20 |
bdpayne | yeah, this would be nice to do | 21:21 |
sicarie | The compute chapter (what there is of it) is rife with this | 21:21 |
bdpayne | but the reporter should really have provided more specific details ;-) | 21:21 |
sicarie | I think there might be a few n the Dashboard chapter too | 21:21 |
sicarie | I can fill those in | 21:21 |
elmiko | i like this one, might be difficult to maintain for some things. | 21:21 |
sicarie | Should I throw them all into this bug, or track them individually? | 21:21 |
elmiko | also, i may have just added a bunch of links i need to fix ... ;) | 21:21 |
bdpayne | ok, added the comment "Would be nice to fill out this ticket with details of where we need to make this fixes. Perhaps even break this into multiple tickets. That will help to make this more actionable." | 21:22 |
sicarie | hehe | 21:22 |
elmiko | sicarie: maybe by chapter? | 21:22 |
bdpayne | yeah, I'd prefer separate bugs per chapter for this cleanup | 21:22 |
bdpayne | that would be nice | 21:22 |
bdpayne | and more tractable | 21:22 |
sicarie | sounds good | 21:22 |
elmiko | honestly though, for bigger changes we could almost go to the file resolution and make reviews for each chapter/section document | 21:22 |
bdpayne | yeah | 21:23 |
bdpayne | sicare you want to take the task of breaking this out into multiple tickets? | 21:23 |
sicarie | sure! | 21:23 |
bdpayne | thanks | 21:23 |
bdpayne | https://bugs.launchpad.net/openstack-manuals/+bug/1347057 | 21:23 |
openstack | Launchpad bug 1347057 in openstack-manuals "Security Guide - New Chapter on Vulnerability Management" [Wishlist,Triaged] | 21:23 |
sicarie | +1 for wishlist - good idea, but will be interesting to expand on vuln mgmt in a generalized sense | 21:24 |
bdpayne | I think my comment from last July still holds | 21:24 |
bdpayne | perhaps I'll aim to get Travis to flush out these ideas a bit next week | 21:24 |
elmiko | +1 seems like a really nice addition | 21:24 |
bdpayne | ok... last one! https://bugs.launchpad.net/openstack-manuals/+bug/1418661 | 21:25 |
openstack | Launchpad bug 1418661 in openstack-manuals "Example TLS / SSL potentially insecure " [Undecided,New] | 21:25 |
bdpayne | I suggest taking this as a high | 21:25 |
bdpayne | actually, critical | 21:26 |
elmiko | yea, i'd say high at a minimum | 21:26 |
sicarie | Yeah, definitely dont' want to be giving inaccurate/insecure info | 21:26 |
elmiko | +1 | 21:26 |
bdpayne | and I'll assign this to myself | 21:26 |
bdpayne | I should do a little work from time to time | 21:26 |
bdpayne | ;-) | 21:26 |
sicarie | :D | 21:26 |
*** singlethink has quit IRC | 21:26 | |
elmiko | hehe | 21:26 |
bdpayne | ok, so we have now walked through all of the bugs | 21:27 |
bdpayne | so next week is the mid-cycle meetup, so let's skip this IRC meeting | 21:27 |
sicarie | If we have a minute, I have a few that aren't tagged sec-guide yet | 21:27 |
elmiko | works for me | 21:27 |
sicarie | Sounds good | 21:27 |
bdpayne | but perhaps we should resume the following week to plan out our next steps post meetup | 21:27 |
elmiko | i'm up for that | 21:28 |
bdpayne | I'm hoping that sicarie and I will have some time to put together a game plan for us going forward next week | 21:28 |
elmiko | unfortunately i won't be at the meetup =( | 21:28 |
bdpayne | elmiko feel free to send ideas along as well | 21:28 |
bdpayne | email, etc is fine | 21:28 |
elmiko | cool, thanks | 21:28 |
bdpayne | sicarie can you tag the other bugs with sec-guide? | 21:28 |
sicarie | yep, going through now | 21:28 |
sicarie | For some reason I didn't realize I could edit that stuff until last week | 21:29 |
sicarie | :\ | 21:29 |
sicarie | Plus I'm trying not to edit/set priority on my own stuff | 21:29 |
bdpayne | heh | 21:30 |
bdpayne | sicarie I'm going to need to run so perhaps we can review those remaining ones next week | 21:30 |
bdpayne | ? | 21:30 |
sicarie | Sounds good to me | 21:31 |
elmiko | i have some questions about the Bob case study for when we have more time to talk | 21:31 |
elmiko | maybe it will be a good topic to bring up in vancouver though | 21:31 |
bdpayne | sure... or email or here and I can read later | 21:31 |
bdpayne | ok that's all for today... thanks! | 21:32 |
elmiko | k | 21:32 |
elmiko | take care =) | 21:32 |
sicarie | thanks! | 21:32 |
*** singlethink has joined #openstack-security | 21:35 | |
*** tmcpeak has quit IRC | 22:07 | |
*** tmcpeak has joined #openstack-security | 22:25 | |
*** ljfisher has quit IRC | 22:43 | |
openstackgerrit | Michael McCune proposed openstack/security-doc: Adding data processing chapter https://review.openstack.org/155052 | 22:43 |
*** singlethink has quit IRC | 22:59 | |
*** singlethink has joined #openstack-security | 23:01 | |
*** singlethink has quit IRC | 23:06 | |
openstackgerrit | Michael McCune proposed openstack/security-doc: Adding data processing chapter https://review.openstack.org/155052 | 23:11 |
openstackgerrit | Michael McCune proposed openstack/security-doc: Adding data processing chapter https://review.openstack.org/155052 | 23:17 |
elmiko | sicarie: hey | 23:18 |
sicarie | elmiko Hi! | 23:19 |
elmiko | i'm a little confused about the whole capitalization issue | 23:19 |
elmiko | oh, and thanks for the comments! | 23:19 |
sicarie | Found my other two questions, was about to submit it but you keep dropping patches on my notes :) | 23:19 |
elmiko | haha, sorry | 23:19 |
sicarie | Yeah, i'm not sure either I think bdpayne needs to come back | 23:19 |
bdpayne | yo | 23:20 |
elmiko | i'm suspecting that you, and another who pointed it out, are correct though. those probably should be capitalized | 23:20 |
elmiko | hey | 23:20 |
elmiko | i'm having some issues with when to use capitalization of the service name | 23:20 |
bdpayne | what's the question? | 23:20 |
elmiko | if i'm talking about "the Data processing service" the capitalization is obvious | 23:21 |
elmiko | but, | 23:21 |
elmiko | if i say, "so-and-so interacts with data processing" do i capitalize? | 23:21 |
bdpayne | first see https://wiki.openstack.org/wiki/Documentation/Conventions#Service_and_project_names | 23:21 |
elmiko | got it open =) | 23:22 |
bdpayne | generally cap is needed when saying OpenStack Blah but not when saying blah | 23:22 |
bdpayne | if that makes sense | 23:22 |
bdpayne | so OpenStack Data Processing Service | 23:22 |
elmiko | i think so | 23:22 |
sicarie | ah | 23:22 |
bdpayne | or data processing service | 23:22 |
sicarie | good to know | 23:22 |
elmiko | yea | 23:22 |
bdpayne | unless | 23:22 |
bdpayne | well | 23:22 |
bdpayne | perhaps I'm leading you a touch astray here | 23:22 |
bdpayne | if you are saying data processing service and really referencing _the_ _OpenStack_ data processing service, then it should be Data Processing Service | 23:23 |
sicarie | to be fair, elmiko, he is going to have to review and +2/-2 to have the chapter merged :) | 23:23 |
bdpayne | if you are talking about some generic data processing service, then no caps | 23:23 |
elmiko | sicarie: good point | 23:23 |
elmiko | bdpayne: ok, i probably have it backwards in a few places then | 23:23 |
bdpayne | but yeah, perhaps best to wait 24-48 hours for some reviews and then take a pass at cleanup | 23:24 |
bdpayne | that helps reduce church with the larger CR | 23:24 |
elmiko | agreed, i'll hold off for now. just wanted to correct some whitespace and tox errors | 23:24 |
sicarie | elmiko: I added another comment about logging details, but it looks very good! | 23:25 |
elmiko | sicarie: thanks =) | 23:25 |
elmiko | bdpayne: and thanks for the consult | 23:25 |
bdpayne | sure, np | 23:25 |
elmiko | g'night folks | 23:26 |
sicarie | night! | 23:26 |
*** sicarie has left #openstack-security | 23:36 | |
*** singlethink has joined #openstack-security | 23:47 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!