| *** tmcpeak has quit IRC | 00:35 | |
| *** bdpayne has quit IRC | 00:44 | |
| *** voodookid has joined #openstack-security | 01:35 | |
| *** voodookid has quit IRC | 03:07 | |
| *** bdpayne has joined #openstack-security | 03:12 | |
| *** bdpayne has quit IRC | 03:41 | |
| *** voodookid has joined #openstack-security | 04:00 | |
| *** voodookid has quit IRC | 04:13 | |
| *** bdpayne has joined #openstack-security | 04:23 | |
| *** voodookid has joined #openstack-security | 04:29 | |
| *** voodookid has quit IRC | 04:41 | |
| *** bdpayne has quit IRC | 05:02 | |
| *** voodookid has joined #openstack-security | 05:07 | |
| *** bdpayne has joined #openstack-security | 05:08 | |
| openstackgerrit | A change was merged to openstack/security-doc: Remove wording advising against certain wsgi services https://review.openstack.org/117596 | 05:09 |
|---|---|---|
| *** voodookid has quit IRC | 05:12 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/117527 | 05:22 |
| *** jamielennox has quit IRC | 05:48 | |
| *** jamielennox has joined #openstack-security | 05:48 | |
| *** jamielennox has quit IRC | 05:50 | |
| *** jamielennox has joined #openstack-security | 05:50 | |
| *** bdpayne has quit IRC | 06:02 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/security-doc: Imported Translations from Transifex https://review.openstack.org/117693 | 06:05 |
| *** bdpayne has joined #openstack-security | 06:09 | |
| *** bdpayne has quit IRC | 06:36 | |
| *** zz_naotok is now known as naotok | 06:46 | |
| openstackgerrit | A change was merged to openstack/security-doc: Imported Translations from Transifex https://review.openstack.org/117693 | 06:49 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/117527 | 07:27 |
| *** jamielennox is now known as jamielennox|away | 07:46 | |
| openstackgerrit | A change was merged to openstack/security-doc: Updated from openstack-manuals https://review.openstack.org/117527 | 09:06 |
| *** mandela900 has joined #openstack-security | 09:13 | |
| *** marzif_ has joined #openstack-security | 09:48 | |
| *** jeblair_ has joined #openstack-security | 09:48 | |
| *** jeblair has quit IRC | 09:50 | |
| *** marzif has quit IRC | 09:50 | |
| *** sweston_ has joined #openstack-security | 09:55 | |
| *** erw_ has joined #openstack-security | 09:58 | |
| *** naotok_ has joined #openstack-security | 10:03 | |
| *** naotok has quit IRC | 10:09 | |
| *** erw has quit IRC | 10:09 | |
| *** sweston has quit IRC | 10:09 | |
| *** sweston_ is now known as sweston | 10:10 | |
| *** erw_ is now known as erw | 10:10 | |
| *** openstackgerrit has quit IRC | 10:34 | |
| *** bknudson has quit IRC | 10:34 | |
| *** bknudson has joined #openstack-security | 10:40 | |
| *** openstackgerrit has joined #openstack-security | 10:40 | |
| *** erw_ has joined #openstack-security | 10:49 | |
| *** Glass_saga_ has quit IRC | 10:55 | |
| *** erw has quit IRC | 10:55 | |
| *** erw_ is now known as erw | 10:58 | |
| *** Glass_saga_ has joined #openstack-security | 11:04 | |
| *** Dafna has joined #openstack-security | 11:12 | |
| *** naotok_ is now known as zz_naotok_ | 11:29 | |
| *** gmurphy has quit IRC | 11:30 | |
| *** gmurphy has joined #openstack-security | 11:33 | |
| *** dmccowan_ has joined #openstack-security | 12:12 | |
| *** dmccowan has quit IRC | 12:13 | |
| *** dmccowan_ is now known as dmccowan | 12:13 | |
| *** dmccowan_ has joined #openstack-security | 12:36 | |
| *** dmccowan has quit IRC | 12:37 | |
| *** dmccowan_ is now known as dmccowan | 12:37 | |
| *** bknudson has quit IRC | 13:24 | |
| *** voodookid has joined #openstack-security | 13:35 | |
| *** voodookid has quit IRC | 13:36 | |
| *** tmcpeak has joined #openstack-security | 13:42 | |
| *** bknudson has joined #openstack-security | 14:02 | |
| *** dmccowan has quit IRC | 14:31 | |
| *** voodookid has joined #openstack-security | 14:34 | |
| *** dmccowan has joined #openstack-security | 14:46 | |
| *** bdpayne has joined #openstack-security | 15:12 | |
| *** jeblair_ is now known as jeblair | 15:17 | |
| tmcpeak | nkinder: you around? | 15:55 |
| nkinder | tmcpeak: yeah, what's up? | 15:56 |
| tmcpeak | got first wave of changes for Bandit, you got a minute to take a look? | 15:56 |
| tmcpeak | https://github.com/mcpeak/bandit/compare/chair6:master...master | 15:56 |
| nkinder | tmcpeak: is seems strange to have to do 'context = b_context.Context(cur_context)' in every test | 16:00 |
| nkinder | tmcpeak: can we avoid that? The less logic needed in the test that is not related to what we're trying to test, the better | 16:00 |
| tmcpeak | yeah, I hear you | 16:01 |
| tmcpeak | cur_context is the raw context that was getting passed before | 16:01 |
| tmcpeak | so if you want to do any raw node manipulation you use that | 16:01 |
| tmcpeak | creating an instance of Context allows you to do the nicer stuff | 16:01 |
| nkinder | tmcpeak: so the Context instance doesn't have access to the raw node? | 16:02 |
| tmcpeak | otherwise I think I'd need to have cur_context be a parameter of all of these functions and that seems even messier | 16:02 |
| nkinder | why not have the raw node be a parameter of the Context object? | 16:02 |
| tmcpeak | oh I see, you're just saying pass in Context | 16:02 |
| nkinder | Context.node | 16:02 |
| nkinder | yes | 16:03 |
| tmcpeak | oh yeah | 16:03 |
| tmcpeak | duh | 16:03 |
| tmcpeak | yes, that will work :) | 16:03 |
| tmcpeak | brain far | 16:03 |
| tmcpeak | t | 16:03 |
| nkinder | so pass in Context to simplify the test code, but be sure that tests can get at the raw node if they need to do something extra fancy | 16:03 |
| tmcpeak | cool | 16:03 |
| tmcpeak | solid point | 16:03 |
| nkinder | aside from thta, the approach looks good | 16:03 |
| tmcpeak | cool, I'll make that update | 16:03 |
| tmcpeak | thanks for having a look! | 16:04 |
| nkinder | one minor point to make is that reordering the tests makes it difficult to see exactly what you changed | 16:04 |
| nkinder | next time, split the refactoring into a separate commit | 16:04 |
| *** bdpayne has quit IRC | 16:04 | |
| tmcpeak | did I? | 16:04 |
| nkinder | so have a "reorder tests" commit that just moves existing code around, then your real context work so the diff shows the lines that were changed | 16:04 |
| tmcpeak | reorder I mean? | 16:04 |
| tmcpeak | I thought I kept the order the same | 16:05 |
| nkinder | tmcpeak: ah, you did | 16:05 |
| tmcpeak | oh, I think I know what happened | 16:05 |
| nkinder | the diff just makes it look like large blocks were moved (don't think they were) | 16:05 |
| tmcpeak | since I changed parameter name it thinks it's a different function? | 16:05 |
| *** bdpayne has joined #openstack-security | 16:06 | |
| *** bdpayne has quit IRC | 16:06 | |
| nkinder | tmcpeak: nah, your good. My mistake | 16:06 |
| nkinder | tmcpeak: the code is different, but the order is the same | 16:06 |
| tmcpeak | I see what you mean though, it is hard to read like that :) | 16:06 |
| *** ptd has joined #openstack-security | 16:31 | |
| *** bdpayne has joined #openstack-security | 16:33 | |
| *** Dafna has quit IRC | 16:36 | |
| *** nkinder has quit IRC | 17:02 | |
| *** mandela900 has quit IRC | 17:24 | |
| *** ptd has quit IRC | 17:42 | |
| *** sweston has quit IRC | 18:47 | |
| *** sweston_ has joined #openstack-security | 18:48 | |
| *** dmccowan has quit IRC | 19:48 | |
| *** dmccowan has joined #openstack-security | 20:02 | |
| *** dmccowan has quit IRC | 20:07 | |
| *** dmccowan has joined #openstack-security | 20:08 | |
| *** paulmo has quit IRC | 20:55 | |
| *** dmccowan has quit IRC | 21:42 | |
| *** marzif__ has joined #openstack-security | 21:45 | |
| *** bknudson has quit IRC | 21:52 | |
| *** marzif_ has quit IRC | 21:52 | |
| *** bknudson has joined #openstack-security | 22:03 | |
| *** bknudson has quit IRC | 22:21 | |
| *** voodookid has quit IRC | 22:43 | |
| *** tmcpeak has quit IRC | 22:53 | |
| *** bdpayne has quit IRC | 23:41 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!