*** robcresswell has quit IRC | 00:04 | |
*** yingjun has joined #openstack-searchlight | 00:25 | |
*** ddieterly has joined #openstack-searchlight | 01:06 | |
*** ddieterly has quit IRC | 01:41 | |
openstackgerrit | Li Yingjun proposed openstack/searchlight: Fix dot issue in field name https://review.openstack.org/372042 | 01:47 |
---|---|---|
*** TravT has joined #openstack-searchlight | 02:12 | |
*** TravT has quit IRC | 02:14 | |
*** TravT_ has joined #openstack-searchlight | 02:15 | |
*** TravT_ has quit IRC | 02:15 | |
*** TravT has joined #openstack-searchlight | 02:16 | |
*** TravT has quit IRC | 02:16 | |
*** TravT has joined #openstack-searchlight | 02:17 | |
*** TravT has quit IRC | 02:18 | |
*** TravT has joined #openstack-searchlight | 02:18 | |
*** TravT has quit IRC | 02:19 | |
*** TravT has joined #openstack-searchlight | 02:20 | |
*** TravT_ has joined #openstack-searchlight | 02:24 | |
*** TravT has quit IRC | 02:25 | |
openstackgerrit | gengchc2 proposed openstack/searchlight: Fix a typo in authoring-plugins.rst,etc https://review.openstack.org/379055 | 02:28 |
*** TravT has joined #openstack-searchlight | 02:29 | |
*** TravT_ has quit IRC | 02:30 | |
*** TravT has quit IRC | 02:30 | |
*** TravT has joined #openstack-searchlight | 02:30 | |
*** TravT has quit IRC | 02:31 | |
*** TravT has joined #openstack-searchlight | 02:33 | |
*** TravT has quit IRC | 02:36 | |
*** TravT has joined #openstack-searchlight | 02:36 | |
*** TravT has quit IRC | 02:41 | |
*** TravT_ has joined #openstack-searchlight | 02:41 | |
*** TravT_ has quit IRC | 02:45 | |
*** TravT has joined #openstack-searchlight | 02:45 | |
*** TravT_ has joined #openstack-searchlight | 02:50 | |
*** TravT has quit IRC | 02:50 | |
*** TravT_ has quit IRC | 02:55 | |
*** TravT has joined #openstack-searchlight | 02:55 | |
*** TravT_ has joined #openstack-searchlight | 03:00 | |
*** TravT has quit IRC | 03:00 | |
*** TravT_ has quit IRC | 03:04 | |
*** david-lyle has quit IRC | 03:04 | |
*** TravT has joined #openstack-searchlight | 03:04 | |
*** TravT has quit IRC | 03:09 | |
*** TravT has joined #openstack-searchlight | 03:09 | |
*** TravT has quit IRC | 03:14 | |
*** TravT has joined #openstack-searchlight | 03:14 | |
*** TravT has quit IRC | 03:18 | |
*** TravT has joined #openstack-searchlight | 03:19 | |
*** TravT_ has joined #openstack-searchlight | 03:23 | |
*** TravT has quit IRC | 03:23 | |
*** TravT_ has quit IRC | 03:28 | |
*** TravT has joined #openstack-searchlight | 03:28 | |
*** TravT has quit IRC | 03:33 | |
*** TravT has joined #openstack-searchlight | 03:33 | |
*** TravT has quit IRC | 03:37 | |
*** TravT_ has joined #openstack-searchlight | 03:37 | |
*** TravT_ has quit IRC | 03:42 | |
*** TravT has joined #openstack-searchlight | 03:42 | |
*** ddieterly has joined #openstack-searchlight | 03:44 | |
*** ddieterly has quit IRC | 03:45 | |
*** TravT has quit IRC | 03:47 | |
*** TravT has joined #openstack-searchlight | 03:47 | |
*** TravT_ has joined #openstack-searchlight | 03:52 | |
*** TravT has quit IRC | 03:52 | |
*** TravT_ has quit IRC | 03:56 | |
*** TravT has joined #openstack-searchlight | 03:56 | |
*** TravT_ has joined #openstack-searchlight | 04:01 | |
*** TravT has quit IRC | 04:01 | |
*** TravT_ has quit IRC | 04:06 | |
*** ddieterly has joined #openstack-searchlight | 04:47 | |
*** ddieterly has quit IRC | 04:52 | |
*** GB21 has joined #openstack-searchlight | 04:57 | |
*** TravT has joined #openstack-searchlight | 05:02 | |
*** GB21 has quit IRC | 05:02 | |
*** TravT_ has joined #openstack-searchlight | 05:07 | |
*** TravT has quit IRC | 05:07 | |
*** TravT_ has quit IRC | 05:11 | |
*** TravT has joined #openstack-searchlight | 05:11 | |
*** TravT has quit IRC | 05:12 | |
*** TravT has joined #openstack-searchlight | 05:13 | |
*** GB21 has joined #openstack-searchlight | 05:15 | |
*** TravT has quit IRC | 05:16 | |
*** TravT has joined #openstack-searchlight | 05:16 | |
*** TravT has quit IRC | 05:20 | |
*** TravT has joined #openstack-searchlight | 05:21 | |
*** TravT_ has joined #openstack-searchlight | 05:26 | |
*** TravT has quit IRC | 05:26 | |
*** TravT has joined #openstack-searchlight | 05:30 | |
*** TravT_ has quit IRC | 05:31 | |
*** TravT has quit IRC | 05:35 | |
*** TravT has joined #openstack-searchlight | 05:40 | |
*** TravT has quit IRC | 05:44 | |
*** TravT has joined #openstack-searchlight | 05:44 | |
*** TravT has quit IRC | 05:49 | |
*** TravT_ has joined #openstack-searchlight | 05:49 | |
*** TravT_ has quit IRC | 05:54 | |
*** TravT has joined #openstack-searchlight | 05:54 | |
*** TravT has quit IRC | 05:58 | |
*** TravT_ has joined #openstack-searchlight | 05:58 | |
*** TravT_ has quit IRC | 06:03 | |
*** TravT has joined #openstack-searchlight | 06:03 | |
*** TravT has quit IRC | 06:07 | |
*** TravT has joined #openstack-searchlight | 06:08 | |
*** TravT has quit IRC | 06:13 | |
*** TravT_ has joined #openstack-searchlight | 06:13 | |
*** TravT_ has quit IRC | 06:17 | |
*** TravT has joined #openstack-searchlight | 06:17 | |
*** TravT has quit IRC | 06:22 | |
*** TravT has joined #openstack-searchlight | 06:22 | |
*** TravT has quit IRC | 06:26 | |
*** TravT has joined #openstack-searchlight | 06:27 | |
*** TravT has quit IRC | 06:31 | |
*** TravT has joined #openstack-searchlight | 06:31 | |
*** TravT_ has joined #openstack-searchlight | 06:36 | |
*** TravT has quit IRC | 06:37 | |
*** pcaruana has joined #openstack-searchlight | 06:39 | |
*** TravT_ has quit IRC | 06:41 | |
*** TravT has joined #openstack-searchlight | 06:41 | |
*** TravT has quit IRC | 06:45 | |
*** TravT has joined #openstack-searchlight | 06:46 | |
*** TravT has quit IRC | 06:50 | |
*** TravT has joined #openstack-searchlight | 06:50 | |
*** GB21 has quit IRC | 06:53 | |
*** TravT_ has joined #openstack-searchlight | 06:55 | |
*** TravT has quit IRC | 06:55 | |
*** TravT_ has quit IRC | 06:59 | |
*** TravT has joined #openstack-searchlight | 07:00 | |
*** TravT_ has joined #openstack-searchlight | 07:04 | |
*** TravT has quit IRC | 07:05 | |
*** GB21 has joined #openstack-searchlight | 07:06 | |
*** TravT_ has quit IRC | 07:09 | |
*** TravT has joined #openstack-searchlight | 07:09 | |
*** TravT_ has joined #openstack-searchlight | 07:14 | |
*** TravT has quit IRC | 07:14 | |
*** TravT_ has quit IRC | 07:15 | |
*** TravT has joined #openstack-searchlight | 07:15 | |
*** TravT has quit IRC | 07:18 | |
*** TravT has joined #openstack-searchlight | 07:19 | |
*** TravT_ has joined #openstack-searchlight | 07:23 | |
*** TravT has quit IRC | 07:23 | |
*** TravT_ has quit IRC | 07:28 | |
*** TravT has joined #openstack-searchlight | 07:28 | |
*** TravT has quit IRC | 07:33 | |
*** TravT_ has joined #openstack-searchlight | 07:33 | |
*** TravT has joined #openstack-searchlight | 07:37 | |
*** TravT_ has quit IRC | 07:38 | |
*** TravT has quit IRC | 07:42 | |
*** TravT has joined #openstack-searchlight | 07:42 | |
*** TravT_ has joined #openstack-searchlight | 07:47 | |
*** TravT has quit IRC | 07:47 | |
*** TravT has joined #openstack-searchlight | 07:52 | |
*** TravT_ has quit IRC | 07:52 | |
*** TravT_ has joined #openstack-searchlight | 07:56 | |
*** TravT has quit IRC | 07:56 | |
*** TravT has joined #openstack-searchlight | 08:01 | |
*** TravT_ has quit IRC | 08:01 | |
*** TravT has quit IRC | 08:05 | |
*** TravT_ has joined #openstack-searchlight | 08:06 | |
*** TravT_ has quit IRC | 08:10 | |
*** TravT has joined #openstack-searchlight | 08:10 | |
*** TravT has quit IRC | 08:15 | |
*** TravT has joined #openstack-searchlight | 08:15 | |
*** TravT_ has joined #openstack-searchlight | 08:20 | |
*** TravT has quit IRC | 08:20 | |
*** TravT_ has quit IRC | 08:24 | |
*** TravT has joined #openstack-searchlight | 08:24 | |
*** TravT has quit IRC | 08:29 | |
*** TravT_ has joined #openstack-searchlight | 08:29 | |
*** shu-mutou-AWAY has quit IRC | 08:33 | |
*** TravT has joined #openstack-searchlight | 08:34 | |
*** TravT_ has quit IRC | 08:34 | |
*** TravT has quit IRC | 08:38 | |
*** TravT has joined #openstack-searchlight | 08:38 | |
*** TravT has quit IRC | 08:43 | |
*** TravT_ has joined #openstack-searchlight | 08:43 | |
*** TravT has joined #openstack-searchlight | 08:48 | |
*** TravT_ has quit IRC | 08:48 | |
*** TravT has quit IRC | 08:52 | |
*** TravT has joined #openstack-searchlight | 08:53 | |
*** TravT_ has joined #openstack-searchlight | 08:57 | |
*** TravT has quit IRC | 08:58 | |
*** TravT has joined #openstack-searchlight | 09:02 | |
*** TravT_ has quit IRC | 09:02 | |
*** TravT has quit IRC | 09:06 | |
*** TravT has joined #openstack-searchlight | 09:07 | |
*** TravT has quit IRC | 09:11 | |
*** TravT_ has joined #openstack-searchlight | 09:11 | |
*** TravT_ has quit IRC | 09:16 | |
*** TravT has joined #openstack-searchlight | 09:16 | |
*** TravT has quit IRC | 09:21 | |
*** TravT has joined #openstack-searchlight | 09:21 | |
*** robcresswell has joined #openstack-searchlight | 09:25 | |
*** TravT has quit IRC | 09:26 | |
*** TravT_ has joined #openstack-searchlight | 09:26 | |
*** yingjun has quit IRC | 09:27 | |
*** TravT has joined #openstack-searchlight | 09:30 | |
*** TravT_ has quit IRC | 09:31 | |
*** TravT has quit IRC | 09:34 | |
*** TravT has joined #openstack-searchlight | 09:35 | |
*** TravT has quit IRC | 09:40 | |
*** TravT_ has joined #openstack-searchlight | 09:40 | |
*** TravT_ has quit IRC | 09:44 | |
*** TravT has joined #openstack-searchlight | 09:44 | |
*** TravT has quit IRC | 09:49 | |
*** TravT has joined #openstack-searchlight | 09:49 | |
*** TravT_ has joined #openstack-searchlight | 09:54 | |
*** TravT has quit IRC | 09:54 | |
*** TravT_ has quit IRC | 09:58 | |
*** TravT has joined #openstack-searchlight | 09:58 | |
*** TravT has quit IRC | 10:03 | |
*** TravT_ has joined #openstack-searchlight | 10:03 | |
*** TravT_ has quit IRC | 10:08 | |
*** TravT has joined #openstack-searchlight | 10:08 | |
*** TravT_ has joined #openstack-searchlight | 10:12 | |
*** TravT has quit IRC | 10:13 | |
*** TravT has joined #openstack-searchlight | 10:17 | |
*** TravT_ has quit IRC | 10:17 | |
*** GB21 has quit IRC | 10:19 | |
*** TravT has quit IRC | 10:22 | |
*** TravT_ has joined #openstack-searchlight | 10:22 | |
*** GB21 has joined #openstack-searchlight | 10:25 | |
*** TravT_ has quit IRC | 10:26 | |
*** TravT has joined #openstack-searchlight | 10:27 | |
*** TravT has quit IRC | 10:31 | |
*** TravT_ has joined #openstack-searchlight | 10:31 | |
*** TravT has joined #openstack-searchlight | 10:36 | |
*** TravT_ has quit IRC | 10:36 | |
*** TravT has quit IRC | 10:40 | |
*** TravT has joined #openstack-searchlight | 10:41 | |
*** TravT_ has joined #openstack-searchlight | 10:45 | |
*** TravT has quit IRC | 10:46 | |
*** TravT_ has quit IRC | 10:50 | |
*** TravT has joined #openstack-searchlight | 10:50 | |
*** TravT has quit IRC | 10:55 | |
*** TravT has joined #openstack-searchlight | 11:51 | |
*** TravT has quit IRC | 11:55 | |
*** TravT has joined #openstack-searchlight | 11:56 | |
*** TravT has quit IRC | 12:01 | |
*** GB21 has quit IRC | 12:19 | |
*** matt-borland has joined #openstack-searchlight | 12:52 | |
*** TravT has joined #openstack-searchlight | 12:57 | |
*** david-lyle has joined #openstack-searchlight | 12:57 | |
*** TravT has quit IRC | 13:01 | |
*** TravT has joined #openstack-searchlight | 13:01 | |
*** TravT has quit IRC | 13:06 | |
*** TravT has joined #openstack-searchlight | 13:06 | |
*** TravT has quit IRC | 13:10 | |
*** TravT has joined #openstack-searchlight | 13:11 | |
*** TravT has quit IRC | 13:15 | |
*** TravT has joined #openstack-searchlight | 13:15 | |
*** TravT_ has joined #openstack-searchlight | 13:20 | |
*** TravT has quit IRC | 13:20 | |
*** TravT_ has quit IRC | 13:24 | |
*** TravT has joined #openstack-searchlight | 13:25 | |
*** Kevin_Zheng has quit IRC | 13:26 | |
*** TravT has quit IRC | 13:29 | |
*** TravT_ has joined #openstack-searchlight | 13:30 | |
openstackgerrit | Hironori Shiina proposed openstack/searchlight: Fix a typo in documentation https://review.openstack.org/380294 | 13:32 |
*** TravT_ has quit IRC | 13:34 | |
*** TravT has joined #openstack-searchlight | 13:34 | |
*** TravT has quit IRC | 13:39 | |
*** TravT has joined #openstack-searchlight | 13:39 | |
*** TravT has quit IRC | 13:43 | |
*** TravT has joined #openstack-searchlight | 13:44 | |
*** TravT_ has joined #openstack-searchlight | 13:48 | |
*** TravT has quit IRC | 13:49 | |
*** TravT_ has quit IRC | 13:53 | |
*** TravT has joined #openstack-searchlight | 13:53 | |
*** TravT has quit IRC | 13:58 | |
*** TravT has joined #openstack-searchlight | 13:58 | |
*** TravT_ has joined #openstack-searchlight | 14:02 | |
*** TravT has quit IRC | 14:02 | |
*** sjmc7 has joined #openstack-searchlight | 14:07 | |
*** TravT_ has quit IRC | 14:07 | |
*** TravT has joined #openstack-searchlight | 14:07 | |
*** TravT has quit IRC | 14:12 | |
*** TravT_ has joined #openstack-searchlight | 14:12 | |
*** TravT has joined #openstack-searchlight | 14:16 | |
*** TravT_ has quit IRC | 14:16 | |
*** matt-borland has quit IRC | 14:31 | |
*** david-lyle has quit IRC | 14:37 | |
*** david-lyle has joined #openstack-searchlight | 14:38 | |
*** GB21 has joined #openstack-searchlight | 14:54 | |
*** mfedosin has joined #openstack-searchlight | 15:55 | |
mfedosin | TravT: sjmc7 GB21 hey :) | 16:02 |
mfedosin | how are you today? | 16:02 |
GB21 | \o mfedosin , TravT , GB21 | 16:02 |
GB21 | srry sjmc7 | 16:03 |
GB21 | :D | 16:03 |
sjmc7 | good evening | 16:03 |
GB21 | good evening sjmc7 | 16:03 |
mfedosin | I think it's a morning for TravT :) | 16:04 |
TravT | o. | 16:04 |
sjmc7 | and me :) i’m on an internal demo meeting, so please bear with me if i’m slow to respond for a little while | 16:04 |
TravT | same here.... | 16:04 |
GB21 | no problem | 16:04 |
mfedosin | sjmc7: np, we won't take much time | 16:04 |
sjmc7 | i know it’s pretty late for you guys so thanks for taking the time | 16:05 |
GB21 | no issues at all | 16:05 |
mfedosin | sjmc7: I'm used to it | 16:05 |
sjmc7 | :) | 16:05 |
GB21 | high five mfedosin | 16:05 |
sjmc7 | we in the US refuse to get up early :) | 16:05 |
*** itisha has joined #openstack-searchlight | 16:06 | |
GB21 | well, it is the same for us here as well | 16:07 |
sjmc7 | what was it you wanted to discuss? | 16:07 |
sjmc7 | i know you’ve spoken to travis a bit, mfedosin | 16:07 |
mfedosin | I think, the main question is how we can check that we send correct notifications | 16:07 |
mfedosin | and what config options we should set to make it work | 16:07 |
sjmc7 | ok. so in our ideal world, a notificaiton payload contains all hte information about a resource that needs to be indexed | 16:08 |
mfedosin | as I said we have notification and oslo_messaging support | 16:08 |
sjmc7 | other than that, if you’re using oslo_messaging | 16:08 |
sjmc7 | send the notification at the info level and we’ll be able to receive it in searchlight | 16:08 |
TravT | Not sure if I gave you this before... | 16:08 |
TravT | http://docs.openstack.org/developer/searchlight/authoring-plugins.html | 16:08 |
RickA-HP | To clarify what Steve said, this applies to both create and updates of a resource. | 16:09 |
GB21 | TravT, sjmc7 :I tried to explain mfedosin, how we add support for new plugins | 16:09 |
mfedosin | GB21: yep | 16:10 |
mfedosin | and now I'm interested how to configure glare | 16:10 |
mfedosin | as I see "notification_driver = messaging" is required | 16:10 |
sjmc7 | ok. so you shouldn’t need to configure glare, except yeah, notification_driver | 16:10 |
sjmc7 | i can email you a script to listen to notifications if you want to check that it’s sending the right thing | 16:10 |
sjmc7 | it might even be in the searchlight codebase.. | 16:11 |
mfedosin | so I just put this string in [oslo_messaging_notifications] section and that's all? | 16:11 |
TravT | steve, this is the script you put in searchlight | 16:11 |
sjmc7 | mfedosin: yes | 16:11 |
sjmc7 | https://github.com/openstack/searchlight/blob/master/test-scripts/listener.py | 16:11 |
TravT | mentioned here: http://docs.openstack.org/developer/searchlight/authoring-plugins.html#notification-pools | 16:11 |
mfedosin | sjmc7: perfect | 16:11 |
sjmc7 | that script listens to notifications and prints them out | 16:11 |
sjmc7 | you’d start it with ./listener.py glare test-listener | 16:11 |
mfedosin | but what about rabbit config? [oslo_messaging_rabbit] | 16:12 |
mfedosin | I think notifications won't work without rabbit_userid and password | 16:12 |
sjmc7 | yeah, but those are probably already configured if glare uses messaging internally? | 16:13 |
TravT | mfedosin: you have a good familiarity with glance (obviously)... | 16:13 |
TravT | here is the glance plugin guide for searchlight | 16:13 |
TravT | http://docs.openstack.org/developer/searchlight/plugins/glance.html | 16:13 |
sjmc7 | if not then yes, you’ll need to set them. we don’t have them in the docs i don’tthink because every service uses oslo_messaging for RPC | 16:13 |
sjmc7 | so yes, you will need those settings; if you use the config generator it’ll show all the available messaging settings | 16:14 |
mfedosin | that's fine. so it looks like almost everything is done on glare's side | 16:14 |
mfedosin | I need to update decstack plugin and that's all | 16:15 |
sjmc7 | yep | 16:15 |
sjmc7 | you can do it manually to check it rather than waiting for devstack | 16:15 |
mfedosin | I just did it | 16:16 |
mfedosin | It works | 16:16 |
sjmc7 | great! :) | 16:16 |
mfedosin | then I have a couple of questions about artifact structure | 16:16 |
TravT | and one more link for you | 16:16 |
TravT | http://docs.openstack.org/developer/searchlight/plugins.html#notifications | 16:16 |
mfedosin | TravT: it's for me and Geetika :) | 16:17 |
mfedosin | as I said in email there are common attributes and artifact type specific | 16:17 |
mfedosin | initially we don't need support of type specific | 16:18 |
mfedosin | and we can do single "artifact" plugin without them | 16:18 |
GB21 | mfedosin, like we are doing the other plugins in searchlight, right? | 16:18 |
mfedosin | let me show you our notification format | 16:18 |
mfedosin | GB21: correct | 16:19 |
mfedosin | https://github.com/openstack/glare/blob/master/glare/objects/base.py#L1054 | 16:19 |
TravT | mfedosin: I think you should define a base artifact type OS::Glare::Artifact | 16:20 |
TravT | have a set of common field mappings defined in that | 16:20 |
mfedosin | and as far as I understand SL will be able to filter only by these fields | 16:20 |
TravT | then for specific types | 16:20 |
TravT | use that base glass | 16:20 |
TravT | class | 16:20 |
TravT | and extend the mapping | 16:20 |
TravT | but make a specific resource type | 16:21 |
TravT | I don't know if it would be OS::Glare::Image | 16:21 |
TravT | get the base mapping | 16:21 |
mfedosin | it's like inheritance? | 16:21 |
TravT | not exactly... | 16:21 |
TravT | your python structure would be same as you do in python | 16:22 |
sjmc7 | yeah, that’d be my advice too; we wouldn’t index Glare::Artifact, onlythe concrete subtypes | 16:23 |
mfedosin | then we'll have to update our Base notification dict with Image attributes | 16:23 |
sjmc7 | so for now you could just index Artifacts | 16:23 |
sjmc7 | just to get something working | 16:23 |
sjmc7 | and then figure out how to add to the notifications | 16:24 |
TravT | so, here's an example plugin | 16:24 |
TravT | https://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/glance/images.py#L43 | 16:24 |
TravT | picture that you create one for OS::Glare:Artifact | 16:24 |
TravT | then if you have OS::Glare:Image | 16:24 |
TravT | have it start with the base classs you defined for OS::Glare::Artifact | 16:25 |
TravT | https://github.com/openstack/searchlight/blob/master/searchlight/elasticsearch/plugins/glance/images.py#L25 | 16:25 |
mfedosin | silly question... what is "not_analyzed"? | 16:25 |
sjmc7 | not_analyzed means a field doesn’t get tokenized | 16:25 |
TravT | there are some parent child things | 16:25 |
sjmc7 | normally a value “this is a string” would get tokenized into [“this”, “is”, “a”, “string”] | 16:26 |
TravT | but i don't think that is exactly what you are looking for | 16:26 |
GB21 | can we do it something like OS::Glare::Artifact::image | 16:26 |
GB21 | something like that | 16:26 |
sjmc7 | not_analyzed means it gets indexed as “this is a string” | 16:26 |
mfedosin | sjmc7: got it | 16:26 |
sjmc7 | we use it mainly for IDS | 16:26 |
TravT | The swift plugin does parent child..., but that is more like a 1...M relationship. | 16:26 |
TravT | in other words, a swift account contains containers which contains objects | 16:27 |
sjmc7 | so that “abc-1234-567def” is a single term, not broken up | 16:27 |
TravT | i really think you should start with defining a basic artifact type | 16:28 |
sjmc7 | yep. index an artifact type, hook it up to notifications | 16:28 |
sjmc7 | and then go from there | 16:28 |
mfedosin | looks like a plan then... we create OS::Glare::Artifact and try to use it, then we create OS::Glare:Image and all other things and disable search by OS::Glare::Artifact | 16:29 |
sjmc7 | yeah, that’d be my advice | 16:29 |
GB21 | that sounds good | 16:29 |
mfedosin | deal :) | 16:29 |
TravT | excellent! | 16:29 |
mfedosin | and also I have one tricky question | 16:29 |
mfedosin | I wonder if SL is able to cope with it | 16:30 |
sjmc7 | :) try us | 16:30 |
mfedosin | we have attribute "version" | 16:30 |
mfedosin | and it's a string | 16:30 |
mfedosin | but it's not typical string | 16:30 |
mfedosin | and we have to sort and filter by that | 16:30 |
sjmc7 | like semver or something? | 16:31 |
mfedosin | semver | 16:31 |
mfedosin | in glare we use pretty sophisticated things to make it work right | 16:31 |
TravT | sjmc7, i remember us talking about how to do that about 2 summits ago. | 16:31 |
sjmc7 | elasticsearch doesn’t have a semver field type. i’d recommend indexing it as an integer or string, with 0-padding | 16:32 |
sjmc7 | so you might index ‘1.15.3a’ as ‘001.015.003.a’ and mark it not analyzed | 16:32 |
sjmc7 | i think we can figure something out | 16:33 |
GB21 | why do we need to add 0 padding, if I may ask | 16:33 |
sjmc7 | because otherwise it’s hard to compare versions where you go from 9 -> 10 | 16:33 |
mfedosin | GB21: imagine you have version "10.0.0" and "2.0.0" | 16:33 |
sjmc7 | 1.9.0 is considered greater than 1.10.0 | 16:33 |
GB21 | okay | 16:34 |
GB21 | :) | 16:34 |
mfedosin | in glare we have special db representation for this type | 16:35 |
mfedosin | https://github.com/openstack/glare/blob/master/glare/common/semver_db.py | 16:35 |
mfedosin | it means that it converts semver into long integer | 16:36 |
sjmc7 | yeah, you could do the same thing in e-s | 16:36 |
mfedosin | sjmc7: that's what I suppose to try | 16:36 |
mfedosin | so, instead of version we will send this integer | 16:37 |
sjmc7 | yeah | 16:37 |
GB21 | so, I can convert it before dumping it into ed | 16:37 |
GB21 | es* | 16:37 |
GB21 | mfedosin, or I can convert it at my end, if u say | 16:37 |
sjmc7 | we currently don’t intercept search terms (though we could) | 16:38 |
sjmc7 | so it’d be easier to do it client side | 16:38 |
mfedosin | GB21: look: glare will send this integer to sl | 16:38 |
mfedosin | and it will be stored in lucene | 16:38 |
sjmc7 | that’d be best. we can index it as a sub-field of “version" | 16:38 |
TravT | mfedosin, ES lets you index any given field several ways. | 16:38 |
mfedosin | but after that we have to "unconvert" it to user friendly string again | 16:39 |
mfedosin | it means that we will have to put https://github.com/openstack/glare/blob/master/glare/common/semver_db.py in SL? | 16:39 |
mfedosin | sjmc7: are you guys okay with it? | 16:39 |
mfedosin | wouldn't it be too much? | 16:40 |
TravT | i have no qualms with it if it ends up being needed by your plugin | 16:40 |
sjmc7 | i would say for now it’s best if you send it | 16:40 |
sjmc7 | we can certainly add it if it makes sense | 16:40 |
mfedosin | oslo we can put it in oslo_utils | 16:41 |
mfedosin | if 3 projects use this code then oslo_utils is the best place for it | 16:41 |
sjmc7 | but for searches you’d need to send the integer version, because right now we don’t have a way to turn “version>1.10.0” into “version.int>15624242” | 16:41 |
TravT | +1 for that | 16:41 |
sjmc7 | yeah, oslo’d be a good place too | 16:42 |
TravT | if getting into oslo_utils is slow and it needs to be in both glare and SL temporarily, I can't complain either. | 16:42 |
sjmc7 | or even pbr | 16:42 |
mfedosin | let's put it in our plugin and then after some time (month or so) get rid of it and move it to oslo | 16:42 |
TravT | yes, the search side is the question to evaluate there. | 16:42 |
mfedosin | TravT: and currently in Glance :) | 16:43 |
TravT | haha | 16:43 |
TravT | all the more reason to get into oslo | 16:43 |
TravT | but i also will not block things over beaurocracy | 16:43 |
mfedosin | https://github.com/openstack/glance/blob/master/glance/common/semver_db.py <- it's Glance | 16:43 |
TravT | yeah, so we can iterate through that as needed | 16:44 |
mfedosin | okay, things are pretty clear to me now | 16:44 |
TravT | great. | 16:44 |
GB21 | perfect:) | 16:45 |
mfedosin | I don't think it would be a big deal | 16:45 |
TravT | I have to run to a meeting. Thanks guys! | 16:45 |
mfedosin | thanks so much for your help folks | 16:45 |
GB21 | Thanks TravT, sjmc7 and mfedosin | 16:45 |
GB21 | I am very excited to work on this plugin | 16:46 |
*** TravT has quit IRC | 16:46 | |
sjmc7 | thanks for taking the time. let us know if you have other questions, and have a good weekend | 16:46 |
GB21 | likewise sjmc7 | 16:46 |
*** GB21 has quit IRC | 17:15 | |
*** TravT has joined #openstack-searchlight | 17:18 | |
*** TravT has quit IRC | 17:19 | |
*** TravT has joined #openstack-searchlight | 17:59 | |
*** mfedosin has quit IRC | 18:18 | |
*** itisha has quit IRC | 18:21 | |
*** openstackgerrit has quit IRC | 19:18 | |
*** openstackgerrit has joined #openstack-searchlight | 19:19 | |
*** RickA-HP_ has joined #openstack-searchlight | 20:14 | |
*** RickA-HP has quit IRC | 20:18 | |
*** mfedosin has joined #openstack-searchlight | 21:02 | |
*** TravT_ has joined #openstack-searchlight | 21:17 | |
*** TravT has quit IRC | 21:19 | |
*** mfedosin has quit IRC | 21:38 | |
*** TravT_ has quit IRC | 21:52 | |
*** TravT has joined #openstack-searchlight | 21:53 | |
*** sjmc7 has quit IRC | 22:34 | |
*** TravT has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!