| TravT | which would explain the test failure | 00:00 |
|---|---|---|
| TravT | https://github.com/openstack/searchlight-ui/blob/master/searchlight_ui/karma.conf.js#L37 | 00:00 |
| TravT | i copied this from the lbaas plugin | 00:00 |
| TravT | so thought it would work... | 00:00 |
| * krotscheck sighs. | 00:01 | |
| TravT | (pictures krotscheck dreaming of a world where only npm and bower exist) | 00:01 |
| * krotscheck grumbles something about python and javascript not being good bedfellos. | 00:01 | |
| krotscheck | Oh, forget bower. I'm more or less done with them. | 00:02 |
| TravT | orly? i haven't been keeping up with the latest on that front. | 00:02 |
| TravT | oh, i think i see the problem... | 00:03 |
| krotscheck | I'm pretty certain that everyhting that bower provides can be provided via npm's dependencies. | 00:03 |
| krotscheck | It's just that bower exists, and therefore few people are willing to put their noggins to work. | 00:03 |
| krotscheck | Anyway.... | 00:04 |
| TravT | okay, i think i'll chase down this karma thing tomorrow. | 00:04 |
| TravT | i have to run for tonight | 00:04 |
| krotscheck | The one change I made wsa to modify the ../coverage-karma to ../cover. I'm also working on getting HTML test reports. | 00:04 |
| krotscheck | I'll get those two up and ready for ya. | 00:04 |
| TravT | i did put that ../coverage-karma in the patch above. | 00:05 |
| TravT | https://review.openstack.org/#/c/298440/4/searchlight_ui/karma.conf.js | 00:05 |
| TravT | is that what you think it should be? | 00:05 |
| krotscheck | Yep | 00:06 |
| TravT | if there is more, then please feel free to amend that patch | 00:06 |
| krotscheck | Huhn, this plugin assumes it's running in a directory adjacent to the horizon directory. | 00:06 |
| TravT | yeah | 00:06 |
| krotscheck | That's all kind of gate fail. | 00:06 |
| TravT | that's what I was seeing as the problem | 00:06 |
| TravT | but i can't for the life of me understand why this config works on the lbaas dashboard | 00:07 |
| krotscheck | I'll amend the patch, see if removing it blows everything up. | 00:07 |
| TravT | https://github.com/openstack/neutron-lbaas-dashboard/blob/master/neutron_lbaas_dashboard/karma.conf.js#L25 | 00:07 |
| TravT | ok, cool. today is my wife's birthday and i need to head out for the moment. | 00:07 |
| TravT | thanks for helping out! | 00:08 |
| krotscheck | Yeah, that's puzzling | 00:09 |
| krotscheck | I'll keep yammering on here in the channel | 00:09 |
| krotscheck | Urmm....http://logs.openstack.org/15/296615/1/check/gate-neutron-lbaas-dashboard-npm-run-test/724279b/console.html.gz#_2016-03-23_18_20_04_404 | 00:14 |
| krotscheck | It doesn't actually work for them. | 00:14 |
| TravT | oh geez, you are right. they have it set up as a non-voting job | 00:18 |
| krotscheck | No worries, I think I know what to do. | 00:30 |
| krotscheck | Sooooocloooose | 00:31 |
| openstackgerrit | Michael Krotscheck proposed openstack/searchlight-ui: Fix Zuul errors. https://review.openstack.org/298440 | 00:37 |
| krotscheck | Ok, so ^^ makes the tests pass, but I had to do a few things I don't recommend actually doing. | 00:38 |
| *** yingjun has joined #openstack-searchlight | 00:39 | |
| krotscheck | And of course, it times out on clone. | 00:46 |
| krotscheck | Oh, nevermind. | 00:46 |
| * krotscheck was impatient | 00:46 | |
| *** yingjun has quit IRC | 00:56 | |
| krotscheck | 2016-03-29 00:59:12.431 | Finished: SUCCESS | 00:59 |
| krotscheck | All green! | 01:00 |
| *** yingjun has joined #openstack-searchlight | 01:10 | |
| *** lakshmiS_ has quit IRC | 01:19 | |
| openstackgerrit | Michael Krotscheck proposed openstack/searchlight-ui: Fix Zuul errors. https://review.openstack.org/298440 | 01:20 |
| krotscheck | ok, lets try that | 01:20 |
| krotscheck | We just had a build timeout during bindep. | 03:08 |
| krotscheck | http://logs.openstack.org/40/298440/6/check/gate-searchlight-ui-npm-run-test/40d2bd0/console.html | 03:08 |
| krotscheck | It _might_ be the mirror? | 03:08 |
| *** bpokorny has joined #openstack-searchlight | 03:29 | |
| krotscheck | Ok, so I guess removing the xstatic test was still necessary. | 03:32 |
| * krotscheck sighs | 03:32 | |
| krotscheck | It probably needs to have its logic adjusted somehow. | 03:33 |
| *** bpokorny has quit IRC | 04:45 | |
| *** pcaruana has quit IRC | 05:09 | |
| *** GB21 has joined #openstack-searchlight | 05:39 | |
| *** GB21 has quit IRC | 07:05 | |
| openstackgerrit | Li Yingjun proposed openstack/searchlight: Use delete_index instead of alias_listener_update https://review.openstack.org/298570 | 07:12 |
| *** GB21 has joined #openstack-searchlight | 07:17 | |
| *** pcaruana has joined #openstack-searchlight | 07:48 | |
| *** TravT has quit IRC | 08:23 | |
| *** TravT has joined #openstack-searchlight | 08:24 | |
| *** GB21 has quit IRC | 08:54 | |
| *** yingjun has quit IRC | 09:32 | |
| *** yingjun has joined #openstack-searchlight | 11:27 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:57 | |
| *** yingjun has quit IRC | 14:06 | |
| *** yingjun has joined #openstack-searchlight | 14:06 | |
| *** yingjun has quit IRC | 14:11 | |
| *** GB21 has joined #openstack-searchlight | 14:50 | |
| *** openstackgerrit has quit IRC | 15:06 | |
| *** openstackgerrit has joined #openstack-searchlight | 15:07 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Improve install instructions https://review.openstack.org/298433 | 15:11 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Add missing zero-downtime indexing documentation https://review.openstack.org/298315 | 15:14 |
| openstackgerrit | Merged openstack/searchlight: Add missing mitaka release notes https://review.openstack.org/297267 | 15:24 |
| sjmc7 | how dare you touch my red! | 15:26 |
| TravT | it deserved it | 15:26 |
| sjmc7 | i need to put my editor in the corner to think about what it’s done | 15:26 |
| TravT | yes, shaming is always the best choice | 15:27 |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Disable oslo_config file discovery in tests https://review.openstack.org/298830 | 15:37 |
| TravT | sjmc7 yingjun (not on). thierry wants us to push a 0.3 for python-searchlightclient so they can create a stable mitaka branch | 15:39 |
| sjmc7 | ok. did we have any changes to make? | 15:39 |
| sjmc7 | i can’t think of any | 15:40 |
| TravT | there's one open bug out there potentially worth considering fixing, but i don't have time to look at it further at the moment. | 15:40 |
| TravT | https://bugs.launchpad.net/python-searchlightclient | 15:40 |
| sjmc7 | i can look at it, but i guess they want to do the branch asap? | 15:41 |
| TravT | if that is an easy fix (today) probably would be find | 15:41 |
| TravT | find | 15:41 |
| TravT | fine | 15:41 |
| TravT | bleh | 15:41 |
| sjmc7 | hahaha | 15:43 |
| sjmc7 | ok, will take a quick look | 15:43 |
| sjmc7 | at my old job a guy who hated the entire idea of non-ascii characters would occasionally scream ‘UNICODE’, indicating he had encountered an encoding issue | 15:44 |
| TravT | i'm now trying to see the magic krotscheck was working on late last night for searchlight-ui | 15:45 |
| TravT | also need to get that tagged for mitaka | 15:45 |
| *** lakshmiS has joined #openstack-searchlight | 15:53 | |
| krotscheck | TravT: the xstatic test is the only stickler,but you can see where my thoughts were. | 15:55 |
| TravT | yeah, i do see that. | 15:55 |
| krotscheck | I've got a meeting in 5, can help after. | 15:55 |
| TravT | actually adding what you did now made it so that i can set my pycharms interpretter to the .tox env and the horizon libs show up properly now | 15:55 |
| krotscheck | Ah, neat. | 15:56 |
| krotscheck | Wins all around! | 15:56 |
| TravT | i tried commenting out that path check and it doesn't help the karma though... | 15:56 |
| TravT | i'll try tinkering with that a bit | 15:56 |
| openstackgerrit | Rick Aulino proposed openstack/searchlight: Re-indexing optimization for doc_type https://review.openstack.org/295538 | 16:09 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Fix searchlight-ui Zuul errors. https://review.openstack.org/298440 | 16:29 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Fix searchlight-ui Zuul errors. https://review.openstack.org/298440 | 16:44 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Improve install instructions https://review.openstack.org/298433 | 16:44 |
| TravT | krotscheck: got it working! just a minor path change on top of your changes last night | 16:45 |
| *** robcresswell is now known as grand-poobah-of- | 16:47 | |
| *** grand-poobah-of- is now known as robcresswell | 16:47 | |
| *** pcaruana has quit IRC | 16:48 | |
| sjmc7 | TravT: added a note to the sl client bug https://bugs.launchpad.net/python-searchlightclient/+bug/1558757 - TL;DR is check your terminal LANG setting | 16:48 |
| openstack | Launchpad bug 1558757 in python-searchlightclient "search query * -> 'ascii' codec can't encode character u'\xae' in position 3739: ordinal not in range(128)" [Undecided,New] | 16:48 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Fix searchlight-ui Zuul errors. https://review.openstack.org/298440 | 16:59 |
| *** briancline has quit IRC | 17:07 | |
| *** sigmavirus24 has quit IRC | 17:07 | |
| *** _sigmavirus24 has joined #openstack-searchlight | 17:07 | |
| *** briancli1e has joined #openstack-searchlight | 17:07 | |
| *** _sigmavirus24 is now known as sigmavirus24 | 17:14 | |
| *** sigmavirus24 has joined #openstack-searchlight | 17:14 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Fix searchlight-ui Zuul errors. https://review.openstack.org/298440 | 17:27 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Fix searchlight-ui Zuul errors. https://review.openstack.org/298440 | 17:36 |
| TravT | sjmc7: just added a comment on that bug | 17:43 |
| sjmc7 | haha | 17:46 |
| sjmc7 | that’s fun! | 17:46 |
| sjmc7 | it does in fact unset LANG | 17:47 |
| sjmc7 | in stackrc | 17:47 |
| TravT | well, yay for that | 17:47 |
| sjmc7 | :) | 17:47 |
| sjmc7 | does the bug go away if you set LANG? | 17:47 |
| sjmc7 | if so, i’ll close it | 17:48 |
| TravT | so, then i knew you'd ask that next... | 17:48 |
| TravT | i have to reset my keystone endpoints to actually test | 17:48 |
| TravT | gimme a second. | 17:49 |
| sjmc7 | k | 17:49 |
| sjmc7 | also be interesting to see if nova client chokes on the same issue | 17:49 |
| sjmc7 | hmm, doesn’t look like it. so maybe sl-client should be explicitly encoding | 17:50 |
| sjmc7 | i’ll take a quick look, need to eat first | 17:50 |
| TravT | ok | 17:50 |
| TravT | i think i'm done with the zuul errors patch on sl ui | 17:50 |
| TravT | just waiting for gate to pass | 17:50 |
| TravT | but if so, i really need to get that in today | 17:50 |
| *** bpokorny has joined #openstack-searchlight | 17:52 | |
| sjmc7 | splendid | 17:52 |
| *** bpokorny has quit IRC | 17:52 | |
| *** bpokorny has joined #openstack-searchlight | 17:53 | |
| sjmc7 | TravT: looks like it’s an openstackclient bug | 17:54 |
| sjmc7 | or ‘condition’, i guess | 17:54 |
| sjmc7 | now i really am getting food | 17:57 |
| TravT | okay, just tested and I actually am not seeing that now | 17:57 |
| TravT | even with $LANG not set | 17:58 |
| TravT | maybe it got fixed elsewhere? | 17:58 |
| sjmc7 | check LC_ALL, too | 17:58 |
| sjmc7 | devstack seems to set LC_ALL=C | 17:58 |
| sjmc7 | which will break it | 17:58 |
| TravT | ttripp@ubuntu:~$ echo $LANG | 17:58 |
| TravT | ttripp@ubuntu:~$ echo $LC_ALL | 17:58 |
| TravT | C | 17:58 |
| TravT | ttripp@ubuntu:~$ | 17:58 |
| sjmc7 | you’re sure it’s trying to print non-ascii results? | 17:59 |
| TravT | no... let me add the copyright symbol | 17:59 |
| sjmc7 | cos i can reliably reproduce it by setting LC_ALL=C | 17:59 |
| TravT | (switching which listeners I have running) | 18:01 |
| TravT | and increasing limit | 18:02 |
| *** pcaruana has joined #openstack-searchlight | 18:02 | |
| TravT | there it is | 18:02 |
| TravT | so, sjmc7 are you proposing we close this as a SL bug then? | 18:03 |
| TravT | and call it an opentackclient bug? | 18:03 |
| sjmc7 | yes | 18:03 |
| sjmc7 | it’s not really an openstackclient bug, either | 18:03 |
| sjmc7 | but it’s certainly not a SL one | 18:04 |
| TravT | they could catch it and give a nicer error message with guidance at least. | 18:04 |
| sjmc7 | yeah, true | 18:04 |
| sjmc7 | i’ll file one later | 18:04 |
| sjmc7 | gonna close this bug | 18:04 |
| TravT | okay, then i'm going to go ahead and put up a patch for releasing 0.3.0 python-searchlightclient | 18:04 |
| sjmc7 | yay | 18:04 |
| sjmc7 | ok, i really AM going to eat now | 18:05 |
| TravT | go eat! | 18:05 |
| lakshmiS | designate plugin doesnt listen for server create/delete events. was there a reason for it or just left out | 18:05 |
| sjmc7 | ? | 18:06 |
| lakshmiS | when you create/delete server's in designate it sends a dns.pool.update event | 18:06 |
| lakshmiS | designate server-create --name ns2.foo.com. | 18:07 |
| sjmc7 | umm.. i don’t know | 18:07 |
| sjmc7 | i’ve not used the command before :( | 18:08 |
| lakshmiS | i will create a bug | 18:08 |
| sjmc7 | could ask endre or graham but they’re both out for the day | 18:08 |
| TravT | maybe ekarlso- would know | 18:08 |
| sjmc7 | i really really AM getting some food now | 18:08 |
| lakshmiS | i will put another comment and you will be back :) | 18:09 |
| ekarlso- | what ? :P | 18:13 |
| ekarlso- | im on vacation actually :o | 18:13 |
| lakshmiS | ekarlso-: do you know if we need to index data from dns.pool.update events? | 18:16 |
| ekarlso- | lakshmiS: unsure atm, try hitting the guys up in the designate chat :) | 18:17 |
| lakshmiS | no problem. will checkout there... | 18:17 |
| openstackgerrit | GB21 proposed openstack/searchlight: Adds Nova Functional Tests https://review.openstack.org/289837 | 18:18 |
| mugsie | sjmc7: you called? | 18:23 |
| mugsie | oh, yeah. do we listen for any pool events currently? I didnt think we did | 18:26 |
| mugsie | yeap, searchlight only listens for zones/domain + recordsets events | 18:28 |
| lakshmiS | mugsie: we currently dont index nameservers. i think it good to index and update it on notifications | 18:34 |
| mugsie | yeah. we should index the whole pool object and its updates if possible in my opinion | 18:35 |
| lakshmiS | yes | 18:35 |
| mugsie | especially with mitaka actually allowing multiple pools | 18:35 |
| *** GB21 has quit IRC | 18:35 | |
| lakshmiS | the only issue i see is that it sends information for all nameservers in notification instead of the nameserver being created. i guess there can only be a handfull of nameservers | 18:39 |
| mugsie | yeah, 99% will have less then 3, and only a few people will ever have more than 6 | 18:45 |
| *** david-lyle has quit IRC | 18:45 | |
| *** david-lyle has joined #openstack-searchlight | 18:46 | |
| lakshmiS | that makes sense | 18:48 |
| sjmc7 | TravT: I’m happy to give my blessing to the ui patch https://review.openstack.org/#/c/298440/ although i’ll take your word that it fixes the issues i’ll also take your word about :) | 18:55 |
| TravT | well, it does turn 4 out of 5 tests from red to green. :) | 18:55 |
| TravT | (the other one was already green) | 18:55 |
| sjmc7 | looks like mostly linting | 18:55 |
| TravT | yes | 18:56 |
| TravT | and then actually making horizon javascript available to karma for JS testing | 18:56 |
| TravT | i went through the whole zuul layout | 18:56 |
| sjmc7 | https://review.openstack.org/#/c/298440/11/searchlight_ui/static/dashboard/project/search/filters/keystone-project-name.filter.js line 33 comment looks funky | 18:56 |
| TravT | turns out we are the first angular plugin to horizon to actually run tests. | 18:56 |
| sjmc7 | but it all looks fine | 18:56 |
| sjmc7 | ha, yeah :) | 18:56 |
| sjmc7 | though someone else was asking about it the other day | 18:57 |
| sjmc7 | or maybe it was you | 18:57 |
| TravT | i'll probably go put up a fix to neutron lbaas plugin to get their karma to run now. | 18:57 |
| sjmc7 | ok. this looks fine; i’m guessing you don’t want minor comment nits at this stage | 18:58 |
| TravT | you can leave them and i can maybe fix later on. | 18:59 |
| TravT | we're just crunched for mitaka | 18:59 |
| TravT | there are a couple actual bugs i want to work on. | 18:59 |
| sjmc7 | ok. once gerrit stops misbehaving will +2 | 18:59 |
| TravT | ok, i'm gonna step away for lunch | 19:00 |
| *** krotscheck is now known as krotscheck_dcm | 19:07 | |
| openstackgerrit | Steve McLellan proposed openstack/searchlight: Fix _is_multiple_alias_exception signature https://review.openstack.org/298947 | 19:28 |
| sjmc7 | lakshmiS: TravT: need review on https://review.openstack.org/298947 please | 19:29 |
| TravT | sjmc7, looking... but looking at the optimization patch first. | 19:38 |
| sjmc7 | sure, long as it gets into rc2 | 19:39 |
| lakshmiS | sjmc7: middle of some testing. will do it today | 19:52 |
| openstackgerrit | Merged openstack/searchlight: Re-indexing optimization for doc_type https://review.openstack.org/295538 | 20:18 |
| openstackgerrit | Merged openstack/searchlight-ui: Fix searchlight-ui Zuul errors. https://review.openstack.org/298440 | 20:22 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Improve install instructions https://review.openstack.org/298433 | 20:23 |
| openstackgerrit | Travis Tripp proposed openstack/searchlight-ui: Removing oslo-incubator config file https://review.openstack.org/298468 | 20:23 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 20:37 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 20:37 | |
| openstackgerrit | Travis Tripp proposed openstack/searchlight: Add Link to client and ui https://review.openstack.org/298972 | 20:39 |
| openstackgerrit | Merged openstack/searchlight-ui: Removing oslo-incubator config file https://review.openstack.org/298468 | 21:07 |
| TravT | lakshmiS: Awesome job getting the functional tests into zuul! | 21:17 |
| TravT | https://review.openstack.org/#/c/294224 | 21:17 |
| lakshmiS | thats half the patch though. but good that its working | 21:17 |
| lakshmiS | have another patch https://review.openstack.org/#/c/298360/ which changes experimental to real | 21:18 |
| sjmc7 | nice. and you got infra onboard with it? | 21:18 |
| lakshmiS | yes | 21:18 |
| TravT | well, they'll run each time as experimental right? | 21:19 |
| sjmc7 | it’s a shame it needs a seperate job definition. zuul macros are a pain | 21:19 |
| lakshmiS | only if you add "check experimental" in the comment | 21:20 |
| TravT | ahh | 21:20 |
| TravT | that's pretty tricky | 21:20 |
| lakshmiS | yeah, not much in documentation | 21:20 |
| TravT | i guess until infra approves we may as well add that to all our commits | 21:20 |
| lakshmiS | not sure if it reads in the commit message(worth trying). I added as a review comment | 21:21 |
| sjmc7 | lakshmiS: what’s zuul-swift-test-results-with-console ? | 21:21 |
| lakshmiS | infra asked me to copy py27 job and just change stuff for elasticsearch. so not sure | 21:22 |
| lakshmiS | https://review.openstack.org/#/c/298339/ has the experimental run | 21:24 |
| TravT | yeah, i saw that... just added those comments to one Steve's patches as well | 21:27 |
| *** lakshmiS has quit IRC | 21:33 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 21:47 | |
| openstackgerrit | Merged openstack/searchlight-ui: Improve install instructions https://review.openstack.org/298433 | 22:02 |
| sjmc7 | gotta go, will check in later | 22:33 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!