| *** sigmavirus24 is now known as sigmavirus24_awa | 00:14 | |
| *** sjmc7 has joined #openstack-searchlight | 01:27 | |
| *** sjmc7 has quit IRC | 02:07 | |
| *** lakshmiS has joined #openstack-searchlight | 04:31 | |
| *** lakshmiS has quit IRC | 05:25 | |
| *** nikhil_k has quit IRC | 10:18 | |
| *** nikhil_k has joined #openstack-searchlight | 10:18 | |
| *** openstackgerrit has quit IRC | 10:45 | |
| *** openstackgerrit has joined #openstack-searchlight | 10:49 | |
| *** TravT has quit IRC | 10:57 | |
| *** TravT has joined #openstack-searchlight | 11:05 | |
| *** pkarikh has joined #openstack-searchlight | 11:09 | |
| *** lakshmiS has joined #openstack-searchlight | 12:27 | |
| *** lakshmiS has quit IRC | 12:35 | |
| *** lakshmiS has joined #openstack-searchlight | 13:11 | |
| *** lakshmiS has quit IRC | 13:41 | |
| *** sjmc7 has joined #openstack-searchlight | 13:55 | |
| sjmc7 | TravT - looking at your comments on the resource type instead of index/doctype review | 14:25 |
|---|---|---|
| sjmc7 | the main sticking point is that searching by index/doctype is more transparent to elasticsearch, which yes, that is true. perhaps rather than fully abstracting it, we beef up the discovery mechanism | 14:26 |
| sjmc7 | such that 'enabled_plugins' returns OS::Glance::Image: (glance, image) etc, and then allow any combination (index name, doc type, resource name) | 14:27 |
| sjmc7 | that way you can essentially hardcode something if you want to look for OS::Glance::Image, but you have the ability to do passthrough queries as long as you check the index types | 14:28 |
| sjmc7 | i'll reply in the review, now i've thought out loud :) | 14:29 |
| openstackgerrit | Merged openstack/searchlight: Fix issue with multiple notification listeners https://review.openstack.org/202392 | 15:10 |
| TravT | hey sjmc7 | 15:13 |
| TravT | i think you might be saying... 1) query for plugins. 2) plugin list has OS::Glance::Image and it still shows index and type 3) the client uses the index and type in query. | 15:15 |
| sjmc7 | client can use EITHER | 15:29 |
| *** tsufiev has quit IRC | 18:22 | |
| *** tsufiev has joined #openstack-searchlight | 18:22 | |
| *** nikhil_k has quit IRC | 22:19 | |
| *** nikhil_k has joined #openstack-searchlight | 22:20 | |
| sjmc7 | TravT something that also just occurred - we don't really need to allow customizable *types*, just *indices* | 22:25 |
| sjmc7 | so we could do 'type': 'OS::Glance::Image' | 22:25 |
| sjmc7 | it's a bit unpleasant using that as a url is the only downside | 22:26 |
| TravT | sjmc7: i pondered that a little as well... | 22:27 |
| TravT | but it also occurred to me that leaving type customizable might be good for future version usage? | 22:28 |
| TravT | of even now. | 22:28 |
| sjmc7 | maybe. i can't see why you'd do it | 22:28 |
| sjmc7 | now i think about it | 22:28 |
| TravT | so glance/v2 | 22:28 |
| TravT | glance-v2 | 22:28 |
| TravT | but that is a half baked thought | 22:28 |
| sjmc7 | i don't think i'd index glance v1 and glance v2 | 22:29 |
| sjmc7 | that seems odd | 22:29 |
| TravT | a long time ago, people didn't think they needed 4 digits for the year | 22:29 |
| sjmc7 | and even then, customizable doc types doesn't help | 22:29 |
| TravT | so just index would be diff... | 22:29 |
| sjmc7 | well.. i guess maybe it would. ok. well, to get a resource_Type field in, it has to go in the source doc | 22:29 |
| TravT | unless we only make the resource type a lookup to find the index and doc type | 22:30 |
| sjmc7 | oh weird, you don't have to escape colons in urls | 22:31 |
| TravT | that that's not so bad | 22:31 |
| TravT | so then maybe we just do type | 22:32 |
| TravT | i mean index | 22:32 |
| sjmc7 | yeah, i'm leaning that way | 22:32 |
| sjmc7 | it means that the enabled_plugins becomes a dict type : index | 22:32 |
| sjmc7 | and it guarantees types are unique | 22:33 |
| TravT | i'd lean towards | 22:33 |
| sjmc7 | which has some advantages (like you can put everything on the same index if you want) | 22:33 |
| TravT | OS::Glance::Image : { 'index' : 'glance' } | 22:33 |
| TravT | leave room for other info. | 22:33 |
| sjmc7 | just in case? | 22:33 |
| sjmc7 | ok | 22:33 |
| TravT | like search syntax | 22:34 |
| sjmc7 | ok, i'll cobble that up and see how it looks | 22:34 |
| TravT | in the unlikely event that we support more than ES in the future | 22:34 |
| sjmc7 | i think i like this more | 22:34 |
| sjmc7 | yeah | 22:34 |
| TravT | seems like a more natural mapping i suppose.... i also was rather hesitant about having to stuff that into the source fields | 22:34 |
| sjmc7 | yeah, it's not good to do that | 22:35 |
| *** sjmc7_ has joined #openstack-searchlight | 22:37 | |
| *** sjmc7 has quit IRC | 22:49 | |
| *** sjmc7_ has quit IRC | 23:23 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!