| opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: WIP: Add support for default volume types https://review.opendev.org/c/openstack/openstacksdk/+/920464 | 07:03 |
|---|---|---|
| opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: WIP: Add support for default volume type commands https://review.opendev.org/c/openstack/python-openstackclient/+/920465 | 07:04 |
| dtantsur | I wonder what the chances are that https://opendev.org/openstack/openstacksdk/commit/2b4aeff6d3972761da9c4a6a8b696103664a758b causes memory leaks in the code that worked before | 10:48 |
| frickler | dtantsur: do you actually see some memory leak or is this just a theoretical question? | 10:57 |
| dtantsur | frickler: I do see ironic-inspector leaking memory. Taking periodical snapshows from Python's tracealloc led me here: https://paste.opendev.org/show/b9HRCbkxqtPrZ3yU0TCH/ | 10:58 |
| dtantsur | but after looking at lines, I'm not longer sure it's related to __del__ | 10:58 |
| dtantsur | I'm now wondering if we somehow make CONF grow infinitely | 10:59 |
| dtantsur | At the very least, it looks like we're modifying global defaults.. | 11:01 |
| dtantsur | mmm, or not really, it has copy() everywhere | 11:01 |
| * dtantsur is puzzled | 11:01 | |
| frickler | dtantsur: which version are you using? there was a leak fixed a short time later https://review.opendev.org/c/openstack/openstacksdk/+/890781 | 11:09 |
| dtantsur | frickler: it's possible that I don't have the newest version, let me check | 11:10 |
| dtantsur | alas, I have this change already | 11:10 |
| opendevreview | Jens Harbott proposed openstack/openstackclient master: zuul: Drop retired repos from required-projects https://review.opendev.org/c/openstack/openstackclient/+/920512 | 12:45 |
| opendevreview | Dmitry Tantsur proposed openstack/openstacksdk master: Do not create a class in runtime on a potentially hot path https://review.opendev.org/c/openstack/openstacksdk/+/920541 | 13:26 |
| dtantsur | Okay, this is the first, unfortunately by far the smallest, part of the puzzle ^^ | 13:26 |
| dtantsur | frickler, so, is now calling close() on a Connection mandatory? I don't think it was always the case. | 14:01 |
| dtantsur | Honestly, using atexit smells badly. Are you sure you guys considered long-running users of openstacksdk? | 14:04 |
| frickler | dtantsur: I've so far successfully avoided to dig into performance relevant details of python implementations, will defer to gtema and stephenfin | 14:10 |
| gtema | dtantsur - token caching currently relies on calling close | 14:10 |
| dtantsur | gtema: it's off by default though? | 14:11 |
| dtantsur | I mean, the caching? | 14:11 |
| gtema | well, yes - it is config option | 14:11 |
| gtema | and off by default | 14:11 |
| dtantsur | At the very least, you need a very, VERY ugly warning in the release notes | 14:11 |
| dtantsur | I don't think we're the only people who don't call close() | 14:11 |
| gtema | currently the cli does so (since that is the main user of caching) | 14:12 |
| dtantsur | gtema: related question: are Connections long lived and (green) thread safe? Can I just cache one for the lifetime of ironic-inspector? | 14:13 |
| gtema | what is this lifetime? I have certain usecases with connections living multiple months | 14:13 |
| dtantsur | gtema: it's an OpenStack service. Weeks, months, in a very unlikely case years :) | 14:14 |
| gtema | should be thread safe | 14:14 |
| dtantsur | in any case, it's a pity that the change went in without a release note (or am I not looking carefully enough?) | 14:15 |
| gtema | this is there since years | 14:16 |
| dtantsur | last year, to be precise | 14:16 |
| gtema | ok, could be, time is relative | 14:17 |
| gtema | :) | 14:17 |
| dtantsur | gtema: also for your attention: https://review.opendev.org/c/openstack/openstacksdk/+/920541 | 14:19 |
| gtema | ack | 14:19 |
| opendevreview | Merged openstack/openstackclient master: zuul: Drop retired repos from required-projects https://review.opendev.org/c/openstack/openstackclient/+/920512 | 14:36 |
| opendevreview | Merged openstack/openstackclient master: Remove clients of retired projects https://review.opendev.org/c/openstack/openstackclient/+/919857 | 21:00 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!