| opendevreview | SongSuheon proposed openstack/openstacksdk master: Implement heat 'stack resource signal' https://review.opendev.org/c/openstack/openstacksdk/+/894203 | 00:49 |
|---|---|---|
| opendevreview | SongSuheon proposed openstack/openstacksdk master: Implement heat 'stack resource signal' https://review.opendev.org/c/openstack/openstacksdk/+/894203 | 05:04 |
| stephenfin | M0weng[m]: Okay, I see the metering label issue also. Do you want to try fix that one yourself? | 09:44 |
| stephenfin | M0weng[m]: The issue is that there's a missing extension for the networking service related to metering or labelling a meter. You can use my previous patch as a basis for how to address that scenario https://review.opendev.org/c/openstack/python-openstackclient/+/900607 | 09:45 |
| stephenfin | M0weng[m]: Some more hints. Unlike most other services, neutron stores its API definitions in another project, neutron-lib. You can find the source for that here https://github.com/openstack/neutron-lib Have a look through there and see if you can find the *alias" of the extension you're looking for | 09:46 |
| stephenfin | M0weng[m]: (Extensions have names and aliases - the aliases should be a slug, or lowercase string of ASCII characters and dashes, and are what we search for rather than the name. For example, 'standard-attr-segment' is the alias of the "Standard Attribute Segment Extension" extension | 09:48 |
| stephenfin | Once you find the alias, look at my previous patch again for how to skip tests if an extension is missing | 09:49 |
| stephenfin | M0weng[m]: I think I said this previously, but the reason you're seeing this is because we configure DevStack in a specific manner in our CI jobs. You could of course redeploy DevStack to match one of those configurations, but this is a nice gap in our testing that you've found which we should fix. | 09:50 |
| stephenfin | M0weng[m]: Last point. I also see the other failures, so we obviously need to add more extension checks than just the metering label one. The technique will be the same for all. You can do it all in one patch or separately, whatever is easier | 09:52 |
| stephenfin | M0weng[m]: With one exception: openstackclient.tests.functional.network.v2.test_network.NetworkTests.test_network_dhcp_agent is skipped for me with "SKIPPED: No dhcp_agent_scheduler extension present". We might debug that one together later today | 09:54 |
| stephenfin | M0weng[m]: Wait, never mind, I figured it out. My DevStack is an older deployment. I'm likely missing this change https://review.opendev.org/c/openstack/neutron/+/897528 I will talk to the neutron folks about it | 09:57 |
| *** ykarel|away is now known as ykarel | 10:06 | |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Blacken code https://review.opendev.org/c/openstack/osc-lib/+/893263 | 10:06 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: pre-commit: Integrate black https://review.opendev.org/c/openstack/osc-lib/+/893264 | 10:06 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Ignore black changes https://review.opendev.org/c/openstack/osc-lib/+/893265 | 10:06 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: tox: Use pre-commit for style checks https://review.opendev.org/c/openstack/osc-lib/+/893266 | 10:06 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: Remove lower-constraints.txt https://review.opendev.org/c/openstack/osc-lib/+/893267 | 10:06 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Address bug in shelve offload logic https://review.opendev.org/c/openstack/python-openstackclient/+/901019 | 11:33 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Use CommandError, not SystemExit, to exit https://review.opendev.org/c/openstack/python-openstackclient/+/901020 | 11:33 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove unnecessary file https://review.opendev.org/c/openstack/python-openstackclient/+/901021 | 11:33 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: parseactions: Use ArgumentError, not ArgumentTypeError https://review.opendev.org/c/openstack/python-openstackclient/+/901022 | 11:33 |
| opendevreview | Stephen Finucane proposed openstack/osc-lib master: parseactions: Use ArgumentError, not ArgumentTypeError https://review.opendev.org/c/openstack/osc-lib/+/836204 | 11:34 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: test: Ignore 'OS_' environment variables https://review.opendev.org/c/openstack/python-openstackclient/+/900918 | 11:41 |
| opendevreview | Merged openstack/osc-lib master: Blacken code https://review.opendev.org/c/openstack/osc-lib/+/893263 | 11:54 |
| opendevreview | Merged openstack/osc-lib master: pre-commit: Integrate black https://review.opendev.org/c/openstack/osc-lib/+/893264 | 12:29 |
| opendevreview | Merged openstack/osc-lib master: Ignore black changes https://review.opendev.org/c/openstack/osc-lib/+/893265 | 12:30 |
| opendevreview | Merged openstack/osc-lib master: tox: Use pre-commit for style checks https://review.opendev.org/c/openstack/osc-lib/+/893266 | 12:30 |
| opendevreview | Merged openstack/osc-lib master: Remove lower-constraints.txt https://review.opendev.org/c/openstack/osc-lib/+/893267 | 12:30 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Check for DHCP agents first in DHCP test https://review.opendev.org/c/openstack/python-openstackclient/+/901054 | 17:01 |
| diablo_rojo | stephenfin: gtema coming to the meeting? | 17:03 |
| stephenfin | yup, zoom is being a pain | 17:03 |
| diablo_rojo | stephenfin: its totally one of those days | 17:04 |
| gtema | yupp, sorry | 17:04 |
| stephenfin | gtema: You haven't pushed the updates to any of that fake generator stuff yet, I assume? | 17:24 |
| stephenfin | I've seen the previous stuff but nothing new recently | 17:24 |
| gtema | nope | 17:24 |
| gtema | I am working hard on getting openapi generated from sources and it 1) pulls lot of energy 2) requires small changes into the generators which I group for later | 17:25 |
| stephenfin | ack okay, I'll wait and watch in that case | 17:25 |
| *** JasonF is now known as JayF | 18:47 | |
| M0weng[m] | Is it possible to use is_extension_enabled() from a classmethod rather than with self? (Trying to skip the meter_rule test if the metering extension isn't enabled.) | 19:46 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!