| opendevreview | Mridula Joshi proposed openstack/openstacksdk master: Adding support for image upload https://review.opendev.org/c/openstack/openstacksdk/+/881939 | 08:07 |
|---|---|---|
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: [DNM] Experiment with OpenAPI schema https://review.opendev.org/c/openstack/openstacksdk/+/892161 | 08:28 |
| opendevreview | suzhengwei proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | 10:04 |
| opendevreview | Merged openstack/openstacksdk master: cloud: Remove dead code https://review.opendev.org/c/openstack/openstacksdk/+/892770 | 10:22 |
| opendevreview | Merged openstack/openstacksdk master: Encode type of 'links' for Extension objects https://review.opendev.org/c/openstack/openstacksdk/+/885133 | 10:55 |
| opendevreview | Merged openstack/openstacksdk master: volume: Add Extension to volume v2 API https://review.opendev.org/c/openstack/openstacksdk/+/885134 | 11:03 |
| opendevreview | Merged openstack/ansible-collections-openstack master: Image filters should be dict not set https://review.opendev.org/c/openstack/ansible-collections-openstack/+/889388 | 11:04 |
| opendevreview | Merged openstack/openstacksdk master: block storage: Add support for services https://review.opendev.org/c/openstack/openstacksdk/+/889886 | 11:08 |
| opendevreview | Merged openstack/openstacksdk master: tests: Migrate tests from os-hosts to os-services https://review.opendev.org/c/openstack/openstacksdk/+/889887 | 11:27 |
| opendevreview | Merged openstack/openstacksdk master: tests: Move cloud-layer service tests to their own file https://review.opendev.org/c/openstack/openstacksdk/+/891217 | 12:12 |
| opendevreview | Baek Seung Ju proposed openstack/openstacksdk master: Implemented heat 'stack suspend' and 'stack resume' function https://review.opendev.org/c/openstack/openstacksdk/+/892156 | 12:21 |
| opendevreview | YeJun, Jung proposed openstack/openstacksdk master: Add support for other metadef property operations https://review.opendev.org/c/openstack/openstacksdk/+/857727 | 12:38 |
| opendevreview | YeJun, Jung proposed openstack/openstacksdk master: Add support for other metadef property operations https://review.opendev.org/c/openstack/openstacksdk/+/857727 | 12:43 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Migrate 'availability zone list' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/885135 | 12:52 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Migrate 'extension list' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/885139 | 12:52 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Remove project purge image commands https://review.opendev.org/c/openstack/python-openstackclient/+/885528 | 12:52 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Remove FakeNetworkV2Client https://review.opendev.org/c/openstack/python-openstackclient/+/885526 | 12:52 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Use consistent shortcut to fake network client https://review.opendev.org/c/openstack/python-openstackclient/+/892788 | 12:52 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Add network v2 FakeClientMixin https://review.opendev.org/c/openstack/python-openstackclient/+/885527 | 12:52 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Remove FakeImagev1Client, FakeImagev2Client https://review.opendev.org/c/openstack/python-openstackclient/+/885529 | 12:52 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Use consistent shortcut to fake image client https://review.opendev.org/c/openstack/python-openstackclient/+/892789 | 12:52 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Add image v1, v2 FakeClientMixin https://review.opendev.org/c/openstack/python-openstackclient/+/885530 | 12:52 |
| opendevreview | kim woo seok proposed openstack/openstacksdk master: Implement stack export in openstacksdk https://review.opendev.org/c/openstack/openstacksdk/+/891249 | 13:56 |
| opendevreview | YeJun, Jung proposed openstack/openstacksdk master: Add support for other metadef property operations https://review.opendev.org/c/openstack/openstacksdk/+/857727 | 14:22 |
| chris218 | Hey so I'm using openstacksdk to manage servers through objects that persist for long time in my app, should I create Connection with openstack.connect() on demand when I want to interact with Openstack or can I save it as an attribute and close in for example __del__? | 14:27 |
| opendevreview | SongSuheon proposed openstack/openstacksdk master: Implement heat 'stack event list' https://review.opendev.org/c/openstack/openstacksdk/+/892836 | 14:40 |
| rladntjr4 | Hello! i want to contribute python-openstackcli. i have a few question. Is this the right place to ask questions? | 15:07 |
| opendevreview | Merged openstack/openstacksdk master: identity: Add support for domain config https://review.opendev.org/c/openstack/openstacksdk/+/891681 | 15:16 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: block storage: Add query string params for many APIs https://review.opendev.org/c/openstack/openstacksdk/+/892974 | 15:18 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Migrate 'volume group snapshot' commands to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/892975 | 15:19 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: [DNM] Experiment with OpenAPI schema https://review.opendev.org/c/openstack/openstacksdk/+/892161 | 15:22 |
| gtema | stephenfin: I have updated openapi experiment with few more calls and few random server actions to show how it can be looking like | 15:23 |
| stephenfin | ack, it's on my list to look at before EOD else tomorrow morning | 15:24 |
| stephenfin | rladntjr4: it is | 15:24 |
| stephenfin | just be aware that delays can be slow | 15:24 |
| gtema | thanks stephenfin. I think it is now more then experiment and looks really reasonable in my eyes | 15:25 |
| stephenfin | chris218: tbh, I don't think we have any guidance on that. However, many of the OpenStack services create a session once on start up and then generate a new client each time they need one | 15:28 |
| stephenfin | My gut would suggest opening on demand would likely be more reliable and take you less off the beaten track that saving it and opening/closing manually | 15:28 |
| stephenfin | but maybe gtema has more ideas | 15:28 |
| gtema | well, I think it depends on the "how long". In principle it is ok to keep session open and I have an app that runs in the container with a session pretty much endless, but I do not manage servers this way. | 15:30 |
| gtema | another example would be Zuul which also keeps the session and does activity pretty much permanently with no issues | 15:30 |
| gtema | so I would rather first try to open session on demand and keep it open forever | 15:31 |
| gtema | if you start facing issues - closing session should be also not a problem, but remember every re-connection is causing a new API call to the Keystone (auth_token), so there is additional "overhead" in that | 15:32 |
| gtema | stephenfin - any urgent change to be included in the release? I am going to update release change once stack_export merges and it can be released today/tomorrow | 15:33 |
| chris218 | so if I understand it correctly session != connection, right? so how can I create session with openstacksdk? | 15:34 |
| stephenfin | for sdk? https://review.opendev.org/c/openstack/openstacksdk/+/892974 would be nice | 15:34 |
| gtema | chris218: in principle it is equal, technically not, but highlevel it is | 15:34 |
| stephenfin | oh, maybe also https://review.opendev.org/c/openstack/openstacksdk/+/889984 so I can continue with that work | 15:34 |
| gtema | rojer | 15:35 |
| rladntjr4 | i found some happen in 'server list -c ' command. The code contains a case that handles lowercase, but it does not work. | 15:42 |
| rladntjr4 | so i fix it. https://review.opendev.org/c/openstack/python-openstackclient/+/892830 | 15:42 |
| rladntjr4 | i wonder if this is the way you want. | 15:43 |
| rladntjr4 | i think only 'server list -c ' support this features. | 15:44 |
| opendevreview | kim woo seok proposed openstack/openstacksdk master: Implement stack export in openstacksdk https://review.opendev.org/c/openstack/openstacksdk/+/891249 | 15:51 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: [WIP] Add OpenAPI invokation interface https://review.opendev.org/c/openstack/openstacksdk/+/892161 | 16:05 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: [WIP] Add OpenAPI invocation interface https://review.opendev.org/c/openstack/openstacksdk/+/892161 | 16:09 |
| andrewbogott_ | Before I start writing patches, I would like someone to read https://storyboard.openstack.org/#!/story/2010784 and confirm or deny that the problem I'm describing is an actual problem. I think in theory I'm supposed to ping gtema with this question but so far haven't had any luck with that so I'd appreciate comments from basically anyone else. | 16:48 |
| andrewbogott_ | The short version of that task is: adopting clouds.yaml as the source of auth truth breaks a whole lot of admin-account-based workflows | 16:48 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: docs: Add missing docs for identity resources https://review.opendev.org/c/openstack/openstacksdk/+/891682 | 17:06 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: docs: Add missing docs for compute resources https://review.opendev.org/c/openstack/openstacksdk/+/891683 | 17:06 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: docs: Add missing docs for block storage resources https://review.opendev.org/c/openstack/openstacksdk/+/891684 | 17:06 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add missing docstrings https://review.opendev.org/c/openstack/openstacksdk/+/891685 | 17:06 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: block storage: Add missing docstrings https://review.opendev.org/c/openstack/openstacksdk/+/891686 | 17:06 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: baremetal: Add missing docstrings https://review.opendev.org/c/openstack/openstacksdk/+/891687 | 17:06 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: docs: Document various warnings https://review.opendev.org/c/openstack/openstacksdk/+/891688 | 17:06 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: docs: Add exception documentation https://review.opendev.org/c/openstack/openstacksdk/+/891689 | 17:06 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: tox: Add coverage docs builder https://review.opendev.org/c/openstack/openstacksdk/+/891690 | 17:06 |
| stephenfin | gtema: It would be good to get those doc patches in also, but they're not urgent | 17:08 |
| stephenfin | they are, however, quite useful | 17:08 |
| stephenfin | ...if I do say so myself :) | 17:08 |
| stephenfin | andrewbogott_: looking | 17:08 |
| andrewbogott_ | thank you! | 17:08 |
| stephenfin | Okay, so suggestion is that environment variables should trump cloud variables. This is complicated because of how much the options can potentially layer over each other | 17:10 |
| andrewbogott_ | Can you give me an example? | 17:10 |
| andrewbogott_ | (Or, maybe better to discuss on the task) | 17:10 |
| andrewbogott_ | mostly I want the --os-<whatever> args to trump, but maybe in code that's the same thing as the env variables | 17:12 |
| stephenfin | auth types would be the first thing that jumps to mind because it's been a source of bugs | 17:13 |
| andrewbogott_ | I'm not sure I know what 'auth types' means | 17:13 |
| stephenfin | ah, the 'auth_types' setting in cloud.conf / 'OS_AUTH_TYPE' envvar lets us determine which keystone authentication type to use | 17:14 |
| andrewbogott_ | you mean like admin/public/internal? | 17:14 |
| stephenfin | v3password, v3token, v3applicationcredential etc. | 17:14 |
| andrewbogott_ | oh, I see | 17:14 |
| stephenfin | Setting 'clouds.$cloud.auth_type' completely changes what we look for in 'clouds.$cloud.auth' | 17:14 |
| stephenfin | iirc if it's 'auth_type=v3applicationcredential' but a user sets 'OS_PASSWORD', then we try passing passwords also | 17:15 |
| andrewbogott_ | huh... that seems wrong to me but probably you've already had that conversation :) | 17:16 |
| stephenfin | It is. Unfortunately keystoneauth is a rats nest :) | 17:16 |
| andrewbogott_ | That I know from experience | 17:16 |
| opendevreview | SongSuheon proposed openstack/openstacksdk master: Implement heat 'stack event list' https://review.opendev.org/c/openstack/openstacksdk/+/892836 | 17:17 |
| stephenfin | however, that's kind of tangential to what you're asking | 17:17 |
| andrewbogott_ | So what instead of saying 'env variables trump clouds variables' we say 'select env variables trump clouds variables' | 17:17 |
| andrewbogott_ | and start with project/domain being part of that select | 17:17 |
| andrewbogott_ | Sorry, that was confusing, I'll try again: What if the task is "Allow CLI and env to override the project specified in clouds.yaml"? That would fix /my/ workflows I think. | 17:19 |
| andrewbogott_ | hm. The fact that the same variable OS_PROJECT is used for auth and also used to affect what the command does seems broken either way :( | 17:20 |
| stephenfin | what do you mean? | 17:21 |
| stephenfin | btw, the commands that allow you to specify '--project' rely on server-side support. OSC is merely exposing that. I would guess that those will not be usable by users with standard project-scoped tokens in the future but I can't say for sure | 17:22 |
| andrewbogott_ | Eh, I guess that isn't really right, if you don't have auth in a project you shouldn't be able to do things there anyway. | 17:22 |
| stephenfin | '--os-project' is the keystone thing | 17:23 |
| * andrewbogott_ nods | 17:23 | |
| andrewbogott_ | sorry, had to answer the phone and got confused :) | 17:24 |
| opendevreview | SongSuheon proposed openstack/openstacksdk master: Implement heat 'stack event list' https://review.opendev.org/c/openstack/openstacksdk/+/892836 | 17:24 |
| stephenfin | I have no issues with allowing overriding of clouds.yaml config with CLI args and env vars | 17:24 |
| andrewbogott_ | But yeah, I realize that the --project thing is only selectively implemented for some commands. | 17:24 |
| andrewbogott_ | stephenfin: ok then :) I will try to write a patch, and see how lost I get. | 17:25 |
| andrewbogott_ | Do you think the change should be for /all/ CLI args and env vars, or only for a limited list? | 17:25 |
| stephenfin | I would just ask that we provide a mechanism to disable the env var aspect or set the env var prefix to something other than 'OS_' (if that doesn't exist already) | 17:25 |
| andrewbogott_ | hm... | 17:26 |
| andrewbogott_ | a mechanism other than "Don't set that in your env if you don't want it in your env"? | 17:26 |
| gtema | I was thinking quite some time about that. I think what should always win is "--os-XX" argument. | 17:26 |
| gtema | I would personally even kill the whole env part as such | 17:26 |
| gtema | this is simply terrible stuff from my pov (OS_CLOUD is the only exception) | 17:27 |
| stephenfin | Yes, I know it's ridiculous _but_ we've had bugs in some k8s components because of this (Gophercloud already behaves the way you're suggesting) | 17:27 |
| * stephenfin gets a link | 17:27 | |
| andrewbogott_ | Yeah, I agree that ideally clouds.yaml is a full substitute for ready-made env files. But that might not be a simple migration path. | 17:27 |
| andrewbogott_ | Some days you're the guy wishing that there weren't existing silly workflows, and some days you're the guy complaining about your existing silly workflow being broken. I guess today I'm the second guy :( | 17:28 |
| gtema | heh, maybe. I the guy not using ENVs in OpenStack context at all and happy | 17:30 |
| andrewbogott_ | that sounds nice | 17:30 |
| stephenfin | okay, no rational attached but here's on example https://github.com/kubernetes/cloud-provider-openstack/pull/733/files | 17:32 |
| stephenfin | See the `EnvPrefix` attribute in `pkg/cloudprovider/providers/openstack/openstack.go` | 17:32 |
| * andrewbogott_ discovers that he can't edit storyboard comments | 17:33 | |
| stephenfin | gtema: Alas, I am afraid we are stuck with environment variables for the long-term. TripleO still deploys rc files everywhere, and internally I note all our QE and many field engineers still use them | 17:33 |
| gtema | I know, it is just my opinion that it should have not been existing | 17:33 |
| stephenfin | on that we can agree | 17:34 |
| stephenfin | the mistakes of (project) youth | 17:34 |
| gtema | but wrt CPO - another param to disable/enable ENVs sounds even more crazy | 17:34 |
| gtema | lets see whether the new OSC (;-) can get this addressed | 17:35 |
| andrewbogott_ | Thank you for your thoughts! I will work on a strawman/minimal patch (assuming that's even possible) and then we can see if we want to get more ambitious. | 17:35 |
| opendevreview | Suyeon Cha proposed openstack/openstacksdk master: reset_state, force_delete for Share, ShareSnapshot https://review.opendev.org/c/openstack/openstacksdk/+/888311 | 18:07 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: [WIP] Add OpenAPI invocation interface https://review.opendev.org/c/openstack/openstacksdk/+/892161 | 18:43 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: block storage: Add query string params for many APIs https://review.opendev.org/c/openstack/openstacksdk/+/892974 | 19:27 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/cliff master: Autofit table output if stdout is a tty https://review.opendev.org/c/openstack/cliff/+/892991 | 19:42 |
| chris218 | Hi again so when I try to stop server through conn.compute.start_server(server) it works but when trying to do it with server.start(conn) it errors with AttributeError 'Connection' object has no attribute 'default_microversion' | 20:37 |
| opendevreview | Merged openstack/openstacksdk master: docs: Add missing docs for identity resources https://review.opendev.org/c/openstack/openstacksdk/+/891682 | 21:45 |
| opendevreview | Merged openstack/openstacksdk master: docs: Add missing docs for compute resources https://review.opendev.org/c/openstack/openstacksdk/+/891683 | 21:48 |
| opendevreview | Merged openstack/openstacksdk master: docs: Add missing docs for block storage resources https://review.opendev.org/c/openstack/openstacksdk/+/891684 | 21:56 |
| chris218 | also wanted to note that being able to use OpenAPI spec for openstack sounds supper exciting kudos to you guys :) | 22:15 |
| opendevreview | Merged openstack/openstacksdk master: openstack.format: Remove 'serialize' classmethod https://review.opendev.org/c/openstack/openstacksdk/+/889983 | 23:15 |
| opendevreview | Merged openstack/openstacksdk master: mypy: Address issues with top-level files https://review.opendev.org/c/openstack/openstacksdk/+/889984 | 23:15 |
| opendevreview | Merged openstack/openstacksdk master: Run mypy as pre-commit https://review.opendev.org/c/openstack/openstacksdk/+/889985 | 23:15 |
| opendevreview | Merged openstack/openstacksdk master: block storage: Add query string params for many APIs https://review.opendev.org/c/openstack/openstacksdk/+/892974 | 23:24 |
| opendevreview | Merged openstack/openstacksdk master: compute: Add missing docstrings https://review.opendev.org/c/openstack/openstacksdk/+/891685 | 23:24 |
| opendevreview | Merged openstack/openstacksdk master: block storage: Add missing docstrings https://review.opendev.org/c/openstack/openstacksdk/+/891686 | 23:24 |
| opendevreview | Merged openstack/openstacksdk master: baremetal: Add missing docstrings https://review.opendev.org/c/openstack/openstacksdk/+/891687 | 23:27 |
| chris218 | I figured it out!! needed to pass connection.compute instead of just connection | 23:45 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!