| opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | 08:13 |
|---|---|---|
| opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | 08:20 |
| frickler | stephenfin: since your fix doesn't seem to work yet, can we go with the revert for now? or do a partial revert only for the baremetal part? | 09:46 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | 10:07 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | 10:19 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored coe_cluster{,_template} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/866796 | 10:21 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | 10:23 |
| stephenfin | frickler: I'd be okay with a partial revert, sure | 10:47 |
| stephenfin | If you want to propose it, I'll review | 10:47 |
| opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Move network trunk commands from python-neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/869447 | 11:12 |
| opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: Revert "Add 'details' parameter to various 'find' proxy methods" https://review.opendev.org/c/openstack/openstacksdk/+/869315 | 11:24 |
| opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: DNM: Testing legacy job https://review.opendev.org/c/openstack/openstacksdk/+/869472 | 11:38 |
| opendevreview | Lajos Katona proposed openstack/python-openstackclient master: Move network trunk commands from python-neutronclient https://review.opendev.org/c/openstack/python-openstackclient/+/869447 | 12:15 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | 12:30 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | 12:35 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | 12:40 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated contributor docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | 13:21 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated contributor docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | 14:02 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | 14:03 |
| frickler | stephenfin: tox is completely acting up now on 869315 and I cannot reproduce locally. I'm holding a node for investigation now, but if you have any idea, feel free to join in | 14:20 |
| gtema | yeah, tox became a real mess, myself debugging issues with it | 14:21 |
| frickler | oh, I missed the explicit "--skip-missing-interpreters=false" parameter that we call tox with | 14:30 |
| opendevreview | Dr. Jens Harbott proposed openstack/openstacksdk master: DNM test tox workaround https://review.opendev.org/c/openstack/openstacksdk/+/869480 | 14:43 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | 14:56 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | 14:58 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Updated docs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/868923 | 15:02 |
| stephenfin | frickler: if you want to get that passing, you either (a) drop usedevelop=true from tox.ini or (b) wait for https://github.com/tox-dev/tox/pull/2828 to merge | 15:29 |
| opendevreview | Lajos Katona proposed openstack/openstacksdk master: Add BGP Speakers and Peers to SDK https://review.opendev.org/c/openstack/openstacksdk/+/869485 | 16:29 |
| frickler | stephenfin: tox 4.2.5 doesn't help either. dropping usedevelop gives yet another error then: SystemExit: error: Multiple top-level packages discovered in a flat-layout: ['vv', 'extras', 'devstack', 'openstack', 'playbooks', 'releasenotes']. | 17:26 |
| stephenfin | frickler: That's https://review.opendev.org/c/openstack/pbr/+/869082 | 17:27 |
| stephenfin | That should be merged today and released Monday so we'll be unblocked then | 17:28 |
| stephenfin | clarkb and fungi are looking at it | 17:28 |
| fungi | yeah, just discussing how to preserve test coverage for older platforms now, i think clarkb is pushing up a new revision or additional change for it | 17:31 |
| fungi | as a followup, according to what he said in #opendev | 17:31 |
| fungi | er, in #openstack-infra i mean | 17:37 |
| fungi | well, both | 17:37 |
| whoami-rajat | stephenfin, hey, regarding your comment here https://review.opendev.org/c/openstack/python-openstackclient/+/869436/2/openstackclient/tests/unit/volume/v3/test_volume.py#123 | 17:39 |
| whoami-rajat | I tried that before but did that with assertEqual | 17:39 |
| whoami-rajat | in the examples i see assertCountEqual being used | 17:39 |
| whoami-rajat | but I'm unsure if it compares the DictColumn ? | 17:39 |
| stephenfin | can you rephrase the question? | 17:42 |
| whoami-rajat | does the assertCountEqual method actually compare DictColumn? | 17:43 |
| whoami-rajat | IIUC it takes frequency of elements and compares that, like Counter(list1) == Counter(list2) | 17:45 |
| whoami-rajat | and that's what is used in tests to compare values with DictColumn in it | 17:45 |
| whoami-rajat | like here https://github.com/openstack/python-openstackclient/blob/7985d496892635b70b71be552c52946824d73e9b/openstackclient/tests/unit/volume/v2/test_volume.py#L1125 | 17:47 |
| whoami-rajat | stephenfin, ^ | 17:47 |
| stephenfin | well you can check. Remove dictcolumn from one of the tests that has it and see if the test continues to pass | 17:49 |
| stephenfin | but the answer is yes, it does compare as expected | 17:49 |
| stephenfin | they're comparable because of this https://github.com/openstack/cliff/commit/c1c991045cece85dd55494f9d4670429e370e131 | 17:50 |
| stephenfin | sorry, this https://github.com/openstack/cliff/commit/997e05fce6cf2267099f3d5f91116ba491495d7e | 17:51 |
| stephenfin | (The first commit should have said "sortable", not "comparable") | 17:51 |
| whoami-rajat | ok, i see it failing with a fake value, DictColumn(meta) != DictColumn({'fake':'dict'}) | 17:55 |
| whoami-rajat | will update it | 17:55 |
| whoami-rajat | thanks | 17:55 |
| opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume summary command https://review.opendev.org/c/openstack/python-openstackclient/+/869436 | 18:18 |
| opendevreview | Corey Bryant proposed openstack/openstackclient master: Test to ensure tox is pinned for stable/zed https://review.opendev.org/c/openstack/openstackclient/+/869504 | 19:11 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Added parameter for managing rules in security_group module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863208 | 19:11 |
| opendevreview | Corey Bryant proposed openstack/python-openstackclient stable/zed: [DNM] Test to ensure tox is pinned for stable/zed https://review.opendev.org/c/openstack/python-openstackclient/+/869505 | 19:38 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!