| opendevreview | Merged openstack/ansible-collections-openstack master: Fix documentation defaults for modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863267 | 08:54 |
|---|---|---|
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | 10:25 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | 10:26 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | 10:28 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | 10:28 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix backup metadata management https://review.opendev.org/c/openstack/openstacksdk/+/863634 | 10:38 |
| gtema | jm1 - this is for you | 10:38 |
| jm1 | gtema: uuuh nice :D thx! | 10:39 |
| gtema | as usual - one line of code is causing heavy misbehave | 10:39 |
| jm1 | gtema: this has never worked before, has it? wondering how people tested their code when they contributed it .. | 10:41 |
| gtema | well, this is metadata. It is not a scope of SDK to test functionality of the service itself with all possible combinations | 10:42 |
| gtema | in this case backup was copied from v2 | 10:42 |
| jm1 | gtema: btw do we have to use 3.56 instead of 3.51 because of this? https://review.opendev.org/c/openstack/openstacksdk/+/863634/1/openstack/block_storage/v3/backup.py#84 | 10:43 |
| gtema | no, max_microversion is something like: client support max 3.51 for this resource | 10:43 |
| gtema | so we eventually downgrade server side just to be sure server doesn't send us back what we are not supporting | 10:44 |
| jm1 | gtema: what microversion would be used without your patch? | 10:45 |
| gtema | 3.51 | 10:45 |
| gtema | because there is no changes to backup resource afterwards | 10:45 |
| jm1 | gtema: so why do you set it to 3.51 if 3.51 would be used anyway? | 10:46 |
| gtema | no, without that 3.0 is used | 10:46 |
| jm1 | gtema: ah ok, so 3.0 is the default | 10:46 |
| gtema | I misread the question, sorry | 10:46 |
| gtema | SDK opts for max_microversion if set on the resource, otherwise not specify microver at all | 10:47 |
| jm1 | gtema: but how are users supposed to use the user_id attribute if we set microversio to 3.51 instead of 3.56? | 10:47 |
| gtema | where you get 3.56 from? | 10:48 |
| gtema | ah, I missed to look at "get" response | 10:48 |
| jm1 | "The UUID of the project owner. New in 3.56" < https://review.opendev.org/c/openstack/openstacksdk/+/863634/1/openstack/block_storage/v3/backup.py#84 | 10:48 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix backup metadata management https://review.opendev.org/c/openstack/openstacksdk/+/863634 | 10:49 |
| jm1 | gtema: :D thank you | 10:49 |
| gtema | now I see this is again not really correct, since in 3.64 also encryption_key_id is being added | 10:50 |
| jm1 | gtema: one would think that cinder folks would add their new features to osc | 10:50 |
| jm1 | ..and sdk | 10:50 |
| gtema | yupp | 10:51 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Fix backup metadata management and update https://review.opendev.org/c/openstack/openstacksdk/+/863634 | 10:57 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | 12:44 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | 12:45 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | 12:45 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | 12:45 |
| opendevreview | Merged openstack/openstacksdk master: image: Correct typo with 'get_import_info' proxy method https://review.opendev.org/c/openstack/openstacksdk/+/862177 | 12:51 |
| opendevreview | Merged openstack/openstacksdk master: image: Correct typo https://review.opendev.org/c/openstack/openstacksdk/+/862178 | 13:01 |
| opendevreview | Merged openstack/openstacksdk master: image: Allow listing detailed view of stores https://review.opendev.org/c/openstack/openstacksdk/+/862179 | 13:01 |
| opendevreview | Merged openstack/openstacksdk master: image: Add 'store' argument to 'delete_image' proxy method https://review.opendev.org/c/openstack/openstacksdk/+/862180 | 13:01 |
| opendevreview | Merged openstack/openstacksdk master: tests: Avoid potential aliasing of imports https://review.opendev.org/c/openstack/openstacksdk/+/862297 | 13:01 |
| diablo_rojo_phone | gtema: should I join? I was driving my mom to work and am running late | 13:48 |
| gtema | no problem, we are fine | 13:48 |
| opendevreview | Eunyoung Kim proposed openstack/openstacksdk master: image: Add metadef resource type operations https://review.opendev.org/c/openstack/openstacksdk/+/861490 | 13:55 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Introduce resource_registry in the proxies https://review.opendev.org/c/openstack/openstacksdk/+/863658 | 14:38 |
| *** rcastillo is now known as rcastillo|rover | 15:28 | |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Implement unified search_resources method https://review.opendev.org/c/openstack/openstacksdk/+/859845 | 16:23 |
| opendevreview | Merged openstack/openstacksdk master: Fix backup metadata management and update https://review.opendev.org/c/openstack/openstacksdk/+/863634 | 16:48 |
| opendevreview | Merged openstack/openstacksdk master: Fix creation of protected image for old user code https://review.opendev.org/c/openstack/openstacksdk/+/838941 | 16:48 |
| *** dtantsur_ is now known as dtantsur | 17:56 | |
| *** dtantsur_ is now known as dtantsur | 18:29 | |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_backup{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863486 | 19:06 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored volume_snapshot{,_info} modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863498 | 19:09 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored config module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863512 | 19:09 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored integration test of openstacksdk logging feature https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863529 | 19:09 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored project_access module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/863696 | 19:10 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!