| opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix missing closing bracket https://review.opendev.org/c/openstack/python-openstackclient/+/854462 | 00:12 |
|---|---|---|
| opendevreview | Ke Niu proposed openstack/shade master: remove unicode prefix from code https://review.opendev.org/c/openstack/shade/+/854510 | 03:39 |
| opendevreview | Ke Niu proposed openstack/shade master: remove unicode prefix from code https://review.opendev.org/c/openstack/shade/+/854510 | 03:40 |
| opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | 06:42 |
| opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | 06:51 |
| opendevreview | Merged openstack/openstacksdk master: Support unknown attributes in resource.__getitem__ https://review.opendev.org/c/openstack/openstacksdk/+/854461 | 07:38 |
| jm1 | gtema: actually i think we should implement that jmespath_filters handling inside openstacksdk https://review.opendev.org/c/openstack/openstacksdk/+/853052/comments/11073ef3_681b3030 | 07:55 |
| gtema | what exactly do you mean? with my patch jmespath is supported, but you need to pass it. So I do not deal with creating jmes out of anything else | 07:56 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_node_action module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854357 | 07:58 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_node_action module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854357 | 08:04 |
| opendevreview | Areg Grigoryan proposed openstack/python-openstackclient master: Added "openstack image namespace list" command https://review.opendev.org/c/openstack/python-openstackclient/+/854557 | 08:14 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Release 1.9.0 version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854564 | 08:49 |
| jm1 | gtema: cloud layer functions such as search_projects offer a filters parameter which accept(ed in the past) a jmespath expression. imho openstacksdk should continue to support that | 08:51 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_node_action module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854357 | 09:05 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_port and baremetal_port_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854569 | 09:06 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored baremetal_port and baremetal_port_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854569 | 09:19 |
| gtema | <jm1> "gtema: cloud layer functions..." <- ok, for cases from cloud layer this is definitely going to live further. It just that implementation will be moved to the list function. Once we agree on the change in question and merge it I will go and update cloud layer functions to unify the logic | 10:06 |
| jm1 | gtema: ack | 10:25 |
| opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | 11:09 |
| opendevreview | yangjianfeng proposed openstack/python-openstackclient master: Add router ndp proxy commands https://review.opendev.org/c/openstack/python-openstackclient/+/749038 | 11:14 |
| opendevreview | Areg Grigoryan proposed openstack/openstacksdk master: added api requirements for new "openstack image namespace list command" https://review.opendev.org/c/openstack/openstacksdk/+/854612 | 11:54 |
| *** tosky_ is now known as tosky | 12:25 | |
| opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Release 1.9.0 version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854564 | 13:16 |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack stable/1.0.0: Fix release job https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854634 | 14:54 |
| *** tosky is now known as Guest1129 | 15:12 | |
| *** tosky_ is now known as tosky | 15:12 | |
| opendevreview | Takashi Kajinami proposed openstack/python-openstackclient master: Fix missing closing brackets in metavar https://review.opendev.org/c/openstack/python-openstackclient/+/854462 | 16:09 |
| frickler | slaweq: gtema: ralonsoh: via a merge conflict I found https://review.opendev.org/c/openstack/python-openstackclient/+/424733 and it does have a certain point. there are a lot of field that show "None" as value instead of an empty string, only some like description are really empty. my fix would likely go in the other direction though, like make an unset ipv4_address_scope or | 16:42 |
| frickler | provider:segmentation_id field show an empty value instead of "None". what do you think? | 16:42 |
| ralonsoh | frickler, for flat networks doesn't matter | 17:18 |
| ralonsoh | maybe is better an empty string, rather than None | 17:18 |
| ralonsoh | what other parameters could have this None parameter? | 17:19 |
| ralonsoh | hold on, no, it is better to show "None" | 17:19 |
| ralonsoh | empty string is a valid value, None is no value at all | 17:19 |
| ralonsoh | and I've seen a problem related to the port binding because of this | 17:20 |
| ralonsoh | converting a non-value to an empty string could hide this | 17:20 |
| gtema | frickler: unset doesn't work for sure, since user has attribute access. None vs empty value is so terrible to differentiate once server doesn't return the field at all (/serves/details vs /servers). And even more troublesome to differentiate empty value (as None) from real empty value | 17:46 |
| gtema | We have none in the interface and we need to live with it | 17:47 |
| frickler | so you're telling me that the above patch is valid and I should rebase it and also apply it for the dns_domain field, o.k. | 20:23 |
| *** ianw_ is now known as ianw | 20:37 | |
| *** tosky_ is now known as tosky | 22:06 | |
| *** anskiy1 is now known as anskiy | 22:28 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!