| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: [DNM] Build and install latest RPM for openstacksdk in TripleO jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849657 | 07:12 |
|---|---|---|
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored server and server_info modules https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849423 | 07:44 |
| opendevreview | mbu proposed openstack/osc-lib stable/yoga: Do not output log on bash autocomplete generation https://review.opendev.org/c/openstack/osc-lib/+/849822 | 08:38 |
| opendevreview | mbu proposed openstack/osc-lib stable/xena: Do not output log on bash autocomplete generation https://review.opendev.org/c/openstack/osc-lib/+/849823 | 08:38 |
| opendevreview | mbu proposed openstack/osc-lib stable/wallaby: Do not output log on bash autocomplete generation https://review.opendev.org/c/openstack/osc-lib/+/849824 | 08:38 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 09:03 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored router module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849793 | 09:27 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Replaced code in routers_info module with openstacksdk function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849975 | 09:56 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Replaced code in routers_info module with openstacksdk function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849975 | 10:13 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 10:16 |
| elodilles | gtema: hi, release team is approving zed-2 release patches and i remember that openstacksdk latest release was a bit 'bigger' than usual, so now that we generated the zed-2 release patch for it, it would be good if you could double check the release, before we merge it (deadline was yesterday): https://review.opendev.org/c/openstack/releases/+/849554 | 10:17 |
| gtema | uhm, I somehow again missed the email, need to check spam rules. Looking now | 10:18 |
| elodilles | this is the general countdown mail that contains the info about zed-2: https://lists.openstack.org/pipermail/openstack-discuss/2022-July/029465.html | 10:20 |
| gtema | thks, approved | 10:20 |
| elodilles | gtema: thanks \o/ | 10:21 |
| elodilles | just a question: do you plan to release 1.0.0 @ zed-3? | 10:21 |
| elodilles | or it is not planned yet / will be released in the next cycle after Zed? | 10:24 |
| elodilles | (i'm just asking this out of curiosity, no official statement is needed or something like that [4~:)) | 10:25 |
| gtema | I fear zed-3 will not be reachable - there are still lots of issues fron Ansible collections side | 10:25 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 10:26 |
| elodilles | gtema: ack, i see, thanks! | 10:28 |
| opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Replaced code in routers_info module with openstacksdk function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/849975 | 10:34 |
| jm1 | gtema: having issues with unit tests for this one here https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 10:48 |
| jm1 | gtema: any idea how to change the mock uris? https://291f4451bebc670e507b-a999ae1d5baedde86711d4f3bf719537.ssl.cf1.rackcdn.com/849967/3/check/openstack-tox-py38/863c9c3/job-output.txt | 10:48 |
| jm1 | gtema: that is the error: requests_mock.exceptions.NoMockAddress: No mock address: GET https://network.example.com/v2.0/ports?device_id=57076620-dcfb-42ed-8ad6-79ccb4a79ed2 | 10:48 |
| jm1 | gtema: this is the location where mock is created: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/cloud/test_router.py#L377 | 10:49 |
| gtema | hehe, I admit I reworked how mocks are filled here | 10:50 |
| gtema | why do you delete device_id filter? | 10:52 |
| jm1 | gtema: i dont, do i? | 10:53 |
| gtema | need to look deeper, but that should be the reason for mock not being recognized | 10:54 |
| gtema | ah, this is vice versa, this is the only one remaining now | 10:55 |
| gtema | i will update your change after lunch if you don't mind | 10:55 |
| jm1 | gtema: yes, instead of doing 4 api calls with different device_owner's i am doing just a single one | 10:55 |
| gtema | sure, makes sense. There are too many places to simplify - that is the whole sense of breaking ansible ;-) | 10:57 |
| jm1 | gtema: maybe you can give me a hint on how to remove the device_owner from the mock url? | 10:59 |
| gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/cloud/test_router.py#L374 | 11:00 |
| gtema | maybe extend the function _get_mock_dict to not to include it in the QS if param is empty | 11:01 |
| opendevreview | Pavlo Shchelokovskyy proposed openstack/python-openstackclient master: Fix server evacuate command https://review.opendev.org/c/openstack/python-openstackclient/+/849990 | 11:24 |
| jm1 | gtema: omg, of course 😂 wood and all those trees, you know.. | 12:42 |
| gtema | yeah | 12:42 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 12:46 |
| anskiy | gtema: hello! I've made this thing: https://review.opendev.org/c/openstack/openstacksdk/+/848095, it's not thoroughly tested (I'm using a bit less functionality: just basic create/delete/find and ...s(), without extensive filters and such), but it works as expected from what I can see now. Can you take a look and tell me what's left for it to be merged? | 12:54 |
| gtema | ok, will try to get some time for that | 12:54 |
| anskiy | I'm gonna remove the "WIP" in the heading, CI should be fine as those issues look temporary. Thank you! | 12:56 |
| opendevreview | Danila Balagansky proposed openstack/openstacksdk master: Cron Triggers proxy https://review.opendev.org/c/openstack/openstacksdk/+/848095 | 12:58 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 14:02 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 14:49 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 15:06 |
| opendevreview | Stephen Finucane proposed openstack/cliff master: Remove final use of pkg_resources https://review.opendev.org/c/openstack/cliff/+/842350 | 15:08 |
| gtema | stephenfin, I feel nearly ashamed, but how have you found syntax from https://review.opendev.org/c/openstack/openstacksdk/+/846214/2/openstack/resource.py#1303? | 15:14 |
| stephenfin | gtema: https://peps.python.org/pep-3102/ | 15:14 |
| gtema | ugh | 15:14 |
| stephenfin | that's for kwarg-only arguments | 15:14 |
| gtema | I've never seen single "*" | 15:15 |
| stephenfin | which I think make sense here. No one should ever be passing those args positionally. It also means we can opt to move things around down the line if we like | 15:15 |
| stephenfin | Yeah, it's a Python 3-only thing afaik | 15:15 |
| stephenfin | so we could only use it in the last two years or so | 15:15 |
| gtema | yeah, feels now totally "weird". Moving more and more into the static languages with pointers and so on | 15:16 |
| stephenfin | you've also got positional-only arguments since Python 3.8, though I've yet to find a reason for those https://peps.python.org/pep-0570/ | 15:19 |
| gtema | oh man, going into rust direction nearly | 15:20 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 15:29 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | 15:56 |
| opendevreview | Artem Goncharov proposed openstack/openstacksdk master: block storage: Add support for the Group resource https://review.opendev.org/c/openstack/openstacksdk/+/782013 | 16:11 |
| stephenfin | gtema: Nice find on ^ | 16:33 |
| gtema | thks | 16:33 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update router for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/846446 | 17:49 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Adds mechanisms to extend OpenstackModule behaviors https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843324 | 18:24 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update baremetal_inspect to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843334 | 18:24 |
| opendevreview | Merged openstack/openstacksdk master: Add VPNaaS Endpoint Group resource https://review.opendev.org/c/openstack/openstacksdk/+/846016 | 18:24 |
| opendevreview | Merged openstack/openstacksdk master: Reorg existing vpnaas content https://review.opendev.org/c/openstack/openstacksdk/+/846017 | 18:24 |
| opendevreview | Merged openstack/openstacksdk master: Add VPNaaS IpsecPolicy resource https://review.opendev.org/c/openstack/openstacksdk/+/846595 | 18:24 |
| opendevreview | Merged openstack/openstacksdk master: Allow unknown attributes in project resources https://review.opendev.org/c/openstack/openstacksdk/+/843964 | 18:24 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 19:04 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 19:18 |
| opendevreview | Jakob Meng proposed openstack/openstacksdk master: Reduce list_router_interfaces() to necessary API calls https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 19:28 |
| jm1 | gtema: unit tests for list_router_interfaces fixed. it took me a while until i realized that network.ports() returns a generator and those are iterable only once of course 🙄😂 https://review.opendev.org/c/openstack/openstacksdk/+/849967 | 19:41 |
| gtema | Yes, sdks (and working with apis) is always full of fun | 19:45 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: [WIP] Update compute flavor module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | 19:47 |
| jm1 | gtema: at least its working now and we can get rid of some more code in aoc :) | 19:47 |
| gtema | That's awesome | 19:47 |
| jm1 | gtema: that is it for today, have a nice weekend 🍻 | 19:47 |
| gtema | Thanks, you too | 19:48 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update baremetal_inspect to be compatible with new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/843334 | 20:19 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update compute flavor module for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | 20:27 |
| opendevreview | Rafael Castillo proposed openstack/ansible-collections-openstack master: Update compute flavor module for 2.0.0 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/850069 | 22:38 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!