frickler | gtema: iiuc the tenant_id warning is triggered not because OSC is using it, but because the API response from neutron still contains that field. | 05:43 |
---|---|---|
gtema | Ok, having long day on the train today, maybe will have enough capability to check. That mean to me out deprecation warning is not really raised properly. And it pains on few fronts so maybe we should simply disable it | 06:10 |
gtema | Older clouds have all rights to use fields not yet deprecated for them | 06:10 |
frickler | gtema: yes, although that even is with neutron master still. not sure if we could hard drop tenant_id from the API response if project_id is present. otherwise disabling that deprecation might be the right way to do, yes | 06:17 |
gtema | There's even change open for dropping warnings | 06:19 |
frickler | maybe make that specific to tenant_id. I'm not sure there is another attribute that is deprecated but still in widespread use. the other option would be to check whether the resource is coming from user input or from the API, but I guess that distinction would be difficult to make | 07:02 |
gtema | Well, we can add additional (suppress_warning) attribute ;-) | 07:03 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack stable/1.0.0: Make publish_collection more universal https://review.opendev.org/c/openstack/ansible-collections-openstack/+/847659 | 07:11 |
frickler | but then everyone will set that and in the end we could have just dropped the warnings right away | 07:15 |
frickler | gtema: just found that this one was wrong, too https://review.opendev.org/c/openstack/python-openstackclient/+/824746/2/openstackclient/network/v2/security_group.py#b38 | 07:15 |
gtema | Right | 07:15 |
frickler | makes tenant_id show up in the rules. I'll do a revert for that line | 07:16 |
gtema | Yeah, this is what I meant - something explicitly touches attr | 07:16 |
frickler | oh, wait, it's not only that single line that was wrong, need to revert all the column_map changes in that patch, too. /me sighs | 07:21 |
frickler | this is really a can of worms, why do floating IPs have a subnet attr? can't find anything about that in the api-ref. maybe it was a nova-network thing? | 08:02 |
frickler | and I'm also not convinced that copying the floating_ip_address as "name" attribute is a good thing | 08:03 |
gtema | Right, networking is a pretty dangerous thing | 08:03 |
opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: Don't show tenant_id in network objects https://review.opendev.org/c/openstack/python-openstackclient/+/847751 | 08:53 |
opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: WIP: Test for tenant_id and project_id columns https://review.opendev.org/c/openstack/python-openstackclient/+/847752 | 08:53 |
opendevreview | ribaudr proposed openstack/python-openstackclient master: Microversion 2.91: Support specifying destination host to unshelve https://review.opendev.org/c/openstack/python-openstackclient/+/831902 | 08:54 |
gtema | frickler - https://review.opendev.org/c/openstack/openstacksdk/+/816790 was to disable deprecation warning | 08:58 |
*** vkmc_ is now known as vkmc | 09:10 | |
frickler | gtema: yes, I found that, that's what I was referring to earlier. don't disable all warnings, only if attr="tenant_id", then I think we should merge that | 10:25 |
gtema | I fear this is really more widespread than only tenant_id, but ok, will update the change | 10:27 |
opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Disable deprecation warning for tenant_id https://review.opendev.org/c/openstack/openstacksdk/+/816790 | 10:39 |
gtema | frickler: ^^ | 10:42 |
opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: WIP: Test for tenant_id and project_id columns https://review.opendev.org/c/openstack/python-openstackclient/+/847752 | 11:12 |
opendevreview | Jakob Meng proposed openstack/ansible-collections-openstack master: Refactored endpoint module and explained region attribute https://review.opendev.org/c/openstack/ansible-collections-openstack/+/847293 | 11:34 |
*** arxcruz is now known as arxcruz|brb | 12:42 | |
opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: WIP: Test for tenant_id and project_id columns https://review.opendev.org/c/openstack/python-openstackclient/+/847752 | 12:45 |
opendevreview | Merged openstack/ansible-collections-openstack stable/1.0.0: Make publish_collection more universal https://review.opendev.org/c/openstack/ansible-collections-openstack/+/847659 | 12:48 |
frickler | it seems that https://review.opendev.org/c/openstack/python-openstackclient/+/828106 is responsible for much of the functional test instability we are seeing | 13:11 |
frickler | it sets the network quota to 1, leading to failures if any other test runs in parallel and tries to create a network | 13:12 |
frickler | test_quota_network_set_with_force() in particular. not sure what ralonsoh was thinking there. I'll make a patch to skip that test | 13:13 |
opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: Skip test_quota_network_set_with_force func test https://review.opendev.org/c/openstack/python-openstackclient/+/847786 | 13:25 |
frickler | is there any chance we could revert to using launchpad instead of storyboard? trying to find out whether a story already exists for an issue seems impossible to me | 13:29 |
gtema | I feel also terribly about storyboard. Honestly I want to see the outcome of the general 3rd party projects discussion, cause using gitea issue tracker is at least mentioned there. If we get a chance to get this working I would rather go this way and skip fallback to launchpad now (it has also not really an awesome UX) | 13:33 |
*** arxcruz|brb is now known as arxcruz | 13:48 | |
opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves security_group_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840660 | 13:56 |
opendevreview | Ananya proposed openstack/ansible-collections-openstack master: Moves security_group_info from cloud to proxy object https://review.opendev.org/c/openstack/ansible-collections-openstack/+/840660 | 14:05 |
opendevreview | Jan Hartkopf proposed openstack/python-openstackclient master: add support for microversion 2.91 https://review.opendev.org/c/openstack/python-openstackclient/+/847792 | 14:11 |
opendevreview | Merged openstack/osc-lib master: Do not output log on bash autocomplete generation https://review.opendev.org/c/openstack/osc-lib/+/841307 | 14:28 |
slaweq | gtema hi, I have a quick question to You about this neutron-vpnaas support in OSC/SDK - is there any story or something created already so if I would like to help with it, I will not e.g. duplicate work done by someone else already? | 14:44 |
gtema | we do not have a story, since nobody here is happy about using Storyboard | 14:45 |
slaweq | so there is no any tracker for that now? | 14:46 |
gtema | nope | 14:46 |
slaweq | ok | 14:46 |
slaweq | I will ping You simply if/when I will have some time to work on this | 14:46 |
gtema | sure, great | 14:46 |
opendevreview | Merged openstack/openstacksdk master: Warn when no statsd library available https://review.opendev.org/c/openstack/openstacksdk/+/843855 | 15:49 |
opendevreview | Merged openstack/openstacksdk master: test: Remove duplicated tests https://review.opendev.org/c/openstack/openstacksdk/+/847577 | 15:54 |
opendevreview | Merged openstack/openstacksdk master: tests: Add pointers to docs on running tests https://review.opendev.org/c/openstack/openstacksdk/+/847578 | 15:54 |
opendevreview | Merged openstack/python-openstackclient master: Don't show tenant_id in network objects https://review.opendev.org/c/openstack/python-openstackclient/+/847751 | 15:54 |
opendevreview | Merged openstack/python-openstackclient master: volume: Correct output of 'volume attachment create' https://review.opendev.org/c/openstack/python-openstackclient/+/841894 | 15:54 |
*** diablo_rojo__ is now known as diablo_rojo | 15:56 | |
*** diablo_rojo__ is now known as diablo_rojo | 16:22 | |
*** diablo_rojo is now known as Guest3434 | 17:08 | |
*** Guest3279 is now known as rcastillo | 17:20 | |
*** Guest3434 is now known as diablo_rojo | 18:03 | |
*** diablo_rojo__ is now known as diablo_rojo | 19:25 | |
opendevreview | Merged openstack/ansible-collections-openstack master: Update project_info module to new sdk https://review.opendev.org/c/openstack/ansible-collections-openstack/+/837276 | 21:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!