| *** sshnaidm is now known as sshnaidm|off | 02:57 | |
| thomasb06 | gtema: Hello. At the moment, I'm modifying `load_balancer/v2/_proxy.py`, but it looks like the docstrings indentation is broken back again. Maybe I missed something? | 08:24 |
|---|---|---|
| gtema | maybe there was some additional change that broke it again | 08:25 |
| gtema | actually I do not see any change from you landed there | 08:26 |
| gtema | and I do not see any your change fixing load_balancer | 08:27 |
| thomasb06 | maybe I forgot to commit the changes on this file, I do it now | 08:43 |
| thomasb06 | what is the line length limit, 82 characters? | 08:48 |
| gtema | 80 | 08:49 |
| thomasb06 | arg... Good thing I asked | 08:49 |
| thomasb06 | so 81 triggers an error but 80 is ok? | 08:56 |
| gtema | actually 79 is ok, but 80 is not good anymore | 08:57 |
| thomasb06 | alright | 08:57 |
| thomasb06 | line 1097 or so, there is ":class:`~openstack.load_balancer.v2.availability_zone.AvailabilityZone`," but it can fit 79 characters | 09:01 |
| thomasb06 | maybe for the docstrings, the 80 limit is not blocking? | 09:02 |
| thomasb06 | *can't fit | 09:06 |
| gtema | those particular lines must stay on the same line, and pep should not actually complain about it - it should know what to ignore | 09:10 |
| thomasb06 | great, thank you | 09:10 |
| gtema | but just ensure that :class:`blabla` stays on the single line | 09:10 |
| thomasb06 | so ":rtype: :class:`~openstack.load_balancer.v2.availability_zone_profile.AvailabilityZoneProfile`" takes to be split in two lines? | 09:11 |
| gtema | yes, ":rtype: \n :class:`blabla`" | 09:12 |
| thomasb06 | here it is: https://review.opendev.org/c/openstack/openstacksdk/+/820357 | 09:17 |
| gtema | yeah, let's see what checks will say | 09:24 |
| gtema | oh, I missed in the reviews list. -https://review.opendev.org/c/openstack/openstacksdk/+/816809 - this was the initial change for fixing it in the LB, but checks failed | 09:25 |
| thomasb06 | so maybe we wait for this one? It doesn't seem related to the docstrings, is it? | 09:27 |
| gtema | we take the latest one once it passes | 09:28 |
| thomasb06 | so I abandon number 816809? | 09:28 |
| gtema | yeah, perhaps | 09:30 |
| thomasb06 | sure | 09:30 |
| thomasb06 | Orchestration is ready too: https://review.opendev.org/c/openstack/openstacksdk/+/820360 | 09:34 |
| opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | 11:26 |
| opendevreview | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Adding "files/config_drive_files" to server module. https://review.opendev.org/c/openstack/ansible-collections-openstack/+/819657 | 12:53 |
| opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | 18:44 |
| opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | 19:02 |
| opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | 22:51 |
| opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | 22:53 |
| opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch add fixed IP to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/820050 | 22:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!