| *** tkajinam is now known as Guest6741 | 06:15 | |
| thomasb06 | gtema: Hello. The Compute docstring stays in error, but it doesn't seem related with my modifications: https://review.opendev.org/c/openstack/openstacksdk/+/816785 | 08:30 |
|---|---|---|
| thomasb06 | By the way, would you have something else to give to me? | 08:31 |
| gtema | it does - line 776 - you have 2 odd spaces | 08:32 |
| gtema | actually since you are already on the docstrings there are some more things to fix - in some proxy methods apparently type of the return is not really being accepted properly what results in broken link | 08:34 |
| gtema | i.e. https://docs.openstack.org/openstacksdk/latest/user/proxies/network.html - remove_gateway_from_router method | 08:34 |
| gtema | I assume this is due to the line break in the rtype macro | 08:35 |
| gtema | so it would be great if you can do another walk through proxies and have a look where those are broken | 08:35 |
| thomasb06 | line 776, fixed | 08:36 |
| thomasb06 | Regarding the remove_gateway_from_router method, the docstrings has ":rtype: :class: `~openstack.network.v2.router.Router`" without line break (after executing `git pull origin feature/r1`) | 08:41 |
| gtema | yeah, but there is space in between ":class: `~openstack.network.v2.router.Router`" | 08:42 |
| gtema | between :class: and the `~...` | 08:43 |
| thomasb06 | understood | 08:43 |
| thomasb06 | Let me take care of it | 08:43 |
| gtema | cool, thks | 08:43 |
| thomasb06 | (my CV says 'thanks you guys', hehe...) | 08:44 |
| gtema | i.e. https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/network/v2/_proxy.py#L780 the line is broken (find_local_ip_association method) | 08:44 |
| gtema | same stuff for validate_auto_allocated_topology - I assume it can be in multiple places (you can verify in the rendered docs (i.e. on https://cf484ceb1edd89d30dfe-675a54f2682a71ce0a87525368caccbf.ssl.cf5.rackcdn.com/816785/2/check/openstack-tox-docs/14f9fb4/docs/user/index.html#api-documentation | 08:46 |
| gtema | that is the link to built artifacts from your last change | 08:46 |
| gtema | there you go under "Service Proxies" | 08:46 |
| thomasb06 | so it should be :class:`openstack.service.version.variable`, with no space, and on it's own line if a line break splits it? | 08:47 |
| gtema | yes | 08:47 |
| gtema | basically :class:`whatever` - this all must be on the same line | 08:47 |
| thomasb06 | ok, I track them down | 08:50 |
| gtema | awesome | 08:50 |
| opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | 08:55 |
| isabek | gtema: Hi! Can you please take a look [1] when you have a time. Thanks! 1) https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | 09:38 |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add support for server lock reason https://review.opendev.org/c/openstack/openstacksdk/+/819293 | 11:22 |
| *** artom_ is now known as artom | 15:53 | |
| opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add support for server lock reason https://review.opendev.org/c/openstack/openstacksdk/+/819293 | 16:52 |
| stephenfin | gtema: Is the neutron stuff in OSC using neutronclient or SDK now? | 17:19 |
| gtema | sdk | 17:19 |
| stephenfin | I can figure it out but just in case you know off the top of your head | 17:19 |
| stephenfin | Sweet | 17:19 |
| stephenfin | Okay, all our tests need to be fixed. They're using FakeResource everywhere /o\ | 17:20 |
| gtema | and glance also | 17:20 |
| stephenfin | Fun! | 17:20 |
| stephenfin | (rather than "fake" SDK objects) | 17:20 |
| stephenfin | *SDK resource objects | 17:20 |
| gtema | yes, I wanted to start on that after we complete with moving compute - there's plenty of improvements possible | 17:20 |
| stephenfin | Okay, cool, once you know. I'll make sure we don't add any new usage of this | 17:20 |
| gtema | :) | 17:21 |
| opendevreview | Merged openstack/python-openstackclient master: Add --subnet-pool to subnet list https://review.opendev.org/c/openstack/python-openstackclient/+/778521 | 17:46 |
| opendevreview | Merged openstack/python-openstackclient master: Switch command server add volume to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815919 | 17:46 |
| opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add network update quota "limit_check" parameter https://review.opendev.org/c/openstack/python-openstackclient/+/806016 | 17:50 |
| opendevreview | Thobias Trevisan proposed openstack/python-openstackclient master: compute: Add 'Security Groups' for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/819368 | 19:24 |
| opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | 23:39 |
| opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | 23:49 |
| opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!