| opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server suspend and server resume to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817860 | 00:23 |
|---|---|---|
| opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server suspend and server resume to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817860 | 00:33 |
| opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server suspend and server resume to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817860 | 00:35 |
| *** brinzhang_ is now known as brinzhang | 07:26 | |
| thomasb06 | gtema: Hello. The Compute service is still messy: https://review.opendev.org/c/openstack/openstacksdk/+/816785 | 08:02 |
| thomasb06 | Should I abandon it, pull the remote and reindent the docstring? | 08:03 |
| thomasb06 | These two services are ready: https://review.opendev.org/c/openstack/openstacksdk/+/816619 and https://review.opendev.org/c/openstack/openstacksdk/+/816307 | 08:03 |
| gtema | yes, this is perhaps the easiest. But when you do new commit simply reuse commit message (including change-id). Then you do not need to abandon/produce new change | 08:05 |
| thomasb06 | from my computer, I don't know how to find the Compute commit to amend it. Is there a command to see the full working tree? | 08:12 |
| gtema | just copy it from the UI: full change description | 08:12 |
| gtema | """Compute - reindentation of the docstrings | 08:13 |
| gtema | Change-Id: Iee76170382faf13c584fa215ef9dbe94de805d32""" | 08:13 |
| thomasb06 | Ah, I add the Change-Id in the commit message? | 08:13 |
| gtema | you just take this full message as the new commit | 08:13 |
| thomasb06 | understood | 08:14 |
| thomasb06 | Here it is: https://review.opendev.org/c/openstack/openstacksdk/+/818202 | 08:21 |
| thomasb06 | Is it ok, it looks weird to have two ChangeIds in the UI? | 08:39 |
| gtema | you should have only one | 08:39 |
| gtema | you produced new change. I think your hook has not properly identified change-id in the commit (maybe missing line break) | 08:40 |
| gtema | in this case just drop the original id in the new change and abandon the old one | 08:41 |
| thomasb06 | you were right, it was just a newline missing. The old one is fine now: https://review.opendev.org/c/openstack/openstacksdk/+/816785 | 08:46 |
| thomasb06 | If it's ok for you, I can delete the new commit? | 08:46 |
| thomasb06 | (which is 818202) | 08:47 |
| gtema | yupp, can be | 08:50 |
| thomasb06 | Unless I forgot some _proxy.py files, this it is. Would you have other docstrings to fix, my script is ready? | 08:58 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: image: Remove dead test helper methods https://review.opendev.org/c/openstack/python-openstackclient/+/818223 | 11:42 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: image: Remove FakeImage test helper https://review.opendev.org/c/openstack/python-openstackclient/+/818224 | 11:42 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Update fake image client in tests https://review.opendev.org/c/openstack/python-openstackclient/+/818225 | 11:42 |
| opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: image: Sanity check the 'SetImage' command https://review.opendev.org/c/openstack/python-openstackclient/+/818226 | 11:42 |
| opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server add volume to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815919 | 14:08 |
| opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server add volume to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815919 | 19:21 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!